[jira] [Commented] (HUDI-617) Add support for data types convertible to String in TimestampBasedKeyGenerator

2020-03-13 Thread Amit Singh (Jira)
[ https://issues.apache.org/jira/browse/HUDI-617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17059178#comment-17059178 ] Amit Singh commented on HUDI-617: - So far I have not applied for any contribution permission. [~yanghua] >

[GitHub] [incubator-hudi] xushiyan commented on issue #1404: [HUDI-344] Improve exporter tests

2020-03-13 Thread GitBox
xushiyan commented on issue #1404: [HUDI-344] Improve exporter tests URL: https://github.com/apache/incubator-hudi/pull/1404#issuecomment-599007254 @leesf This is ready for review. Thanks. This is an automated message from

Build failed in Jenkins: hudi-snapshot-deployment-0.5 #216

2020-03-13 Thread Apache Jenkins Server
See Changes: -- [...truncated 2.38 KB...] /home/jenkins/tools/maven/apache-maven-3.5.4/conf: logging settings.xml toolchains.xml

[GitHub] [incubator-hudi] codecov-io edited a comment on issue #1404: [HUDI-344] Improve exporter tests

2020-03-13 Thread GitBox
codecov-io edited a comment on issue #1404: [HUDI-344] Improve exporter tests URL: https://github.com/apache/incubator-hudi/pull/1404#issuecomment-598999825 # [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1404?src=pr=h1) Report > Merging

[GitHub] [incubator-hudi] codecov-io edited a comment on issue #1404: [HUDI-344] Improve exporter tests

2020-03-13 Thread GitBox
codecov-io edited a comment on issue #1404: [HUDI-344] Improve exporter tests URL: https://github.com/apache/incubator-hudi/pull/1404#issuecomment-598999825 # [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1404?src=pr=h1) Report > Merging

[GitHub] [incubator-hudi] codecov-io commented on issue #1404: [HUDI-344] Improve exporter tests

2020-03-13 Thread GitBox
codecov-io commented on issue #1404: [HUDI-344] Improve exporter tests URL: https://github.com/apache/incubator-hudi/pull/1404#issuecomment-598999825 # [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1404?src=pr=h1) Report > Merging

[GitHub] [incubator-hudi] codecov-io edited a comment on issue #1159: [HUDI-479] Eliminate or Minimize use of Guava if possible

2020-03-13 Thread GitBox
codecov-io edited a comment on issue #1159: [HUDI-479] Eliminate or Minimize use of Guava if possible URL: https://github.com/apache/incubator-hudi/pull/1159#issuecomment-596089314 # [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1159?src=pr=h1) Report > Merging

[GitHub] [incubator-hudi] codecov-io edited a comment on issue #1159: [HUDI-479] Eliminate or Minimize use of Guava if possible

2020-03-13 Thread GitBox
codecov-io edited a comment on issue #1159: [HUDI-479] Eliminate or Minimize use of Guava if possible URL: https://github.com/apache/incubator-hudi/pull/1159#issuecomment-596089314 # [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1159?src=pr=h1) Report > Merging

[GitHub] [incubator-hudi] xushiyan commented on a change in pull request #1404: [HUDI-344] Improve exporter tests

2020-03-13 Thread GitBox
xushiyan commented on a change in pull request #1404: [HUDI-344] Improve exporter tests URL: https://github.com/apache/incubator-hudi/pull/1404#discussion_r392539180 ## File path: hudi-utilities/src/test/java/org/apache/hudi/utilities/DataSourceTestUtils.java ## @@ -1,50

[GitHub] [incubator-hudi] xushiyan commented on a change in pull request #1404: [HUDI-344] Improve exporter tests

2020-03-13 Thread GitBox
xushiyan commented on a change in pull request #1404: [HUDI-344] Improve exporter tests URL: https://github.com/apache/incubator-hudi/pull/1404#discussion_r392539398 ## File path: hudi-utilities/src/test/java/org/apache/hudi/utilities/TestHoodieSnapshotExporter.java ##

[GitHub] [incubator-hudi] xushiyan opened a new pull request #1404: [HUDI-344] Improve exporter tests

2020-03-13 Thread GitBox
xushiyan opened a new pull request #1404: [HUDI-344] Improve exporter tests URL: https://github.com/apache/incubator-hudi/pull/1404 ## What is the purpose of the pull request - Use `HoodieWriteClient` to prepare data for testing. ## Verify this pull request This change

[jira] [Updated] (HUDI-629) Replace Guava's Hashing with an equivalent in NumericUtils.java

2020-03-13 Thread Suneel Marthi (Jira)
[ https://issues.apache.org/jira/browse/HUDI-629?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suneel Marthi updated HUDI-629: --- Status: Closed (was: Patch Available) > Replace Guava's Hashing with an equivalent in

[jira] [Updated] (HUDI-629) Replace Guava's Hashing with an equivalent in NumericUtils.java

2020-03-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HUDI-629?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HUDI-629: Labels: pull-request-available (was: ) > Replace Guava's Hashing with an equivalent in

[GitHub] [incubator-hudi] smarthi merged pull request #1350: [HUDI-629]: Replace Guava's Hashing with an equivalent in NumericUtils.java

2020-03-13 Thread GitBox
smarthi merged pull request #1350: [HUDI-629]: Replace Guava's Hashing with an equivalent in NumericUtils.java URL: https://github.com/apache/incubator-hudi/pull/1350 This is an automated message from the Apache Git

[incubator-hudi] branch master updated: [HUDI-629]: Replace Guava's Hashing with an equivalent in NumericUtils.java (#1350)

2020-03-13 Thread smarthi
This is an automated email from the ASF dual-hosted git repository. smarthi pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-hudi.git The following commit(s) were added to refs/heads/master by this push: new 99b7e9e [HUDI-629]: Replace Guava's

[GitHub] [incubator-hudi] codecov-io edited a comment on issue #1350: [HUDI-629]: Replace Guava's Hashing with an equivalent in NumericUtils.java

2020-03-13 Thread GitBox
codecov-io edited a comment on issue #1350: [HUDI-629]: Replace Guava's Hashing with an equivalent in NumericUtils.java URL: https://github.com/apache/incubator-hudi/pull/1350#issuecomment-59868 # [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1350?src=pr=h1) Report >

[GitHub] [incubator-hudi] lamber-ken edited a comment on issue #1402: [WIP][HUDI-407] Adding Simple Index

2020-03-13 Thread GitBox
lamber-ken edited a comment on issue #1402: [WIP][HUDI-407] Adding Simple Index URL: https://github.com/apache/incubator-hudi/pull/1402#issuecomment-598977914 @nsivabalan, I think this is a great addtition.  I have the same idea, but didn't realizate it all. Another topic, if

[GitHub] [incubator-hudi] lamber-ken commented on issue #1402: [WIP][HUDI-407] Adding Simple Index

2020-03-13 Thread GitBox
lamber-ken commented on issue #1402: [WIP][HUDI-407] Adding Simple Index URL: https://github.com/apache/incubator-hudi/pull/1402#issuecomment-598977914 @nsivabalan, I think this is a great addtition.  I have the same idea, but didn't realizate it all.

[GitHub] [incubator-hudi] lamber-ken commented on issue #1373: [HUDI-646] Re-enable TestUpdateSchemaEvolution to reproduce CI error

2020-03-13 Thread GitBox
lamber-ken commented on issue #1373: [HUDI-646] Re-enable TestUpdateSchemaEvolution to reproduce CI error URL: https://github.com/apache/incubator-hudi/pull/1373#issuecomment-598975216 > @lamber-ken nonetheless. I agree with your analysis.. Lets see if this build passes.. > This is

[jira] [Commented] (HUDI-83) Map Timestamp type in spark to corresponding Timestamp type in Hive during Hive sync

2020-03-13 Thread Udit Mehrotra (Jira)
[ https://issues.apache.org/jira/browse/HUDI-83?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17059103#comment-17059103 ] Udit Mehrotra commented on HUDI-83: --- Updated the Jira title to more accurately reflect what it is for, >

[jira] [Updated] (HUDI-83) Map Timestamp type in spark to corresponding Timestamp type in Hive during Hive sync

2020-03-13 Thread Udit Mehrotra (Jira)
[ https://issues.apache.org/jira/browse/HUDI-83?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Udit Mehrotra updated HUDI-83: -- Component/s: Hive Integration > Map Timestamp type in spark to corresponding Timestamp type in Hive

[jira] [Updated] (HUDI-83) Map Timestamp type in spark to corresponding Timestamp type in Hive during Hive sync

2020-03-13 Thread Udit Mehrotra (Jira)
[ https://issues.apache.org/jira/browse/HUDI-83?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Udit Mehrotra updated HUDI-83: -- Summary: Map Timestamp type in spark to corresponding Timestamp type in Hive during Hive sync (was:

[jira] [Commented] (HUDI-83) Support for timestamp datatype in Hudi

2020-03-13 Thread Udit Mehrotra (Jira)
[ https://issues.apache.org/jira/browse/HUDI-83?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17059099#comment-17059099 ] Udit Mehrotra commented on HUDI-83: --- [~arw357] Timestamp type is supported while writing through spark and

[GitHub] [incubator-hudi] smarthi commented on a change in pull request #1350: [HUDI-629]: Replace Guava's Hashing with an equivalent in NumericUtils.java

2020-03-13 Thread GitBox
smarthi commented on a change in pull request #1350: [HUDI-629]: Replace Guava's Hashing with an equivalent in NumericUtils.java URL: https://github.com/apache/incubator-hudi/pull/1350#discussion_r392467151 ## File path:

[GitHub] [incubator-hudi] satishkotha commented on a change in pull request #1396: [HUDI-687] Stop incremental reader on RO table before a pending compaction

2020-03-13 Thread GitBox
satishkotha commented on a change in pull request #1396: [HUDI-687] Stop incremental reader on RO table before a pending compaction URL: https://github.com/apache/incubator-hudi/pull/1396#discussion_r392436908 ## File path:

[GitHub] [incubator-hudi] satishkotha commented on a change in pull request #1396: [HUDI-687] Stop incremental reader on RO table before a pending compaction

2020-03-13 Thread GitBox
satishkotha commented on a change in pull request #1396: [HUDI-687] Stop incremental reader on RO table before a pending compaction URL: https://github.com/apache/incubator-hudi/pull/1396#discussion_r392436855 ## File path:

[GitHub] [incubator-hudi] satishkotha commented on a change in pull request #1396: [HUDI-687] Stop incremental reader on RO table before a pending compaction

2020-03-13 Thread GitBox
satishkotha commented on a change in pull request #1396: [HUDI-687] Stop incremental reader on RO table before a pending compaction URL: https://github.com/apache/incubator-hudi/pull/1396#discussion_r392436461 ## File path:

[GitHub] [incubator-hudi] satishkotha commented on a change in pull request #1396: [HUDI-687] Stop incremental reader on RO table before a pending compaction

2020-03-13 Thread GitBox
satishkotha commented on a change in pull request #1396: [HUDI-687] Stop incremental reader on RO table before a pending compaction URL: https://github.com/apache/incubator-hudi/pull/1396#discussion_r392436630 ## File path:

[GitHub] [incubator-hudi] prashantwason commented on a change in pull request #1395: [HUDI-667] Fixing delete tests for DeltaStreamer

2020-03-13 Thread GitBox
prashantwason commented on a change in pull request #1395: [HUDI-667] Fixing delete tests for DeltaStreamer URL: https://github.com/apache/incubator-hudi/pull/1395#discussion_r392403324 ## File path: hudi-client/src/test/java/org/apache/hudi/common/HoodieTestDataGenerator.java

[GitHub] [incubator-hudi] smarthi commented on a change in pull request #1350: [HUDI-629]: Replace Guava's Hashing with an equivalent in NumericUtils.java

2020-03-13 Thread GitBox
smarthi commented on a change in pull request #1350: [HUDI-629]: Replace Guava's Hashing with an equivalent in NumericUtils.java URL: https://github.com/apache/incubator-hudi/pull/1350#discussion_r392151737 ## File path:

[jira] [Resolved] (HUDI-667) HoodieTestDataGenerator does not delete keys correctly

2020-03-13 Thread sivabalan narayanan (Jira)
[ https://issues.apache.org/jira/browse/HUDI-667?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] sivabalan narayanan resolved HUDI-667. -- Fix Version/s: 0.6.0 Resolution: Fixed > HoodieTestDataGenerator does not delete

[jira] [Assigned] (HUDI-667) HoodieTestDataGenerator does not delete keys correctly

2020-03-13 Thread sivabalan narayanan (Jira)
[ https://issues.apache.org/jira/browse/HUDI-667?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] sivabalan narayanan reassigned HUDI-667: Assignee: sivabalan narayanan > HoodieTestDataGenerator does not delete keys

[jira] [Commented] (HUDI-667) HoodieTestDataGenerator does not delete keys correctly

2020-03-13 Thread sivabalan narayanan (Jira)
[ https://issues.apache.org/jira/browse/HUDI-667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17058905#comment-17058905 ] sivabalan narayanan commented on HUDI-667: -- thanks Pratyaksh for responding. [~pwason] : Yes, the

[GitHub] [incubator-hudi] bvaradar opened a new pull request #1403: [HUDI-710] Fixing failure in Staging Validation Script

2020-03-13 Thread GitBox
bvaradar opened a new pull request #1403: [HUDI-710] Fixing failure in Staging Validation Script URL: https://github.com/apache/incubator-hudi/pull/1403 Works after fixing the issue. ./release/validate_staged_release.sh --release=0.5.2 --rc_num=1 /tmp/validation_scratch_dir_001

[jira] [Updated] (HUDI-710) Fixing failure in Staging Validation Script

2020-03-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HUDI-710?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HUDI-710: Labels: pull-request-available (was: ) > Fixing failure in Staging Validation Script >

[jira] [Created] (HUDI-710) Fixing failure in Staging Validation Script

2020-03-13 Thread Balaji Varadarajan (Jira)
Balaji Varadarajan created HUDI-710: --- Summary: Fixing failure in Staging Validation Script Key: HUDI-710 URL: https://issues.apache.org/jira/browse/HUDI-710 Project: Apache Hudi (incubating)

[jira] [Updated] (HUDI-710) Fixing failure in Staging Validation Script

2020-03-13 Thread Balaji Varadarajan (Jira)
[ https://issues.apache.org/jira/browse/HUDI-710?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Balaji Varadarajan updated HUDI-710: Status: Open (was: New) > Fixing failure in Staging Validation Script >

[GitHub] [incubator-hudi] vinothchandar commented on a change in pull request #1350: [HUDI-629]: Replace Guava's Hashing with an equivalent in NumericUtils.java

2020-03-13 Thread GitBox
vinothchandar commented on a change in pull request #1350: [HUDI-629]: Replace Guava's Hashing with an equivalent in NumericUtils.java URL: https://github.com/apache/incubator-hudi/pull/1350#discussion_r392321048 ## File path:

[GitHub] [incubator-hudi] vinothchandar commented on a change in pull request #1350: [HUDI-629]: Replace Guava's Hashing with an equivalent in NumericUtils.java

2020-03-13 Thread GitBox
vinothchandar commented on a change in pull request #1350: [HUDI-629]: Replace Guava's Hashing with an equivalent in NumericUtils.java URL: https://github.com/apache/incubator-hudi/pull/1350#discussion_r392321862 ## File path:

[GitHub] [incubator-hudi] vinothchandar commented on a change in pull request #1350: [HUDI-629]: Replace Guava's Hashing with an equivalent in NumericUtils.java

2020-03-13 Thread GitBox
vinothchandar commented on a change in pull request #1350: [HUDI-629]: Replace Guava's Hashing with an equivalent in NumericUtils.java URL: https://github.com/apache/incubator-hudi/pull/1350#discussion_r392322279 ## File path:

[GitHub] [incubator-hudi] vinothchandar commented on a change in pull request #1350: [HUDI-629]: Replace Guava's Hashing with an equivalent in NumericUtils.java

2020-03-13 Thread GitBox
vinothchandar commented on a change in pull request #1350: [HUDI-629]: Replace Guava's Hashing with an equivalent in NumericUtils.java URL: https://github.com/apache/incubator-hudi/pull/1350#discussion_r392320176 ## File path:

[GitHub] [incubator-hudi] smarthi commented on a change in pull request #1350: [HUDI-629]: Replace Guava's Hashing with an equivalent in NumericUtils.java

2020-03-13 Thread GitBox
smarthi commented on a change in pull request #1350: [HUDI-629]: Replace Guava's Hashing with an equivalent in NumericUtils.java URL: https://github.com/apache/incubator-hudi/pull/1350#discussion_r392211319 ## File path:

[jira] [Comment Edited] (HUDI-83) Support for timestamp datatype in Hudi

2020-03-13 Thread Cosmin Iordache (Jira)
[ https://issues.apache.org/jira/browse/HUDI-83?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17058635#comment-17058635 ] Cosmin Iordache edited comment on HUDI-83 at 3/13/20, 11:13 AM: I was

[GitHub] [incubator-hudi] codecov-io commented on issue #1174: [HUDI-96]: Implemented command line options instead of positional arguments for CLI commands

2020-03-13 Thread GitBox
codecov-io commented on issue #1174: [HUDI-96]: Implemented command line options instead of positional arguments for CLI commands URL: https://github.com/apache/incubator-hudi/pull/1174#issuecomment-598671510 # [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1174?src=pr=h1)

[jira] [Comment Edited] (HUDI-83) Support for timestamp datatype in Hudi

2020-03-13 Thread Cosmin Iordache (Jira)
[ https://issues.apache.org/jira/browse/HUDI-83?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17058635#comment-17058635 ] Cosmin Iordache edited comment on HUDI-83 at 3/13/20, 11:11 AM: I was

[jira] [Comment Edited] (HUDI-83) Support for timestamp datatype in Hudi

2020-03-13 Thread Cosmin Iordache (Jira)
[ https://issues.apache.org/jira/browse/HUDI-83?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17058635#comment-17058635 ] Cosmin Iordache edited comment on HUDI-83 at 3/13/20, 11:06 AM: I was

[jira] [Commented] (HUDI-83) Support for timestamp datatype in Hudi

2020-03-13 Thread Cosmin Iordache (Jira)
[ https://issues.apache.org/jira/browse/HUDI-83?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17058635#comment-17058635 ] Cosmin Iordache commented on HUDI-83: - I was looking at how hudi saves data with spark-2.4.4 and things

[GitHub] [incubator-hudi] smarthi commented on a change in pull request #1350: [HUDI-629]: Replace Guava's Hashing with an equivalent in NumericUtils.java

2020-03-13 Thread GitBox
smarthi commented on a change in pull request #1350: [HUDI-629]: Replace Guava's Hashing with an equivalent in NumericUtils.java URL: https://github.com/apache/incubator-hudi/pull/1350#discussion_r392154852 ## File path:

[GitHub] [incubator-hudi] smarthi commented on a change in pull request #1350: [HUDI-629]: Replace Guava's Hashing with an equivalent in NumericUtils.java

2020-03-13 Thread GitBox
smarthi commented on a change in pull request #1350: [HUDI-629]: Replace Guava's Hashing with an equivalent in NumericUtils.java URL: https://github.com/apache/incubator-hudi/pull/1350#discussion_r392151737 ## File path:

[jira] [Commented] (HUDI-603) HoodieDeltaStreamer should periodically fetch table schema update

2020-03-13 Thread Pratyaksh Sharma (Jira)
[ https://issues.apache.org/jira/browse/HUDI-603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17058606#comment-17058606 ] Pratyaksh Sharma commented on HUDI-603: --- I guess updating it at the start of every deltaSync loop

[jira] [Commented] (HUDI-93) Enforce semantics on HoodieRecordPayload to allow for a consistent instantiation of custom payloads via reflection

2020-03-13 Thread Pratyaksh Sharma (Jira)
[ https://issues.apache.org/jira/browse/HUDI-93?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17058590#comment-17058590 ] Pratyaksh Sharma commented on HUDI-93: -- [~xleesf] [~nishith29] How do we plan to go ahead with this?

[GitHub] [incubator-hudi] pratyakshsharma commented on a change in pull request #1395: [HUDI-667] Fixing delete tests for DeltaStreamer

2020-03-13 Thread GitBox
pratyakshsharma commented on a change in pull request #1395: [HUDI-667] Fixing delete tests for DeltaStreamer URL: https://github.com/apache/incubator-hudi/pull/1395#discussion_r392120925 ## File path: hudi-client/src/test/java/org/apache/hudi/common/HoodieTestDataGenerator.java

[jira] [Commented] (HUDI-667) HoodieTestDataGenerator does not delete keys correctly

2020-03-13 Thread Pratyaksh Sharma (Jira)
[ https://issues.apache.org/jira/browse/HUDI-667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17058557#comment-17058557 ] Pratyaksh Sharma commented on HUDI-667: --- This has been fixed in 

[jira] [Issue Comment Deleted] (HUDI-667) HoodieTestDataGenerator does not delete keys correctly

2020-03-13 Thread Pratyaksh Sharma (Jira)
[ https://issues.apache.org/jira/browse/HUDI-667?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pratyaksh Sharma updated HUDI-667: -- Comment: was deleted (was: Ok, let me try to fix this in my current PR. 

[jira] [Commented] (HUDI-667) HoodieTestDataGenerator does not delete keys correctly

2020-03-13 Thread Pratyaksh Sharma (Jira)
[ https://issues.apache.org/jira/browse/HUDI-667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17058541#comment-17058541 ] Pratyaksh Sharma commented on HUDI-667: --- Ok, let me try to fix this in my current PR. 

[GitHub] [incubator-hudi] vinothchandar merged pull request #1373: [HUDI-646] Re-enable TestUpdateSchemaEvolution to reproduce CI error

2020-03-13 Thread GitBox
vinothchandar merged pull request #1373: [HUDI-646] Re-enable TestUpdateSchemaEvolution to reproduce CI error URL: https://github.com/apache/incubator-hudi/pull/1373 This is an automated message from the Apache Git Service.

[incubator-hudi] branch master updated: [HUDI-646] fix failing test due to improper filesytem cleanup (#1373)

2020-03-13 Thread vinoth
This is an automated email from the ASF dual-hosted git repository. vinoth pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-hudi.git The following commit(s) were added to refs/heads/master by this push: new fb7fba3 [HUDI-646] fix failing test

[GitHub] [incubator-hudi] vinothchandar commented on a change in pull request #1402: [HUDI-407] Adding Simple Index

2020-03-13 Thread GitBox
vinothchandar commented on a change in pull request #1402: [HUDI-407] Adding Simple Index URL: https://github.com/apache/incubator-hudi/pull/1402#discussion_r392050022 ## File path: hudi-client/src/main/java/org/apache/hudi/index/HoodieIndex.java ## @@ -77,15 +80,15 @@

[GitHub] [incubator-hudi] vinothchandar commented on a change in pull request #1402: [HUDI-407] Adding Simple Index

2020-03-13 Thread GitBox
vinothchandar commented on a change in pull request #1402: [HUDI-407] Adding Simple Index URL: https://github.com/apache/incubator-hudi/pull/1402#discussion_r392057436 ## File path: hudi-client/src/main/java/org/apache/hudi/index/bloom/HoodieSimpleIndex.java ## @@ -0,0

[GitHub] [incubator-hudi] vinothchandar commented on a change in pull request #1402: [HUDI-407] Adding Simple Index

2020-03-13 Thread GitBox
vinothchandar commented on a change in pull request #1402: [HUDI-407] Adding Simple Index URL: https://github.com/apache/incubator-hudi/pull/1402#discussion_r392057776 ## File path: hudi-client/src/main/java/org/apache/hudi/index/bloom/HoodieSimpleIndex.java ## @@ -0,0

[GitHub] [incubator-hudi] vinothchandar commented on a change in pull request #1402: [HUDI-407] Adding Simple Index

2020-03-13 Thread GitBox
vinothchandar commented on a change in pull request #1402: [HUDI-407] Adding Simple Index URL: https://github.com/apache/incubator-hudi/pull/1402#discussion_r392056483 ## File path: hudi-client/src/main/java/org/apache/hudi/index/bloom/HoodieSimpleIndex.java ## @@ -0,0

[GitHub] [incubator-hudi] vinothchandar commented on a change in pull request #1402: [HUDI-407] Adding Simple Index

2020-03-13 Thread GitBox
vinothchandar commented on a change in pull request #1402: [HUDI-407] Adding Simple Index URL: https://github.com/apache/incubator-hudi/pull/1402#discussion_r392057624 ## File path: hudi-client/src/main/java/org/apache/hudi/index/HoodieIndex.java ## @@ -118,9 +121,10 @@

[GitHub] [incubator-hudi] vinothchandar commented on a change in pull request #1402: [HUDI-407] Adding Simple Index

2020-03-13 Thread GitBox
vinothchandar commented on a change in pull request #1402: [HUDI-407] Adding Simple Index URL: https://github.com/apache/incubator-hudi/pull/1402#discussion_r392057064 ## File path: hudi-client/src/main/java/org/apache/hudi/index/bloom/HoodieSimpleIndex.java ## @@ -0,0

[GitHub] [incubator-hudi] vinothchandar commented on a change in pull request #1402: [HUDI-407] Adding Simple Index

2020-03-13 Thread GitBox
vinothchandar commented on a change in pull request #1402: [HUDI-407] Adding Simple Index URL: https://github.com/apache/incubator-hudi/pull/1402#discussion_r392056996 ## File path: hudi-client/src/main/java/org/apache/hudi/index/bloom/HoodieSimpleIndex.java ## @@ -0,0

[GitHub] [incubator-hudi] vinothchandar commented on a change in pull request #1402: [HUDI-407] Adding Simple Index

2020-03-13 Thread GitBox
vinothchandar commented on a change in pull request #1402: [HUDI-407] Adding Simple Index URL: https://github.com/apache/incubator-hudi/pull/1402#discussion_r392056290 ## File path: hudi-client/src/main/java/org/apache/hudi/index/bloom/HoodieSimpleIndex.java ## @@ -0,0

[GitHub] [incubator-hudi] vinothchandar commented on a change in pull request #1402: [HUDI-407] Adding Simple Index

2020-03-13 Thread GitBox
vinothchandar commented on a change in pull request #1402: [HUDI-407] Adding Simple Index URL: https://github.com/apache/incubator-hudi/pull/1402#discussion_r392055143 ## File path: hudi-client/src/main/java/org/apache/hudi/index/bloom/HoodieSimpleIndex.java ## @@ -0,0

[GitHub] [incubator-hudi] vinothchandar commented on a change in pull request #1402: [HUDI-407] Adding Simple Index

2020-03-13 Thread GitBox
vinothchandar commented on a change in pull request #1402: [HUDI-407] Adding Simple Index URL: https://github.com/apache/incubator-hudi/pull/1402#discussion_r392055088 ## File path: hudi-client/src/main/java/org/apache/hudi/index/bloom/HoodieSimpleIndex.java ## @@ -0,0

[GitHub] [incubator-hudi] codecov-io edited a comment on issue #1373: [WIP] [HUDI-646] Re-enable TestUpdateSchemaEvolution to reproduce CI error

2020-03-13 Thread GitBox
codecov-io edited a comment on issue #1373: [WIP] [HUDI-646] Re-enable TestUpdateSchemaEvolution to reproduce CI error URL: https://github.com/apache/incubator-hudi/pull/1373#issuecomment-598574814 # [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1373?src=pr=h1) Report >

[GitHub] [incubator-hudi] codecov-io commented on issue #1373: [WIP] [HUDI-646] Re-enable TestUpdateSchemaEvolution to reproduce CI error

2020-03-13 Thread GitBox
codecov-io commented on issue #1373: [WIP] [HUDI-646] Re-enable TestUpdateSchemaEvolution to reproduce CI error URL: https://github.com/apache/incubator-hudi/pull/1373#issuecomment-598574814 # [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1373?src=pr=h1) Report > Merging

[GitHub] [incubator-hudi] vinothchandar commented on a change in pull request #1350: [HUDI-629]: Replace Guava's Hashing with an equivalent in NumericUtils.java

2020-03-13 Thread GitBox
vinothchandar commented on a change in pull request #1350: [HUDI-629]: Replace Guava's Hashing with an equivalent in NumericUtils.java URL: https://github.com/apache/incubator-hudi/pull/1350#discussion_r392047055 ## File path:

[GitHub] [incubator-hudi] vinothchandar commented on a change in pull request #1350: [HUDI-629]: Replace Guava's Hashing with an equivalent in NumericUtils.java

2020-03-13 Thread GitBox
vinothchandar commented on a change in pull request #1350: [HUDI-629]: Replace Guava's Hashing with an equivalent in NumericUtils.java URL: https://github.com/apache/incubator-hudi/pull/1350#discussion_r392047003 ## File path:

[GitHub] [incubator-hudi] vinothchandar commented on a change in pull request #1350: [HUDI-629]: Replace Guava's Hashing with an equivalent in NumericUtils.java

2020-03-13 Thread GitBox
vinothchandar commented on a change in pull request #1350: [HUDI-629]: Replace Guava's Hashing with an equivalent in NumericUtils.java URL: https://github.com/apache/incubator-hudi/pull/1350#discussion_r392047856 ## File path:

[GitHub] [incubator-hudi] vinothchandar commented on issue #1373: [WIP] [HUDI-646] Re-enable TestUpdateSchemaEvolution to reproduce CI error

2020-03-13 Thread GitBox
vinothchandar commented on issue #1373: [WIP] [HUDI-646] Re-enable TestUpdateSchemaEvolution to reproduce CI error URL: https://github.com/apache/incubator-hudi/pull/1373#issuecomment-598567320 @lamber-ken nonetheless. I agree with your analysis.. Lets see if this build passes.. This

[GitHub] [incubator-hudi] vinothchandar commented on issue #1400: optimization debian package manager tweaks

2020-03-13 Thread GitBox
vinothchandar commented on issue #1400: optimization debian package manager tweaks URL: https://github.com/apache/incubator-hudi/pull/1400#issuecomment-598566156 @Rajpratik71 also please raise a JIRA for this work! This is

[GitHub] [incubator-hudi] vinothchandar commented on a change in pull request #1396: [HUDI-687] Stop incremental reader on RO table before a pending compaction

2020-03-13 Thread GitBox
vinothchandar commented on a change in pull request #1396: [HUDI-687] Stop incremental reader on RO table before a pending compaction URL: https://github.com/apache/incubator-hudi/pull/1396#discussion_r392043054 ## File path:

[GitHub] [incubator-hudi] vinothchandar commented on a change in pull request #1396: [HUDI-687] Stop incremental reader on RO table before a pending compaction

2020-03-13 Thread GitBox
vinothchandar commented on a change in pull request #1396: [HUDI-687] Stop incremental reader on RO table before a pending compaction URL: https://github.com/apache/incubator-hudi/pull/1396#discussion_r392043240 ## File path:

[GitHub] [incubator-hudi] vinothchandar commented on a change in pull request #1396: [HUDI-687] Stop incremental reader on RO table before a pending compaction

2020-03-13 Thread GitBox
vinothchandar commented on a change in pull request #1396: [HUDI-687] Stop incremental reader on RO table before a pending compaction URL: https://github.com/apache/incubator-hudi/pull/1396#discussion_r392043404 ## File path:

[GitHub] [incubator-hudi] vinothchandar commented on a change in pull request #1396: [HUDI-687] Stop incremental reader on RO table before a pending compaction

2020-03-13 Thread GitBox
vinothchandar commented on a change in pull request #1396: [HUDI-687] Stop incremental reader on RO table before a pending compaction URL: https://github.com/apache/incubator-hudi/pull/1396#discussion_r392043150 ## File path:

[GitHub] [incubator-hudi] vinothchandar commented on a change in pull request #1396: [HUDI-687] Stop incremental reader on RO table before a pending compaction

2020-03-13 Thread GitBox
vinothchandar commented on a change in pull request #1396: [HUDI-687] Stop incremental reader on RO table before a pending compaction URL: https://github.com/apache/incubator-hudi/pull/1396#discussion_r392042671 ## File path: