[jira] [Updated] (HUDI-725) Remove or rewrite init log in DeltaSync

2020-03-19 Thread wangxianghu (Jira)
[ https://issues.apache.org/jira/browse/HUDI-725?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] wangxianghu updated HUDI-725: - Description: When initializing HoodieDeltaStreamer, DeltaSyncService and DeltaSync are initialized in

[jira] [Updated] (HUDI-726) Delete unused method in HoodieDeltaStreamer

2020-03-19 Thread wangxianghu (Jira)
[ https://issues.apache.org/jira/browse/HUDI-726?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] wangxianghu updated HUDI-726: - Description: It seems that this method

[jira] [Updated] (HUDI-726) Delete unused method in HoodieDeltaStreamer

2020-03-19 Thread wangxianghu (Jira)
[ https://issues.apache.org/jira/browse/HUDI-726?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] wangxianghu updated HUDI-726: - Description: It seems that this method

[jira] [Commented] (HUDI-726) Delete unused method in HoodieDeltaStreamer

2020-03-19 Thread wangxianghu (Jira)
[ https://issues.apache.org/jira/browse/HUDI-726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17063105#comment-17063105 ] wangxianghu commented on HUDI-726: -- [~vinoth] what do you think ? > Delete unused method in

[jira] [Commented] (HUDI-725) Remove or rewrite init log in DeltaSync

2020-03-19 Thread wangxianghu (Jira)
[ https://issues.apache.org/jira/browse/HUDI-725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17063104#comment-17063104 ] wangxianghu commented on HUDI-725: -- [~vinoth] what do you think ? > Remove or rewrite init log in

[jira] [Created] (HUDI-726) Delete unused method in HoodieDeltaStreamer

2020-03-19 Thread wangxianghu (Jira)
wangxianghu created HUDI-726: Summary: Delete unused method in HoodieDeltaStreamer Key: HUDI-726 URL: https://issues.apache.org/jira/browse/HUDI-726 Project: Apache Hudi (incubating) Issue Type:

[GitHub] [incubator-hudi] ffcchi commented on a change in pull request #1421: [HUDI-724] Parallelize getSmallFiles for partitions

2020-03-19 Thread GitBox
ffcchi commented on a change in pull request #1421: [HUDI-724] Parallelize getSmallFiles for partitions URL: https://github.com/apache/incubator-hudi/pull/1421#discussion_r395433296 ## File path: hudi-client/src/main/java/org/apache/hudi/table/HoodieCopyOnWriteTable.java

[GitHub] [incubator-hudi] ffcchi commented on a change in pull request #1421: [HUDI-724] Parallelize getSmallFiles for partitions

2020-03-19 Thread GitBox
ffcchi commented on a change in pull request #1421: [HUDI-724] Parallelize getSmallFiles for partitions URL: https://github.com/apache/incubator-hudi/pull/1421#discussion_r395433104 ## File path: hudi-client/src/main/java/org/apache/hudi/table/HoodieCopyOnWriteTable.java

[GitHub] [incubator-hudi] ffcchi commented on a change in pull request #1421: [HUDI-724] Parallelize getSmallFiles for partitions

2020-03-19 Thread GitBox
ffcchi commented on a change in pull request #1421: [HUDI-724] Parallelize getSmallFiles for partitions URL: https://github.com/apache/incubator-hudi/pull/1421#discussion_r395432973 ## File path: hudi-client/src/main/java/org/apache/hudi/table/HoodieMergeOnReadTable.java

Build failed in Jenkins: hudi-snapshot-deployment-0.5 #222

2020-03-19 Thread Apache Jenkins Server
See Changes: -- [...truncated 2.37 KB...] /home/jenkins/tools/maven/apache-maven-3.5.4/conf: logging settings.xml toolchains.xml

[jira] [Updated] (HUDI-725) Remove or rewrite init log in DeltaSync

2020-03-19 Thread wangxianghu (Jira)
[ https://issues.apache.org/jira/browse/HUDI-725?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] wangxianghu updated HUDI-725: - Description: When initializing HoodieDeltaStreamer, DeltaSyncService and DeltaSync are initialized in

[jira] [Created] (HUDI-725) Remove or rewrite init log in DeltaSync

2020-03-19 Thread wangxianghu (Jira)
wangxianghu created HUDI-725: Summary: Remove or rewrite init log in DeltaSync Key: HUDI-725 URL: https://issues.apache.org/jira/browse/HUDI-725 Project: Apache Hudi (incubating) Issue Type:

[GitHub] [incubator-hudi] codecov-io commented on issue #1422: [HUDI-400]check upgrade from old plan to new plan for compaction

2020-03-19 Thread GitBox
codecov-io commented on issue #1422: [HUDI-400]check upgrade from old plan to new plan for compaction URL: https://github.com/apache/incubator-hudi/pull/1422#issuecomment-601500333 # [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1422?src=pr=h1) Report > Merging

[GitHub] [incubator-hudi] leesf commented on issue #1165: [HUDI-76] Add CSV Source support for Hudi Delta Streamer

2020-03-19 Thread GitBox
leesf commented on issue #1165: [HUDI-76] Add CSV Source support for Hudi Delta Streamer URL: https://github.com/apache/incubator-hudi/pull/1165#issuecomment-601498123 > I feel it can go on the contributing guide.. Code reviews are also contributing :) .. either way is fine by me.. Draft

[incubator-hudi] branch asf-site updated: [HUDI-653] Add JMX Report Config to Doc (#1370)

2020-03-19 Thread leesf
This is an automated email from the ASF dual-hosted git repository. leesf pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-hudi.git The following commit(s) were added to refs/heads/asf-site by this push: new 434e9c5 [HUDI-653] Add JMX Report

[GitHub] [incubator-hudi] leesf merged pull request #1370: [HUDI-653] Add JMX Report Config to Doc

2020-03-19 Thread GitBox
leesf merged pull request #1370: [HUDI-653] Add JMX Report Config to Doc URL: https://github.com/apache/incubator-hudi/pull/1370 This is an automated message from the Apache Git Service. To respond to the message, please log

[jira] [Commented] (HUDI-724) Parallelize GetSmallFiles For Partitions

2020-03-19 Thread Vinoth Chandar (Jira)
[ https://issues.apache.org/jira/browse/HUDI-724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17063038#comment-17063038 ] Vinoth Chandar commented on HUDI-724: - Seems legit... I have not seen this with HDFS atleast... fix

[GitHub] [incubator-hudi] vinothchandar commented on issue #1165: [HUDI-76] Add CSV Source support for Hudi Delta Streamer

2020-03-19 Thread GitBox
vinothchandar commented on issue #1165: [HUDI-76] Add CSV Source support for Hudi Delta Streamer URL: https://github.com/apache/incubator-hudi/pull/1165#issuecomment-601497167 I feel it can go on the contributing guide.. Code reviews are also contributing :) .. either way is fine by me..

[GitHub] [incubator-hudi] vinothchandar commented on issue #1421: [HUDI-724] Parallelize getSmallFiles for partitions

2020-03-19 Thread GitBox
vinothchandar commented on issue #1421: [HUDI-724] Parallelize getSmallFiles for partitions URL: https://github.com/apache/incubator-hudi/pull/1421#issuecomment-601496939 @bvaradar to make final pass and sign off This is

[GitHub] [incubator-hudi] vinothchandar commented on a change in pull request #1421: [HUDI-724] Parallelize getSmallFiles for partitions

2020-03-19 Thread GitBox
vinothchandar commented on a change in pull request #1421: [HUDI-724] Parallelize getSmallFiles for partitions URL: https://github.com/apache/incubator-hudi/pull/1421#discussion_r395410649 ## File path: hudi-client/src/main/java/org/apache/hudi/table/HoodieCopyOnWriteTable.java

[GitHub] [incubator-hudi] vinothchandar commented on a change in pull request #1421: [HUDI-724] Parallelize getSmallFiles for partitions

2020-03-19 Thread GitBox
vinothchandar commented on a change in pull request #1421: [HUDI-724] Parallelize getSmallFiles for partitions URL: https://github.com/apache/incubator-hudi/pull/1421#discussion_r395410993 ## File path: hudi-client/src/main/java/org/apache/hudi/table/HoodieMergeOnReadTable.java

[GitHub] [incubator-hudi] vinothchandar commented on a change in pull request #1421: [HUDI-724] Parallelize getSmallFiles for partitions

2020-03-19 Thread GitBox
vinothchandar commented on a change in pull request #1421: [HUDI-724] Parallelize getSmallFiles for partitions URL: https://github.com/apache/incubator-hudi/pull/1421#discussion_r395410562 ## File path: hudi-client/src/main/java/org/apache/hudi/table/HoodieCopyOnWriteTable.java

[jira] [Updated] (HUDI-400) Add more checks to TestCompactionUtils#testUpgradeDowngrade

2020-03-19 Thread jerry (Jira)
[ https://issues.apache.org/jira/browse/HUDI-400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jerry updated HUDI-400: --- Status: In Progress (was: Open) > Add more checks to TestCompactionUtils#testUpgradeDowngrade >

[GitHub] [incubator-hudi] zhaomin1423 opened a new pull request #1422: [HUDI-400]check upgrade from old plan to new plan for compaction

2020-03-19 Thread GitBox
zhaomin1423 opened a new pull request #1422: [HUDI-400]check upgrade from old plan to new plan for compaction URL: https://github.com/apache/incubator-hudi/pull/1422 What is the purpose of the pull request Add more test for compaction plan upgrade Brief change log check

[GitHub] [incubator-hudi] zhaomin1423 closed pull request #1419: [HUDI-400]check upgrade from old plan to new plan for compaction

2020-03-19 Thread GitBox
zhaomin1423 closed pull request #1419: [HUDI-400]check upgrade from old plan to new plan for compaction URL: https://github.com/apache/incubator-hudi/pull/1419 This is an automated message from the Apache Git Service. To

[jira] [Commented] (HUDI-724) Parallelize GetSmallFiles For Partitions

2020-03-19 Thread Udit Mehrotra (Jira)
[ https://issues.apache.org/jira/browse/HUDI-724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17063033#comment-17063033 ] Udit Mehrotra commented on HUDI-724: Thanks Feichi for putting this out ! [~vinoth] [~vbalaji] Feichi

[GitHub] [incubator-hudi] ffcchi opened a new pull request #1421: [HUDI-724] Parallelize getSmallFiles for partitions

2020-03-19 Thread GitBox
ffcchi opened a new pull request #1421: [HUDI-724] Parallelize getSmallFiles for partitions URL: https://github.com/apache/incubator-hudi/pull/1421 ## What is the purpose of the pull request *parallelizing the operation of getting small files for partitions when constructing

[GitHub] [incubator-hudi] leesf commented on issue #1165: [HUDI-76] Add CSV Source support for Hudi Delta Streamer

2020-03-19 Thread GitBox
leesf commented on issue #1165: [HUDI-76] Add CSV Source support for Hudi Delta Streamer URL: https://github.com/apache/incubator-hudi/pull/1165#issuecomment-601488498 > @leesf this has happened enough times now, that we probably need a Code Review guide as well? wdyt Agree, I

[GitHub] [incubator-hudi] nsivabalan commented on a change in pull request #1176: [HUDI-430] Adding InlineFileSystem to support embedding any file format as an InlineFile

2020-03-19 Thread GitBox
nsivabalan commented on a change in pull request #1176: [HUDI-430] Adding InlineFileSystem to support embedding any file format as an InlineFile URL: https://github.com/apache/incubator-hudi/pull/1176#discussion_r39540 ## File path:

[GitHub] [incubator-hudi] nsivabalan commented on a change in pull request #1176: [HUDI-430] Adding InlineFileSystem to support embedding any file format as an InlineFile

2020-03-19 Thread GitBox
nsivabalan commented on a change in pull request #1176: [HUDI-430] Adding InlineFileSystem to support embedding any file format as an InlineFile URL: https://github.com/apache/incubator-hudi/pull/1176#discussion_r395401242 ## File path:

[GitHub] [incubator-hudi] nsivabalan commented on a change in pull request #1176: [HUDI-430] Adding InlineFileSystem to support embedding any file format as an InlineFile

2020-03-19 Thread GitBox
nsivabalan commented on a change in pull request #1176: [HUDI-430] Adding InlineFileSystem to support embedding any file format as an InlineFile URL: https://github.com/apache/incubator-hudi/pull/1176#discussion_r395401013 ## File path:

[GitHub] [incubator-hudi] nsivabalan commented on a change in pull request #1176: [HUDI-430] Adding InlineFileSystem to support embedding any file format as an InlineFile

2020-03-19 Thread GitBox
nsivabalan commented on a change in pull request #1176: [HUDI-430] Adding InlineFileSystem to support embedding any file format as an InlineFile URL: https://github.com/apache/incubator-hudi/pull/1176#discussion_r395400942 ## File path:

[GitHub] [incubator-hudi] lamber-ken commented on issue #1377: [HUDI-663] Fix HoodieDeltaStreamer offset not handled correctly

2020-03-19 Thread GitBox
lamber-ken commented on issue #1377: [HUDI-663] Fix HoodieDeltaStreamer offset not handled correctly URL: https://github.com/apache/incubator-hudi/pull/1377#issuecomment-601486061 @garyli1019 thanks very much for your detail comment.

[GitHub] [incubator-hudi] nsivabalan commented on a change in pull request #1176: [HUDI-430] Adding InlineFileSystem to support embedding any file format as an InlineFile

2020-03-19 Thread GitBox
nsivabalan commented on a change in pull request #1176: [HUDI-430] Adding InlineFileSystem to support embedding any file format as an InlineFile URL: https://github.com/apache/incubator-hudi/pull/1176#discussion_r395399661 ## File path:

[GitHub] [incubator-hudi] nsivabalan commented on a change in pull request #1176: [HUDI-430] Adding InlineFileSystem to support embedding any file format as an InlineFile

2020-03-19 Thread GitBox
nsivabalan commented on a change in pull request #1176: [HUDI-430] Adding InlineFileSystem to support embedding any file format as an InlineFile URL: https://github.com/apache/incubator-hudi/pull/1176#discussion_r395399488 ## File path:

[GitHub] [incubator-hudi] nsivabalan commented on a change in pull request #1176: [HUDI-430] Adding InlineFileSystem to support embedding any file format as an InlineFile

2020-03-19 Thread GitBox
nsivabalan commented on a change in pull request #1176: [HUDI-430] Adding InlineFileSystem to support embedding any file format as an InlineFile URL: https://github.com/apache/incubator-hudi/pull/1176#discussion_r395398271 ## File path:

[GitHub] [incubator-hudi] nsivabalan commented on a change in pull request #1176: [HUDI-430] Adding InlineFileSystem to support embedding any file format as an InlineFile

2020-03-19 Thread GitBox
nsivabalan commented on a change in pull request #1176: [HUDI-430] Adding InlineFileSystem to support embedding any file format as an InlineFile URL: https://github.com/apache/incubator-hudi/pull/1176#discussion_r395395831 ## File path:

[GitHub] [incubator-hudi] nsivabalan commented on a change in pull request #1176: [HUDI-430] Adding InlineFileSystem to support embedding any file format as an InlineFile

2020-03-19 Thread GitBox
nsivabalan commented on a change in pull request #1176: [HUDI-430] Adding InlineFileSystem to support embedding any file format as an InlineFile URL: https://github.com/apache/incubator-hudi/pull/1176#discussion_r395395084 ## File path:

[GitHub] [incubator-hudi] satishkotha commented on a change in pull request #1368: [HUDI-650] Modify handleUpdate path to validate partitionPath

2020-03-19 Thread GitBox
satishkotha commented on a change in pull request #1368: [HUDI-650] Modify handleUpdate path to validate partitionPath URL: https://github.com/apache/incubator-hudi/pull/1368#discussion_r395389042 ## File path: hudi-client/src/main/java/org/apache/hudi/io/HoodieMergeHandle.java

[GitHub] [incubator-hudi] satishkotha commented on a change in pull request #1368: [HUDI-650] Modify handleUpdate path to validate partitionPath

2020-03-19 Thread GitBox
satishkotha commented on a change in pull request #1368: [HUDI-650] Modify handleUpdate path to validate partitionPath URL: https://github.com/apache/incubator-hudi/pull/1368#discussion_r395389012 ## File path: hudi-client/src/main/java/org/apache/hudi/io/HoodieAppendHandle.java

[GitHub] [incubator-hudi] satishkotha commented on issue #1396: [HUDI-687] Stop incremental reader on RO table before a pending compaction

2020-03-19 Thread GitBox
satishkotha commented on issue #1396: [HUDI-687] Stop incremental reader on RO table before a pending compaction URL: https://github.com/apache/incubator-hudi/pull/1396#issuecomment-601473026 > @satishkotha : Some minor comments. Will approve once you reply/address them. Let's also wait

[GitHub] [incubator-hudi] satishkotha commented on a change in pull request #1396: [HUDI-687] Stop incremental reader on RO table before a pending compaction

2020-03-19 Thread GitBox
satishkotha commented on a change in pull request #1396: [HUDI-687] Stop incremental reader on RO table before a pending compaction URL: https://github.com/apache/incubator-hudi/pull/1396#discussion_r395386191 ## File path:

[GitHub] [incubator-hudi] satishkotha commented on a change in pull request #1396: [HUDI-687] Stop incremental reader on RO table before a pending compaction

2020-03-19 Thread GitBox
satishkotha commented on a change in pull request #1396: [HUDI-687] Stop incremental reader on RO table before a pending compaction URL: https://github.com/apache/incubator-hudi/pull/1396#discussion_r395386043 ## File path:

[GitHub] [incubator-hudi] satishkotha commented on a change in pull request #1396: [HUDI-687] Stop incremental reader on RO table before a pending compaction

2020-03-19 Thread GitBox
satishkotha commented on a change in pull request #1396: [HUDI-687] Stop incremental reader on RO table before a pending compaction URL: https://github.com/apache/incubator-hudi/pull/1396#discussion_r395386006 ## File path:

[GitHub] [incubator-hudi] vinothchandar commented on issue #1362: [WIP]HUDI-644 Implement checkpoint generator helper tool

2020-03-19 Thread GitBox
vinothchandar commented on issue #1362: [WIP]HUDI-644 Implement checkpoint generator helper tool URL: https://github.com/apache/incubator-hudi/pull/1362#issuecomment-601469123 No. thank you.. This kind of stuff, gives me energy to keep pushing more :)

[jira] [Commented] (HUDI-648) Implement error log/table for Datasource/DeltaStreamer/WriteClient/Compaction writes

2020-03-19 Thread Vinoth Chandar (Jira)
[ https://issues.apache.org/jira/browse/HUDI-648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17063001#comment-17063001 ] Vinoth Chandar commented on HUDI-648: - [~liujinhui] Actually, skipping should be supported today with

[jira] [Updated] (HUDI-724) Parallelize GetSmallFiles For Partitions

2020-03-19 Thread Feichi Feng (Jira)
[ https://issues.apache.org/jira/browse/HUDI-724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Feichi Feng updated HUDI-724: - Description: When writing data, a gap was observed between spark stages. By tracking down where the time

[GitHub] [incubator-hudi] garyli1019 closed pull request #1362: [WIP]HUDI-644 Implement checkpoint generator helper tool

2020-03-19 Thread GitBox
garyli1019 closed pull request #1362: [WIP]HUDI-644 Implement checkpoint generator helper tool URL: https://github.com/apache/incubator-hudi/pull/1362 This is an automated message from the Apache Git Service. To respond to

[GitHub] [incubator-hudi] garyli1019 commented on issue #1362: [WIP]HUDI-644 Implement checkpoint generator helper tool

2020-03-19 Thread GitBox
garyli1019 commented on issue #1362: [WIP]HUDI-644 Implement checkpoint generator helper tool URL: https://github.com/apache/incubator-hudi/pull/1362#issuecomment-601468645 ok, I will make a separate PR for the tool. Thanks everyone who participated in this long discussion...

[GitHub] [incubator-hudi] vinothchandar commented on issue #1362: [WIP]HUDI-644 Implement checkpoint generator helper tool

2020-03-19 Thread GitBox
vinothchandar commented on issue #1362: [WIP]HUDI-644 Implement checkpoint generator helper tool URL: https://github.com/apache/incubator-hudi/pull/1362#issuecomment-601468133 > Do you see any other use case the reverse search would be useful? No. not at the moment.. We can close

[jira] [Created] (HUDI-724) Parallelize GetSmallFiles For Partitions

2020-03-19 Thread Feichi Feng (Jira)
Feichi Feng created HUDI-724: Summary: Parallelize GetSmallFiles For Partitions Key: HUDI-724 URL: https://issues.apache.org/jira/browse/HUDI-724 Project: Apache Hudi (incubating) Issue Type:

[GitHub] [incubator-hudi] bvaradar commented on a change in pull request #1416: [HUDI-717] Fixed usage of HiveDriver for DDL statements for Hive 2.x

2020-03-19 Thread GitBox
bvaradar commented on a change in pull request #1416: [HUDI-717] Fixed usage of HiveDriver for DDL statements for Hive 2.x URL: https://github.com/apache/incubator-hudi/pull/1416#discussion_r395341832 ## File path:

[GitHub] [incubator-hudi] bvaradar commented on a change in pull request #1416: [HUDI-717] Fixed usage of HiveDriver for DDL statements for Hive 2.x

2020-03-19 Thread GitBox
bvaradar commented on a change in pull request #1416: [HUDI-717] Fixed usage of HiveDriver for DDL statements for Hive 2.x URL: https://github.com/apache/incubator-hudi/pull/1416#discussion_r395337083 ## File path:

[jira] [Commented] (HUDI-686) Implement BloomIndexV2 that does not depend on memory caching

2020-03-19 Thread Vinoth Chandar (Jira)
[ https://issues.apache.org/jira/browse/HUDI-686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17062945#comment-17062945 ] Vinoth Chandar commented on HUDI-686: - [~vbalaji] [~shivnarayan] Please review this information

[jira] [Commented] (HUDI-686) Implement BloomIndexV2 that does not depend on memory caching

2020-03-19 Thread Vinoth Chandar (Jira)
[ https://issues.apache.org/jira/browse/HUDI-686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17062940#comment-17062940 ] Vinoth Chandar commented on HUDI-686: - Timing the individual stages  Roughly, here is how it looks

[GitHub] [incubator-hudi] garyli1019 commented on issue #1362: [WIP]HUDI-644 Implement checkpoint generator helper tool

2020-03-19 Thread GitBox
garyli1019 commented on issue #1362: [WIP]HUDI-644 Implement checkpoint generator helper tool URL: https://github.com/apache/incubator-hudi/pull/1362#issuecomment-601416005 > Given that, do we still need the ability to search for the checkpoints in reverse time order? Maybe not

[GitHub] [incubator-hudi] garyli1019 commented on issue #1377: [HUDI-663] Fix HoodieDeltaStreamer offset not handled correctly

2020-03-19 Thread GitBox
garyli1019 commented on issue #1377: [HUDI-663] Fix HoodieDeltaStreamer offset not handled correctly URL: https://github.com/apache/incubator-hudi/pull/1377#issuecomment-601412133 @vinothchandar I thought the empty checkpoint was created by a bug before, but if the empty checkpoint is

[GitHub] [incubator-hudi] prashantwason commented on a change in pull request #1416: [HUDI-717] Fixed usage of HiveDriver for DDL statements for Hive 2.x

2020-03-19 Thread GitBox
prashantwason commented on a change in pull request #1416: [HUDI-717] Fixed usage of HiveDriver for DDL statements for Hive 2.x URL: https://github.com/apache/incubator-hudi/pull/1416#discussion_r395308902 ## File path:

[GitHub] [incubator-hudi] bvaradar commented on a change in pull request #1368: [HUDI-650] Modify handleUpdate path to validate partitionPath

2020-03-19 Thread GitBox
bvaradar commented on a change in pull request #1368: [HUDI-650] Modify handleUpdate path to validate partitionPath URL: https://github.com/apache/incubator-hudi/pull/1368#discussion_r395228837 ## File path: hudi-client/src/main/java/org/apache/hudi/io/HoodieAppendHandle.java

[GitHub] [incubator-hudi] bvaradar commented on a change in pull request #1368: [HUDI-650] Modify handleUpdate path to validate partitionPath

2020-03-19 Thread GitBox
bvaradar commented on a change in pull request #1368: [HUDI-650] Modify handleUpdate path to validate partitionPath URL: https://github.com/apache/incubator-hudi/pull/1368#discussion_r395229769 ## File path: hudi-client/src/main/java/org/apache/hudi/io/HoodieMergeHandle.java

[GitHub] [incubator-hudi] vinothchandar commented on issue #1362: [WIP]HUDI-644 Implement checkpoint generator helper tool

2020-03-19 Thread GitBox
vinothchandar commented on issue #1362: [WIP]HUDI-644 Implement checkpoint generator helper tool URL: https://github.com/apache/incubator-hudi/pull/1362#issuecomment-601321422 Given that, do we still need the ability to search for the checkpoints in reverse time order? tbh I don't see a

[GitHub] [incubator-hudi] bvaradar commented on a change in pull request #1396: [HUDI-687] Stop incremental reader on RO table before a pending compaction

2020-03-19 Thread GitBox
bvaradar commented on a change in pull request #1396: [HUDI-687] Stop incremental reader on RO table before a pending compaction URL: https://github.com/apache/incubator-hudi/pull/1396#discussion_r395181942 ## File path:

[GitHub] [incubator-hudi] bvaradar commented on a change in pull request #1396: [HUDI-687] Stop incremental reader on RO table before a pending compaction

2020-03-19 Thread GitBox
bvaradar commented on a change in pull request #1396: [HUDI-687] Stop incremental reader on RO table before a pending compaction URL: https://github.com/apache/incubator-hudi/pull/1396#discussion_r395187395 ## File path:

[GitHub] [incubator-hudi] bvaradar commented on a change in pull request #1396: [HUDI-687] Stop incremental reader on RO table before a pending compaction

2020-03-19 Thread GitBox
bvaradar commented on a change in pull request #1396: [HUDI-687] Stop incremental reader on RO table before a pending compaction URL: https://github.com/apache/incubator-hudi/pull/1396#discussion_r395185815 ## File path:

[jira] [Commented] (HUDI-686) Implement BloomIndexV2 that does not depend on memory caching

2020-03-19 Thread Vinoth Chandar (Jira)
[ https://issues.apache.org/jira/browse/HUDI-686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17062781#comment-17062781 ] Vinoth Chandar commented on HUDI-686: - Running a local microbenchmark, I actually found that the extra

[jira] [Updated] (HUDI-686) Implement BloomIndexV2 that does not depend on memory caching

2020-03-19 Thread Vinoth Chandar (Jira)
[ https://issues.apache.org/jira/browse/HUDI-686?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vinoth Chandar updated HUDI-686: Attachment: image-2020-03-19-10-17-43-048.png > Implement BloomIndexV2 that does not depend on

[jira] [Updated] (HUDI-686) Implement BloomIndexV2 that does not depend on memory caching

2020-03-19 Thread Vinoth Chandar (Jira)
[ https://issues.apache.org/jira/browse/HUDI-686?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vinoth Chandar updated HUDI-686: Attachment: Screen Shot 2020-03-19 at 10.15.10 AM.png > Implement BloomIndexV2 that does not depend

[jira] [Updated] (HUDI-686) Implement BloomIndexV2 that does not depend on memory caching

2020-03-19 Thread Vinoth Chandar (Jira)
[ https://issues.apache.org/jira/browse/HUDI-686?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vinoth Chandar updated HUDI-686: Attachment: Screen Shot 2020-03-19 at 10.15.10 AM.png > Implement BloomIndexV2 that does not depend

[jira] [Updated] (HUDI-686) Implement BloomIndexV2 that does not depend on memory caching

2020-03-19 Thread Vinoth Chandar (Jira)
[ https://issues.apache.org/jira/browse/HUDI-686?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vinoth Chandar updated HUDI-686: Attachment: Screen Shot 2020-03-19 at 10.15.10 AM.png > Implement BloomIndexV2 that does not depend

[GitHub] [incubator-hudi] codecov-io edited a comment on issue #1419: [HUDI-400]check upgrade from old plan to new plan for compaction

2020-03-19 Thread GitBox
codecov-io edited a comment on issue #1419: [HUDI-400]check upgrade from old plan to new plan for compaction URL: https://github.com/apache/incubator-hudi/pull/1419#issuecomment-601246921 # [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1419?src=pr=h1) Report > Merging

[jira] [Commented] (HUDI-686) Implement BloomIndexV2 that does not depend on memory caching

2020-03-19 Thread Vinoth Chandar (Jira)
[ https://issues.apache.org/jira/browse/HUDI-686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17062771#comment-17062771 ] Vinoth Chandar commented on HUDI-686: - candidates can be as big as N * size of HoodieRecord, where N is

[GitHub] [incubator-hudi] vinothchandar commented on issue #1377: [HUDI-663] Fix HoodieDeltaStreamer offset not handled correctly

2020-03-19 Thread GitBox
vinothchandar commented on issue #1377: [HUDI-663] Fix HoodieDeltaStreamer offset not handled correctly URL: https://github.com/apache/incubator-hudi/pull/1377#issuecomment-601303031

[jira] [Commented] (HUDI-686) Implement BloomIndexV2 that does not depend on memory caching

2020-03-19 Thread lamber-ken (Jira)
[ https://issues.apache.org/jira/browse/HUDI-686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17062761#comment-17062761 ] lamber-ken commented on HUDI-686: - [~vinoth] thanks for bring up this new idea. here are some concerns to

[GitHub] [incubator-hudi] vinothchandar commented on issue #1165: [HUDI-76] Add CSV Source support for Hudi Delta Streamer

2020-03-19 Thread GitBox
vinothchandar commented on issue #1165: [HUDI-76] Add CSV Source support for Hudi Delta Streamer URL: https://github.com/apache/incubator-hudi/pull/1165#issuecomment-601285910 @leesf this has happened enough times now, that we probably need a Code Review guide as well? wdyt

[GitHub] [incubator-hudi] vinothchandar commented on issue #1417: [HUDI-720] NOTICE file needs to add more content based on the NOTICE files of the ASF projects that hudi bundles

2020-03-19 Thread GitBox
vinothchandar commented on issue #1417: [HUDI-720] NOTICE file needs to add more content based on the NOTICE files of the ASF projects that hudi bundles URL: https://github.com/apache/incubator-hudi/pull/1417#issuecomment-601283565 @yanghua LGTM . lets roll the dice again

[GitHub] [incubator-hudi] vinothchandar commented on issue #1409: [HUDI-714]Add javadoc and comments to hudi write method link

2020-03-19 Thread GitBox
vinothchandar commented on issue #1409: [HUDI-714]Add javadoc and comments to hudi write method link URL: https://github.com/apache/incubator-hudi/pull/1409#issuecomment-601280309 @nsivabalan could you please review this

[GitHub] [incubator-hudi] deabreu opened a new issue #1420: Broken Maven dependencies.

2020-03-19 Thread GitBox
deabreu opened a new issue #1420: Broken Maven dependencies. URL: https://github.com/apache/incubator-hudi/issues/1420 The following artifacts are missing from https://packages.confluent.io/maven org.apache.hudi:hudi-client::0.6.0-SNAPSHOT org.apache.hudi:hudi-common::0.6.0-SNAPSHOT

[GitHub] [incubator-hudi] bvaradar commented on issue #1400: optimization debian package manager tweaks

2020-03-19 Thread GitBox
bvaradar commented on issue #1400: optimization debian package manager tweaks URL: https://github.com/apache/incubator-hudi/pull/1400#issuecomment-601277565 @Rajpratik71 : Just pinging to see if you are planning to work on this PR.

[GitHub] [incubator-hudi] bvaradar commented on a change in pull request #1416: [HUDI-717] Fixed usage of HiveDriver for DDL statements for Hive 2.x

2020-03-19 Thread GitBox
bvaradar commented on a change in pull request #1416: [HUDI-717] Fixed usage of HiveDriver for DDL statements for Hive 2.x URL: https://github.com/apache/incubator-hudi/pull/1416#discussion_r395155031 ## File path:

[GitHub] [incubator-hudi] nsivabalan commented on a change in pull request #1176: [HUDI-430] Adding InlineFileSystem to support embedding any file format as an InlineFile

2020-03-19 Thread GitBox
nsivabalan commented on a change in pull request #1176: [HUDI-430] Adding InlineFileSystem to support embedding any file format as an InlineFile URL: https://github.com/apache/incubator-hudi/pull/1176#discussion_r395120821 ## File path:

[GitHub] [incubator-hudi] codecov-io edited a comment on issue #1419: [HUDI-400]check upgrade from old plan to new plan for compaction

2020-03-19 Thread GitBox
codecov-io edited a comment on issue #1419: [HUDI-400]check upgrade from old plan to new plan for compaction URL: https://github.com/apache/incubator-hudi/pull/1419#issuecomment-601246921 # [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1419?src=pr=h1) Report > Merging

[GitHub] [incubator-hudi] codecov-io commented on issue #1419: [HUDI-400]check upgrade from old plan to new plan for compaction

2020-03-19 Thread GitBox
codecov-io commented on issue #1419: [HUDI-400]check upgrade from old plan to new plan for compaction URL: https://github.com/apache/incubator-hudi/pull/1419#issuecomment-601246921 # [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1419?src=pr=h1) Report > Merging

[GitHub] [incubator-hudi] zhaomin1423 opened a new pull request #1419: [HUDI-400]check upgrade from old plan to new plan for compaction

2020-03-19 Thread GitBox
zhaomin1423 opened a new pull request #1419: [HUDI-400]check upgrade from old plan to new plan for compaction URL: https://github.com/apache/incubator-hudi/pull/1419 ## What is the purpose of the pull request Add more test for compaction plan upgrade ## Brief change log

[jira] [Updated] (HUDI-400) Add more checks to TestCompactionUtils#testUpgradeDowngrade

2020-03-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HUDI-400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HUDI-400: Labels: pull-request-available (was: ) > Add more checks to

[GitHub] [incubator-hudi] nsivabalan commented on issue #1165: [HUDI-76] Add CSV Source support for Hudi Delta Streamer

2020-03-19 Thread GitBox
nsivabalan commented on issue #1165: [HUDI-76] Add CSV Source support for Hudi Delta Streamer URL: https://github.com/apache/incubator-hudi/pull/1165#issuecomment-601219527 got it, sure. This is an automated message from the

[GitHub] [incubator-hudi] leesf commented on issue #1165: [HUDI-76] Add CSV Source support for Hudi Delta Streamer

2020-03-19 Thread GitBox
leesf commented on issue #1165: [HUDI-76] Add CSV Source support for Hudi Delta Streamer URL: https://github.com/apache/incubator-hudi/pull/1165#issuecomment-601204501 > @leesf : Thanks. I got the permission now. You are welcome and a nice shot. just one minor tip, please

[incubator-hudi] branch master updated: [HUDI-76] Add CSV Source support for Hudi Delta Streamer

2020-03-19 Thread sivabalan
This is an automated email from the ASF dual-hosted git repository. sivabalan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-hudi.git The following commit(s) were added to refs/heads/master by this push: new cf765df [HUDI-76] Add CSV Source

[GitHub] [incubator-hudi] nsivabalan commented on issue #1165: [HUDI-76] Add CSV Source support for Hudi Delta Streamer

2020-03-19 Thread GitBox
nsivabalan commented on issue #1165: [HUDI-76] Add CSV Source support for Hudi Delta Streamer URL: https://github.com/apache/incubator-hudi/pull/1165#issuecomment-601195118 @leesf : I got the permission now. This is an

[GitHub] [incubator-hudi] nsivabalan merged pull request #1165: [HUDI-76] Add CSV Source support for Hudi Delta Streamer

2020-03-19 Thread GitBox
nsivabalan merged pull request #1165: [HUDI-76] Add CSV Source support for Hudi Delta Streamer URL: https://github.com/apache/incubator-hudi/pull/1165 This is an automated message from the Apache Git Service. To respond to

[GitHub] [incubator-hudi] nsivabalan edited a comment on issue #1165: [HUDI-76] Add CSV Source support for Hudi Delta Streamer

2020-03-19 Thread GitBox
nsivabalan edited a comment on issue #1165: [HUDI-76] Add CSV Source support for Hudi Delta Streamer URL: https://github.com/apache/incubator-hudi/pull/1165#issuecomment-601195118 @leesf : Thanks. I got the permission now.

[GitHub] [incubator-hudi] XuQianJin-Stars commented on issue #1370: [HUDI-653] Add JMX Report Config to Doc

2020-03-19 Thread GitBox
XuQianJin-Stars commented on issue #1370: [HUDI-653] Add JMX Report Config to Doc URL: https://github.com/apache/incubator-hudi/pull/1370#issuecomment-601152532 > @XuQianJin-Stars Would you please only update the docs under _docs and please not update the docs under 0.5.0/0.5.1. Thanks.

[GitHub] [incubator-hudi] codecov-io commented on issue #1418: [HUDI-678] Make config package spark free

2020-03-19 Thread GitBox
codecov-io commented on issue #1418: [HUDI-678] Make config package spark free URL: https://github.com/apache/incubator-hudi/pull/1418#issuecomment-601151728 # [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1418?src=pr=h1) Report > Merging

[GitHub] [incubator-hudi] codecov-io edited a comment on issue #1418: [HUDI-678] Make config package spark free

2020-03-19 Thread GitBox
codecov-io edited a comment on issue #1418: [HUDI-678] Make config package spark free URL: https://github.com/apache/incubator-hudi/pull/1418#issuecomment-601151728 # [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1418?src=pr=h1) Report > Merging

[GitHub] [incubator-hudi] leesf commented on issue #1370: [HUDI-653] Add JMX Report Config to Doc

2020-03-19 Thread GitBox
leesf commented on issue #1370: [HUDI-653] Add JMX Report Config to Doc URL: https://github.com/apache/incubator-hudi/pull/1370#issuecomment-601144978 @XuQianJin-Stars Would you please only update the docs under _docs and please not update the docs under 0.5.0/0.5.1. Thanks.

[incubator-hudi] branch master updated: [HUDI-209] Implement JMX metrics reporter (#1106)

2020-03-19 Thread leesf
This is an automated email from the ASF dual-hosted git repository. leesf pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-hudi.git The following commit(s) were added to refs/heads/master by this push: new 1e321c2 [HUDI-209] Implement JMX

[GitHub] [incubator-hudi] leesf merged pull request #1106: [HUDI-209] Implement JMX metrics reporter

2020-03-19 Thread GitBox
leesf merged pull request #1106: [HUDI-209] Implement JMX metrics reporter URL: https://github.com/apache/incubator-hudi/pull/1106 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-hudi] leesf merged pull request #1414: [HUDI-437] Add user-defined index config

2020-03-19 Thread GitBox
leesf merged pull request #1414: [HUDI-437] Add user-defined index config URL: https://github.com/apache/incubator-hudi/pull/1414 This is an automated message from the Apache Git Service. To respond to the message, please

[incubator-hudi] branch asf-site updated: [HUDI-437] Add user-defined index config (#1414)

2020-03-19 Thread leesf
This is an automated email from the ASF dual-hosted git repository. leesf pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-hudi.git The following commit(s) were added to refs/heads/asf-site by this push: new e500cc1 [HUDI-437] Add user-defined

[GitHub] [incubator-hudi] yanghua commented on a change in pull request #1417: [HUDI-720] NOTICE file needs to add more content based on the NOTICE files of the ASF projects that hudi bundles

2020-03-19 Thread GitBox
yanghua commented on a change in pull request #1417: [HUDI-720] NOTICE file needs to add more content based on the NOTICE files of the ASF projects that hudi bundles URL: https://github.com/apache/incubator-hudi/pull/1417#discussion_r394906742 ## File path: NOTICE ## @@

[GitHub] [incubator-hudi] yanghua commented on a change in pull request #1417: [HUDI-720] NOTICE file needs to add more content based on the NOTICE files of the ASF projects that hudi bundles

2020-03-19 Thread GitBox
yanghua commented on a change in pull request #1417: [HUDI-720] NOTICE file needs to add more content based on the NOTICE files of the ASF projects that hudi bundles URL: https://github.com/apache/incubator-hudi/pull/1417#discussion_r394884156 ## File path: NOTICE ## @@

  1   2   >