[GitHub] [incubator-mxnet] mikemwx commented on a change in pull request #15550: Infra to use tvm write op kernels

2019-08-05 Thread GitBox
mikemwx commented on a change in pull request #15550: Infra to use tvm write op kernels URL: https://github.com/apache/incubator-mxnet/pull/15550#discussion_r310480960 ## File path: src/operator/contrib/tvmop/ufunc.cc ## @@ -0,0 +1,66 @@ +/* + * Licensed to the Apache

[GitHub] [incubator-mxnet] vrakesh commented on issue #15747: Cannot run cpp examples, Too many resources requested for launch

2019-08-05 Thread GitBox
vrakesh commented on issue #15747: Cannot run cpp examples, Too many resources requested for launch URL: https://github.com/apache/incubator-mxnet/issues/15747#issuecomment-518146811 @mxnet-label-bot add [Build, Example]

[GitHub] [incubator-mxnet] arcadiaphy commented on issue #15576: Multi-threaded inference broken with MKLDNN

2019-08-05 Thread GitBox
arcadiaphy commented on issue #15576: Multi-threaded inference broken with MKLDNN URL: https://github.com/apache/incubator-mxnet/issues/15576#issuecomment-518118164 @pengzhao-intel My local solution works fine, but it's not suitable for an official PR.

[GitHub] [incubator-mxnet] vrakesh commented on issue #15729: Missing nin content from dmlc.ml site

2019-08-05 Thread GitBox
vrakesh commented on issue #15729: Missing nin content from dmlc.ml site URL: https://github.com/apache/incubator-mxnet/issues/15729#issuecomment-518131446 @mxnet-label-bot add [Website] This is an automated message from the

[GitHub] [incubator-mxnet] vrakesh commented on issue #15730: Missing nnvm content from DMLC.ML site

2019-08-05 Thread GitBox
vrakesh commented on issue #15730: Missing nnvm content from DMLC.ML site URL: https://github.com/apache/incubator-mxnet/issues/15730#issuecomment-518131577 @mxnet-label-bot add [Website] This is an automated message from

[GitHub] [incubator-mxnet] sandeep-krishnamurthy merged pull request #15714: Fix broadcast op param

2019-08-05 Thread GitBox
sandeep-krishnamurthy merged pull request #15714: Fix broadcast op param URL: https://github.com/apache/incubator-mxnet/pull/15714 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-mxnet] xinyu-intel opened a new pull request #15754: Add quantization support for GluonCV

2019-08-05 Thread GitBox
xinyu-intel opened a new pull request #15754: Add quantization support for GluonCV URL: https://github.com/apache/incubator-mxnet/pull/15754 ## Description ## Add a User-level API for Gluon users to generate a quantized SymbolBlock from a FP32 HybridBlock w/ or w/o calibration.

[incubator-mxnet] branch master updated (7c26810 -> 3255d87)

2019-08-05 Thread skm
This is an automated email from the ASF dual-hosted git repository. skm pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git. from 7c26810 fix dropout mask output (#15697) add 3255d87 fix broadcast op param (#15714) No new revisions

[GitHub] [incubator-mxnet] fhieber closed issue #14574: Feature Request: 'arange_like/enumerate' operator

2019-08-05 Thread GitBox
fhieber closed issue #14574: Feature Request: 'arange_like/enumerate' operator URL: https://github.com/apache/incubator-mxnet/issues/14574 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-mxnet] fhieber commented on issue #14574: Feature Request: 'arange_like/enumerate' operator

2019-08-05 Thread GitBox
fhieber commented on issue #14574: Feature Request: 'arange_like/enumerate' operator URL: https://github.com/apache/incubator-mxnet/issues/14574#issuecomment-518104007 Resolved by #15400 This is an automated message from

[GitHub] [incubator-mxnet] anotinelg commented on issue #15710: Inconsistent behaviour of ImageRecordIter depending on encoding format png vs jpeg

2019-08-05 Thread GitBox
anotinelg commented on issue #15710: Inconsistent behaviour of ImageRecordIter depending on encoding format png vs jpeg URL: https://github.com/apache/incubator-mxnet/issues/15710#issuecomment-518146148 Thanks for the confirmation. But then I have a concern and this is about the color

[GitHub] [incubator-mxnet] vrakesh commented on issue #15738: AMP results in higher loss

2019-08-05 Thread GitBox
vrakesh commented on issue #15738: AMP results in higher loss URL: https://github.com/apache/incubator-mxnet/issues/15738#issuecomment-518146362 @mxnet-label-bot add [Performance] This is an automated message from the Apache

[GitHub] [incubator-mxnet] vrakesh commented on issue #15749: [RFC][WIP] RFC Issue Mirroring to d...@mxnet.apache.org

2019-08-05 Thread GitBox
vrakesh commented on issue #15749: [RFC][WIP] RFC Issue Mirroring to d...@mxnet.apache.org URL: https://github.com/apache/incubator-mxnet/issues/15749#issuecomment-518148397 @mxnet-label-bot add [RFC] This is an automated

[GitHub] [incubator-mxnet] vrakesh commented on issue #15750: New feature request: split tensor into arbitrary contiguous groups along the specified dimension

2019-08-05 Thread GitBox
vrakesh commented on issue #15750: New feature request: split tensor into arbitrary contiguous groups along the specified dimension URL: https://github.com/apache/incubator-mxnet/issues/15750#issuecomment-518148522 @mxnet-label-bot add [Feature Request]

[GitHub] [incubator-mxnet] vrakesh commented on issue #15742: Minor bugs in ImageNet training tutorial

2019-08-05 Thread GitBox
vrakesh commented on issue #15742: Minor bugs in ImageNet training tutorial URL: https://github.com/apache/incubator-mxnet/issues/15742#issuecomment-518148088 @youn123 Thank you for pointing this out @mxnet-label-bot add [Gluon, Website]

[GitHub] [incubator-mxnet] zixuanweeei commented on issue #15741: MKL-DNN LBR-GRU Inference Integration (FP32 LBR-GRU)

2019-08-05 Thread GitBox
zixuanweeei commented on issue #15741: MKL-DNN LBR-GRU Inference Integration (FP32 LBR-GRU) URL: https://github.com/apache/incubator-mxnet/pull/15741#issuecomment-518208748 @pengzhao-intel This PR might also contain flaky unit tests with gpu context. For instance,

[GitHub] [incubator-mxnet] zixuanweeei commented on issue #15741: MKL-DNN LBR-GRU Inference Integration (FP32 LBR-GRU)

2019-08-05 Thread GitBox
zixuanweeei commented on issue #15741: MKL-DNN LBR-GRU Inference Integration (FP32 LBR-GRU) URL: https://github.com/apache/incubator-mxnet/pull/15741#issuecomment-518276903 I tried to reproduce the failures on our internal GPU platforms, but all worked well. And it should be noticed that

[GitHub] [incubator-mxnet] ptrendx commented on issue #15545: Softmax fwd optimization for GPU

2019-08-05 Thread GitBox
ptrendx commented on issue #15545: Softmax fwd optimization for GPU URL: https://github.com/apache/incubator-mxnet/pull/15545#issuecomment-518305583 @haojin2 I'm not sure how to progress with this PR - it seems that Windows CI instances do not have enough RAM to process all the templates

[GitHub] [incubator-mxnet] aaronmarkham closed issue #15642: Website installation issue

2019-08-05 Thread GitBox
aaronmarkham closed issue #15642: Website installation issue URL: https://github.com/apache/incubator-mxnet/issues/15642 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-mxnet] aaronmarkham commented on issue #15642: Website installation issue

2019-08-05 Thread GitBox
aaronmarkham commented on issue #15642: Website installation issue URL: https://github.com/apache/incubator-mxnet/issues/15642#issuecomment-518321260 Yes, it's fixed. This is an automated message from the Apache Git Service.

[GitHub] [incubator-mxnet] ptrendx commented on a change in pull request #15657: Eliminate common expressions

2019-08-05 Thread GitBox
ptrendx commented on a change in pull request #15657: Eliminate common expressions URL: https://github.com/apache/incubator-mxnet/pull/15657#discussion_r310686576 ## File path: include/mxnet/op_attr_types.h ## @@ -208,6 +208,17 @@ using FCreateOpState = std::function&

[GitHub] [incubator-mxnet] ptrendx commented on a change in pull request #15657: Eliminate common expressions

2019-08-05 Thread GitBox
ptrendx commented on a change in pull request #15657: Eliminate common expressions URL: https://github.com/apache/incubator-mxnet/pull/15657#discussion_r310686717 ## File path: src/imperative/cached_op.cc ## @@ -126,6 +126,8 @@ CachedOp::CachedOp(

[GitHub] [incubator-mxnet] ptrendx commented on issue #15716: Increase amp support for Bi-lstm and Concat operators in gluon

2019-08-05 Thread GitBox
ptrendx commented on issue #15716: Increase amp support for Bi-lstm and Concat operators in gluon URL: https://github.com/apache/incubator-mxnet/issues/15716#issuecomment-518327880 Ok, so after applying PR #15740 I can successfully run the example when using `amp.init`: ``` import

[GitHub] [incubator-mxnet] eloi-loomai commented on issue #15745: Memory layout in the LSTM operator

2019-08-05 Thread GitBox
eloi-loomai commented on issue #15745: Memory layout in the LSTM operator URL: https://github.com/apache/incubator-mxnet/issues/15745#issuecomment-518284857 I also realized that the order of gates in the planes is: `I, F, G, O`

[GitHub] [incubator-mxnet] ptrendx commented on issue #15738: AMP results in higher loss

2019-08-05 Thread GitBox
ptrendx commented on issue #15738: AMP results in higher loss URL: https://github.com/apache/incubator-mxnet/issues/15738#issuecomment-518309855 Hi @ChengXianbing, the loss being high problem comes from the fact that the gradients generated when using AMP are scaled up by the loss scale

[GitHub] [incubator-mxnet] eloi-loomai commented on issue #15745: Memory layout in the LSTM operator

2019-08-05 Thread GitBox
eloi-loomai commented on issue #15745: Memory layout in the LSTM operator URL: https://github.com/apache/incubator-mxnet/issues/15745#issuecomment-518284295 Ok, thanks! This is an automated message from the Apache Git

[GitHub] [incubator-mxnet] eloi-loomai closed issue #15745: Memory layout in the LSTM operator

2019-08-05 Thread GitBox
eloi-loomai closed issue #15745: Memory layout in the LSTM operator URL: https://github.com/apache/incubator-mxnet/issues/15745 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [incubator-mxnet] junrushao1994 commented on issue #15749: [RFC][WIP] RFC Issue Mirroring to d...@mxnet.apache.org

2019-08-05 Thread GitBox
junrushao1994 commented on issue #15749: [RFC][WIP] RFC Issue Mirroring to d...@mxnet.apache.org URL: https://github.com/apache/incubator-mxnet/issues/15749#issuecomment-518323470 +1 for the proposal! BTW shall we have an option to block messages sent by the label bot to avoid too

[GitHub] [incubator-mxnet] Adesun commented on issue #15749: [RFC][WIP] RFC Issue Mirroring to d...@mxnet.apache.org

2019-08-05 Thread GitBox
Adesun commented on issue #15749: [RFC][WIP] RFC Issue Mirroring to d...@mxnet.apache.org URL: https://github.com/apache/incubator-mxnet/issues/15749#issuecomment-518178698 thats a good option This is an automated message

[GitHub] [incubator-mxnet] pengzhao-intel commented on issue #15741: MKL-DNN LBR-GRU Inference Integration (FP32 LBR-GRU)

2019-08-05 Thread GitBox
pengzhao-intel commented on issue #15741: MKL-DNN LBR-GRU Inference Integration (FP32 LBR-GRU) URL: https://github.com/apache/incubator-mxnet/pull/15741#issuecomment-51874 Could you analyze why the flaky test is generated? It's from the numerical difference or algorithm level

[GitHub] [incubator-mxnet] zixuanweeei edited a comment on issue #15741: MKL-DNN LBR-GRU Inference Integration (FP32 LBR-GRU)

2019-08-05 Thread GitBox
zixuanweeei edited a comment on issue #15741: MKL-DNN LBR-GRU Inference Integration (FP32 LBR-GRU) URL: https://github.com/apache/incubator-mxnet/pull/15741#issuecomment-518208748 @pengzhao-intel This PR might also contain flaky unit tests with gpu context. For instance,

[GitHub] [incubator-mxnet] edisongustavo closed pull request #14871: Cmake blas

2019-08-05 Thread GitBox
edisongustavo closed pull request #14871: Cmake blas URL: https://github.com/apache/incubator-mxnet/pull/14871 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [incubator-mxnet] edisongustavo commented on issue #14871: Cmake blas

2019-08-05 Thread GitBox
edisongustavo commented on issue #14871: Cmake blas URL: https://github.com/apache/incubator-mxnet/pull/14871#issuecomment-518211958 Hello everyone, I don't think I will be able to work on this anymore. Given that Conan support has been merged in

[GitHub] [incubator-mxnet] wkcn commented on a change in pull request #15751: Fix the bug of `MXEnginePushAsyncND` and `MXEnginePushSyncND`

2019-08-05 Thread GitBox
wkcn commented on a change in pull request #15751: Fix the bug of `MXEnginePushAsyncND` and `MXEnginePushSyncND` URL: https://github.com/apache/incubator-mxnet/pull/15751#discussion_r310579220 ## File path: src/c_api/c_api.cc ## @@ -1544,18 +1544,18 @@ int

[GitHub] [incubator-mxnet] Adesun removed a comment on issue #15749: [RFC][WIP] RFC Issue Mirroring to d...@mxnet.apache.org

2019-08-05 Thread GitBox
Adesun removed a comment on issue #15749: [RFC][WIP] RFC Issue Mirroring to d...@mxnet.apache.org URL: https://github.com/apache/incubator-mxnet/issues/15749#issuecomment-518178698 thats a good option This is an automated

[incubator-mxnet-site] branch asf-site updated: Bump the publish timestamp.

2019-08-05 Thread marcoabreu
This is an automated email from the ASF dual-hosted git repository. marcoabreu pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-mxnet-site.git The following commit(s) were added to refs/heads/asf-site by this push: new f7062ed Bump the publish

[GitHub] [incubator-mxnet] sxjscience commented on a change in pull request #15581: Numpy-compatible Infra

2019-08-05 Thread GitBox
sxjscience commented on a change in pull request #15581: Numpy-compatible Infra URL: https://github.com/apache/incubator-mxnet/pull/15581#discussion_r310720110 ## File path: python/mxnet/numpy/multiarray.py ## @@ -0,0 +1,2147 @@ +#!/usr/bin/env python + +# Licensed to the

[GitHub] [incubator-mxnet] samskalicky commented on issue #15737: 1.5.0 MKLDNN error "Unknown MKLDNN format"

2019-08-05 Thread GitBox
samskalicky commented on issue #15737: 1.5.0 MKLDNN error "Unknown MKLDNN format" URL: https://github.com/apache/incubator-mxnet/issues/15737#issuecomment-518343733 @pengzhao-intel This is from a public model in the MXNet model zoo. Can you share the PR with the fix and describe the

[GitHub] [incubator-mxnet] haojin2 commented on a change in pull request #15581: Numpy-compatible Infra

2019-08-05 Thread GitBox
haojin2 commented on a change in pull request #15581: Numpy-compatible Infra URL: https://github.com/apache/incubator-mxnet/pull/15581#discussion_r310736891 ## File path: python/mxnet/_ctypes/symbol.py ## @@ -115,7 +116,13 @@ def _set_symbol_class(cls): _symbol_cls =

[GitHub] [incubator-mxnet] eric-haibin-lin merged pull request #15489: Dynamic Library Loading Support

2019-08-05 Thread GitBox
eric-haibin-lin merged pull request #15489: Dynamic Library Loading Support URL: https://github.com/apache/incubator-mxnet/pull/15489 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-mxnet] aaronmarkham merged pull request #15708: DMLC link removal

2019-08-05 Thread GitBox
aaronmarkham merged pull request #15708: DMLC link removal URL: https://github.com/apache/incubator-mxnet/pull/15708 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[incubator-mxnet] branch v1.5.x updated: DMLC link removal (#15708)

2019-08-05 Thread aaronmarkham
This is an automated email from the ASF dual-hosted git repository. aaronmarkham pushed a commit to branch v1.5.x in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git The following commit(s) were added to refs/heads/v1.5.x by this push: new 0a3413f DMLC link removal

[GitHub] [incubator-mxnet] larroy commented on a change in pull request #15489: Dynamic Library Loading Support

2019-08-05 Thread GitBox
larroy commented on a change in pull request #15489: Dynamic Library Loading Support URL: https://github.com/apache/incubator-mxnet/pull/15489#discussion_r310763807 ## File path: tests/python/unittest/test_library_loading.py ## @@ -0,0 +1,38 @@ +# Licensed to the Apache

[GitHub] [incubator-mxnet] zhreshold commented on a change in pull request #15754: Add quantization support for GluonCV

2019-08-05 Thread GitBox
zhreshold commented on a change in pull request #15754: Add quantization support for GluonCV URL: https://github.com/apache/incubator-mxnet/pull/15754#discussion_r310777249 ## File path: python/mxnet/contrib/quantization.py ## @@ -780,3 +820,170 @@ def calib_graph(qsym,

[GitHub] [incubator-mxnet] zhreshold commented on a change in pull request #15754: Add quantization support for GluonCV

2019-08-05 Thread GitBox
zhreshold commented on a change in pull request #15754: Add quantization support for GluonCV URL: https://github.com/apache/incubator-mxnet/pull/15754#discussion_r310776345 ## File path: python/mxnet/contrib/quantization.py ## @@ -780,3 +820,170 @@ def calib_graph(qsym,

[GitHub] [incubator-mxnet] sandeep-krishnamurthy opened a new issue #15757: [Discussion] Unified performance tests and dashboard

2019-08-05 Thread GitBox
sandeep-krishnamurthy opened a new issue #15757: [Discussion] Unified performance tests and dashboard URL: https://github.com/apache/incubator-mxnet/issues/15757 **Problem Statement** 1. Performance tests are not integrated with CI. We do not run any performance tests during PR

[GitHub] [incubator-mxnet] mxnet-label-bot commented on issue #15757: [Discussion] Unified performance tests and dashboard

2019-08-05 Thread GitBox
mxnet-label-bot commented on issue #15757: [Discussion] Unified performance tests and dashboard URL: https://github.com/apache/incubator-mxnet/issues/15757#issuecomment-518388377 Hey, this is the MXNet Label Bot. Thank you for submitting the issue! I will try and suggest some labels

[GitHub] [incubator-mxnet] access2rohit commented on a change in pull request #15593: Large Index Support for Slice

2019-08-05 Thread GitBox
access2rohit commented on a change in pull request #15593: Large Index Support for Slice URL: https://github.com/apache/incubator-mxnet/pull/15593#discussion_r310718738 ## File path: include/mxnet/c_api.h ## @@ -565,6 +567,13 @@ MXNET_DLL int MXNDArrayCreateEx(const

[GitHub] [incubator-mxnet] marcoabreu commented on issue #15749: [RFC][WIP] RFC Issue Mirroring to d...@mxnet.apache.org

2019-08-05 Thread GitBox
marcoabreu commented on issue #15749: [RFC][WIP] RFC Issue Mirroring to d...@mxnet.apache.org URL: https://github.com/apache/incubator-mxnet/issues/15749#issuecomment-518341748 Yeah anything involving the label bot should be blocked if possible

[GitHub] [incubator-mxnet] haojin2 commented on a change in pull request #15581: Numpy-compatible Infra

2019-08-05 Thread GitBox
haojin2 commented on a change in pull request #15581: Numpy-compatible Infra URL: https://github.com/apache/incubator-mxnet/pull/15581#discussion_r310756450 ## File path: src/operator/tensor/broadcast_reduce_op.h ## @@ -977,24 +1037,40 @@ inline void

[GitHub] [incubator-mxnet] marcoabreu commented on a change in pull request #15489: Dynamic Library Loading Support

2019-08-05 Thread GitBox
marcoabreu commented on a change in pull request #15489: Dynamic Library Loading Support URL: https://github.com/apache/incubator-mxnet/pull/15489#discussion_r310766155 ## File path: tests/python/unittest/test_library_loading.py ## @@ -0,0 +1,38 @@ +# Licensed to the

[GitHub] [incubator-mxnet] apeforest commented on a change in pull request #15593: Large Index Support for Slice

2019-08-05 Thread GitBox
apeforest commented on a change in pull request #15593: Large Index Support for Slice URL: https://github.com/apache/incubator-mxnet/pull/15593#discussion_r310780707 ## File path: include/mxnet/c_api.h ## @@ -55,7 +55,9 @@ extern "C" { #endif /*! \brief manually

[GitHub] [incubator-mxnet] apeforest commented on a change in pull request #15593: Large Index Support for Slice

2019-08-05 Thread GitBox
apeforest commented on a change in pull request #15593: Large Index Support for Slice URL: https://github.com/apache/incubator-mxnet/pull/15593#discussion_r310781096 ## File path: include/mxnet/tuple.h ## @@ -366,7 +366,6 @@ class Tuple { } }; - Review comment:

[GitHub] [incubator-mxnet] apeforest commented on a change in pull request #15593: Large Index Support for Slice

2019-08-05 Thread GitBox
apeforest commented on a change in pull request #15593: Large Index Support for Slice URL: https://github.com/apache/incubator-mxnet/pull/15593#discussion_r310783434 ## File path: src/c_api/c_api.cc ## @@ -189,27 +189,46 @@ int MXNDArrayCreateNone(NDArrayHandle *out) {

[GitHub] [incubator-mxnet] access2rohit commented on a change in pull request #15593: Large Index Support for Slice

2019-08-05 Thread GitBox
access2rohit commented on a change in pull request #15593: Large Index Support for Slice URL: https://github.com/apache/incubator-mxnet/pull/15593#discussion_r310787012 ## File path: src/c_api/c_api_common.h ## @@ -80,11 +81,15 @@ struct MXAPIThreadLocalEntry { /*!

[GitHub] [incubator-mxnet] access2rohit commented on a change in pull request #15593: Large Index Support for Slice

2019-08-05 Thread GitBox
access2rohit commented on a change in pull request #15593: Large Index Support for Slice URL: https://github.com/apache/incubator-mxnet/pull/15593#discussion_r310804504 ## File path: include/mxnet/tuple.h ## @@ -366,7 +366,6 @@ class Tuple { } }; - Review

[GitHub] [incubator-mxnet] access2rohit commented on a change in pull request #15593: Large Index Support for Slice

2019-08-05 Thread GitBox
access2rohit commented on a change in pull request #15593: Large Index Support for Slice URL: https://github.com/apache/incubator-mxnet/pull/15593#discussion_r310804533 ## File path: src/c_api/c_api_common.h ## @@ -80,11 +81,15 @@ struct MXAPIThreadLocalEntry { /*!

[GitHub] [incubator-mxnet] IvyBazan commented on issue #15708: DMLC link removal

2019-08-05 Thread GitBox
IvyBazan commented on issue #15708: DMLC link removal URL: https://github.com/apache/incubator-mxnet/pull/15708#issuecomment-518415560 Issues related to missing content: Missing nin content-https://github.com/apache/incubator-mxnet/issues/15729#issuecomment-518131446 Missing nnvm

[GitHub] [incubator-mxnet] haojin2 commented on a change in pull request #15581: Numpy-compatible Infra

2019-08-05 Thread GitBox
haojin2 commented on a change in pull request #15581: Numpy-compatible Infra URL: https://github.com/apache/incubator-mxnet/pull/15581#discussion_r310736470 ## File path: python/mxnet/_ctypes/symbol.py ## @@ -27,6 +27,7 @@ from ..base import check_call _symbol_cls =

[GitHub] [incubator-mxnet] anirudh2290 commented on issue #15716: Increase amp support for Bi-lstm and Concat operators in gluon

2019-08-05 Thread GitBox
anirudh2290 commented on issue #15716: Increase amp support for Bi-lstm and Concat operators in gluon URL: https://github.com/apache/incubator-mxnet/issues/15716#issuecomment-518347956 @ptrendx will take a look. This is an

[GitHub] [incubator-mxnet] haojin2 commented on issue #15753: Numpy add numpy linalg norm and numpy min

2019-08-05 Thread GitBox
haojin2 commented on issue #15753: Numpy add numpy linalg norm and numpy min URL: https://github.com/apache/incubator-mxnet/pull/15753#issuecomment-518384022 @gyshi Please separate this into 2 PRs: one for linalg.norm, the other for np.min.

[GitHub] [incubator-mxnet] apeforest commented on a change in pull request #15593: Large Index Support for Slice

2019-08-05 Thread GitBox
apeforest commented on a change in pull request #15593: Large Index Support for Slice URL: https://github.com/apache/incubator-mxnet/pull/15593#discussion_r310782505 ## File path: src/c_api/c_api_symbolic.cc ## @@ -585,6 +586,96 @@ int MXSymbolInferShape(SymbolHandle sym,

[GitHub] [incubator-mxnet] access2rohit commented on a change in pull request #15593: Large Index Support for Slice

2019-08-05 Thread GitBox
access2rohit commented on a change in pull request #15593: Large Index Support for Slice URL: https://github.com/apache/incubator-mxnet/pull/15593#discussion_r310784456 ## File path: src/c_api/c_api.cc ## @@ -189,27 +189,46 @@ int MXNDArrayCreateNone(NDArrayHandle *out) {

[GitHub] [incubator-mxnet] samskalicky commented on issue #15489: Dynamic Library Loading Support

2019-08-05 Thread GitBox
samskalicky commented on issue #15489: Dynamic Library Loading Support URL: https://github.com/apache/incubator-mxnet/pull/15489#issuecomment-518393421 Thanks @marcoabreu for the catch. As we discussed offline, the problem is not with the feature in this PR but with how

[incubator-mxnet-site] branch asf-site updated: Bump the publish timestamp.

2019-08-05 Thread marcoabreu
This is an automated email from the ASF dual-hosted git repository. marcoabreu pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-mxnet-site.git The following commit(s) were added to refs/heads/asf-site by this push: new e128999 Bump the publish

[GitHub] [incubator-mxnet] haojin2 commented on a change in pull request #15699: Numpy take operator implementation & bug fix in ndarray.take

2019-08-05 Thread GitBox
haojin2 commented on a change in pull request #15699: Numpy take operator implementation & bug fix in ndarray.take URL: https://github.com/apache/incubator-mxnet/pull/15699#discussion_r310810460 ## File path: python/mxnet/numpy/multiarray.py ## @@ -1879,6 +1879,85 @@ def

[GitHub] [incubator-mxnet] leleamol commented on a change in pull request #15489: Dynamic Library Loading Support

2019-08-05 Thread GitBox
leleamol commented on a change in pull request #15489: Dynamic Library Loading Support URL: https://github.com/apache/incubator-mxnet/pull/15489#discussion_r310719376 ## File path: src/common/library.cc ## @@ -0,0 +1,104 @@ +/* + * Licensed to the Apache Software

[GitHub] [incubator-mxnet] haojin2 commented on a change in pull request #15581: Numpy-compatible Infra

2019-08-05 Thread GitBox
haojin2 commented on a change in pull request #15581: Numpy-compatible Infra URL: https://github.com/apache/incubator-mxnet/pull/15581#discussion_r310737714 ## File path: src/operator/tensor/broadcast_reduce_op.h ## @@ -168,15 +168,24 @@ struct BroadcastLikeParam : public

[incubator-mxnet] branch master updated (3255d87 -> 3112893)

2019-08-05 Thread haibin
This is an automated email from the ASF dual-hosted git repository. haibin pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git. from 3255d87 fix broadcast op param (#15714) add 3112893 Dynamic Library Loading Support (#15489) No new

[GitHub] [incubator-mxnet] marcoabreu commented on a change in pull request #15489: Dynamic Library Loading Support

2019-08-05 Thread GitBox
marcoabreu commented on a change in pull request #15489: Dynamic Library Loading Support URL: https://github.com/apache/incubator-mxnet/pull/15489#discussion_r310757672 ## File path: tests/python/unittest/test_library_loading.py ## @@ -0,0 +1,38 @@ +# Licensed to the

[GitHub] [incubator-mxnet] ptrendx opened a new pull request #15756: Fix flaky test test_global_metric

2019-08-05 Thread GitBox
ptrendx opened a new pull request #15756: Fix flaky test test_global_metric URL: https://github.com/apache/incubator-mxnet/pull/15756 ## Description ## Fixes #15592 The reason for assertion failure was that sometimes the random inputs would produce `nan` as a result, which would

[GitHub] [incubator-mxnet] larroy commented on a change in pull request #15489: Dynamic Library Loading Support

2019-08-05 Thread GitBox
larroy commented on a change in pull request #15489: Dynamic Library Loading Support URL: https://github.com/apache/incubator-mxnet/pull/15489#discussion_r310763807 ## File path: tests/python/unittest/test_library_loading.py ## @@ -0,0 +1,38 @@ +# Licensed to the Apache

[GitHub] [incubator-mxnet] aaronmarkham commented on issue #15708: DMLC link removal

2019-08-05 Thread GitBox
aaronmarkham commented on issue #15708: DMLC link removal URL: https://github.com/apache/incubator-mxnet/pull/15708#issuecomment-518380481 @marcoabreu Sorry about rushing that through without addressing your questions. We needed to be rid of the malware links ASAP. @IvyBazan Can you

[GitHub] [incubator-mxnet] apeforest commented on a change in pull request #15593: Large Index Support for Slice

2019-08-05 Thread GitBox
apeforest commented on a change in pull request #15593: Large Index Support for Slice URL: https://github.com/apache/incubator-mxnet/pull/15593#discussion_r310782296 ## File path: src/c_api/c_api_common.h ## @@ -80,11 +81,15 @@ struct MXAPIThreadLocalEntry { /*! \brief

[GitHub] [incubator-mxnet] apeforest commented on a change in pull request #15593: Large Index Support for Slice

2019-08-05 Thread GitBox
apeforest commented on a change in pull request #15593: Large Index Support for Slice URL: https://github.com/apache/incubator-mxnet/pull/15593#discussion_r310782321 ## File path: src/c_api/c_api_common.h ## @@ -80,11 +81,15 @@ struct MXAPIThreadLocalEntry { /*! \brief

[GitHub] [incubator-mxnet] access2rohit commented on a change in pull request #15593: Large Index Support for Slice

2019-08-05 Thread GitBox
access2rohit commented on a change in pull request #15593: Large Index Support for Slice URL: https://github.com/apache/incubator-mxnet/pull/15593#discussion_r310786940 ## File path: src/c_api/c_api_symbolic.cc ## @@ -658,6 +658,85 @@ int MXSymbolInferShapeEx(SymbolHandle

[GitHub] [incubator-mxnet] marcoabreu commented on issue #15489: Dynamic Library Loading Support

2019-08-05 Thread GitBox
marcoabreu commented on issue #15489: Dynamic Library Loading Support URL: https://github.com/apache/incubator-mxnet/pull/15489#issuecomment-518399555 > We'll move the test pulling from the S3 bucket to the examples directory so that it doesnt run in the CI. Could you elaborate?

[GitHub] [incubator-mxnet] samskalicky commented on issue #15489: Dynamic Library Loading Support

2019-08-05 Thread GitBox
samskalicky commented on issue #15489: Dynamic Library Loading Support URL: https://github.com/apache/incubator-mxnet/pull/15489#issuecomment-518404947 @marcoabreu we added an example directory at: example/lib_api. Currently the test.py includes a test that uses the locally built library

[GitHub] [incubator-mxnet] haojin2 commented on a change in pull request #15699: Numpy take operator implementation & bug fix in ndarray.take

2019-08-05 Thread GitBox
haojin2 commented on a change in pull request #15699: Numpy take operator implementation & bug fix in ndarray.take URL: https://github.com/apache/incubator-mxnet/pull/15699#discussion_r310809625 ## File path: src/operator/tensor/indexing_op.h ## @@ -341,6 +341,53 @@

[GitHub] [incubator-mxnet] haojin2 commented on a change in pull request #15699: Numpy take operator implementation & bug fix in ndarray.take

2019-08-05 Thread GitBox
haojin2 commented on a change in pull request #15699: Numpy take operator implementation & bug fix in ndarray.take URL: https://github.com/apache/incubator-mxnet/pull/15699#discussion_r310810220 ## File path: python/mxnet/ndarray/numpy/_op.py ## @@ -590,6 +590,88 @@ def

[GitHub] [incubator-mxnet] sxjscience commented on issue #15751: Fix the bug of `MXEnginePushAsyncND` and `MXEnginePushSyncND`

2019-08-05 Thread GitBox
sxjscience commented on issue #15751: Fix the bug of `MXEnginePushAsyncND` and `MXEnginePushSyncND` URL: https://github.com/apache/incubator-mxnet/pull/15751#issuecomment-518338420 Why did the code pass the previous tests?

[incubator-mxnet-site] branch asf-site updated: Bump the publish timestamp.

2019-08-05 Thread marcoabreu
This is an automated email from the ASF dual-hosted git repository. marcoabreu pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-mxnet-site.git The following commit(s) were added to refs/heads/asf-site by this push: new e130fcc Bump the publish

[GitHub] [incubator-mxnet] larroy commented on a change in pull request #15581: Numpy-compatible Infra

2019-08-05 Thread GitBox
larroy commented on a change in pull request #15581: Numpy-compatible Infra URL: https://github.com/apache/incubator-mxnet/pull/15581#discussion_r310761132 ## File path: include/mxnet/tuple.h ## @@ -272,6 +272,14 @@ class Tuple { is.get(); if (ch == '(' || ch

[GitHub] [incubator-mxnet] apeforest commented on a change in pull request #15593: Large Index Support for Slice

2019-08-05 Thread GitBox
apeforest commented on a change in pull request #15593: Large Index Support for Slice URL: https://github.com/apache/incubator-mxnet/pull/15593#discussion_r310781490 ## File path: python/mxnet/ndarray/ndarray.py ## @@ -131,14 +133,24 @@ def _new_alloc_handle(shape, ctx,

[GitHub] [incubator-mxnet] samskalicky edited a comment on issue #15489: Dynamic Library Loading Support

2019-08-05 Thread GitBox
samskalicky edited a comment on issue #15489: Dynamic Library Loading Support URL: https://github.com/apache/incubator-mxnet/pull/15489#issuecomment-518393421 Thanks @marcoabreu for the catch. As we discussed offline, the problem is not with the feature in this PR but with how

[GitHub] [incubator-mxnet] haojin2 commented on a change in pull request #15699: Numpy take operator implementation & bug fix in ndarray.take

2019-08-05 Thread GitBox
haojin2 commented on a change in pull request #15699: Numpy take operator implementation & bug fix in ndarray.take URL: https://github.com/apache/incubator-mxnet/pull/15699#discussion_r31081 ## File path: src/operator/numpy/indexing_op.cc ## @@ -0,0 +1,158 @@ +/* + *

[GitHub] [incubator-mxnet] haojin2 commented on a change in pull request #15581: Numpy-compatible Infra

2019-08-05 Thread GitBox
haojin2 commented on a change in pull request #15581: Numpy-compatible Infra URL: https://github.com/apache/incubator-mxnet/pull/15581#discussion_r310737246 ## File path: python/mxnet/base.py ## @@ -735,7 +739,121 @@ def write_all_str(module_file, module_all_list):

[incubator-mxnet] branch revert-15489-acc_api created (now 1e97b86)

2019-08-05 Thread marcoabreu
This is an automated email from the ASF dual-hosted git repository. marcoabreu pushed a change to branch revert-15489-acc_api in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git. at 1e97b86 Revert "Dynamic Library Loading Support (#15489)" This branch includes the

[incubator-mxnet] 01/01: Revert "Dynamic Library Loading Support (#15489)"

2019-08-05 Thread marcoabreu
This is an automated email from the ASF dual-hosted git repository. marcoabreu pushed a commit to branch revert-15489-acc_api in repository https://gitbox.apache.org/repos/asf/incubator-mxnet.git commit 1e97b86e7027dc3adbf467aab90cee3ea3f6f236 Author: Marco de Abreu AuthorDate: Mon Aug 5

[GitHub] [incubator-mxnet] marcoabreu opened a new pull request #15755: Revert "Dynamic Library Loading Support"

2019-08-05 Thread GitBox
marcoabreu opened a new pull request #15755: Revert "Dynamic Library Loading Support" URL: https://github.com/apache/incubator-mxnet/pull/15755 Reverts apache/incubator-mxnet#15489 Reason is the fact that this change poses a security risk:

[GitHub] [incubator-mxnet] marcoabreu commented on a change in pull request #15489: Dynamic Library Loading Support

2019-08-05 Thread GitBox
marcoabreu commented on a change in pull request #15489: Dynamic Library Loading Support URL: https://github.com/apache/incubator-mxnet/pull/15489#discussion_r310757672 ## File path: tests/python/unittest/test_library_loading.py ## @@ -0,0 +1,38 @@ +# Licensed to the

[GitHub] [incubator-mxnet] larroy commented on a change in pull request #15581: Numpy-compatible Infra

2019-08-05 Thread GitBox
larroy commented on a change in pull request #15581: Numpy-compatible Infra URL: https://github.com/apache/incubator-mxnet/pull/15581#discussion_r310761998 ## File path: include/mxnet/tuple.h ## @@ -653,6 +661,13 @@ inline bool shape_is_known(const TShape& x) { return

[GitHub] [incubator-mxnet] larroy commented on a change in pull request #15581: Numpy-compatible Infra

2019-08-05 Thread GitBox
larroy commented on a change in pull request #15581: Numpy-compatible Infra URL: https://github.com/apache/incubator-mxnet/pull/15581#discussion_r310762141 ## File path: python/mxnet/base.py ## @@ -735,7 +739,121 @@ def write_all_str(module_file, module_all_list):

[GitHub] [incubator-mxnet] larroy commented on a change in pull request #15581: Numpy-compatible Infra

2019-08-05 Thread GitBox
larroy commented on a change in pull request #15581: Numpy-compatible Infra URL: https://github.com/apache/incubator-mxnet/pull/15581#discussion_r310761998 ## File path: include/mxnet/tuple.h ## @@ -653,6 +661,13 @@ inline bool shape_is_known(const TShape& x) { return

[GitHub] [incubator-mxnet] access2rohit commented on a change in pull request #15593: Large Index Support for Slice

2019-08-05 Thread GitBox
access2rohit commented on a change in pull request #15593: Large Index Support for Slice URL: https://github.com/apache/incubator-mxnet/pull/15593#discussion_r310784456 ## File path: src/c_api/c_api.cc ## @@ -189,27 +189,46 @@ int MXNDArrayCreateNone(NDArrayHandle *out) {

[GitHub] [incubator-mxnet] marcoabreu commented on issue #15757: [Discussion] Unified performance tests and dashboard

2019-08-05 Thread GitBox
marcoabreu commented on issue #15757: [Discussion] Unified performance tests and dashboard URL: https://github.com/apache/incubator-mxnet/issues/15757#issuecomment-518404430 We can't use the CI system for performance measurements since it does not provide a consistent environment for

[GitHub] [incubator-mxnet] IvyBazan commented on issue #15708: DMLC link removal

2019-08-05 Thread GitBox
IvyBazan commented on issue #15708: DMLC link removal URL: https://github.com/apache/incubator-mxnet/pull/15708#issuecomment-518410177 @marcoabreu I removed those links because I couldn't find any replacement for the content that was hosted on dmlc.ml. It seems better to temporarily have

[GitHub] [incubator-mxnet] wkcn commented on issue #15751: Fix the bug of `MXEnginePushAsyncND` and `MXEnginePushSyncND`

2019-08-05 Thread GitBox
wkcn commented on issue #15751: Fix the bug of `MXEnginePushAsyncND` and `MXEnginePushSyncND` URL: https://github.com/apache/incubator-mxnet/pull/15751#issuecomment-518416439 @sxjscience The previous test is also wrong. In the previous test, I passed the memory address of a NDArray into

[GitHub] [incubator-mxnet] haojin2 commented on a change in pull request #15699: Numpy take operator implementation & bug fix in ndarray.take

2019-08-05 Thread GitBox
haojin2 commented on a change in pull request #15699: Numpy take operator implementation & bug fix in ndarray.take URL: https://github.com/apache/incubator-mxnet/pull/15699#discussion_r310808895 ## File path: src/operator/tensor/indexing_op.h ## @@ -341,6 +341,53 @@

[GitHub] [incubator-mxnet] vdantu commented on issue #15734: How to get computation cost and communication cost in distributed training?

2019-08-05 Thread GitBox
vdantu commented on issue #15734: How to get computation cost and communication cost in distributed training? URL: https://github.com/apache/incubator-mxnet/issues/15734#issuecomment-518424537 @mxnet-label-bot add [question, training] @apeforest @yuxihu : Would you be able to help

  1   2   >