[GitHub] utzig commented on issue #140: newt - Repo dependencies

utzig commented on issue #140: newt - Repo dependencies URL: https://github.com/apache/mynewt-newt/pull/140#issuecomment-371226257 Could you break this into multiple PRs that build feature by feature? Just kidding, the code looks really good and the comments are a very nice addition. I

[GitHub] utzig commented on a change in pull request #140: newt - Repo dependencies

utzig commented on a change in pull request #140: newt - Repo dependencies URL: https://github.com/apache/mynewt-newt/pull/140#discussion_r172960416 ## File path: newt/downloader/downloader.go ## @@ -667,8 +667,8 @@ func (ld *LocalDownloader) CurrentBranch(path string)

[GitHub] michal-narajowski commented on issue #864: JSON library's array count not incrementing

michal-narajowski commented on issue #864: JSON library's array count not incrementing URL: https://github.com/apache/mynewt-core/issues/864#issuecomment-371231496 Hi @adityaxavier, I found some issues with your code and an issue in JSON library code. I submitted a pull request

[GitHub] ccollins476ad commented on a change in pull request #140: newt - Repo dependencies

ccollins476ad commented on a change in pull request #140: newt - Repo dependencies URL: https://github.com/apache/mynewt-newt/pull/140#discussion_r172955343 ## File path: newt/project/project.go ## @@ -198,177 +209,350 @@ func (proj *Project) Warnings() []string {

[GitHub] ccollins476ad commented on a change in pull request #140: newt - Repo dependencies

ccollins476ad commented on a change in pull request #140: newt - Repo dependencies URL: https://github.com/apache/mynewt-newt/pull/140#discussion_r172955379 ## File path: newt/repo/repo.go ## @@ -3,7 +3,7 @@ * or more contributor license agreements. See the NOTICE file

[GitHub] wes3 opened a new pull request #887: net/lora: Update sx1272 to latest semtech code.

wes3 opened a new pull request #887: net/lora: Update sx1272 to latest semtech code. URL: https://github.com/apache/mynewt-core/pull/887 Decided to bring this file up to date with latest code in semtech repo. Changes were all coding style except for the setting of FIFO address

[GitHub] michal-narajowski commented on issue #864: JSON library's array count not incrementing

michal-narajowski commented on issue #864: JSON library's array count not incrementing URL: https://github.com/apache/mynewt-core/issues/864#issuecomment-371231496 Hi @adityaxavier, I found some issues with your code and an issue in JSON library code. I submitted a pull request

[GitHub] ccollins476ad commented on a change in pull request #140: newt - Repo dependencies

ccollins476ad commented on a change in pull request #140: newt - Repo dependencies URL: https://github.com/apache/mynewt-newt/pull/140#discussion_r172954972 ## File path: newt/downloader/downloader.go ## @@ -667,8 +667,8 @@ func (ld *LocalDownloader) CurrentBranch(path

[GitHub] ccollins476ad commented on a change in pull request #140: newt - Repo dependencies

ccollins476ad commented on a change in pull request #140: newt - Repo dependencies URL: https://github.com/apache/mynewt-newt/pull/140#discussion_r172954881 ## File path: newt/repo/repo.go ## @@ -596,18 +499,18 @@ func (r *Repo) Sync(vers *Version, force bool) (bool,

[GitHub] mkiiskila opened a new pull request #885: sys/config; add conf_save_tree() which saves config for single subsystem.

mkiiskila opened a new pull request #885: sys/config; add conf_save_tree() which saves config for single subsystem. URL: https://github.com/apache/mynewt-core/pull/885 This is an automated message from the Apache Git

[GitHub] ccollins476ad opened a new pull request #886: lwip - Fix time calculation

ccollins476ad opened a new pull request #886: lwip - Fix time calculation URL: https://github.com/apache/mynewt-core/pull/886 The `sys_now` function is supposed to calculate milliseconds since boot. However, the operands were not in the correct order, so the units were off. In sim,

[mynewt-core] 01/01: Merge pull request #886 from ccollins476ad/lwip-now

This is an automated email from the ASF dual-hosted git repository. ccollins pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/mynewt-core.git commit cf619127b1de35699f864726b2a00bf03da0ba17 Merge: 5a38381 a5650f9 Author: ccollins476ad

[mynewt-core] 01/01: Merge pull request #887 from wes3/sx1272_update

This is an automated email from the ASF dual-hosted git repository. wes3 pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/mynewt-core.git commit 5a38381d21900d7d3ad07509c2a78ef9b7c779dc Merge: 23c507e 2241e9d Author: wes3 AuthorDate: Wed Mar 7

[GitHub] wes3 closed pull request #887: net/lora: Update sx1272 to latest semtech code.

wes3 closed pull request #887: net/lora: Update sx1272 to latest semtech code. URL: https://github.com/apache/mynewt-core/pull/887 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[mynewt-core] branch master updated (23c507e -> 5a38381)

This is an automated email from the ASF dual-hosted git repository. wes3 pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/mynewt-core.git. from 23c507e Update README to document minimal console add 2241e9d net/lora: Update sx1272 to latest semtech

[GitHub] ccollins476ad closed pull request #886: lwip - Fix time calculation

ccollins476ad closed pull request #886: lwip - Fix time calculation URL: https://github.com/apache/mynewt-core/pull/886 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[mynewt-core] branch master updated (5a38381 -> cf61912)

This is an automated email from the ASF dual-hosted git repository. ccollins pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/mynewt-core.git. from 5a38381 Merge pull request #887 from wes3/sx1272_update add 30ddf67 lwip - Fix time calculation.

[GitHub] michal-narajowski closed pull request #871: nimble/ll: Allow setting scan rsp data before configuring advertising

michal-narajowski closed pull request #871: nimble/ll: Allow setting scan rsp data before configuring advertising URL: https://github.com/apache/mynewt-core/pull/871 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the

[mynewt-core] branch master updated (8f0a8d5 -> 356528c)

This is an automated email from the ASF dual-hosted git repository. andk pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/mynewt-core.git. from 8f0a8d5 Merge pull request #871 from michal-narajowski/ll-legacy-adv-fix add 29d5d03 nimble/ll: Update

[GitHub] utzig commented on a change in pull request #140: newt - Repo dependencies

utzig commented on a change in pull request #140: newt - Repo dependencies URL: https://github.com/apache/mynewt-newt/pull/140#discussion_r172846489 ## File path: newt/project/project.go ## @@ -198,177 +209,350 @@ func (proj *Project) Warnings() []string { return

[GitHub] sjanc commented on a change in pull request #882: libc: Add support for float in printf

sjanc commented on a change in pull request #882: libc: Add support for float in printf URL: https://github.com/apache/mynewt-core/pull/882#discussion_r172848803 ## File path: libc/baselibc/src/tinyprintf.c ## @@ -337,6 +342,50 @@ size_t tfp_format(FILE *putp, const char

[GitHub] sjanc commented on a change in pull request #882: libc: Add support for float in printf

sjanc commented on a change in pull request #882: libc: Add support for float in printf URL: https://github.com/apache/mynewt-core/pull/882#discussion_r172842782 ## File path: libc/baselibc/src/tinyprintf.c ## @@ -337,6 +342,50 @@ size_t tfp_format(FILE *putp, const char

[GitHub] utzig commented on a change in pull request #140: newt - Repo dependencies

utzig commented on a change in pull request #140: newt - Repo dependencies URL: https://github.com/apache/mynewt-newt/pull/140#discussion_r172847193 ## File path: newt/downloader/downloader.go ## @@ -667,8 +667,8 @@ func (ld *LocalDownloader) CurrentBranch(path string)

[GitHub] rymanluk opened a new pull request #866: nimble/dtm: Couple of improvements helping in RF testing.

rymanluk opened a new pull request #866: nimble/dtm: Couple of improvements helping in RF testing. URL: https://github.com/apache/mynewt-core/pull/866 This is an automated message from the Apache Git Service. To respond to

[GitHub] michal-narajowski opened a new pull request #882: libc: Add support for float in printf

michal-narajowski opened a new pull request #882: libc: Add support for float in printf URL: https://github.com/apache/mynewt-core/pull/882 This implementation supports only 3 decimal digits. Left-align is not supported. When specifying width it is counted with 3 decimal digits,

[GitHub] rymanluk opened a new pull request #883: nimble/ll: Improve extended scan/connect when host request both PHYs to be used

rymanluk opened a new pull request #883: nimble/ll: Improve extended scan/connect when host request both PHYs to be used URL: https://github.com/apache/mynewt-core/pull/883 This is an automated message from the Apache Git

[GitHub] utzig commented on a change in pull request #140: newt - Repo dependencies

utzig commented on a change in pull request #140: newt - Repo dependencies URL: https://github.com/apache/mynewt-newt/pull/140#discussion_r172831920 ## File path: newt/repo/repo.go ## @@ -3,7 +3,7 @@ * or more contributor license agreements. See the NOTICE file *