Re: [PR] sched/taskfiles: skip unnecessary file open/close operations to improve performance [nuttx]

2023-11-14 Thread via GitHub
anchao commented on code in PR #11177: URL: https://github.com/apache/nuttx/pull/11177#discussion_r1393790669 ## sched/task/task_spawnparms.c: ## @@ -289,3 +291,70 @@ int spawn_file_actions(FAR struct tcb_s *tcb, return ret; } +

Re: [PR] task/pthread_cancelpt: Move cancel point handling to libc, data to TLS [nuttx]

2023-11-14 Thread via GitHub
pussuw commented on code in PR #11165: URL: https://github.com/apache/nuttx/pull/11165#discussion_r1393736227 ## sched/pthread/pthread_condclockwait.c: ## @@ -104,7 +105,7 @@ int pthread_cond_clockwait(FAR pthread_cond_t *cond, else if (!abstime) { - ret =

Re: [PR] sched/taskfiles: skip unnecessary file open/close operations to improve performance [nuttx]

2023-11-14 Thread via GitHub
pussuw commented on PR #11177: URL: https://github.com/apache/nuttx/pull/11177#issuecomment-1811904683 > > This should be fine from the kernel mode point of view now. I'm just wondering will we lose the benefit from your optimizations because of the copying ? > > This may depend on

Re: [PR] sched/taskfiles: skip unnecessary file open/close operations to improve performance [nuttx]

2023-11-14 Thread via GitHub
anchao commented on code in PR #11177: URL: https://github.com/apache/nuttx/pull/11177#discussion_r1393641304 ## binfmt/binfmt_execmodule.c: ## @@ -256,6 +257,12 @@ int exec_module(FAR struct binary_s *binp, goto errout_with_args; } + ret = binfmt_copyactions(,

Re: [PR] sched/taskfiles: skip unnecessary file open/close operations to improve performance [nuttx]

2023-11-14 Thread via GitHub
anchao commented on PR #11177: URL: https://github.com/apache/nuttx/pull/11177#issuecomment-1811808812 > This should be fine from the kernel mode point of view now. I'm just wondering will we lose the benefit from your optimizations because of the copying ? This may depend on the

[I] Unexpected behaviour with poll and tickless scheduler [nuttx]

2023-11-14 Thread via GitHub
g2gps opened a new issue, #11189: URL: https://github.com/apache/nuttx/issues/11189 Hello, I'm using poll in conjunction with timerfds and the `POLLIN` event to schedule actions at different rates. I'm finding that when `CONFIG_SCHED_TICKLESS` is used, poll is returning with only a

Re: [PR] sched/taskfiles: skip unnecessary file open/close operations to improve performance [nuttx]

2023-11-14 Thread via GitHub
anchao commented on code in PR #11177: URL: https://github.com/apache/nuttx/pull/11177#discussion_r1393621487 ## include/nuttx/spawn.h: ## @@ -100,9 +100,14 @@ extern "C" void add_file_action(FAR posix_spawn_file_actions_t *file_action, FAR struct

(nuttx) 01/02: adjtime: Rewrite implementation to work for RTC and tickless kernel

2023-11-14 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit 1825f9534c2e76ec94f772651b6036dd9efa4004 Author: Petteri Aimonen AuthorDate: Tue Nov 14 13:52:53 2023 +0200

(nuttx) 02/02: stm32/samv7: Update SysTick drivers to new up_adjtime() API.

2023-11-14 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit 6dabcd567ec9a2f91431f25ef0c892f51b2ac4a5 Author: Petteri Aimonen AuthorDate: Tue Nov 14 13:58:12 2023 +0200

(nuttx) branch master updated (4033018a72 -> 6dabcd567e)

2023-11-14 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from 4033018a72 xtensa/esp32s3: Add XTWDT support new 1825f9534c adjtime: Rewrite implementation to work for RTC

Re: [PR] Rewrite adjtime() implementation to work for RTC and tickless kernel [nuttx]

2023-11-14 Thread via GitHub
xiaoxiang781216 merged PR #11186: URL: https://github.com/apache/nuttx/pull/11186 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] task/pthread_cancelpt: Move cancel point handling to libc, data to TLS [nuttx]

2023-11-14 Thread via GitHub
xiaoxiang781216 commented on code in PR #11165: URL: https://github.com/apache/nuttx/pull/11165#discussion_r1393601024 ## sched/pthread/pthread_condclockwait.c: ## @@ -104,7 +105,7 @@ int pthread_cond_clockwait(FAR pthread_cond_t *cond, else if (!abstime) { - ret

Re: [PR] the bug of sscanf exception output in arm64 platform [nuttx]

2023-11-14 Thread via GitHub
Boatingup commented on code in PR #11182: URL: https://github.com/apache/nuttx/pull/11182#discussion_r1393550803 ## libs/libc/stdio/lib_libvscanf.c: ## @@ -315,6 +315,37 @@ int lib_vscanf(FAR struct lib_instream_s *stream, FAR int *lastc, fmt++;

(nuttx-website) branch asf-site updated: Publishing web: 36ddd7c60a8230335eda886c909bc938739114a2 docs: 4033018a724d5dca8a68a43928d8f6ada5ce3439

2023-11-14 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/nuttx-website.git The following commit(s) were added to refs/heads/asf-site by this push: new 5f59908e Publishing web:

(nuttx) branch master updated (d63034994e -> 4033018a72)

2023-11-14 Thread acassis
This is an automated email from the ASF dual-hosted git repository. acassis pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from d63034994e fs/inode: check file list before memcpy add 4033018a72 xtensa/esp32s3: Add XTWDT support No new

Re: [PR] xtensa/esp32s3: Add XTWDT support [nuttx]

2023-11-14 Thread via GitHub
acassis merged PR #11179: URL: https://github.com/apache/nuttx/pull/11179 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(nuttx) branch master updated: fs/inode: check file list before memcpy

2023-11-14 Thread acassis
This is an automated email from the ASF dual-hosted git repository. acassis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new d63034994e fs/inode: check file list before

Re: [PR] fs/inode: check file list before memcpy [nuttx]

2023-11-14 Thread via GitHub
acassis merged PR #11188: URL: https://github.com/apache/nuttx/pull/11188 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] sched/taskfiles: skip unnecessary file open/close operations to improve performance [nuttx]

2023-11-14 Thread via GitHub
pussuw commented on PR #11177: URL: https://github.com/apache/nuttx/pull/11177#issuecomment-1811079492 This should be fine from the kernel mode point of view now. I'm just wondering will we lose the benefit from your optimizations because of the copying ? -- This is an automated message

Re: [PR] task/pthread_cancelpt: Move cancel point handling to libc, data to TLS [nuttx]

2023-11-14 Thread via GitHub
pussuw commented on code in PR #11165: URL: https://github.com/apache/nuttx/pull/11165#discussion_r1393167474 ## sched/pthread/pthread_condclockwait.c: ## @@ -104,7 +105,7 @@ int pthread_cond_clockwait(FAR pthread_cond_t *cond, else if (!abstime) { - ret =

Re: [PR] task/pthread_cancelpt: Move cancel point handling to libc, data to TLS [nuttx]

2023-11-14 Thread via GitHub
pussuw commented on code in PR #11165: URL: https://github.com/apache/nuttx/pull/11165#discussion_r1393167474 ## sched/pthread/pthread_condclockwait.c: ## @@ -104,7 +105,7 @@ int pthread_cond_clockwait(FAR pthread_cond_t *cond, else if (!abstime) { - ret =

Re: [PR] sched/taskfiles: skip unnecessary file open/close operations to improve performance [nuttx]

2023-11-14 Thread via GitHub
xiaoxiang781216 commented on code in PR #11177: URL: https://github.com/apache/nuttx/pull/11177#discussion_r1393043346 ## sched/task/task_spawnparms.c: ## @@ -289,3 +291,70 @@ int spawn_file_actions(FAR struct tcb_s *tcb, return ret; } +

Re: [PR] sched/taskfiles: skip unnecessary file open/close operations to improve performance [nuttx]

2023-11-14 Thread via GitHub
anchao commented on code in PR #11177: URL: https://github.com/apache/nuttx/pull/11177#discussion_r1393021044 ## binfmt/binfmt_execmodule.c: ## @@ -310,12 +317,14 @@ int exec_module(FAR struct binary_s *binp, if (argv && argv[0]) { ret = nxtask_init(tcb, argv[0],

Re: [PR] sched/taskfiles: skip unnecessary file open/close operations to improve performance [nuttx]

2023-11-14 Thread via GitHub
anchao commented on code in PR #11177: URL: https://github.com/apache/nuttx/pull/11177#discussion_r1393018450 ## fs/inode/fs_files.c: ## @@ -408,7 +409,9 @@ int file_allocate_from_tcb(FAR struct tcb_s *tcb, FAR struct inode *inode, return ret; } - filep =

Re: [PR] sched/taskfiles: skip unnecessary file open/close operations to improve performance [nuttx]

2023-11-14 Thread via GitHub
anchao commented on code in PR #11177: URL: https://github.com/apache/nuttx/pull/11177#discussion_r1393016153 ## sched/task/task_spawnparms.c: ## @@ -289,3 +291,70 @@ int spawn_file_actions(FAR struct tcb_s *tcb, return ret; } +

Re: [PR] sched/taskfiles: skip unnecessary file open/close operations to improve performance [nuttx]

2023-11-14 Thread via GitHub
anchao commented on code in PR #11177: URL: https://github.com/apache/nuttx/pull/11177#discussion_r1393013541 ## sched/task/task_spawnparms.c: ## @@ -289,3 +291,70 @@ int spawn_file_actions(FAR struct tcb_s *tcb, return ret; } +

Re: [PR] sched/taskfiles: skip unnecessary file open/close operations to improve performance [nuttx]

2023-11-14 Thread via GitHub
anchao commented on code in PR #11177: URL: https://github.com/apache/nuttx/pull/11177#discussion_r1393011182 ## binfmt/binfmt_copyactions.c: ## @@ -0,0 +1,183 @@ +/ + * binfmt/binfmt_copyactions.c + *

Re: [PR] sched/taskfiles: skip unnecessary file open/close operations to improve performance [nuttx]

2023-11-14 Thread via GitHub
anchao commented on code in PR #11177: URL: https://github.com/apache/nuttx/pull/11177#discussion_r1393007557 ## binfmt/binfmt_copyactions.c: ## @@ -0,0 +1,183 @@ +/ + * binfmt/binfmt_copyactions.c + *

Re: [PR] sched/taskfiles: skip unnecessary file open/close operations to improve performance [nuttx]

2023-11-14 Thread via GitHub
anchao commented on code in PR #11177: URL: https://github.com/apache/nuttx/pull/11177#discussion_r1393006471 ## binfmt/binfmt_copyactions.c: ## @@ -0,0 +1,183 @@ +/ + * binfmt/binfmt_copyactions.c + *

Re: [PR] sched/taskfiles: skip unnecessary file open/close operations to improve performance [nuttx]

2023-11-14 Thread via GitHub
anchao commented on code in PR #11177: URL: https://github.com/apache/nuttx/pull/11177#discussion_r1393005563 ## binfmt/binfmt_copyactions.c: ## @@ -0,0 +1,183 @@ +/ + * binfmt/binfmt_copyactions.c + *

Re: [PR] sched/taskfiles: skip unnecessary file open/close operations to improve performance [nuttx]

2023-11-14 Thread via GitHub
anchao commented on code in PR #11177: URL: https://github.com/apache/nuttx/pull/11177#discussion_r1393004962 ## binfmt/Makefile: ## @@ -25,7 +25,7 @@ include $(TOPDIR)/Make.defs CSRCS = binfmt_globals.c binfmt_initialize.c binfmt_register.c binfmt_unregister.c CSRCS +=

(nuttx-apps) 03/03: examples/foc: pass from velocity controller to torque controller

2023-11-14 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git commit 9eb5bd409176ecf1a0ba5e32afceb9a32650ac7d Author: raiden00pl AuthorDate: Thu Nov 9 12:43:46 2023 +0100

(nuttx-apps) 02/03: examples/foc: add torque saturation

2023-11-14 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git commit ce53f0fc4cd85e2dda52da523dc51491efd1a925 Author: raiden00pl AuthorDate: Thu Nov 9 12:22:31 2023 +0100

(nuttx-apps) 01/03: examples/foc: add velocity saturation

2023-11-14 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git commit dc4330476d09ef6bd1aaa357480d060e5cb3f1f0 Author: raiden00pl AuthorDate: Thu Nov 9 12:05:28 2023 +0100

(nuttx-apps) branch master updated (32a8c2975 -> 9eb5bd409)

2023-11-14 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git from 32a8c2975 examples/foc: don't raise error when EXAMPLES_FOC_IPHASE_ADC isn't set new dc4330476

Re: [PR] examples/foc: refactor motor controller [nuttx-apps]

2023-11-14 Thread via GitHub
xiaoxiang781216 merged PR #2195: URL: https://github.com/apache/nuttx-apps/pull/2195 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] sched/taskfiles: skip unnecessary file open/close operations to improve performance [nuttx]

2023-11-14 Thread via GitHub
xiaoxiang781216 commented on code in PR #11177: URL: https://github.com/apache/nuttx/pull/11177#discussion_r1392951414 ## binfmt/binfmt_copyactions.c: ## @@ -0,0 +1,183 @@ +/ + *

(nuttx) branch master updated: s25fl1: fix compile warnings caused by incorrect variable print format

2023-11-14 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new 0554b975da s25fl1: fix compile warnings

Re: [PR] s25fl1: fix compile warnings caused by incorrect variable print format [nuttx]

2023-11-14 Thread via GitHub
xiaoxiang781216 merged PR #11187: URL: https://github.com/apache/nuttx/pull/11187 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] task/pthread_cancelpt: Move cancel point handling to libc, data to TLS [nuttx]

2023-11-14 Thread via GitHub
xiaoxiang781216 commented on code in PR #11165: URL: https://github.com/apache/nuttx/pull/11165#discussion_r1392939538 ## sched/pthread/pthread_condclockwait.c: ## @@ -104,7 +105,7 @@ int pthread_cond_clockwait(FAR pthread_cond_t *cond, else if (!abstime) { - ret

Re: [PR] task/pthread_cancelpt: Move cancel point handling to libc, data to TLS [nuttx]

2023-11-14 Thread via GitHub
xiaoxiang781216 commented on code in PR #11165: URL: https://github.com/apache/nuttx/pull/11165#discussion_r1392930328 ## include/nuttx/tls.h: ## @@ -309,9 +315,28 @@ uintptr_t task_tls_get_value(int tlsindex); #elif defined(CONFIG_TLS_ALIGNED) && !defined(__KERNEL__) Review

[PR] fs/inode: check file list before memcpy [nuttx]

2023-11-14 Thread via GitHub
anchao opened a new pull request, #11188: URL: https://github.com/apache/nuttx/pull/11188 ## Summary fs/inode: check file list before memcpy The file list is NULL if task group initialized, check the validity of the file list before memcpy. ## Impact N/A

Re: [PR] drivers/lcd: change lcd stride from pixel to bytes [nuttx]

2023-11-14 Thread via GitHub
xiaoxiang781216 merged PR #11185: URL: https://github.com/apache/nuttx/pull/11185 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] s25fl1: fix compile warnings caused by incorrect variable print format [nuttx]

2023-11-14 Thread via GitHub
michallenc opened a new pull request, #11187: URL: https://github.com/apache/nuttx/pull/11187 ## Summary Compilation warnings fixes. ## Impact Build fixes. ## Testing Build pass. -- This is an automated message from the Apache Git Service. To respond to the

(nuttx-apps) branch master updated: examples/foc: don't raise error when EXAMPLES_FOC_IPHASE_ADC isn't set

2023-11-14 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git The following commit(s) were added to refs/heads/master by this push: new 32a8c2975 examples/foc: don't raise

Re: [PR] examples/foc: don't raise error when EXAMPLES_FOC_IPHASE_ADC isn't set [nuttx-apps]

2023-11-14 Thread via GitHub
xiaoxiang781216 merged PR #2194: URL: https://github.com/apache/nuttx-apps/pull/2194 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(nuttx) 01/02: drivers/foc: get hardware information via lower-half interface

2023-11-14 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit 7d99f01cf746546001f7500ebcbd74202da65708 Author: raiden00pl AuthorDate: Mon Nov 13 12:18:48 2023 +0100

(nuttx) 02/02: drivers/foc: return scaling factor for phase currents and BEMF via ioctl

2023-11-14 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git commit 99513ac23e1779a564cfcf6b095427bc5fc4d77c Author: raiden00pl AuthorDate: Mon Nov 13 12:24:55 2023 +0100

(nuttx) branch master updated (5f15c73219 -> 99513ac23e)

2023-11-14 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git from 5f15c73219 Documentation, tools: Bump xpack-riscv-none-elf-gcc to 12.3.0-2 new 7d99f01cf7 drivers/foc: get

Re: [PR] drivers/foc: return scaling factor for phase currents and BEMF via ioctl [nuttx]

2023-11-14 Thread via GitHub
xiaoxiang781216 merged PR #11176: URL: https://github.com/apache/nuttx/pull/11176 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] Rewrite adjtime() implementation to work for RTC and tickless kernel [nuttx]

2023-11-14 Thread via GitHub
PetteriAimonen opened a new pull request, #11186: URL: https://github.com/apache/nuttx/pull/11186 ## Summary Previous `adjtime()` implementation was limited to adjusting system timer tick period. This commit reimplements the internals to use a kernel watchdog timer.

[PR] drivers/lcd: change lcd stride from pixel to bytes [nuttx]

2023-11-14 Thread via GitHub
terry0012 opened a new pull request, #11185: URL: https://github.com/apache/nuttx/pull/11185 In order to achieve better scalability, change the stride from pixel mode to byte mode.For example, in the case of RGB888 mode with 466 pixels in width and a 4-byte aligned buffer,it is only

[PR] examples/foc: refactor motor controller [nuttx-apps]

2023-11-14 Thread via GitHub
raiden00pl opened a new pull request, #2195: URL: https://github.com/apache/nuttx-apps/pull/2195 ## Summary - examples/foc: add velocity saturation - examples/foc: add torque saturation - examples/foc: pass from velocity controller to torque controller ## Impact

(nuttx) branch master updated: Documentation, tools: Bump xpack-riscv-none-elf-gcc to 12.3.0-2

2023-11-14 Thread pkarashchenko
This is an automated email from the ASF dual-hosted git repository. pkarashchenko pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new 5f15c73219 Documentation, tools: Bump

Re: [PR] Documentation, tools: Bump xpack-riscv-none-elf-gcc to 12.3.0-2 [nuttx]

2023-11-14 Thread via GitHub
pkarashchenko merged PR #11184: URL: https://github.com/apache/nuttx/pull/11184 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [I] `libtest` does not work [nuttx-apps]

2023-11-14 Thread via GitHub
xiaoxiang781216 commented on issue #2189: URL: https://github.com/apache/nuttx-apps/issues/2189#issuecomment-1809943495 Yes, it's very useful that app's Makefile could adjust EXTRA_LIB used by nuttx in some way. -- This is an automated message from the Apache Git Service. To respond to

(nuttx-apps) 01/03: examples/foc: fix compilation for open-loop without angle observer

2023-11-14 Thread pkarashchenko
This is an automated email from the ASF dual-hosted git repository. pkarashchenko pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git commit cb36d9c8b2bd39f4ab3647bad7a5801b1feaa4f8 Author: raiden00pl AuthorDate: Tue Nov 7 17:58:15 2023 +0100

(nuttx-apps) branch master updated (b52f7dae0 -> eeacbdde3)

2023-11-14 Thread pkarashchenko
This is an automated email from the ASF dual-hosted git repository. pkarashchenko pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git from b52f7dae0 examples/foc: set direction when updating new setpoint new cb36d9c8b examples/foc: fix

(nuttx-apps) 02/03: examples/foc: fix active brake for sensored mode

2023-11-14 Thread pkarashchenko
This is an automated email from the ASF dual-hosted git repository. pkarashchenko pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git commit c5314b54a4a015c8ab827e301e5d8ebca1e7443b Author: raiden00pl AuthorDate: Wed Nov 8 15:06:17 2023 +0100

(nuttx-apps) 03/03: examples/foc: get velocity from observer if sensored mode

2023-11-14 Thread pkarashchenko
This is an automated email from the ASF dual-hosted git repository. pkarashchenko pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git commit eeacbdde3a1d648c89a49ce3e7b821dda7ce268e Author: raiden00pl AuthorDate: Wed Nov 8 18:42:33 2023 +0100

Re: [PR] examples/foc: fixes for sensored operation mode [nuttx-apps]

2023-11-14 Thread via GitHub
pkarashchenko merged PR #2192: URL: https://github.com/apache/nuttx-apps/pull/2192 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [I] `libtest` does not work [nuttx-apps]

2023-11-14 Thread via GitHub
casaroli commented on issue #2189: URL: https://github.com/apache/nuttx-apps/issues/2189#issuecomment-1809802408 Do you think it will make sense to have nuttx makefile process and include apps/Make.defs and not the other way around? -- This is an automated message from the Apache Git

Re: [I] `libtest` does not work [nuttx-apps]

2023-11-14 Thread via GitHub
xiaoxiang781216 commented on issue #2189: URL: https://github.com/apache/nuttx-apps/issues/2189#issuecomment-1809800145 libtest demonstrate that you can generate a separated library from libapps.a, but the addtional work need be done manually to link with the final nuttx image since the

[PR] Documentation, tools: Bump xpack-riscv-none-elf-gcc to 12.3.0-2 [nuttx]

2023-11-14 Thread via GitHub
masayuki2009 opened a new pull request, #11184: URL: https://github.com/apache/nuttx/pull/11184 ## Summary - Upgraded to xpack-riscv-none-elf-gcc-12.3.0-2 to resolve symbol recognition issues in riscv-none-elf-gdb, as reported in

Re: [PR] task/pthread_cancelpt: Move cancel point handling to libc, data to TLS [nuttx]

2023-11-14 Thread via GitHub
pussuw commented on code in PR #11165: URL: https://github.com/apache/nuttx/pull/11165#discussion_r1392193610 ## include/nuttx/tls.h: ## @@ -309,9 +315,28 @@ uintptr_t task_tls_get_value(int tlsindex); #elif defined(CONFIG_TLS_ALIGNED) && !defined(__KERNEL__) Review Comment:

Re: [PR] task/pthread_cancelpt: Move cancel point handling to libc, data to TLS [nuttx]

2023-11-14 Thread via GitHub
pussuw commented on code in PR #11165: URL: https://github.com/apache/nuttx/pull/11165#discussion_r1392193610 ## include/nuttx/tls.h: ## @@ -309,9 +315,28 @@ uintptr_t task_tls_get_value(int tlsindex); #elif defined(CONFIG_TLS_ALIGNED) && !defined(__KERNEL__) Review Comment:

[PR] examples/foc: don't raise error when EXAMPLES_FOC_IPHASE_ADC isn't set [nuttx-apps]

2023-11-14 Thread via GitHub
raiden00pl opened a new pull request, #2194: URL: https://github.com/apache/nuttx-apps/pull/2194 ## Summary - examples/foc: don't raise error when EXAMPLES_FOC_IPHASE_ADC isn't set This is the first step towards getting rid of CONFIG_EXAMPLES_FOC_IPHASE_ADC completely

Re: [I] `libtest` does not work [nuttx-apps]

2023-11-14 Thread via GitHub
casaroli commented on issue #2189: URL: https://github.com/apache/nuttx-apps/issues/2189#issuecomment-1809749114 So the `libtest` example shipped with `nuttx-apps` does not work out of the box? -- This is an automated message from the Apache Git Service. To respond to the message, please