xiaoxiang781216 merged PR #14701:
URL: https://github.com/apache/nuttx/pull/14701
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nu
liamHowatt commented on code in PR #14701:
URL: https://github.com/apache/nuttx/pull/14701#discussion_r1847618176
##
arch/xtensa/src/esp32s3/esp32s3_lcd.c:
##
@@ -545,10 +569,66 @@ static int esp32s3_lcd_base_getplaneinfo(struct
fb_vtable_s *vtable,
static int esp32s3_lcd_base
liamHowatt commented on code in PR #14701:
URL: https://github.com/apache/nuttx/pull/14701#discussion_r1847618176
##
arch/xtensa/src/esp32s3/esp32s3_lcd.c:
##
@@ -545,10 +569,66 @@ static int esp32s3_lcd_base_getplaneinfo(struct
fb_vtable_s *vtable,
static int esp32s3_lcd_base
liamHowatt commented on code in PR #14701:
URL: https://github.com/apache/nuttx/pull/14701#discussion_r1845492088
##
arch/xtensa/src/esp32s3/esp32s3_lcd.c:
##
@@ -548,7 +564,31 @@ static int esp32s3_lcd_base_updatearea(struct fb_vtable_s
*vtable,
struct esp32s3_lcd_s *priv =
FASTSHIFT commented on code in PR #14701:
URL: https://github.com/apache/nuttx/pull/14701#discussion_r1845816244
##
arch/xtensa/src/esp32s3/esp32s3_lcd.c:
##
@@ -545,10 +569,59 @@ static int esp32s3_lcd_base_getplaneinfo(struct
fb_vtable_s *vtable,
static int esp32s3_lcd_base_
xiaoxiang781216 commented on code in PR #14701:
URL: https://github.com/apache/nuttx/pull/14701#discussion_r1845931261
##
arch/xtensa/src/esp32s3/esp32s3_lcd.c:
##
@@ -545,10 +569,66 @@ static int esp32s3_lcd_base_getplaneinfo(struct
fb_vtable_s *vtable,
static int esp32s3_lcd
FASTSHIFT commented on code in PR #14701:
URL: https://github.com/apache/nuttx/pull/14701#discussion_r1845815662
##
arch/xtensa/src/esp32s3/esp32s3_lcd.c:
##
@@ -545,10 +569,59 @@ static int esp32s3_lcd_base_getplaneinfo(struct
fb_vtable_s *vtable,
static int esp32s3_lcd_base_
xiaoxiang781216 commented on code in PR #14701:
URL: https://github.com/apache/nuttx/pull/14701#discussion_r1845716570
##
arch/xtensa/src/esp32s3/esp32s3_lcd.c:
##
@@ -603,10 +677,43 @@ static int IRAM_ATTR lcd_interrupt(int irq, void
*context, void *arg)
liamHowatt commented on code in PR #14701:
URL: https://github.com/apache/nuttx/pull/14701#discussion_r1845487682
##
arch/xtensa/src/esp32s3/esp32s3_lcd.c:
##
@@ -300,13 +310,16 @@ static const struct fb_videoinfo_s g_base_videoinfo =
/* This structure provides the base layer
liamHowatt commented on code in PR #14701:
URL: https://github.com/apache/nuttx/pull/14701#discussion_r1845487848
##
arch/xtensa/src/esp32s3/esp32s3_lcd.c:
##
@@ -623,6 +663,8 @@ static int IRAM_ATTR lcd_interrupt(int irq, void *context,
void *arg)
regval = esp32s3_lcd_
liamHowatt commented on PR #14701:
URL: https://github.com/apache/nuttx/pull/14701#issuecomment-2481313508
I've updated and validated it. It's much more correct now, despite the
previous iteration technically working.
> can be enabled/disabled by the user (default to `y`, I think).
liamHowatt commented on code in PR #14701:
URL: https://github.com/apache/nuttx/pull/14701#discussion_r1845488537
##
arch/xtensa/src/esp32s3/esp32s3_lcd.c:
##
@@ -548,7 +564,31 @@ static int esp32s3_lcd_base_updatearea(struct fb_vtable_s
*vtable,
struct esp32s3_lcd_s *priv =
liamHowatt commented on code in PR #14701:
URL: https://github.com/apache/nuttx/pull/14701#discussion_r1845487977
##
arch/xtensa/src/esp32s3/esp32s3_lcd.c:
##
@@ -548,7 +564,31 @@ static int esp32s3_lcd_base_updatearea(struct fb_vtable_s
*vtable,
struct esp32s3_lcd_s *priv =
liamHowatt commented on code in PR #14701:
URL: https://github.com/apache/nuttx/pull/14701#discussion_r1845487848
##
arch/xtensa/src/esp32s3/esp32s3_lcd.c:
##
@@ -623,6 +663,8 @@ static int IRAM_ATTR lcd_interrupt(int irq, void *context,
void *arg)
regval = esp32s3_lcd_
xiaoxiang781216 commented on PR #14701:
URL: https://github.com/apache/nuttx/pull/14701#issuecomment-2471286728
Please update the patch inplace.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
liamHowatt commented on PR #14701:
URL: https://github.com/apache/nuttx/pull/14701#issuecomment-2471009537
I'm going to make some changes I think.
I did this some time ago and wanted to remember why I made it work for 1
layer only. I don't think there was a reason, after analyzing. Ho
xiaoxiang781216 commented on code in PR #14701:
URL: https://github.com/apache/nuttx/pull/14701#discussion_r1836618030
##
arch/xtensa/src/esp32s3/esp32s3_lcd.c:
##
@@ -300,13 +310,16 @@ static const struct fb_videoinfo_s g_base_videoinfo =
/* This structure provides the base
liamHowatt commented on code in PR #14701:
URL: https://github.com/apache/nuttx/pull/14701#discussion_r1836548619
##
arch/xtensa/src/esp32s3/esp32s3_lcd.c:
##
@@ -300,13 +310,16 @@ static const struct fb_videoinfo_s g_base_videoinfo =
/* This structure provides the base layer
xiaoxiang781216 commented on code in PR #14701:
URL: https://github.com/apache/nuttx/pull/14701#discussion_r1835474942
##
arch/xtensa/src/esp32s3/esp32s3_lcd.c:
##
@@ -300,13 +310,16 @@ static const struct fb_videoinfo_s g_base_videoinfo =
/* This structure provides the base
xiaoxiang781216 commented on code in PR #14701:
URL: https://github.com/apache/nuttx/pull/14701#discussion_r1835474832
##
arch/xtensa/src/esp32s3/esp32s3_lcd.c:
##
@@ -548,7 +564,31 @@ static int esp32s3_lcd_base_updatearea(struct fb_vtable_s
*vtable,
struct esp32s3_lcd_s *p
FASTSHIFT commented on code in PR #14701:
URL: https://github.com/apache/nuttx/pull/14701#discussion_r1834528910
##
arch/xtensa/src/esp32s3/esp32s3_lcd.c:
##
@@ -548,7 +564,31 @@ static int esp32s3_lcd_base_updatearea(struct fb_vtable_s
*vtable,
struct esp32s3_lcd_s *priv =
FASTSHIFT commented on code in PR #14701:
URL: https://github.com/apache/nuttx/pull/14701#discussion_r1834531099
##
arch/xtensa/src/esp32s3/esp32s3_lcd.c:
##
@@ -548,7 +564,31 @@ static int esp32s3_lcd_base_updatearea(struct fb_vtable_s
*vtable,
struct esp32s3_lcd_s *priv =
tmedicci commented on PR #14701:
URL: https://github.com/apache/nuttx/pull/14701#issuecomment-2464922749
> I would like feedback on how this change should be managed. I made it so
that the feature will be active if there is 1 LCD layer. The impact is that
double the memory will be allocated
nuttxpr commented on PR #14701:
URL: https://github.com/apache/nuttx/pull/14701#issuecomment-2464618190
[**\[Experimental Bot, please feedback
here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues)
This PR appears to mostly meet the NuttX requirements,
liamHowatt opened a new pull request, #14701:
URL: https://github.com/apache/nuttx/pull/14701
cc @XuNeo @FASTSHIFT
## Summary
Make the esp32s3 LCD FB device support double buffering. Leverage the FB
`pandisplay` callback for users to achieve [double buffering in applications
s
25 matches
Mail list logo
