[GitHub] [incubator-nuttx] masayuki2009 opened a new issue #1838: Do we still need IFF_DOWN?

masayuki2009 opened a new issue #1838: URL: https://github.com/apache/incubator-nuttx/issues/1838 I noticed that IFF_DOWN is used both nuttx and apps to control network interface. In my understanding, IFF_UP is enough and IFF_DOWN is rather redundant. So my question is that do we

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #1817: SIM in MacOS: make MacOS link process same with Linux

xiaoxiang781216 commented on pull request #1817: URL: https://github.com/apache/incubator-nuttx/pull/1817#issuecomment-694645125 @yamt could you try the update? This is an automated message from the Apache Git Service. To

[incubator-nuttx-testing] branch master updated: cibuild.sh: fix binutils path error

This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-testing.git The following commit(s) were added to refs/heads/master by this push: new 732c33b cibuild.sh: fix

[incubator-nuttx] branch master updated: input: STMPE811 GPIO interrupt bug fixes

This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new 7554eed input: STMPE811 GPIO

[GitHub] [incubator-nuttx] cwespressif commented on pull request #1830: xtensa/esp32: Add power management of force-sleep

cwespressif commented on pull request #1830: URL: https://github.com/apache/incubator-nuttx/pull/1830#issuecomment-694617146 > @cwespressif the checks are failing (other than the style issue) because the defconfig you provided is still using some old CONFIGs_. Please run `refresh.sh`

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #1835: Fix build errors when using DEBUGASSERT

xiaoxiang781216 commented on pull request #1835: URL: https://github.com/apache/incubator-nuttx/pull/1835#issuecomment-694609312 @Palmitoxico could you fix these warnings too: ``` ##[error]/home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/drivers/rf/dat-31r5-sp.c:192:78:

[GitHub] [incubator-nuttx] v01d opened a new pull request #1837: Add CONTRIBUTING.md

v01d opened a new pull request #1837: URL: https://github.com/apache/incubator-nuttx/pull/1837 ## Summary This commits adds a CONTRIBUTING.md to be used by GitHub, which is displayed when creating a pull-request. My aim was to keep it simple and include the most important

[GitHub] [incubator-nuttx] btashton commented on pull request #1836: input: STMPE811 GPIO interrupt bug fixes

btashton commented on pull request #1836: URL: https://github.com/apache/incubator-nuttx/pull/1836#issuecomment-694600065 @patacongo one more patch for this chip... At this point I have the GPIO and SPI portions of the driver fairly well tested. The undocumented requirement to read

[GitHub] [incubator-nuttx] btashton opened a new pull request #1836: input: STMPE811 GPIO interrupt bug fixes

btashton opened a new pull request #1836: URL: https://github.com/apache/incubator-nuttx/pull/1836 ## Summary This patch resolves to bugs in the GPIO interrupt logic: 1. Any pins did not have STMPE811_GPIO_RISING in their pincfg would clear the rising edge interrupt enable flag

[GitHub] [incubator-nuttx-testing] btashton edited a comment on pull request #64: cibuild.sh: fix binutils path error

btashton edited a comment on pull request #64: URL: https://github.com/apache/incubator-nuttx-testing/pull/64#issuecomment-694557708 > add_path prepend the path. i guess it's safer to add the path to the end of PATH. binutils provides a lot of tools besides objcopy. Alternatively

[GitHub] [incubator-nuttx-testing] btashton commented on pull request #64: cibuild.sh: fix binutils path error

btashton commented on pull request #64: URL: https://github.com/apache/incubator-nuttx-testing/pull/64#issuecomment-694557708 > add_path prepend the path. i guess it's safer to add the path to the end of PATH. binutils provides a lot of tools besides objcopy. Alternatively what if

[GitHub] [incubator-nuttx-testing] yamt commented on pull request #64: cibuild.sh: fix binutils path error

yamt commented on pull request #64: URL: https://github.com/apache/incubator-nuttx-testing/pull/64#issuecomment-694555138 add_path prepend the path. i guess it's safer to add the path to the end of PATH. binutils provides a lot of tools besides objcopy.

[GitHub] [incubator-nuttx] justinmclean commented on pull request #1834: License/authorship handling scrips (wip)

justinmclean commented on pull request #1834: URL: https://github.com/apache/incubator-nuttx/pull/1834#issuecomment-694550504 Hi, If you come up with a list of people I can check for you. Justin This is an

[GitHub] [incubator-nuttx] btashton commented on pull request #1834: License/authorship handling scrips (wip)

btashton commented on pull request #1834: URL: https://github.com/apache/incubator-nuttx/pull/1834#issuecomment-694549218 > > Unfortunately this is something that we do not have access to: > > https://svn.apache.org/repos/private/foundation/officers > > It appears you can

[GitHub] [incubator-nuttx] v01d commented on pull request #1834: License/authorship handling scrips (wip)

v01d commented on pull request #1834: URL: https://github.com/apache/incubator-nuttx/pull/1834#issuecomment-694548548 > > @justinmclean sorry, where is that foundation SVN? > > Unfortunately this is something that we do not have access to: >

[GitHub] [incubator-nuttx] justinmclean commented on pull request #1834: License/authorship handling scrips (wip)

justinmclean commented on pull request #1834: URL: https://github.com/apache/incubator-nuttx/pull/1834#issuecomment-694548095 Hi, > @justinmclean Thank, that's quite useful (specially since it is JSON). I'm wondering how we can safely identify authors

[GitHub] [incubator-nuttx] btashton commented on pull request #1834: License/authorship handling scrips (wip)

btashton commented on pull request #1834: URL: https://github.com/apache/incubator-nuttx/pull/1834#issuecomment-694546960 > @justinmclean sorry, where is that foundation SVN? Unfortunately this is something that we do not have access to:

[GitHub] [incubator-nuttx] v01d commented on pull request #1834: License/authorship handling scrips (wip)

v01d commented on pull request #1834: URL: https://github.com/apache/incubator-nuttx/pull/1834#issuecomment-694541151 @justinmclean sorry, where is that foundation SVN? This is an automated message from the Apache Git

[GitHub] [incubator-nuttx] v01d edited a comment on pull request #1834: License/authorship handling scrips (wip)

v01d edited a comment on pull request #1834: URL: https://github.com/apache/incubator-nuttx/pull/1834#issuecomment-694538544 I improved header parsing among other things. The following is an interesting case. You can run it with: ```bash tools/licensing/log2json.sh

[GitHub] [incubator-nuttx] v01d commented on pull request #1834: License/authorship handling scrips (wip)

v01d commented on pull request #1834: URL: https://github.com/apache/incubator-nuttx/pull/1834#issuecomment-694538544 I improved header parsing among other things. The following is an interesting case. You can run it with: tools/licensing/log2json.sh

[GitHub] [incubator-nuttx] v01d commented on pull request #1834: License/authorship handling scrips (wip)

v01d commented on pull request #1834: URL: https://github.com/apache/incubator-nuttx/pull/1834#issuecomment-694531814 @justinmclean Thank, that's quite useful (specially since it is JSON). I'm wondering how we can safely identify authors since I see there are only names and apache UIDs

[GitHub] [incubator-nuttx] v01d commented on pull request #1834: License/authorship handling scrips (wip)

v01d commented on pull request #1834: URL: https://github.com/apache/incubator-nuttx/pull/1834#issuecomment-694529679 > Hmmm... This is all project management stuff. Perhaps you have changed your mind? Perhaps you should be on the PPMC? Are you interested? I would say this is mostly

[GitHub] [incubator-nuttx] justinmclean commented on pull request #1834: License/authorship handling scrips (wip)

justinmclean commented on pull request #1834: URL: https://github.com/apache/incubator-nuttx/pull/1834#issuecomment-694522962 Hi, There’s a list of all cla in the foundations svn under: ./officers/cclas.txt ./officers/iclas.txt The ICLAs files contains lines like:

[GitHub] [incubator-nuttx] patacongo commented on pull request #1834: License/authorship handling scrips (wip)

patacongo commented on pull request #1834: URL: https://github.com/apache/incubator-nuttx/pull/1834#issuecomment-694510627 Hmmm... This is all project management stuff. Perhaps you have changed your mind? Perhaps you should be on the PPMC? Are you interested?

[GitHub] [incubator-nuttx] v01d commented on pull request #1834: License/authorship handling scrips (wip)

v01d commented on pull request #1834: URL: https://github.com/apache/incubator-nuttx/pull/1834#issuecomment-694509810 > > Also, how can we get an authoritative list of committers who have ICLAs? Ideally this should be retrievable from some Apache URL so that it can be made to pull the

[GitHub] [incubator-nuttx] patacongo edited a comment on pull request #1834: License/authorship handling scrips (wip)

patacongo edited a comment on pull request #1834: URL: https://github.com/apache/incubator-nuttx/pull/1834#issuecomment-694508772 > Also, how can we get an authoritative list of committers who have ICLAs? Ideally this should be retrievable from some Apache URL so that it can be made to

[GitHub] [incubator-nuttx] v01d commented on pull request #1834: License/authorship handling scrips (wip)

v01d commented on pull request #1834: URL: https://github.com/apache/incubator-nuttx/pull/1834#issuecomment-694509003 > Another case that will be confusing is that under arch/ and boards/ many people copied files that I wrote verbatim, changing only some context stuff (like paths or file

[GitHub] [incubator-nuttx] patacongo commented on pull request #1834: License/authorship handling scrips (wip)

patacongo commented on pull request #1834: URL: https://github.com/apache/incubator-nuttx/pull/1834#issuecomment-694508772 > Also, how can we get an authoritative list of committers who have ICLAs? Ideally this should be retrievable from some Apache URL so that it can be made to pull the

[GitHub] [incubator-nuttx] v01d commented on pull request #1834: License/authorship handling scrips (wip)

v01d commented on pull request #1834: URL: https://github.com/apache/incubator-nuttx/pull/1834#issuecomment-694508492 One example of a file in arch is the following: `arch/arm/src/samd5e5/sam_tc.h`. If you run: `git --no-abbrev --raw --follow -- ../../arch/arm/src/samd5e5/sam_tc.h` you

[GitHub] [incubator-nuttx] patacongo edited a comment on pull request #1834: License/authorship handling scrips (wip)

patacongo edited a comment on pull request #1834: URL: https://github.com/apache/incubator-nuttx/pull/1834#issuecomment-694506935 The old ChangeLog files that we removed also has the author and date of each significant change, but these are not referenced by commit number. But perhaps

[GitHub] [incubator-nuttx] patacongo commented on pull request #1834: License/authorship handling scrips (wip)

patacongo commented on pull request #1834: URL: https://github.com/apache/incubator-nuttx/pull/1834#issuecomment-694506935 The old ChangeLog files that we removed also has the author and date of each significant change, but these are not referenced by commit number. But perhaps they

[GitHub] [incubator-nuttx] patacongo commented on pull request #1834: License/authorship handling scrips (wip)

patacongo commented on pull request #1834: URL: https://github.com/apache/incubator-nuttx/pull/1834#issuecomment-694506158 Another case that will be confusing is that under arch/ and boards/ many people copied files that I wrote verbatim, changing only some context stuff (like paths or

[GitHub] [incubator-nuttx] patacongo commented on pull request #1834: License/authorship handling scrips (wip)

patacongo commented on pull request #1834: URL: https://github.com/apache/incubator-nuttx/pull/1834#issuecomment-694505323 > > Another question is, what is the impact of copyright vs authorship indication? For example: > > ../../arch/arm/src/samd5e5/sam_tc.h- * Copyright 2020 > >

[GitHub] [incubator-nuttx] v01d edited a comment on pull request #1834: License/authorship handling scrips (wip)

v01d edited a comment on pull request #1834: URL: https://github.com/apache/incubator-nuttx/pull/1834#issuecomment-694501841 I was adding comments to the issue thinking I was commenting here, I'll copy them: > Another question is, what is the impact of copyright vs authorship

[GitHub] [incubator-nuttx] v01d edited a comment on pull request #1834: License/authorship handling scrips (wip)

v01d edited a comment on pull request #1834: URL: https://github.com/apache/incubator-nuttx/pull/1834#issuecomment-694501841 I was adding comments to the issue thinking I was commenting here, I'll copy them: > Another question is, what is the impact of copyright vs authorship

[GitHub] [incubator-nuttx] v01d commented on pull request #1834: License/authorship handling scrips (wip)

v01d commented on pull request #1834: URL: https://github.com/apache/incubator-nuttx/pull/1834#issuecomment-694501841 I was adding comments to the issue thinking I was commenting here, I'll copy them: > Another question is, what is the impact of copyright vs authorship indication?

[GitHub] [incubator-nuttx] v01d edited a comment on issue #128: IP Clearance

v01d edited a comment on issue #128: URL: https://github.com/apache/incubator-nuttx/issues/128#issuecomment-694499609 Comment moved to #1834 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-nuttx] patacongo commented on pull request #1834: License/authorship handling scrips (wip)

patacongo commented on pull request #1834: URL: https://github.com/apache/incubator-nuttx/pull/1834#issuecomment-694501611 > Sorry for the name dropping, was just an example. We do need to exercise some care with names if we wander into areas that are inappropriate for a public

[GitHub] [incubator-nuttx] patacongo edited a comment on pull request #1834: License/authorship handling scrips (wip)

patacongo edited a comment on pull request #1834: URL: https://github.com/apache/incubator-nuttx/pull/1834#issuecomment-694500299 Please also remember, when it comes down to talking about specific people by name, we probably need to do that on the priv...@nuttx.apache.org list. This is

[GitHub] [incubator-nuttx] v01d commented on issue #128: IP Clearance

v01d commented on issue #128: URL: https://github.com/apache/incubator-nuttx/issues/128#issuecomment-694499806 Oops, thought I was on the PR, I'll move the comments there This is an automated message from the Apache Git

[GitHub] [incubator-nuttx] v01d commented on issue #128: IP Clearance

v01d commented on issue #128: URL: https://github.com/apache/incubator-nuttx/issues/128#issuecomment-694499609 I think we will have a hard time with many files that once existed in submodules. Git is smart enough to know about the file coming from a submodule, but it is not possible to

[GitHub] [incubator-nuttx] patacongo edited a comment on pull request #1834: License/authorship handling scrips (wip)

patacongo edited a comment on pull request #1834: URL: https://github.com/apache/incubator-nuttx/pull/1834#issuecomment-694497704 > Greg, I was looking for example commits for where you have attributed a change to some other author (ie: a commit with you as author but with message in the

[GitHub] [incubator-nuttx] patacongo commented on pull request #1834: License/authorship handling scrips (wip)

patacongo commented on pull request #1834: URL: https://github.com/apache/incubator-nuttx/pull/1834#issuecomment-694497704 > Greg, I was looking for example commits for where you have attributed a change to some other author (ie: a commit with you as author but with message in the

[GitHub] [incubator-nuttx] v01d commented on issue #128: IP Clearance

v01d commented on issue #128: URL: https://github.com/apache/incubator-nuttx/issues/128#issuecomment-694490204 Another question is, what is the impact of copyright vs authorship indication? For example: ../../arch/arm/src/samd5e5/sam_tc.h- * Copyright 2020 Falker Automacao

[GitHub] [incubator-nuttx] v01d commented on issue #128: IP Clearance

v01d commented on issue #128: URL: https://github.com/apache/incubator-nuttx/issues/128#issuecomment-694481474 > @v01d yes, text-based json or csv/tsv formats would be great. The scripts in #1834 look cool. Maybe we combine them into one python script with the

[GitHub] [incubator-nuttx] v01d commented on pull request #1834: License/authorship handling scrips (wip)

v01d commented on pull request #1834: URL: https://github.com/apache/incubator-nuttx/pull/1834#issuecomment-694480221 Greg, I was looking for example commits for where you have attributed a change to some other author (ie: a commit with you as author but with message in the commit

[GitHub] [incubator-nuttx] v01d commented on a change in pull request #1834: License/authorship handling scrips (wip)

v01d commented on a change in pull request #1834: URL: https://github.com/apache/incubator-nuttx/pull/1834#discussion_r490533669 ## File path: tools/licensing/check.py ## @@ -0,0 +1,43 @@ +#!/usr/bin/env python3 + Review comment: will do ## File path:

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #1834: License/authorship handling scrips (wip)

patacongo commented on a change in pull request #1834: URL: https://github.com/apache/incubator-nuttx/pull/1834#discussion_r490527373 ## File path: tools/licensing/log2json.sh ## @@ -0,0 +1,47 @@ +#!/usr/bin/env bash + Review comment: Apache 2.0 header

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #1834: License/authorship handling scrips (wip)

patacongo commented on a change in pull request #1834: URL: https://github.com/apache/incubator-nuttx/pull/1834#discussion_r490527214 ## File path: tools/licensing/check.py ## @@ -0,0 +1,43 @@ +#!/usr/bin/env python3 + Review comment: Needs Apache 2.0 header

[GitHub] [incubator-nuttx] adamfeuer edited a comment on issue #128: IP Clearance

adamfeuer edited a comment on issue #128: URL: https://github.com/apache/incubator-nuttx/issues/128#issuecomment-694460802 @patacongo Re: anything that makes forward progress, me too. @v01d yes, text-based json or csv/tsv formats would be great. The scripts in #1834 look cool. Maybe

[GitHub] [incubator-nuttx] adamfeuer commented on issue #128: IP Clearance

adamfeuer commented on issue #128: URL: https://github.com/apache/incubator-nuttx/issues/128#issuecomment-694460802 @patacongo Re: anything that makes forward progress, me too. @v01d yes, text-based json or csv/tsv formats would be great. The scripts in #1834 look cool Maybe we

[GitHub] [incubator-nuttx-apps] Ouss4 commented on a change in pull request #395: make/clean: clean the OBJ directly if declare in subdirectory

Ouss4 commented on a change in pull request #395: URL: https://github.com/apache/incubator-nuttx-apps/pull/395#discussion_r490516672 ## File path: Application.mk ## @@ -238,6 +238,7 @@ depend:: .depend clean:: $(call CLEAN) + $(Q) rm -f $(wildcard $(foreach

[GitHub] [incubator-nuttx] patacongo commented on issue #128: IP Clearance

patacongo commented on issue #128: URL: https://github.com/apache/incubator-nuttx/issues/128#issuecomment-694443519 > > > Please see #1834 > > I know @PeterBee97 started some of this work but to be honest it was quite difficult for me to take advantage of those, considering

[incubator-nuttx] branch master updated: STMPE811: Fix name collision in include/nuttx/input/stmpe811.h

This is an automated email from the ASF dual-hosted git repository. btashton pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new 415d83c STMPE811: Fix name

[GitHub] [incubator-nuttx] btashton commented on pull request #1832: STMPE811: Fix name collision in include/nuttx/input/stmpe811.h

btashton commented on pull request #1832: URL: https://github.com/apache/incubator-nuttx/pull/1832#issuecomment-694440871 Yeah I understand why, just the naming through me off, but there is not really a "standard" here and this is documented, so I say we just merge this in. My input

[GitHub] [incubator-nuttx] btashton merged pull request #1832: STMPE811: Fix name collision in include/nuttx/input/stmpe811.h

btashton merged pull request #1832: URL: https://github.com/apache/incubator-nuttx/pull/1832 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [incubator-nuttx] Palmitoxico opened a new pull request #1835: Fix build errors when using DEBUGASSERT

Palmitoxico opened a new pull request #1835: URL: https://github.com/apache/incubator-nuttx/pull/1835 ## Summary Wrong variable names used inside DEBUGASSERT macros causes build errors when building with debug assertions enabled. ## Impact This PR should fix these build errors

[GitHub] [incubator-nuttx] patacongo commented on pull request #1832: STMPE811: Fix name collision in include/nuttx/input/stmpe811.h

patacongo commented on pull request #1832: URL: https://github.com/apache/incubator-nuttx/pull/1832#issuecomment-694437954 STMPE811_GPIO_PIN() is an internal driver definition and not part of the user interface. If you want, you can just close this PR and move the definition to

[GitHub] [incubator-nuttx] v01d commented on issue #128: IP Clearance

v01d commented on issue #128: URL: https://github.com/apache/incubator-nuttx/issues/128#issuecomment-694438093 Please see #1834 I know @PeterBee97 started some of this work but to be honest it was quite difficult for me to take advantage of those, considering it was based on sqlite

[GitHub] [incubator-nuttx] v01d opened a new pull request #1834: License/authorship handling scrips (wip)

v01d opened a new pull request #1834: URL: https://github.com/apache/incubator-nuttx/pull/1834 ## Summary This is a work in progress to create a series of scripts to obtain the history of a file in the repository and extract all known sources of authorship so that we can determine

[GitHub] [incubator-nuttx] patacongo edited a comment on pull request #1832: STMPE811: Fix name collision in include/nuttx/input/stmpe811.h

patacongo edited a comment on pull request #1832: URL: https://github.com/apache/incubator-nuttx/pull/1832#issuecomment-694431378 > > > @patacongo does this definition make sense for `STMPE811_GPIO_PIN(n)` I would expect to do something like this to define the pin config: >

[GitHub] [incubator-nuttx] patacongo edited a comment on pull request #1832: STMPE811: Fix name collision in include/nuttx/input/stmpe811.h

patacongo edited a comment on pull request #1832: URL: https://github.com/apache/incubator-nuttx/pull/1832#issuecomment-694431378 > > > @patacongo does this definition make sense for `STMPE811_GPIO_PIN(n)` I would expect to do something like this to define the pin config: >

[GitHub] [incubator-nuttx] patacongo commented on pull request #1832: STMPE811: Fix name collision in include/nuttx/input/stmpe811.h

patacongo commented on pull request #1832: URL: https://github.com/apache/incubator-nuttx/pull/1832#issuecomment-694431378 > > > @patacongo does this definition make sense for `STMPE811_GPIO_PIN(n)` I would expect to do something like this to define the pin config: > > ```

[GitHub] [incubator-nuttx] adamfeuer commented on issue #128: IP Clearance

adamfeuer commented on issue #128: URL: https://github.com/apache/incubator-nuttx/issues/128#issuecomment-694430940 Yeah, life intervened and I haven't been able to get back to this. I have less time for it than I thought. @PeterBee97 made some progress in parsing out the list of

[GitHub] [incubator-nuttx] patacongo commented on issue #128: IP Clearance

patacongo commented on issue #128: URL: https://github.com/apache/incubator-nuttx/issues/128#issuecomment-694425754 > I've been writing some scripts which convert the output of git log (over a given file) into JSON format, to obtain metadata for each revision of the file. The final JSON

[GitHub] [incubator-nuttx] v01d commented on issue #128: IP Clearance

v01d commented on issue #128: URL: https://github.com/apache/incubator-nuttx/issues/128#issuecomment-694413112 I've been writing some scripts which convert the output of git log (over a given file) into JSON format, to obtain metadata for each revision of the file. The final JSON contains

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #1833: tiva: tiva_lowputc.h: Fix nxstyle warnings

xiaoxiang781216 merged pull request #1833: URL: https://github.com/apache/incubator-nuttx/pull/1833 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[incubator-nuttx] branch master updated (204e84f -> a4d1a20)

This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from 204e84f input: Add SPI mode for STMPE811 touch screen controller add a4d1a20 tiva:

[GitHub] [incubator-nuttx] btashton commented on pull request #1832: STMPE811: Fix name collision in include/nuttx/input/stmpe811.h

btashton commented on pull request #1832: URL: https://github.com/apache/incubator-nuttx/pull/1832#issuecomment-694406946 Other than that I have verified that I am able to write to the GPIO pins with this. Something is not working with reading, but I am looking into that now.

[GitHub] [incubator-nuttx] btashton commented on pull request #1832: STMPE811: Fix name collision in include/nuttx/input/stmpe811.h

btashton commented on pull request #1832: URL: https://github.com/apache/incubator-nuttx/pull/1832#issuecomment-694395999 @patacongo does this definition make sense for `STMPE811_GPIO_PIN(n)` I would expect to do something like this to define the pin config: ``` #define KB_FW_BL

[incubator-nuttx-apps] branch master updated: interpreters/wamr: Add missing options

This is an automated email from the ASF dual-hosted git repository. aguettouche pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git The following commit(s) were added to refs/heads/master by this push: new 6995602 interpreters/wamr:

[GitHub] [incubator-nuttx-apps] Ouss4 merged pull request #396: interpreters/wamr: Add missing options

Ouss4 merged pull request #396: URL: https://github.com/apache/incubator-nuttx-apps/pull/396 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [incubator-nuttx] hartmannathan opened a new pull request #1833: tiva: tiva_lowputc.h: Fix nxstyle warnings

hartmannathan opened a new pull request #1833: URL: https://github.com/apache/incubator-nuttx/pull/1833 ## Summary arch/arm/src/tiva/tiva_lowputc.h: * Fix nxstyle warnings. No functional changes. ## Impact Removes nxstyle warnings. ## Testing

[GitHub] [incubator-nuttx] patacongo edited a comment on pull request #1816: input: Add SPI mode for STMPE811 touch screen controller

patacongo edited a comment on pull request #1816: URL: https://github.com/apache/incubator-nuttx/pull/1816#issuecomment-694342005 I prepared a PR to fix the name collision. See PR #1832 This is an automated message from

[GitHub] [incubator-nuttx] patacongo opened a new pull request #1832: STMPE811: Fix name collision in include/nuttx/input/stmpe811.h

patacongo opened a new pull request #1832: URL: https://github.com/apache/incubator-nuttx/pull/1832 ## Summary The macro name GPIO_PIN collides with naming used by many architectures as noted in PR #1816: $ find . -name "*.h" | xargs grep "define GPIO_PIN[(]"

[GitHub] [incubator-nuttx] Ouss4 commented on pull request #1830: xtensa/esp32: Add power management of force-sleep

Ouss4 commented on pull request #1830: URL: https://github.com/apache/incubator-nuttx/pull/1830#issuecomment-694345205 @cwespressif the checks are failing (other than the style issue) because the defconfig you provided is still using some old CONFIGs_. Please run `refresh.sh` against it:

[GitHub] [incubator-nuttx] patacongo commented on pull request #1816: input: Add SPI mode for STMPE811 touch screen controller

patacongo commented on pull request #1816: URL: https://github.com/apache/incubator-nuttx/pull/1816#issuecomment-694342005 I am preparing a PR to fix the name collision. This is an automated message from the Apache Git

[GitHub] [incubator-nuttx] patacongo edited a comment on pull request #1816: input: Add SPI mode for STMPE811 touch screen controller

patacongo edited a comment on pull request #1816: URL: https://github.com/apache/incubator-nuttx/pull/1816#issuecomment-694300865 > > > @patacongo did you have any thoughts on the header file issue? Appears to be a classic name collision. GPIO_PIN is too generic and should

[GitHub] [incubator-nuttx] patacongo edited a comment on pull request #1816: input: Add SPI mode for STMPE811 touch screen controller

patacongo edited a comment on pull request #1816: URL: https://github.com/apache/incubator-nuttx/pull/1816#issuecomment-694300865 > > > @patacongo did you have any thoughts on the header file issue? Appears to be a classic name collision. GPIO_PIN is too generic and should

[GitHub] [incubator-nuttx] patacongo edited a comment on pull request #1816: input: Add SPI mode for STMPE811 touch screen controller

patacongo edited a comment on pull request #1816: URL: https://github.com/apache/incubator-nuttx/pull/1816#issuecomment-694300865 > > > @patacongo did you have any thoughts on the header file issue? Appears to be a classic name collision. GPIO_PIN is too generic and should

[GitHub] [incubator-nuttx] patacongo commented on pull request #1816: input: Add SPI mode for STMPE811 touch screen controller

patacongo commented on pull request #1816: URL: https://github.com/apache/incubator-nuttx/pull/1816#issuecomment-694300865 > > > @patacongo did you have any thoughts on the header file issue? Appears to be a classic name collision. GPIO_PIN is too generic and should be

[GitHub] [incubator-nuttx] btashton commented on pull request #1816: input: Add SPI mode for STMPE811 touch screen controller

btashton commented on pull request #1816: URL: https://github.com/apache/incubator-nuttx/pull/1816#issuecomment-694296090 @patacongo did you have any thoughts on the header file issue? This is an automated message from the

[GitHub] [incubator-nuttx] davids5 commented on issue #1568: STM32F4 core over-drive enable/disable sequence problem.

davids5 commented on issue #1568: URL: https://github.com/apache/incubator-nuttx/issues/1568#issuecomment-694290734 @fjpanag - > Users' code may use it, however. By deleting it, their code may break. But I think this is good. It will clearly indicate the bug, on next build, and

[GitHub] [incubator-nuttx] patacongo commented on pull request #1661: WIP: Start implementing BTPROTO_HCI socket support

patacongo commented on pull request #1661: URL: https://github.com/apache/incubator-nuttx/pull/1661#issuecomment-694288272 > The point is something we discussed many times: do we want to fork an active project and then have to manually keep it in sync (or not even do that and take on the

[incubator-nuttx] branch master updated: input: Add SPI mode for STMPE811 touch screen controller

This is an automated email from the ASF dual-hosted git repository. gnutt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new 204e84f input: Add SPI mode for

[GitHub] [incubator-nuttx] patacongo merged pull request #1816: input: Add SPI mode for STMPE811 touch screen controller

patacongo merged pull request #1816: URL: https://github.com/apache/incubator-nuttx/pull/1816 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #1816: input: Add SPI mode for STMPE811 touch screen controller

patacongo commented on a change in pull request #1816: URL: https://github.com/apache/incubator-nuttx/pull/1816#discussion_r490291913 ## File path: drivers/input/stmpe811_base.c ## @@ -422,18 +443,21 @@ uint8_t stmpe811_getreg8(FAR struct stmpe811_dev_s *priv, uint8_t

[GitHub] [incubator-nuttx] v01d commented on pull request #1661: WIP: Start implementing BTPROTO_HCI socket support

v01d commented on pull request #1661: URL: https://github.com/apache/incubator-nuttx/pull/1661#issuecomment-694265373 Yes, I completely understand that motivation. And I agree. The point is something we discussed many times: do we want to fork an active project and then have to

[GitHub] [incubator-nuttx] lukegluke opened a new issue #1831: Echo stucks in initial script if USB console is used

lukegluke opened a new issue #1831: URL: https://github.com/apache/incubator-nuttx/issues/1831 If usb CDC ACM is used as console and echo is called in init script it will hangup in nsh_output. Other apps that called from init script and print something to console are handled correctly - I

[GitHub] [incubator-nuttx] patacongo commented on pull request #1661: WIP: Start implementing BTPROTO_HCI socket support

patacongo commented on pull request #1661: URL: https://github.com/apache/incubator-nuttx/pull/1661#issuecomment-694251298 > I don't know know at this point if it would be better to embrace an external project (with the risks it involves) or to continue maturing our own (even if it is

[GitHub] [incubator-nuttx-testing] GUIDINGLI opened a new pull request #64: cibuild.sh: fix binutils path error

GUIDINGLI opened a new pull request #64: URL: https://github.com/apache/incubator-nuttx-testing/pull/64 ## Summary cibuild.sh: fix binutils path error ## Impact ## Testing This is an automated

[GitHub] [incubator-nuttx] fjpanag commented on issue #1568: STM32F4 core over-drive enable/disable sequence problem.

fjpanag commented on issue #1568: URL: https://github.com/apache/incubator-nuttx/issues/1568#issuecomment-694236810 @davids5 I agree that it is best to delete it. It seems that it cannot be fixed properly, and as no other NuttX code uses it, it won't cause any issues removing it.

[GitHub] [incubator-nuttx] anchao commented on pull request #1829: nuttx/wireless: add wireless event member length helper

anchao commented on pull request #1829: URL: https://github.com/apache/incubator-nuttx/pull/1829#issuecomment-694221068 > @anchao please edit all your PRs, follow the three section template and fill each section. It may feel like a chore but it is there to help reviewers and people

[GitHub] [incubator-nuttx] v01d commented on issue #1638: Documentation roadmap

v01d commented on issue #1638: URL: https://github.com/apache/incubator-nuttx/issues/1638#issuecomment-694207936 Ok, then no change needed for that section. This is an automated message from the Apache Git Service. To

[GitHub] [incubator-nuttx] v01d edited a comment on pull request #1829: nuttx/wireless: add wireless event member length helper

v01d edited a comment on pull request #1829: URL: https://github.com/apache/incubator-nuttx/pull/1829#issuecomment-694205301 @anchao please edit all your PRs, follow the three section template and fill each section. It may feel like a chore but it is there to help reviewers and people

[GitHub] [incubator-nuttx] v01d commented on pull request #1829: nuttx/wireless: add wireless event member length helper

v01d commented on pull request #1829: URL: https://github.com/apache/incubator-nuttx/pull/1829#issuecomment-694205301 @anchao please edit all your PRs, follow the three section template and fill each section. It may feel like a chore but it is there to help reviewers and people creating

[GitHub] [incubator-nuttx-apps] no1wudi opened a new pull request #396: interpreters/wamr: Add missing options

no1wudi opened a new pull request #396: URL: https://github.com/apache/incubator-nuttx-apps/pull/396 ## Summary Add missing options to Kconfig, now these symbol provided by NuttX, handled in WAMR side. ## Impact None ## Testing Tested on STM32.

[GitHub] [incubator-nuttx] justinmclean commented on pull request #1661: WIP: Start implementing BTPROTO_HCI socket support

justinmclean commented on pull request #1661: URL: https://github.com/apache/incubator-nuttx/pull/1661#issuecomment-694180487 Hi, > nimBLE, on the other hand, is a AFS project. It is part of Apache MyNewt. Etiquette would require that we establish some dialog and get that project's

[GitHub] [incubator-nuttx] cwespressif opened a new pull request #1830: xtensa/esp32: Add power management of force-sleep

cwespressif opened a new pull request #1830: URL: https://github.com/apache/incubator-nuttx/pull/1830 This driver refactoring was implemented by Chen Wen chen...@espressif.com and reviewed by Alan Carvalho de Assis && Abdelatif Guettouche. ## Summary Add power management

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 merged pull request #389: examples/fb: correct the munmap(2) parameter type

xiaoxiang781216 merged pull request #389: URL: https://github.com/apache/incubator-nuttx-apps/pull/389 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

  1   2   >