[GitHub] [incubator-nuttx] Gary-Hobson opened a new pull request #5260: driver/up_touchscreen: update up_touchscreen, using touch_upperhalf

2022-01-17 Thread GitBox
Gary-Hobson opened a new pull request #5260: URL: https://github.com/apache/incubator-nuttx/pull/5260 ## Summary update simtouchscreen, using touch_upperhalf,simplified simulator touchscreen driver ## Impact ## Testing -- This is an automated message from the

[GitHub] [incubator-nuttx] pkarashchenko opened a new pull request #5259: net: use HTONS, NTOHS, HTONL, NTOHL macro in kernel code

2022-01-17 Thread GitBox
pkarashchenko opened a new pull request #5259: URL: https://github.com/apache/incubator-nuttx/pull/5259 ## Summary Currently in the kernel code we have a mix of byte convert functions like `htons` and byte convert macro like `HTONS` used in code. Switch to byte convert macro in all

[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5254: net: unify FAR keyword usage for all net buffer memory mapped buffers

2022-01-17 Thread GitBox
pkarashchenko commented on a change in pull request #5254: URL: https://github.com/apache/incubator-nuttx/pull/5254#discussion_r786483815 ## File path: arch/mips/src/pic32mz/pic32mz_ethernet.c ## @@ -254,7 +254,7 @@ * header */ -#define BUF ((struct eth_hdr_s

[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5254: net: unify FAR keyword usage for all net buffer memory mapped buffers

2022-01-17 Thread GitBox
pkarashchenko commented on a change in pull request #5254: URL: https://github.com/apache/incubator-nuttx/pull/5254#discussion_r786483815 ## File path: arch/mips/src/pic32mz/pic32mz_ethernet.c ## @@ -254,7 +254,7 @@ * header */ -#define BUF ((struct eth_hdr_s

[incubator-nuttx] branch master updated (04723a8 -> 8d591d5)

2022-01-17 Thread jerpelea
This is an automated email from the ASF dual-hosted git repository. jerpelea pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from 04723a8 xtensa: Fix core voltage level when SPI Flash runs at 80Mhz add 60913d3 Revert

[GitHub] [incubator-nuttx] jerpelea merged pull request #5257: fs/smartfs: Fix file size corruption when opening with truncate mode

2022-01-17 Thread GitBox
jerpelea merged pull request #5257: URL: https://github.com/apache/incubator-nuttx/pull/5257 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #5249: Fix aligment issue: pktbuf needs to be 16bit aligned

2022-01-17 Thread GitBox
pkarashchenko commented on pull request #5249: URL: https://github.com/apache/incubator-nuttx/pull/5249#issuecomment-1015139932 @xiaoxiang781216 please take a loop. If you approve I think we can merge this change -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [incubator-nuttx] Gary-Hobson opened a new pull request #5258: add touchscreen uinput driver

2022-01-17 Thread GitBox
Gary-Hobson opened a new pull request #5258: URL: https://github.com/apache/incubator-nuttx/pull/5258 ## Summary Using the uinput device to provide virtual data to the application without the existence of the real device. For example, provide lvgl with virtual touchscreen data for

[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5254: net: unify FAR keyword usage for all net buffer memory mapped buffers

2022-01-17 Thread GitBox
pkarashchenko commented on a change in pull request #5254: URL: https://github.com/apache/incubator-nuttx/pull/5254#discussion_r786449355 ## File path: arch/xtensa/src/esp32/esp32_wlan.c ## @@ -1077,7 +1077,7 @@ static void wlan_txtimeout_expiry(wdparm_t arg) static void

[GitHub] [incubator-nuttx] GUIDINGLI commented on a change in pull request #5232: rpmsg_rtc: resolve deadlock when the receive SYNC cmd

2022-01-17 Thread GitBox
GUIDINGLI commented on a change in pull request #5232: URL: https://github.com/apache/incubator-nuttx/pull/5232#discussion_r786409489 ## File path: drivers/timers/rpmsg_rtc.c ## @@ -310,7 +297,16 @@ static int rpmsg_rtc_ept_cb(FAR struct rpmsg_endpoint *ept, FAR void *data,

[GitHub] [incubator-nuttx] SPRESENSE opened a new pull request #5257: fs/smartfs: Fix file size corruption when opening with truncate mode

2022-01-17 Thread GitBox
SPRESENSE opened a new pull request #5257: URL: https://github.com/apache/incubator-nuttx/pull/5257 ## Summary If a existing file is opened with truncate mode e.g. fopen(file, "w+"), the file size will be incorrect after writing any data to the file. Before writing to the first

[GitHub] [incubator-nuttx] a-lunev commented on a change in pull request #5252: net/tcp/tcp_send*: reliably obtain the TCP connection pointer in TCP event handlers

2022-01-17 Thread GitBox
a-lunev commented on a change in pull request #5252: URL: https://github.com/apache/incubator-nuttx/pull/5252#discussion_r786398944 ## File path: net/tcp/tcp_send_buffered.c ## @@ -355,10 +355,38 @@ static uint16_t psock_send_eventhandler(FAR struct net_driver_s *dev,

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5252: net/tcp/tcp_send*: reliably obtain the TCP connection pointer in TCP event handlers

2022-01-17 Thread GitBox
xiaoxiang781216 commented on a change in pull request #5252: URL: https://github.com/apache/incubator-nuttx/pull/5252#discussion_r786390907 ## File path: net/tcp/tcp_send_buffered.c ## @@ -355,10 +355,38 @@ static uint16_t psock_send_eventhandler(FAR struct net_driver_s *dev,

[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on pull request #2063: Fix libcxx for sim/macOS

2022-01-17 Thread GitBox
xiaoxiang781216 edited a comment on pull request #2063: URL: https://github.com/apache/incubator-nuttx/pull/2063#issuecomment-1015036986 Ok, let's merge this until we find the better solution, but the patch need rebase first. -- This is an automated message from the Apache Git Service.

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #2063: Fix libcxx for sim/macOS

2022-01-17 Thread GitBox
xiaoxiang781216 commented on pull request #2063: URL: https://github.com/apache/incubator-nuttx/pull/2063#issuecomment-1015036986 Ok, let's merge this until we find the better solution. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5254: net: unify FAR keyword usage for all net buffer memory mapped buffers

2022-01-17 Thread GitBox
xiaoxiang781216 commented on a change in pull request #5254: URL: https://github.com/apache/incubator-nuttx/pull/5254#discussion_r786384684 ## File path: arch/mips/src/pic32mx/pic32mx_ethernet.c ## @@ -215,7 +215,7 @@ * header */ -#define BUF ((struct eth_hdr_s

[GitHub] [incubator-nuttx] zhuyanlinzyl edited a comment on pull request #5248: xtensa: some fixes in interrupt handler

2022-01-17 Thread GitBox
zhuyanlinzyl edited a comment on pull request #5248: URL: https://github.com/apache/incubator-nuttx/pull/5248#issuecomment-1015024713 hi, @acassis. No, I only test BUILD_FLAT. And also arch Xtensa do not support BULD_PROTECTED now. All kernel and user code run in user mode.

[GitHub] [incubator-nuttx] zhuyanlinzyl commented on pull request #5248: xtensa: some fixes in interrupt handler

2022-01-17 Thread GitBox
zhuyanlinzyl commented on pull request #5248: URL: https://github.com/apache/incubator-nuttx/pull/5248#issuecomment-1015024713 hi, @acassis. No, I only test BUILD_FLAT. And also arch xtensa do not support BULD_PROTECTED now. All kernel and user code run in user mode. -- This

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 merged pull request #969: netutils/netcat: sendfile related code refactoring + small fixes

2022-01-17 Thread GitBox
xiaoxiang781216 merged pull request #969: URL: https://github.com/apache/incubator-nuttx-apps/pull/969 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[incubator-nuttx-apps] branch master updated: netutils/netcat: sendfile related code refactoring + small fixes

2022-01-17 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git The following commit(s) were added to refs/heads/master by this push: new 371beb2 netutils/netcat:

[GitHub] [incubator-nuttx] SPRESENSE opened a new pull request #5256: Add usbdev serial use boardid

2022-01-17 Thread GitBox
SPRESENSE opened a new pull request #5256: URL: https://github.com/apache/incubator-nuttx/pull/5256 ## Summary Add use board unique ID as a USB device serial number support. ## Impact USB devices (MSC, Composite, PL2303, CDCACM, CDCECM, RNDIS, ADB) ## Testing

[GitHub] [incubator-nuttx] zouboan commented on pull request #5241: Port nuttx to sparc-v8

2022-01-17 Thread GitBox
zouboan commented on pull request #5241: URL: https://github.com/apache/incubator-nuttx/pull/5241#issuecomment-1014993056 @xiaoxiang781216 ok, i will try it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #5249: Fix aligment issue: pktbuf needs to be 16bit aligned

2022-01-17 Thread GitBox
pkarashchenko commented on pull request #5249: URL: https://github.com/apache/incubator-nuttx/pull/5249#issuecomment-1014982463 Hi, Yes. That seems to be true. I was confused about "if (BUF->type == HTONS(ETHTYPE_IP))" and I didn't expect it to fail anymore with a packed

[GitHub] [incubator-nuttx-apps] a-lunev opened a new pull request #969: netutils/netcat: sendfile related code refactoring + small fixes

2022-01-17 Thread GitBox
a-lunev opened a new pull request #969: URL: https://github.com/apache/incubator-nuttx-apps/pull/969 ## Summary sendfile related code refactoring + small fixes. ## Impact netutils/netcat ## Testing Build NuttX: ``` $ ./tools/configure.sh -l

[GitHub] [incubator-nuttx] gustavonihei commented on pull request #5254: net: unify FAR keyword usage for all net buffer memory mapped buffers

2022-01-17 Thread GitBox
gustavonihei commented on pull request #5254: URL: https://github.com/apache/incubator-nuttx/pull/5254#issuecomment-1014968493 > > FAR qualifier is only required for common code. Many (if not all, haven’t looked at all files) are restricted to chip implementation. Besides, FAR and CODE

[incubator-nuttx-website] branch asf-site updated: Publishing web: adbba922a8890b650c27ecac31f9d26fe25e1ec4 docs: 04723a89f2010f17bc2a18f788eff4a93e292d2d

2022-01-17 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-website.git The following commit(s) were added to refs/heads/asf-site by this push: new 6f35c69 Publishing

[GitHub] [incubator-nuttx] ptka removed a comment on pull request #5249: Fix aligment issue: pktbuf needs to be 16bit aligned

2022-01-17 Thread GitBox
ptka removed a comment on pull request #5249: URL: https://github.com/apache/incubator-nuttx/pull/5249#issuecomment-1014958870 I did some further investigations and the issue is now at the next place in arp_table.c: void arp_hdr_update(FAR struct net_driver_s *dev, FAR uint16_t

[GitHub] [incubator-nuttx] ptka commented on pull request #5249: Fix aligment issue: pktbuf needs to be 16bit aligned

2022-01-17 Thread GitBox
ptka commented on pull request #5249: URL: https://github.com/apache/incubator-nuttx/pull/5249#issuecomment-1014958870 I did some further investigations and the issue is now at the next place in arp_table.c: void arp_hdr_update(FAR struct net_driver_s *dev, FAR uint16_t *pipaddr,

[GitHub] [incubator-nuttx] pkarashchenko opened a new issue #5255: make: *** No rule to make target 'byte', needed by 'differ'. Stop.

2022-01-17 Thread GitBox
pkarashchenko opened a new issue #5255: URL: https://github.com/apache/incubator-nuttx/issues/5255 Sometimes when running `make` few times in a row compilation fails with `make: *** No rule to make target 'byte', needed by 'differ'. Stop.` -- This is an automated message from the

[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #5254: net: unify FAR keyword usage for all net buffer memory mapped buffers

2022-01-17 Thread GitBox
pkarashchenko commented on pull request #5254: URL: https://github.com/apache/incubator-nuttx/pull/5254#issuecomment-1014947616 > FAR qualifier is only required for common code. Many (if not all, haven’t looked at all files) are restricted to chip implementation. Besides, FAR and CODE

[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5249: Fix aligment issue: pktbuf needs to be 16bit aligned

2022-01-17 Thread GitBox
pkarashchenko commented on a change in pull request #5249: URL: https://github.com/apache/incubator-nuttx/pull/5249#discussion_r786326970 ## File path: drivers/usbdev/cdcecm.c ## @@ -120,7 +120,7 @@ struct cdcecm_driver_s FAR struct usbdev_ep_s *epbulkout; /* Bulk

[GitHub] [incubator-nuttx] pkarashchenko closed pull request #5251: ethernet: apply compiler packing to all ethernet packet based types that are memory mapped

2022-01-17 Thread GitBox
pkarashchenko closed pull request #5251: URL: https://github.com/apache/incubator-nuttx/pull/5251 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #5251: ethernet: apply compiler packing to all ethernet packet based types that are memory mapped

2022-01-17 Thread GitBox
pkarashchenko commented on pull request #5251: URL: https://github.com/apache/incubator-nuttx/pull/5251#issuecomment-1014944528 But maybe this changes are not worth of moving forward with. There are many places that are taking addresses that now become unaligned. Maybe we just need to

[GitHub] [incubator-nuttx] normanr commented on issue #5253: `df -h` not rendered correctly when LIBC_LONG_LONG is disabled

2022-01-17 Thread GitBox
normanr commented on issue #5253: URL: https://github.com/apache/incubator-nuttx/issues/5253#issuecomment-1014943283 I also tried SiFive's gcc version 10.2.0: ``` nsh> df -h FilesystemSize Used Available Mounted on romfs 1107365336@0B 9998@

[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #5251: ethernet: apply compiler packing to all ethernet packet based types that are memory mapped

2022-01-17 Thread GitBox
pkarashchenko commented on pull request #5251: URL: https://github.com/apache/incubator-nuttx/pull/5251#issuecomment-1014942062 > I think the bug is that some architectures do not support dereferencing a pointer to an unaligned address. Packing the structs will create more of those, won't

[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5249: Fix aligment issue: pktbuf needs to be 16bit aligned

2022-01-17 Thread GitBox
pkarashchenko commented on a change in pull request #5249: URL: https://github.com/apache/incubator-nuttx/pull/5249#discussion_r786318309 ## File path: drivers/usbdev/cdcecm.c ## @@ -120,7 +120,7 @@ struct cdcecm_driver_s FAR struct usbdev_ep_s *epbulkout; /* Bulk

[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5249: Fix aligment issue: pktbuf needs to be 16bit aligned

2022-01-17 Thread GitBox
pkarashchenko commented on a change in pull request #5249: URL: https://github.com/apache/incubator-nuttx/pull/5249#discussion_r786318309 ## File path: drivers/usbdev/cdcecm.c ## @@ -120,7 +120,7 @@ struct cdcecm_driver_s FAR struct usbdev_ep_s *epbulkout; /* Bulk

[GitHub] [incubator-nuttx] ptka commented on pull request #5251: ethernet: apply compiler packing to all ethernet packet based types that are memory mapped

2022-01-17 Thread GitBox
ptka commented on pull request #5251: URL: https://github.com/apache/incubator-nuttx/pull/5251#issuecomment-1014924189 I took incubator head revision, your change and my additonal changes (board configuration level to get cdcecm included and started). I cannot judge on the changes,

[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #5251: ethernet: apply compiler packing to all ethernet packet based types that are memory mapped

2022-01-17 Thread GitBox
pkarashchenko commented on pull request #5251: URL: https://github.com/apache/incubator-nuttx/pull/5251#issuecomment-1014924077 > > @a-lunev could you please also participate in the review since you are doing many changes to the networking sub-system? > > So far, I do not well

[GitHub] [incubator-nuttx] pkarashchenko opened a new pull request #5254: net: unify FAR keyword usage for all net buffer memory mapped buffers

2022-01-17 Thread GitBox
pkarashchenko opened a new pull request #5254: URL: https://github.com/apache/incubator-nuttx/pull/5254 ## Summary In some cases the `FAR` keyword is missing when working with network buffers and using memory mapped types. Restore consistency ## Impact No functional changes

[GitHub] [incubator-nuttx] normanr opened a new issue #5253: `df -h` not rendered correctly when LIBC_LONG_LONG is disabled

2022-01-17 Thread GitBox
normanr opened a new issue #5253: URL: https://github.com/apache/incubator-nuttx/issues/5253 I get some very strange output for `df -h` on my bl602. As `dh -h` is just a wrapper around `cat /proc/fs/usage` the issue comes from `usage_entry` in fs_procfs_mount.c. Unfortunately I can

[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #5251: ethernet: apply compiler packing to all ethernet packet based types that are memory mapped

2022-01-17 Thread GitBox
pkarashchenko commented on pull request #5251: URL: https://github.com/apache/incubator-nuttx/pull/5251#issuecomment-1014914339 > > @a-lunev could you please also participate in the review since you are doing many changes to the networking sub-system? > > So far, I do not well

[GitHub] [incubator-nuttx] a-lunev commented on pull request #5251: ethernet: apply compiler packing to all ethernet packet based types that are memory mapped

2022-01-17 Thread GitBox
a-lunev commented on pull request #5251: URL: https://github.com/apache/incubator-nuttx/pull/5251#issuecomment-1014911072 > @a-lunev could you please also participate in the review since you are doing many changes to the networking sub-system? So far, I do not well understand if

[GitHub] [incubator-nuttx] ptka commented on a change in pull request #5249: Fix aligment issue: pktbuf needs to be 16bit aligned

2022-01-17 Thread GitBox
ptka commented on a change in pull request #5249: URL: https://github.com/apache/incubator-nuttx/pull/5249#discussion_r786301316 ## File path: drivers/usbdev/cdcecm.c ## @@ -120,7 +120,7 @@ struct cdcecm_driver_s FAR struct usbdev_ep_s *epbulkout; /* Bulk OUT

[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #5251: ethernet: apply compiler packing to all ethernet packet based types that are memory mapped

2022-01-17 Thread GitBox
pkarashchenko commented on pull request #5251: URL: https://github.com/apache/incubator-nuttx/pull/5251#issuecomment-1014902244 @a-lunev could you please also participate in the review since you are doing many changes to the networking sub-system? -- This is an automated message from

[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5249: Fix aligment issue: pktbuf needs to be 16bit aligned

2022-01-17 Thread GitBox
pkarashchenko commented on a change in pull request #5249: URL: https://github.com/apache/incubator-nuttx/pull/5249#discussion_r786298235 ## File path: drivers/usbdev/cdcecm.c ## @@ -120,7 +120,7 @@ struct cdcecm_driver_s FAR struct usbdev_ep_s *epbulkout; /* Bulk

[GitHub] [incubator-nuttx] a-lunev opened a new pull request #5252: net/tcp/tcp_send*: reliably obtain the TCP connection pointer in TCP event handlers

2022-01-17 Thread GitBox
a-lunev opened a new pull request #5252: URL: https://github.com/apache/incubator-nuttx/pull/5252 ## Summary Do not use pvconn argument to get the TCP connection pointer because pvconn is normally NULL for some events like NETDEV_DOWN. Instead, the TCP connection pointer can be

[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5249: Fix aligment issue: pktbuf needs to be 16bit aligned

2022-01-17 Thread GitBox
pkarashchenko commented on a change in pull request #5249: URL: https://github.com/apache/incubator-nuttx/pull/5249#discussion_r786296146 ## File path: drivers/usbdev/cdcecm.c ## @@ -120,7 +120,7 @@ struct cdcecm_driver_s FAR struct usbdev_ep_s *epbulkout; /* Bulk

[GitHub] [incubator-nuttx] pkarashchenko opened a new pull request #5251: ethernet: apply compiler packing to all ethernet packet based types that are memory mapped

2022-01-17 Thread GitBox
pkarashchenko opened a new pull request #5251: URL: https://github.com/apache/incubator-nuttx/pull/5251 ## Summary The network stack does not have any information about memory that stores the Ethernet (TCP/IP) packet, so in order to generate proper code that takes care all the

[GitHub] [incubator-nuttx] ptka commented on a change in pull request #5249: Fix aligment issue: pktbuf needs to be 16bit aligned

2022-01-17 Thread GitBox
ptka commented on a change in pull request #5249: URL: https://github.com/apache/incubator-nuttx/pull/5249#discussion_r786295371 ## File path: drivers/usbdev/cdcecm.c ## @@ -120,7 +120,7 @@ struct cdcecm_driver_s FAR struct usbdev_ep_s *epbulkout; /* Bulk OUT

[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5249: Fix aligment issue: pktbuf needs to be 16bit aligned

2022-01-17 Thread GitBox
pkarashchenko commented on a change in pull request #5249: URL: https://github.com/apache/incubator-nuttx/pull/5249#discussion_r786274863 ## File path: drivers/usbdev/cdcecm.c ## @@ -120,7 +120,7 @@ struct cdcecm_driver_s FAR struct usbdev_ep_s *epbulkout; /* Bulk

[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5249: Fix aligment issue: pktbuf needs to be 16bit aligned

2022-01-17 Thread GitBox
pkarashchenko commented on a change in pull request #5249: URL: https://github.com/apache/incubator-nuttx/pull/5249#discussion_r786264331 ## File path: drivers/usbdev/cdcecm.c ## @@ -120,7 +120,7 @@ struct cdcecm_driver_s FAR struct usbdev_ep_s *epbulkout; /* Bulk

[GitHub] [incubator-nuttx] jlaitine commented on a change in pull request #5247: Mpfs switch to exception common

2022-01-17 Thread GitBox
jlaitine commented on a change in pull request #5247: URL: https://github.com/apache/incubator-nuttx/pull/5247#discussion_r786262409 ## File path: arch/risc-v/src/common/riscv_exception_common.S ## @@ -49,7 +49,9 @@ exception_common: addi sp, sp, -XCPTCONTEXT_SIZE

[GitHub] [incubator-nuttx] ptka commented on a change in pull request #5249: Fix aligment issue: pktbuf needs to be 16bit aligned

2022-01-17 Thread GitBox
ptka commented on a change in pull request #5249: URL: https://github.com/apache/incubator-nuttx/pull/5249#discussion_r786260549 ## File path: drivers/usbdev/cdcecm.c ## @@ -120,7 +120,7 @@ struct cdcecm_driver_s FAR struct usbdev_ep_s *epbulkout; /* Bulk OUT

[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5249: Fix aligment issue: pktbuf needs to be 16bit aligned

2022-01-17 Thread GitBox
pkarashchenko commented on a change in pull request #5249: URL: https://github.com/apache/incubator-nuttx/pull/5249#discussion_r786257267 ## File path: drivers/usbdev/cdcecm.c ## @@ -120,7 +120,7 @@ struct cdcecm_driver_s FAR struct usbdev_ep_s *epbulkout; /* Bulk

[GitHub] [incubator-nuttx] ptka commented on pull request #5249: Fix aligment issue: pktbuf needs to be 16bit aligned

2022-01-17 Thread GitBox
ptka commented on pull request #5249: URL: https://github.com/apache/incubator-nuttx/pull/5249#issuecomment-1014837041 > Please fix > > ``` > Error: usbdev/cdcecm.c:2098:23: error: assignment to 'uint8_t *' {aka 'unsigned char *'} from incompatible pointer type 'uint16_t *' {aka

[GitHub] [incubator-nuttx] ptka commented on a change in pull request #5249: Fix aligment issue: pktbuf needs to be 16bit aligned

2022-01-17 Thread GitBox
ptka commented on a change in pull request #5249: URL: https://github.com/apache/incubator-nuttx/pull/5249#discussion_r786254615 ## File path: drivers/usbdev/cdcecm.c ## @@ -120,7 +120,7 @@ struct cdcecm_driver_s FAR struct usbdev_ep_s *epbulkout; /* Bulk OUT

[GitHub] [incubator-nuttx] ptka commented on a change in pull request #5249: Fix aligment issue: pktbuf needs to be 16bit aligned

2022-01-17 Thread GitBox
ptka commented on a change in pull request #5249: URL: https://github.com/apache/incubator-nuttx/pull/5249#discussion_r786252367 ## File path: drivers/usbdev/cdcecm.c ## @@ -120,7 +120,7 @@ struct cdcecm_driver_s FAR struct usbdev_ep_s *epbulkout; /* Bulk OUT

[GitHub] [incubator-nuttx] ptka commented on a change in pull request #5249: Fix aligment issue: pktbuf needs to be 16bit aligned

2022-01-17 Thread GitBox
ptka commented on a change in pull request #5249: URL: https://github.com/apache/incubator-nuttx/pull/5249#discussion_r786245870 ## File path: drivers/usbdev/cdcecm.c ## @@ -120,7 +120,7 @@ struct cdcecm_driver_s FAR struct usbdev_ep_s *epbulkout; /* Bulk OUT

[GitHub] [incubator-nuttx] ptka commented on a change in pull request #5249: Fix aligment issue: pktbuf needs to be 16bit aligned

2022-01-17 Thread GitBox
ptka commented on a change in pull request #5249: URL: https://github.com/apache/incubator-nuttx/pull/5249#discussion_r786245302 ## File path: drivers/usbdev/cdcecm.c ## @@ -120,7 +120,7 @@ struct cdcecm_driver_s FAR struct usbdev_ep_s *epbulkout; /* Bulk OUT

[GitHub] [incubator-nuttx] jlaitine commented on a change in pull request #5247: Mpfs switch to exception common

2022-01-17 Thread GitBox
jlaitine commented on a change in pull request #5247: URL: https://github.com/apache/incubator-nuttx/pull/5247#discussion_r786243630 ## File path: arch/risc-v/src/common/riscv_exception_common.S ## @@ -178,16 +181,8 @@ exception_common: .type g_intstackalloc, object

[GitHub] [incubator-nuttx] jlaitine commented on a change in pull request #5247: Mpfs switch to exception common

2022-01-17 Thread GitBox
jlaitine commented on a change in pull request #5247: URL: https://github.com/apache/incubator-nuttx/pull/5247#discussion_r786242006 ## File path: arch/risc-v/src/mpfs/Kconfig ## @@ -46,6 +46,9 @@ config MPFS_BOOTLOADER ---help--- This NuttX image is

[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5249: Fix aligment issue: pktbuf needs to be 16bit aligned

2022-01-17 Thread GitBox
pkarashchenko commented on a change in pull request #5249: URL: https://github.com/apache/incubator-nuttx/pull/5249#discussion_r786241904 ## File path: drivers/usbdev/cdcecm.c ## @@ -120,7 +120,7 @@ struct cdcecm_driver_s FAR struct usbdev_ep_s *epbulkout; /* Bulk

[GitHub] [incubator-nuttx] jlaitine commented on a change in pull request #5247: Mpfs switch to exception common

2022-01-17 Thread GitBox
jlaitine commented on a change in pull request #5247: URL: https://github.com/apache/incubator-nuttx/pull/5247#discussion_r786240912 ## File path: arch/risc-v/src/common/riscv_exception_common.S ## @@ -178,16 +181,8 @@ exception_common: .type g_intstackalloc, object

[GitHub] [incubator-nuttx] ptka commented on a change in pull request #5249: Fix aligment issue: pktbuf needs to be 16bit aligned

2022-01-17 Thread GitBox
ptka commented on a change in pull request #5249: URL: https://github.com/apache/incubator-nuttx/pull/5249#discussion_r786235577 ## File path: drivers/usbdev/cdcecm.c ## @@ -120,7 +120,7 @@ struct cdcecm_driver_s FAR struct usbdev_ep_s *epbulkout; /* Bulk OUT

[GitHub] [incubator-nuttx] acassis commented on pull request #5237: add CAN example for b-g431b-esc1 and nucleo-g431rb

2022-01-17 Thread GitBox
acassis commented on pull request #5237: URL: https://github.com/apache/incubator-nuttx/pull/5237#issuecomment-1014805252 @raiden00pl please take a look: ``` In file included from board/stm32_boot.c:28: Error: /github/workspace/sources/nuttx/include/arch/board/board.h:256:4:

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #5250: xtensa: Fix core voltage level when SPI Flash runs at 80Mhz

2022-01-17 Thread GitBox
xiaoxiang781216 merged pull request #5250: URL: https://github.com/apache/incubator-nuttx/pull/5250 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[incubator-nuttx] branch master updated (f61f276 -> 04723a8)

2022-01-17 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from f61f276 net/tcp/sendfile: TCP retransmission could not start because of incorrect snd_ackcb callback

[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5249: Fix aligment issue: pktbuf needs to be 16bit aligned

2022-01-17 Thread GitBox
pkarashchenko commented on a change in pull request #5249: URL: https://github.com/apache/incubator-nuttx/pull/5249#discussion_r786224832 ## File path: drivers/usbdev/cdcecm.c ## @@ -120,7 +120,7 @@ struct cdcecm_driver_s FAR struct usbdev_ep_s *epbulkout; /* Bulk

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5249: Fix aligment issue: pktbuf needs to be 16bit aligned

2022-01-17 Thread GitBox
xiaoxiang781216 commented on a change in pull request #5249: URL: https://github.com/apache/incubator-nuttx/pull/5249#discussion_r786222703 ## File path: drivers/usbdev/cdcecm.c ## @@ -120,7 +120,7 @@ struct cdcecm_driver_s FAR struct usbdev_ep_s *epbulkout; /* Bulk

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #5241: Port nuttx to sparc-v8

2022-01-17 Thread GitBox
xiaoxiang781216 commented on pull request #5241: URL: https://github.com/apache/incubator-nuttx/pull/5241#issuecomment-1014788972 @zouboan could you add sparc-v8 to the daily ci? You can add the tool installation here:

[incubator-nuttx] branch master updated (e140ba1 -> f61f276)

2022-01-17 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from e140ba1 arch/stm32: fdcan cosmetics add f61f276 net/tcp/sendfile: TCP retransmission could not

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #5242: net/tcp/sendfile: TCP retransmission could not start because of incorrect snd_ackcb callback handling

2022-01-17 Thread GitBox
xiaoxiang781216 merged pull request #5242: URL: https://github.com/apache/incubator-nuttx/pull/5242 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5247: Mpfs switch to exception common

2022-01-17 Thread GitBox
xiaoxiang781216 commented on a change in pull request #5247: URL: https://github.com/apache/incubator-nuttx/pull/5247#discussion_r786217985 ## File path: arch/risc-v/src/common/riscv_exception_common.S ## @@ -49,7 +49,9 @@ exception_common: addi sp, sp,

[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #5249: Fix aligment issue: pktbuf needs to be 16bit aligned

2022-01-17 Thread GitBox
pkarashchenko commented on pull request #5249: URL: https://github.com/apache/incubator-nuttx/pull/5249#issuecomment-101415 Please fix ``` Error: usbdev/cdcecm.c:2098:23: error: assignment to 'uint8_t *' {aka 'unsigned char *'} from incompatible pointer type 'uint16_t *' {aka

[GitHub] [incubator-nuttx] gustavonihei opened a new pull request #5250: xtensa: Fix core voltage level when SPI Flash runs at 80Mhz

2022-01-17 Thread GitBox
gustavonihei opened a new pull request #5250: URL: https://github.com/apache/incubator-nuttx/pull/5250 ## Summary This PR intends to fix the core voltage level of both **ESP32** and **ESP32-S2** when their SPI Flash runs at 80 MHz. ## Impact Only for **ESP32** and **ESP32-S2**

[GitHub] [incubator-nuttx] ptka commented on a change in pull request #5249: Fix aligment issue: pktbuf needs to be 16bit aligned

2022-01-17 Thread GitBox
ptka commented on a change in pull request #5249: URL: https://github.com/apache/incubator-nuttx/pull/5249#discussion_r786169975 ## File path: drivers/usbdev/cdcecm.c ## @@ -120,7 +120,7 @@ struct cdcecm_driver_s FAR struct usbdev_ep_s *epbulkout; /* Bulk OUT

[GitHub] [incubator-nuttx] ptka commented on a change in pull request #5249: Fix aligment issue: pktbuf needs to be 16bit aligned

2022-01-17 Thread GitBox
ptka commented on a change in pull request #5249: URL: https://github.com/apache/incubator-nuttx/pull/5249#discussion_r786120096 ## File path: drivers/usbdev/cdcecm.c ## @@ -120,7 +120,7 @@ struct cdcecm_driver_s FAR struct usbdev_ep_s *epbulkout; /* Bulk OUT

[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5249: Fix aligment issue: pktbuf needs to be 16bit aligned

2022-01-17 Thread GitBox
pkarashchenko commented on a change in pull request #5249: URL: https://github.com/apache/incubator-nuttx/pull/5249#discussion_r786112280 ## File path: drivers/usbdev/cdcecm.c ## @@ -120,7 +120,7 @@ struct cdcecm_driver_s FAR struct usbdev_ep_s *epbulkout; /* Bulk

[GitHub] [incubator-nuttx] zouboan commented on pull request #5241: Port nuttx to sparc-v8

2022-01-17 Thread GitBox
zouboan commented on pull request #5241: URL: https://github.com/apache/incubator-nuttx/pull/5241#issuecomment-1014662846 > "habemus spark v8" kudos @zouboan I will try to support the SMP of leon 5 in future -- This is an automated message from the Apache Git

[GitHub] [incubator-nuttx] ptka opened a new pull request #5249: Fix aligment issue: pktbuf needs to be 16bit aligned

2022-01-17 Thread GitBox
ptka opened a new pull request #5249: URL: https://github.com/apache/incubator-nuttx/pull/5249 ## Summary aligment is needed to avoid hard fault in driver/usbdev/usbdev.c in cdcecm_receive() at: #ifdef CONFIG_NET_IPv4 if (BUF->type == HTONS(ETHTYPE_IP))

[GitHub] [incubator-nuttx] a-lunev commented on a change in pull request #5242: net/tcp/sendfile: TCP retransmission could not start because of incorrect snd_ackcb callback handling

2022-01-17 Thread GitBox
a-lunev commented on a change in pull request #5242: URL: https://github.com/apache/incubator-nuttx/pull/5242#discussion_r786009323 ## File path: net/tcp/tcp_sendfile.c ## @@ -320,41 +298,38 @@ static uint16_t sendfile_eventhandler(FAR struct net_driver_s *dev,

[GitHub] [incubator-nuttx] a-lunev commented on a change in pull request #5242: net/tcp/sendfile: TCP retransmission could not start because of incorrect snd_ackcb callback handling

2022-01-17 Thread GitBox
a-lunev commented on a change in pull request #5242: URL: https://github.com/apache/incubator-nuttx/pull/5242#discussion_r786008604 ## File path: net/tcp/tcp_sendfile.c ## @@ -87,17 +86,63 @@ struct sendfile_s uint32_t snd_acked;/* The number of bytes

[GitHub] [incubator-nuttx] a-lunev commented on a change in pull request #5242: net/tcp/sendfile: TCP retransmission could not start because of incorrect snd_ackcb callback handling

2022-01-17 Thread GitBox
a-lunev commented on a change in pull request #5242: URL: https://github.com/apache/incubator-nuttx/pull/5242#discussion_r786006998 ## File path: net/tcp/tcp_sendfile.c ## @@ -87,17 +86,63 @@ struct sendfile_s uint32_t snd_acked;/* The number of bytes

[GitHub] [incubator-nuttx] a-lunev commented on a change in pull request #5242: net/tcp/sendfile: TCP retransmission could not start because of incorrect snd_ackcb callback handling

2022-01-17 Thread GitBox
a-lunev commented on a change in pull request #5242: URL: https://github.com/apache/incubator-nuttx/pull/5242#discussion_r786005125 ## File path: net/tcp/tcp_sendfile.c ## @@ -320,41 +298,38 @@ static uint16_t sendfile_eventhandler(FAR struct net_driver_s *dev,

[GitHub] [incubator-nuttx] a-lunev commented on a change in pull request #5242: net/tcp/sendfile: TCP retransmission could not start because of incorrect snd_ackcb callback handling

2022-01-17 Thread GitBox
a-lunev commented on a change in pull request #5242: URL: https://github.com/apache/incubator-nuttx/pull/5242#discussion_r786005125 ## File path: net/tcp/tcp_sendfile.c ## @@ -320,41 +298,38 @@ static uint16_t sendfile_eventhandler(FAR struct net_driver_s *dev,

[GitHub] [incubator-nuttx] a-lunev commented on a change in pull request #5242: net/tcp/sendfile: TCP retransmission could not start because of incorrect snd_ackcb callback handling

2022-01-17 Thread GitBox
a-lunev commented on a change in pull request #5242: URL: https://github.com/apache/incubator-nuttx/pull/5242#discussion_r785992413 ## File path: net/tcp/tcp_sendfile.c ## @@ -320,41 +298,38 @@ static uint16_t sendfile_eventhandler(FAR struct net_driver_s *dev,

[GitHub] [incubator-nuttx] acassis merged pull request #5206: stm32: add FDCAN support

2022-01-17 Thread GitBox
acassis merged pull request #5206: URL: https://github.com/apache/incubator-nuttx/pull/5206 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[incubator-nuttx] branch master updated (4f98ac4 -> e140ba1)

2022-01-17 Thread acassis
This is an automated email from the ASF dual-hosted git repository. acassis pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from 4f98ac4 arch/arm/samv7: implement quadrature encoder driver add c450dea stm32: add FDCAN support

[GitHub] [incubator-nuttx] acassis merged pull request #5219: arch/arm/samv7: implement quadrature encoder driver

2022-01-17 Thread GitBox
acassis merged pull request #5219: URL: https://github.com/apache/incubator-nuttx/pull/5219 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[incubator-nuttx] branch master updated (74aeb5d -> 4f98ac4)

2022-01-17 Thread acassis
This is an automated email from the ASF dual-hosted git repository. acassis pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from 74aeb5d port nuttx to sparc-v8 commit includes following parts: add support of sparc in arch/Kconfig add

[GitHub] [incubator-nuttx] acassis commented on pull request #5248: xtensa: some fixes in interrupt handler

2022-01-17 Thread GitBox
acassis commented on pull request #5248: URL: https://github.com/apache/incubator-nuttx/pull/5248#issuecomment-1014473411 Hi @zhuyanlinzyl did you test BUILD_PROTECTED ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [incubator-nuttx] jlaitine commented on pull request #5247: Mpfs switch to exception common

2022-01-17 Thread GitBox
jlaitine commented on pull request #5247: URL: https://github.com/apache/incubator-nuttx/pull/5247#issuecomment-1014456243 Did the modifications suggested by @pkarashchenko -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [incubator-nuttx] jlaitine commented on a change in pull request #5247: Mpfs switch to exception common

2022-01-17 Thread GitBox
jlaitine commented on a change in pull request #5247: URL: https://github.com/apache/incubator-nuttx/pull/5247#discussion_r785932706 ## File path: arch/risc-v/src/common/riscv_exception_common.S ## @@ -99,15 +101,14 @@ exception_common: csrr s0, mhartid /* Switch to

[GitHub] [incubator-nuttx] acassis commented on pull request #5241: Port nuttx to sparc-v8

2022-01-17 Thread GitBox
acassis commented on pull request #5241: URL: https://github.com/apache/incubator-nuttx/pull/5241#issuecomment-1014453469 "habemus spark v8" kudos @zouboan -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-nuttx] acassis merged pull request #5241: Port nuttx to sparc-v8

2022-01-17 Thread GitBox
acassis merged pull request #5241: URL: https://github.com/apache/incubator-nuttx/pull/5241 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[incubator-nuttx] branch master updated (10d98f6 -> 74aeb5d)

2022-01-17 Thread acassis
This is an automated email from the ASF dual-hosted git repository. acassis pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from 10d98f6 Documentation: risc-v/mpfs: update documentation add 74aeb5d port nuttx to sparc-v8 commit

[GitHub] [incubator-nuttx] jlaitine commented on a change in pull request #5247: Mpfs switch to exception common

2022-01-17 Thread GitBox
jlaitine commented on a change in pull request #5247: URL: https://github.com/apache/incubator-nuttx/pull/5247#discussion_r785919037 ## File path: boards/risc-v/mpfs/icicle/scripts/ld-envm-opensbi.script ## @@ -59,7 +59,7 @@ SECTIONS .text : { _stext =

[GitHub] [incubator-nuttx] jlaitine commented on a change in pull request #5247: Mpfs switch to exception common

2022-01-17 Thread GitBox
jlaitine commented on a change in pull request #5247: URL: https://github.com/apache/incubator-nuttx/pull/5247#discussion_r785918264 ## File path: arch/risc-v/src/common/riscv_exception_common.S ## @@ -99,15 +101,14 @@ exception_common: csrr s0, mhartid /* Switch to

[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5247: Mpfs switch to exception common

2022-01-17 Thread GitBox
pkarashchenko commented on a change in pull request #5247: URL: https://github.com/apache/incubator-nuttx/pull/5247#discussion_r785857818 ## File path: arch/risc-v/src/common/riscv_exception_common.S ## @@ -99,15 +101,14 @@ exception_common: csrr s0, mhartid /* Switch

  1   2   >