[GitHub] [incubator-pinot] kishoreg commented on a change in pull request #4602: First pass of GROUP BY with ORDER BY support

2019-09-13 Thread GitBox
kishoreg commented on a change in pull request #4602: First pass of GROUP BY with ORDER BY support URL: https://github.com/apache/incubator-pinot/pull/4602#discussion_r324411231 ## File path:

[GitHub] [incubator-pinot] kishoreg commented on a change in pull request #4602: First pass of GROUP BY with ORDER BY support

2019-09-13 Thread GitBox
kishoreg commented on a change in pull request #4602: First pass of GROUP BY with ORDER BY support URL: https://github.com/apache/incubator-pinot/pull/4602#discussion_r324411786 ## File path:

[GitHub] [incubator-pinot] kishoreg commented on a change in pull request #4602: First pass of GROUP BY with ORDER BY support

2019-09-13 Thread GitBox
kishoreg commented on a change in pull request #4602: First pass of GROUP BY with ORDER BY support URL: https://github.com/apache/incubator-pinot/pull/4602#discussion_r324411567 ## File path: pinot-core/src/main/java/org/apache/pinot/core/data/table/ConcurrentIndexedTable.java

[GitHub] [incubator-pinot] kishoreg commented on a change in pull request #4602: First pass of GROUP BY with ORDER BY support

2019-09-13 Thread GitBox
kishoreg commented on a change in pull request #4602: First pass of GROUP BY with ORDER BY support URL: https://github.com/apache/incubator-pinot/pull/4602#discussion_r324411518 ## File path: pinot-core/src/main/java/org/apache/pinot/core/data/table/ConcurrentIndexedTable.java

[GitHub] [incubator-pinot] kishoreg commented on a change in pull request #4602: First pass of GROUP BY with ORDER BY support

2019-09-13 Thread GitBox
kishoreg commented on a change in pull request #4602: First pass of GROUP BY with ORDER BY support URL: https://github.com/apache/incubator-pinot/pull/4602#discussion_r324411766 ## File path:

[GitHub] [incubator-pinot] kishoreg commented on a change in pull request #4602: First pass of GROUP BY with ORDER BY support

2019-09-13 Thread GitBox
kishoreg commented on a change in pull request #4602: First pass of GROUP BY with ORDER BY support URL: https://github.com/apache/incubator-pinot/pull/4602#discussion_r324411811 ## File path: pinot-core/src/main/java/org/apache/pinot/core/plan/CombinePlanNode.java ## @@

[GitHub] [incubator-pinot] kishoreg commented on a change in pull request #4602: First pass of GROUP BY with ORDER BY support

2019-09-13 Thread GitBox
kishoreg commented on a change in pull request #4602: First pass of GROUP BY with ORDER BY support URL: https://github.com/apache/incubator-pinot/pull/4602#discussion_r324411445 ## File path: pinot-core/src/main/java/org/apache/pinot/core/data/table/ConcurrentIndexedTable.java

[GitHub] [incubator-pinot] kishoreg commented on a change in pull request #4602: First pass of GROUP BY with ORDER BY support

2019-09-13 Thread GitBox
kishoreg commented on a change in pull request #4602: First pass of GROUP BY with ORDER BY support URL: https://github.com/apache/incubator-pinot/pull/4602#discussion_r324411303 ## File path: pinot-common/src/main/java/org/apache/pinot/common/utils/CommonConstants.java ##

[GitHub] [incubator-pinot] codecov-io edited a comment on issue #4597: [WIP] Adding json_path function to extract field from json object

2019-09-13 Thread GitBox
codecov-io edited a comment on issue #4597: [WIP] Adding json_path function to extract field from json object URL: https://github.com/apache/incubator-pinot/pull/4597#issuecomment-529669548 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4597?src=pr=h1) Report > Merging

[GitHub] [incubator-pinot] codecov-io edited a comment on issue #4553: Refactor ControllerLeaderLocator

2019-09-13 Thread GitBox
codecov-io edited a comment on issue #4553: Refactor ControllerLeaderLocator URL: https://github.com/apache/incubator-pinot/pull/4553#issuecomment-524232323 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4553?src=pr=h1) Report > Merging

[GitHub] [incubator-pinot] jackjlli commented on a change in pull request #4567: Add integration test for ControllerLeaderLocator

2019-09-13 Thread GitBox
jackjlli commented on a change in pull request #4567: Add integration test for ControllerLeaderLocator URL: https://github.com/apache/incubator-pinot/pull/4567#discussion_r324392158 ## File path:

[GitHub] [incubator-pinot] jackjlli commented on a change in pull request #4553: Refactor ControllerLeaderLocator

2019-09-13 Thread GitBox
jackjlli commented on a change in pull request #4553: Refactor ControllerLeaderLocator URL: https://github.com/apache/incubator-pinot/pull/4553#discussion_r324388158 ## File path: pinot-core/src/main/java/org/apache/pinot/server/realtime/ControllerLeaderLocator.java ##

[GitHub] [incubator-pinot] jackjlli commented on a change in pull request #4553: Refactor ControllerLeaderLocator

2019-09-13 Thread GitBox
jackjlli commented on a change in pull request #4553: Refactor ControllerLeaderLocator URL: https://github.com/apache/incubator-pinot/pull/4553#discussion_r324388249 ## File path: pinot-core/src/main/java/org/apache/pinot/server/realtime/ControllerLeaderLocator.java ##

[GitHub] [incubator-pinot] jackjlli commented on a change in pull request #4553: Refactor ControllerLeaderLocator

2019-09-13 Thread GitBox
jackjlli commented on a change in pull request #4553: Refactor ControllerLeaderLocator URL: https://github.com/apache/incubator-pinot/pull/4553#discussion_r324388229 ## File path: pinot-core/src/main/java/org/apache/pinot/server/realtime/ControllerLeaderLocator.java ##

[GitHub] [incubator-pinot] jackjlli commented on a change in pull request #4553: Refactor ControllerLeaderLocator

2019-09-13 Thread GitBox
jackjlli commented on a change in pull request #4553: Refactor ControllerLeaderLocator URL: https://github.com/apache/incubator-pinot/pull/4553#discussion_r324388119 ## File path: pinot-core/src/main/java/org/apache/pinot/server/realtime/ControllerLeaderLocator.java ##

[GitHub] [incubator-pinot] jackjlli commented on a change in pull request #4553: Refactor ControllerLeaderLocator

2019-09-13 Thread GitBox
jackjlli commented on a change in pull request #4553: Refactor ControllerLeaderLocator URL: https://github.com/apache/incubator-pinot/pull/4553#discussion_r324388084 ## File path: pinot-core/src/main/java/org/apache/pinot/server/realtime/ControllerLeaderLocator.java ##

[GitHub] [incubator-pinot] jackjlli commented on a change in pull request #4553: Refactor ControllerLeaderLocator

2019-09-13 Thread GitBox
jackjlli commented on a change in pull request #4553: Refactor ControllerLeaderLocator URL: https://github.com/apache/incubator-pinot/pull/4553#discussion_r324386815 ## File path: pinot-core/src/main/java/org/apache/pinot/server/realtime/ControllerLeaderLocator.java ##

[GitHub] [incubator-pinot] jackjlli commented on a change in pull request #4553: Refactor ControllerLeaderLocator

2019-09-13 Thread GitBox
jackjlli commented on a change in pull request #4553: Refactor ControllerLeaderLocator URL: https://github.com/apache/incubator-pinot/pull/4553#discussion_r324379250 ## File path: pinot-core/src/main/java/org/apache/pinot/server/realtime/ControllerLeaderLocator.java ##

[GitHub] [incubator-pinot] jackjlli commented on issue #4583: Support default value for Byte column

2019-09-13 Thread GitBox
jackjlli commented on issue #4583: Support default value for Byte column URL: https://github.com/apache/incubator-pinot/pull/4583#issuecomment-531390467 @mayankshriv tests for both HLL and TDigest columns added. This is an

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4607: Add code for pinot benchmark as a service

2019-09-13 Thread GitBox
mcvsubbu commented on a change in pull request #4607: Add code for pinot benchmark as a service URL: https://github.com/apache/incubator-pinot/pull/4607#discussion_r324358479 ## File path: pinot-benchmark/src/main/java/org/apache/pinot/benchmark/PinotBenchmarkServiceStarter.java

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4607: Add code for pinot benchmark as a service

2019-09-13 Thread GitBox
mcvsubbu commented on a change in pull request #4607: Add code for pinot benchmark as a service URL: https://github.com/apache/incubator-pinot/pull/4607#discussion_r324358298 ## File path: pinot-benchmark/src/main/java/org/apache/pinot/benchmark/PinotBenchmarkServiceStarter.java

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4607: Add code for pinot benchmark as a service

2019-09-13 Thread GitBox
mcvsubbu commented on a change in pull request #4607: Add code for pinot benchmark as a service URL: https://github.com/apache/incubator-pinot/pull/4607#discussion_r324357773 ## File path: pinot-benchmark/src/main/java/org/apache/pinot/benchmark/PinotBenchmarkServiceStarter.java

[GitHub] [incubator-pinot] xiaohui-sun opened a new pull request #4613: [TE] consider anomaly type during merge

2019-09-13 Thread GitBox
xiaohui-sun opened a new pull request #4613: [TE] consider anomaly type during merge URL: https://github.com/apache/incubator-pinot/pull/4613 This PR fixes the logic so that we don't merge two anomalies if they have different types.

[GitHub] [incubator-pinot] akshayrai commented on a change in pull request #4609: [TE][Composite-Alert] Entity Anomaly Merger

2019-09-13 Thread GitBox
akshayrai commented on a change in pull request #4609: [TE][Composite-Alert] Entity Anomaly Merger URL: https://github.com/apache/incubator-pinot/pull/4609#discussion_r324308652 ## File path:

[GitHub] [incubator-pinot] akshayrai commented on a change in pull request #4609: [TE][Composite-Alert] Entity Anomaly Merger

2019-09-13 Thread GitBox
akshayrai commented on a change in pull request #4609: [TE][Composite-Alert] Entity Anomaly Merger URL: https://github.com/apache/incubator-pinot/pull/4609#discussion_r324308660 ## File path:

[GitHub] [incubator-pinot] codecov-io edited a comment on issue #4602: First pass of GROUP BY with ORDER BY support

2019-09-13 Thread GitBox
codecov-io edited a comment on issue #4602: First pass of GROUP BY with ORDER BY support URL: https://github.com/apache/incubator-pinot/pull/4602#issuecomment-530129911 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4602?src=pr=h1) Report > Merging

[GitHub] [incubator-pinot] chenboat commented on issue #4608: Unit tests and bug fixes for DeleteTable rest API for controller.

2019-09-13 Thread GitBox
chenboat commented on issue #4608: Unit tests and bug fixes for DeleteTable rest API for controller. URL: https://github.com/apache/incubator-pinot/pull/4608#issuecomment-531331597 > Is this somehow causing an issue in your environment? What is the motivation behind this change?

[GitHub] [incubator-pinot] vincentchenjl commented on a change in pull request #4611: [TE] Remove the logic of reading stderr from phantomjs to avoid zombie processes

2019-09-13 Thread GitBox
vincentchenjl commented on a change in pull request #4611: [TE] Remove the logic of reading stderr from phantomjs to avoid zombie processes URL: https://github.com/apache/incubator-pinot/pull/4611#discussion_r324294233 ## File path:

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4567: Add integration test for ControllerLeaderLocator

2019-09-13 Thread GitBox
mcvsubbu commented on a change in pull request #4567: Add integration test for ControllerLeaderLocator URL: https://github.com/apache/incubator-pinot/pull/4567#discussion_r324293457 ## File path:

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4567: Add integration test for ControllerLeaderLocator

2019-09-13 Thread GitBox
mcvsubbu commented on a change in pull request #4567: Add integration test for ControllerLeaderLocator URL: https://github.com/apache/incubator-pinot/pull/4567#discussion_r324291564 ## File path:

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4567: Add integration test for ControllerLeaderLocator

2019-09-13 Thread GitBox
mcvsubbu commented on a change in pull request #4567: Add integration test for ControllerLeaderLocator URL: https://github.com/apache/incubator-pinot/pull/4567#discussion_r324293752 ## File path:

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4553: Refactor ControllerLeaderLocator

2019-09-13 Thread GitBox
mcvsubbu commented on a change in pull request #4553: Refactor ControllerLeaderLocator URL: https://github.com/apache/incubator-pinot/pull/4553#discussion_r324286616 ## File path: pinot-core/src/main/java/org/apache/pinot/server/realtime/ControllerLeaderLocator.java ##

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4553: Refactor ControllerLeaderLocator

2019-09-13 Thread GitBox
mcvsubbu commented on a change in pull request #4553: Refactor ControllerLeaderLocator URL: https://github.com/apache/incubator-pinot/pull/4553#discussion_r324278948 ## File path: pinot-core/src/main/java/org/apache/pinot/server/realtime/ControllerLeaderLocator.java ##

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4553: Refactor ControllerLeaderLocator

2019-09-13 Thread GitBox
mcvsubbu commented on a change in pull request #4553: Refactor ControllerLeaderLocator URL: https://github.com/apache/incubator-pinot/pull/4553#discussion_r324281828 ## File path: pinot-core/src/main/java/org/apache/pinot/server/realtime/ControllerLeaderLocator.java ##

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4553: Refactor ControllerLeaderLocator

2019-09-13 Thread GitBox
mcvsubbu commented on a change in pull request #4553: Refactor ControllerLeaderLocator URL: https://github.com/apache/incubator-pinot/pull/4553#discussion_r324271954 ## File path: pinot-core/src/main/java/org/apache/pinot/server/realtime/ControllerLeaderLocator.java ##

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4553: Refactor ControllerLeaderLocator

2019-09-13 Thread GitBox
mcvsubbu commented on a change in pull request #4553: Refactor ControllerLeaderLocator URL: https://github.com/apache/incubator-pinot/pull/4553#discussion_r324278317 ## File path: pinot-core/src/main/java/org/apache/pinot/server/realtime/ControllerLeaderLocator.java ##

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4553: Refactor ControllerLeaderLocator

2019-09-13 Thread GitBox
mcvsubbu commented on a change in pull request #4553: Refactor ControllerLeaderLocator URL: https://github.com/apache/incubator-pinot/pull/4553#discussion_r324287164 ## File path: pinot-core/src/main/java/org/apache/pinot/server/realtime/ControllerLeaderLocator.java ##

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4553: Refactor ControllerLeaderLocator

2019-09-13 Thread GitBox
mcvsubbu commented on a change in pull request #4553: Refactor ControllerLeaderLocator URL: https://github.com/apache/incubator-pinot/pull/4553#discussion_r324284314 ## File path: pinot-core/src/main/java/org/apache/pinot/server/realtime/ControllerLeaderLocator.java ##

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4553: Refactor ControllerLeaderLocator

2019-09-13 Thread GitBox
mcvsubbu commented on a change in pull request #4553: Refactor ControllerLeaderLocator URL: https://github.com/apache/incubator-pinot/pull/4553#discussion_r324280388 ## File path: pinot-core/src/main/java/org/apache/pinot/server/realtime/ControllerLeaderLocator.java ##

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4553: Refactor ControllerLeaderLocator

2019-09-13 Thread GitBox
mcvsubbu commented on a change in pull request #4553: Refactor ControllerLeaderLocator URL: https://github.com/apache/incubator-pinot/pull/4553#discussion_r324271534 ## File path: pinot-core/src/main/java/org/apache/pinot/server/realtime/ControllerLeaderLocator.java ##

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4553: Refactor ControllerLeaderLocator

2019-09-13 Thread GitBox
mcvsubbu commented on a change in pull request #4553: Refactor ControllerLeaderLocator URL: https://github.com/apache/incubator-pinot/pull/4553#discussion_r324285734 ## File path: pinot-core/src/main/java/org/apache/pinot/server/realtime/ControllerLeaderLocator.java ##

[GitHub] [incubator-pinot] akshayrai commented on a change in pull request #4611: [TE] Remove the logic of reading stderr from phantomjs to avoid zombie processes

2019-09-13 Thread GitBox
akshayrai commented on a change in pull request #4611: [TE] Remove the logic of reading stderr from phantomjs to avoid zombie processes URL: https://github.com/apache/incubator-pinot/pull/4611#discussion_r324279730 ## File path:

[GitHub] [incubator-pinot] mcvsubbu commented on issue #4608: Unit tests and bug fixes for DeleteTable rest API for controller.

2019-09-13 Thread GitBox
mcvsubbu commented on issue #4608: Unit tests and bug fixes for DeleteTable rest API for controller. URL: https://github.com/apache/incubator-pinot/pull/4608#issuecomment-531289428 Is this somehow causing an issue in your environment? What is the motivation behind this change?

[GitHub] [incubator-pinot] chenboat commented on a change in pull request #4608: Unit tests and bug fixes for DeleteTable rest API for controller.

2019-09-13 Thread GitBox
chenboat commented on a change in pull request #4608: Unit tests and bug fixes for DeleteTable rest API for controller. URL: https://github.com/apache/incubator-pinot/pull/4608#discussion_r324223469 ## File path:

[GitHub] [incubator-pinot] chenboat commented on a change in pull request #4608: Unit tests and bug fixes for DeleteTable rest API for controller.

2019-09-13 Thread GitBox
chenboat commented on a change in pull request #4608: Unit tests and bug fixes for DeleteTable rest API for controller. URL: https://github.com/apache/incubator-pinot/pull/4608#discussion_r324223312 ## File path:

[GitHub] [incubator-pinot] fx19880617 edited a comment on issue #4597: [WIP] Adding json_path function to extract field from json object

2019-09-13 Thread GitBox
fx19880617 edited a comment on issue #4597: [WIP] Adding json_path function to extract field from json object URL: https://github.com/apache/incubator-pinot/pull/4597#issuecomment-531218134 Will add more documents, this could be used in selection/filtering/groupby, please refer to

[GitHub] [incubator-pinot] fx19880617 commented on issue #4597: [WIP] Adding json_path function to extract field from json object

2019-09-13 Thread GitBox
fx19880617 commented on issue #4597: [WIP] Adding json_path function to extract field from json object URL: https://github.com/apache/incubator-pinot/pull/4597#issuecomment-531218134 Will add more documents, this could be used in selection/filtering/groupby, please refer to integration

[incubator-pinot] branch jsonpath_function updated (21e2810 -> 382d5f6)

2019-09-13 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch jsonpath_function in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from 21e2810 Adding json_path function to extract field from json object add 382d5f6 Adding

[GitHub] [incubator-pinot] AnishKanth commented on issue #4603: Can not find a deserializer for non-concrete Map type

2019-09-13 Thread GitBox
AnishKanth commented on issue #4603: Can not find a deserializer for non-concrete Map type URL: https://github.com/apache/incubator-pinot/issues/4603#issuecomment-531136177 Facing the same issue with above mentioned docker

[GitHub] [incubator-pinot] codecov-io commented on issue #4612: Add column types info to the selection and aggregation query results.

2019-09-13 Thread GitBox
codecov-io commented on issue #4612: Add column types info to the selection and aggregation query results. URL: https://github.com/apache/incubator-pinot/pull/4612#issuecomment-531124397 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4612?src=pr=h1) Report > Merging

[GitHub] [incubator-pinot] chenboat opened a new pull request #4612: Add column types info to the selection and aggregation query results.

2019-09-13 Thread GitBox
chenboat opened a new pull request #4612: Add column types info to the selection and aggregation query results. URL: https://github.com/apache/incubator-pinot/pull/4612 Add column types to the selection and aggregation query results. The column type info for group by columns are not added