[GitHub] [incubator-pinot] fx19880617 opened a new pull request #4216: PQL -> SQL enhancement - phase 1 - new Pinot Query Struct

2019-05-17 Thread GitBox
fx19880617 opened a new pull request #4216: PQL -> SQL enhancement - phase 1 - new Pinot Query Struct URL: https://github.com/apache/incubator-pinot/pull/4216 According to https://github.com/winedepot/pinot/issues/14, this PR will make PinotQuery the entry point for query processing.

[GitHub] [incubator-pinot] codecov-io commented on issue #4216: PQL -> SQL enhancement - phase 1 - new Pinot Query Struct

2019-05-17 Thread GitBox
codecov-io commented on issue #4216: PQL -> SQL enhancement - phase 1 - new Pinot Query Struct URL: https://github.com/apache/incubator-pinot/pull/4216#issuecomment-493376612 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4216?src=pr=h1) Report > Merging

[GitHub] [incubator-pinot] kishoreg commented on issue #4216: PQL -> SQL enhancement - phase 1 - new Pinot Query Struct

2019-05-17 Thread GitBox
kishoreg commented on issue #4216: PQL -> SQL enhancement - phase 1 - new Pinot Query Struct URL: https://github.com/apache/incubator-pinot/pull/4216#issuecomment-493478353 We dint handle HAVING clause in the new code path. having is not used anywhere and implemented poorly and dint feel

[GitHub] [incubator-pinot] sunithabeeram commented on issue #4216: PQL -> SQL enhancement - phase 1 - new Pinot Query Struct

2019-05-17 Thread GitBox
sunithabeeram commented on issue #4216: PQL -> SQL enhancement - phase 1 - new Pinot Query Struct URL: https://github.com/apache/incubator-pinot/pull/4216#issuecomment-493449805 I see that existing tests pass, but are there any backwards compatibility implications with this change?

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4215: Minor fix for star-tree creation logs

2019-05-17 Thread GitBox
Jackie-Jiang commented on a change in pull request #4215: Minor fix for star-tree creation logs URL: https://github.com/apache/incubator-pinot/pull/4215#discussion_r285249381 ## File path:

[incubator-pinot] branch minor_fix_startree updated (b27799e -> faf4520)

2019-05-17 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch minor_fix_startree in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard b27799e Minor fix for star-tree creation logs add faf4520 Minor fix for star-tree

[incubator-pinot] 01/01: [TE] distribute detection and notification tasks

2019-05-17 Thread xhsun
This is an automated email from the ASF dual-hosted git repository. xhsun pushed a commit to branch distribute_tasks in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git commit 1ebdc7fbfc43bcd96a507d7a76166d61c480c3f6 Author: Xiaohui Sun AuthorDate: Fri May 17 12:19:19 2019

[GitHub] [incubator-pinot] xiaohui-sun commented on a change in pull request #4209: [TE] Model evaluator interface & Implementation

2019-05-17 Thread GitBox
xiaohui-sun commented on a change in pull request #4209: [TE] Model evaluator interface & Implementation URL: https://github.com/apache/incubator-pinot/pull/4209#discussion_r285258830 ## File path:

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4216: PQL -> SQL enhancement - phase 1 - new Pinot Query Struct

2019-05-17 Thread GitBox
Jackie-Jiang commented on a change in pull request #4216: PQL -> SQL enhancement - phase 1 - new Pinot Query Struct URL: https://github.com/apache/incubator-pinot/pull/4216#discussion_r285258179 ## File path: pinot-common/src/thrift/request.thrift ## @@ -152,6 +153,7 @@

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4216: PQL -> SQL enhancement - phase 1 - new Pinot Query Struct

2019-05-17 Thread GitBox
Jackie-Jiang commented on a change in pull request #4216: PQL -> SQL enhancement - phase 1 - new Pinot Query Struct URL: https://github.com/apache/incubator-pinot/pull/4216#discussion_r285257300 ## File path: pinot-common/src/thrift/query.thrift ## @@ -0,0 +1,76 @@ +/** +

[GitHub] [incubator-pinot] xiaohui-sun opened a new pull request #4217: [TE] distribute detection and notification tasks

2019-05-17 Thread GitBox
xiaohui-sun opened a new pull request #4217: [TE] distribute detection and notification tasks URL: https://github.com/apache/incubator-pinot/pull/4217 1. Set cron for detection and notification tasks to start at random seconds. 2. Have a random delay between 0 to 1000 milliseconds when

[GitHub] [incubator-pinot] kishoreg commented on a change in pull request #4216: PQL -> SQL enhancement - phase 1 - new Pinot Query Struct

2019-05-17 Thread GitBox
kishoreg commented on a change in pull request #4216: PQL -> SQL enhancement - phase 1 - new Pinot Query Struct URL: https://github.com/apache/incubator-pinot/pull/4216#discussion_r285267939 ## File path: pinot-common/src/thrift/request.thrift ## @@ -152,6 +153,7 @@

[GitHub] [incubator-pinot] codecov-io commented on issue #4218: Add RealtimeConsumptionCatchupServiceCallback

2019-05-17 Thread GitBox
codecov-io commented on issue #4218: Add RealtimeConsumptionCatchupServiceCallback URL: https://github.com/apache/incubator-pinot/pull/4218#issuecomment-493596443 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4218?src=pr=h1) Report > Merging

[incubator-pinot] branch distribute_tasks updated (81d72f1 -> ac588a1)

2019-05-17 Thread xhsun
This is an automated email from the ASF dual-hosted git repository. xhsun pushed a change to branch distribute_tasks in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from 81d72f1 [TE] fix integration test by adding cron explicitly add ac588a1 [TE] revert

[GitHub] [incubator-pinot] kishoreg opened a new issue #4219: Support SQL in Pinot.

2019-05-17 Thread GitBox
kishoreg opened a new issue #4219: Support SQL in Pinot. URL: https://github.com/apache/incubator-pinot/issues/4219 While existing PQL is almost similar to SQL, it has some nuances that make it difficult for users to query pinot. Our eventual goal should be able to support most of the

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4218: Add RealtimeConsumptionCatchupServiceCallback

2019-05-17 Thread GitBox
mcvsubbu commented on a change in pull request #4218: Add RealtimeConsumptionCatchupServiceCallback URL: https://github.com/apache/incubator-pinot/pull/4218#discussion_r285293190 ## File path: pinot-common/src/main/java/org/apache/pinot/common/utils/ServiceStatus.java ##

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4218: Add RealtimeConsumptionCatchupServiceCallback

2019-05-17 Thread GitBox
mcvsubbu commented on a change in pull request #4218: Add RealtimeConsumptionCatchupServiceCallback URL: https://github.com/apache/incubator-pinot/pull/4218#discussion_r285293613 ## File path: pinot-common/src/main/java/org/apache/pinot/common/utils/ServiceStatus.java ##

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4218: Add RealtimeConsumptionCatchupServiceCallback

2019-05-17 Thread GitBox
mcvsubbu commented on a change in pull request #4218: Add RealtimeConsumptionCatchupServiceCallback URL: https://github.com/apache/incubator-pinot/pull/4218#discussion_r285294519 ## File path: pinot-common/src/main/java/org/apache/pinot/common/utils/ServiceStatus.java ##

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4218: Add RealtimeConsumptionCatchupServiceCallback

2019-05-17 Thread GitBox
mcvsubbu commented on a change in pull request #4218: Add RealtimeConsumptionCatchupServiceCallback URL: https://github.com/apache/incubator-pinot/pull/4218#discussion_r285294221 ## File path: pinot-common/src/main/java/org/apache/pinot/common/utils/ServiceStatus.java ##

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4218: Add RealtimeConsumptionCatchupServiceCallback

2019-05-17 Thread GitBox
mcvsubbu commented on a change in pull request #4218: Add RealtimeConsumptionCatchupServiceCallback URL: https://github.com/apache/incubator-pinot/pull/4218#discussion_r285292544 ## File path: pinot-common/src/main/java/org/apache/pinot/common/utils/ServiceStatus.java ##

[GitHub] [incubator-pinot] kishoreg commented on a change in pull request #4216: PQL -> SQL enhancement - phase 1 - new Pinot Query Struct

2019-05-17 Thread GitBox
kishoreg commented on a change in pull request #4216: PQL -> SQL enhancement - phase 1 - new Pinot Query Struct URL: https://github.com/apache/incubator-pinot/pull/4216#discussion_r285296638 ## File path: pinot-common/src/thrift/request.thrift ## @@ -152,6 +153,7 @@

[GitHub] [incubator-pinot] kishoreg commented on a change in pull request #4216: PQL -> SQL enhancement - phase 1 - new Pinot Query Struct

2019-05-17 Thread GitBox
kishoreg commented on a change in pull request #4216: PQL -> SQL enhancement - phase 1 - new Pinot Query Struct URL: https://github.com/apache/incubator-pinot/pull/4216#discussion_r285265637 ## File path: pinot-common/src/thrift/query.thrift ## @@ -0,0 +1,76 @@ +/** + *

[GitHub] [incubator-pinot] jihaozh merged pull request #4209: [TE] Model evaluator interface & Implementation

2019-05-17 Thread GitBox
jihaozh merged pull request #4209: [TE] Model evaluator interface & Implementation URL: https://github.com/apache/incubator-pinot/pull/4209 This is an automated message from the Apache Git Service. To respond to the

[incubator-pinot] branch master updated: [TE] Model evaluator interface & Implementation (#4209)

2019-05-17 Thread jihao
This is an automated email from the ASF dual-hosted git repository. jihao pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new f50e87f [TE] Model evaluator interface

[GitHub] [incubator-pinot] akshayrai commented on a change in pull request #4217: [TE] distribute detection and notification tasks

2019-05-17 Thread GitBox
akshayrai commented on a change in pull request #4217: [TE] distribute detection and notification tasks URL: https://github.com/apache/incubator-pinot/pull/4217#discussion_r285290205 ## File path:

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4218: Add RealtimeConsumptionCatchupServiceCallback

2019-05-17 Thread GitBox
Jackie-Jiang commented on a change in pull request #4218: Add RealtimeConsumptionCatchupServiceCallback URL: https://github.com/apache/incubator-pinot/pull/4218#discussion_r285293378 ## File path: pinot-common/src/main/java/org/apache/pinot/common/utils/ServiceStatus.java

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4218: Add RealtimeConsumptionCatchupServiceCallback

2019-05-17 Thread GitBox
Jackie-Jiang commented on a change in pull request #4218: Add RealtimeConsumptionCatchupServiceCallback URL: https://github.com/apache/incubator-pinot/pull/4218#discussion_r285292297 ## File path: pinot-common/src/main/java/org/apache/pinot/common/utils/ServiceStatus.java

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4218: Add RealtimeConsumptionCatchupServiceCallback

2019-05-17 Thread GitBox
Jackie-Jiang commented on a change in pull request #4218: Add RealtimeConsumptionCatchupServiceCallback URL: https://github.com/apache/incubator-pinot/pull/4218#discussion_r285292815 ## File path: pinot-common/src/main/java/org/apache/pinot/common/utils/ServiceStatus.java

[GitHub] [incubator-pinot] snleee opened a new pull request #4220: Adding a simple partition function

2019-05-17 Thread GitBox
snleee opened a new pull request #4220: Adding a simple partition function URL: https://github.com/apache/incubator-pinot/pull/4220 - Adding a simple partition function using object.hashCode() - Adding a unit test for simple partition function

[GitHub] [incubator-pinot] npawar opened a new pull request #4218: Add RealtimeConsumptionCatchupServiceCallback

2019-05-17 Thread GitBox
npawar opened a new pull request #4218: Add RealtimeConsumptionCatchupServiceCallback URL: https://github.com/apache/incubator-pinot/pull/4218 Creating a ServiceCallback within ServiceStatus, to check that realtime consuming segments have caught up. This will help with latency issues

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4216: PQL -> SQL enhancement - phase 1 - new Pinot Query Struct

2019-05-17 Thread GitBox
Jackie-Jiang commented on a change in pull request #4216: PQL -> SQL enhancement - phase 1 - new Pinot Query Struct URL: https://github.com/apache/incubator-pinot/pull/4216#discussion_r285286058 ## File path: pinot-common/src/thrift/query.thrift ## @@ -0,0 +1,76 @@ +/** +

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4216: PQL -> SQL enhancement - phase 1 - new Pinot Query Struct

2019-05-17 Thread GitBox
Jackie-Jiang commented on a change in pull request #4216: PQL -> SQL enhancement - phase 1 - new Pinot Query Struct URL: https://github.com/apache/incubator-pinot/pull/4216#discussion_r285287420 ## File path: pinot-common/src/thrift/request.thrift ## @@ -152,6 +153,7 @@

[incubator-pinot] branch distribute_tasks updated (1ebdc7f -> 81d72f1)

2019-05-17 Thread xhsun
This is an automated email from the ASF dual-hosted git repository. xhsun pushed a change to branch distribute_tasks in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from 1ebdc7f [TE] distribute detection and notification tasks add 81d72f1 [TE] fix integration

[GitHub] [incubator-pinot] akshayrai commented on a change in pull request #4217: [TE] distribute detection and notification tasks

2019-05-17 Thread GitBox
akshayrai commented on a change in pull request #4217: [TE] distribute detection and notification tasks URL: https://github.com/apache/incubator-pinot/pull/4217#discussion_r285286018 ## File path:

[GitHub] [incubator-pinot] akshayrai commented on a change in pull request #4217: [TE] distribute detection and notification tasks

2019-05-17 Thread GitBox
akshayrai commented on a change in pull request #4217: [TE] distribute detection and notification tasks URL: https://github.com/apache/incubator-pinot/pull/4217#discussion_r285292766 ## File path:

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4218: Add RealtimeConsumptionCatchupServiceCallback

2019-05-17 Thread GitBox
Jackie-Jiang commented on a change in pull request #4218: Add RealtimeConsumptionCatchupServiceCallback URL: https://github.com/apache/incubator-pinot/pull/4218#discussion_r285288043 ## File path: pinot-common/src/main/java/org/apache/pinot/common/config/TableNameBuilder.java

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4218: Add RealtimeConsumptionCatchupServiceCallback

2019-05-17 Thread GitBox
Jackie-Jiang commented on a change in pull request #4218: Add RealtimeConsumptionCatchupServiceCallback URL: https://github.com/apache/incubator-pinot/pull/4218#discussion_r285292421 ## File path: pinot-common/src/main/java/org/apache/pinot/common/utils/ServiceStatus.java

[incubator-pinot] branch master updated: Minor fix for star-tree creation logs (#4215)

2019-05-17 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new aed4b56 Minor fix for star-tree

[incubator-pinot] branch minor_fix_startree deleted (was faf4520)

2019-05-17 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch minor_fix_startree in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. was faf4520 Minor fix for star-tree creation logs The revisions that were on this branch are

[GitHub] [incubator-pinot] Jackie-Jiang merged pull request #4215: Minor fix for star-tree creation logs

2019-05-17 Thread GitBox
Jackie-Jiang merged pull request #4215: Minor fix for star-tree creation logs URL: https://github.com/apache/incubator-pinot/pull/4215 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4216: PQL -> SQL enhancement - phase 1 - new Pinot Query Struct

2019-05-17 Thread GitBox
Jackie-Jiang commented on a change in pull request #4216: PQL -> SQL enhancement - phase 1 - new Pinot Query Struct URL: https://github.com/apache/incubator-pinot/pull/4216#discussion_r285299278 ## File path: pinot-common/src/thrift/request.thrift ## @@ -152,6 +153,7 @@

[GitHub] [incubator-pinot] xiaohui-sun commented on a change in pull request #4217: [TE] distribute detection and notification tasks

2019-05-17 Thread GitBox
xiaohui-sun commented on a change in pull request #4217: [TE] distribute detection and notification tasks URL: https://github.com/apache/incubator-pinot/pull/4217#discussion_r285311895 ## File path:

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4220: Adding a simple partition function

2019-05-17 Thread GitBox
Jackie-Jiang commented on a change in pull request #4220: Adding a simple partition function URL: https://github.com/apache/incubator-pinot/pull/4220#discussion_r285318326 ## File path: pinot-core/src/test/java/org/apache/pinot/core/data/partition/PartitionFunctionTest.java

[GitHub] [incubator-pinot] sunny209868 commented on issue #4219: Support SQL in Pinot.

2019-05-17 Thread GitBox
sunny209868 commented on issue #4219: Support SQL in Pinot. URL: https://github.com/apache/incubator-pinot/issues/4219#issuecomment-493643346 > Suggest changing Enhanced Broker Request to Pinot Query to make them totally separate from each other. No need to nest them IMO. > > For

[GitHub] [incubator-pinot] sunny209868 closed pull request #4205: use conf start pinot

2019-05-17 Thread GitBox
sunny209868 closed pull request #4205: use conf start pinot URL: https://github.com/apache/incubator-pinot/pull/4205 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-pinot] sunny209868 closed issue #4199: Support for SQL plans

2019-05-17 Thread GitBox
sunny209868 closed issue #4199: Support for SQL plans URL: https://github.com/apache/incubator-pinot/issues/4199 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [incubator-pinot] xiaohui-sun commented on a change in pull request #4217: [TE] distribute detection and notification tasks

2019-05-17 Thread GitBox
xiaohui-sun commented on a change in pull request #4217: [TE] distribute detection and notification tasks URL: https://github.com/apache/incubator-pinot/pull/4217#discussion_r285311603 ## File path:

[incubator-pinot] branch distribute_tasks updated (ac588a1 -> a277260)

2019-05-17 Thread xhsun
This is an automated email from the ASF dual-hosted git repository. xhsun pushed a change to branch distribute_tasks in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from ac588a1 [TE] revert removing notification flag add a277260 [TE] randomization when creating

[incubator-pinot] branch distribute_tasks updated (a277260 -> a4aca9e)

2019-05-17 Thread xhsun
This is an automated email from the ASF dual-hosted git repository. xhsun pushed a change to branch distribute_tasks in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from a277260 [TE] randomization when creating the task add a4aca9e [TE] randomization when

[GitHub] [incubator-pinot] Jackie-Jiang commented on issue #4219: Support SQL in Pinot.

2019-05-17 Thread GitBox
Jackie-Jiang commented on issue #4219: Support SQL in Pinot. URL: https://github.com/apache/incubator-pinot/issues/4219#issuecomment-493618571 Suggest changing Enhanced Broker Request to Pinot Query to make them totally separate from each other. No need to nest them IMO. For steps

[GitHub] [incubator-pinot] codecov-io commented on issue #4220: Adding a simple partition function

2019-05-17 Thread GitBox
codecov-io commented on issue #4220: Adding a simple partition function URL: https://github.com/apache/incubator-pinot/pull/4220#issuecomment-493623478 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4220?src=pr=h1) Report > Merging

[GitHub] [incubator-pinot] xiaohui-sun commented on a change in pull request #4217: [TE] distribute detection and notification tasks

2019-05-17 Thread GitBox
xiaohui-sun commented on a change in pull request #4217: [TE] distribute detection and notification tasks URL: https://github.com/apache/incubator-pinot/pull/4217#discussion_r285312156 ## File path:

[GitHub] [incubator-pinot] akshayrai opened a new pull request #4221: Code cleanup - Pull out all validation checks from translator into validator modules

2019-05-17 Thread GitBox
akshayrai opened a new pull request #4221: Code cleanup - Pull out all validation checks from translator into validator modules URL: https://github.com/apache/incubator-pinot/pull/4221 Changes: * We will support two kinds of validation - raw yaml config validation & translated

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4220: Adding a simple partition function

2019-05-17 Thread GitBox
Jackie-Jiang commented on a change in pull request #4220: Adding a simple partition function URL: https://github.com/apache/incubator-pinot/pull/4220#discussion_r285316029 ## File path: pinot-core/src/main/java/org/apache/pinot/core/data/partition/PartitionFunctionFactory.java

[GitHub] [incubator-pinot] snleee commented on a change in pull request #4220: Adding a simple partition function

2019-05-17 Thread GitBox
snleee commented on a change in pull request #4220: Adding a simple partition function URL: https://github.com/apache/incubator-pinot/pull/4220#discussion_r285316962 ## File path: pinot-core/src/main/java/org/apache/pinot/core/data/partition/PartitionFunctionFactory.java

[GitHub] [incubator-pinot] codecov-io edited a comment on issue #4220: Adding a simple partition function

2019-05-17 Thread GitBox
codecov-io edited a comment on issue #4220: Adding a simple partition function URL: https://github.com/apache/incubator-pinot/pull/4220#issuecomment-493623478 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4220?src=pr=h1) Report > Merging

[GitHub] [incubator-pinot] sunny209868 edited a comment on issue #4219: Support SQL in Pinot.

2019-05-17 Thread GitBox
sunny209868 edited a comment on issue #4219: Support SQL in Pinot. URL: https://github.com/apache/incubator-pinot/issues/4219#issuecomment-493643346 @sunny209868 sorry, I removed the quoted reply That's great @Jackie-Jiang

[GitHub] [incubator-pinot] kishoreg edited a comment on issue #4219: Support SQL in Pinot.

2019-05-17 Thread GitBox
kishoreg edited a comment on issue #4219: Support SQL in Pinot. URL: https://github.com/apache/incubator-pinot/issues/4219#issuecomment-493645566 @Jackie-Jiang yes, I would love to do this and this was how I started. The problem was that brokerrequest was very widely used in the code and

[GitHub] [incubator-pinot] kishoreg commented on issue #4219: Support SQL in Pinot.

2019-05-17 Thread GitBox
kishoreg commented on issue #4219: Support SQL in Pinot. URL: https://github.com/apache/incubator-pinot/issues/4219#issuecomment-493645566 @Jackie-Jiang yes, I would love to do this and this was how I started. The problem was that brokerrequest was very widely used in the code and it was