[GitHub] [incubator-pinot] ShubhamMMT1 opened a new issue #4425: Anomalies tab shows anomalies for only mock data source

2019-07-11 Thread GitBox
ShubhamMMT1 opened a new issue #4425: Anomalies tab shows anomalies for only mock data source URL: https://github.com/apache/incubator-pinot/issues/4425 1. Ingested data into pinot. Had set up alerts for different metrics. The anomalies appear for different metrics in the home's tab as

[GitHub] [incubator-pinot] codecov-io edited a comment on issue #4323: [Controller Separation] Add logic for lead controller resource

2019-07-11 Thread GitBox
codecov-io edited a comment on issue #4323: [Controller Separation] Add logic for lead controller resource URL: https://github.com/apache/incubator-pinot/pull/4323#issuecomment-502327426 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4323?src=pr=h1) Report > Merging

[GitHub] [incubator-pinot] npawar commented on a change in pull request #4397: Adding Support for Kafka 2.0 Consumer

2019-07-11 Thread GitBox
npawar commented on a change in pull request #4397: Adding Support for Kafka 2.0 Consumer URL: https://github.com/apache/incubator-pinot/pull/4397#discussion_r302680915 ## File path:

[GitHub] [incubator-pinot] npawar commented on a change in pull request #4397: Adding Support for Kafka 2.0 Consumer

2019-07-11 Thread GitBox
npawar commented on a change in pull request #4397: Adding Support for Kafka 2.0 Consumer URL: https://github.com/apache/incubator-pinot/pull/4397#discussion_r302675363 ## File path: pinot-connectors/pinot-connector-kafka-2.0/pom.xml ## @@ -0,0 +1,103 @@ + +

[GitHub] [incubator-pinot] npawar commented on a change in pull request #4397: Adding Support for Kafka 2.0 Consumer

2019-07-11 Thread GitBox
npawar commented on a change in pull request #4397: Adding Support for Kafka 2.0 Consumer URL: https://github.com/apache/incubator-pinot/pull/4397#discussion_r302713189 ## File path:

[GitHub] [incubator-pinot] npawar commented on a change in pull request #4397: Adding Support for Kafka 2.0 Consumer

2019-07-11 Thread GitBox
npawar commented on a change in pull request #4397: Adding Support for Kafka 2.0 Consumer URL: https://github.com/apache/incubator-pinot/pull/4397#discussion_r302688764 ## File path:

[GitHub] [incubator-pinot] npawar commented on a change in pull request #4397: Adding Support for Kafka 2.0 Consumer

2019-07-11 Thread GitBox
npawar commented on a change in pull request #4397: Adding Support for Kafka 2.0 Consumer URL: https://github.com/apache/incubator-pinot/pull/4397#discussion_r302680527 ## File path:

[GitHub] [incubator-pinot] npawar commented on a change in pull request #4397: Adding Support for Kafka 2.0 Consumer

2019-07-11 Thread GitBox
npawar commented on a change in pull request #4397: Adding Support for Kafka 2.0 Consumer URL: https://github.com/apache/incubator-pinot/pull/4397#discussion_r302678609 ## File path:

[GitHub] [incubator-pinot] npawar commented on a change in pull request #4397: Adding Support for Kafka 2.0 Consumer

2019-07-11 Thread GitBox
npawar commented on a change in pull request #4397: Adding Support for Kafka 2.0 Consumer URL: https://github.com/apache/incubator-pinot/pull/4397#discussion_r302682512 ## File path:

[GitHub] [incubator-pinot] npawar commented on a change in pull request #4397: Adding Support for Kafka 2.0 Consumer

2019-07-11 Thread GitBox
npawar commented on a change in pull request #4397: Adding Support for Kafka 2.0 Consumer URL: https://github.com/apache/incubator-pinot/pull/4397#discussion_r302674935 ## File path: pinot-connectors/pinot-connector-kafka-2.0/README.md ## @@ -0,0 +1,24 @@ + +# Pinot

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #4418: Fix potential resource leak in the way we close a collection of closeables

2019-07-11 Thread GitBox
siddharthteotia commented on a change in pull request #4418: Fix potential resource leak in the way we close a collection of closeables URL: https://github.com/apache/incubator-pinot/pull/4418#discussion_r302714401 ## File path:

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #4418: Fix potential resource leak in the way we close a collection of closeables

2019-07-11 Thread GitBox
siddharthteotia commented on a change in pull request #4418: Fix potential resource leak in the way we close a collection of closeables URL: https://github.com/apache/incubator-pinot/pull/4418#discussion_r302736254 ## File path:

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #4418: Fix potential resource leak in the way we close a collection of closeables

2019-07-11 Thread GitBox
siddharthteotia commented on a change in pull request #4418: Fix potential resource leak in the way we close a collection of closeables URL: https://github.com/apache/incubator-pinot/pull/4418#discussion_r302736284 ## File path:

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #4418: Fix potential resource leak in the way we close a collection of closeables

2019-07-11 Thread GitBox
siddharthteotia commented on a change in pull request #4418: Fix potential resource leak in the way we close a collection of closeables URL: https://github.com/apache/incubator-pinot/pull/4418#discussion_r302736411 ## File path:

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #4418: Fix potential resource leak in the way we close a collection of closeables

2019-07-11 Thread GitBox
siddharthteotia commented on a change in pull request #4418: Fix potential resource leak in the way we close a collection of closeables URL: https://github.com/apache/incubator-pinot/pull/4418#discussion_r302736329 ## File path:

[GitHub] [incubator-pinot] siddharthteotia commented on issue #4418: Fix potential resource leak in the way we close a collection of closeables

2019-07-11 Thread GitBox
siddharthteotia commented on issue #4418: Fix potential resource leak in the way we close a collection of closeables URL: https://github.com/apache/incubator-pinot/pull/4418#issuecomment-510649382 Based on the above conversations, I have addressed the review comments in latest commit.

[GitHub] [incubator-pinot] codecov-io edited a comment on issue #4418: Fix potential resource leak in the way we close a collection of closeables

2019-07-11 Thread GitBox
codecov-io edited a comment on issue #4418: Fix potential resource leak in the way we close a collection of closeables URL: https://github.com/apache/incubator-pinot/pull/4418#issuecomment-510276514 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4418?src=pr=h1) Report >

[GitHub] [incubator-pinot] kishoreg commented on issue #48: Grouping data by time interval

2019-07-11 Thread GitBox
kishoreg commented on issue #48: Grouping data by time interval URL: https://github.com/apache/incubator-pinot/issues/48#issuecomment-510345632 @provenvelocity The udf's needed are supported in Pinot but I don't think the plugin for Grafana was contributed.

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #4418: Fix potential resource leak in the way we close a collection of closeables

2019-07-11 Thread GitBox
siddharthteotia commented on a change in pull request #4418: Fix potential resource leak in the way we close a collection of closeables URL: https://github.com/apache/incubator-pinot/pull/4418#discussion_r302378497 ## File path:

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #4418: Fix potential resource leak in the way we close a collection of closeables

2019-07-11 Thread GitBox
siddharthteotia commented on a change in pull request #4418: Fix potential resource leak in the way we close a collection of closeables URL: https://github.com/apache/incubator-pinot/pull/4418#discussion_r302378461 ## File path:

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #4418: Fix potential resource leak in the way we close a collection of closeables

2019-07-11 Thread GitBox
siddharthteotia commented on a change in pull request #4418: Fix potential resource leak in the way we close a collection of closeables URL: https://github.com/apache/incubator-pinot/pull/4418#discussion_r302378439 ## File path:

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #4418: Fix potential resource leak in the way we close a collection of closeables

2019-07-11 Thread GitBox
siddharthteotia commented on a change in pull request #4418: Fix potential resource leak in the way we close a collection of closeables URL: https://github.com/apache/incubator-pinot/pull/4418#discussion_r302378399 ## File path:

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #4418: Fix potential resource leak in the way we close a collection of closeables

2019-07-11 Thread GitBox
siddharthteotia commented on a change in pull request #4418: Fix potential resource leak in the way we close a collection of closeables URL: https://github.com/apache/incubator-pinot/pull/4418#discussion_r302378411 ## File path:

[GitHub] [incubator-pinot] akshayrai merged pull request #4420: [TE] Inject the port from config into Commons mail SSL Smtp port

2019-07-11 Thread GitBox
akshayrai merged pull request #4420: [TE] Inject the port from config into Commons mail SSL Smtp port URL: https://github.com/apache/incubator-pinot/pull/4420 This is an automated message from the Apache Git Service. To

[incubator-pinot] branch master updated: [TE] Inject the port from config into Commons mail SSL Smtp port (#4420)

2019-07-11 Thread akshayrai09
This is an automated email from the ASF dual-hosted git repository. akshayrai09 pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new 6bec451 [TE] Inject the port

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4418: Fix potential resource leak in the way we close a collection of closeables

2019-07-11 Thread GitBox
mcvsubbu commented on a change in pull request #4418: Fix potential resource leak in the way we close a collection of closeables URL: https://github.com/apache/incubator-pinot/pull/4418#discussion_r302629209 ## File path:

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4418: Fix potential resource leak in the way we close a collection of closeables

2019-07-11 Thread GitBox
mcvsubbu commented on a change in pull request #4418: Fix potential resource leak in the way we close a collection of closeables URL: https://github.com/apache/incubator-pinot/pull/4418#discussion_r302626793 ## File path:

[GitHub] [incubator-pinot] buchireddy closed issue #4317: Support variable length Offline Dictionary Indexes for bytes, strings and maps to save on storage

2019-07-11 Thread GitBox
buchireddy closed issue #4317: Support variable length Offline Dictionary Indexes for bytes, strings and maps to save on storage URL: https://github.com/apache/incubator-pinot/issues/4317 This is an automated message from

[GitHub] [incubator-pinot] jackjlli merged pull request #4395: Prompt when get table schema failed on query-console

2019-07-11 Thread GitBox
jackjlli merged pull request #4395: Prompt when get table schema failed on query-console URL: https://github.com/apache/incubator-pinot/pull/4395 This is an automated message from the Apache Git Service. To respond to the

[incubator-pinot] branch master updated: prompt on fail schema (#4395)

2019-07-11 Thread jlli
This is an automated email from the ASF dual-hosted git repository. jlli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new dac9ae2 prompt on fail schema (#4395)

[GitHub] [incubator-pinot] jihaozh commented on a change in pull request #4419: [TE] Fix exception handling - Propagate and display the error message/exception on frontend

2019-07-11 Thread GitBox
jihaozh commented on a change in pull request #4419: [TE] Fix exception handling - Propagate and display the error message/exception on frontend URL: https://github.com/apache/incubator-pinot/pull/4419#discussion_r302654765 ## File path:

[GitHub] [incubator-pinot] jihaozh commented on a change in pull request #4419: [TE] Fix exception handling - Propagate and display the error message/exception on frontend

2019-07-11 Thread GitBox
jihaozh commented on a change in pull request #4419: [TE] Fix exception handling - Propagate and display the error message/exception on frontend URL: https://github.com/apache/incubator-pinot/pull/4419#discussion_r302654507 ## File path:

[GitHub] [incubator-pinot] npawar merged pull request #4396: make kafka version number controlled by config number

2019-07-11 Thread GitBox
npawar merged pull request #4396: make kafka version number controlled by config number URL: https://github.com/apache/incubator-pinot/pull/4396 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-pinot] jihaozh opened a new pull request #4423: [TE] add ml auto config into YAML template

2019-07-11 Thread GitBox
jihaozh opened a new pull request #4423: [TE] add ml auto config into YAML template URL: https://github.com/apache/incubator-pinot/pull/4423 Add the ml auto-config into the default YAML template. This is an automated

[incubator-pinot] branch master updated: make kafka version number controlled by config number (#4396)

2019-07-11 Thread nehapawar
This is an automated email from the ASF dual-hosted git repository. nehapawar pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new bca6756 make kafka version number

[GitHub] [incubator-pinot] akshayrai commented on a change in pull request #4419: [TE] Fix exception handling - Propagate and display the error message/exception on frontend

2019-07-11 Thread GitBox
akshayrai commented on a change in pull request #4419: [TE] Fix exception handling - Propagate and display the error message/exception on frontend URL: https://github.com/apache/incubator-pinot/pull/4419#discussion_r302670565 ## File path:

[GitHub] [incubator-pinot] jackjlli commented on a change in pull request #4368: 3891: Check for validity of segment start/end time during segment generation

2019-07-11 Thread GitBox
jackjlli commented on a change in pull request #4368: 3891: Check for validity of segment start/end time during segment generation URL: https://github.com/apache/incubator-pinot/pull/4368#discussion_r302671179 ## File path:

[GitHub] [incubator-pinot] jackjlli commented on a change in pull request #4368: 3891: Check for validity of segment start/end time during segment generation

2019-07-11 Thread GitBox
jackjlli commented on a change in pull request #4368: 3891: Check for validity of segment start/end time during segment generation URL: https://github.com/apache/incubator-pinot/pull/4368#discussion_r302673886 ## File path:

[incubator-pinot] branch master updated: [TE] Fix exception handling - Propagate and display the error message/exception on frontind (#4419)

2019-07-11 Thread akshayrai09
This is an automated email from the ASF dual-hosted git repository. akshayrai09 pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new 0993974 [TE] Fix exception

[GitHub] [incubator-pinot] jihaozh commented on a change in pull request #4419: [TE] Fix exception handling - Propagate and display the error message/exception on frontend

2019-07-11 Thread GitBox
jihaozh commented on a change in pull request #4419: [TE] Fix exception handling - Propagate and display the error message/exception on frontend URL: https://github.com/apache/incubator-pinot/pull/4419#discussion_r302676262 ## File path:

[GitHub] [incubator-pinot] akshayrai merged pull request #4419: [TE] Fix exception handling - Propagate and display the error message/exception on frontend

2019-07-11 Thread GitBox
akshayrai merged pull request #4419: [TE] Fix exception handling - Propagate and display the error message/exception on frontend URL: https://github.com/apache/incubator-pinot/pull/4419 This is an automated message from the

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #4418: Fix potential resource leak in the way we close a collection of closeables

2019-07-11 Thread GitBox
siddharthteotia commented on a change in pull request #4418: Fix potential resource leak in the way we close a collection of closeables URL: https://github.com/apache/incubator-pinot/pull/4418#discussion_r302683406 ## File path:

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4418: Fix potential resource leak in the way we close a collection of closeables

2019-07-11 Thread GitBox
Jackie-Jiang commented on a change in pull request #4418: Fix potential resource leak in the way we close a collection of closeables URL: https://github.com/apache/incubator-pinot/pull/4418#discussion_r302684337 ## File path:

[GitHub] [incubator-pinot] cyy0714 commented on a change in pull request #4423: [TE] add ml auto config into YAML template

2019-07-11 Thread GitBox
cyy0714 commented on a change in pull request #4423: [TE] add ml auto config into YAML template URL: https://github.com/apache/incubator-pinot/pull/4423#discussion_r302684105 ## File path: thirdeye/thirdeye-frontend/app/utils/constants.js ## @@ -27,6 +27,7 @@ rules:

[GitHub] [incubator-pinot] ananthdurai opened a new pull request #4424: Add pinot community inviter

2019-07-11 Thread GitBox
ananthdurai opened a new pull request #4424: Add pinot community inviter URL: https://github.com/apache/incubator-pinot/pull/4424 The current process to onboard new users into the Pinot & ThirdEye Slack community requires a manual invite. Community inviter is a free service that can

[GitHub] [incubator-pinot] jihaozh commented on a change in pull request #4419: [TE] Fix exception handling - Propagate and display the error message/exception on frontend

2019-07-11 Thread GitBox
jihaozh commented on a change in pull request #4419: [TE] Fix exception handling - Propagate and display the error message/exception on frontend URL: https://github.com/apache/incubator-pinot/pull/4419#discussion_r302677026 ## File path:

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4397: Adding Support for Kafka 2.0 Consumer

2019-07-11 Thread GitBox
mcvsubbu commented on a change in pull request #4397: Adding Support for Kafka 2.0 Consumer URL: https://github.com/apache/incubator-pinot/pull/4397#discussion_r302679686 ## File path:

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4397: Adding Support for Kafka 2.0 Consumer

2019-07-11 Thread GitBox
mcvsubbu commented on a change in pull request #4397: Adding Support for Kafka 2.0 Consumer URL: https://github.com/apache/incubator-pinot/pull/4397#discussion_r302644058 ## File path:

[GitHub] [incubator-pinot] xiaohui-sun commented on a change in pull request #4421: [TE] detection health UI adjustments

2019-07-11 Thread GitBox
xiaohui-sun commented on a change in pull request #4421: [TE] detection health UI adjustments URL: https://github.com/apache/incubator-pinot/pull/4421#discussion_r302681153 ## File path: thirdeye/thirdeye-frontend/app/pods/components/detection-health/template.hbs ## @@

[GitHub] [incubator-pinot] xiaohui-sun commented on a change in pull request #4421: [TE] detection health UI adjustments

2019-07-11 Thread GitBox
xiaohui-sun commented on a change in pull request #4421: [TE] detection health UI adjustments URL: https://github.com/apache/incubator-pinot/pull/4421#discussion_r302681493 ## File path: thirdeye/thirdeye-frontend/app/pods/components/detection-health/template.hbs ## @@

[GitHub] [incubator-pinot] akshayrai commented on a change in pull request #4423: [TE] add ml auto config into YAML template

2019-07-11 Thread GitBox
akshayrai commented on a change in pull request #4423: [TE] add ml auto config into YAML template URL: https://github.com/apache/incubator-pinot/pull/4423#discussion_r302682042 ## File path: thirdeye/thirdeye-frontend/app/utils/constants.js ## @@ -27,6 +27,7 @@ rules:

[GitHub] [incubator-pinot] xiaohui-sun commented on a change in pull request #4421: [TE] detection health UI adjustments

2019-07-11 Thread GitBox
xiaohui-sun commented on a change in pull request #4421: [TE] detection health UI adjustments URL: https://github.com/apache/incubator-pinot/pull/4421#discussion_r302682047 ## File path: thirdeye/thirdeye-frontend/app/pods/components/detection-health/template.hbs ## @@

[incubator-pinot] branch add-logic-for-lead-controller-resource updated (480f49d -> f7132cd)

2019-07-11 Thread jlli
This is an automated email from the ASF dual-hosted git repository. jlli pushed a change to branch add-logic-for-lead-controller-resource in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. omit 480f49d Address PR comments add f7132cd Address PR comments This

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4418: Fix potential resource leak in the way we close a collection of closeables

2019-07-11 Thread GitBox
Jackie-Jiang commented on a change in pull request #4418: Fix potential resource leak in the way we close a collection of closeables URL: https://github.com/apache/incubator-pinot/pull/4418#discussion_r302682935 ## File path:

[GitHub] [incubator-pinot] akshayrai commented on a change in pull request #4423: [TE] add ml auto config into YAML template

2019-07-11 Thread GitBox
akshayrai commented on a change in pull request #4423: [TE] add ml auto config into YAML template URL: https://github.com/apache/incubator-pinot/pull/4423#discussion_r302682042 ## File path: thirdeye/thirdeye-frontend/app/utils/constants.js ## @@ -27,6 +27,7 @@ rules:

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #4418: Fix potential resource leak in the way we close a collection of closeables

2019-07-11 Thread GitBox
siddharthteotia commented on a change in pull request #4418: Fix potential resource leak in the way we close a collection of closeables URL: https://github.com/apache/incubator-pinot/pull/4418#discussion_r302684714 ## File path:

[GitHub] [incubator-pinot] jihaozh commented on a change in pull request #4423: [TE] add ml auto config into YAML template

2019-07-11 Thread GitBox
jihaozh commented on a change in pull request #4423: [TE] add ml auto config into YAML template URL: https://github.com/apache/incubator-pinot/pull/4423#discussion_r302684568 ## File path: thirdeye/thirdeye-frontend/app/utils/constants.js ## @@ -27,6 +27,7 @@ rules:

[GitHub] [incubator-pinot] jihaozh merged pull request #4421: [TE] detection health UI adjustments

2019-07-11 Thread GitBox
jihaozh merged pull request #4421: [TE] detection health UI adjustments URL: https://github.com/apache/incubator-pinot/pull/4421 This is an automated message from the Apache Git Service. To respond to the message, please log

[incubator-pinot] branch master updated: [TE] detection health ui adjustments (#4421)

2019-07-11 Thread jihao
This is an automated email from the ASF dual-hosted git repository. jihao pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new b6fe4e6 [TE] detection health ui

[GitHub] [incubator-pinot] akshayrai commented on a change in pull request #4419: [TE] Fix exception handling - Propagate and display the error message/exception on frontend

2019-07-11 Thread GitBox
akshayrai commented on a change in pull request #4419: [TE] Fix exception handling - Propagate and display the error message/exception on frontend URL: https://github.com/apache/incubator-pinot/pull/4419#discussion_r302672546 ## File path:

[GitHub] [incubator-pinot] jackjlli commented on a change in pull request #4368: 3891: Check for validity of segment start/end time during segment generation

2019-07-11 Thread GitBox
jackjlli commented on a change in pull request #4368: 3891: Check for validity of segment start/end time during segment generation URL: https://github.com/apache/incubator-pinot/pull/4368#discussion_r302671587 ## File path:

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4397: Adding Support for Kafka 2.0 Consumer

2019-07-11 Thread GitBox
mcvsubbu commented on a change in pull request #4397: Adding Support for Kafka 2.0 Consumer URL: https://github.com/apache/incubator-pinot/pull/4397#discussion_r302638730 ## File path:

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4397: Adding Support for Kafka 2.0 Consumer

2019-07-11 Thread GitBox
mcvsubbu commented on a change in pull request #4397: Adding Support for Kafka 2.0 Consumer URL: https://github.com/apache/incubator-pinot/pull/4397#discussion_r302673645 ## File path:

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4397: Adding Support for Kafka 2.0 Consumer

2019-07-11 Thread GitBox
mcvsubbu commented on a change in pull request #4397: Adding Support for Kafka 2.0 Consumer URL: https://github.com/apache/incubator-pinot/pull/4397#discussion_r302645727 ## File path:

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #4418: Fix potential resource leak in the way we close a collection of closeables

2019-07-11 Thread GitBox
siddharthteotia commented on a change in pull request #4418: Fix potential resource leak in the way we close a collection of closeables URL: https://github.com/apache/incubator-pinot/pull/4418#discussion_r302683406 ## File path:

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4418: Fix potential resource leak in the way we close a collection of closeables

2019-07-11 Thread GitBox
Jackie-Jiang commented on a change in pull request #4418: Fix potential resource leak in the way we close a collection of closeables URL: https://github.com/apache/incubator-pinot/pull/4418#discussion_r302685987 ## File path:

[GitHub] [incubator-pinot] Jackie-Jiang merged pull request #4422: In ClusterChangeMediator, stop enqueue/process changes if already stopped

2019-07-11 Thread GitBox
Jackie-Jiang merged pull request #4422: In ClusterChangeMediator, stop enqueue/process changes if already stopped URL: https://github.com/apache/incubator-pinot/pull/4422 This is an automated message from the Apache Git

[incubator-pinot] branch cluster_change_mediator deleted (was b47866e)

2019-07-11 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch cluster_change_mediator in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. was b47866e In ClusterChangeMediator, stop enqueue/process changes if already stopped The

[incubator-pinot] branch master updated: In ClusterChangeMediator, stop enqueue/process changes if already stopped (#4422)

2019-07-11 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new aadcd36 In ClusterChangeMediator,

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4418: Fix potential resource leak in the way we close a collection of closeables

2019-07-11 Thread GitBox
Jackie-Jiang commented on a change in pull request #4418: Fix potential resource leak in the way we close a collection of closeables URL: https://github.com/apache/incubator-pinot/pull/4418#discussion_r302685376 ## File path:

[incubator-pinot] branch uri_encoding created (now 403f5b7)

2019-07-11 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch uri_encoding in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. at 403f5b7 Add URIUtils class to handle URI/URL encoding/decoding This branch includes the following

[incubator-pinot] 01/01: Add URIUtils class to handle URI/URL encoding/decoding

2019-07-11 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch uri_encoding in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git commit 403f5b75bd45cd4f54a0cdcd04b639d1127a740d Author: Jackie (Xiaotian) Jiang AuthorDate: Thu Jul 11 15:19:33

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #4368: 3891: Check for validity of segment start/end time during segment generation

2019-07-11 Thread GitBox
siddharthteotia commented on a change in pull request #4368: 3891: Check for validity of segment start/end time during segment generation URL: https://github.com/apache/incubator-pinot/pull/4368#discussion_r302770571 ## File path:

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #4368: 3891: Check for validity of segment start/end time during segment generation

2019-07-11 Thread GitBox
siddharthteotia commented on a change in pull request #4368: 3891: Check for validity of segment start/end time during segment generation URL: https://github.com/apache/incubator-pinot/pull/4368#discussion_r302770596 ## File path:

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #4368: 3891: Check for validity of segment start/end time during segment generation

2019-07-11 Thread GitBox
siddharthteotia commented on a change in pull request #4368: 3891: Check for validity of segment start/end time during segment generation URL: https://github.com/apache/incubator-pinot/pull/4368#discussion_r302770631 ## File path:

[incubator-pinot] branch uri_encoding updated (403f5b7 -> 3cfe19e)

2019-07-11 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch uri_encoding in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard 403f5b7 Add URIUtils class to handle URI/URL encoding/decoding add 3cfe19e Add URIUtils class

[GitHub] [incubator-pinot] xiaohui-sun commented on a change in pull request #4428: [TE] detection health - coverage fix

2019-07-11 Thread GitBox
xiaohui-sun commented on a change in pull request #4428: [TE] detection health - coverage fix URL: https://github.com/apache/incubator-pinot/pull/4428#discussion_r302786669 ## File path: thirdeye/thirdeye-frontend/app/pods/components/detection-health/template.hbs ## @@

[GitHub] [incubator-pinot] jihaozh commented on a change in pull request #4428: [TE] detection health - coverage fix

2019-07-11 Thread GitBox
jihaozh commented on a change in pull request #4428: [TE] detection health - coverage fix URL: https://github.com/apache/incubator-pinot/pull/4428#discussion_r302790505 ## File path: thirdeye/thirdeye-frontend/app/pods/components/detection-health/template.hbs ## @@ -26,7

[GitHub] [incubator-pinot] Jackie-Jiang opened a new pull request #4426: Add URIUtils class to handle URI/URL encoding/decoding

2019-07-11 Thread GitBox
Jackie-Jiang opened a new pull request #4426: Add URIUtils class to handle URI/URL encoding/decoding URL: https://github.com/apache/incubator-pinot/pull/4426 Fix the double encoding bug of encoding URI without scheme "/segments/segment %" -> Without fix:

[GitHub] [incubator-pinot] jackjlli commented on a change in pull request #4368: 3891: Check for validity of segment start/end time during segment generation

2019-07-11 Thread GitBox
jackjlli commented on a change in pull request #4368: 3891: Check for validity of segment start/end time during segment generation URL: https://github.com/apache/incubator-pinot/pull/4368#discussion_r302773071 ## File path:

[GitHub] [incubator-pinot] siddharthteotia opened a new issue #4427: Consider using epoll based event loop in Netty when Pinot runs on Linux systems

2019-07-11 Thread GitBox
siddharthteotia opened a new issue #4427: Consider using epoll based event loop in Netty when Pinot runs on Linux systems URL: https://github.com/apache/incubator-pinot/issues/4427 Netty provides the asynchronous event based multiplexing over connections in 3 different flavors -- java nio

[GitHub] [incubator-pinot] jihaozh opened a new pull request #4428: [TE] detection health - coverage fix

2019-07-11 Thread GitBox
jihaozh opened a new pull request #4428: [TE] detection health - coverage fix URL: https://github.com/apache/incubator-pinot/pull/4428 - Fix the issue that anomaly coverage can be more than 100% - Update the logic to get the latest success task to finish time in backend

[GitHub] [incubator-pinot] jackjlli commented on a change in pull request #4426: Add URIUtils class to handle URI/URL encoding/decoding

2019-07-11 Thread GitBox
jackjlli commented on a change in pull request #4426: Add URIUtils class to handle URI/URL encoding/decoding URL: https://github.com/apache/incubator-pinot/pull/4426#discussion_r302789354 ## File path: pinot-common/src/main/java/org/apache/pinot/common/utils/URIUtils.java

[GitHub] [incubator-pinot] jackjlli commented on a change in pull request #4426: Add URIUtils class to handle URI/URL encoding/decoding

2019-07-11 Thread GitBox
jackjlli commented on a change in pull request #4426: Add URIUtils class to handle URI/URL encoding/decoding URL: https://github.com/apache/incubator-pinot/pull/4426#discussion_r302789110 ## File path:

[GitHub] [incubator-pinot] jackjlli commented on a change in pull request #4426: Add URIUtils class to handle URI/URL encoding/decoding

2019-07-11 Thread GitBox
jackjlli commented on a change in pull request #4426: Add URIUtils class to handle URI/URL encoding/decoding URL: https://github.com/apache/incubator-pinot/pull/4426#discussion_r302790223 ## File path: pinot-common/src/main/java/org/apache/pinot/common/utils/URIUtils.java

[GitHub] [incubator-pinot] jackjlli commented on a change in pull request #4426: Add URIUtils class to handle URI/URL encoding/decoding

2019-07-11 Thread GitBox
jackjlli commented on a change in pull request #4426: Add URIUtils class to handle URI/URL encoding/decoding URL: https://github.com/apache/incubator-pinot/pull/4426#discussion_r302788814 ## File path:

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #4368: 3891: Check for validity of segment start/end time during segment generation

2019-07-11 Thread GitBox
siddharthteotia commented on a change in pull request #4368: 3891: Check for validity of segment start/end time during segment generation URL: https://github.com/apache/incubator-pinot/pull/4368#discussion_r302791778 ## File path:

[incubator-pinot] 01/01: [TE] added ThirdEye configuration documents

2019-07-11 Thread xhsun
This is an automated email from the ASF dual-hosted git repository. xhsun pushed a commit to branch document_configuration in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git commit 6b833b95d7bd6aea3b8ec0b3c6ed86e4a29c2d13 Author: Xiaohui Sun AuthorDate: Thu Jul 11 17:41:18

[incubator-pinot] branch document_configuration created (now 6b833b9)

2019-07-11 Thread xhsun
This is an automated email from the ASF dual-hosted git repository. xhsun pushed a change to branch document_configuration in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. at 6b833b9 [TE] added ThirdEye configuration documents This branch includes the following new

[GitHub] [incubator-pinot] xiaohui-sun opened a new pull request #4429: [TE] added ThirdEye configuration documents

2019-07-11 Thread GitBox
xiaohui-sun opened a new pull request #4429: [TE] added ThirdEye configuration documents URL: https://github.com/apache/incubator-pinot/pull/4429 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4426: Add URIUtils class to handle URI/URL encoding/decoding

2019-07-11 Thread GitBox
Jackie-Jiang commented on a change in pull request #4426: Add URIUtils class to handle URI/URL encoding/decoding URL: https://github.com/apache/incubator-pinot/pull/4426#discussion_r302793095 ## File path:

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4418: Fix potential resource leak in the way we close a collection of closeables

2019-07-11 Thread GitBox
Jackie-Jiang commented on a change in pull request #4418: Fix potential resource leak in the way we close a collection of closeables URL: https://github.com/apache/incubator-pinot/pull/4418#discussion_r302772372 ## File path:

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4418: Fix potential resource leak in the way we close a collection of closeables

2019-07-11 Thread GitBox
Jackie-Jiang commented on a change in pull request #4418: Fix potential resource leak in the way we close a collection of closeables URL: https://github.com/apache/incubator-pinot/pull/4418#discussion_r302774250 ## File path:

[incubator-pinot] branch uri_encoding updated (3cfe19e -> 6c4f76c)

2019-07-11 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch uri_encoding in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard 3cfe19e Add URIUtils class to handle URI/URL encoding/decoding add 6c4f76c Add URIUtils class

[incubator-pinot] branch uri_encoding updated (6c4f76c -> 4ec26fc)

2019-07-11 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch uri_encoding in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. omit 6c4f76c Add URIUtils class to handle URI/URL encoding/decoding add 4ec26fc Add URIUtils class

[GitHub] [incubator-pinot] Jackie-Jiang opened a new pull request #4430: Cleanup un-necessary setups in HelixSetupUtils

2019-07-11 Thread GitBox
Jackie-Jiang opened a new pull request #4430: Cleanup un-necessary setups in HelixSetupUtils URL: https://github.com/apache/incubator-pinot/pull/4430 - Do not enable leadControllerResource by default (no auto-rebalance) - Remove redundant empty brokerResource resource config - Remove

[incubator-pinot] 01/01: Cleanup un-necessary setups in HelixSetupUtils

2019-07-11 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch helix_setup in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git commit db6fdf8da0321d1a1ef283bdb3becd64ad6c4068 Author: Jackie (Xiaotian) Jiang AuthorDate: Thu Jul 11 18:20:42

[incubator-pinot] branch misc_fix created (now 9c4d9fa)

2019-07-11 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch misc_fix in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. at 9c4d9fa Misc fix for controller tests This branch includes the following new commits: new 9c4d9fa

[incubator-pinot] 01/01: Misc fix for controller tests

2019-07-11 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch misc_fix in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git commit 9c4d9fa43adda13a96577e48dc37f44165253c34 Author: Jackie (Xiaotian) Jiang AuthorDate: Thu Jul 11 18:46:09

[incubator-pinot] branch helix_setup created (now db6fdf8)

2019-07-11 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch helix_setup in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. at db6fdf8 Cleanup un-necessary setups in HelixSetupUtils This branch includes the following new

  1   2   >