[GitHub] [incubator-pinot] akshayrai commented on a change in pull request #4960: [TE] Use upper and lower bounds as predicted for threshold algorithm

2020-01-06 Thread GitBox
akshayrai commented on a change in pull request #4960: [TE] Use upper and lower bounds as predicted for threshold algorithm URL: https://github.com/apache/incubator-pinot/pull/4960#discussion_r363620810 ## File path:

[GitHub] [incubator-pinot] kishoreg commented on a change in pull request #4963: Package rename pinot-plugin modules (part of #4941).

2020-01-06 Thread GitBox
kishoreg commented on a change in pull request #4963: Package rename pinot-plugin modules (part of #4941). URL: https://github.com/apache/incubator-pinot/pull/4963#discussion_r363617632 ## File path:

[GitHub] [incubator-pinot] kishoreg commented on a change in pull request #4963: Package rename pinot-plugin modules (part of #4941).

2020-01-06 Thread GitBox
kishoreg commented on a change in pull request #4963: Package rename pinot-plugin modules (part of #4941). URL: https://github.com/apache/incubator-pinot/pull/4963#discussion_r363616977 ## File path:

[GitHub] [incubator-pinot] kishoreg commented on a change in pull request #4963: Package rename pinot-plugin modules (part of #4941).

2020-01-06 Thread GitBox
kishoreg commented on a change in pull request #4963: Package rename pinot-plugin modules (part of #4941). URL: https://github.com/apache/incubator-pinot/pull/4963#discussion_r363617882 ## File path:

[GitHub] [incubator-pinot] codecov-io commented on issue #4963: Package rename pinot-plugin modules (part of #4941).

2020-01-06 Thread GitBox
codecov-io commented on issue #4963: Package rename pinot-plugin modules (part of #4941). URL: https://github.com/apache/incubator-pinot/pull/4963#issuecomment-571461556 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4963?src=pr=h1) Report > Merging

[GitHub] [incubator-pinot] haibow commented on a change in pull request #4954: Support schema evolution for consuming segments

2020-01-06 Thread GitBox
haibow commented on a change in pull request #4954: Support schema evolution for consuming segments URL: https://github.com/apache/incubator-pinot/pull/4954#discussion_r363563130 ## File path: pinot-core/src/main/java/org/apache/pinot/core/segment/index/SegmentMetadataImpl.java

[GitHub] [incubator-pinot] kishoreg commented on issue #4957: Rename stream plugin pkgs

2020-01-06 Thread GitBox
kishoreg commented on issue #4957: Rename stream plugin pkgs URL: https://github.com/apache/incubator-pinot/pull/4957#issuecomment-571408989 Along with mentioning it in the release notes, can we add a hashmap that maps old class to the new class in PluginManager to make this seamless?

[GitHub] [incubator-pinot] haibow commented on a change in pull request #4954: Support schema evolution for consuming segments

2020-01-06 Thread GitBox
haibow commented on a change in pull request #4954: Support schema evolution for consuming segments URL: https://github.com/apache/incubator-pinot/pull/4954#discussion_r363563130 ## File path: pinot-core/src/main/java/org/apache/pinot/core/segment/index/SegmentMetadataImpl.java

[GitHub] [incubator-pinot] haibow commented on a change in pull request #4954: Support schema evolution for consuming segments

2020-01-06 Thread GitBox
haibow commented on a change in pull request #4954: Support schema evolution for consuming segments URL: https://github.com/apache/incubator-pinot/pull/4954#discussion_r363562951 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/pruner/SegmentPrunerService.java

[GitHub] [incubator-pinot] haibow commented on a change in pull request #4954: Support schema evolution for consuming segments

2020-01-06 Thread GitBox
haibow commented on a change in pull request #4954: Support schema evolution for consuming segments URL: https://github.com/apache/incubator-pinot/pull/4954#discussion_r363562153 ## File path:

[GitHub] [incubator-pinot] haibow commented on a change in pull request #4954: Support schema evolution for consuming segments

2020-01-06 Thread GitBox
haibow commented on a change in pull request #4954: Support schema evolution for consuming segments URL: https://github.com/apache/incubator-pinot/pull/4954#discussion_r363562045 ## File path:

[GitHub] [incubator-pinot] haibow commented on a change in pull request #4954: Support schema evolution for consuming segments

2020-01-06 Thread GitBox
haibow commented on a change in pull request #4954: Support schema evolution for consuming segments URL: https://github.com/apache/incubator-pinot/pull/4954#discussion_r363561268 ## File path: pinot-core/src/main/java/org/apache/pinot/core/indexsegment/IndexSegment.java

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4954: Support schema evolution for consuming segments

2020-01-06 Thread GitBox
mcvsubbu commented on a change in pull request #4954: Support schema evolution for consuming segments URL: https://github.com/apache/incubator-pinot/pull/4954#discussion_r363555321 ## File path:

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4954: Support schema evolution for consuming segments

2020-01-06 Thread GitBox
mcvsubbu commented on a change in pull request #4954: Support schema evolution for consuming segments URL: https://github.com/apache/incubator-pinot/pull/4954#discussion_r363552150 ## File path: pinot-core/src/main/java/org/apache/pinot/core/indexsegment/IndexSegment.java

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4954: Support schema evolution for consuming segments

2020-01-06 Thread GitBox
mcvsubbu commented on a change in pull request #4954: Support schema evolution for consuming segments URL: https://github.com/apache/incubator-pinot/pull/4954#discussion_r363553655 ## File path:

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4954: Support schema evolution for consuming segments

2020-01-06 Thread GitBox
mcvsubbu commented on a change in pull request #4954: Support schema evolution for consuming segments URL: https://github.com/apache/incubator-pinot/pull/4954#discussion_r363553172 ## File path:

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4954: Support schema evolution for consuming segments

2020-01-06 Thread GitBox
mcvsubbu commented on a change in pull request #4954: Support schema evolution for consuming segments URL: https://github.com/apache/incubator-pinot/pull/4954#discussion_r363553071 ## File path:

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4954: Support schema evolution for consuming segments

2020-01-06 Thread GitBox
mcvsubbu commented on a change in pull request #4954: Support schema evolution for consuming segments URL: https://github.com/apache/incubator-pinot/pull/4954#discussion_r363556801 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/pruner/SegmentPrunerService.java

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4954: Support schema evolution for consuming segments

2020-01-06 Thread GitBox
mcvsubbu commented on a change in pull request #4954: Support schema evolution for consuming segments URL: https://github.com/apache/incubator-pinot/pull/4954#discussion_r363554485 ## File path:

[GitHub] [incubator-pinot] mayankshriv opened a new pull request #4963: Package rename pinot-plugin modules (part of #4941).

2020-01-06 Thread GitBox
mayankshriv opened a new pull request #4963: Package rename pinot-plugin modules (part of #4941). URL: https://github.com/apache/incubator-pinot/pull/4963 Renamed packages for various pinot-plugins as follows. 1. pinot-input-format: The input format plugins will be under the

[GitHub] [incubator-pinot] mcvsubbu commented on issue #4952: Adding new Controller APIs for retrieving and setting tag for an instance

2020-01-06 Thread GitBox
mcvsubbu commented on issue #4952: Adding new Controller APIs for retrieving and setting tag for an instance URL: https://github.com/apache/incubator-pinot/pull/4952#issuecomment-571380809 @snleee right now we have a use case where we need to tag hosts in helix that do not conform to any

[GitHub] [incubator-pinot] snleee edited a comment on issue #4952: Adding new Controller APIs for retrieving and setting tag for an instance

2020-01-06 Thread GitBox
snleee edited a comment on issue #4952: Adding new Controller APIs for retrieving and setting tag for an instance URL: https://github.com/apache/incubator-pinot/pull/4952#issuecomment-571359606 @icefury71 Current implementation adds a generic API that can add arbitrary `tags` on

[GitHub] [incubator-pinot] snleee edited a comment on issue #4952: Adding new Controller APIs for retrieving and setting tag for an instance

2020-01-06 Thread GitBox
snleee edited a comment on issue #4952: Adding new Controller APIs for retrieving and setting tag for an instance URL: https://github.com/apache/incubator-pinot/pull/4952#issuecomment-571359606 @icefury71 Current implementation adds a generic API that can add arbitrary `tags` on

[GitHub] [incubator-pinot] mcvsubbu commented on issue #4957: Rename stream plugin pkgs

2020-01-06 Thread GitBox
mcvsubbu commented on issue #4957: Rename stream plugin pkgs URL: https://github.com/apache/incubator-pinot/pull/4957#issuecomment-571369256 > > > Will this package name change causing existing realtime tables fail to start consuming? > > > I've also updated the quickstart and examples

[GitHub] [incubator-pinot] snleee edited a comment on issue #4952: Adding new Controller APIs for retrieving and setting tag for an instance

2020-01-06 Thread GitBox
snleee edited a comment on issue #4952: Adding new Controller APIs for retrieving and setting tag for an instance URL: https://github.com/apache/incubator-pinot/pull/4952#issuecomment-571359606 @icefury71 Current implementation adds a generic API that can add arbitrary `tags` on

[GitHub] [incubator-pinot] codecov-io edited a comment on issue #4954: Support schema evolution for consuming segments

2020-01-06 Thread GitBox
codecov-io edited a comment on issue #4954: Support schema evolution for consuming segments URL: https://github.com/apache/incubator-pinot/pull/4954#issuecomment-570396099 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4954?src=pr=h1) Report > Merging

[GitHub] [incubator-pinot] snleee commented on issue #4952: Adding new Controller APIs for retrieving and setting tag for an instance

2020-01-06 Thread GitBox
snleee commented on issue #4952: Adding new Controller APIs for retrieving and setting tag for an instance URL: https://github.com/apache/incubator-pinot/pull/4952#issuecomment-571359606 @icefury71 Current implementation adds a generic API that can add arbitrary `tags` on `instance`

[GitHub] [incubator-pinot] codecov-io edited a comment on issue #4954: Support schema evolution for consuming segments

2020-01-06 Thread GitBox
codecov-io edited a comment on issue #4954: Support schema evolution for consuming segments URL: https://github.com/apache/incubator-pinot/pull/4954#issuecomment-570396099 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4954?src=pr=h1) Report > Merging

[GitHub] [incubator-pinot] npawar commented on issue #4962: Create a new query endpoint for sql

2020-01-06 Thread GitBox
npawar commented on issue #4962: Create a new query endpoint for sql URL: https://github.com/apache/incubator-pinot/issues/4962#issuecomment-571349043 > +1 to adding a new endpoint. > Should pql endpoint still support responseFormat and groupByMode of sql? Why? responseFormat,

[GitHub] [incubator-pinot] haibow opened a new pull request #4954: Support schema evolution for consuming segments

2020-01-06 Thread GitBox
haibow opened a new pull request #4954: Support schema evolution for consuming segments URL: https://github.com/apache/incubator-pinot/pull/4954 Implement the design in https://github.com/apache/incubator-pinot/issues/4225#issuecomment-548173120 Support querying newly added columns

[GitHub] [incubator-pinot] haibow closed pull request #4954: Support schema evolution for consuming segments

2020-01-06 Thread GitBox
haibow closed pull request #4954: Support schema evolution for consuming segments URL: https://github.com/apache/incubator-pinot/pull/4954 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-pinot] fx19880617 commented on issue #4957: Rename stream plugin pkgs

2020-01-06 Thread GitBox
fx19880617 commented on issue #4957: Rename stream plugin pkgs URL: https://github.com/apache/incubator-pinot/pull/4957#issuecomment-571344239 > > Will this package name change causing existing realtime tables fail to start consuming? > > I've also updated the quickstart and examples in

[GitHub] [incubator-pinot] snleee removed a comment on issue #4952: Adding new Controller APIs for retrieving and setting tag for an instance

2020-01-06 Thread GitBox
snleee removed a comment on issue #4952: Adding new Controller APIs for retrieving and setting tag for an instance URL: https://github.com/apache/incubator-pinot/pull/4952#issuecomment-571338493 @mcvsubbu I agree with @icefury71. As you mentioned, we are depending on helix's tagging

[GitHub] [incubator-pinot] snleee commented on issue #4952: Adding new Controller APIs for retrieving and setting tag for an instance

2020-01-06 Thread GitBox
snleee commented on issue #4952: Adding new Controller APIs for retrieving and setting tag for an instance URL: https://github.com/apache/incubator-pinot/pull/4952#issuecomment-571338493 @mcvsubbu I agree with @icefury71. We are depending on helix's tagging feature for our tenant

[GitHub] [incubator-pinot] snleee edited a comment on issue #4952: Adding new Controller APIs for retrieving and setting tag for an instance

2020-01-06 Thread GitBox
snleee edited a comment on issue #4952: Adding new Controller APIs for retrieving and setting tag for an instance URL: https://github.com/apache/incubator-pinot/pull/4952#issuecomment-571338493 @mcvsubbu I agree with @icefury71. As you mentioned, we are depending on helix's tagging

[GitHub] [incubator-pinot] icefury71 commented on issue #4952: Adding new Controller APIs for retrieving and setting tag for an instance

2020-01-06 Thread GitBox
icefury71 commented on issue #4952: Adding new Controller APIs for retrieving and setting tag for an instance URL: https://github.com/apache/incubator-pinot/pull/4952#issuecomment-571335765 > Helix provides commands to add/remove/list tags, so the only value added in making this a part of

[incubator-pinot] branch master updated (9edad92 -> 247af5d)

2020-01-06 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from 9edad92 Make plugin manager to load plugins based on environment variables (#4956) add 247af5d Add

[GitHub] [incubator-pinot] fx19880617 merged pull request #4959: Add schemaFile as option in AddTableCommand

2020-01-06 Thread GitBox
fx19880617 merged pull request #4959: Add schemaFile as option in AddTableCommand URL: https://github.com/apache/incubator-pinot/pull/4959 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #4959: Add schemaFile as option in AddTableCommand

2020-01-06 Thread GitBox
fx19880617 commented on a change in pull request #4959: Add schemaFile as option in AddTableCommand URL: https://github.com/apache/incubator-pinot/pull/4959#discussion_r363488701 ## File path: pinot-tools/src/main/java/org/apache/pinot/tools/admin/command/AddTableCommand.java

[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #4959: Add schemaFile as option in AddTableCommand

2020-01-06 Thread GitBox
fx19880617 commented on a change in pull request #4959: Add schemaFile as option in AddTableCommand URL: https://github.com/apache/incubator-pinot/pull/4959#discussion_r363488701 ## File path: pinot-tools/src/main/java/org/apache/pinot/tools/admin/command/AddTableCommand.java

[GitHub] [incubator-pinot] mcvsubbu commented on issue #4962: Create a new query endpoint for sql

2020-01-06 Thread GitBox
mcvsubbu commented on issue #4962: Create a new query endpoint for sql URL: https://github.com/apache/incubator-pinot/issues/4962#issuecomment-571310841 +1 to adding a new endpoint. Should pql endpoint still support responseFormat and groupByMode of sql? Why?

[GitHub] [incubator-pinot] xiaohui-sun commented on a change in pull request #4960: [TE] Use upper and lower bounds as predicted for threshold algorithm

2020-01-06 Thread GitBox
xiaohui-sun commented on a change in pull request #4960: [TE] Use upper and lower bounds as predicted for threshold algorithm URL: https://github.com/apache/incubator-pinot/pull/4960#discussion_r363473207 ## File path:

[GitHub] [incubator-pinot] npawar edited a comment on issue #4962: Create a new query endpoint for sql

2020-01-06 Thread GitBox
npawar edited a comment on issue #4962: Create a new query endpoint for sql URL: https://github.com/apache/incubator-pinot/issues/4962#issuecomment-571272652 Existing endpoints are: 1. /query GET ``` @GET @Produces(MediaType.APPLICATION_JSON) @Path("query") public

[GitHub] [incubator-pinot] npawar commented on issue #4962: Create a new query endpoint for sql

2020-01-06 Thread GitBox
npawar commented on issue #4962: Create a new query endpoint for sql URL: https://github.com/apache/incubator-pinot/issues/4962#issuecomment-571272652 Existing endpoints are: 1. /query GET ``` @GET @Produces(MediaType.APPLICATION_JSON) @Path("query") public String

[GitHub] [incubator-pinot] npawar opened a new issue #4962: Create a new query endpoint for sql

2020-01-06 Thread GitBox
npawar opened a new issue #4962: Create a new query endpoint for sql URL: https://github.com/apache/incubator-pinot/issues/4962 Add a new endpoint to the pinot broker, which will be the sql query endpoint. Adding a new endpoint will make it easier for migration from pql to sql. The

[GitHub] [incubator-pinot] mcvsubbu commented on issue #4957: Rename stream plugin pkgs

2020-01-06 Thread GitBox
mcvsubbu commented on issue #4957: Rename stream plugin pkgs URL: https://github.com/apache/incubator-pinot/pull/4957#issuecomment-571220982 > Will this package name change causing existing realtime tables fail to start consuming? > I've also updated the quickstart and examples in #4956

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4959: Add schemaFile as option in AddTableCommand

2020-01-06 Thread GitBox
mcvsubbu commented on a change in pull request #4959: Add schemaFile as option in AddTableCommand URL: https://github.com/apache/incubator-pinot/pull/4959#discussion_r363383402 ## File path: pinot-tools/src/main/java/org/apache/pinot/tools/admin/command/AddTableCommand.java