[GitHub] [pulsar] liangyepianzhou commented on pull request #14803: [Fix][Transaction] Fix transaction can not be enable when allowAutoTopicCreation = false

2022-03-22 Thread GitBox
liangyepianzhou commented on pull request #14803: URL: https://github.com/apache/pulsar/pull/14803#issuecomment-1075940920 > How about the transaction log topic and transaction buffer snapshot topic? they will create allow auto-creation or not? Transaction Log is to open a manager

[GitHub] [pulsar] yaalsn commented on issue #14401: Speed up CI workflows

2022-03-22 Thread GitBox
yaalsn commented on issue #14401: URL: https://github.com/apache/pulsar/issues/14401#issuecomment-1075940243 @lhotari Thanks for your contribution! Please @ me in the PR and I'll take a look. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [pulsar-client-go] merlimat commented on a change in pull request #743: Add TableView support

2022-03-22 Thread GitBox
merlimat commented on a change in pull request #743: URL: https://github.com/apache/pulsar-client-go/pull/743#discussion_r832867913 ## File path: pulsar/table_view.go ## @@ -0,0 +1,76 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor

[GitHub] [pulsar-client-go] merlimat commented on a change in pull request #743: Add TableView support

2022-03-22 Thread GitBox
merlimat commented on a change in pull request #743: URL: https://github.com/apache/pulsar-client-go/pull/743#discussion_r832867554 ## File path: pulsar/table_view.go ## @@ -0,0 +1,76 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor

[GitHub] [pulsar] lhotari commented on issue #14401: Speed up CI workflows

2022-03-22 Thread GitBox
lhotari commented on issue #14401: URL: https://github.com/apache/pulsar/issues/14401#issuecomment-1075927069 The workflow refactoring is now ready. I'll prepare a PR to apache/pulsar. Here's a screenshot of the combined workflow:

[pulsar-client-node] branch master updated: Upgrade minimist to 1.2.6 (#205)

2022-03-22 Thread nkurihar
This is an automated email from the ASF dual-hosted git repository. nkurihar pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar-client-node.git The following commit(s) were added to refs/heads/master by this push: new f869a45 Upgrade minimist to

[GitHub] [pulsar] momo-jun commented on pull request #14723: [Broker] Improve SchemaRegistry logs and metrics

2022-03-22 Thread GitBox
momo-jun commented on pull request #14723: URL: https://github.com/apache/pulsar/pull/14723#issuecomment-1075890072 Doc updates: @tjiuming will submit a doc PR to add the new metrics for schema as soon as this PR gets merged. -- This is an automated message from the Apache Git Service.

[pulsar-test-infra] branch master updated (76c227d -> 89acb76)

2022-03-22 Thread lhotari
This is an automated email from the ASF dual-hosted git repository. lhotari pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar-test-infra.git. from 76c227d [Docbot]Fix problems in docbot scripts (#26) new b9df410 Add copy of

[GitHub] [pulsar] momo-jun commented on a change in pull request #14811: [feature][workflow] Add Pulsar PR Naming Convention

2022-03-22 Thread GitBox
momo-jun commented on a change in pull request #14811: URL: https://github.com/apache/pulsar/pull/14811#discussion_r832815462 ## File path: site2/website/contributing.md ## @@ -196,6 +196,10 @@ You'll then push to your branch on GitHub. Note: when updating your commit after

[GitHub] [pulsar] momo-jun commented on issue #13617: [Doc] add explanations for topic retention policy and other commands

2022-03-22 Thread GitBox
momo-jun commented on issue #13617: URL: https://github.com/apache/pulsar/issues/13617#issuecomment-1075875630 @Anonymitaet can you pls help re-assign the issue to @mattisonchao? He will check updates on this issue. -- This is an automated message from the Apache Git Service. To respond

[GitHub] [pulsar] 704237006 opened a new issue #14812: 400 appears when start sink

2022-03-22 Thread GitBox
704237006 opened a new issue #14812: URL: https://github.com/apache/pulsar/issues/14812 **Describe the bug** download [apache-pulsar-2.9.1-bin.tar.gz](https://www.apache.org/dyn/mirrors/mirrors.cgi?action=download=pulsar/pulsar-2.9.1/apache-pulsar-2.9.1-bin.tar.gz) my config is:

[pulsar] branch master updated: [fix][txn]: fix pending ack is recovering throw CursorAlreadyClosedxception (#14781)

2022-03-22 Thread bogong
This is an automated email from the ASF dual-hosted git repository. bogong pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 9f30ee9 [fix][txn]: fix pending ack is

[GitHub] [pulsar] congbobo184 merged pull request #14781: [fix][txn]: fix pending ack is recovering throw CursorAlreadyClosedxception

2022-03-22 Thread GitBox
congbobo184 merged pull request #14781: URL: https://github.com/apache/pulsar/pull/14781 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] Anonymitaet commented on pull request #14811: [feature][workflow] Add Pulsar PR Naming Convention

2022-03-22 Thread GitBox
Anonymitaet commented on pull request #14811: URL: https://github.com/apache/pulsar/pull/14811#issuecomment-1075860707 @D-2-Ed @DaveDuggins @momo-jun could u PTAL? Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [pulsar] Anonymitaet opened a new pull request #14811: [feature][workflow] Add Pulsar PR Naming Convention

2022-03-22 Thread GitBox
Anonymitaet opened a new pull request #14811: URL: https://github.com/apache/pulsar/pull/14811 Preview looks good: https://user-images.githubusercontent.com/50226895/159614141-dc0f659c-8bdf-49dc-bd08-58c5f6561881.png;> -- This is an automated message from the Apache Git Service. To

[GitHub] [pulsar] BewareMyPower closed issue #7479: support pulsar consumer keyshared in C++ And Cgo

2022-03-22 Thread GitBox
BewareMyPower closed issue #7479: URL: https://github.com/apache/pulsar/issues/7479 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] BewareMyPower commented on issue #7800: Missing KEY_BASED option from BatchBuilder for C++ Client

2022-03-22 Thread GitBox
BewareMyPower commented on issue #7800: URL: https://github.com/apache/pulsar/issues/7800#issuecomment-1075858045 Close this issue since it is supported now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [pulsar] BewareMyPower closed issue #7800: Missing KEY_BASED option from BatchBuilder for C++ Client

2022-03-22 Thread GitBox
BewareMyPower closed issue #7800: URL: https://github.com/apache/pulsar/issues/7800 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] congbobo184 opened a new pull request #14810: [fix][txn]: fix transaction log recover throw cursor already close

2022-03-22 Thread GitBox
congbobo184 opened a new pull request #14810: URL: https://github.com/apache/pulsar/pull/14810 ### Motivation When Transactionlog recover fail throw CursorAlreadyClosedException, we should stop the recover op. the cursor was been closed, the transaction log was been closed, so we

[GitHub] [pulsar] gaozhangmin commented on issue #14799: bookie is ready but broker can not fount bookies available

2022-03-22 Thread GitBox
gaozhangmin commented on issue #14799: URL: https://github.com/apache/pulsar/issues/14799#issuecomment-1075853875 Bookie servers num should be greater than `ensembleSize` in broker.conf. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [pulsar] nodece commented on a change in pull request #14798: [improve][security] Add load multiple certificates support

2022-03-22 Thread GitBox
nodece commented on a change in pull request #14798: URL: https://github.com/apache/pulsar/pull/14798#discussion_r832792425 ## File path: pulsar-common/src/main/java/org/apache/pulsar/common/util/TrustManagerProxy.java ## @@ -74,11 +76,16 @@ private void updateTrustManager()

[GitHub] [pulsar] momo-jun commented on pull request #14773: [feature][doc]Add doc for how to use MultiRolesTokenAuthorizationProvider

2022-03-22 Thread GitBox
momo-jun commented on pull request #14773: URL: https://github.com/apache/pulsar/pull/14773#issuecomment-1075852739 > @momo-jun any other doc versions that should be applied to the same changes? Yes, thanks for your reminder. Checked with @RobertIndie, I've added the doc for 2.8.1

[pulsar] branch master updated (763b96c -> a32edc7)

2022-03-22 Thread jianghaiting
This is an automated email from the ASF dual-hosted git repository. jianghaiting pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 763b96c Support dynamic update between non-zero values of topicPublisherThrottlingTickTimeMillis (#14782)

[GitHub] [pulsar] liangyepianzhou opened a new pull request #14809: Fix cannot enable transaction when is allow auto update schema enabled=fasle

2022-03-22 Thread GitBox
liangyepianzhou opened a new pull request #14809: URL: https://github.com/apache/pulsar/pull/14809 [Fix][Transaction] Fix transaction can not be enable when allowAutoUpdateSchemaEnabled = false ### Motivation Fix transaction can not be enable when allowAutoUpdateSchemaEnabled = false

[GitHub] [pulsar] Jason918 merged pull request #14566: [client] Optimize pause when creating sub consumers in multi-topic consumer

2022-03-22 Thread GitBox
Jason918 merged pull request #14566: URL: https://github.com/apache/pulsar/pull/14566 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[pulsar] branch master updated (91b30d5 -> 763b96c)

2022-03-22 Thread jianghaiting
This is an automated email from the ASF dual-hosted git repository. jianghaiting pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 91b30d5 [improve][doc] Describe message ID and enhance the description of sequence ID (#14746) add

[GitHub] [pulsar] congbobo184 opened a new pull request #14808: [fix][txn]: fix some exception handle in transaction buffer

2022-03-22 Thread GitBox
congbobo184 opened a new pull request #14808: URL: https://github.com/apache/pulsar/pull/14808 ### Motivation fix some exception return in transaction buffer ### Modifications use exception.getCause(); ### Verifying this change add test for it ### Does this pull

[GitHub] [pulsar] Jason918 merged pull request #14782: [enh][broker] Support dynamic update between non-zero values of topicPublisherThrottlingTickTimeMillis

2022-03-22 Thread GitBox
Jason918 merged pull request #14782: URL: https://github.com/apache/pulsar/pull/14782 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] congbobo184 opened a new pull request #14807: [fix][txn]: fix transaction buffer recover throw cursor already close

2022-03-22 Thread GitBox
congbobo184 opened a new pull request #14807: URL: https://github.com/apache/pulsar/pull/14807 ### Motivation When Transaction buffer recover fail throw CursorAlreadyClosedException, we should stop the recover op. the cursor was been closed, the transaction buffer was been closed, so

[GitHub] [pulsar] github-actions[bot] commented on pull request #12251: [pulsar-admin] Add --update-mode to optimize namespace rate policy

2022-03-22 Thread GitBox
github-actions[bot] commented on pull request #12251: URL: https://github.com/apache/pulsar/pull/12251#issuecomment-1075832367 The pr had no activity for 30 days, mark with Stale label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [pulsar] armandxu commented on issue #14785: how to setup rack aware in pulsar

2022-03-22 Thread GitBox
armandxu commented on issue #14785: URL: https://github.com/apache/pulsar/issues/14785#issuecomment-1075829926 > Looks like the pulsar documentation doesn't have a concept about this part. /cc @Anonymitaet > > I found a tech blog that contains some concepts about rack ware

[pulsar] branch master updated (dc80a19 -> 91b30d5)

2022-03-22 Thread liuyu
This is an automated email from the ASF dual-hosted git repository. liuyu pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from dc80a19 [improve][doc]Mark CGo client as deprecated in the documentation (#14766) add 91b30d5 [improve][doc]

[pulsar] branch master updated (7556c4e -> dc80a19)

2022-03-22 Thread liuyu
This is an automated email from the ASF dual-hosted git repository. liuyu pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 7556c4e [fix][broker] Fix cannot delete namespace with system topic (#14730) add dc80a19 [improve][doc]Mark

[GitHub] [pulsar] Anonymitaet edited a comment on pull request #14773: [feature][doc]Add doc for how to use MultiRolesTokenAuthorizationProvider

2022-03-22 Thread GitBox
Anonymitaet edited a comment on pull request #14773: URL: https://github.com/apache/pulsar/pull/14773#issuecomment-1075818973 @momo-jun any other doc versions that should be applied to the same changes? -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [pulsar] Anonymitaet commented on pull request #14773: [feature][doc]Add doc for how to use MultiRolesTokenAuthorizationProvider

2022-03-22 Thread GitBox
Anonymitaet commented on pull request #14773: URL: https://github.com/apache/pulsar/pull/14773#issuecomment-1075818973 @momo-jun any other doc versions should be applied the same changes? -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [pulsar] Anonymitaet commented on pull request #14788: Build python client docs once from published libraries

2022-03-22 Thread GitBox
Anonymitaet commented on pull request #14788: URL: https://github.com/apache/pulsar/pull/14788#issuecomment-1075816459 @michaeljmarshall thanks for your clear explanations and quick fix! -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [pulsar] Anonymitaet closed issue #14455: [Doc] Terminology? Message and Sequence Id

2022-03-22 Thread GitBox
Anonymitaet closed issue #14455: URL: https://github.com/apache/pulsar/issues/14455 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] Anonymitaet merged pull request #14746: [improve][doc] Describe message ID and enhance the description of sequence ID

2022-03-22 Thread GitBox
Anonymitaet merged pull request #14746: URL: https://github.com/apache/pulsar/pull/14746 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] Anonymitaet closed issue #14609: [Doc] Remove references to the deleted CGo client

2022-03-22 Thread GitBox
Anonymitaet closed issue #14609: URL: https://github.com/apache/pulsar/issues/14609 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] Anonymitaet merged pull request #14766: Mark CGo client as deprecated in the documentation

2022-03-22 Thread GitBox
Anonymitaet merged pull request #14766: URL: https://github.com/apache/pulsar/pull/14766 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] Anonymitaet commented on pull request #14766: Mark CGo client as deprecated in the documentation

2022-03-22 Thread GitBox
Anonymitaet commented on pull request #14766: URL: https://github.com/apache/pulsar/pull/14766#issuecomment-1075811614 > @Anonymitaet - done, thanks! Added a banner in the CGo client docs saying it has been deprecated. Great reminder! -- This is an automated message from the

[pulsar-site] branch main updated: fix: add dev cmd

2022-03-22 Thread urfree
This is an automated email from the ASF dual-hosted git repository. urfree pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/pulsar-site.git The following commit(s) were added to refs/heads/main by this push: new 18eb200 fix: add dev cmd 18eb200 is described

[GitHub] [pulsar] Raven888888 commented on issue #12465: Pulsar SQL NullPointerException when select a row produced by go client with schema

2022-03-22 Thread GitBox
Raven88 commented on issue #12465: URL: https://github.com/apache/pulsar/issues/12465#issuecomment-1075800758 I was going to try Pulsar 2.9.1 to see if it gets resolved, hearing from @halfvector puts a stop for me... -- This is an automated message from the Apache Git Service. To

[GitHub] [pulsar] liudezhi2098 commented on pull request #14784: [Authenticate] fix debug log authenticate role error

2022-03-22 Thread GitBox
liudezhi2098 commented on pull request #14784: URL: https://github.com/apache/pulsar/pull/14784#issuecomment-1075796188 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [pulsar] liudezhi2098 commented on pull request #14756: [metrics] Metrics http interface unified authentication configuration

2022-03-22 Thread GitBox
liudezhi2098 commented on pull request #14756: URL: https://github.com/apache/pulsar/pull/14756#issuecomment-1075795918 @eolivelli PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] halfvector commented on issue #12465: Pulsar SQL NullPointerException when select a row produced by go client with schema

2022-03-22 Thread GitBox
halfvector commented on issue #12465: URL: https://github.com/apache/pulsar/issues/12465#issuecomment-1075732502 Ran into this same bug using Pulsar 2.9.1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [pulsar] A-Wanderer commented on a change in pull request #14604: [C++] add chunk message id

2022-03-22 Thread GitBox
A-Wanderer commented on a change in pull request #14604: URL: https://github.com/apache/pulsar/pull/14604#discussion_r832547877 ## File path: pulsar-client-cpp/lib/ConsumerImpl.cc ## @@ -415,21 +411,40 @@ void ConsumerImpl::messageReceived(const ClientConnectionPtr& cnx,

[GitHub] [pulsar] A-Wanderer commented on a change in pull request #14604: [C++] add chunk message id

2022-03-22 Thread GitBox
A-Wanderer commented on a change in pull request #14604: URL: https://github.com/apache/pulsar/pull/14604#discussion_r832547639 ## File path: pulsar-client-cpp/lib/ConsumerImpl.cc ## @@ -415,21 +411,40 @@ void ConsumerImpl::messageReceived(const ClientConnectionPtr& cnx,

[GitHub] [pulsar] A-Wanderer commented on a change in pull request #14604: [C++] add chunk message id

2022-03-22 Thread GitBox
A-Wanderer commented on a change in pull request #14604: URL: https://github.com/apache/pulsar/pull/14604#discussion_r832547352 ## File path: pulsar-client-cpp/lib/Commands.cc ## @@ -469,6 +469,19 @@ SharedBuffer Commands::newSeek(uint64_t consumerId, uint64_t requestId,

[GitHub] [pulsar-client-go] merlimat commented on issue #752: Update license txt files to reflect updated dependency (go-rate)

2022-03-22 Thread GitBox
merlimat commented on issue #752: URL: https://github.com/apache/pulsar-client-go/issues/752#issuecomment-1075520923 Good point. I think we need to have a tool that automatically updates this license file from the dependencies and we should check in the PR that it's consistent. --

[GitHub] [pulsar] A-Wanderer commented on a change in pull request #14604: [C++] add chunk message id

2022-03-22 Thread GitBox
A-Wanderer commented on a change in pull request #14604: URL: https://github.com/apache/pulsar/pull/14604#discussion_r832515808 ## File path: pulsar-client-cpp/lib/ConsumerImpl.cc ## @@ -1228,8 +1243,15 @@ void ConsumerImpl::seekAsync(const MessageId& msgId, ResultCallback

[GitHub] [pulsar] A-Wanderer commented on a change in pull request #14604: [C++] add chunk message id

2022-03-22 Thread GitBox
A-Wanderer commented on a change in pull request #14604: URL: https://github.com/apache/pulsar/pull/14604#discussion_r832503849 ## File path: pulsar-client-cpp/lib/ConsumerImpl.cc ## @@ -1228,8 +1243,15 @@ void ConsumerImpl::seekAsync(const MessageId& msgId, ResultCallback

[GitHub] [pulsar] asardaes commented on a change in pull request #14798: [improve][security] Add load multiple certificates support

2022-03-22 Thread GitBox
asardaes commented on a change in pull request #14798: URL: https://github.com/apache/pulsar/pull/14798#discussion_r832508322 ## File path: pulsar-common/src/main/java/org/apache/pulsar/common/util/TrustManagerProxy.java ## @@ -74,11 +76,16 @@ private void

[GitHub] [pulsar] A-Wanderer commented on a change in pull request #14604: [C++] add chunk message id

2022-03-22 Thread GitBox
A-Wanderer commented on a change in pull request #14604: URL: https://github.com/apache/pulsar/pull/14604#discussion_r832503849 ## File path: pulsar-client-cpp/lib/ConsumerImpl.cc ## @@ -1228,8 +1243,15 @@ void ConsumerImpl::seekAsync(const MessageId& msgId, ResultCallback

[GitHub] [pulsar] A-Wanderer commented on a change in pull request #14604: [C++] add chunk message id

2022-03-22 Thread GitBox
A-Wanderer commented on a change in pull request #14604: URL: https://github.com/apache/pulsar/pull/14604#discussion_r832497610 ## File path: pulsar-client-cpp/lib/ConsumerImpl.cc ## @@ -1228,8 +1243,15 @@ void ConsumerImpl::seekAsync(const MessageId& msgId, ResultCallback

[GitHub] [pulsar] dlg99 commented on pull request #14780: Handle kafka sinks that return immutable maps as configs

2022-03-22 Thread GitBox
dlg99 commented on pull request #14780: URL: https://github.com/apache/pulsar/pull/14780#issuecomment-1075439229 @eolivelli https://github.com/apache/pulsar/pull/14806 - it cherry-picks into 2.8 cleanly, but I can create a separate PR if needed -- This is an automated message from the

[GitHub] [pulsar-client-go] shubham1172 opened a new issue #752: Update license txt files to reflect updated dependency (go-rate)

2022-03-22 Thread GitBox
shubham1172 opened a new issue #752: URL: https://github.com/apache/pulsar-client-go/issues/752 With this PR https://github.com/apache/pulsar-client-go/issues/725. we upgraded https://github.com/beefsack/go-rate to a version that's MIT licensed. This issue suggests updating the same at

[GitHub] [pulsar] dlg99 opened a new pull request #14806: Handle kafka sinks that return immutable maps as configs (#14780)

2022-03-22 Thread GitBox
dlg99 opened a new pull request #14806: URL: https://github.com/apache/pulsar/pull/14806 (cherry picked from commit b56d7318e73fb6915208dbe1223446e759c2ed0b) ### Motivation Some Kafka sinks return immutable map as config (e.g. ones written in Scala) As result KCA sink fail

[GitHub] [pulsar] BewareMyPower commented on a change in pull request #14604: [C++] add chunk message id

2022-03-22 Thread GitBox
BewareMyPower commented on a change in pull request #14604: URL: https://github.com/apache/pulsar/pull/14604#discussion_r832420382 ## File path: pulsar-client-cpp/lib/ConsumerImpl.cc ## @@ -415,21 +411,40 @@ void ConsumerImpl::messageReceived(const ClientConnectionPtr& cnx,

[GitHub] [pulsar] BewareMyPower commented on a change in pull request #14604: [C++] add chunk message id

2022-03-22 Thread GitBox
BewareMyPower commented on a change in pull request #14604: URL: https://github.com/apache/pulsar/pull/14604#discussion_r832371254 ## File path: pulsar-client-cpp/lib/ChunkMessageIdImpl.h ## @@ -0,0 +1,44 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one +

[GitHub] [pulsar] BewareMyPower commented on a change in pull request #14604: [C++] add chunk message id

2022-03-22 Thread GitBox
BewareMyPower commented on a change in pull request #14604: URL: https://github.com/apache/pulsar/pull/14604#discussion_r832377612 ## File path: pulsar-client-cpp/lib/ChunkMessageIdImpl.h ## @@ -0,0 +1,44 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one +

[GitHub] [pulsar] BewareMyPower commented on a change in pull request #14604: [C++] add chunk message id

2022-03-22 Thread GitBox
BewareMyPower commented on a change in pull request #14604: URL: https://github.com/apache/pulsar/pull/14604#discussion_r832441150 ## File path: pulsar-client-cpp/lib/ConsumerImpl.cc ## @@ -1228,8 +1243,15 @@ void ConsumerImpl::seekAsync(const MessageId& msgId, ResultCallback

[GitHub] [pulsar] TheNotary commented on issue #9579: Issues connecting to standalone docker compose from within docker

2022-03-22 Thread GitBox
TheNotary commented on issue #9579: URL: https://github.com/apache/pulsar/issues/9579#issuecomment-1075390636 Yeah I think no one on the team had time to look into it or respond. I don't use Pulsar at the moment so will just close this. -- This is an automated message from the Apache

[GitHub] [pulsar] TheNotary closed issue #9579: Issues connecting to standalone docker compose from within docker

2022-03-22 Thread GitBox
TheNotary closed issue #9579: URL: https://github.com/apache/pulsar/issues/9579 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] nicoloboschi opened a new pull request #14805: [pulsar-io] Elasticsearch sink support for Elastic 8

2022-03-22 Thread GitBox
nicoloboschi opened a new pull request #14805: URL: https://github.com/apache/pulsar/pull/14805 ### Motivation OpenSearch high-level rest api client does not support Elastic 8 servers. There are some hardcoded request fields that are no longer supported in ES 8 and the server

[GitHub] [pulsar] github-actions[bot] commented on pull request #14804: [Issue 14505] PIP-145: Enable evaluating subscription pattern on broker side

2022-03-22 Thread GitBox
github-actions[bot] commented on pull request #14804: URL: https://github.com/apache/pulsar/pull/14804#issuecomment-1075349695 @andrasbeni:Thanks for your contribution. For this PR, do we need to update docs? (The [PR template contains info about

[GitHub] [pulsar] andrasbeni opened a new pull request #14804: [Issue 14505] PIP-145: Enable evaluating subscription pattern on broker side

2022-03-22 Thread GitBox
andrasbeni opened a new pull request #14804: URL: https://github.com/apache/pulsar/pull/14804 Master Issue: #14505 ### Motivation This is part 1 of PIP-145: Improve performance of regex subscriptions ### Modifications This change covers applying

[GitHub] [pulsar] tjiuming commented on a change in pull request #14453: Improve /metrics endpoint performance

2022-03-22 Thread GitBox
tjiuming commented on a change in pull request #14453: URL: https://github.com/apache/pulsar/pull/14453#discussion_r832331106 ## File path: pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java ## @@ -2276,6 +2276,11 @@ doc = "If true,

[GitHub] [pulsar] eolivelli commented on a change in pull request #14589: Sink does not crash/restart after an error on write.

2022-03-22 Thread GitBox
eolivelli commented on a change in pull request #14589: URL: https://github.com/apache/pulsar/pull/14589#discussion_r832326016 ## File path: pulsar-functions/proto/src/main/proto/Function.proto ## @@ -101,6 +101,7 @@ message ConsumerSpec { map schemaProperties = 5;

[GitHub] [pulsar] BewareMyPower commented on issue #14665: Flaky-test: C++ ClientTest.testConnectTimeout

2022-03-22 Thread GitBox
BewareMyPower commented on issue #14665: URL: https://github.com/apache/pulsar/issues/14665#issuecomment-1075318073 ``` 2022-03-22 15:17:31.535 INFO [140307560827648] ClientConnection:189 | [ -> pulsar://192.0.2.1:1234] Create ClientConnection, timeout=1000 2022-03-22 15:17:31.535

[GitHub] [pulsar] eolivelli commented on a change in pull request #14453: Improve /metrics endpoint performance

2022-03-22 Thread GitBox
eolivelli commented on a change in pull request #14453: URL: https://github.com/apache/pulsar/pull/14453#discussion_r832308809 ## File path: pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java ## @@ -2276,6 +2276,11 @@ doc = "If

[GitHub] [pulsar] lordcheng10 commented on pull request #14645: Fix bug: markdelete position not moving forward when skipping lost entries

2022-03-22 Thread GitBox
lordcheng10 commented on pull request #14645: URL: https://github.com/apache/pulsar/pull/14645#issuecomment-1075284666 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [pulsar] liangyepianzhou opened a new pull request #14803: [Fix][Transaction] Fix transaction can not be enable when allowAutoTopicCreation = false

2022-03-22 Thread GitBox
liangyepianzhou opened a new pull request #14803: URL: https://github.com/apache/pulsar/pull/14803 Fix https://github.com/apache/pulsar/issues/14786 ### Motivation Fix transaction can not be enable when allowAutoTopicCreation = false ### Modification create topic, no only

[GitHub] [pulsar] nicoloboschi opened a new pull request #14802: [owasp] suppress debezium-connector-postgres CVE-2021-23214 false positive

2022-03-22 Thread GitBox
nicoloboschi opened a new pull request #14802: URL: https://github.com/apache/pulsar/pull/14802 ### Motivation debezium-connector-postgres is incorrectly targeted with CVE-2021-23214 and the owasp check fails. It's a false positive since the CVE is for PostGre server.

[GitHub] [pulsar] ZiyaoWei commented on a change in pull request #14766: Mark CGo client as deprecated in the documentation

2022-03-22 Thread GitBox
ZiyaoWei commented on a change in pull request #14766: URL: https://github.com/apache/pulsar/pull/14766#discussion_r832213851 ## File path: site2/docs/client-libraries-cgo.md ## @@ -4,6 +4,8 @@ title: Pulsar CGo client sidebar_label: CGo(deprecated) --- +> The CGo client

[GitHub] [pulsar] nodece commented on pull request #14798: [improve][security] Add load multiple certificates support

2022-03-22 Thread GitBox
nodece commented on pull request #14798: URL: https://github.com/apache/pulsar/pull/14798#issuecomment-1075200446 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pulsar] nicoloboschi commented on pull request #14796: [tests] Add Kinesis Sink integration tests

2022-03-22 Thread GitBox
nicoloboschi commented on pull request #14796: URL: https://github.com/apache/pulsar/pull/14796#issuecomment-1075192998 /pulsarbot rerun-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [pulsar] lhotari commented on issue #14401: Speed up CI workflows

2022-03-22 Thread GitBox
lhotari commented on issue #14401: URL: https://github.com/apache/pulsar/issues/14401#issuecomment-1075135405 most recent attempt https://github.com/lhotari/pulsar/actions/runs/2022322466 There was a problem were builds failed with an error like this: ``` Error: Failed to

[GitHub] [pulsar] aparajita89 commented on pull request #14102: PIP-144: Making SchemaRegistry implementation configurable

2022-03-22 Thread GitBox
aparajita89 commented on pull request #14102: URL: https://github.com/apache/pulsar/pull/14102#issuecomment-1075134964 @eolivelli the org.apache.pulsar.common.nar.NarClassLoader supports loading of jar files as well and so, changing to NarClassLoader would not be a change in interface

[GitHub] [pulsar] codelipenghui commented on a change in pull request #14801: [fix][txn]: fix transaction buffer recover reader and writer fail

2022-03-22 Thread GitBox
codelipenghui commented on a change in pull request #14801: URL: https://github.com/apache/pulsar/pull/14801#discussion_r832117787 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/transaction/buffer/impl/TopicTransactionBuffer.java ## @@ -178,15 +178,17 @@

[GitHub] [pulsar] james-bright-helix commented on issue #14079: Inactive topics cannot be consumed if recreated after automatic deletion

2022-03-22 Thread GitBox
james-bright-helix commented on issue #14079: URL: https://github.com/apache/pulsar/issues/14079#issuecomment-1075117403 @Technoboy- @mattisonchao OK I finally reproduced it on my home machine. The secret sauce is that you have to wait a little bit after the GC before trying to reconnect

[GitHub] [pulsar] congbobo184 commented on pull request #14760: [fix][txn]: fix transaction buffer snaphost broker persistent close issue

2022-03-22 Thread GitBox
congbobo184 commented on pull request #14760: URL: https://github.com/apache/pulsar/pull/14760#issuecomment-1075090398 https://github.com/apache/pulsar/pull/14801 will fix this problem so close this PR -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [pulsar] congbobo184 closed pull request #14760: [fix][txn]: fix transaction buffer snaphost broker persistent close issue

2022-03-22 Thread GitBox
congbobo184 closed pull request #14760: URL: https://github.com/apache/pulsar/pull/14760 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] congbobo184 opened a new pull request #14801: [fix][txn]: fix transaction buffer recover reader and writer fail

2022-03-22 Thread GitBox
congbobo184 opened a new pull request #14801: URL: https://github.com/apache/pulsar/pull/14801 ### Motivation When Transaction buffer recover create reader or create writer fail or read snapshot fail throw PulsarClientException, we should rerecover this topic so close this topic to

[GitHub] [pulsar] codelipenghui commented on issue #14785: how to setup rack aware in pulsar

2022-03-22 Thread GitBox
codelipenghui commented on issue #14785: URL: https://github.com/apache/pulsar/issues/14785#issuecomment-1075086552 Looks like the pulsar documentation doesn't have a concept about this part. /cc @Anonymitaet I found a tech blog that contains some concepts about rack ware

[GitHub] [pulsar] leizhiyuan closed issue #14800: metadata-store was blocked by pulsar-backlog-quota-checker

2022-03-22 Thread GitBox
leizhiyuan closed issue #14800: URL: https://github.com/apache/pulsar/issues/14800 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] leizhiyuan commented on issue #14800: metadata-store was blocked by pulsar-backlog-quota-checker

2022-03-22 Thread GitBox
leizhiyuan commented on issue #14800: URL: https://github.com/apache/pulsar/issues/14800#issuecomment-1075082915 thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [pulsar] Jason918 commented on issue #14800: metadata-store was blocked by pulsar-backlog-quota-checker

2022-03-22 Thread GitBox
Jason918 commented on issue #14800: URL: https://github.com/apache/pulsar/issues/14800#issuecomment-1075080972 And #14634 already removed synchronized from monitorBacklogQuota. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [pulsar] Jason918 commented on issue #14800: metadata-store was blocked by pulsar-backlog-quota-checker

2022-03-22 Thread GitBox
Jason918 commented on issue #14800: URL: https://github.com/apache/pulsar/issues/14800#issuecomment-1075079896 #14782 will remove synchronized from `setupTopicPublishRateLimiterMonitor` -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [pulsar] Jason918 commented on pull request #14782: [enh][broker] Support dynamic update between non-zero values of topicPublisherThrottlingTickTimeMillis

2022-03-22 Thread GitBox
Jason918 commented on pull request #14782: URL: https://github.com/apache/pulsar/pull/14782#issuecomment-1075074396 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pulsar] leizhiyuan opened a new issue #14800: metadata-store was blocked 不用

2022-03-22 Thread GitBox
leizhiyuan opened a new issue #14800: URL: https://github.com/apache/pulsar/issues/14800 **Describe the bug** A clear and concise description of what the bug is. **To Reproduce** Steps to reproduce the behavior: 1. Go to '...' 2. Click on '' 3. Scroll down to

[pulsar] branch master updated: [fix][broker] Fix cannot delete namespace with system topic (#14730)

2022-03-22 Thread technoboy
This is an automated email from the ASF dual-hosted git repository. technoboy pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 7556c4e [fix][broker] Fix cannot delete

[GitHub] [pulsar] Technoboy- merged pull request #14730: [fix][broker]: Fix cannot delete namespace with system topic

2022-03-22 Thread GitBox
Technoboy- merged pull request #14730: URL: https://github.com/apache/pulsar/pull/14730 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] Technoboy- closed issue #10263: Cannot delete non empty bundle

2022-03-22 Thread GitBox
Technoboy- closed issue #10263: URL: https://github.com/apache/pulsar/issues/10263 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] A-Wanderer commented on a change in pull request #14604: [C++] add chunk message id

2022-03-22 Thread GitBox
A-Wanderer commented on a change in pull request #14604: URL: https://github.com/apache/pulsar/pull/14604#discussion_r832018914 ## File path: pulsar-client-cpp/lib/ConsumerImpl.cc ## @@ -1229,7 +1244,17 @@ void ConsumerImpl::seekAsync(const MessageId& msgId, ResultCallback

[pulsar] branch master updated (b56d731 -> 0b6b1e2)

2022-03-22 Thread eolivelli
This is an automated email from the ASF dual-hosted git repository. eolivelli pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from b56d731 Handle kafka sinks that return immutable maps as configs (#14780) add 0b6b1e2 [fix][admin] Fix

[GitHub] [pulsar] eolivelli merged pull request #14769: [fix][admin] Fix NPE in PulsarAdminBuilder when the service is not set

2022-03-22 Thread GitBox
eolivelli merged pull request #14769: URL: https://github.com/apache/pulsar/pull/14769 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] eolivelli closed issue #14768: PulsarAdmin throws NPE when the service url is not set

2022-03-22 Thread GitBox
eolivelli closed issue #14768: URL: https://github.com/apache/pulsar/issues/14768 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] github-actions[bot] commented on pull request #14792: [fix] [package] Fix Auto delete the package name issue

2022-03-22 Thread GitBox
github-actions[bot] commented on pull request #14792: URL: https://github.com/apache/pulsar/pull/14792#issuecomment-1074984338 @poorbarcode:Thanks for providing doc info! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [pulsar] codelipenghui commented on issue #14767: Need an api interface for the process to start working normally for rolling restart of pulsar

2022-03-22 Thread GitBox
codelipenghui commented on issue #14767: URL: https://github.com/apache/pulsar/issues/14767#issuecomment-1074965505 @zcola Ok, thanks for the update, we will consider to add it the administration upgrade part /cc @Anonymitaet -- This is an automated message from the Apache Git

  1   2   >