[PR] [fix][test] Flaky-test: AdminApiMultiBrokersTest.testForceDeletePartitionedTopicWithSub [pulsar]

2024-04-25 Thread via GitHub
crossoverJie opened a new pull request, #22592: URL: https://github.com/apache/pulsar/pull/22592 Fixes #22428 ### Motivation ```java java.util.concurrent.ExecutionException: org.apache.pulsar.client.admin.PulsarAdminException$ConflictException: This topic

Re: [PR] [improve][test] Add policy authentication test for namespace API [pulsar]

2024-04-25 Thread via GitHub
Technoboy- closed pull request #22593: [improve][test] Add policy authentication test for namespace API URL: https://github.com/apache/pulsar/pull/22593 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] [fix][broker]One topic can be close multiple times concurrently [pulsar]

2024-04-25 Thread via GitHub
poorbarcode commented on code in PR #17524: URL: https://github.com/apache/pulsar/pull/17524#discussion_r1580420056 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java: ## @@ -1595,41 +1662,50 @@ public CompletableFuture close(

Re: [PR] [cleanup] [test] remove useless TestAuthorizationProvider2 [pulsar]

2024-04-25 Thread via GitHub
thetumbled commented on PR #22595: URL: https://github.com/apache/pulsar/pull/22595#issuecomment-2078588760 PTAL, thanks. @Technoboy- @lhotari -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] [fix] [test] Fix flaky test ReplicatorTest [pulsar]

2024-04-25 Thread via GitHub
lhotari commented on code in PR #22594: URL: https://github.com/apache/pulsar/pull/22594#discussion_r1580496723 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/NamespacesBase.java: ## @@ -2019,7 +2019,7 @@ protected void

Re: [PR] [fix] [test] Fix flaky test ReplicatorTest [pulsar]

2024-04-25 Thread via GitHub
lhotari commented on code in PR #22594: URL: https://github.com/apache/pulsar/pull/22594#discussion_r1580497194 ## pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/NamespaceAuthZTest.java: ## @@ -1028,4 +1019,43 @@ public void testPackageAPI() throws Exception {

Re: [PR] [fix] [broker] Part-2: Replicator can not created successfully due to an orphan replicator in the previous topic owner [pulsar]

2024-04-25 Thread via GitHub
heesung-sn commented on code in PR #21948: URL: https://github.com/apache/pulsar/pull/21948#discussion_r1580239552 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java: ## @@ -3881,9 +3895,27 @@ private void fenceTopicToCloseOrDelete()

Re: [PR] [fix] [test] Fix flaky test ReplicatorTest [pulsar]

2024-04-25 Thread via GitHub
lhotari commented on code in PR #22594: URL: https://github.com/apache/pulsar/pull/22594#discussion_r1580470740 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/NamespacesBase.java: ## @@ -2019,7 +2019,7 @@ protected void

Re: [PR] [fix] [test] Fix flaky test ReplicatorTest [pulsar]

2024-04-25 Thread via GitHub
poorbarcode commented on code in PR #22594: URL: https://github.com/apache/pulsar/pull/22594#discussion_r1580507648 ## pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/NamespaceAuthZTest.java: ## @@ -1028,4 +1019,43 @@ public void testPackageAPI() throws Exception {

Re: [PR] [fix] [broker] Part-2: Replicator can not created successfully due to an orphan replicator in the previous topic owner [pulsar]

2024-04-25 Thread via GitHub
lhotari commented on PR #21948: URL: https://github.com/apache/pulsar/pull/21948#issuecomment-2078264388 @poorbarcode I can confirm that this PR is causing problems which most likely lead to OOMEs. Reported as #22588. To reproduce: ``` git clone https://github.com/apache/pulsar

Re: [PR] [fix][test] Disable ExtensibleLoadManagerImpl in ReplicatorGlobalNSTest [pulsar]

2024-04-25 Thread via GitHub
lhotari closed pull request #22590: [fix][test] Disable ExtensibleLoadManagerImpl in ReplicatorGlobalNSTest URL: https://github.com/apache/pulsar/pull/22590 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] [fix] [broker] Part-2: Replicator can not created successfully due to an orphan replicator in the previous topic owner [pulsar]

2024-04-25 Thread via GitHub
heesung-sn commented on code in PR #21948: URL: https://github.com/apache/pulsar/pull/21948#discussion_r1580239552 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java: ## @@ -3881,9 +3895,27 @@ private void fenceTopicToCloseOrDelete()

Re: [PR] [fix] [broker] Part-2: Replicator can not created successfully due to an orphan replicator in the previous topic owner [pulsar]

2024-04-25 Thread via GitHub
heesung-sn commented on code in PR #21948: URL: https://github.com/apache/pulsar/pull/21948#discussion_r1580239552 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java: ## @@ -3881,9 +3895,27 @@ private void fenceTopicToCloseOrDelete()

(pulsar) branch master updated: [fix][admin] Fix namespace admin api exception response (#22587)

2024-04-25 Thread technoboy
This is an automated email from the ASF dual-hosted git repository. technoboy pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new f25776d7fe6 [fix][admin] Fix namespace admin

[PR] [fix] [test] Fix flaky test ReplicatorTest [pulsar]

2024-04-25 Thread via GitHub
poorbarcode opened a new pull request, #22594: URL: https://github.com/apache/pulsar/pull/22594 ### Motivation There are two tests that are not normal operations when using Geo-Replication with a global metadata store, which is should be denied in a production pulsar cluster. they

Re: [PR] [fix] [test] Fix flaky test ReplicatorTest [pulsar]

2024-04-25 Thread via GitHub
lhotari commented on PR #22594: URL: https://github.com/apache/pulsar/pull/22594#issuecomment-207861 > Rename the class ReplicatorGlobalNSTest to ReplicatorGlobalNSDangerousOperationTest I think this could be handled with a comment instead. -- This is an automated message from

Re: [PR] [fix] [test] Fix flaky test ReplicatorTest [pulsar]

2024-04-25 Thread via GitHub
lhotari commented on PR #22594: URL: https://github.com/apache/pulsar/pull/22594#issuecomment-2078613762 > Move Replicatortest.testConfigChange into ReplicatorGlobalNSDangerousOperationTest\nMove the normal test ReplicatorGlobalNSTest. testForcefullyTopicDeletion into Replicatortest

Re: [PR] [cleanup] [test] remove useless TestAuthorizationProvider2 [pulsar]

2024-04-25 Thread via GitHub
lhotari commented on code in PR #22595: URL: https://github.com/apache/pulsar/pull/22595#discussion_r1580497818 ## pulsar-broker/src/test/java/org/apache/pulsar/client/api/AuthorizationProducerConsumerTest.java: ## @@ -349,7 +349,8 @@ public void testSubscriberPermission()

Re: [PR] [fix] [broker] Part-2: Replicator can not created successfully due to an orphan replicator in the previous topic owner [pulsar]

2024-04-25 Thread via GitHub
heesung-sn commented on code in PR #21948: URL: https://github.com/apache/pulsar/pull/21948#discussion_r1580226632 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java: ## @@ -3881,9 +3895,27 @@ private void fenceTopicToCloseOrDelete()

Re: [PR] [fix] [broker] Part-2: Replicator can not created successfully due to an orphan replicator in the previous topic owner [pulsar]

2024-04-25 Thread via GitHub
heesung-sn commented on code in PR #21948: URL: https://github.com/apache/pulsar/pull/21948#discussion_r1580224189 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java: ## @@ -3881,9 +3895,27 @@ private void fenceTopicToCloseOrDelete()

Re: [PR] [fix] [broker] Part-2: Replicator can not created successfully due to an orphan replicator in the previous topic owner [pulsar]

2024-04-25 Thread via GitHub
heesung-sn commented on code in PR #21948: URL: https://github.com/apache/pulsar/pull/21948#discussion_r1580224189 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java: ## @@ -3881,9 +3895,27 @@ private void fenceTopicToCloseOrDelete()

(pulsar) branch branch-3.0 updated: [fix][admin] Fix namespace admin api exception response (#22587)

2024-04-25 Thread zhaocong
This is an automated email from the ASF dual-hosted git repository. zhaocong pushed a commit to branch branch-3.0 in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/branch-3.0 by this push: new 5ffec8a3cd8 [fix][admin] Fix

Re: [PR] [fix][broker]One topic can be close multiple times concurrently [pulsar]

2024-04-25 Thread via GitHub
poorbarcode commented on PR #17524: URL: https://github.com/apache/pulsar/pull/17524#issuecomment-2078537404 Rebase master -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [improve][admin] Check if the topic existed before the permission operations [pulsar]

2024-04-25 Thread via GitHub
Technoboy- commented on PR #22547: URL: https://github.com/apache/pulsar/pull/22547#issuecomment-2078539225 > I think this should be a breaking change and we need a PIP for it. Users need to explicitly create a topic before granting the permission after this change. This doesn't seem to

Re: [PR] [fix] [broker] Part-2: Replicator can not created successfully due to an orphan replicator in the previous topic owner [pulsar]

2024-04-25 Thread via GitHub
poorbarcode commented on code in PR #21948: URL: https://github.com/apache/pulsar/pull/21948#discussion_r1580423072 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java: ## @@ -3881,9 +3895,27 @@ private void

Re: [I] [Bug] broker healthcheck ran into loop after decommissioned a cluster of bookies [pulsar]

2024-04-25 Thread via GitHub
wallacepeng commented on issue #22559: URL: https://github.com/apache/pulsar/issues/22559#issuecomment-2078544904 I finally fixed it . I have to set up another broker cluster, then did some clean up for namespace and managed-ledgers , schemas , then restore the old broker cluster, it fixed

Re: [I] [Bug] broker healthcheck ran into loop after decommissioned a cluster of bookies [pulsar]

2024-04-25 Thread via GitHub
wallacepeng closed issue #22559: [Bug] broker healthcheck ran into loop after decommissioned a cluster of bookies URL: https://github.com/apache/pulsar/issues/22559 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[PR] [improve][test] Add policy authentication test for namespace API [pulsar]

2024-04-25 Thread via GitHub
coderzc opened a new pull request, #22593: URL: https://github.com/apache/pulsar/pull/22593 Fixes #xyz Main Issue: #xyz PIP: #xyz ### Motivation & Modifications Add policy authentication test for namespace API. ###

Re: [PR] [fix][broker]One topic can be close multiple times concurrently [pulsar]

2024-04-25 Thread via GitHub
poorbarcode commented on code in PR #17524: URL: https://github.com/apache/pulsar/pull/17524#discussion_r1580420056 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java: ## @@ -1595,41 +1662,50 @@ public CompletableFuture close(

[PR] [cleanup] [test] remove useless TestAuthorizationProvider2 [pulsar]

2024-04-25 Thread via GitHub
thetumbled opened a new pull request, #22595: URL: https://github.com/apache/pulsar/pull/22595 ### Motivation `TestAuthorizationProvider2` is useless, no need to retain. ### Modifications Remove it. ### Verifying this change - [ ] Make sure that the

(pulsar) branch branch-3.2 updated: [fix][admin] Fix namespace admin api exception response (#22587)

2024-04-25 Thread zhaocong
This is an automated email from the ASF dual-hosted git repository. zhaocong pushed a commit to branch branch-3.2 in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/branch-3.2 by this push: new ea584d0b652 [fix][admin] Fix

[I] Sepcify the client version for the node client [pulsar-client-node]

2024-04-25 Thread via GitHub
RobertIndie opened a new issue, #379: URL: https://github.com/apache/pulsar-client-node/issues/379 As we have discussed [here](https://lists.apache.org/thread/n59k537fhthjnzkfxtc2p4zk4l0cv3mp) and [the PIP-254](https://github.com/apache/pulsar/issues/19705). The node client should specify

Re: [D] broker healthcheck endpoint reports No such ledger exists on Metadata Server - ledger endlessly [pulsar]

2024-04-25 Thread via GitHub
GitHub user wallacepeng closed the discussion with a comment: broker healthcheck endpoint reports No such ledger exists on Metadata Server - ledger endlessly I ended up with setting up another broker cluster, then i shutdown old broker cluster, clean up the namespaces , managed-ledgers then

Re: [D] broker healthcheck endpoint reports No such ledger exists on Metadata Server - ledger endlessly [pulsar]

2024-04-25 Thread via GitHub
GitHub user wallacepeng closed a discussion: broker healthcheck endpoint reports No such ledger exists on Metadata Server - ledger endlessly 2024-04-21T03:14:20,474+ [pulsar-io-4-7] ERROR org.apache.pulsar.client.impl.ProducerImpl -

Re: [PR] [fix][broker]One topic can be close multiple times concurrently [pulsar]

2024-04-25 Thread via GitHub
lhotari commented on PR #17524: URL: https://github.com/apache/pulsar/pull/17524#issuecomment-2078663063 @poorbarcode there are some test failures, do you have a chance to check? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [fix] [test] Fix flaky test ReplicatorTest [pulsar]

2024-04-25 Thread via GitHub
poorbarcode commented on PR #22594: URL: https://github.com/apache/pulsar/pull/22594#issuecomment-2078685982 > @poorbarcode I disabled one problematic test causing OOME in https://github.com/apache/pulsar/pull/22586 . Would it be fine to include the revert in this PR or is it better to

Re: [PR] [fix][admin] Fix namespace admin api exception response [pulsar]

2024-04-25 Thread via GitHub
Technoboy- merged PR #22587: URL: https://github.com/apache/pulsar/pull/22587 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [fix] [broker] Part-2: Replicator can not created successfully due to an orphan replicator in the previous topic owner [pulsar]

2024-04-25 Thread via GitHub
heesung-sn commented on code in PR #21948: URL: https://github.com/apache/pulsar/pull/21948#discussion_r1580453561 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java: ## @@ -3881,9 +3895,27 @@ private void fenceTopicToCloseOrDelete()

Re: [PR] [fix] [test] Fix flaky test ReplicatorTest [pulsar]

2024-04-25 Thread via GitHub
lhotari commented on PR #22594: URL: https://github.com/apache/pulsar/pull/22594#issuecomment-2078684396 @poorbarcode I disabled one problematic test causing OOME in https://github.com/apache/pulsar/pull/22586 . Would it be fine to include the revert in this PR or is it better to handle

Re: [PR] [fix] [broker] [fix] [broker] Fix metrics pulsar_topic_load_failed_count is 0 when load non-persistent topic fails and fix the flaky test testBrokerStatsTopicLoadFailed [pulsar]

2024-04-25 Thread via GitHub
dao-jun commented on code in PR #22580: URL: https://github.com/apache/pulsar/pull/22580#discussion_r1578943731 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java: ## @@ -1254,7 +1254,8 @@ private CompletableFuture>

Re: [PR] [improve][pip] PIP-347: add role field in consumer's stat [pulsar]

2024-04-25 Thread via GitHub
thetumbled commented on code in PR #22564: URL: https://github.com/apache/pulsar/pull/22564#discussion_r1578960282 ## pip/pip-347.md: ## @@ -0,0 +1,68 @@ + +# PIP-347: add role field in consumer's stat + +# Background knowledge + +- In a typical Pulsar deployment, we set

Re: [PR] [fix][broker] Reader stuck after call hasMessageAvailable when enable replicateSubscriptionState [pulsar]

2024-04-25 Thread via GitHub
dao-jun commented on code in PR #22572: URL: https://github.com/apache/pulsar/pull/22572#discussion_r1578970618 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java: ## @@ -3602,6 +3603,15 @@ public Position getLastPosition() {

(pulsar-site) branch main updated: typo fix (#890)

2024-04-25 Thread visortelle
This is an automated email from the ASF dual-hosted git repository. visortelle pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/pulsar-site.git The following commit(s) were added to refs/heads/main by this push: new 0a2cd81208b2 typo fix (#890) 0a2cd81208b2

Re: [PR] typo fix [pulsar-site]

2024-04-25 Thread via GitHub
visortelle merged PR #890: URL: https://github.com/apache/pulsar-site/pull/890 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

svn commit: r68761 - /dev/pulsar/pulsar-dotpulsar-3.2.1-rc.1/ /release/pulsar/pulsar-dotpulsar-3.2.1/

2024-04-25 Thread djensen
Author: djensen Date: Thu Apr 25 07:48:52 2024 New Revision: 68761 Log: release 3.2.1 Added: release/pulsar/pulsar-dotpulsar-3.2.1/ - copied from r68760, dev/pulsar/pulsar-dotpulsar-3.2.1-rc.1/ Removed: dev/pulsar/pulsar-dotpulsar-3.2.1-rc.1/

Re: [PR] [fix] [broker] [Namespace-level Geo-Replication] Reject a topic creation if there is a confilct topic on the remote side [pulsar]

2024-04-25 Thread via GitHub
nodece commented on code in PR #22577: URL: https://github.com/apache/pulsar/pull/22577#discussion_r1579088423 ## pulsar-broker/src/test/java/org/apache/pulsar/broker/service/OneWayReplicatorTest.java: ## @@ -652,4 +652,63 @@ public void testUnFenceTopicToReuse() throws

(pulsar) branch master updated: [improve][misc] Upgrade slf4j to 2.0.13 (#22391)

2024-04-25 Thread zixuan
This is an automated email from the ASF dual-hosted git repository. zixuan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 0c097ef2c6c [improve][misc] Upgrade slf4j to

Re: [PR] [fix] [broker] [fix] [broker] Fix metrics pulsar_topic_load_failed_count is 0 when load non-persistent topic fails and fix the flaky test testBrokerStatsTopicLoadFailed [pulsar]

2024-04-25 Thread via GitHub
dao-jun commented on code in PR #22580: URL: https://github.com/apache/pulsar/pull/22580#discussion_r1578943731 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java: ## @@ -1254,7 +1254,8 @@ private CompletableFuture>

Re: [PR] [fix][broker] Disable system topic message deduplication [pulsar]

2024-04-25 Thread via GitHub
mattisonchao closed pull request #22582: [fix][broker] Disable system topic message deduplication URL: https://github.com/apache/pulsar/pull/22582 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [D] Pulsar in Active , Active small scale Setup [pulsar]

2024-04-25 Thread via GitHub
GitHub user lhotari edited a comment on the discussion: Pulsar in Active , Active small scale Setup Assuming that this is a local redundancy setup and not about geographical redundancy where Pulsar's geo-replication would be relevant. Pulsar standalone shouldn't be considered a unit of

Re: [PR] [improve][misc] Upgrade slf4j to 2.0.13 [pulsar]

2024-04-25 Thread via GitHub
nodece merged PR #22391: URL: https://github.com/apache/pulsar/pull/22391 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [improve][pip] PIP-347: add role field in consumer's stat [pulsar]

2024-04-25 Thread via GitHub
thetumbled commented on code in PR #22564: URL: https://github.com/apache/pulsar/pull/22564#discussion_r1578960282 ## pip/pip-347.md: ## @@ -0,0 +1,68 @@ + +# PIP-347: add role field in consumer's stat + +# Background knowledge + +- In a typical Pulsar deployment, we set

Re: [PR] [fix] [broker] [Namespace-level Geo-Replication] Reject a topic creation if there is a confilct topic on the remote side [pulsar]

2024-04-25 Thread via GitHub
poorbarcode commented on PR #22577: URL: https://github.com/apache/pulsar/pull/22577#issuecomment-2076500256 Rebase master -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [fix] [broker] [Namespace-level Geo-Replication] Reject a topic creation if there is a confilct topic on the remote side [pulsar]

2024-04-25 Thread via GitHub
poorbarcode commented on code in PR #22577: URL: https://github.com/apache/pulsar/pull/22577#discussion_r1578990646 ## pulsar-broker/src/test/java/org/apache/pulsar/broker/service/OneWayReplicatorTest.java: ## @@ -652,4 +652,63 @@ public void testUnFenceTopicToReuse() throws

Re: [PR] [fix] [broker] [Namespace-level Geo-Replication] Reject a topic creation if there is a confilct topic on the remote side [pulsar]

2024-04-25 Thread via GitHub
poorbarcode commented on code in PR #22577: URL: https://github.com/apache/pulsar/pull/22577#discussion_r1578990646 ## pulsar-broker/src/test/java/org/apache/pulsar/broker/service/OneWayReplicatorTest.java: ## @@ -652,4 +652,63 @@ public void testUnFenceTopicToReuse() throws

Re: [PR] [improve][ml] Optimize read entries with skipCondition [pulsar]

2024-04-25 Thread via GitHub
dao-jun closed pull request #22560: [improve][ml] Optimize read entries with skipCondition URL: https://github.com/apache/pulsar/pull/22560 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [D] Pulsar in Active , Active small scale Setup [pulsar]

2024-04-25 Thread via GitHub
GitHub user lhotari edited a comment on the discussion: Pulsar in Active , Active small scale Setup Assuming that this is a local redundancy setup and not about geographical redundancy where Pulsar's geo-replication would be relevant. Pulsar standalone shouldn't be considered a unit of

Re: [D] Pulsar in Active , Active small scale Setup [pulsar]

2024-04-25 Thread via GitHub
GitHub user lhotari added a comment to the discussion: Pulsar in Active , Active small scale Setup Assuming that this is a local redundancy setup and not about geographical redundancy where Pulsar's geo-replication would be relevant. Pulsar standalone shouldn't be considered a unit of

Re: [PR] [fix][broker] Avoid being stuck when closing the broker with extensible load manager [pulsar]

2024-04-25 Thread via GitHub
BewareMyPower commented on PR #22573: URL: https://github.com/apache/pulsar/pull/22573#issuecomment-2076450786 > This was added to wait for some time after bundles are unloaded, but I don't think it is necessary. Agreed. We can remove it in another PR. -- This is an automated

Re: [PR] [improve][pip] PIP-347: add role field in consumer's stat [pulsar]

2024-04-25 Thread via GitHub
thetumbled commented on code in PR #22564: URL: https://github.com/apache/pulsar/pull/22564#discussion_r1578947195 ## pip/pip-347.md: ## @@ -0,0 +1,68 @@ + +# PIP-347: add role field in consumer's stat + +# Background knowledge + +- In a typical Pulsar deployment, we set

Re: [PR] [fix][broker] Reader stuck after call hasMessageAvailable when enable replicateSubscriptionState [pulsar]

2024-04-25 Thread via GitHub
dao-jun commented on code in PR #22572: URL: https://github.com/apache/pulsar/pull/22572#discussion_r1578970618 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java: ## @@ -3602,6 +3603,15 @@ public Position getLastPosition() {

Re: [PR] [improve][pip] PIP-347: add role field in consumer's stat [pulsar]

2024-04-25 Thread via GitHub
nodece commented on PR #22564: URL: https://github.com/apache/pulsar/pull/22564#issuecomment-2076517972 Leaving aside the issue above. It looks like you want to add `role` to the consumer stats, that is a good idea to track the relationship between subscriptions and users.

[PR] typo fix [pulsar-site]

2024-04-25 Thread via GitHub
JoeCqupt opened a new pull request, #890: URL: https://github.com/apache/pulsar-site/pull/890 ### ✅ Contribution Checklist - [x] I read the [contribution guide](https://pulsar.apache.org/contribute/document-contribution/) - [x] I updated the [versioned

Re: [PR] typo fix [pulsar-site]

2024-04-25 Thread via GitHub
visortelle commented on PR #890: URL: https://github.com/apache/pulsar-site/pull/890#issuecomment-2076528825 @JoeCqupt thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[PR] [fix][broker] Disable system topic message deduplication [pulsar]

2024-04-25 Thread via GitHub
mattisonchao opened a new pull request, #22582: URL: https://github.com/apache/pulsar/pull/22582 ### Motivation Disable deduplication on system topic to avoid recovering deduplication WAL (especially from offloaded topic). Because the system topic usually is a precondition to other

Re: [PR] [fix] [broker] [Namespace-level Geo-Replication] Reject a topic creation if there is a confilct topic on the remote side [pulsar]

2024-04-25 Thread via GitHub
nodece commented on code in PR #22577: URL: https://github.com/apache/pulsar/pull/22577#discussion_r1579030734 ## pulsar-broker/src/test/java/org/apache/pulsar/broker/service/OneWayReplicatorTest.java: ## @@ -652,4 +652,63 @@ public void testUnFenceTopicToReuse() throws

Re: [PR] [improve][pip] PIP-347: add role field in consumer's stat [pulsar]

2024-04-25 Thread via GitHub
thetumbled commented on code in PR #22564: URL: https://github.com/apache/pulsar/pull/22564#discussion_r1578947195 ## pip/pip-347.md: ## @@ -0,0 +1,68 @@ + +# PIP-347: add role field in consumer's stat + +# Background knowledge + +- In a typical Pulsar deployment, we set

Re: [PR] [fix][broker] Fix permission for subscription. [pulsar]

2024-04-25 Thread via GitHub
thetumbled commented on PR #22579: URL: https://github.com/apache/pulsar/pull/22579#issuecomment-2076564923 > Could you help add a test for this ? We can use this test code to reproduce issue.

Re: [PR] [fix] [broker] [Namespace-level Geo-Replication] Reject a topic creation if there is a confilct topic on the remote side [pulsar]

2024-04-25 Thread via GitHub
nodece commented on code in PR #22577: URL: https://github.com/apache/pulsar/pull/22577#discussion_r1579030734 ## pulsar-broker/src/test/java/org/apache/pulsar/broker/service/OneWayReplicatorTest.java: ## @@ -652,4 +652,63 @@ public void testUnFenceTopicToReuse() throws

Re: [PR] [fix] [broker] [Namespace-level Geo-Replication] Reject a topic creation if there is a confilct topic on the remote side [pulsar]

2024-04-25 Thread via GitHub
nodece commented on code in PR #22577: URL: https://github.com/apache/pulsar/pull/22577#discussion_r1579030734 ## pulsar-broker/src/test/java/org/apache/pulsar/broker/service/OneWayReplicatorTest.java: ## @@ -652,4 +652,63 @@ public void testUnFenceTopicToReuse() throws

Re: [PR] [fix] [broker] [Namespace-level Geo-Replication] Reject a topic creation if there is a confilct topic on the remote side [pulsar]

2024-04-25 Thread via GitHub
poorbarcode commented on code in PR #22577: URL: https://github.com/apache/pulsar/pull/22577#discussion_r1579059969 ## pulsar-broker/src/test/java/org/apache/pulsar/broker/service/OneWayReplicatorTest.java: ## @@ -652,4 +652,63 @@ public void testUnFenceTopicToReuse() throws

Re: [PR] [fix] [broker] [Namespace-level Geo-Replication] Reject a topic creation if there is a confilct topic on the remote side [pulsar]

2024-04-25 Thread via GitHub
poorbarcode commented on code in PR #22577: URL: https://github.com/apache/pulsar/pull/22577#discussion_r1579059969 ## pulsar-broker/src/test/java/org/apache/pulsar/broker/service/OneWayReplicatorTest.java: ## @@ -652,4 +652,63 @@ public void testUnFenceTopicToReuse() throws

Re: [PR] [fix] [broker] [Namespace-level Geo-Replication] Reject a topic creation if there is a confilct topic on the remote side [pulsar]

2024-04-25 Thread via GitHub
poorbarcode commented on code in PR #22577: URL: https://github.com/apache/pulsar/pull/22577#discussion_r1579099569 ## pulsar-broker/src/test/java/org/apache/pulsar/broker/service/OneWayReplicatorTest.java: ## @@ -652,4 +652,63 @@ public void testUnFenceTopicToReuse() throws

Re: [PR] [pulsar-broker] schedule one add/read timeout task per ml/topic [pulsar]

2024-04-25 Thread via GitHub
dao-jun commented on PR #4111: URL: https://github.com/apache/pulsar/pull/4111#issuecomment-2076515656 @rdhabalia Hi, I noticed we only introduced a single `lastReadCallback` field to store the ongoing read operations, does it mean we only check the last read operation is timeout or not?

Re: [PR] [fix] [broker] [Namespace-level Geo-Replication] Reject a topic creation if there is a confilct topic on the remote side [pulsar]

2024-04-25 Thread via GitHub
poorbarcode commented on code in PR #22577: URL: https://github.com/apache/pulsar/pull/22577#discussion_r1579059969 ## pulsar-broker/src/test/java/org/apache/pulsar/broker/service/OneWayReplicatorTest.java: ## @@ -652,4 +652,63 @@ public void testUnFenceTopicToReuse() throws

[PR] [improve][meta] Fix invalid use of drain API and race condition in closing metadata store [pulsar]

2024-04-25 Thread via GitHub
lhotari opened a new pull request, #22585: URL: https://github.com/apache/pulsar/pull/22585 ### Motivation There's currently some memory leaks in tests and while investigating the issue, I found out that there's a large number of uncompleted CompletableFutures in the heap dump.

[PR] [fix][test] Clear fields in test cleanup to reduce memory consumption [pulsar]

2024-04-25 Thread via GitHub
lhotari opened a new pull request, #22583: URL: https://github.com/apache/pulsar/pull/22583 ### Motivation - TestNG keeps a reference to the test instance and this will cause a OOME in some cases

[PR] [fix][broker] Fix geo-replication admin client url [pulsar]

2024-04-25 Thread via GitHub
Demogorgon314 opened a new pull request, #22584: URL: https://github.com/apache/pulsar/pull/22584 ### Motivation When we only set the TLS URLs for `ClusterData` and set the `brokerClientTlsEnabled` to `true`, the admin client for geo-replication will be failed to create because the

Re: [PR] [fix][broker] Fix BufferOverflowException and EOFException bugs in /metrics gzip compression [pulsar]

2024-04-25 Thread via GitHub
lhotari merged PR #22576: URL: https://github.com/apache/pulsar/pull/22576 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [I] [Bug] /metrics gzip compression sporadically fails with error 500 caused by java.nio.BufferOverflowException [pulsar]

2024-04-25 Thread via GitHub
lhotari closed issue #22575: [Bug] /metrics gzip compression sporadically fails with error 500 caused by java.nio.BufferOverflowException URL: https://github.com/apache/pulsar/issues/22575 -- This is an automated message from the Apache Git Service. To respond to the message, please log on

(pulsar) branch master updated: [fix][broker] Fix BufferOverflowException and EOFException bugs in /metrics gzip compression (#22576)

2024-04-25 Thread lhotari
This is an automated email from the ASF dual-hosted git repository. lhotari pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 997c8b95e17 [fix][broker] Fix

Re: [PR] [fix] [broker] [Namespace-level Geo-Replication] Reject a topic creation if there is a confilct topic on the remote side [pulsar]

2024-04-25 Thread via GitHub
nodece commented on code in PR #22577: URL: https://github.com/apache/pulsar/pull/22577#discussion_r1579136424 ## pulsar-broker/src/test/java/org/apache/pulsar/broker/service/OneWayReplicatorTest.java: ## @@ -652,4 +652,63 @@ public void testUnFenceTopicToReuse() throws

Re: [PR] [fix][broker] Fix BufferOverflowException and EOFException bugs in /metrics gzip compression [pulsar]

2024-04-25 Thread via GitHub
codecov-commenter commented on PR #22576: URL: https://github.com/apache/pulsar/pull/22576#issuecomment-2076880246 ## [Codecov](https://app.codecov.io/gh/apache/pulsar/pull/22576?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report

(pulsar) branch branch-3.2 updated: [fix][broker] Fix BufferOverflowException and EOFException bugs in /metrics gzip compression (#22576)

2024-04-25 Thread lhotari
This is an automated email from the ASF dual-hosted git repository. lhotari pushed a commit to branch branch-3.2 in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/branch-3.2 by this push: new c6e58b0f0eb [fix][broker] Fix

(pulsar) branch branch-2.11 updated: [fix][broker] Fix BufferOverflowException and EOFException bugs in /metrics gzip compression (#22576)

2024-04-25 Thread lhotari
This is an automated email from the ASF dual-hosted git repository. lhotari pushed a commit to branch branch-2.11 in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/branch-2.11 by this push: new 0ef7bd2dcb3 [fix][broker] Fix

(pulsar) branch branch-3.1 updated: [fix][broker] Fix BufferOverflowException and EOFException bugs in /metrics gzip compression (#22576)

2024-04-25 Thread lhotari
This is an automated email from the ASF dual-hosted git repository. lhotari pushed a commit to branch branch-3.1 in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/branch-3.1 by this push: new fe05e089c97 [fix][broker] Fix

(pulsar) branch branch-3.0 updated: [fix][broker] Fix BufferOverflowException and EOFException bugs in /metrics gzip compression (#22576)

2024-04-25 Thread lhotari
This is an automated email from the ASF dual-hosted git repository. lhotari pushed a commit to branch branch-3.0 in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/branch-3.0 by this push: new d017030b232 [fix][broker] Fix

(pulsar-dotpulsar) branch master updated: Updated NuGet package

2024-04-25 Thread blankensteiner
This is an automated email from the ASF dual-hosted git repository. blankensteiner pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar-dotpulsar.git The following commit(s) were added to refs/heads/master by this push: new a3d6825 Updated NuGet

Re: [PR] [improve][meta] Fix invalid use of drain API and race condition in closing metadata store [pulsar]

2024-04-25 Thread via GitHub
lhotari commented on PR #22585: URL: https://github.com/apache/pulsar/pull/22585#issuecomment-2077333078 It seems that the OOME is another issue. https://github.com/apache/pulsar/pull/22586 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [I] PostgreSQL sink connector doesn't persist message to table [pulsar]

2024-04-25 Thread via GitHub
alexandrebrilhante closed issue #22543: PostgreSQL sink connector doesn't persist message to table URL: https://github.com/apache/pulsar/issues/22543 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [I] PostgreSQL sink connector doesn't persist message to table [pulsar]

2024-04-25 Thread via GitHub
alexandrebrilhante commented on issue #22543: URL: https://github.com/apache/pulsar/issues/22543#issuecomment-2077396425 Looks I was trying to persist `{"id" 1, "name" "abcdefg"}` as opposed to just `{"name" "abcdefg"}` as expected by the sink connector. -- This is an automated message

Re: [I] PostgreSQL sink connector doesn't persist message to table [pulsar]

2024-04-25 Thread via GitHub
alexandrebrilhante commented on issue #22543: URL: https://github.com/apache/pulsar/issues/22543#issuecomment-2077310495 Seems to be related to the schema Postgres is using which is weird I'm using the same schema as the getting started example for Pulsar IO. ```log

Re: [PR] [fix] [broker] Part-2: Replicator can not created successfully due to an orphan replicator in the previous topic owner [pulsar]

2024-04-25 Thread via GitHub
lhotari commented on PR #21948: URL: https://github.com/apache/pulsar/pull/21948#issuecomment-2077417174 @poorbarcode I wonder if these changes somehow cause OOME problems with org.apache.pulsar.broker.service.ReplicatorSubscriptionTest#testWriteMarkerTaskOfReplicateSubscriptions, please

Re: [PR] [improve][ci] Disable test that causes OOME until the problem has been resolved [pulsar]

2024-04-25 Thread via GitHub
lhotari commented on PR #22586: URL: https://github.com/apache/pulsar/pull/22586#issuecomment-2077437609 There are a few recent replicator related changes #21946, #21948 and #22537 . @poorbarcode please check if one of the changes is triggering the OOME issue possibly related to deletion.

[PR] [improve][ci] Disable test that causes OOME until the problem has been resolved [pulsar]

2024-04-25 Thread via GitHub
lhotari opened a new pull request, #22586: URL: https://github.com/apache/pulsar/pull/22586 ### Motivation Unit test group 1 fails often with OOME. ### Modifications The issue is most like related to https://github.com/apache/pulsar/pull/21495 and

Re: [PR] [improve][ci] Disable test that causes OOME until the problem has been resolved [pulsar]

2024-04-25 Thread via GitHub
lhotari commented on PR #22586: URL: https://github.com/apache/pulsar/pull/22586#issuecomment-2077351106 In one of the heap dumps, there was 251,029 lambdas which all reference a `__change_events` topic. ```sql select this['arg$2.completeTopicName'], count(*) from

Re: [PR] [fix][broker] Reader stuck after call hasMessageAvailable when enable replicateSubscriptionState [pulsar]

2024-04-25 Thread via GitHub
shibd commented on code in PR #22572: URL: https://github.com/apache/pulsar/pull/22572#discussion_r1579492679 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java: ## @@ -3602,6 +3603,15 @@ public Position getLastPosition() {

Re: [PR] [improve][ci] Disable test that causes OOME until the problem has been resolved [pulsar]

2024-04-25 Thread via GitHub
lhotari commented on PR #22586: URL: https://github.com/apache/pulsar/pull/22586#issuecomment-2077363787 In another heapdump ```sql select this['arg$2.completeTopicName'], count(*) from

Re: [PR] [fix][admin] Fix namespace admin api exception response [pulsar]

2024-04-25 Thread via GitHub
Technoboy- commented on code in PR #22587: URL: https://github.com/apache/pulsar/pull/22587#discussion_r1579694026 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/NamespacesBase.java: ## @@ -2125,9 +2125,10 @@ protected CompletableFuture

Re: [PR] [fix][admin] Fix namespace admin api exception response [pulsar]

2024-04-25 Thread via GitHub
coderzc commented on code in PR #22587: URL: https://github.com/apache/pulsar/pull/22587#discussion_r1579703993 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/NamespacesBase.java: ## @@ -2125,9 +2125,10 @@ protected CompletableFuture

  1   2   >