[GitHub] [tvm] quic-sanirudh commented on pull request #9315: [TensorIR][Tutorial] Blitz course

2021-10-22 Thread GitBox
quic-sanirudh commented on pull request #9315: URL: https://github.com/apache/tvm/pull/9315#issuecomment-950078661 > I agree with @quic-sanirudh that printing things as T by default might be better. We can do that as a separate PR Thanks for the reply and confirmation @tqchen.

[GitHub] [tvm] masahi commented on issue #9349: [Torch, CI] Upgrade to PyTorch 1.10

2021-10-22 Thread GitBox
masahi commented on issue #9349: URL: https://github.com/apache/tvm/issues/9349#issuecomment-950078067 With some simple fix, MaskRCNN can be correctly converted to Relay and pass the test. Other tests are also looking good, only less than five of them are broken but seems easy to fix:

[GitHub] [tvm] masahi edited a comment on issue #9349: [Torch, CI] Upgrade to PyTorch 1.10

2021-10-22 Thread GitBox
masahi edited a comment on issue #9349: URL: https://github.com/apache/tvm/issues/9349#issuecomment-950044958 ~~Tracing MaskRCNN is broken with this release https://github.com/pytorch/vision/issues/4158#issuecomment-950043269~~ cc @hgt312 UPDATE: If I import PyTorch before

[GitHub] [tvm] masahi edited a comment on issue #9349: [Torch, CI] Upgrade to PyTorch 1.10

2021-10-22 Thread GitBox
masahi edited a comment on issue #9349: URL: https://github.com/apache/tvm/issues/9349#issuecomment-950044958 ~~Tracing MaskRCNN is broken with this release https://github.com/pytorch/vision/issues/4158#issuecomment-950043269~~ cc @hgt312 UPDATE: If I import PyTorch before

[GitHub] [tvm] masahi commented on issue #9349: [Torch, CI] Upgrade to PyTorch 1.10

2021-10-22 Thread GitBox
masahi commented on issue #9349: URL: https://github.com/apache/tvm/issues/9349#issuecomment-950044958 Tracing MaskRCNN is broken with this release https://github.com/pytorch/vision/issues/4158#issuecomment-950043269 cc @hgt312 -- This is an automated message from the Apache Git

[GitHub] [tvm] hogepodge commented on pull request #9281: [Tutorial] Fix formatting, grammar, dead link

2021-10-22 Thread GitBox
hogepodge commented on pull request #9281: URL: https://github.com/apache/tvm/pull/9281#issuecomment-950030079  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[tvm] branch main updated (bb5e653 -> 6219d19)

2021-10-22 Thread masahi
This is an automated email from the ASF dual-hosted git repository. masahi pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/tvm.git. from bb5e653 [Tutorial] Fix formatting, grammar, dead link (#9281) add 6219d19 [Caffe Frontend] Add support for Embed

[GitHub] [tvm] masahi merged pull request #9257: [Caffe Frontend] Add support for Embed layer

2021-10-22 Thread GitBox
masahi merged pull request #9257: URL: https://github.com/apache/tvm/pull/9257 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[tvm] branch main updated (1526ad1 -> bb5e653)

2021-10-22 Thread masahi
This is an automated email from the ASF dual-hosted git repository. masahi pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/tvm.git. from 1526ad1 [UnitTest][Flaky] In test_report_serialization, compare csv. (#9275) add bb5e653 [Tutorial] Fix

[GitHub] [tvm] masahi merged pull request #9281: [Tutorial] Fix formatting, grammar, dead link

2021-10-22 Thread GitBox
masahi merged pull request #9281: URL: https://github.com/apache/tvm/pull/9281 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [tvm] anwang2009 opened a new pull request #9357: Draft: Add pass to fold type transformations into function signature

2021-10-22 Thread GitBox
anwang2009 opened a new pull request #9357: URL: https://github.com/apache/tvm/pull/9357 As title. This transformer gives users more control over where preprocessing steps may be located, and what input types their relay program can accept -- This is an automated message from the

[GitHub] [tvm] mehrdadh commented on a change in pull request #9274: [microTVM] Add platform version check to template project

2021-10-22 Thread GitBox
mehrdadh commented on a change in pull request #9274: URL: https://github.com/apache/tvm/pull/9274#discussion_r734892831 ## File path: apps/microtvm/arduino/template_project/microtvm_api_server.py ## @@ -275,7 +286,25 @@ def _find_modified_include_path(self, project_dir,

[GitHub] [tvm] mehrdadh commented on a change in pull request #9274: [microTVM] Add platform version check to template project

2021-10-22 Thread GitBox
mehrdadh commented on a change in pull request #9274: URL: https://github.com/apache/tvm/pull/9274#discussion_r734892831 ## File path: apps/microtvm/arduino/template_project/microtvm_api_server.py ## @@ -275,7 +286,25 @@ def _find_modified_include_path(self, project_dir,

[GitHub] [tvm] AndrewZhaoLuo edited a comment on pull request #9336: [Topi][Op][PyTorch][Vitas] Fix inconsistent kernel layout conventions for conv2d_transpose

2021-10-22 Thread GitBox
AndrewZhaoLuo edited a comment on pull request #9336: URL: https://github.com/apache/tvm/pull/9336#issuecomment-950006190 I think in general, `I = the dimension that will change when we expect the input channels to change`. `O = the dimension that will change when we expect the output

[GitHub] [tvm] AndrewZhaoLuo commented on pull request #9336: [Topi][Op][PyTorch][Vitas] Fix inconsistent kernel layout conventions for conv2d_transpose

2021-10-22 Thread GitBox
AndrewZhaoLuo commented on pull request #9336: URL: https://github.com/apache/tvm/pull/9336#issuecomment-950006190 I think in general, `I = the dimension that will change when we expect the input channels to change`. `O = the dimension that will change when we expect the output channels

[GitHub] [tvm] mbrookhart commented on pull request #9336: [Topi][Op][PyTorch][Vitas] Fix inconsistent kernel layout conventions for conv2d_transpose

2021-10-22 Thread GitBox
mbrookhart commented on pull request #9336: URL: https://github.com/apache/tvm/pull/9336#issuecomment-94485 @masahi Perhaps you or someone you know has a better sense of framework conventions here than I do? -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [tvm] mbrookhart edited a comment on pull request #9336: [Topi][Op][PyTorch][Vitas] Fix inconsistent kernel layout conventions for conv2d_transpose

2021-10-22 Thread GitBox
mbrookhart edited a comment on pull request #9336: URL: https://github.com/apache/tvm/pull/9336#issuecomment-94485 @masahi Perhaps you or someone you know has a better sense of framework conventions here than I do? I'm not sure if there's a common representation here. -- This is an

[GitHub] [tvm] gromero commented on pull request #9320: [microTVM] Arduino: Fix MLF archive filename in generated project dir

2021-10-22 Thread GitBox
gromero commented on pull request #9320: URL: https://github.com/apache/tvm/pull/9320#issuecomment-949975658 @guberti Thanks for the review. Yes, please, if you can crack it it would cool. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [tvm] mbs-octoml commented on a change in pull request #9246: [Relay] Introduce Executor and Runtime representations with associated registries

2021-10-22 Thread GitBox
mbs-octoml commented on a change in pull request #9246: URL: https://github.com/apache/tvm/pull/9246#discussion_r734852692 ## File path: src/relay/backend/executor.cc ## @@ -0,0 +1,110 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

[tvm] branch main updated (4fb6fa5 -> 1526ad1)

2021-10-22 Thread masahi
This is an automated email from the ASF dual-hosted git repository. masahi pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/tvm.git. from 4fb6fa5 [Frontend][PaddlePaddle] Add autopad for conv/pool (#9295) add 1526ad1 [UnitTest][Flaky] In

[GitHub] [tvm] masahi merged pull request #9275: [UnitTest][Flaky] In test_report_serialization, compare csv.

2021-10-22 Thread GitBox
masahi merged pull request #9275: URL: https://github.com/apache/tvm/pull/9275 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[tvm] branch main updated (e830a1f -> 4fb6fa5)

2021-10-22 Thread masahi
This is an automated email from the ASF dual-hosted git repository. masahi pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/tvm.git. from e830a1f [Code Style] Changed code to match the tvm code style conventions. (#9040) add 4fb6fa5

[GitHub] [tvm] masahi merged pull request #9295: [Frontend][PaddlePaddle] Add autopad for conv/pool

2021-10-22 Thread GitBox
masahi merged pull request #9295: URL: https://github.com/apache/tvm/pull/9295 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[tvm] branch main updated (6ef1c2a -> e830a1f)

2021-10-22 Thread masahi
This is an automated email from the ASF dual-hosted git repository. masahi pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/tvm.git. from 6ef1c2a [CORE][Relay] Swap and remove compile_engine with te_compiler followup of #8775 (#9282) add e830a1f [Code

[GitHub] [tvm] masahi merged pull request #9040: [Code Style] Changed code to match the tvm code style conventions.

2021-10-22 Thread GitBox
masahi merged pull request #9040: URL: https://github.com/apache/tvm/pull/9040 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [tvm] masahi commented on pull request #9255: Fix inconsistencies in graph_executor function names handling

2021-10-22 Thread GitBox
masahi commented on pull request #9255: URL: https://github.com/apache/tvm/pull/9255#issuecomment-949964836 @PhilippvK please fix the conflict. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[tvm] branch main updated (f0efecc -> 6ef1c2a)

2021-10-22 Thread masahi
This is an automated email from the ASF dual-hosted git repository. masahi pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/tvm.git. from f0efecc [microTVM][Zephyr] Enable RISCV Tests on QEMU CI (#9325) add 6ef1c2a [CORE][Relay] Swap and remove

[GitHub] [tvm] guberti commented on a change in pull request #9274: [microTVM] Add platform version check to template project

2021-10-22 Thread GitBox
guberti commented on a change in pull request #9274: URL: https://github.com/apache/tvm/pull/9274#discussion_r734846374 ## File path: apps/microtvm/arduino/template_project/microtvm_api_server.py ## @@ -335,7 +337,23 @@ def _find_modified_include_path(self, project_dir,

[GitHub] [tvm] masahi merged pull request #9282: [CORE][Relay] Swap and remove compile_engine with te_compiler followup of #8775

2021-10-22 Thread GitBox
masahi merged pull request #9282: URL: https://github.com/apache/tvm/pull/9282 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [tvm] areusch commented on pull request #9288: [Rust][Doc] Re-enable the building and copying of Rust documentation.

2021-10-22 Thread GitBox
areusch commented on pull request #9288: URL: https://github.com/apache/tvm/pull/9288#issuecomment-949960809 @jroesch seems like it's failing to find the CI-unpacked build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[tvm] branch main updated (d34a632 -> f0efecc)

2021-10-22 Thread areusch
This is an automated email from the ASF dual-hosted git repository. areusch pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/tvm.git. from d34a632 Support dynamic shape searchsorted (#9348) add f0efecc [microTVM][Zephyr] Enable RISCV Tests on QEMU CI

[GitHub] [tvm] areusch merged pull request #9325: [microTVM][Zephyr] Enable RISCV Tests on QEMU CI

2021-10-22 Thread GitBox
areusch merged pull request #9325: URL: https://github.com/apache/tvm/pull/9325 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [tvm] areusch commented on a change in pull request #9325: [microTVM][Zephyr] Enable RISCV Tests on QEMU CI

2021-10-22 Thread GitBox
areusch commented on a change in pull request #9325: URL: https://github.com/apache/tvm/pull/9325#discussion_r734832991 ## File path: tests/micro/zephyr/test_zephyr_aot.py ## @@ -55,8 +57,8 @@ def test_tflite(temp_dir, board, west_cmd, tvm_debug): output_shape = (1, 10)

[GitHub] [tvm] mehrdadh commented on a change in pull request #9325: [microTVM][Zephyr] Enable RISCV Tests on QEMU CI

2021-10-22 Thread GitBox
mehrdadh commented on a change in pull request #9325: URL: https://github.com/apache/tvm/pull/9325#discussion_r734832401 ## File path: tests/micro/zephyr/test_zephyr_aot.py ## @@ -55,8 +57,8 @@ def test_tflite(temp_dir, board, west_cmd, tvm_debug): output_shape = (1, 10)

[GitHub] [tvm] csullivan opened a new pull request #9356: [Hexagon] Launcher modifications to make use of the new device API

2021-10-22 Thread GitBox
csullivan opened a new pull request #9356: URL: https://github.com/apache/tvm/pull/9356 These changes enable the use of the new hexagon device api in the hexagon launcher. Changes include, * Using a new module loader `loadfile_hexagon` * Using a customized linked params

[GitHub] [tvm] mehrdadh commented on pull request #9325: [microTVM][Zephyr] Enable RISCV Tests on QEMU CI

2021-10-22 Thread GitBox
mehrdadh commented on pull request #9325: URL: https://github.com/apache/tvm/pull/9325#issuecomment-949947620 disabled the fpu tests for riscv32 because of this issue: https://github.com/zephyrproject-rtos/zephyr/issues/34026 we can add it when we upgrade to Zephyr 2.6. -- This

[GitHub] [tvm] areusch commented on a change in pull request #9325: [microTVM][Zephyr] Enable RISCV Tests on QEMU CI

2021-10-22 Thread GitBox
areusch commented on a change in pull request #9325: URL: https://github.com/apache/tvm/pull/9325#discussion_r734831407 ## File path: tests/micro/zephyr/test_zephyr_aot.py ## @@ -55,8 +57,8 @@ def test_tflite(temp_dir, board, west_cmd, tvm_debug): output_shape = (1, 10)

[tvm] branch main updated (982e8e5 -> d34a632)

2021-10-22 Thread wuwei
This is an automated email from the ASF dual-hosted git repository. wuwei pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/tvm.git. from 982e8e5 [Hexagon] Fix cmake files for Hexagon launcher (#9343) add d34a632 Support dynamic shape searchsorted

[GitHub] [tvm] vinx13 merged pull request #9348: [Relay] Support dynamic shape searchsorted

2021-10-22 Thread GitBox
vinx13 merged pull request #9348: URL: https://github.com/apache/tvm/pull/9348 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [tvm] manupa-arm commented on a change in pull request #9331: [4/10] Code generation for Conv2D via CMSIS-NN

2021-10-22 Thread GitBox
manupa-arm commented on a change in pull request #9331: URL: https://github.com/apache/tvm/pull/9331#discussion_r734824425 ## File path: src/relay/backend/contrib/cmsisnn/extract_constants.cc ## @@ -0,0 +1,158 @@ + +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [tvm] manupa-arm commented on a change in pull request #9323: Fix Arm(R) Ethos(TM)-U55 NPU Demo app

2021-10-22 Thread GitBox
manupa-arm commented on a change in pull request #9323: URL: https://github.com/apache/tvm/pull/9323#discussion_r73482 ## File path: tests/scripts/task_cpp_unittest.sh ## @@ -45,3 +45,11 @@ cd apps/bundle_deploy rm -rf build make test_dynamic test_static cd ../.. + +#

[GitHub] [tvm] grant-arm commented on a change in pull request #9323: Fix Arm(R) Ethos(TM)-U55 NPU Demo app

2021-10-22 Thread GitBox
grant-arm commented on a change in pull request #9323: URL: https://github.com/apache/tvm/pull/9323#discussion_r734814235 ## File path: tests/scripts/task_cpp_unittest.sh ## @@ -45,3 +45,11 @@ cd apps/bundle_deploy rm -rf build make test_dynamic test_static cd ../.. + +#

[GitHub] [tvm] grant-arm commented on a change in pull request #9323: Fix Arm(R) Ethos(TM)-U55 NPU Demo app

2021-10-22 Thread GitBox
grant-arm commented on a change in pull request #9323: URL: https://github.com/apache/tvm/pull/9323#discussion_r734810451 ## File path: tests/scripts/task_cpp_unittest.sh ## @@ -45,3 +45,11 @@ cd apps/bundle_deploy rm -rf build make test_dynamic test_static cd ../.. + +#

[GitHub] [tvm] grant-arm commented on a change in pull request #9323: Fix Arm(R) Ethos(TM)-U55 NPU Demo app

2021-10-22 Thread GitBox
grant-arm commented on a change in pull request #9323: URL: https://github.com/apache/tvm/pull/9323#discussion_r734808813 ## File path: tests/scripts/task_cpp_unittest.sh ## @@ -45,3 +45,11 @@ cd apps/bundle_deploy rm -rf build make test_dynamic test_static cd ../.. + +#

[GitHub] [tvm] grant-arm commented on a change in pull request #9323: Fix Arm(R) Ethos(TM)-U55 NPU Demo app

2021-10-22 Thread GitBox
grant-arm commented on a change in pull request #9323: URL: https://github.com/apache/tvm/pull/9323#discussion_r734808669 ## File path: tests/scripts/task_cpp_unittest.sh ## @@ -45,3 +45,11 @@ cd apps/bundle_deploy rm -rf build make test_dynamic test_static cd ../.. + +#

[GitHub] [tvm] grant-arm commented on a change in pull request #9323: Fix Arm(R) Ethos(TM)-U55 NPU Demo app

2021-10-22 Thread GitBox
grant-arm commented on a change in pull request #9323: URL: https://github.com/apache/tvm/pull/9323#discussion_r734808401 ## File path: tests/scripts/task_cpp_unittest.sh ## @@ -45,3 +45,11 @@ cd apps/bundle_deploy rm -rf build make test_dynamic test_static cd ../.. + +#

[GitHub] [tvm] Mousius commented on a change in pull request #9331: [4/10] Code generation for Conv2D via CMSIS-NN

2021-10-22 Thread GitBox
Mousius commented on a change in pull request #9331: URL: https://github.com/apache/tvm/pull/9331#discussion_r734802864 ## File path: src/relay/backend/contrib/cmsisnn/extract_constants.cc ## @@ -0,0 +1,158 @@ + +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [tvm] Mousius commented on a change in pull request #9331: [4/10] Code generation for Conv2D via CMSIS-NN

2021-10-22 Thread GitBox
Mousius commented on a change in pull request #9331: URL: https://github.com/apache/tvm/pull/9331#discussion_r734802676 ## File path: src/relay/backend/contrib/cmsisnn/extract_constants.cc ## @@ -0,0 +1,158 @@ + +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [tvm] Mousius commented on a change in pull request #9323: Fix Arm(R) Ethos(TM)-U55 NPU Demo app

2021-10-22 Thread GitBox
Mousius commented on a change in pull request #9323: URL: https://github.com/apache/tvm/pull/9323#discussion_r734801979 ## File path: tests/scripts/task_cpp_unittest.sh ## @@ -45,3 +45,11 @@ cd apps/bundle_deploy rm -rf build make test_dynamic test_static cd ../.. + +# Test

[GitHub] [tvm] grant-arm commented on a change in pull request #9323: Fix Arm(R) Ethos(TM)-U55 NPU Demo app

2021-10-22 Thread GitBox
grant-arm commented on a change in pull request #9323: URL: https://github.com/apache/tvm/pull/9323#discussion_r734799137 ## File path: tests/scripts/task_cpp_unittest.sh ## @@ -45,3 +45,11 @@ cd apps/bundle_deploy rm -rf build make test_dynamic test_static cd ../.. + +#

[GitHub] [tvm] grant-arm commented on a change in pull request #9323: Fix Arm(R) Ethos(TM)-U55 NPU Demo app

2021-10-22 Thread GitBox
grant-arm commented on a change in pull request #9323: URL: https://github.com/apache/tvm/pull/9323#discussion_r734797871 ## File path: apps/microtvm/ethosu/run_demo.sh ## @@ -79,6 +83,30 @@ while (( $# )); do fi ;; +--fvp_path) +

[GitHub] [tvm] manupa-arm commented on a change in pull request #9331: [4/10] Code generation for Conv2D via CMSIS-NN

2021-10-22 Thread GitBox
manupa-arm commented on a change in pull request #9331: URL: https://github.com/apache/tvm/pull/9331#discussion_r734793206 ## File path: src/relay/backend/contrib/cmsisnn/extract_constants.cc ## @@ -0,0 +1,158 @@ + +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [tvm] manupa-arm commented on a change in pull request #9331: [4/10] Code generation for Conv2D via CMSIS-NN

2021-10-22 Thread GitBox
manupa-arm commented on a change in pull request #9331: URL: https://github.com/apache/tvm/pull/9331#discussion_r734793206 ## File path: src/relay/backend/contrib/cmsisnn/extract_constants.cc ## @@ -0,0 +1,158 @@ + +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [tvm] Mousius commented on a change in pull request #9331: [4/10] Code generation for Conv2D via CMSIS-NN

2021-10-22 Thread GitBox
Mousius commented on a change in pull request #9331: URL: https://github.com/apache/tvm/pull/9331#discussion_r734787732 ## File path: src/relay/backend/contrib/cmsisnn/extract_constants.cc ## @@ -0,0 +1,158 @@ + +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [tvm] Mousius commented on a change in pull request #9331: [4/10] Code generation for Conv2D via CMSIS-NN

2021-10-22 Thread GitBox
Mousius commented on a change in pull request #9331: URL: https://github.com/apache/tvm/pull/9331#discussion_r734787732 ## File path: src/relay/backend/contrib/cmsisnn/extract_constants.cc ## @@ -0,0 +1,158 @@ + +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [tvm] Raghav-Chakravarthy commented on pull request #9040: [Code Style] Changed code to match the tvm code style conventions.

2021-10-22 Thread GitBox
Raghav-Chakravarthy commented on pull request #9040: URL: https://github.com/apache/tvm/pull/9040#issuecomment-949899771 @areusch @mbrookhart - Please take a look at my PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [tvm] Mousius commented on a change in pull request #9331: [4/10] Code generation for Conv2D via CMSIS-NN

2021-10-22 Thread GitBox
Mousius commented on a change in pull request #9331: URL: https://github.com/apache/tvm/pull/9331#discussion_r734786945 ## File path: src/relay/backend/contrib/cmsisnn/extract_constants.cc ## @@ -0,0 +1,158 @@ + +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [tvm] Mousius commented on a change in pull request #9323: Fix Arm(R) Ethos(TM)-U55 NPU Demo app

2021-10-22 Thread GitBox
Mousius commented on a change in pull request #9323: URL: https://github.com/apache/tvm/pull/9323#discussion_r734785216 ## File path: tests/scripts/task_cpp_unittest.sh ## @@ -45,3 +45,11 @@ cd apps/bundle_deploy rm -rf build make test_dynamic test_static cd ../.. + +# Test

[GitHub] [tvm] grant-arm commented on a change in pull request #9323: Fix Arm(R) Ethos(TM)-U55 NPU Demo app

2021-10-22 Thread GitBox
grant-arm commented on a change in pull request #9323: URL: https://github.com/apache/tvm/pull/9323#discussion_r734781948 ## File path: tests/scripts/task_cpp_unittest.sh ## @@ -45,3 +45,11 @@ cd apps/bundle_deploy rm -rf build make test_dynamic test_static cd ../.. + +#

[GitHub] [tvm] AndrewZhaoLuo commented on a change in pull request #9329: [Relay/TOPI][ONNX/TFLite] Refactor MATRIX_SET_DIAG Operator for Relay…

2021-10-22 Thread GitBox
AndrewZhaoLuo commented on a change in pull request #9329: URL: https://github.com/apache/tvm/pull/9329#discussion_r734781762 ## File path: include/tvm/topi/transform.h ## @@ -1776,12 +1775,10 @@ inline Tensor matrix_set_diag(const Tensor& input, const Tensor& diagonal, int k

[GitHub] [tvm] Mousius commented on a change in pull request #9323: Fix Arm(R) Ethos(TM)-U55 NPU Demo app

2021-10-22 Thread GitBox
Mousius commented on a change in pull request #9323: URL: https://github.com/apache/tvm/pull/9323#discussion_r734780326 ## File path: tests/scripts/task_cpp_unittest.sh ## @@ -45,3 +45,11 @@ cd apps/bundle_deploy rm -rf build make test_dynamic test_static cd ../.. + +# Test

[GitHub] [tvm] Mousius commented on a change in pull request #9323: Fix Arm(R) Ethos(TM)-U55 NPU Demo app

2021-10-22 Thread GitBox
Mousius commented on a change in pull request #9323: URL: https://github.com/apache/tvm/pull/9323#discussion_r734776847 ## File path: tests/scripts/task_cpp_unittest.sh ## @@ -45,3 +45,11 @@ cd apps/bundle_deploy rm -rf build make test_dynamic test_static cd ../.. + +# Test

[GitHub] [tvm] tqchen edited a comment on pull request #9315: [TensorIR][Tutorial] Blitz course

2021-10-22 Thread GitBox
tqchen edited a comment on pull request #9315: URL: https://github.com/apache/tvm/pull/9315#issuecomment-949873841 I agree with @quic-sanirudh that printing things as T by default might be better. We can do that as a separate PR -- This is an automated message from the Apache Git

[GitHub] [tvm] tqchen commented on pull request #9315: [TensorIR][Tutorial] Blitz course

2021-10-22 Thread GitBox
tqchen commented on pull request #9315: URL: https://github.com/apache/tvm/pull/9315#issuecomment-949873841 I agree with @quic-sanirudh that printing things as T might be better. We can do that as a separate PR -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [tvm] shingjan commented on a change in pull request #9306: [TIR] Add structural error printing for TensorIR

2021-10-22 Thread GitBox
shingjan commented on a change in pull request #9306: URL: https://github.com/apache/tvm/pull/9306#discussion_r734764312 ## File path: src/printer/tvmscript_printer.cc ## @@ -1049,15 +1068,24 @@ Doc TVMScriptPrinter::PrintBlockBody(const BlockNode* op) { return body; }

[tvm] branch main updated (d5dd8c0 -> 982e8e5)

2021-10-22 Thread kparzysz
This is an automated email from the ASF dual-hosted git repository. kparzysz pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/tvm.git. from d5dd8c0 Disable Hexagon TestConv2dPackedFilter test (#9344) add 982e8e5 [Hexagon] Fix cmake files for Hexagon

[GitHub] [tvm] kparzysz-quic merged pull request #9343: [Hexagon] Fix cmake files for Hexagon launcher

2021-10-22 Thread GitBox
kparzysz-quic merged pull request #9343: URL: https://github.com/apache/tvm/pull/9343 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [tvm] shingjan commented on a change in pull request #9306: [TIR] Add structural error printing for TensorIR

2021-10-22 Thread GitBox
shingjan commented on a change in pull request #9306: URL: https://github.com/apache/tvm/pull/9306#discussion_r734757692 ## File path: src/printer/tvmscript_printer.cc ## @@ -1049,15 +1068,24 @@ Doc TVMScriptPrinter::PrintBlockBody(const BlockNode* op) { return body; }

[GitHub] [tvm] shingjan commented on a change in pull request #9306: [TIR] Add structural error printing for TensorIR

2021-10-22 Thread GitBox
shingjan commented on a change in pull request #9306: URL: https://github.com/apache/tvm/pull/9306#discussion_r734757692 ## File path: src/printer/tvmscript_printer.cc ## @@ -1049,15 +1068,24 @@ Doc TVMScriptPrinter::PrintBlockBody(const BlockNode* op) { return body; }

[GitHub] [tvm] shingjan commented on a change in pull request #9306: [TIR] Add structural error printing for TensorIR

2021-10-22 Thread GitBox
shingjan commented on a change in pull request #9306: URL: https://github.com/apache/tvm/pull/9306#discussion_r734757428 ## File path: tests/python/unittest/test_tvmscript_error_report.py ## @@ -511,5 +512,77 @@ def render(e): # TODO(Siyuan): block iter errors. +

[GitHub] [tvm] vinx13 commented on a change in pull request #9306: [TIR] Add structural error printing for TensorIR

2021-10-22 Thread GitBox
vinx13 commented on a change in pull request #9306: URL: https://github.com/apache/tvm/pull/9306#discussion_r734757408 ## File path: src/printer/tvmscript_printer.cc ## @@ -1049,15 +1068,24 @@ Doc TVMScriptPrinter::PrintBlockBody(const BlockNode* op) { return body; }

[GitHub] [tvm] shingjan commented on a change in pull request #9306: [TIR] Add structural error printing for TensorIR

2021-10-22 Thread GitBox
shingjan commented on a change in pull request #9306: URL: https://github.com/apache/tvm/pull/9306#discussion_r734757348 ## File path: src/tir/schedule/error.cc ## @@ -24,29 +24,37 @@ namespace tir { String ScheduleError::RenderReport(const String& primitive) const {

[GitHub] [tvm] mehrdadh commented on a change in pull request #9229: [TVMC] Add new micro context

2021-10-22 Thread GitBox
mehrdadh commented on a change in pull request #9229: URL: https://github.com/apache/tvm/pull/9229#discussion_r734753773 ## File path: python/tvm/driver/tvmc/runner.py ## @@ -366,13 +460,17 @@ def run_module( "Try calling tvmc.compile on the model before running

[GitHub] [tvm] ashutosh-arm commented on a change in pull request #9331: [4/10] Code generation for Conv2D via CMSIS-NN

2021-10-22 Thread GitBox
ashutosh-arm commented on a change in pull request #9331: URL: https://github.com/apache/tvm/pull/9331#discussion_r734740995 ## File path: src/relay/backend/contrib/cmsisnn/extract_constants.cc ## @@ -0,0 +1,158 @@ + +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [tvm] ashutosh-arm commented on a change in pull request #9331: [4/10] Code generation for Conv2D via CMSIS-NN

2021-10-22 Thread GitBox
ashutosh-arm commented on a change in pull request #9331: URL: https://github.com/apache/tvm/pull/9331#discussion_r734738825 ## File path: src/relay/backend/contrib/cmsisnn/extract_constants.cc ## @@ -0,0 +1,158 @@ + +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [tvm] csullivan opened a new pull request #9355: [Hexagon] Introduce new DeviceAPI

2021-10-22 Thread GitBox
csullivan opened a new pull request #9355: URL: https://github.com/apache/tvm/pull/9355 The new Hexagon DeviceAPI is intended for cross compilation directly to Hexagon. This is distinct from the current device api which is compiled and run on the android arm CPU. This includes: *

[GitHub] [tvm] manupa-arm commented on a change in pull request #9331: [4/10] Code generation for Conv2D via CMSIS-NN

2021-10-22 Thread GitBox
manupa-arm commented on a change in pull request #9331: URL: https://github.com/apache/tvm/pull/9331#discussion_r734707993 ## File path: src/relay/backend/contrib/cmsisnn/extract_constants.cc ## @@ -0,0 +1,158 @@ + +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [tvm] ashutosh-arm commented on a change in pull request #9331: [4/10] Code generation for Conv2D via CMSIS-NN

2021-10-22 Thread GitBox
ashutosh-arm commented on a change in pull request #9331: URL: https://github.com/apache/tvm/pull/9331#discussion_r734712228 ## File path: src/relay/backend/contrib/cmsisnn/extract_constants.cc ## @@ -0,0 +1,158 @@ + +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [tvm] ashutosh-arm commented on a change in pull request #9331: [4/10] Code generation for Conv2D via CMSIS-NN

2021-10-22 Thread GitBox
ashutosh-arm commented on a change in pull request #9331: URL: https://github.com/apache/tvm/pull/9331#discussion_r734711642 ## File path: src/relay/backend/contrib/cmsisnn/extract_constants.cc ## @@ -0,0 +1,158 @@ + +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [tvm] manupa-arm commented on a change in pull request #9331: [4/10] Code generation for Conv2D via CMSIS-NN

2021-10-22 Thread GitBox
manupa-arm commented on a change in pull request #9331: URL: https://github.com/apache/tvm/pull/9331#discussion_r734711358 ## File path: src/relay/backend/contrib/cmsisnn/extract_constants.cc ## @@ -0,0 +1,158 @@ + +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [tvm] manupa-arm commented on a change in pull request #9331: [4/10] Code generation for Conv2D via CMSIS-NN

2021-10-22 Thread GitBox
manupa-arm commented on a change in pull request #9331: URL: https://github.com/apache/tvm/pull/9331#discussion_r734709297 ## File path: src/relay/backend/contrib/cmsisnn/extract_constants.cc ## @@ -0,0 +1,158 @@ + +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [tvm] manupa-arm commented on a change in pull request #9331: [4/10] Code generation for Conv2D via CMSIS-NN

2021-10-22 Thread GitBox
manupa-arm commented on a change in pull request #9331: URL: https://github.com/apache/tvm/pull/9331#discussion_r734707993 ## File path: src/relay/backend/contrib/cmsisnn/extract_constants.cc ## @@ -0,0 +1,158 @@ + +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [tvm] manupa-arm commented on a change in pull request #9331: [4/10] Code generation for Conv2D via CMSIS-NN

2021-10-22 Thread GitBox
manupa-arm commented on a change in pull request #9331: URL: https://github.com/apache/tvm/pull/9331#discussion_r734707629 ## File path: src/relay/backend/contrib/cmsisnn/extract_constants.cc ## @@ -0,0 +1,158 @@ + +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [tvm] csullivan opened a new pull request #9354: [Hexagon] Refactor directory structure to accommodate new runtime

2021-10-22 Thread GitBox
csullivan opened a new pull request #9354: URL: https://github.com/apache/tvm/pull/9354 Move hexagon runtime files used for ARM offload to Hexagon into runtime/hexagon/android and runtime files compiled for hexagon into runtime/hexagon/hexagon. Use common hexagon_module.h for the "offload

[GitHub] [tvm] ashutosh-arm commented on a change in pull request #9331: [4/10] Code generation for Conv2D via CMSIS-NN

2021-10-22 Thread GitBox
ashutosh-arm commented on a change in pull request #9331: URL: https://github.com/apache/tvm/pull/9331#discussion_r734682910 ## File path: src/relay/backend/contrib/cmsisnn/extract_constants.cc ## @@ -0,0 +1,158 @@ + +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [tvm] ashutosh-arm commented on a change in pull request #9331: [4/10] Code generation for Conv2D via CMSIS-NN

2021-10-22 Thread GitBox
ashutosh-arm commented on a change in pull request #9331: URL: https://github.com/apache/tvm/pull/9331#discussion_r734679648 ## File path: src/relay/backend/contrib/cmsisnn/extract_constants.cc ## @@ -0,0 +1,158 @@ + +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [tvm] ashutosh-arm commented on a change in pull request #9331: [4/10] Code generation for Conv2D via CMSIS-NN

2021-10-22 Thread GitBox
ashutosh-arm commented on a change in pull request #9331: URL: https://github.com/apache/tvm/pull/9331#discussion_r734678777 ## File path: src/relay/backend/contrib/cmsisnn/extract_constants.cc ## @@ -0,0 +1,158 @@ + +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [tvm] ashutosh-arm commented on a change in pull request #9331: [4/10] Code generation for Conv2D via CMSIS-NN

2021-10-22 Thread GitBox
ashutosh-arm commented on a change in pull request #9331: URL: https://github.com/apache/tvm/pull/9331#discussion_r734675178 ## File path: src/relay/backend/contrib/cmsisnn/extract_constants.cc ## @@ -0,0 +1,158 @@ + +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [tvm] ashutosh-arm commented on a change in pull request #9331: [4/10] Code generation for Conv2D via CMSIS-NN

2021-10-22 Thread GitBox
ashutosh-arm commented on a change in pull request #9331: URL: https://github.com/apache/tvm/pull/9331#discussion_r734672888 ## File path: src/relay/backend/contrib/cmsisnn/extract_constants.cc ## @@ -0,0 +1,158 @@ + +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [tvm] Lunderberg opened a new pull request #9353: [PyTest] Sort by test location, but not parametrization

2021-10-22 Thread GitBox
Lunderberg opened a new pull request #9353: URL: https://github.com/apache/tvm/pull/9353 A follow-up from https://github.com/apache/tvm/pull/9188. The `item.location` tuple contains `(filename, line_number, test_name)`, where the `test_name` includes a string representation of all

[GitHub] [tvm] Mousius commented on a change in pull request #9331: [4/10] Code generation for Conv2D via CMSIS-NN

2021-10-22 Thread GitBox
Mousius commented on a change in pull request #9331: URL: https://github.com/apache/tvm/pull/9331#discussion_r734670353 ## File path: src/relay/backend/contrib/cmsisnn/extract_constants.cc ## @@ -0,0 +1,158 @@ + +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [tvm] Mousius commented on a change in pull request #9331: [4/10] Code generation for Conv2D via CMSIS-NN

2021-10-22 Thread GitBox
Mousius commented on a change in pull request #9331: URL: https://github.com/apache/tvm/pull/9331#discussion_r734669302 ## File path: src/relay/backend/contrib/cmsisnn/extract_constants.cc ## @@ -0,0 +1,158 @@ + +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [tvm] manupa-arm commented on pull request #9344: [TEST] Disable Hexagon TestConv2dPackedFilter test

2021-10-22 Thread GitBox
manupa-arm commented on pull request #9344: URL: https://github.com/apache/tvm/pull/9344#issuecomment-949759736 This is merged! Thanks! @masahi @mbs-octoml @csullivan @grant-arm -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[tvm] branch main updated (5ca646b -> d5dd8c0)

2021-10-22 Thread manupa
This is an automated email from the ASF dual-hosted git repository. manupa pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/tvm.git. from 5ca646b BUG: Look through on_device annotations when looking for shape constants (#9345) add d5dd8c0 Disable

[GitHub] [tvm] manupa-arm merged pull request #9344: [TEST] Disable Hexagon TestConv2dPackedFilter test

2021-10-22 Thread GitBox
manupa-arm merged pull request #9344: URL: https://github.com/apache/tvm/pull/9344 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [tvm] quic-sanirudh commented on pull request #9315: [TensorIR][Tutorial] Blitz course

2021-10-22 Thread GitBox
quic-sanirudh commented on pull request #9315: URL: https://github.com/apache/tvm/pull/9315#issuecomment-949759035 From my limited experience playing with TensorIR recently, I realized that almost all tests in TVM import the tir script as `from tvm.script import tir as T` and the same is

[GitHub] [tvm] Mousius commented on a change in pull request #9331: [4/10] Code generation for Conv2D via CMSIS-NN

2021-10-22 Thread GitBox
Mousius commented on a change in pull request #9331: URL: https://github.com/apache/tvm/pull/9331#discussion_r734665254 ## File path: src/relay/backend/contrib/cmsisnn/tir_to_runtime.cc ## @@ -69,6 +225,10 @@ class CodeGenCMSISNN : public CodeGenC { ss << "}\n"; ss

[GitHub] [tvm] manupa-arm commented on pull request #9344: [TEST] Disable Hexagon TestConv2dPackedFilter test

2021-10-22 Thread GitBox
manupa-arm commented on pull request #9344: URL: https://github.com/apache/tvm/pull/9344#issuecomment-949758202 I am also seeing this : https://ci.tlcpack.ai/blue/organizations/jenkins/tvm/detail/PR-9214/3/pipeline/. Seem like, we broadly agree to disable it for now to unblock. --

[GitHub] [tvm] grant-arm commented on pull request #9344: [TEST] Disable Hexagon TestConv2dPackedFilter test

2021-10-22 Thread GitBox
grant-arm commented on pull request #9344: URL: https://github.com/apache/tvm/pull/9344#issuecomment-949755811 This issue is blocking 2 of my PRs in CI as well: https://ci.tlcpack.ai/blue/organizations/jenkins/tvm/detail/PR-9323/3/pipeline/270

[GitHub] [tvm] Mousius commented on a change in pull request #9331: [4/10] Code generation for Conv2D via CMSIS-NN

2021-10-22 Thread GitBox
Mousius commented on a change in pull request #9331: URL: https://github.com/apache/tvm/pull/9331#discussion_r734661754 ## File path: src/relay/backend/contrib/cmsisnn/extract_constants.cc ## @@ -0,0 +1,158 @@ + +/* + * Licensed to the Apache Software Foundation (ASF) under

  1   2   >