[GitHub] [incubator-tvm] tmoreau89 commented on issue #4318: [Relay][TOPI]Fix meaning of conv2d_transpose output_padding parameter

2019-11-21 Thread GitBox
tmoreau89 commented on issue #4318: [Relay][TOPI]Fix meaning of conv2d_transpose output_padding parameter URL: https://github.com/apache/incubator-tvm/pull/4318#issuecomment-557425594 FYI, I was able to reproduce the issue in your branch, I'll look more into what's causing it tomorrow...

[GitHub] [incubator-tvm] tmoreau89 commented on a change in pull request #4366: [DOCS] add benchmark log format doc

2019-11-21 Thread GitBox
tmoreau89 commented on a change in pull request #4366: [DOCS] add benchmark log format doc URL: https://github.com/apache/incubator-tvm/pull/4366#discussion_r349462188 ## File path: docs/dev/benchmark.rst ## @@ -0,0 +1,116 @@ +.. Licensed to the Apache Software

[GitHub] [incubator-tvm] jackwish commented on issue #3859: [TOPI][AutoTVM] NHWC conv2d templates for ARM

2019-11-21 Thread GitBox
jackwish commented on issue #3859: [TOPI][AutoTVM] NHWC conv2d templates for ARM URL: https://github.com/apache/incubator-tvm/pull/3859#issuecomment-557416474 Hi @tmoreau89 , thanks for your comments! > Do you mind checking tuned performance for e2e resnet18 and/or mobilenet?

[GitHub] [incubator-tvm] tmoreau89 commented on issue #3859: [TOPI][AutoTVM] NHWC conv2d templates for ARM

2019-11-21 Thread GitBox
tmoreau89 commented on issue #3859: [TOPI][AutoTVM] NHWC conv2d templates for ARM URL: https://github.com/apache/incubator-tvm/pull/3859#issuecomment-557407797 Other than that, I'd recommend adding more comments in the schedule code. Particularly in terms of decisions that affect compute

[GitHub] [incubator-tvm] tmoreau89 commented on issue #4318: [Relay][TOPI]Fix meaning of conv2d_transpose output_padding parameter

2019-11-21 Thread GitBox
tmoreau89 commented on issue #4318: [Relay][TOPI]Fix meaning of conv2d_transpose output_padding parameter URL: https://github.com/apache/incubator-tvm/pull/4318#issuecomment-557403912 @abergeron got sidetracked with other commitments, I'll reproduce the issue tomorrow.

[incubator-tvm] branch master updated (030a163 -> 70017ef)

2019-11-21 Thread srk
This is an automated email from the ASF dual-hosted git repository. srk pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git. from 030a163 update_document_after_repository_renamed (#4398) add 70017ef [Golang][Doc] improve the samples

[GitHub] [incubator-tvm] srkreddy1238 merged pull request #4385: [Golang][Doc] improve the samples and doc

2019-11-21 Thread GitBox
srkreddy1238 merged pull request #4385: [Golang][Doc] improve the samples and doc URL: https://github.com/apache/incubator-tvm/pull/4385 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-tvm] liangfu edited a comment on issue #4392: [VTA] Enable streamlined GEMM execution

2019-11-21 Thread GitBox
liangfu edited a comment on issue #4392: [VTA] Enable streamlined GEMM execution URL: https://github.com/apache/incubator-tvm/pull/4392#issuecomment-557371295 This PR doesn't intend to reduce cycle count, or any performance improvement. My major intention is to bring successful

[GitHub] [incubator-tvm] liangfu edited a comment on issue #4392: [VTA] Enable streamlined GEMM execution

2019-11-21 Thread GitBox
liangfu edited a comment on issue #4392: [VTA] Enable streamlined GEMM execution URL: https://github.com/apache/incubator-tvm/pull/4392#issuecomment-557371295 This PR doesn't intend to reduce cycle count, or any performance improvement. My major intention is to bring successful

[GitHub] [incubator-tvm] abergeron commented on issue #4318: [Relay][TOPI]Fix meaning of conv2d_transpose output_padding parameter

2019-11-21 Thread GitBox
abergeron commented on issue #4318: [Relay][TOPI]Fix meaning of conv2d_transpose output_padding parameter URL: https://github.com/apache/incubator-tvm/pull/4318#issuecomment-557396409 @tmoreau89 Any news? This is an

[GitHub] [incubator-tvm] yzhliu commented on issue #4259: [DEV][DRAFT] TVM v0.6 Release candidate

2019-11-21 Thread GitBox
yzhliu commented on issue #4259: [DEV][DRAFT] TVM v0.6 Release candidate URL: https://github.com/apache/incubator-tvm/issues/4259#issuecomment-557394735 The next steps are roughly, 1. Tag release candidate 2. Create binary artifact 3. Vote on dev@ mail-list (if fail, make change,

[GitHub] [incubator-tvm] yzhliu edited a comment on issue #4259: [DEV][DRAFT] TVM v0.6 Release candidate

2019-11-21 Thread GitBox
yzhliu edited a comment on issue #4259: [DEV][DRAFT] TVM v0.6 Release candidate URL: https://github.com/apache/incubator-tvm/issues/4259#issuecomment-550417287 # Build and Test * Increate the robuteness of CI test ([#2841](https://github.com/apache/incubator-tvm/pull/2841),

[GitHub] [incubator-tvm] yzhliu edited a comment on issue #4259: [DEV][DRAFT] TVM v0.6 Release candidate

2019-11-21 Thread GitBox
yzhliu edited a comment on issue #4259: [DEV][DRAFT] TVM v0.6 Release candidate URL: https://github.com/apache/incubator-tvm/issues/4259#issuecomment-550417287 # Build and Test * Increate the robuteness of CI test ([#2841](https://github.com/apache/incubator-tvm/pull/2841),

[GitHub] [incubator-tvm] liangfu edited a comment on issue #4392: [VTA] Enable streamlined GEMM execution

2019-11-21 Thread GitBox
liangfu edited a comment on issue #4392: [VTA] Enable streamlined GEMM execution URL: https://github.com/apache/incubator-tvm/pull/4392#issuecomment-557371295 This PR doesn't intend to reduce cycle count, or any performance improvement. My major intention is to bring successful

[incubator-tvm] branch v0.6.0 updated (122a493 -> 030a163)

2019-11-21 Thread liuyizhi
This is an automated email from the ASF dual-hosted git repository. liuyizhi pushed a change to branch v0.6.0 in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git. from 122a493 [Relay][VM] Clean up the VM and VM profiler code (#4391) add 4b2c4c3 Update Jenkinsfile for

[GitHub] [incubator-tvm] jackwish commented on issue #3859: [TOPI][AutoTVM] NHWC conv2d templates for ARM

2019-11-21 Thread GitBox
jackwish commented on issue #3859: [TOPI][AutoTVM] NHWC conv2d templates for ARM URL: https://github.com/apache/incubator-tvm/pull/3859#issuecomment-557374095 Thanks @FrozenGene for your quick review, comments addressed. This

[GitHub] [incubator-tvm] jackwish commented on a change in pull request #3859: [TOPI][AutoTVM] NHWC conv2d templates for ARM

2019-11-21 Thread GitBox
jackwish commented on a change in pull request #3859: [TOPI][AutoTVM] NHWC conv2d templates for ARM URL: https://github.com/apache/incubator-tvm/pull/3859#discussion_r349421231 ## File path: topi/python/topi/arm_cpu/conv2d_spatial_pack.py ## @@ -196,3 +196,160 @@ def

[GitHub] [incubator-tvm] jackwish commented on a change in pull request #3859: [TOPI][AutoTVM] NHWC conv2d templates for ARM

2019-11-21 Thread GitBox
jackwish commented on a change in pull request #3859: [TOPI][AutoTVM] NHWC conv2d templates for ARM URL: https://github.com/apache/incubator-tvm/pull/3859#discussion_r349421208 ## File path: topi/python/topi/arm_cpu/conv2d_spatial_pack.py ## @@ -196,3 +196,160 @@ def

[GitHub] [incubator-tvm] liangfu commented on issue #4392: [VTA] Enable streamlined GEMM execution

2019-11-21 Thread GitBox
liangfu commented on issue #4392: [VTA] Enable streamlined GEMM execution URL: https://github.com/apache/incubator-tvm/pull/4392#issuecomment-557371295 This PR doesn't intend to reduce cycle count, or any performance improvement. My major intention is to bring successful evaluation

[GitHub] [incubator-tvm] minminsun commented on a change in pull request #4234: Auto TensorCore CodeGen

2019-11-21 Thread GitBox
minminsun commented on a change in pull request #4234: Auto TensorCore CodeGen URL: https://github.com/apache/incubator-tvm/pull/4234#discussion_r349418871 ## File path: src/pass/tensor_core.cc ## @@ -0,0 +1,1247 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[incubator-tvm] branch master updated (4b2c4c3 -> 030a163)

2019-11-21 Thread tqchen
This is an automated email from the ASF dual-hosted git repository. tqchen pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git. from 4b2c4c3 Update Jenkinsfile for external runtime (#4396) add 030a163

[GitHub] [incubator-tvm] gittripley opened a new pull request #4398: update_document_after_repository_renamed

2019-11-21 Thread GitBox
gittripley opened a new pull request #4398: update_document_after_repository_renamed URL: https://github.com/apache/incubator-tvm/pull/4398 Thanks for contributing to TVM! Please refer to guideline https://docs.tvm.ai/contribute/ for useful information and tips. After the pull request

[GitHub] [incubator-tvm] vmiheer commented on issue #4397: Use the best tuner possible

2019-11-21 Thread GitBox
vmiheer commented on issue #4397: Use the best tuner possible URL: https://github.com/apache/incubator-tvm/pull/4397#issuecomment-557337992 Also I think installing xgboost is not hard.  On Thu, Nov 21, 2019 at 5:46 PM miheer vaidya wrote: > But then I guess the instructions

[GitHub] [incubator-tvm] vmiheer commented on issue #4397: Use the best tuner possible

2019-11-21 Thread GitBox
vmiheer commented on issue #4397: Use the best tuner possible URL: https://github.com/apache/incubator-tvm/pull/4397#issuecomment-557337675 But then I guess the instructions needs updating. There is comment and instruction to install xgboost. On Thu, Nov 21, 2019 at 3:54 PM Cody

[incubator-tvm] branch master updated (122a493 -> 4b2c4c3)

2019-11-21 Thread zhic
This is an automated email from the ASF dual-hosted git repository. zhic pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git. from 122a493 [Relay][VM] Clean up the VM and VM profiler code (#4391) add 4b2c4c3 Update Jenkinsfile for

[GitHub] [incubator-tvm] zhiics merged pull request #4396: Update Jenkinsfile for external runtime

2019-11-21 Thread GitBox
zhiics merged pull request #4396: Update Jenkinsfile for external runtime URL: https://github.com/apache/incubator-tvm/pull/4396 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [incubator-tvm] gittripley removed a comment on issue #4376: correct the instructions/scripts after repository name is changed to incubator-tvm

2019-11-21 Thread GitBox
gittripley removed a comment on issue #4376: correct the instructions/scripts after repository name is changed to incubator-tvm URL: https://github.com/apache/incubator-tvm/issues/4376#issuecomment-557330962 @tqchen It looks like I don't have the permission to raise PR. ```

[GitHub] [incubator-tvm] gittripley commented on issue #4376: correct the instructions/scripts after repository name is changed to incubator-tvm

2019-11-21 Thread GitBox
gittripley commented on issue #4376: correct the instructions/scripts after repository name is changed to incubator-tvm URL: https://github.com/apache/incubator-tvm/issues/4376#issuecomment-557330962 @tqchen It looks like I don't have the permission to raise PR. ``` Username

[GitHub] [incubator-tvm] yzhliu commented on issue #4259: [DEV][DRAFT] TVM v0.6 Release candidate

2019-11-21 Thread GitBox
yzhliu commented on issue #4259: [DEV][DRAFT] TVM v0.6 Release candidate URL: https://github.com/apache/incubator-tvm/issues/4259#issuecomment-557329901 I have created v0.6.0 branch. I'm about to update the release notes.

[incubator-tvm] branch v0.6.0 created (now 122a493)

2019-11-21 Thread liuyizhi
This is an automated email from the ASF dual-hosted git repository. liuyizhi pushed a change to branch v0.6.0 in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git. at 122a493 [Relay][VM] Clean up the VM and VM profiler code (#4391) No new revisions were added by this

[GitHub] [incubator-tvm] zhiics commented on issue #4391: [Relay][VM] Clean up the VM and VM profiler code

2019-11-21 Thread GitBox
zhiics commented on issue #4391: [Relay][VM] Clean up the VM and VM profiler code URL: https://github.com/apache/incubator-tvm/pull/4391#issuecomment-557326856 Thanks @icemelon9 @wweic This is an automated message from the

[incubator-tvm] branch master updated (1562eae -> 122a493)

2019-11-21 Thread zhic
This is an automated email from the ASF dual-hosted git repository. zhic pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git. from 1562eae [TOPI] Fix flaky testcase for floor div (#4382) add 122a493 [Relay][VM] Clean up the VM and VM

[GitHub] [incubator-tvm] zhiics merged pull request #4391: [Relay][VM] Clean up the VM and VM profiler code

2019-11-21 Thread GitBox
zhiics merged pull request #4391: [Relay][VM] Clean up the VM and VM profiler code URL: https://github.com/apache/incubator-tvm/pull/4391 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-tvm] yzhliu closed issue #4378: [TESTS][FLAKY] test_floor_divide

2019-11-21 Thread GitBox
yzhliu closed issue #4378: [TESTS][FLAKY] test_floor_divide URL: https://github.com/apache/incubator-tvm/issues/4378 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-tvm] yzhliu merged pull request #4382: [TOPI] Fix flaky testcase for floor div

2019-11-21 Thread GitBox
yzhliu merged pull request #4382: [TOPI] Fix flaky testcase for floor div URL: https://github.com/apache/incubator-tvm/pull/4382 This is an automated message from the Apache Git Service. To respond to the message, please log

[incubator-tvm] branch master updated (0cfa3a8 -> 1562eae)

2019-11-21 Thread liuyizhi
This is an automated email from the ASF dual-hosted git repository. liuyizhi pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git. from 0cfa3a8 Add Logan to reviewer (#4390) add 1562eae [TOPI] Fix flaky testcase for floor div (#4382)

[GitHub] [incubator-tvm] yzhliu commented on issue #4382: [TOPI] Fix flaky testcase for floor div

2019-11-21 Thread GitBox
yzhliu commented on issue #4382: [TOPI] Fix flaky testcase for floor div URL: https://github.com/apache/incubator-tvm/pull/4382#issuecomment-557322004 I merged. Thanks @tqchen This is an automated message from the Apache Git

[GitHub] [incubator-tvm] comaniac commented on issue #4397: Use the best tuner possible

2019-11-21 Thread GitBox
comaniac commented on issue #4397: Use the best tuner possible URL: https://github.com/apache/incubator-tvm/pull/4397#issuecomment-557309203 I think the reason of using the random tuner as an example is because it doesn't require XGBoost to be installed in the system.

[GitHub] [incubator-tvm] vmiheer opened a new pull request #4397: Use the best tuner possible

2019-11-21 Thread GitBox
vmiheer opened a new pull request #4397: Use the best tuner possible URL: https://github.com/apache/incubator-tvm/pull/4397 Maybe I am wrong but what's the point of using randomtuner when AutoTVM paper says XGBoost is the best? Please ignore this PR if you think otherwise . @tqchen,

[GitHub] [incubator-tvm] comaniac opened a new pull request #4396: Update Jenkinsfile for external runtime

2019-11-21 Thread GitBox
comaniac opened a new pull request #4396: Update Jenkinsfile for external runtime URL: https://github.com/apache/incubator-tvm/pull/4396 This PR updates the Jenkinsfile to enable the example external runtime for #4280 .

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #4366: [DOCS] add benchmark log format doc

2019-11-21 Thread GitBox
tqchen commented on a change in pull request #4366: [DOCS] add benchmark log format doc URL: https://github.com/apache/incubator-tvm/pull/4366#discussion_r349351309 ## File path: docs/dev/benchmark.rst ## @@ -0,0 +1,112 @@ +.. Licensed to the Apache Software Foundation

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #4366: [DOCS] add benchmark log format doc

2019-11-21 Thread GitBox
tqchen commented on a change in pull request #4366: [DOCS] add benchmark log format doc URL: https://github.com/apache/incubator-tvm/pull/4366#discussion_r349351392 ## File path: docs/dev/benchmark.rst ## @@ -0,0 +1,112 @@ +.. Licensed to the Apache Software Foundation

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #4366: [DOCS] add benchmark log format doc

2019-11-21 Thread GitBox
tqchen commented on a change in pull request #4366: [DOCS] add benchmark log format doc URL: https://github.com/apache/incubator-tvm/pull/4366#discussion_r349350648 ## File path: docs/dev/benchmark.rst ## @@ -0,0 +1,112 @@ +.. Licensed to the Apache Software Foundation

[GitHub] [incubator-tvm] tmoreau89 commented on issue #4392: [VTA] Enable streamlined GEMM execution

2019-11-21 Thread GitBox
tmoreau89 commented on issue #4392: [VTA] Enable streamlined GEMM execution URL: https://github.com/apache/incubator-tvm/pull/4392#issuecomment-557302374 I second Luis' comments on reporting on the latency/throughput tradeoffs; @liangfu thank you for the PR, do you mind pushing the old and

[GitHub] [incubator-tvm] yzhliu commented on issue #4382: [TOPI] Fix flaky testcase for floor div

2019-11-21 Thread GitBox
yzhliu commented on issue #4382: [TOPI] Fix flaky testcase for floor div URL: https://github.com/apache/incubator-tvm/pull/4382#issuecomment-557300741 @tqchen please review again. sorry i was quite occupied this morning. This

[GitHub] [incubator-tvm] tqchen edited a comment on issue #4280: [TVM][RUNTIME] A minimum example to generate external library wrappers for DSOModule

2019-11-21 Thread GitBox
tqchen edited a comment on issue #4280: [TVM][RUNTIME] A minimum example to generate external library wrappers for DSOModule URL: https://github.com/apache/incubator-tvm/pull/4280#issuecomment-557300395 @comaniac please send another PR first with the updated Jenkinsfile. For security

[GitHub] [incubator-tvm] tqchen commented on issue #4280: [TVM][RUNTIME] A minimum example to generate external library wrappers for DSOModule

2019-11-21 Thread GitBox
tqchen commented on issue #4280: [TVM][RUNTIME] A minimum example to generate external library wrappers for DSOModule URL: https://github.com/apache/incubator-tvm/pull/4280#issuecomment-557300395 @comaniac please send another PR first with the updated Jenkinsfile. CI will only respect

[GitHub] [incubator-tvm] junrushao1994 commented on a change in pull request #4346: [Runtime] Make ADTObject POD container type

2019-11-21 Thread GitBox
junrushao1994 commented on a change in pull request #4346: [Runtime] Make ADTObject POD container type URL: https://github.com/apache/incubator-tvm/pull/4346#discussion_r349340244 ## File path: src/runtime/container.cc ## @@ -0,0 +1,37 @@ +/* + * Licensed to the Apache

[GitHub] [incubator-tvm] junrushao1994 commented on a change in pull request #4346: [Runtime] Make ADTObject POD container type

2019-11-21 Thread GitBox
junrushao1994 commented on a change in pull request #4346: [Runtime] Make ADTObject POD container type URL: https://github.com/apache/incubator-tvm/pull/4346#discussion_r349348399 ## File path: include/tvm/runtime/container.h ## @@ -0,0 +1,259 @@ +/* + * Licensed to the

[GitHub] [incubator-tvm] junrushao1994 commented on a change in pull request #4346: [Runtime] Make ADTObject POD container type

2019-11-21 Thread GitBox
junrushao1994 commented on a change in pull request #4346: [Runtime] Make ADTObject POD container type URL: https://github.com/apache/incubator-tvm/pull/4346#discussion_r349348675 ## File path: include/tvm/runtime/memory.h ## @@ -73,6 +74,26 @@ class ObjAllocatorBase {

[GitHub] [incubator-tvm] junrushao1994 commented on a change in pull request #4346: [Runtime] Make ADTObject POD container type

2019-11-21 Thread GitBox
junrushao1994 commented on a change in pull request #4346: [Runtime] Make ADTObject POD container type URL: https://github.com/apache/incubator-tvm/pull/4346#discussion_r349348121 ## File path: include/tvm/runtime/container.h ## @@ -0,0 +1,259 @@ +/* + * Licensed to the

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #4346: [Runtime] Make ADTObject POD container type

2019-11-21 Thread GitBox
tqchen commented on a change in pull request #4346: [Runtime] Make ADTObject POD container type URL: https://github.com/apache/incubator-tvm/pull/4346#discussion_r349347368 ## File path: include/tvm/runtime/container.h ## @@ -0,0 +1,259 @@ +/* + * Licensed to the Apache

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #4346: [Runtime] Make ADTObject POD container type

2019-11-21 Thread GitBox
tqchen commented on a change in pull request #4346: [Runtime] Make ADTObject POD container type URL: https://github.com/apache/incubator-tvm/pull/4346#discussion_r349346811 ## File path: src/runtime/vm/vm.cc ## @@ -921,7 +923,7 @@ void VirtualMachine::RunLoop() {

[GitHub] [incubator-tvm] tqchen commented on issue #4346: [Runtime] Make ADTObject POD container type

2019-11-21 Thread GitBox
tqchen commented on issue #4346: [Runtime] Make ADTObject POD container type URL: https://github.com/apache/incubator-tvm/pull/4346#issuecomment-557298050 @wweic Some further comments. I think we don't have to implement push_back and emplace_back at the base level as ADT are immutable, we

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #4346: [Runtime] Make ADTObject POD container type

2019-11-21 Thread GitBox
tqchen commented on a change in pull request #4346: [Runtime] Make ADTObject POD container type URL: https://github.com/apache/incubator-tvm/pull/4346#discussion_r349343168 ## File path: include/tvm/runtime/container.h ## @@ -0,0 +1,259 @@ +/* + * Licensed to the Apache

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #4346: [Runtime] Make ADTObject POD container type

2019-11-21 Thread GitBox
tqchen commented on a change in pull request #4346: [Runtime] Make ADTObject POD container type URL: https://github.com/apache/incubator-tvm/pull/4346#discussion_r349345374 ## File path: include/tvm/runtime/container.h ## @@ -0,0 +1,259 @@ +/* + * Licensed to the Apache

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #4346: [Runtime] Make ADTObject POD container type

2019-11-21 Thread GitBox
tqchen commented on a change in pull request #4346: [Runtime] Make ADTObject POD container type URL: https://github.com/apache/incubator-tvm/pull/4346#discussion_r349344721 ## File path: include/tvm/runtime/container.h ## @@ -0,0 +1,259 @@ +/* + * Licensed to the Apache

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #4346: [Runtime] Make ADTObject POD container type

2019-11-21 Thread GitBox
tqchen commented on a change in pull request #4346: [Runtime] Make ADTObject POD container type URL: https://github.com/apache/incubator-tvm/pull/4346#discussion_r349344080 ## File path: include/tvm/runtime/container.h ## @@ -0,0 +1,259 @@ +/* + * Licensed to the Apache

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #4346: [Runtime] Make ADTObject POD container type

2019-11-21 Thread GitBox
tqchen commented on a change in pull request #4346: [Runtime] Make ADTObject POD container type URL: https://github.com/apache/incubator-tvm/pull/4346#discussion_r349344683 ## File path: include/tvm/runtime/container.h ## @@ -0,0 +1,259 @@ +/* + * Licensed to the Apache

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #4346: [Runtime] Make ADTObject POD container type

2019-11-21 Thread GitBox
tqchen commented on a change in pull request #4346: [Runtime] Make ADTObject POD container type URL: https://github.com/apache/incubator-tvm/pull/4346#discussion_r349343957 ## File path: include/tvm/runtime/container.h ## @@ -0,0 +1,259 @@ +/* + * Licensed to the Apache

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #4346: [Runtime] Make ADTObject POD container type

2019-11-21 Thread GitBox
tqchen commented on a change in pull request #4346: [Runtime] Make ADTObject POD container type URL: https://github.com/apache/incubator-tvm/pull/4346#discussion_r349343497 ## File path: include/tvm/runtime/container.h ## @@ -0,0 +1,259 @@ +/* + * Licensed to the Apache

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #4346: [Runtime] Make ADTObject POD container type

2019-11-21 Thread GitBox
tqchen commented on a change in pull request #4346: [Runtime] Make ADTObject POD container type URL: https://github.com/apache/incubator-tvm/pull/4346#discussion_r349343784 ## File path: include/tvm/runtime/container.h ## @@ -0,0 +1,259 @@ +/* + * Licensed to the Apache

[GitHub] [incubator-tvm] comaniac commented on issue #4280: [TVM][RUNTIME] A minimum example to generate external library wrappers for DSOModule

2019-11-21 Thread GitBox
comaniac commented on issue #4280: [TVM][RUNTIME] A minimum example to generate external library wrappers for DSOModule URL: https://github.com/apache/incubator-tvm/pull/4280#issuecomment-557295940 Comment fixed. @tqchen somehow the CI doesn't update the config.cmake to enable the

[GitHub] [incubator-tvm] tqchen commented on issue #4382: [TOPI] Fix flaky testcase for floor div

2019-11-21 Thread GitBox
tqchen commented on issue #4382: [TOPI] Fix flaky testcase for floor div URL: https://github.com/apache/incubator-tvm/pull/4382#issuecomment-557294283 @yzhliu can you act on this? I think this is the last blocking item, then we can cut

[GitHub] [incubator-tvm] kalcohol commented on issue #4371: ImportError: cannot import name 'bilinear_sample_nchw'

2019-11-21 Thread GitBox
kalcohol commented on issue #4371: ImportError: cannot import name 'bilinear_sample_nchw' URL: https://github.com/apache/incubator-tvm/issues/4371#issuecomment-557277103 i know what is the mechanism of the occurrence, topi depends on tvm module, tvm module import this missing function for

[GitHub] [incubator-tvm] u99127 commented on issue #4395: [Relay][Frontend][TFlite] Add test for qnn_mul operator

2019-11-21 Thread GitBox
u99127 commented on issue #4395: [Relay][Frontend][TFlite] Add test for qnn_mul operator URL: https://github.com/apache/incubator-tvm/pull/4395#issuecomment-557273151 @FrozenGene @anijain2305 , please review . This is an

[GitHub] [incubator-tvm] u99127 commented on issue #4280: [TVM][RUNTIME] A minimum example to generate external library wrappers for DSOModule

2019-11-21 Thread GitBox
u99127 commented on issue #4280: [TVM][RUNTIME] A minimum example to generate external library wrappers for DSOModule URL: https://github.com/apache/incubator-tvm/pull/4280#issuecomment-557271412 > @u99127 Thanks for your comment. Thanks @zhiics and @tqchen.

[GitHub] [incubator-tvm] u99127 commented on a change in pull request #4280: [TVM][RUNTIME] A minimum example to generate external library wrappers for DSOModule

2019-11-21 Thread GitBox
u99127 commented on a change in pull request #4280: [TVM][RUNTIME] A minimum example to generate external library wrappers for DSOModule URL: https://github.com/apache/incubator-tvm/pull/4280#discussion_r349316135 ## File path: CMakeLists.txt ## @@ -231,6 +231,12 @@

[GitHub] [incubator-tvm] kalcohol commented on issue #4371: ImportError: cannot import name 'bilinear_sample_nchw'

2019-11-21 Thread GitBox
kalcohol commented on issue #4371: ImportError: cannot import name 'bilinear_sample_nchw' URL: https://github.com/apache/incubator-tvm/issues/4371#issuecomment-557270702 > @OriAlpha If I install `tvm`, `nnvm` and `topi` using `sudo python3 setup.py install` I do not have to set anything

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #4280: [TVM][RUNTIME] A minimum example to generate external library wrappers for DSOModule

2019-11-21 Thread GitBox
tqchen commented on a change in pull request #4280: [TVM][RUNTIME] A minimum example to generate external library wrappers for DSOModule URL: https://github.com/apache/incubator-tvm/pull/4280#discussion_r349314949 ## File path:

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #4280: [TVM][RUNTIME] A minimum example to generate external library wrappers for DSOModule

2019-11-21 Thread GitBox
tqchen commented on a change in pull request #4280: [TVM][RUNTIME] A minimum example to generate external library wrappers for DSOModule URL: https://github.com/apache/incubator-tvm/pull/4280#discussion_r349314361 ## File path:

[incubator-tvm] branch master updated (1bd5d71 -> 0cfa3a8)

2019-11-21 Thread tqchen
This is an automated email from the ASF dual-hosted git repository. tqchen pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git. from 1bd5d71 Update compile_engine.py (#4393) add 0cfa3a8 Add Logan to reviewer (#4390) No new revisions

[GitHub] [incubator-tvm] tqchen merged pull request #4393: [Doc] Fix doc-string in `compile_engine.py`

2019-11-21 Thread GitBox
tqchen merged pull request #4393: [Doc] Fix doc-string in `compile_engine.py` URL: https://github.com/apache/incubator-tvm/pull/4393 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-tvm] tqchen commented on issue #4393: [Doc] Fix doc-string in `compile_engine.py`

2019-11-21 Thread GitBox
tqchen commented on issue #4393: [Doc] Fix doc-string in `compile_engine.py` URL: https://github.com/apache/incubator-tvm/pull/4393#issuecomment-557264919 Thanks @hgt312 @junrushao1994 ! This is an automated message from the

[GitHub] [incubator-tvm] tqchen merged pull request #4390: [Community] @weberlo -> reviewer

2019-11-21 Thread GitBox
tqchen merged pull request #4390: [Community] @weberlo -> reviewer URL: https://github.com/apache/incubator-tvm/pull/4390 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[incubator-tvm] branch master updated (0bbdad4 -> 1bd5d71)

2019-11-21 Thread tqchen
This is an automated email from the ASF dual-hosted git repository. tqchen pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git. from 0bbdad4 [Relay][Frontend][TF] Fix slice when begin or size is not Const (#4372) add 1bd5d71 Update

[GitHub] [incubator-tvm] tqchen commented on issue #4376: correct the instructions/scripts after repository name is changed to incubator-tvm

2019-11-21 Thread GitBox
tqchen commented on issue #4376: correct the instructions/scripts after repository name is changed to incubator-tvm URL: https://github.com/apache/incubator-tvm/issues/4376#issuecomment-557264680 great points, can you send a PR to fix this? we need to change that to ``` git clone

[GitHub] [incubator-tvm] comaniac commented on a change in pull request #4151: [AutoTVM] Added an autotuning Config Library to store autotune results

2019-11-21 Thread GitBox
comaniac commented on a change in pull request #4151: [AutoTVM] Added an autotuning Config Library to store autotune results URL: https://github.com/apache/incubator-tvm/pull/4151#discussion_r349295422 ## File path: tests/python/unittest/test_autotvm_tuning_job.py ## @@

[GitHub] [incubator-tvm] comaniac commented on a change in pull request #4151: [AutoTVM] Added an autotuning Config Library to store autotune results

2019-11-21 Thread GitBox
comaniac commented on a change in pull request #4151: [AutoTVM] Added an autotuning Config Library to store autotune results URL: https://github.com/apache/incubator-tvm/pull/4151#discussion_r349293137 ## File path: python/tvm/autotvm/tuner/tuner.py ## @@ -86,8 +87,7 @@

[GitHub] [incubator-tvm] comaniac commented on a change in pull request #4151: [AutoTVM] Added an autotuning Config Library to store autotune results

2019-11-21 Thread GitBox
comaniac commented on a change in pull request #4151: [AutoTVM] Added an autotuning Config Library to store autotune results URL: https://github.com/apache/incubator-tvm/pull/4151#discussion_r349291485 ## File path: python/tvm/autotvm/config_library.py ## @@ -0,0 +1,279

[GitHub] [incubator-tvm] comaniac commented on a change in pull request #4151: [AutoTVM] Added an autotuning Config Library to store autotune results

2019-11-21 Thread GitBox
comaniac commented on a change in pull request #4151: [AutoTVM] Added an autotuning Config Library to store autotune results URL: https://github.com/apache/incubator-tvm/pull/4151#discussion_r349291108 ## File path: python/tvm/autotvm/config_library.py ## @@ -0,0 +1,279

[GitHub] [incubator-tvm] comaniac commented on a change in pull request #4151: [AutoTVM] Added an autotuning Config Library to store autotune results

2019-11-21 Thread GitBox
comaniac commented on a change in pull request #4151: [AutoTVM] Added an autotuning Config Library to store autotune results URL: https://github.com/apache/incubator-tvm/pull/4151#discussion_r349294111 ## File path: tests/python/unittest/test_autotvm_config_library.py ##

[GitHub] [incubator-tvm] kevinthesun merged pull request #4372: [Relay][Frontend][TF] Fix slice when begin or size is not Const

2019-11-21 Thread GitBox
kevinthesun merged pull request #4372: [Relay][Frontend][TF] Fix slice when begin or size is not Const URL: https://github.com/apache/incubator-tvm/pull/4372 This is an automated message from the Apache Git Service. To

[GitHub] [incubator-tvm] kevinthesun commented on issue #4372: [Relay][Frontend][TF] Fix slice when begin or size is not Const

2019-11-21 Thread GitBox
kevinthesun commented on issue #4372: [Relay][Frontend][TF] Fix slice when begin or size is not Const URL: https://github.com/apache/incubator-tvm/pull/4372#issuecomment-557222718 Thank you @lsy643 This is now merged. This

[incubator-tvm] branch master updated (786d799 -> 0bbdad4)

2019-11-21 Thread kevinthesun
This is an automated email from the ASF dual-hosted git repository. kevinthesun pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git. from 786d799 add GPU checking before compilation for rocm (#4394) add 0bbdad4 [Relay][Frontend][TF]

[GitHub] [incubator-tvm] zhiics commented on a change in pull request #4280: [TVM][RUNTIME] A minimum example to generate external library wrappers for DSOModule

2019-11-21 Thread GitBox
zhiics commented on a change in pull request #4280: [TVM][RUNTIME] A minimum example to generate external library wrappers for DSOModule URL: https://github.com/apache/incubator-tvm/pull/4280#discussion_r349259501 ## File path: apps/ext_runtime/src/ext_json_rt.cc ## @@

[GitHub] [incubator-tvm] u99127 commented on issue #4280: [TVM][RUNTIME] A minimum example to generate external library wrappers for DSOModule

2019-11-21 Thread GitBox
u99127 commented on issue #4280: [TVM][RUNTIME] A minimum example to generate external library wrappers for DSOModule URL: https://github.com/apache/incubator-tvm/pull/4280#issuecomment-557221217 > The directory convention should be something we document in the documents. Currently a

[GitHub] [incubator-tvm] anijain2305 commented on issue #4335: [Relay][WIP] ConvertLayout pass.

2019-11-21 Thread GitBox
anijain2305 commented on issue #4335: [Relay][WIP] ConvertLayout pass. URL: https://github.com/apache/incubator-tvm/pull/4335#issuecomment-557204233 @tqchen @yzhliu @zhiics Let me know if you have some cycles to review this. It will be good to know if you think the high-level design makes

[GitHub] [incubator-tvm] comaniac commented on issue #4280: [TVM][RUNTIME] A minimum example to generate external library wrappers for DSOModule

2019-11-21 Thread GitBox
comaniac commented on issue #4280: [TVM][RUNTIME] A minimum example to generate external library wrappers for DSOModule URL: https://github.com/apache/incubator-tvm/pull/4280#issuecomment-557204068 @tqchen thanks for the comments. Do you have any other suggestions to this PR, or could we

[GitHub] [incubator-tvm] tqchen commented on issue #4382: [TOPI] Fix flaky testcase for floor div

2019-11-21 Thread GitBox
tqchen commented on issue #4382: [TOPI] Fix flaky testcase for floor div URL: https://github.com/apache/incubator-tvm/pull/4382#issuecomment-557195441 Interesting, this could due to the fact that we offload floordiv to floor(div(a, b)) and somehow the two was not consistent(perhaps due to

[GitHub] [incubator-tvm] zhiics commented on issue #4280: [TVM][RUNTIME] A minimum example to generate external library wrappers for DSOModule

2019-11-21 Thread GitBox
zhiics commented on issue #4280: [TVM][RUNTIME] A minimum example to generate external library wrappers for DSOModule URL: https://github.com/apache/incubator-tvm/pull/4280#issuecomment-557194665 yes. Currently, this is an example that provides a demo to tell people how we can write

[GitHub] [incubator-tvm] inadob opened a new pull request #4395: [Relay][Frontend][TFlite] Add test for qnn_mul operator

2019-11-21 Thread GitBox
inadob opened a new pull request #4395: [Relay][Frontend][TFlite] Add test for qnn_mul operator URL: https://github.com/apache/incubator-tvm/pull/4395 * Add a function to set the qnn output range wrt each elemwise operation. * Add comments warning for nonsense clamped output in the

[GitHub] [incubator-tvm] tqchen commented on issue #4280: [TVM][RUNTIME] A minimum example to generate external library wrappers for DSOModule

2019-11-21 Thread GitBox
tqchen commented on issue #4280: [TVM][RUNTIME] A minimum example to generate external library wrappers for DSOModule URL: https://github.com/apache/incubator-tvm/pull/4280#issuecomment-557192302 The directory convention should be something we document in the documents. Currently a

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #4280: [TVM][RUNTIME] A minimum example to generate external library wrappers for DSOModule

2019-11-21 Thread GitBox
tqchen commented on a change in pull request #4280: [TVM][RUNTIME] A minimum example to generate external library wrappers for DSOModule URL: https://github.com/apache/incubator-tvm/pull/4280#discussion_r349223041 ## File path: apps/ext_runtime/src/ext_json_rt.cc ## @@

[GitHub] [incubator-tvm] cchung100m commented on a change in pull request #4385: [Golang][Doc] improve the samples and doc

2019-11-21 Thread GitBox
cchung100m commented on a change in pull request #4385: [Golang][Doc] improve the samples and doc URL: https://github.com/apache/incubator-tvm/pull/4385#discussion_r349151864 ## File path: golang/sample/gen_mobilenet_lib.py ## @@ -0,0 +1,55 @@ +# Licensed to the Apache

[GitHub] [incubator-tvm] cchung100m commented on a change in pull request #4385: [Golang][Doc] improve the samples and doc

2019-11-21 Thread GitBox
cchung100m commented on a change in pull request #4385: [Golang][Doc] improve the samples and doc URL: https://github.com/apache/incubator-tvm/pull/4385#discussion_r349149961 ## File path: golang/sample/gen_mobilenet_lib.py ## @@ -0,0 +1,55 @@ +# Licensed to the Apache

[incubator-tvm] branch master updated (464ebb1 -> 786d799)

2019-11-21 Thread masahi
This is an automated email from the ASF dual-hosted git repository. masahi pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git. from 464ebb1 [QNN] Lowering for Depthwise Convolution. (#4351) add 786d799 add GPU checking before

[GitHub] [incubator-tvm] masahi merged pull request #4394: add GPU checking before compilation for rocm

2019-11-21 Thread GitBox
masahi merged pull request #4394: add GPU checking before compilation for rocm URL: https://github.com/apache/incubator-tvm/pull/4394 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-tvm] mbarrett97 commented on issue #4151: [AutoTVM] Added an autotuning Config Library to store autotune results

2019-11-21 Thread GitBox
mbarrett97 commented on issue #4151: [AutoTVM] Added an autotuning Config Library to store autotune results URL: https://github.com/apache/incubator-tvm/pull/4151#issuecomment-557099069 @comaniac @eqy Could you please take a look at this?

[GitHub] [incubator-tvm] masahi commented on a change in pull request #4394: add GPU checking before compilation for rocm

2019-11-21 Thread GitBox
masahi commented on a change in pull request #4394: add GPU checking before compilation for rocm URL: https://github.com/apache/incubator-tvm/pull/4394#discussion_r349043981 ## File path: python/tvm/autotvm/measure/measure_methods.py ## @@ -227,7 +227,8 @@ def

  1   2   >