[GitHub] [airflow] amichai07 commented on a change in pull request #4751: [AIRFLOW-3607] collected trigger rule dep check per dag run

2020-01-16 Thread GitBox
amichai07 commented on a change in pull request #4751: [AIRFLOW-3607] collected trigger rule dep check per dag run URL: https://github.com/apache/airflow/pull/4751#discussion_r367599292 ## File path: tests/models/test_dagrun.py ## @@ -234,8 +234,9 @@ def

[GitHub] [airflow] amichai07 commented on a change in pull request #4751: [AIRFLOW-3607] collected trigger rule dep check per dag run

2020-01-16 Thread GitBox
amichai07 commented on a change in pull request #4751: [AIRFLOW-3607] collected trigger rule dep check per dag run URL: https://github.com/apache/airflow/pull/4751#discussion_r367551483 ## File path: tests/models/test_dagrun.py ## @@ -234,8 +234,9 @@ def

[GitHub] [airflow] amichai07 commented on a change in pull request #4751: [AIRFLOW-3607] collected trigger rule dep check per dag run

2020-01-13 Thread GitBox
amichai07 commented on a change in pull request #4751: [AIRFLOW-3607] collected trigger rule dep check per dag run URL: https://github.com/apache/airflow/pull/4751#discussion_r366190049 ## File path: airflow/ti_deps/deps/trigger_rule_dep.py ## @@ -34,11 +34,30 @@ class

[GitHub] [airflow] amichai07 commented on a change in pull request #4751: [AIRFLOW-3607] collected trigger rule dep check per dag run

2020-01-11 Thread GitBox
amichai07 commented on a change in pull request #4751: [AIRFLOW-3607] collected trigger rule dep check per dag run URL: https://github.com/apache/airflow/pull/4751#discussion_r365532675 ## File path: tests/models/test_dagrun.py ## @@ -229,7 +229,7 @@ def

[GitHub] [airflow] amichai07 commented on a change in pull request #4751: [AIRFLOW-3607] collected trigger rule dep check per dag run

2020-01-09 Thread GitBox
amichai07 commented on a change in pull request #4751: [AIRFLOW-3607] collected trigger rule dep check per dag run URL: https://github.com/apache/airflow/pull/4751#discussion_r364801917 ## File path: airflow/models/dagrun.py ## @@ -346,7 +331,38 @@ def update_state(self,

[GitHub] [airflow] amichai07 commented on a change in pull request #4751: [AIRFLOW-3607] collected trigger rule dep check per dag run

2020-01-08 Thread GitBox
amichai07 commented on a change in pull request #4751: [AIRFLOW-3607] collected trigger rule dep check per dag run URL: https://github.com/apache/airflow/pull/4751#discussion_r364300910 ## File path: tests/models/test_dagrun.py ## @@ -229,7 +229,7 @@ def

[GitHub] [airflow] amichai07 commented on a change in pull request #4751: [AIRFLOW-3607] collected trigger rule dep check per dag run

2020-01-08 Thread GitBox
amichai07 commented on a change in pull request #4751: [AIRFLOW-3607] collected trigger rule dep check per dag run URL: https://github.com/apache/airflow/pull/4751#discussion_r364170363 ## File path: airflow/models/dagrun.py ## @@ -263,48 +262,34 @@ def update_state(self,

[GitHub] [airflow] amichai07 commented on a change in pull request #4751: [AIRFLOW-3607] collected trigger rule dep check per dag run

2020-01-08 Thread GitBox
amichai07 commented on a change in pull request #4751: [AIRFLOW-3607] collected trigger rule dep check per dag run URL: https://github.com/apache/airflow/pull/4751#discussion_r364169818 ## File path: airflow/models/dagrun.py ## @@ -263,48 +262,34 @@ def update_state(self,

[GitHub] [airflow] amichai07 commented on a change in pull request #4751: [AIRFLOW-3607] collected trigger rule dep check per dag run

2019-11-24 Thread GitBox
amichai07 commented on a change in pull request #4751: [AIRFLOW-3607] collected trigger rule dep check per dag run URL: https://github.com/apache/airflow/pull/4751#discussion_r349927589 ## File path: airflow/jobs/scheduler_job.py ## @@ -721,25 +721,14 @@ def

[GitHub] [airflow] amichai07 commented on a change in pull request #4751: [AIRFLOW-3607] collected trigger rule dep check per dag run

2019-11-19 Thread GitBox
amichai07 commented on a change in pull request #4751: [AIRFLOW-3607] collected trigger rule dep check per dag run URL: https://github.com/apache/airflow/pull/4751#discussion_r348080871 ## File path: airflow/jobs/scheduler_job.py ## @@ -721,25 +721,14 @@ def

[GitHub] [airflow] amichai07 commented on a change in pull request #4751: [AIRFLOW-3607] collected trigger rule dep check per dag run

2019-11-19 Thread GitBox
amichai07 commented on a change in pull request #4751: [AIRFLOW-3607] collected trigger rule dep check per dag run URL: https://github.com/apache/airflow/pull/4751#discussion_r348077144 ## File path: airflow/jobs/scheduler_job.py ## @@ -721,25 +721,14 @@ def

[GitHub] [airflow] amichai07 commented on a change in pull request #4751: [AIRFLOW-3607] collected trigger rule dep check per dag run

2019-11-18 Thread GitBox
amichai07 commented on a change in pull request #4751: [AIRFLOW-3607] collected trigger rule dep check per dag run URL: https://github.com/apache/airflow/pull/4751#discussion_r347493137 ## File path: airflow/ti_deps/deps/trigger_rule_dep.py ## @@ -49,33 +75,33 @@ def

[GitHub] [airflow] amichai07 commented on a change in pull request #4751: [AIRFLOW-3607] collected trigger rule dep check per dag run

2019-11-18 Thread GitBox
amichai07 commented on a change in pull request #4751: [AIRFLOW-3607] collected trigger rule dep check per dag run URL: https://github.com/apache/airflow/pull/4751#discussion_r347492605 ## File path: airflow/ti_deps/dep_context.py ## @@ -67,6 +67,8 @@ class DepContext:

[GitHub] [airflow] amichai07 commented on a change in pull request #4751: [AIRFLOW-3607] collected trigger rule dep check per dag run

2019-11-18 Thread GitBox
amichai07 commented on a change in pull request #4751: [AIRFLOW-3607] collected trigger rule dep check per dag run URL: https://github.com/apache/airflow/pull/4751#discussion_r347492605 ## File path: airflow/ti_deps/dep_context.py ## @@ -67,6 +67,8 @@ class DepContext:

[GitHub] [airflow] amichai07 commented on a change in pull request #4751: [AIRFLOW-3607] collected trigger rule dep check per dag run

2019-11-18 Thread GitBox
amichai07 commented on a change in pull request #4751: [AIRFLOW-3607] collected trigger rule dep check per dag run URL: https://github.com/apache/airflow/pull/4751#discussion_r347270280 ## File path: airflow/jobs/scheduler_job.py ## @@ -717,7 +718,10 @@ def

[GitHub] [airflow] amichai07 commented on a change in pull request #4751: [AIRFLOW-3607] collected trigger rule dep check per dag run

2019-11-17 Thread GitBox
amichai07 commented on a change in pull request #4751: [AIRFLOW-3607] collected trigger rule dep check per dag run URL: https://github.com/apache/airflow/pull/4751#discussion_r347145094 ## File path: airflow/ti_deps/deps/trigger_rule_dep.py ## @@ -49,33 +75,33 @@ def

[GitHub] [airflow] amichai07 commented on a change in pull request #4751: [AIRFLOW-3607] collected trigger rule dep check per dag run

2019-11-17 Thread GitBox
amichai07 commented on a change in pull request #4751: [AIRFLOW-3607] collected trigger rule dep check per dag run URL: https://github.com/apache/airflow/pull/4751#discussion_r347145103 ## File path: airflow/ti_deps/deps/trigger_rule_dep.py ## @@ -34,6 +35,31 @@ class

[GitHub] [airflow] amichai07 commented on a change in pull request #4751: [AIRFLOW-3607] collected trigger rule dep check per dag run

2019-11-13 Thread GitBox
amichai07 commented on a change in pull request #4751: [AIRFLOW-3607] collected trigger rule dep check per dag run URL: https://github.com/apache/airflow/pull/4751#discussion_r345693428 ## File path: airflow/utils/state.py ## @@ -99,6 +99,7 @@ def finished(cls):

[GitHub] [airflow] amichai07 commented on a change in pull request #4751: [AIRFLOW-3607] collected trigger rule dep check per dag run

2019-11-11 Thread GitBox
amichai07 commented on a change in pull request #4751: [AIRFLOW-3607] collected trigger rule dep check per dag run URL: https://github.com/apache/airflow/pull/4751#discussion_r344499843 ## File path: airflow/models/dagrun.py ## @@ -246,11 +246,12 @@ def

[GitHub] [airflow] amichai07 commented on a change in pull request #4751: [AIRFLOW-3607] collected trigger rule dep check per dag run

2019-11-11 Thread GitBox
amichai07 commented on a change in pull request #4751: [AIRFLOW-3607] collected trigger rule dep check per dag run URL: https://github.com/apache/airflow/pull/4751#discussion_r344499688 ## File path: tests/ti_deps/deps/test_trigger_rule_dep.py ## @@ -361,3 +366,55 @@ def

[GitHub] [airflow] amichai07 commented on a change in pull request #4751: [AIRFLOW-3607] collected trigger rule dep check per dag run

2019-11-11 Thread GitBox
amichai07 commented on a change in pull request #4751: [AIRFLOW-3607] collected trigger rule dep check per dag run URL: https://github.com/apache/airflow/pull/4751#discussion_r344499197 ## File path: airflow/utils/state.py ## @@ -99,6 +99,7 @@ def finished(cls):

[GitHub] [airflow] amichai07 commented on a change in pull request #4751: [AIRFLOW-3607] collected trigger rule dep check per dag run

2019-07-10 Thread GitBox
amichai07 commented on a change in pull request #4751: [AIRFLOW-3607] collected trigger rule dep check per dag run URL: https://github.com/apache/airflow/pull/4751#discussion_r302166819 ## File path: airflow/ti_deps/deps/trigger_rule_dep.py ## @@ -49,33 +50,46 @@ def

[GitHub] [airflow] amichai07 commented on a change in pull request #4751: [AIRFLOW-3607] collected trigger rule dep check per dag run

2019-07-10 Thread GitBox
amichai07 commented on a change in pull request #4751: [AIRFLOW-3607] collected trigger rule dep check per dag run URL: https://github.com/apache/airflow/pull/4751#discussion_r302166463 ## File path: airflow/ti_deps/deps/trigger_rule_dep.py ## @@ -49,33 +50,46 @@ def

[GitHub] [airflow] amichai07 commented on a change in pull request #4751: [AIRFLOW-3607] collected trigger rule dep check per dag run

2019-07-10 Thread GitBox
amichai07 commented on a change in pull request #4751: [AIRFLOW-3607] collected trigger rule dep check per dag run URL: https://github.com/apache/airflow/pull/4751#discussion_r302166108 ## File path: airflow/ti_deps/deps/trigger_rule_dep.py ## @@ -49,33 +50,46 @@ def

[GitHub] [airflow] amichai07 commented on a change in pull request #4751: [AIRFLOW-3607] collected trigger rule dep check per dag run

2019-03-03 Thread GitBox
amichai07 commented on a change in pull request #4751: [AIRFLOW-3607] collected trigger rule dep check per dag run URL: https://github.com/apache/airflow/pull/4751#discussion_r261877321 ## File path: airflow/jobs.py ## @@ -930,7 +932,20 @@ def

[GitHub] [airflow] amichai07 commented on a change in pull request #4751: [AIRFLOW-3607] collected trigger rule dep check per dag run

2019-03-03 Thread GitBox
amichai07 commented on a change in pull request #4751: [AIRFLOW-3607] collected trigger rule dep check per dag run URL: https://github.com/apache/airflow/pull/4751#discussion_r261877204 ## File path: airflow/jobs.py ## @@ -930,7 +932,20 @@ def

[GitHub] [airflow] amichai07 commented on a change in pull request #4751: [AIRFLOW-3607] collected trigger rule dep check per dag run

2019-03-03 Thread GitBox
amichai07 commented on a change in pull request #4751: [AIRFLOW-3607] collected trigger rule dep check per dag run URL: https://github.com/apache/airflow/pull/4751#discussion_r261877155 ## File path: airflow/ti_deps/deps/trigger_rule_dep.py ## @@ -49,33 +49,49 @@ def

[GitHub] [airflow] amichai07 commented on a change in pull request #4751: [AIRFLOW-3607] collected trigger rule dep check per dag run

2019-03-03 Thread GitBox
amichai07 commented on a change in pull request #4751: [AIRFLOW-3607] collected trigger rule dep check per dag run URL: https://github.com/apache/airflow/pull/4751#discussion_r261877174 ## File path: airflow/models/__init__.py ## @@ -4872,11 +4872,12 @@ def