[GitHub] [calcite] julianhyde commented on a change in pull request #1141: [CALCITE-2914] Improve how LatticeSuggester deduces foreign keys

2019-04-01 Thread GitBox
julianhyde commented on a change in pull request #1141: [CALCITE-2914] Improve how LatticeSuggester deduces foreign keys URL: https://github.com/apache/calcite/pull/1141#discussion_r271113940 ## File path:

[GitHub] [calcite-avatica] F21 commented on issue #86: [CALCITE-2882] Set dirty true when open connection

2019-04-01 Thread GitBox
F21 commented on issue #86: [CALCITE-2882] Set dirty true when open connection URL: https://github.com/apache/calcite-avatica/pull/86#issuecomment-478822344 @bakea Do you think it would be possible to add a test for this?

[GitHub] [calcite] zhztheplayer removed a comment on issue #897: [CALCITE-2648] Output collation of EnumerableWindow is not consistent…

2019-04-01 Thread GitBox
zhztheplayer removed a comment on issue #897: [CALCITE-2648] Output collation of EnumerableWindow is not consistent… URL: https://github.com/apache/calcite/pull/897#issuecomment-468301076 I have no cue to solve the problem perfectly for now, closing temporarily.

[GitHub] [calcite] chunweilei commented on a change in pull request #1140: [CALCITE-2965] Implement string functions: REPEAT, SPACE, SOUNDEX, DI…

2019-04-01 Thread GitBox
chunweilei commented on a change in pull request #1140: [CALCITE-2965] Implement string functions: REPEAT, SPACE, SOUNDEX, DI… URL: https://github.com/apache/calcite/pull/1140#discussion_r271117690 ## File path: core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java

[GitHub] [calcite] chunweilei commented on a change in pull request #1140: [CALCITE-2965] Implement string functions: REPEAT, SPACE, SOUNDEX, DI…

2019-04-01 Thread GitBox
chunweilei commented on a change in pull request #1140: [CALCITE-2965] Implement string functions: REPEAT, SPACE, SOUNDEX, DI… URL: https://github.com/apache/calcite/pull/1140#discussion_r271117712 ## File path: core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java

[GitHub] [calcite] julianhyde commented on a change in pull request #1141: [CALCITE-2914] Improve how LatticeSuggester deduces foreign keys

2019-04-01 Thread GitBox
julianhyde commented on a change in pull request #1141: [CALCITE-2914] Improve how LatticeSuggester deduces foreign keys URL: https://github.com/apache/calcite/pull/1141#discussion_r271114592 ## File path: core/src/main/java/org/apache/calcite/materialize/SqlStatisticProvider.java

[GitHub] [calcite] chunweilei opened a new pull request #1142: [CALCITE-2754] Implement LISTAGG function (Sergey Nuyanzin, Chunwei Lei)

2019-04-01 Thread GitBox
chunweilei opened a new pull request #1142: [CALCITE-2754] Implement LISTAGG function (Sergey Nuyanzin, Chunwei Lei) URL: https://github.com/apache/calcite/pull/1142 JIRA: https://issues.apache.org/jira/browse/CALCITE-2754.

[GitHub] [calcite] chunweilei commented on issue #1142: [CALCITE-2754] Implement LISTAGG function (Sergey Nuyanzin, Chunwei Lei)

2019-04-02 Thread GitBox
chunweilei commented on issue #1142: [CALCITE-2754] Implement LISTAGG function (Sergey Nuyanzin, Chunwei Lei) URL: https://github.com/apache/calcite/pull/1142#issuecomment-478864452 Since [PR#981](https://github.com/apache/calcite/pull/981) is not updated since Dec, I open this pull

[GitHub] [calcite] julianhyde commented on issue #1100: Site: Improve documentation for MySQL Specific JSON operators

2019-03-29 Thread GitBox
julianhyde commented on issue #1100: Site: Improve documentation for MySQL Specific JSON operators URL: https://github.com/apache/calcite/pull/1100#issuecomment-478089536 Yes, splitting into two changes would be useful. Thanks for suggesting it.

[GitHub] [calcite] XuQianJin-Stars edited a comment on issue #1086: [CALCITE-2892] Add the JSON_KEYS function

2019-03-29 Thread GitBox
XuQianJin-Stars edited a comment on issue #1086: [CALCITE-2892] Add the JSON_KEYS function URL: https://github.com/apache/calcite/pull/1086#issuecomment-477826322 hi @michaelmior @zhztheplayer I have updated this PR. Can you continue to review this PR? best qianjin

[GitHub] [calcite] zhztheplayer commented on a change in pull request #1086: [CALCITE-2892] Add the JSON_KEYS function

2019-04-02 Thread GitBox
zhztheplayer commented on a change in pull request #1086: [CALCITE-2892] Add the JSON_KEYS function URL: https://github.com/apache/calcite/pull/1086#discussion_r271378333 ## File path: babel/src/main/codegen/config.fmpp ## @@ -557,6 +557,10 @@ data: {

[GitHub] [calcite] zhztheplayer commented on a change in pull request #1086: [CALCITE-2892] Add the JSON_KEYS function

2019-04-02 Thread GitBox
zhztheplayer commented on a change in pull request #1086: [CALCITE-2892] Add the JSON_KEYS function URL: https://github.com/apache/calcite/pull/1086#discussion_r271382782 ## File path: core/src/main/java/org/apache/calcite/runtime/CalciteResource.java ## @@ -876,6 +876,9

[GitHub] [calcite] zhztheplayer commented on a change in pull request #1086: [CALCITE-2892] Add the JSON_KEYS function

2019-04-02 Thread GitBox
zhztheplayer commented on a change in pull request #1086: [CALCITE-2892] Add the JSON_KEYS function URL: https://github.com/apache/calcite/pull/1086#discussion_r271382782 ## File path: core/src/main/java/org/apache/calcite/runtime/CalciteResource.java ## @@ -876,6 +876,9

[GitHub] [calcite] zhztheplayer commented on a change in pull request #1086: [CALCITE-2892] Add the JSON_KEYS function

2019-04-02 Thread GitBox
zhztheplayer commented on a change in pull request #1086: [CALCITE-2892] Add the JSON_KEYS function URL: https://github.com/apache/calcite/pull/1086#discussion_r271382782 ## File path: core/src/main/java/org/apache/calcite/runtime/CalciteResource.java ## @@ -876,6 +876,9

[GitHub] [calcite] hsyuan merged pull request #1096: [CALCITE-2004] Push join predicate down into inner relation for lateral join

2019-04-02 Thread GitBox
hsyuan merged pull request #1096: [CALCITE-2004] Push join predicate down into inner relation for lateral join URL: https://github.com/apache/calcite/pull/1096 This is an automated message from the Apache Git Service. To

[GitHub] [calcite] hsyuan commented on issue #1126: [CALCITE-2960] CalciteCatalogReader now uses config.caseSensitive() to get functions…

2019-04-02 Thread GitBox
hsyuan commented on issue #1126: [CALCITE-2960] CalciteCatalogReader now uses config.caseSensitive() to get functions… URL: https://github.com/apache/calcite/pull/1126#issuecomment-479063273 Closing this PR, since it has been resolved in commit:

[GitHub] [calcite] hsyuan closed pull request #1126: [CALCITE-2960] CalciteCatalogReader now uses config.caseSensitive() to get functions…

2019-04-02 Thread GitBox
hsyuan closed pull request #1126: [CALCITE-2960] CalciteCatalogReader now uses config.caseSensitive() to get functions… URL: https://github.com/apache/calcite/pull/1126 This is an automated message from the Apache Git

[GitHub] [calcite] hsyuan edited a comment on issue #1126: [CALCITE-2960] CalciteCatalogReader now uses config.caseSensitive() to get functions…

2019-04-02 Thread GitBox
hsyuan edited a comment on issue #1126: [CALCITE-2960] CalciteCatalogReader now uses config.caseSensitive() to get functions… URL: https://github.com/apache/calcite/pull/1126#issuecomment-479063273 Closing this PR, since it has been resolved in commit:

[GitHub] [calcite] danny0405 commented on issue #1126: [CALCITE-2960] CalciteCatalogReader now uses config.caseSensitive() to get functions…

2019-04-02 Thread GitBox
danny0405 commented on issue #1126: [CALCITE-2960] CalciteCatalogReader now uses config.caseSensitive() to get functions… URL: https://github.com/apache/calcite/pull/1126#issuecomment-478992669 @LaiZhou This problem is fixed in CALCITE-2928

[GitHub] [calcite] chunweilei commented on a change in pull request #1141: [CALCITE-2914] Improve how LatticeSuggester deduces foreign keys

2019-03-31 Thread GitBox
chunweilei commented on a change in pull request #1141: [CALCITE-2914] Improve how LatticeSuggester deduces foreign keys URL: https://github.com/apache/calcite/pull/1141#discussion_r270700169 ## File path:

[GitHub] [calcite] chunweilei commented on a change in pull request #1141: [CALCITE-2914] Improve how LatticeSuggester deduces foreign keys

2019-03-31 Thread GitBox
chunweilei commented on a change in pull request #1141: [CALCITE-2914] Improve how LatticeSuggester deduces foreign keys URL: https://github.com/apache/calcite/pull/1141#discussion_r270698337 ## File path: core/src/main/codegen/templates/Parser.jj ## @@ -5652,6 +5652,24

[GitHub] [calcite] julianhyde opened a new pull request #1141: [CALCITE-2914] Improve how LatticeSuggester deduces foreign keys

2019-03-31 Thread GitBox
julianhyde opened a new pull request #1141: [CALCITE-2914] Improve how LatticeSuggester deduces foreign keys URL: https://github.com/apache/calcite/pull/1141 See https://issues.apache.org/jira/browse/CALCITE-2914 This is an

[GitHub] [calcite] chunweilei commented on a change in pull request #1141: [CALCITE-2914] Improve how LatticeSuggester deduces foreign keys

2019-03-31 Thread GitBox
chunweilei commented on a change in pull request #1141: [CALCITE-2914] Improve how LatticeSuggester deduces foreign keys URL: https://github.com/apache/calcite/pull/1141#discussion_r270699138 ## File path: core/src/main/java/org/apache/calcite/materialize/SqlStatisticProvider.java

[GitHub] [calcite] julianhyde commented on a change in pull request #1130: [CALCITE-2865] FilterProjectTransposeRule generates wrong traitSet when copyFilter/Project is true

2019-03-31 Thread GitBox
julianhyde commented on a change in pull request #1130: [CALCITE-2865] FilterProjectTransposeRule generates wrong traitSet when copyFilter/Project is true URL: https://github.com/apache/calcite/pull/1130#discussion_r270687078 ## File path:

[GitHub] [calcite-avatica] risdenk commented on issue #92: [WIP][CALCITE-2972] Upgrade jetty to 9.4.15.v20190215

2019-04-02 Thread GitBox
risdenk commented on issue #92: [WIP][CALCITE-2972] Upgrade jetty to 9.4.15.v20190215 URL: https://github.com/apache/calcite-avatica/pull/92#issuecomment-479174728 So I'm definitely getting by butt kicked on this. I am going to push my changes that are definitely broken.

[GitHub] [calcite] XuQianJin-Stars opened a new pull request #1143: [CALCITE-2884] Add the JSON_INSERT, JSON_REPLACE, JSON_SET function

2019-04-02 Thread GitBox
XuQianJin-Stars opened a new pull request #1143: [CALCITE-2884] Add the JSON_INSERT,JSON_REPLACE,JSON_SET function URL: https://github.com/apache/calcite/pull/1143 `JSON_INSERT`(jsondoc, path, val[, path, val] ) `JSON_REPLACE`(jsondoc, _path_, _val_[, path, val] )

[GitHub] [calcite] zabetak closed pull request #1112: [CALCITE-2930] FilterCorrelateRule on a Correlate with SemiJoinType SEMI (or ANTI) throws IllegalStateException (Ruben Quesada Lopez)

2019-04-02 Thread GitBox
zabetak closed pull request #1112: [CALCITE-2930] FilterCorrelateRule on a Correlate with SemiJoinType SEMI (or ANTI) throws IllegalStateException (Ruben Quesada Lopez) URL: https://github.com/apache/calcite/pull/1112

[GitHub] [calcite] XuQianJin-Stars commented on a change in pull request #1086: [CALCITE-2892] Add the JSON_KEYS function

2019-04-02 Thread GitBox
XuQianJin-Stars commented on a change in pull request #1086: [CALCITE-2892] Add the JSON_KEYS function URL: https://github.com/apache/calcite/pull/1086#discussion_r271402416 ## File path: babel/src/main/codegen/config.fmpp ## @@ -557,6 +557,10 @@ data: {

[GitHub] [calcite-avatica] risdenk commented on a change in pull request #92: [WIP][CALCITE-2972] Upgrade jetty to 9.4.15.v20190215

2019-04-02 Thread GitBox
risdenk commented on a change in pull request #92: [WIP][CALCITE-2972] Upgrade jetty to 9.4.15.v20190215 URL: https://github.com/apache/calcite-avatica/pull/92#discussion_r271474411 ## File path: server/src/main/java/org/apache/calcite/avatica/server/HttpServer.java ##

[GitHub] [calcite-avatica] risdenk commented on a change in pull request #92: [WIP][CALCITE-2972] Upgrade jetty to 9.4.15.v20190215

2019-04-02 Thread GitBox
risdenk commented on a change in pull request #92: [WIP][CALCITE-2972] Upgrade jetty to 9.4.15.v20190215 URL: https://github.com/apache/calcite-avatica/pull/92#discussion_r271473370 ## File path: server/src/main/java/org/apache/calcite/avatica/server/HttpServer.java ##

[GitHub] [calcite-avatica] risdenk commented on a change in pull request #92: [WIP][CALCITE-2972] Upgrade jetty to 9.4.15.v20190215

2019-04-02 Thread GitBox
risdenk commented on a change in pull request #92: [WIP][CALCITE-2972] Upgrade jetty to 9.4.15.v20190215 URL: https://github.com/apache/calcite-avatica/pull/92#discussion_r271473791 ## File path: server/src/main/java/org/apache/calcite/avatica/server/HttpServer.java ##

[GitHub] [calcite-avatica] risdenk commented on a change in pull request #92: [WIP][CALCITE-2972] Upgrade jetty to 9.4.15.v20190215

2019-04-02 Thread GitBox
risdenk commented on a change in pull request #92: [WIP][CALCITE-2972] Upgrade jetty to 9.4.15.v20190215 URL: https://github.com/apache/calcite-avatica/pull/92#discussion_r271474119 ## File path: server/src/main/java/org/apache/calcite/avatica/server/HttpServer.java ##

[GitHub] [calcite] hsyuan commented on a change in pull request #1140: [CALCITE-2965] Implement string functions: REPEAT, SPACE, SOUNDEX, DI…

2019-04-02 Thread GitBox
hsyuan commented on a change in pull request #1140: [CALCITE-2965] Implement string functions: REPEAT, SPACE, SOUNDEX, DI… URL: https://github.com/apache/calcite/pull/1140#discussion_r271460662 ## File path: core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java

[GitHub] [calcite] hsyuan commented on a change in pull request #1140: [CALCITE-2965] Implement string functions: REPEAT, SPACE, SOUNDEX, DI…

2019-04-02 Thread GitBox
hsyuan commented on a change in pull request #1140: [CALCITE-2965] Implement string functions: REPEAT, SPACE, SOUNDEX, DI… URL: https://github.com/apache/calcite/pull/1140#discussion_r271460739 ## File path: core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java

[GitHub] [calcite-avatica] risdenk commented on issue #92: [WIP][CALCITE-2972] Upgrade jetty to 9.4.15.v20190215

2019-04-02 Thread GitBox
risdenk commented on issue #92: [WIP][CALCITE-2972] Upgrade jetty to 9.4.15.v20190215 URL: https://github.com/apache/calcite-avatica/pull/92#issuecomment-479178185 Since the existing implementation will work (not removed from Jetty yet just deprecated), I am thinking to just suppress the

[GitHub] [calcite] zabetak commented on a change in pull request #1030: [CALCITE-2822] Allow MultiJoin rules with any project/filter

2019-04-02 Thread GitBox
zabetak commented on a change in pull request #1030: [CALCITE-2822] Allow MultiJoin rules with any project/filter URL: https://github.com/apache/calcite/pull/1030#discussion_r271511373 ## File path: core/src/main/java/org/apache/calcite/tools/RelBuilder.java ## @@ -2623,6

[GitHub] [calcite] zabetak commented on a change in pull request #1030: [CALCITE-2822] Allow MultiJoin rules with any project/filter

2019-04-02 Thread GitBox
zabetak commented on a change in pull request #1030: [CALCITE-2822] Allow MultiJoin rules with any project/filter URL: https://github.com/apache/calcite/pull/1030#discussion_r271510854 ## File path: core/src/main/java/org/apache/calcite/rel/core/RelFactories.java ## @@

[GitHub] [calcite] zabetak commented on a change in pull request #1030: [CALCITE-2822] Allow MultiJoin rules with any project/filter

2019-04-02 Thread GitBox
zabetak commented on a change in pull request #1030: [CALCITE-2822] Allow MultiJoin rules with any project/filter URL: https://github.com/apache/calcite/pull/1030#discussion_r271511665 ## File path: core/src/test/java/org/apache/calcite/test/RelOptRulesTest.java ## @@

[GitHub] [calcite] zabetak commented on a change in pull request #1030: [CALCITE-2822] Allow MultiJoin rules with any project/filter

2019-04-02 Thread GitBox
zabetak commented on a change in pull request #1030: [CALCITE-2822] Allow MultiJoin rules with any project/filter URL: https://github.com/apache/calcite/pull/1030#discussion_r271510539 ## File path: core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableRel.java

[GitHub] [calcite] zhztheplayer commented on a change in pull request #1086: [CALCITE-2892] Add the JSON_KEYS function

2019-04-02 Thread GitBox
zhztheplayer commented on a change in pull request #1086: [CALCITE-2892] Add the JSON_KEYS function URL: https://github.com/apache/calcite/pull/1086#discussion_r271543304 ## File path: babel/src/main/codegen/config.fmpp ## @@ -557,6 +557,10 @@ data: {

[GitHub] [calcite] zinking commented on issue #1127: [CALCITE-2913] add a KafkaAdapter for Stream

2019-04-02 Thread GitBox
zinking commented on issue #1127: [CALCITE-2913] add a KafkaAdapter for Stream URL: https://github.com/apache/calcite/pull/1127#issuecomment-479274973 I was hoping to see some sql test in this new adapter though, could that be mocked?

[GitHub] [calcite] siddharthteotia commented on a change in pull request #1030: [CALCITE-2822] Allow MultiJoin rules with any project/filter

2019-04-02 Thread GitBox
siddharthteotia commented on a change in pull request #1030: [CALCITE-2822] Allow MultiJoin rules with any project/filter URL: https://github.com/apache/calcite/pull/1030#discussion_r271485479 ## File path:

[GitHub] [calcite] siddharthteotia commented on a change in pull request #1030: [CALCITE-2822] Allow MultiJoin rules with any project/filter

2019-04-02 Thread GitBox
siddharthteotia commented on a change in pull request #1030: [CALCITE-2822] Allow MultiJoin rules with any project/filter URL: https://github.com/apache/calcite/pull/1030#discussion_r271485206 ## File path: core/src/main/java/org/apache/calcite/plan/RelOptUtil.java ## @@

[GitHub] [calcite] siddharthteotia commented on a change in pull request #1030: [CALCITE-2822] Allow MultiJoin rules with any project/filter

2019-04-02 Thread GitBox
siddharthteotia commented on a change in pull request #1030: [CALCITE-2822] Allow MultiJoin rules with any project/filter URL: https://github.com/apache/calcite/pull/1030#discussion_r271498915 ## File path: core/src/test/java/org/apache/calcite/test/RelOptRulesTest.java ##

[GitHub] [calcite] siddharthteotia commented on a change in pull request #1030: [CALCITE-2822] Allow MultiJoin rules with any project/filter

2019-04-02 Thread GitBox
siddharthteotia commented on a change in pull request #1030: [CALCITE-2822] Allow MultiJoin rules with any project/filter URL: https://github.com/apache/calcite/pull/1030#discussion_r271498915 ## File path: core/src/test/java/org/apache/calcite/test/RelOptRulesTest.java ##

[GitHub] [calcite] siddharthteotia commented on issue #1030: [CALCITE-2822] Allow MultiJoin rules with any project/filter

2019-04-02 Thread GitBox
siddharthteotia commented on issue #1030: [CALCITE-2822] Allow MultiJoin rules with any project/filter URL: https://github.com/apache/calcite/pull/1030#issuecomment-479206930 @zabetak , I have addressed the comments > > I need something like

[GitHub] [calcite] zabetak commented on issue #1072: [CALCITE-2879] Improve filter condition in Join

2019-04-02 Thread GitBox
zabetak commented on issue #1072: [CALCITE-2879] Improve filter condition in Join URL: https://github.com/apache/calcite/pull/1072#issuecomment-479227785 Hi @yuqi1129, thanks for the PR. However, it seems there is already a way to do what you are proposing here. Can you please clarify and

[GitHub] [calcite] zhztheplayer commented on a change in pull request #1086: [CALCITE-2892] Add the JSON_KEYS function

2019-04-02 Thread GitBox
zhztheplayer commented on a change in pull request #1086: [CALCITE-2892] Add the JSON_KEYS function URL: https://github.com/apache/calcite/pull/1086#discussion_r271543754 ## File path: babel/src/main/codegen/config.fmpp ## @@ -557,6 +557,10 @@ data: {

[GitHub] [calcite-avatica] risdenk commented on a change in pull request #92: [WIP][CALCITE-2972] Upgrade jetty to 9.4.15.v20190215

2019-04-02 Thread GitBox
risdenk commented on a change in pull request #92: [WIP][CALCITE-2972] Upgrade jetty to 9.4.15.v20190215 URL: https://github.com/apache/calcite-avatica/pull/92#discussion_r271475849 ## File path: server/src/main/java/org/apache/calcite/avatica/server/HttpServer.java ##

[GitHub] [calcite-avatica] risdenk commented on a change in pull request #92: [WIP][CALCITE-2972] Upgrade jetty to 9.4.15.v20190215

2019-04-02 Thread GitBox
risdenk commented on a change in pull request #92: [WIP][CALCITE-2972] Upgrade jetty to 9.4.15.v20190215 URL: https://github.com/apache/calcite-avatica/pull/92#discussion_r271475823 ## File path: server/src/main/java/org/apache/calcite/avatica/server/HttpServer.java ##

[GitHub] [calcite-avatica] risdenk commented on issue #92: [WIP][CALCITE-2972] Upgrade jetty to 9.4.15.v20190215

2019-04-02 Thread GitBox
risdenk commented on issue #92: [WIP][CALCITE-2972] Upgrade jetty to 9.4.15.v20190215 URL: https://github.com/apache/calcite-avatica/pull/92#issuecomment-479187791 I created https://github.com/apache/calcite-avatica/pull/93 for the suppression route.

[GitHub] [calcite-avatica] risdenk opened a new pull request #93: [CALCITE-2972] Upgrade jetty to 9.4.15.v20190215

2019-04-02 Thread GitBox
risdenk opened a new pull request #93: [CALCITE-2972] Upgrade jetty to 9.4.15.v20190215 URL: https://github.com/apache/calcite-avatica/pull/93 Upgrade jetty to 9.4.15.v20190215 and add suppressions for deprecations associated with the upgrade.

[GitHub] [calcite] siddharthteotia commented on a change in pull request #1030: [CALCITE-2822] Allow MultiJoin rules with any project/filter

2019-04-02 Thread GitBox
siddharthteotia commented on a change in pull request #1030: [CALCITE-2822] Allow MultiJoin rules with any project/filter URL: https://github.com/apache/calcite/pull/1030#discussion_r271498570 ## File path:

[GitHub] [calcite] chunweilei commented on issue #1140: [CALCITE-2965] Implement string functions: REPEAT, SPACE, SOUNDEX, DI…

2019-04-03 Thread GitBox
chunweilei commented on issue #1140: [CALCITE-2965] Implement string functions: REPEAT, SPACE, SOUNDEX, DI… URL: https://github.com/apache/calcite/pull/1140#issuecomment-479363494 @hsyuan Updated. Thank you for your review. But I am afraid that it should not be merged until we come to an

[GitHub] [calcite] chunweilei commented on a change in pull request #1140: [CALCITE-2965] Implement string functions: REPEAT, SPACE, SOUNDEX, DI…

2019-04-03 Thread GitBox
chunweilei commented on a change in pull request #1140: [CALCITE-2965] Implement string functions: REPEAT, SPACE, SOUNDEX, DI… URL: https://github.com/apache/calcite/pull/1140#discussion_r271588566 ## File path: core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java

[GitHub] [calcite] chunweilei commented on a change in pull request #1140: [CALCITE-2965] Implement string functions: REPEAT, SPACE, SOUNDEX, DI…

2019-04-03 Thread GitBox
chunweilei commented on a change in pull request #1140: [CALCITE-2965] Implement string functions: REPEAT, SPACE, SOUNDEX, DI… URL: https://github.com/apache/calcite/pull/1140#discussion_r271588601 ## File path: core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java

[GitHub] [calcite] XuMingmin commented on issue #1127: [CALCITE-2913] add a KafkaAdapter for Stream

2019-04-02 Thread GitBox
XuMingmin commented on issue #1127: [CALCITE-2913] add a KafkaAdapter for Stream URL: https://github.com/apache/calcite/pull/1127#issuecomment-479326310 There're some test cases in `KafkaAdapterTest` with `org.apache.kafka.clients.consumer.MockConsumer`. Is that what you refers to?

[GitHub] [calcite] jcamachor opened a new pull request #1144: [CALCITE-2976] Improve materialized view rewriting coverage with disj…

2019-04-02 Thread GitBox
jcamachor opened a new pull request #1144: [CALCITE-2976] Improve materialized view rewriting coverage with disj… URL: https://github.com/apache/calcite/pull/1144 …unctive predicates This is an automated message from the

[GitHub] [calcite] XuQianJin-Stars commented on a change in pull request #1086: [CALCITE-2892] Add the JSON_KEYS function

2019-04-02 Thread GitBox
XuQianJin-Stars commented on a change in pull request #1086: [CALCITE-2892] Add the JSON_KEYS function URL: https://github.com/apache/calcite/pull/1086#discussion_r271553975 ## File path: babel/src/main/codegen/config.fmpp ## @@ -557,6 +557,10 @@ data: {

[GitHub] [calcite] zhztheplayer closed pull request #1086: [CALCITE-2892] Add the JSON_KEYS function

2019-04-02 Thread GitBox
zhztheplayer closed pull request #1086: [CALCITE-2892] Add the JSON_KEYS function URL: https://github.com/apache/calcite/pull/1086 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [calcite] zhztheplayer commented on a change in pull request #1107: CALCITE-2870: Support for JSON query quotes behavior

2019-04-02 Thread GitBox
zhztheplayer commented on a change in pull request #1107: CALCITE-2870: Support for JSON query quotes behavior URL: https://github.com/apache/calcite/pull/1107#discussion_r271558302 ## File path: core/src/test/java/org/apache/calcite/sql/test/SqlOperatorBaseTest.java ##

[GitHub] [calcite] XuQianJin-Stars commented on issue #1143: [CALCITE-2884] Add the JSON_INSERT, JSON_REPLACE, JSON_SET function

2019-04-03 Thread GitBox
XuQianJin-Stars commented on issue #1143: [CALCITE-2884] Add the JSON_INSERT,JSON_REPLACE,JSON_SET function URL: https://github.com/apache/calcite/pull/1143#issuecomment-479400812 hi @zhztheplayer I don't know if all the considerations are incomplete. I hope you can review and give me

[GitHub] [calcite] XuQianJin-Stars edited a comment on issue #1143: [CALCITE-2884] Add the JSON_INSERT, JSON_REPLACE, JSON_SET function

2019-04-03 Thread GitBox
XuQianJin-Stars edited a comment on issue #1143: [CALCITE-2884] Add the JSON_INSERT,JSON_REPLACE,JSON_SET function URL: https://github.com/apache/calcite/pull/1143#issuecomment-479400812 hi @zhztheplayer @michaelmior I don't know if all the considerations are incomplete. I hope you can

[GitHub] [calcite] hsyuan commented on a change in pull request #1113: Site: Add Alibaba MaxCompute to powered-by page

2019-03-20 Thread GitBox
hsyuan commented on a change in pull request #1113: Site: Add Alibaba MaxCompute to powered-by page URL: https://github.com/apache/calcite/pull/1113#discussion_r267597878 ## File path: site/_docs/powered_by.md ## @@ -112,6 +112,12 @@ is a distributed JVM-Embeddable

[GitHub] [calcite] chunweilei commented on a change in pull request #1121: [CALCITE-2936] Simplify EXISTS or NOT EXISTS sub-query that has "GROUP BY ()"

2019-03-20 Thread GitBox
chunweilei commented on a change in pull request #1121: [CALCITE-2936] Simplify EXISTS or NOT EXISTS sub-query that has "GROUP BY ()" URL: https://github.com/apache/calcite/pull/1121#discussion_r267616220 ## File path:

[GitHub] [calcite] zhztheplayer commented on issue #1070: [CALCITE-2808]Add the JSON_LENGTH function

2019-03-21 Thread GitBox
zhztheplayer commented on issue #1070: [CALCITE-2808]Add the JSON_LENGTH function URL: https://github.com/apache/calcite/pull/1070#issuecomment-475138942 > Is there anything else that needs to be modified about this PR? Can you continue to review this PR? @XuQianJin-Stars - I think

[GitHub] [calcite] julianhyde commented on a change in pull request #1120: [CALCITE-2933] Add timestamp extract for casts from timestamp type to…

2019-03-21 Thread GitBox
julianhyde commented on a change in pull request #1120: [CALCITE-2933] Add timestamp extract for casts from timestamp type to… URL: https://github.com/apache/calcite/pull/1120#discussion_r267651445 ## File path: druid/src/main/java/org/apache/calcite/adapter/druid/DruidQuery.java

[GitHub] [calcite] julianhyde commented on a change in pull request #1121: [CALCITE-2936] Simplify EXISTS or NOT EXISTS sub-query that has "GROUP BY ()"

2019-03-21 Thread GitBox
julianhyde commented on a change in pull request #1121: [CALCITE-2936] Simplify EXISTS or NOT EXISTS sub-query that has "GROUP BY ()" URL: https://github.com/apache/calcite/pull/1121#discussion_r267653025 ## File path:

[GitHub] [calcite] zhztheplayer commented on a change in pull request #1070: [CALCITE-2808]Add the JSON_LENGTH function

2019-03-21 Thread GitBox
zhztheplayer commented on a change in pull request #1070: [CALCITE-2808]Add the JSON_LENGTH function URL: https://github.com/apache/calcite/pull/1070#discussion_r267639290 ## File path: core/src/main/java/org/apache/calcite/sql/fun/SqlJsonApiCommonSyntaxWithoutPathOperator.java

[GitHub] [calcite] hsyuan commented on a change in pull request #1120: [CALCITE-2933] Add timestamp extract for casts from timestamp type to…

2019-03-20 Thread GitBox
hsyuan commented on a change in pull request #1120: [CALCITE-2933] Add timestamp extract for casts from timestamp type to… URL: https://github.com/apache/calcite/pull/1120#discussion_r267620712 ## File path: druid/src/main/java/org/apache/calcite/adapter/druid/DruidQuery.java

[GitHub] [calcite] chunweilei commented on a change in pull request #1108: [CALCITE-883] Support RESPECT NULLS, IGNORE NULLS option for lead, lag, first_value, last_value function

2019-03-20 Thread GitBox
chunweilei commented on a change in pull request #1108: [CALCITE-883] Support RESPECT NULLS, IGNORE NULLS option for lead, lag, first_value, last_value function URL: https://github.com/apache/calcite/pull/1108#discussion_r267609661 ## File path:

[GitHub] [calcite] hsyuan commented on a change in pull request #1121: [CALCITE-2936] Simplify EXISTS or NOT EXISTS sub-query that has "GROUP BY ()"

2019-03-20 Thread GitBox
hsyuan commented on a change in pull request #1121: [CALCITE-2936] Simplify EXISTS or NOT EXISTS sub-query that has "GROUP BY ()" URL: https://github.com/apache/calcite/pull/1121#discussion_r267615643 ## File path:

[GitHub] [calcite] XuQianJin-Stars commented on issue #1070: [CALCITE-2808]Add the JSON_LENGTH function

2019-03-21 Thread GitBox
XuQianJin-Stars commented on issue #1070: [CALCITE-2808]Add the JSON_LENGTH function URL: https://github.com/apache/calcite/pull/1070#issuecomment-475128824 hi @zhztheplayer Is there anything else that needs to be modified about this PR? Can you continue to review this PR?

[GitHub] [calcite] chunweilei commented on a change in pull request #1121: [CALCITE-2936] Simplify EXISTS or NOT EXISTS sub-query that has "GROUP BY ()"

2019-03-20 Thread GitBox
chunweilei commented on a change in pull request #1121: [CALCITE-2936] Simplify EXISTS or NOT EXISTS sub-query that has "GROUP BY ()" URL: https://github.com/apache/calcite/pull/1121#discussion_r267615145 ## File path:

[GitHub] [calcite] hsyuan opened a new pull request #1121: [CALCITE-2936] Simplify EXISTS or NOT EXISTS sub-query that has "GROUP BY ()"

2019-03-20 Thread GitBox
hsyuan opened a new pull request #1121: [CALCITE-2936] Simplify EXISTS or NOT EXISTS sub-query that has "GROUP BY ()" URL: https://github.com/apache/calcite/pull/1121 JIRA: https://issues.apache.org/jira/browse/CALCITE-2936

[GitHub] [calcite] zhztheplayer commented on a change in pull request #1120: [CALCITE-2933] Add timestamp extract for casts from timestamp type to…

2019-03-21 Thread GitBox
zhztheplayer commented on a change in pull request #1120: [CALCITE-2933] Add timestamp extract for casts from timestamp type to… URL: https://github.com/apache/calcite/pull/1120#discussion_r267646121 ## File path: druid/src/test/java/org/apache/calcite/test/DruidAdapterIT2.java

[GitHub] [calcite] XuQianJin-Stars commented on a change in pull request #1070: [CALCITE-2808]Add the JSON_LENGTH function

2019-03-21 Thread GitBox
XuQianJin-Stars commented on a change in pull request #1070: [CALCITE-2808]Add the JSON_LENGTH function URL: https://github.com/apache/calcite/pull/1070#discussion_r267640584 ## File path: core/src/main/java/org/apache/calcite/sql/fun/SqlJsonApiCommonSyntaxWithoutPathOperator.java

[GitHub] [calcite] asereda-gs commented on issue #1119: [CALCITE-2937] Linq4j: implement LazyEnumerable

2019-03-25 Thread GitBox
asereda-gs commented on issue #1119: [CALCITE-2937] Linq4j: implement LazyEnumerable URL: https://github.com/apache/calcite/pull/1119#issuecomment-476433559 Following discussion on #1101 I'm closing this PR. This is an

[GitHub] [calcite] asereda-gs closed pull request #1119: [CALCITE-2937] Linq4j: implement LazyEnumerable

2019-03-25 Thread GitBox
asereda-gs closed pull request #1119: [CALCITE-2937] Linq4j: implement LazyEnumerable URL: https://github.com/apache/calcite/pull/1119 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [calcite] hsyuan commented on issue #1128: [CALCITE-2946] RelBuilder wrongly skips creation of Aggregate that pr…

2019-03-25 Thread GitBox
hsyuan commented on issue #1128: [CALCITE-2946] RelBuilder wrongly skips creation of Aggregate that pr… URL: https://github.com/apache/calcite/pull/1128#issuecomment-476448598 Need to update test case? This is an automated

[GitHub] [calcite] hsyuan commented on issue #1128: [CALCITE-2946] RelBuilder wrongly skips creation of Aggregate that pr…

2019-03-25 Thread GitBox
hsyuan commented on issue #1128: [CALCITE-2946] RelBuilder wrongly skips creation of Aggregate that pr… URL: https://github.com/apache/calcite/pull/1128#issuecomment-476448445 It looks like LatticeTest failed due to this change. https://issues.apache.org/jira/browse/CALCITE-2953

[GitHub] [calcite] hsyuan commented on a change in pull request #1131: [CALCITE-2829] Fix RexSimplify#processRange cast issue

2019-03-25 Thread GitBox
hsyuan commented on a change in pull request #1131: [CALCITE-2829] Fix RexSimplify#processRange cast issue URL: https://github.com/apache/calcite/pull/1131#discussion_r268943545 ## File path: core/src/main/java/org/apache/calcite/rex/RexSimplify.java ## @@ -315,6 +316,18

[GitHub] [calcite-avatica] leonliao commented on a change in pull request #90: [CALCITE-2950] Avatica DriverVersion.load leaks InputStream

2019-03-25 Thread GitBox
leonliao commented on a change in pull request #90: [CALCITE-2950] Avatica DriverVersion.load leaks InputStream URL: https://github.com/apache/calcite-avatica/pull/90#discussion_r268920054 ## File path: core/src/main/java/org/apache/calcite/avatica/DriverVersion.java ##

[GitHub] [calcite] jh3507 opened a new pull request #1131: [CALCITE-2829] Fix RexSimplify#processRange cast issue

2019-03-25 Thread GitBox
jh3507 opened a new pull request #1131: [CALCITE-2829] Fix RexSimplify#processRange cast issue URL: https://github.com/apache/calcite/pull/1131 - Apply consistent data type when processing ranges for timestamp type Change-Id: Iaac13c5add2699c4a3f5bc1881436e47068784fa

[GitHub] [calcite-avatica] zabetak commented on a change in pull request #88: [hotfix] fix typo in AbstractService

2019-03-25 Thread GitBox
zabetak commented on a change in pull request #88: [hotfix] fix typo in AbstractService URL: https://github.com/apache/calcite-avatica/pull/88#discussion_r268902217 ## File path: core/src/main/java/org/apache/calcite/avatica/remote/AbstractService.java ## @@ -89,7 +89,7

[GitHub] [calcite] leesf opened a new pull request #1132: [CALCITE-2955] SQL queries after first query in same statement have no results returned

2019-03-25 Thread GitBox
leesf opened a new pull request #1132: [CALCITE-2955] SQL queries after first query in same statement have no results returned URL: https://github.com/apache/calcite/pull/1132 see jira:[CALCITE-2955](https://jira.apache.org/jira/browse/CALCITE-2955)

[GitHub] [calcite] asfgit closed pull request #1106: [CALCITE-589] Support materialization of aggregate with grouping sets

2019-03-25 Thread GitBox
asfgit closed pull request #1106: [CALCITE-589] Support materialization of aggregate with grouping sets URL: https://github.com/apache/calcite/pull/1106 This is an automated message from the Apache Git Service. To respond

[GitHub] [calcite-avatica] leonliao commented on a change in pull request #90: [CALCITE-2950] Avatica DriverVersion.load leaks InputStream

2019-03-25 Thread GitBox
leonliao commented on a change in pull request #90: [CALCITE-2950] Avatica DriverVersion.load leaks InputStream URL: https://github.com/apache/calcite-avatica/pull/90#discussion_r268917306 ## File path: core/src/main/java/org/apache/calcite/avatica/DriverVersion.java ##

[GitHub] [calcite-avatica] julianhyde commented on issue #88: Improve exception message in AbstractService

2019-03-27 Thread GitBox
julianhyde commented on issue #88: Improve exception message in AbstractService URL: https://github.com/apache/calcite-avatica/pull/88#issuecomment-477031898 I can't believe how much time we've wasted on this PR. The switch is exhaustive. The throw will never happen. So it doesn't matter

[GitHub] [calcite] zhztheplayer commented on issue #1070: [CALCITE-2808] Add the JSON_LENGTH function

2019-03-27 Thread GitBox
zhztheplayer commented on issue #1070: [CALCITE-2808] Add the JSON_LENGTH function URL: https://github.com/apache/calcite/pull/1070#issuecomment-477037203 > hi @zhztheplayer Calcite 1.19.0 has been released. Can you continue to check this PR? @XuQianJin-Stars Will merge after

[GitHub] [calcite] leesf opened a new pull request #1136: [CALCITE-2958] Upgrade SQLLine to 1.7.0

2019-03-27 Thread GitBox
leesf opened a new pull request #1136: [CALCITE-2958] Upgrade SQLLine to 1.7.0 URL: https://github.com/apache/calcite/pull/1136 Upgrade SQLLine to 1.7.0 This is an automated message from the Apache Git Service. To respond to

[GitHub] [calcite-avatica] zabetak commented on issue #88: Improve exception message in AbstractService

2019-03-27 Thread GitBox
zabetak commented on issue #88: Improve exception message in AbstractService URL: https://github.com/apache/calcite-avatica/pull/88#issuecomment-477037657 I don't believe it is a waste of time. There a was a fruitful discussion on if we want to have default case in enumerations in general

[GitHub] [calcite] chunweilei commented on a change in pull request #1102: [CALCITE-1515] RelBuilder supports creating TableFunctionScan

2019-03-27 Thread GitBox
chunweilei commented on a change in pull request #1102: [CALCITE-1515] RelBuilder supports creating TableFunctionScan URL: https://github.com/apache/calcite/pull/1102#discussion_r269426050 ## File path: core/src/main/java/org/apache/calcite/rel/core/TableFunctionScan.java

[GitHub] [calcite] chunweilei commented on a change in pull request #1102: [CALCITE-1515] RelBuilder supports creating TableFunctionScan

2019-03-27 Thread GitBox
chunweilei commented on a change in pull request #1102: [CALCITE-1515] RelBuilder supports creating TableFunctionScan URL: https://github.com/apache/calcite/pull/1102#discussion_r269426080 ## File path:

[GitHub] [calcite] yuqi1129 commented on a change in pull request #1057: [CALCITE-2854] code gen error for UNARY_MINUS operator call with deci…

2019-03-27 Thread GitBox
yuqi1129 commented on a change in pull request #1057: [CALCITE-2854] code gen error for UNARY_MINUS operator call with deci… URL: https://github.com/apache/calcite/pull/1057#discussion_r269522882 ## File path: core/src/test/java/org/apache/calcite/test/ReflectiveSchemaTest.java

[GitHub] [calcite] chunweilei commented on a change in pull request #912: [CALCITE-2729] introducing WindowReduceExpressionsRule

2019-03-27 Thread GitBox
chunweilei commented on a change in pull request #912: [CALCITE-2729] introducing WindowReduceExpressionsRule URL: https://github.com/apache/calcite/pull/912#discussion_r269429047 ## File path: core/src/test/resources/org/apache/calcite/test/RelOptRulesTest.xml ## @@

[GitHub] [calcite-avatica] vlsi commented on issue #88: Improve exception message in AbstractService

2019-03-27 Thread GitBox
vlsi commented on issue #88: Improve exception message in AbstractService URL: https://github.com/apache/calcite-avatica/pull/88#issuecomment-477048459 @zabetak , I'm afraid I'm with Julian. Each message generates GitHub notification, and it does create disruptions. It forces everybody

[GitHub] [calcite] yuqi1129 commented on a change in pull request #1057: [CALCITE-2854] code gen error for UNARY_MINUS operator call with deci…

2019-03-27 Thread GitBox
yuqi1129 commented on a change in pull request #1057: [CALCITE-2854] code gen error for UNARY_MINUS operator call with deci… URL: https://github.com/apache/calcite/pull/1057#discussion_r269519787 ## File path:

[GitHub] [calcite] zhztheplayer commented on a change in pull request #1057: [CALCITE-2854] code gen error for UNARY_MINUS operator call with deci…

2019-03-27 Thread GitBox
zhztheplayer commented on a change in pull request #1057: [CALCITE-2854] code gen error for UNARY_MINUS operator call with deci… URL: https://github.com/apache/calcite/pull/1057#discussion_r269524420 ## File path:

[GitHub] [calcite] julianhyde commented on issue #1071: [CALCITE-2877] Make GeodeSchema constructor public to pass client cache object

2019-03-27 Thread GitBox
julianhyde commented on issue #1071: [CALCITE-2877] Make GeodeSchema constructor public to pass client cache object URL: https://github.com/apache/calcite/pull/1071#issuecomment-477024050 The Schema should have no more functionality than the SchemaFactory - it is just allowed to accept

  1   2   3   4   5   6   7   8   9   10   >