sonarcloud[bot] commented on PR #3403:
URL: https://github.com/apache/calcite/pull/3403#issuecomment-1698724389
Kudos, SonarCloud Quality Gate passed! [
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
sonarcloud[bot] commented on PR #3396:
URL: https://github.com/apache/calcite/pull/3396#issuecomment-1706875705
Kudos, SonarCloud Quality Gate passed! [ {
@Test void
asolimando commented on code in PR #3367:
URL: https://github.com/apache/calcite/pull/3367#discussion_r1316122429
##
core/src/main/java/org/apache/calcite/rel/rules/MinusToDistinctRule.java:
##
@@ -0,0 +1,184 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
tanclary merged PR #3302:
URL: https://github.com/apache/calcite/pull/3302
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
sonarcloud[bot] commented on PR #3391:
URL: https://github.com/apache/calcite/pull/3391#issuecomment-1706882873
Kudos, SonarCloud Quality Gate passed! [.
--
This is an automated message from the Apache Git Service.
sonarcloud[bot] commented on PR #3396:
URL: https://github.com/apache/calcite/pull/3396#issuecomment-1703854702
Kudos, SonarCloud Quality Gate passed! [ {
sonarcloud[bot] commented on PR #3396:
URL: https://github.com/apache/calcite/pull/3396#issuecomment-1703857503
Kudos, SonarCloud Quality Gate passed! [ {
sonarcloud[bot] commented on PR #3408:
URL: https://github.com/apache/calcite/pull/3408#issuecomment-1707463216
Kudos, SonarCloud Quality Gate passed! [ {
olivrlee commented on code in PR #3391:
URL: https://github.com/apache/calcite/pull/3391#discussion_r1316517662
##
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java:
##
@@ -7538,8 +7610,8 @@ private static void checkIf(SqlOperatorFixture f) {
@Test void
sonarcloud[bot] commented on PR #3408:
URL: https://github.com/apache/calcite/pull/3408#issuecomment-1707454303
Kudos, SonarCloud Quality Gate passed! [
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
tanclary commented on code in PR #3391:
URL: https://github.com/apache/calcite/pull/3391#discussion_r1316550752
##
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java:
##
@@ -7538,8 +7610,8 @@ private static void checkIf(SqlOperatorFixture f) {
@Test void
olivrlee commented on code in PR #3391:
URL: https://github.com/apache/calcite/pull/3391#discussion_r1316551091
##
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java:
##
@@ -7538,8 +7610,8 @@ private static void checkIf(SqlOperatorFixture f) {
@Test void
LakeShen commented on PR #3367:
URL: https://github.com/apache/calcite/pull/3367#issuecomment-1707512690
Hi @tanclary ,could you help me to review this pr again,if you have any
suggestions, please tell me,If not, please help me to approve,thank you so
much:)
--
This is an automated
macroguo-ghy commented on PR #3389:
URL: https://github.com/apache/calcite/pull/3389#issuecomment-1707559374
>
Hi, @tanclary would you like to merge this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
sonarcloud[bot] commented on PR #3359:
URL: https://github.com/apache/calcite/pull/3359#issuecomment-1707678079
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
LakeShen commented on code in PR #3367:
URL: https://github.com/apache/calcite/pull/3367#discussion_r1313824184
##
core/src/test/java/org/apache/calcite/test/JdbcTest.java:
##
@@ -3773,6 +3774,35 @@ public void checkOrderBy(final boolean desc,
"empid=110;
LakeShen commented on PR #3367:
URL: https://github.com/apache/calcite/pull/3367#issuecomment-1703830009
@tanclary @asolimando @NobiGo ,Thank you for your review suggestions. I have
modified according to the suggestions. If you have time, please help me review
it again:)
--
This is an
rubenada commented on code in PR #3382:
URL: https://github.com/apache/calcite/pull/3382#discussion_r1314595347
##
core/src/main/java/org/apache/calcite/rel/metadata/RelMdRowCount.java:
##
@@ -169,6 +170,12 @@ public Double getRowCount(Calc rel, RelMetadataQuery mq) {
LeonidChistov opened a new pull request, #3407:
URL: https://github.com/apache/calcite/pull/3407
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
chucheng92 commented on PR #3405:
URL: https://github.com/apache/calcite/pull/3405#issuecomment-1704876596
@NobiGo hi. If you have time, could you help to review it again? thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
sonarcloud[bot] commented on PR #3407:
URL: https://github.com/apache/calcite/pull/3407#issuecomment-1704882138
Kudos, SonarCloud Quality Gate passed! [ {
sonarcloud[bot] commented on PR #3407:
URL: https://github.com/apache/calcite/pull/3407#issuecomment-1705477282
Kudos, SonarCloud Quality Gate passed! [ {
kgyrtkirk merged PR #3400:
URL: https://github.com/apache/calcite/pull/3400
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
rubenada commented on code in PR #3311:
URL: https://github.com/apache/calcite/pull/3311#discussion_r1315141021
##
linq4j/src/main/java/org/apache/calcite/linq4j/EnumerableDefaults.java:
##
@@ -4495,6 +4492,27 @@ private boolean advanceRight(TInner right, TKey
rightKey) {
LakeShen commented on code in PR #3396:
URL: https://github.com/apache/calcite/pull/3396#discussion_r1315336549
##
core/src/test/java/org/apache/calcite/test/RelOptRulesTest.java:
##
@@ -1254,6 +1254,54 @@ private void
checkSemiOrAntiJoinProjectTranspose(JoinRelType type) {
LakeShen commented on code in PR #3396:
URL: https://github.com/apache/calcite/pull/3396#discussion_r1315336125
##
core/src/main/java/org/apache/calcite/rel/rules/SortMergeRule.java:
##
@@ -0,0 +1,146 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
sonarcloud[bot] commented on PR #3311:
URL: https://github.com/apache/calcite/pull/3311#issuecomment-1706161843
Kudos, SonarCloud Quality Gate passed! [ {
}
}
for (RelSubset
sonarcloud[bot] commented on PR #3397:
URL: https://github.com/apache/calcite/pull/3397#issuecomment-1712771007
Kudos, SonarCloud Quality Gate passed! [
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
macroguo-ghy opened a new pull request, #3416:
URL: https://github.com/apache/calcite/pull/3416
Simplify 'p OR NOT p' to 'TRUE' (if p is not nullable), or to 'null AND p IS
NOT NULL' (if p is nullable).
GeodeFilter support converting 'p IS NOT NULL' to 'p <> null'.
--
This is an
sonarcloud[bot] commented on PR #3390:
URL: https://github.com/apache/calcite/pull/3390#issuecomment-1712803161
Kudos, SonarCloud Quality Gate passed! [
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
sonarcloud[bot] commented on PR #3414:
URL: https://github.com/apache/calcite/pull/3414#issuecomment-1712749646
Kudos, SonarCloud Quality Gate passed! [ {
interface Action {
void check(RexBuilder
LakeShen commented on PR #3406:
URL: https://github.com/apache/calcite/pull/3406#issuecomment-1709895369
Hi @zoov-w ,don't begin with fix to the title of a JIRA, should describe the
problem behavior.
BTW, you could rebase the latest code of main branch,the commits and files
changed
sonarcloud[bot] commented on PR #3416:
URL: https://github.com/apache/calcite/pull/3416#issuecomment-1713655572
Kudos, SonarCloud Quality Gate passed! [ {
interface Action {
void check(RexBuilder
macroguo-ghy commented on code in PR #3416:
URL: https://github.com/apache/calcite/pull/3416#discussion_r1321367481
##
core/src/main/java/org/apache/calcite/rex/RexSimplify.java:
##
@@ -1993,6 +1993,7 @@ private RexNode simplifyOrs(List terms,
RexUnknownAs unknownAs) {
//
LakeShen commented on PR #3367:
URL: https://github.com/apache/calcite/pull/3367#issuecomment-1713692808
Hi @tanclary ,could you help me to approve this pr if you don't have the
suggestions,thank you so much.
--
This is an automated message from the Apache Git Service.
To respond to the
1 - 100 of 9414 matches
Mail list logo
