[
https://issues.apache.org/jira/browse/CASSANDRA-6572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14154440#comment-14154440
]
Jonathan Shook commented on CASSANDRA-6572:
---
I believe that we do need a
[
https://issues.apache.org/jira/browse/CASSANDRA-6572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14153974#comment-14153974
]
Carl Yeksigian commented on CASSANDRA-6572:
---
I have a rebase of the branch
[
https://issues.apache.org/jira/browse/CASSANDRA-6572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14154005#comment-14154005
]
Aleksey Yeschenko commented on CASSANDRA-6572:
--
I agree with Carl's
[
https://issues.apache.org/jira/browse/CASSANDRA-6572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14154253#comment-14154253
]
Jonathan Ellis commented on CASSANDRA-6572:
---
bq. We also might want to
[
https://issues.apache.org/jira/browse/CASSANDRA-6572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14073141#comment-14073141
]
Lyuben Todorov commented on CASSANDRA-6572:
---
bq. It looks to me like you
[
https://issues.apache.org/jira/browse/CASSANDRA-6572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14071594#comment-14071594
]
Lyuben Todorov commented on CASSANDRA-6572:
---
Summary of commit
[
https://issues.apache.org/jira/browse/CASSANDRA-6572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14071759#comment-14071759
]
Benedict commented on CASSANDRA-6572:
-
It looks to me like you need some way to
[
https://issues.apache.org/jira/browse/CASSANDRA-6572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14070368#comment-14070368
]
Lyuben Todorov commented on CASSANDRA-6572:
---
Added thread id to the logs in
[
https://issues.apache.org/jira/browse/CASSANDRA-6572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14069328#comment-14069328
]
Lyuben Todorov commented on CASSANDRA-6572:
---
variablesClone was used for
[
https://issues.apache.org/jira/browse/CASSANDRA-6572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14066198#comment-14066198
]
Lyuben Todorov commented on CASSANDRA-6572:
---
Added support for prepared
[
https://issues.apache.org/jira/browse/CASSANDRA-6572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14066230#comment-14066230
]
Benedict commented on CASSANDRA-6572:
-
A few brief comments:
# bb.limit() is
[
https://issues.apache.org/jira/browse/CASSANDRA-6572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14018301#comment-14018301
]
Benedict commented on CASSANDRA-6572:
-
* You need to move the getAndSet() on line
[
https://issues.apache.org/jira/browse/CASSANDRA-6572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14016577#comment-14016577
]
Lyuben Todorov commented on CASSANDRA-6572:
---
Pushed updates to
[
https://issues.apache.org/jira/browse/CASSANDRA-6572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14006452#comment-14006452
]
Lyuben Todorov commented on CASSANDRA-6572:
---
Commit
[
https://issues.apache.org/jira/browse/CASSANDRA-6572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14006555#comment-14006555
]
Benedict commented on CASSANDRA-6572:
-
bq. Added a small optimisation, BBs used
[
https://issues.apache.org/jira/browse/CASSANDRA-6572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14005147#comment-14005147
]
Benedict commented on CASSANDRA-6572:
-
bq. Why do we want to store completed QQs
[
https://issues.apache.org/jira/browse/CASSANDRA-6572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14004097#comment-14004097
]
Lyuben Todorov commented on CASSANDRA-6572:
---
bq. put any finished flushing
[
https://issues.apache.org/jira/browse/CASSANDRA-6572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14001053#comment-14001053
]
Benedict commented on CASSANDRA-6572:
-
Thanks - some comments on the latest patch:
[
https://issues.apache.org/jira/browse/CASSANDRA-6572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14000864#comment-14000864
]
Lyuben Todorov commented on CASSANDRA-6572:
---
Updated the branch on
[
https://issues.apache.org/jira/browse/CASSANDRA-6572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13993673#comment-13993673
]
Benedict commented on CASSANDRA-6572:
-
Points 1 and 2 need to be atomic, so you
[
https://issues.apache.org/jira/browse/CASSANDRA-6572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13993455#comment-13993455
]
Lyuben Todorov commented on CASSANDRA-6572:
---
I'm not too sure about the
[
https://issues.apache.org/jira/browse/CASSANDRA-6572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13990589#comment-13990589
]
Benedict commented on CASSANDRA-6572:
-
Thanks for the update. A couple of nits:
*
[
https://issues.apache.org/jira/browse/CASSANDRA-6572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13986542#comment-13986542
]
Lyuben Todorov commented on CASSANDRA-6572:
---
I added a commit
[
https://issues.apache.org/jira/browse/CASSANDRA-6572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13986591#comment-13986591
]
Benedict commented on CASSANDRA-6572:
-
Some comments on the in progress patch:
*
[
https://issues.apache.org/jira/browse/CASSANDRA-6572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13985239#comment-13985239
]
Lyuben Todorov commented on CASSANDRA-6572:
---
Once a switch is made to a
[
https://issues.apache.org/jira/browse/CASSANDRA-6572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13985381#comment-13985381
]
Benedict commented on CASSANDRA-6572:
-
I wouldn't worry about the negligible
[
https://issues.apache.org/jira/browse/CASSANDRA-6572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13985649#comment-13985649
]
Lyuben Todorov commented on CASSANDRA-6572:
---
Since queries are logged as
[
https://issues.apache.org/jira/browse/CASSANDRA-6572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13985695#comment-13985695
]
Benedict commented on CASSANDRA-6572:
-
It might be easiest to modify
[
https://issues.apache.org/jira/browse/CASSANDRA-6572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13983190#comment-13983190
]
Jonathan Ellis commented on CASSANDRA-6572:
---
Suggest also storing whatever
[
https://issues.apache.org/jira/browse/CASSANDRA-6572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13977104#comment-13977104
]
Tyler Hobbs commented on CASSANDRA-6572:
In addition to Benedict's comments,
[
https://issues.apache.org/jira/browse/CASSANDRA-6572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13977157#comment-13977157
]
Benedict commented on CASSANDRA-6572:
-
Thanks [~thobbs]. There are a few other
[
https://issues.apache.org/jira/browse/CASSANDRA-6572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13972845#comment-13972845
]
Benedict commented on CASSANDRA-6572:
-
[~lyubent] a few comments/suggestions about
[
https://issues.apache.org/jira/browse/CASSANDRA-6572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13969839#comment-13969839
]
Jonathan Ellis commented on CASSANDRA-6572:
---
How do you deal w/ prepared vs
[
https://issues.apache.org/jira/browse/CASSANDRA-6572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13970268#comment-13970268
]
Aleksey Yeschenko commented on CASSANDRA-6572:
--
I'd say 3.0, with 2.1
[
https://issues.apache.org/jira/browse/CASSANDRA-6572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13937417#comment-13937417
]
Lyuben Todorov commented on CASSANDRA-6572:
---
Is there a better alternative
[
https://issues.apache.org/jira/browse/CASSANDRA-6572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13903514#comment-13903514
]
Lyuben Todorov commented on CASSANDRA-6572:
---
Just an update with progress so
[
https://issues.apache.org/jira/browse/CASSANDRA-6572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13896580#comment-13896580
]
Lyuben Todorov commented on CASSANDRA-6572:
---
Just a though, do we want to
[
https://issues.apache.org/jira/browse/CASSANDRA-6572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13896631#comment-13896631
]
Jonathan Ellis commented on CASSANDRA-6572:
---
Yes, we should ignore those
[
https://issues.apache.org/jira/browse/CASSANDRA-6572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13892875#comment-13892875
]
Aleksey Yeschenko commented on CASSANDRA-6572:
--
bq. Do you have any
[
https://issues.apache.org/jira/browse/CASSANDRA-6572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13891605#comment-13891605
]
Jeremiah Jordan commented on CASSANDRA-6572:
i would think saving this to
[
https://issues.apache.org/jira/browse/CASSANDRA-6572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13891620#comment-13891620
]
Jonathan Ellis commented on CASSANDRA-6572:
---
Agreed on both counts.
[
https://issues.apache.org/jira/browse/CASSANDRA-6572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13889939#comment-13889939
]
Lyuben Todorov commented on CASSANDRA-6572:
---
I think it would be easier for
[
https://issues.apache.org/jira/browse/CASSANDRA-6572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13890012#comment-13890012
]
Jonathan Ellis commented on CASSANDRA-6572:
---
Why split the work across two
[
https://issues.apache.org/jira/browse/CASSANDRA-6572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13890421#comment-13890421
]
Lyuben Todorov commented on CASSANDRA-6572:
---
I thought it would make more
[
https://issues.apache.org/jira/browse/CASSANDRA-6572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13890436#comment-13890436
]
Jonathan Ellis commented on CASSANDRA-6572:
---
Do you have any strong feelings
[
https://issues.apache.org/jira/browse/CASSANDRA-6572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13873223#comment-13873223
]
Jimmy MÃ¥rdell commented on CASSANDRA-6572:
--
Sounds interesting, but it's not
[
https://issues.apache.org/jira/browse/CASSANDRA-6572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13869328#comment-13869328
]
Marcus Eriksson commented on CASSANDRA-6572:
[~yarin] something for you
[
https://issues.apache.org/jira/browse/CASSANDRA-6572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13868422#comment-13868422
]
Jonathan Ellis commented on CASSANDRA-6572:
---
IMO the two options to
48 matches
Mail list logo