[GitHub] dhlaluku commented on issue #2848: Vmware offline migration

2018-11-13 Thread GitBox
dhlaluku commented on issue #2848: Vmware offline migration URL: https://github.com/apache/cloudstack/pull/2848#issuecomment-438181200 @blueorangutan test matrix This is an automated message from the Apache Git Service. To

[cloudstack] 01/01: Updating pom.xml version numbers for release 4.11.2.0

2018-11-13 Thread paul_a
This is an automated email from the ASF dual-hosted git repository. paul_a pushed a commit to branch 4.11.2.0-RC20181113T0924 in repository https://gitbox.apache.org/repos/asf/cloudstack.git commit 5aae410dfce2bef5cc21a0892370cb5d0628f681 Author: Paul Angus AuthorDate: Tue Nov 13 09:24:27 2018

[cloudstack] branch 4.11.2.0-RC20181113T0924 created (now 5aae410)

2018-11-13 Thread paul_a
This is an automated email from the ASF dual-hosted git repository. paul_a pushed a change to branch 4.11.2.0-RC20181113T0924 in repository https://gitbox.apache.org/repos/asf/cloudstack.git. at 5aae410 Updating pom.xml version numbers for release 4.11.2.0 This branch includes the

svn commit: r30870 - in /dev/cloudstack/4.11.2.0: apache-cloudstack-4.11.2.0-src.tar.bz2 apache-cloudstack-4.11.2.0-src.tar.bz2.asc apache-cloudstack-4.11.2.0-src.tar.bz2.md5 apache-cloudstack-4.11.2.

2018-11-13 Thread paul_a
Author: paul_a Date: Tue Nov 13 09:24:57 2018 New Revision: 30870 Log: Committing release candidate artifacts for 4.11.2.0 to dist/dev/cloudstack in preparation for release vote Added: dev/cloudstack/4.11.2.0/apache-cloudstack-4.11.2.0-src.tar.bz2 (with props)

[GitHub] blueorangutan commented on issue #2990: Security Group: add secondary ips to the correct ipset based on ip family (4.11)

2018-11-13 Thread GitBox
blueorangutan commented on issue #2990: Security Group: add secondary ips to the correct ipset based on ip family (4.11) URL: https://github.com/apache/cloudstack/pull/2990#issuecomment-438216705 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke

[GitHub] rhtyd commented on issue #2990: Security Group: add secondary ips to the correct ipset based on ip family (4.11)

2018-11-13 Thread GitBox
rhtyd commented on issue #2990: Security Group: add secondary ips to the correct ipset based on ip family (4.11) URL: https://github.com/apache/cloudstack/pull/2990#issuecomment-438216490 @blueorangutan test This is an

[GitHub] blueorangutan commented on issue #2990: Security Group: add secondary ips to the correct ipset based on ip family (4.11)

2018-11-13 Thread GitBox
blueorangutan commented on issue #2990: Security Group: add secondary ips to the correct ipset based on ip family (4.11) URL: https://github.com/apache/cloudstack/pull/2990#issuecomment-438176087 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make

[GitHub] rhtyd commented on issue #2990: Security Group: add secondary ips to the correct ipset based on ip family (4.11)

2018-11-13 Thread GitBox
rhtyd commented on issue #2990: Security Group: add secondary ips to the correct ipset based on ip family (4.11) URL: https://github.com/apache/cloudstack/pull/2990#issuecomment-438176012 @blueorangutan package This is an

[GitHub] blueorangutan commented on issue #2848: Vmware offline migration

2018-11-13 Thread GitBox
blueorangutan commented on issue #2848: Vmware offline migration URL: https://github.com/apache/cloudstack/pull/2848#issuecomment-438181454 @dhlaluku a Trillian-Jenkins matrix job (centos6 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

[GitHub] blueorangutan commented on issue #2990: Security Group: add secondary ips to the correct ipset based on ip family (4.11)

2018-11-13 Thread GitBox
blueorangutan commented on issue #2990: Security Group: add secondary ips to the correct ipset based on ip family (4.11) URL: https://github.com/apache/cloudstack/pull/2990#issuecomment-438214623 Packaging result: ✔centos6 ✖centos7 ✔debian. JID-2437

[GitHub] blueorangutan commented on issue #2992: PoC for log library surface reduction (2991)

2018-11-13 Thread GitBox
blueorangutan commented on issue #2992: PoC for log library surface reduction (2991) URL: https://github.com/apache/cloudstack/pull/2992#issuecomment-438214622 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2436 This is an

[GitHub] rhtyd commented on issue #3014: Remove unused StrategyPriority.PLUGIN

2018-11-13 Thread GitBox
rhtyd commented on issue #3014: Remove unused StrategyPriority.PLUGIN URL: https://github.com/apache/cloudstack/pull/3014#issuecomment-438221762 I'm okay to remove the enum if it's not used by anything or stored in db. This

[GitHub] blueorangutan commented on issue #2997: Allow KVM VM live migration with ROOT volume on file storage type

2018-11-13 Thread GitBox
blueorangutan commented on issue #2997: Allow KVM VM live migration with ROOT volume on file storage type URL: https://github.com/apache/cloudstack/pull/2997#issuecomment-438229261 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2438

[GitHub] andrijapanic commented on issue #3020: Add KVM Guest OS mapping for Windows Server 2019

2018-11-13 Thread GitBox
andrijapanic commented on issue #3020: Add KVM Guest OS mapping for Windows Server 2019 URL: https://github.com/apache/cloudstack/pull/3020#issuecomment-438271031 I'm aware of these two, but have no idea really where these can be used for new release ? ( I can execute them on live

[GitHub] andrijapanic commented on issue #3020: Add KVM Guest OS mapping for Windows Server 2019

2018-11-13 Thread GitBox
andrijapanic commented on issue #3020: Add KVM Guest OS mapping for Windows Server 2019 URL: https://github.com/apache/cloudstack/pull/3020#issuecomment-438230573 @DaanHoogland Not sure where to look at (about issue) ? Haven't been playing so far with Apache Jenkins...

[GitHub] GabrielBrascher edited a comment on issue #3014: Remove unused StrategyPriority.PLUGIN

2018-11-13 Thread GitBox
GabrielBrascher edited a comment on issue #3014: Remove unused StrategyPriority.PLUGIN URL: https://github.com/apache/cloudstack/pull/3014#issuecomment-438244730 @DaanHoogland there is no practical need to remove this enum. I was implementing KVM local to local storage migration and got a

[GitHub] DennisKonrad commented on issue #3022: systemvmtemplate: update debian 9.6 iso url and checksum

2018-11-13 Thread GitBox
DennisKonrad commented on issue #3022: systemvmtemplate: update debian 9.6 iso url and checksum URL: https://github.com/apache/cloudstack/pull/3022#issuecomment-438218685 @rhtyd can this also go to master? This is an

[GitHub] DaanHoogland commented on issue #3020: Add KVM Guest OS mapping for Windows Server 2019

2018-11-13 Thread GitBox
DaanHoogland commented on issue #3020: Add KVM Guest OS mapping for Windows Server 2019 URL: https://github.com/apache/cloudstack/pull/3020#issuecomment-438267763 @andrijapanic, Jenkins is fine now. I'm the only culprit ATM; I think AddGuestOsCmd and a AddGuestOsMappingCmd should be used

[GitHub] GabrielBrascher commented on issue #2997: Allow KVM VM live migration with ROOT volume on file storage type

2018-11-13 Thread GitBox
GabrielBrascher commented on issue #2997: Allow KVM VM live migration with ROOT volume on file storage type URL: https://github.com/apache/cloudstack/pull/2997#issuecomment-438222982 @blueorangutan package This is an

[GitHub] blueorangutan commented on issue #2997: Allow KVM VM live migration with ROOT volume on file storage type

2018-11-13 Thread GitBox
blueorangutan commented on issue #2997: Allow KVM VM live migration with ROOT volume on file storage type URL: https://github.com/apache/cloudstack/pull/2997#issuecomment-438223044 @GabrielBrascher a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] nvazquez commented on issue #2997: Allow KVM VM live migration with ROOT volume on file storage type

2018-11-13 Thread GitBox
nvazquez commented on issue #2997: Allow KVM VM live migration with ROOT volume on file storage type URL: https://github.com/apache/cloudstack/pull/2997#issuecomment-438233275 @blueorangutan test This is an automated message

[GitHub] blueorangutan commented on issue #2997: Allow KVM VM live migration with ROOT volume on file storage type

2018-11-13 Thread GitBox
blueorangutan commented on issue #2997: Allow KVM VM live migration with ROOT volume on file storage type URL: https://github.com/apache/cloudstack/pull/2997#issuecomment-438233454 @nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[GitHub] GabrielBrascher edited a comment on issue #3014: Remove unused StrategyPriority.PLUGIN

2018-11-13 Thread GitBox
GabrielBrascher edited a comment on issue #3014: Remove unused StrategyPriority.PLUGIN URL: https://github.com/apache/cloudstack/pull/3014#issuecomment-438244730 @DaanHoogland there is no practical need to remove this enum. I was implementing KVM local to local storage migration and got a

[GitHub] rhtyd commented on a change in pull request #2992: PoC for log library surface reduction (2991)

2018-11-13 Thread GitBox
rhtyd commented on a change in pull request #2992: PoC for log library surface reduction (2991) URL: https://github.com/apache/cloudstack/pull/2992#discussion_r232985136 ## File path: utils/src/main/java/com/cloud/utils/AutoCloseableUtil.java ## @@ -16,10 +16,11 @@ //

[GitHub] rhtyd commented on a change in pull request #2992: PoC for log library surface reduction (2991)

2018-11-13 Thread GitBox
rhtyd commented on a change in pull request #2992: PoC for log library surface reduction (2991) URL: https://github.com/apache/cloudstack/pull/2992#discussion_r232984935 ## File path: utils/src/main/java/org/apache/cloudstack/utils/log/LogFactory.java ## @@ -0,0 +1,26 @@

[GitHub] DaanHoogland commented on a change in pull request #2992: PoC for log library surface reduction (2991)

2018-11-13 Thread GitBox
DaanHoogland commented on a change in pull request #2992: PoC for log library surface reduction (2991) URL: https://github.com/apache/cloudstack/pull/2992#discussion_r233026748 ## File path: utils/src/main/java/com/cloud/utils/AutoCloseableUtil.java ## @@ -16,10 +16,11 @@

[GitHub] DaanHoogland commented on a change in pull request #2992: PoC for log library surface reduction (2991)

2018-11-13 Thread GitBox
DaanHoogland commented on a change in pull request #2992: PoC for log library surface reduction (2991) URL: https://github.com/apache/cloudstack/pull/2992#discussion_r233026841 ## File path: utils/src/main/java/org/apache/cloudstack/utils/log/LogFactory.java ## @@ -0,0

[GitHub] DaanHoogland commented on issue #3014: Remove unused StrategyPriority.PLUGIN

2018-11-13 Thread GitBox
DaanHoogland commented on issue #3014: Remove unused StrategyPriority.PLUGIN URL: https://github.com/apache/cloudstack/pull/3014#issuecomment-438268162 ok, tnx @GabrielBrascher . Let's do it This is an automated message from

[cloudstack] 01/01: Merge remote-tracking branch 'origin/4.11'

2018-11-13 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git commit a75cfd4d0683184719021210006efff63b87ff3f Merge: 4809fe7 4d8e75c Author: Rohit Yadav AuthorDate: Tue Nov 13 16:13:52

[GitHub] rhtyd commented on issue #3022: systemvmtemplate: update debian 9.6 iso url and checksum

2018-11-13 Thread GitBox
rhtyd commented on issue #3022: systemvmtemplate: update debian 9.6 iso url and checksum URL: https://github.com/apache/cloudstack/pull/3022#issuecomment-438220504 @DennisKonrad yes, forward merged to master. Pull/rebase to latest master.

[cloudstack] branch master updated (4809fe7 -> a75cfd4)

2018-11-13 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from 4809fe7 kvm/ceph: When create a new RBD image use modern flags/features for the image (#2985) add dea0b3e

[GitHub] GabrielBrascher commented on issue #3014: Remove unused StrategyPriority.PLUGIN

2018-11-13 Thread GitBox
GabrielBrascher commented on issue #3014: Remove unused StrategyPriority.PLUGIN URL: https://github.com/apache/cloudstack/pull/3014#issuecomment-438244730 @DaanHoogland there is no pratical need to remove this enum. I was just implementing KVM local to local storage migration and got a bit

[GitHub] dhlaluku commented on issue #2848: Vmware offline migration

2018-11-13 Thread GitBox
dhlaluku commented on issue #2848: Vmware offline migration URL: https://github.com/apache/cloudstack/pull/2848#issuecomment-438201023 @nvazquez @rhtyd @rafaelweingartner @mike-tutkowski @borisstoyanov please review This is

[GitHub] mike-tutkowski commented on issue #2848: Vmware offline migration

2018-11-13 Thread GitBox
mike-tutkowski commented on issue #2848: Vmware offline migration URL: https://github.com/apache/cloudstack/pull/2848#issuecomment-438338419 @DaanHoogland Somehow I didn't notice the request for review here, Daan. I should be able to get to this soon.

[GitHub] dubauski opened a new issue #3025: VPC Router Corruption when working with large number of networks containing instances with public IP addresses

2018-11-13 Thread GitBox
dubauski opened a new issue #3025: VPC Router Corruption when working with large number of networks containing instances with public IP addresses URL: https://github.com/apache/cloudstack/issues/3025

[GitHub] GabrielBrascher commented on a change in pull request #2660: Macaddresses

2018-11-13 Thread GitBox
GabrielBrascher commented on a change in pull request #2660: Macaddresses URL: https://github.com/apache/cloudstack/pull/2660#discussion_r233235122 ## File path: utils/src/main/java/com/cloud/utils/net/MacAddress.java ## @@ -31,9 +31,9 @@ import org.apache.log4j.Logger;

[GitHub] GabrielBrascher commented on a change in pull request #2660: Macaddresses

2018-11-13 Thread GitBox
GabrielBrascher commented on a change in pull request #2660: Macaddresses URL: https://github.com/apache/cloudstack/pull/2660#discussion_r233224675 ## File path: utils/src/test/java/com/cloud/utils/net/MacAddressTest.java ## @@ -51,10 +51,4 @@ public final void

[GitHub] DennisKonrad commented on issue #2930: HA for Management Server - roundrobin: Certificate ownership

2018-11-13 Thread GitBox
DennisKonrad commented on issue #2930: HA for Management Server - roundrobin: Certificate ownership URL: https://github.com/apache/cloudstack/issues/2930#issuecomment-438455586 @rhtyd Starting one management up and later adding the second one did not work. So I tried the following

[GitHub] blueorangutan commented on issue #2848: Vmware offline migration

2018-11-13 Thread GitBox
blueorangutan commented on issue #2848: Vmware offline migration URL: https://github.com/apache/cloudstack/pull/2848#issuecomment-438483926 Trillian test result (tid-3176) Environment: vmware-65 (x2), Advanced Networking with Mgmt server 7 Total time taken: 51235 seconds Marvin

[GitHub] blueorangutan commented on issue #3021: Skip network migration tests for not supported hypervisors instead of failing

2018-11-13 Thread GitBox
blueorangutan commented on issue #3021: Skip network migration tests for not supported hypervisors instead of failing URL: https://github.com/apache/cloudstack/pull/3021#issuecomment-438464839 Trillian test result (tid-3173) Environment: xenserver-65sp1 (x2), Advanced Networking with

[GitHub] rhtyd commented on issue #2930: HA for Management Server - roundrobin: Certificate ownership

2018-11-13 Thread GitBox
rhtyd commented on issue #2930: HA for Management Server - roundrobin: Certificate ownership URL: https://github.com/apache/cloudstack/issues/2930#issuecomment-438518018 @DennisKonrad can you check in the logs if your kvm hosts are trying connect at all? You can try to delete the old

[GitHub] GabrielBrascher commented on a change in pull request #2997: Allow KVM VM live migration with ROOT volume on file storage type

2018-11-13 Thread GitBox
GabrielBrascher commented on a change in pull request #2997: Allow KVM VM live migration with ROOT volume on file storage type URL: https://github.com/apache/cloudstack/pull/2997#discussion_r233310696 ## File path:

[GitHub] GabrielBrascher commented on a change in pull request #2997: Allow KVM VM live migration with ROOT volume on file storage type

2018-11-13 Thread GitBox
GabrielBrascher commented on a change in pull request #2997: Allow KVM VM live migration with ROOT volume on file storage type URL: https://github.com/apache/cloudstack/pull/2997#discussion_r233310484 ## File path:

[GitHub] GabrielBrascher commented on a change in pull request #2997: Allow KVM VM live migration with ROOT volume on file storage type

2018-11-13 Thread GitBox
GabrielBrascher commented on a change in pull request #2997: Allow KVM VM live migration with ROOT volume on file storage type URL: https://github.com/apache/cloudstack/pull/2997#discussion_r233310370 ## File path:

[GitHub] nvazquez commented on issue #3021: Skip network migration tests for not supported hypervisors instead of failing

2018-11-13 Thread GitBox
nvazquez commented on issue #3021: Skip network migration tests for not supported hypervisors instead of failing URL: https://github.com/apache/cloudstack/pull/3021#issuecomment-438521507 @blueorangutan test centos7 xenserver-65sp1

[GitHub] blueorangutan commented on issue #2997: Allow KVM VM live migration with ROOT volume on file storage type

2018-11-13 Thread GitBox
blueorangutan commented on issue #2997: Allow KVM VM live migration with ROOT volume on file storage type URL: https://github.com/apache/cloudstack/pull/2997#issuecomment-438534998 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2440

[GitHub] blueorangutan commented on issue #3021: Skip network migration tests for not supported hypervisors instead of failing

2018-11-13 Thread GitBox
blueorangutan commented on issue #3021: Skip network migration tests for not supported hypervisors instead of failing URL: https://github.com/apache/cloudstack/pull/3021#issuecomment-438521638 @nvazquez a Trillian-Jenkins test job (centos7 mgmt + xenserver-65sp1) has been kicked to run

[GitHub] GabrielBrascher commented on a change in pull request #2997: Allow KVM VM live migration with ROOT volume on file storage type

2018-11-13 Thread GitBox
GabrielBrascher commented on a change in pull request #2997: Allow KVM VM live migration with ROOT volume on file storage type URL: https://github.com/apache/cloudstack/pull/2997#discussion_r233311445 ## File path:

[GitHub] nvazquez commented on issue #3021: Skip network migration tests for not supported hypervisors instead of failing

2018-11-13 Thread GitBox
nvazquez commented on issue #3021: Skip network migration tests for not supported hypervisors instead of failing URL: https://github.com/apache/cloudstack/pull/3021#issuecomment-438517456 Failures fixed, tested in my local environment :~/cloudstack$ cat

[GitHub] blueorangutan commented on issue #3021: Skip network migration tests for not supported hypervisors instead of failing

2018-11-13 Thread GitBox
blueorangutan commented on issue #3021: Skip network migration tests for not supported hypervisors instead of failing URL: https://github.com/apache/cloudstack/pull/3021#issuecomment-438517535 @nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make

[GitHub] blueorangutan commented on issue #3021: Skip network migration tests for not supported hypervisors instead of failing

2018-11-13 Thread GitBox
blueorangutan commented on issue #3021: Skip network migration tests for not supported hypervisors instead of failing URL: https://github.com/apache/cloudstack/pull/3021#issuecomment-438521072 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2439

[GitHub] blueorangutan commented on issue #2997: Allow KVM VM live migration with ROOT volume on file storage type

2018-11-13 Thread GitBox
blueorangutan commented on issue #2997: Allow KVM VM live migration with ROOT volume on file storage type URL: https://github.com/apache/cloudstack/pull/2997#issuecomment-438532202 @GabrielBrascher a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] GabrielBrascher commented on issue #2997: Allow KVM VM live migration with ROOT volume on file storage type

2018-11-13 Thread GitBox
GabrielBrascher commented on issue #2997: Allow KVM VM live migration with ROOT volume on file storage type URL: https://github.com/apache/cloudstack/pull/2997#issuecomment-438532061 @blueorangutan package This is an

[GitHub] rafaelweingartner commented on a change in pull request #2848: Vmware offline migration

2018-11-13 Thread GitBox
rafaelweingartner commented on a change in pull request #2848: Vmware offline migration URL: https://github.com/apache/cloudstack/pull/2848#discussion_r233214364 ## File path: engine/orchestration/src/main/java/com/cloud/vm/VirtualMachineManagerImpl.java ## @@ -1976,92

[GitHub] rafaelweingartner commented on a change in pull request #2848: Vmware offline migration

2018-11-13 Thread GitBox
rafaelweingartner commented on a change in pull request #2848: Vmware offline migration URL: https://github.com/apache/cloudstack/pull/2848#discussion_r233214939 ## File path: engine/orchestration/src/main/java/com/cloud/vm/VirtualMachineManagerImpl.java ## @@ -1976,92

[GitHub] rafaelweingartner commented on a change in pull request #2848: Vmware offline migration

2018-11-13 Thread GitBox
rafaelweingartner commented on a change in pull request #2848: Vmware offline migration URL: https://github.com/apache/cloudstack/pull/2848#discussion_r233212308 ## File path: core/src/main/java/com/cloud/agent/api/UnregisterVMCommand.java ## @@ -22,14 +22,19 @@ public

[GitHub] rafaelweingartner commented on a change in pull request #2848: Vmware offline migration

2018-11-13 Thread GitBox
rafaelweingartner commented on a change in pull request #2848: Vmware offline migration URL: https://github.com/apache/cloudstack/pull/2848#discussion_r233212888 ## File path: engine/components-api/src/main/java/com/cloud/storage/StorageManager.java ## @@ -106,7 +106,14

[GitHub] rafaelweingartner commented on a change in pull request #2848: Vmware offline migration

2018-11-13 Thread GitBox
rafaelweingartner commented on a change in pull request #2848: Vmware offline migration URL: https://github.com/apache/cloudstack/pull/2848#discussion_r233211404 ## File path: api/src/main/java/org/apache/cloudstack/api/command/admin/vm/MigrateVMCmd.java ## @@ -192,4

[GitHub] rafaelweingartner commented on a change in pull request #2848: Vmware offline migration

2018-11-13 Thread GitBox
rafaelweingartner commented on a change in pull request #2848: Vmware offline migration URL: https://github.com/apache/cloudstack/pull/2848#discussion_r233212190 ## File path: core/src/main/java/com/cloud/agent/api/MigrateVmToPoolCommand.java ## @@ -0,0 +1,70 @@ +// +//

[GitHub] rafaelweingartner commented on a change in pull request #2848: Vmware offline migration

2018-11-13 Thread GitBox
rafaelweingartner commented on a change in pull request #2848: Vmware offline migration URL: https://github.com/apache/cloudstack/pull/2848#discussion_r233211822 ## File path: api/src/main/java/org/apache/cloudstack/api/command/user/volume/MigrateVolumeCmd.java ## @@

[GitHub] rafaelweingartner commented on a change in pull request #2848: Vmware offline migration

2018-11-13 Thread GitBox
rafaelweingartner commented on a change in pull request #2848: Vmware offline migration URL: https://github.com/apache/cloudstack/pull/2848#discussion_r233213044 ## File path: engine/api/src/main/java/org/apache/cloudstack/engine/subsystem/api/storage/DataMotionStrategy.java

[GitHub] rafaelweingartner commented on a change in pull request #2848: Vmware offline migration

2018-11-13 Thread GitBox
rafaelweingartner commented on a change in pull request #2848: Vmware offline migration URL: https://github.com/apache/cloudstack/pull/2848#discussion_r233213563 ## File path: engine/orchestration/src/main/java/com/cloud/vm/VirtualMachineManagerImpl.java ## @@ -1976,92

[GitHub] rafaelweingartner commented on a change in pull request #2848: Vmware offline migration

2018-11-13 Thread GitBox
rafaelweingartner commented on a change in pull request #2848: Vmware offline migration URL: https://github.com/apache/cloudstack/pull/2848#discussion_r233214602 ## File path: engine/orchestration/src/main/java/com/cloud/vm/VirtualMachineManagerImpl.java ## @@ -1976,92

[GitHub] rafaelweingartner commented on a change in pull request #2848: Vmware offline migration

2018-11-13 Thread GitBox
rafaelweingartner commented on a change in pull request #2848: Vmware offline migration URL: https://github.com/apache/cloudstack/pull/2848#discussion_r233212655 ## File path: engine/api/src/main/java/org/apache/cloudstack/engine/subsystem/api/storage/DataMotionStrategy.java

[GitHub] rafaelweingartner commented on a change in pull request #2848: Vmware offline migration

2018-11-13 Thread GitBox
rafaelweingartner commented on a change in pull request #2848: Vmware offline migration URL: https://github.com/apache/cloudstack/pull/2848#discussion_r233214319 ## File path: engine/orchestration/src/main/java/com/cloud/vm/VirtualMachineManagerImpl.java ## @@ -1976,92

[GitHub] rafaelweingartner commented on a change in pull request #2848: Vmware offline migration

2018-11-13 Thread GitBox
rafaelweingartner commented on a change in pull request #2848: Vmware offline migration URL: https://github.com/apache/cloudstack/pull/2848#discussion_r233214502 ## File path: engine/orchestration/src/main/java/com/cloud/vm/VirtualMachineManagerImpl.java ## @@ -1976,92

[GitHub] rafaelweingartner commented on a change in pull request #2848: Vmware offline migration

2018-11-13 Thread GitBox
rafaelweingartner commented on a change in pull request #2848: Vmware offline migration URL: https://github.com/apache/cloudstack/pull/2848#discussion_r233215111 ## File path: engine/orchestration/src/main/java/com/cloud/vm/VirtualMachineManagerImpl.java ## @@ -1976,92

[GitHub] GabrielBrascher commented on a change in pull request #3000: CLOUDSTACK-2998: Added two more device name patterns to valid bridge slaves (lo* and dummy*)

2018-11-13 Thread GitBox
GabrielBrascher commented on a change in pull request #3000: CLOUDSTACK-2998: Added two more device name patterns to valid bridge slaves (lo* and dummy*) URL: https://github.com/apache/cloudstack/pull/3000#discussion_r233144436 ## File path:

[GitHub] GabrielBrascher commented on issue #3014: Remove unused StrategyPriority.PLUGIN

2018-11-13 Thread GitBox
GabrielBrascher commented on issue #3014: Remove unused StrategyPriority.PLUGIN URL: https://github.com/apache/cloudstack/pull/3014#issuecomment-438366182 Are you ok with this PR @nvazquez @rhtyd @DaanHoogland? This is an

[GitHub] blueorangutan commented on issue #2848: Vmware offline migration

2018-11-13 Thread GitBox
blueorangutan commented on issue #2848: Vmware offline migration URL: https://github.com/apache/cloudstack/pull/2848#issuecomment-438424729 Trillian test result (tid-3175) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 38653 seconds Marvin

[GitHub] nvazquez commented on a change in pull request #3021: Skip network migration tests for not supported hypervisors instead of failing

2018-11-13 Thread GitBox
nvazquez commented on a change in pull request #3021: Skip network migration tests for not supported hypervisors instead of failing URL: https://github.com/apache/cloudstack/pull/3021#discussion_r233178412 ## File path: test/integration/smoke/test_migration.py ## @@

[GitHub] blueorangutan commented on issue #2997: Allow KVM VM live migration with ROOT volume on file storage type

2018-11-13 Thread GitBox
blueorangutan commented on issue #2997: Allow KVM VM live migration with ROOT volume on file storage type URL: https://github.com/apache/cloudstack/pull/2997#issuecomment-438408115 Trillian test result (tid-3178) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7