[GitHub] [incubator-daffodil] olabusayoT commented on a change in pull request #332: Refactor isHidden

olabusayoT commented on a change in pull request #332: Refactor isHidden URL: https://github.com/apache/incubator-daffodil/pull/332#discussion_r398040388 ## File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/Term.scala ## @@ -578,14 +563,13 @@ trait Term pr

[GitHub] [incubator-daffodil] olabusayoT commented on a change in pull request #332: Refactor isHidden

olabusayoT commented on a change in pull request #332: Refactor isHidden URL: https://github.com/apache/incubator-daffodil/pull/332#discussion_r398003298 ## File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/GroupRef.scala ## @@ -129,18 +131,15 @@ final class

[GitHub] [incubator-daffodil] olabusayoT commented on a change in pull request #332: Refactor isHidden

olabusayoT commented on a change in pull request #332: Refactor isHidden URL: https://github.com/apache/incubator-daffodil/pull/332#discussion_r398003835 ## File path: daffodil-core/src/main/scala/org/apache/daffodil/grammar/GrammarTerm.scala ## @@ -94,16 +94,19 @@ abstrac

[GitHub] [incubator-daffodil] olabusayoT commented on a change in pull request #332: Refactor isHidden

olabusayoT commented on a change in pull request #332: Refactor isHidden URL: https://github.com/apache/incubator-daffodil/pull/332#discussion_r393827299 ## File path: daffodil-core/src/main/scala/org/apache/daffodil/grammar/primitives/ChoiceCombinator.scala ## @@ -257,9 +

[GitHub] [incubator-daffodil] olabusayoT commented on a change in pull request #332: Refactor isHidden

olabusayoT commented on a change in pull request #332: Refactor isHidden URL: https://github.com/apache/incubator-daffodil/pull/332#discussion_r393086662 ## File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/SchemaComponent.scala ## @@ -243,12 +227,12 @@ trai

[GitHub] [incubator-daffodil] olabusayoT commented on a change in pull request #332: Refactor isHidden

olabusayoT commented on a change in pull request #332: Refactor isHidden URL: https://github.com/apache/incubator-daffodil/pull/332#discussion_r393015723 ## File path: daffodil-core/src/main/scala/org/apache/daffodil/grammar/primitives/ChoiceCombinator.scala ## @@ -217,27

[GitHub] [incubator-daffodil] olabusayoT commented on a change in pull request #332: Refactor isHidden

olabusayoT commented on a change in pull request #332: Refactor isHidden URL: https://github.com/apache/incubator-daffodil/pull/332#discussion_r391088959 ## File path: daffodil-core/src/main/scala/org/apache/daffodil/runtime1/SequenceTermRuntime1Mixin.scala ## @@ -76,7 +77

[GitHub] [incubator-daffodil] olabusayoT commented on a change in pull request #332: Refactor isHidden

olabusayoT commented on a change in pull request #332: Refactor isHidden URL: https://github.com/apache/incubator-daffodil/pull/332#discussion_r391088444 ## File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/Term.scala ## @@ -732,9 +728,8 @@ trait Term fina

[GitHub] [incubator-daffodil] olabusayoT commented on a change in pull request #332: Refactor isHidden

olabusayoT commented on a change in pull request #332: Refactor isHidden URL: https://github.com/apache/incubator-daffodil/pull/332#discussion_r391057073 ## File path: daffodil-core/src/main/scala/org/apache/daffodil/grammar/ModelGroupGrammarMixin.scala ## @@ -68,9 +69,16

[GitHub] [incubator-daffodil] olabusayoT commented on a change in pull request #332: Refactor isHidden

olabusayoT commented on a change in pull request #332: Refactor isHidden URL: https://github.com/apache/incubator-daffodil/pull/332#discussion_r390352687 ## File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/Term.scala ## @@ -746,7 +741,7 @@ trait Term *