olabusayoT commented on a change in pull request #332: Refactor isHidden
URL: https://github.com/apache/incubator-daffodil/pull/332#discussion_r393827299
##########
File path:
daffodil-core/src/main/scala/org/apache/daffodil/grammar/primitives/ChoiceCombinator.scala
##########
@@ -257,9 +267,8 @@ case class ChoiceCombinator(ch: ChoiceTermBase,
alternatives: Seq[Gram])
if (mapValues.isEmpty)
new NadaUnparser(null)
else {
- val firstBranchUnparser = alternatives(0).unparser
new ChoiceCombinatorUnparser(ch.modelGroupRuntimeData, eventUnparserMap,
- choiceLengthInBits, optDefaultableBranchUnparser, firstBranchUnparser)
+ choiceLengthInBits, optDefaultableBranchUnparser)
Review comment:
Both have been tested and are passing
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
