olabusayoT commented on a change in pull request #332: Refactor isHidden
URL: https://github.com/apache/incubator-daffodil/pull/332#discussion_r398003298
##########
File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/GroupRef.scala
##########
@@ -129,18 +131,15 @@ final class ChoiceGroupRef(
refXML: Node,
refLexicalParent: SchemaComponent,
positionArg: Int,
- isHiddenArg: Boolean)
+ override val isHidden: Boolean)
extends ChoiceTermBase(refXML, Option(refLexicalParent), positionArg)
with GroupRef {
requiredEvaluationsIfActivated(groupDef)
private lazy val globalGroupDef = globalGroupDefArg // once only
- override def isHidden = isHiddenArg
- override def isHiddenGroupRef = isHiddenArg
-
- override lazy val groupDef = globalGroupDef
+ override lazy val groupDef = LV('cgrGroupDef){ globalGroupDef }.value
Review comment:
There's a comment under LV, where it says 2 symbols with the same name could
cause issues that tend to be difficult to debug, so I named it something
different since SGR's groupDef already has a groupDef LV. I also found some
precedence where the symbol didn't match the variable name (such as in
org/apache/daffodil/dsom/SchemaDocIncludesAndImportsMixin.scala:151) so I
figured it'd be ok
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
