[GitHub] [incubator-druid] gianm commented on a change in pull request #7496: refactor druid-bloom-filter aggregators

2019-04-17 Thread GitBox
gianm commented on a change in pull request #7496: refactor druid-bloom-filter aggregators URL: https://github.com/apache/incubator-druid/pull/7496#discussion_r276413326 ## File path:

[GitHub] [incubator-druid] gianm commented on a change in pull request #7496: refactor druid-bloom-filter aggregators

2019-04-17 Thread GitBox
gianm commented on a change in pull request #7496: refactor druid-bloom-filter aggregators URL: https://github.com/apache/incubator-druid/pull/7496#discussion_r276411032 ## File path:

[GitHub] [incubator-druid] gianm commented on a change in pull request #7496: refactor druid-bloom-filter aggregators

2019-04-17 Thread GitBox
gianm commented on a change in pull request #7496: refactor druid-bloom-filter aggregators URL: https://github.com/apache/incubator-druid/pull/7496#discussion_r276409315 ## File path:

[GitHub] [incubator-druid] gianm commented on a change in pull request #7496: refactor druid-bloom-filter aggregators

2019-04-17 Thread GitBox
gianm commented on a change in pull request #7496: refactor druid-bloom-filter aggregators URL: https://github.com/apache/incubator-druid/pull/7496#discussion_r276409261 ## File path:

[GitHub] [incubator-druid] gianm commented on a change in pull request #7496: refactor druid-bloom-filter aggregators

2019-04-17 Thread GitBox
gianm commented on a change in pull request #7496: refactor druid-bloom-filter aggregators URL: https://github.com/apache/incubator-druid/pull/7496#discussion_r276411745 ## File path:

[GitHub] [incubator-druid] gianm commented on a change in pull request #7496: refactor druid-bloom-filter aggregators

2019-04-17 Thread GitBox
gianm commented on a change in pull request #7496: refactor druid-bloom-filter aggregators URL: https://github.com/apache/incubator-druid/pull/7496#discussion_r276258737 ## File path:

[GitHub] [incubator-druid] justinborromeo commented on issue #7238: [PROPOSAL] Add segment limit for native and streaming index tasks

2019-04-17 Thread GitBox
justinborromeo commented on issue #7238: [PROPOSAL] Add segment limit for native and streaming index tasks URL: https://github.com/apache/incubator-druid/issues/7238#issuecomment-484273106 After taking a first crack at this, I've realized that publishing segments once the number of

[GitHub] [incubator-druid] justinborromeo edited a comment on issue #7238: [PROPOSAL] Add segment limit for native and streaming index tasks

2019-04-17 Thread GitBox
justinborromeo edited a comment on issue #7238: [PROPOSAL] Add segment limit for native and streaming index tasks URL: https://github.com/apache/incubator-druid/issues/7238#issuecomment-484273106 After taking a first crack at this, I've realized that publishing segments once the number

[GitHub] [incubator-druid] justinborromeo edited a comment on issue #7238: [PROPOSAL] Add segment limit for native and streaming index tasks

2019-04-17 Thread GitBox
justinborromeo edited a comment on issue #7238: [PROPOSAL] Add segment limit for native and streaming index tasks URL: https://github.com/apache/incubator-druid/issues/7238#issuecomment-484273106 After taking a first crack at this, I've realized that publishing segments once the number

[incubator-druid] branch master updated: Update kafka version in tutorials (#7500)

2019-04-17 Thread fjy
This is an automated email from the ASF dual-hosted git repository. fjy pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git The following commit(s) were added to refs/heads/master by this push: new 8078f56 Update kafka version in

[GitHub] [incubator-druid] fjy merged pull request #7500: Update kafka version in tutorials

2019-04-17 Thread GitBox
fjy merged pull request #7500: Update kafka version in tutorials URL: https://github.com/apache/incubator-druid/pull/7500 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-druid] justinborromeo commented on issue #7434: [WIP] Indexing Task Segment Limit

2019-04-17 Thread GitBox
justinborromeo commented on issue #7434: [WIP] Indexing Task Segment Limit URL: https://github.com/apache/incubator-druid/pull/7434#issuecomment-484270926 This doesn't work because `sinks` isn't an accurate indicator of # of segments (sinks.size() doesn't equal to 0 until segments are

[GitHub] [incubator-druid] justinborromeo closed pull request #7434: [WIP] Indexing Task Segment Limit

2019-04-17 Thread GitBox
justinborromeo closed pull request #7434: [WIP] Indexing Task Segment Limit URL: https://github.com/apache/incubator-druid/pull/7434 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-druid] jihoonson commented on issue #7498: 0.14 incubating New router unified-console UI shows 0 historical nodes when a cluster has been installed and historicals has no data yet

2019-04-17 Thread GitBox
jihoonson commented on issue #7498: 0.14 incubating New router unified-console UI shows 0 historical nodes when a cluster has been installed and historicals has no data yet URL: https://github.com/apache/incubator-druid/issues/7498#issuecomment-484278877 Related to

[GitHub] [incubator-druid] stale[bot] closed pull request #4885: Add a new worker select strategy of overlord.

2019-04-17 Thread GitBox
stale[bot] closed pull request #4885: Add a new worker select strategy of overlord. URL: https://github.com/apache/incubator-druid/pull/4885 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-druid] stale[bot] commented on issue #4885: Add a new worker select strategy of overlord.

2019-04-17 Thread GitBox
stale[bot] commented on issue #4885: Add a new worker select strategy of overlord. URL: https://github.com/apache/incubator-druid/pull/4885#issuecomment-484247992 This pull request has been closed due to lack of activity. If you think that is incorrect, or the pull request requires

[GitHub] [incubator-druid] gianm commented on a change in pull request #7325: Fix result-level cache for queries

2019-04-17 Thread GitBox
gianm commented on a change in pull request #7325: Fix result-level cache for queries URL: https://github.com/apache/incubator-druid/pull/7325#discussion_r276422611 ## File path: processing/src/main/java/org/apache/druid/query/timeseries/TimeseriesQueryQueryToolChest.java

[GitHub] [incubator-druid] gianm commented on a change in pull request #7325: Fix result-level cache for queries

2019-04-17 Thread GitBox
gianm commented on a change in pull request #7325: Fix result-level cache for queries URL: https://github.com/apache/incubator-druid/pull/7325#discussion_r276423109 ## File path: processing/src/main/java/org/apache/druid/query/topn/TopNQueryQueryToolChest.java ## @@

[GitHub] [incubator-druid] gianm commented on a change in pull request #7325: Fix result-level cache for queries

2019-04-17 Thread GitBox
gianm commented on a change in pull request #7325: Fix result-level cache for queries URL: https://github.com/apache/incubator-druid/pull/7325#discussion_r276420977 ## File path: processing/src/main/java/org/apache/druid/query/metadata/SegmentMetadataQueryQueryToolChest.java

[GitHub] [incubator-druid] gianm commented on a change in pull request #7325: Fix result-level cache for queries

2019-04-17 Thread GitBox
gianm commented on a change in pull request #7325: Fix result-level cache for queries URL: https://github.com/apache/incubator-druid/pull/7325#discussion_r276423008 ## File path: processing/src/main/java/org/apache/druid/query/groupby/GroupByQueryQueryToolChest.java ##

[GitHub] [incubator-druid] gianm commented on a change in pull request #7325: Fix result-level cache for queries

2019-04-17 Thread GitBox
gianm commented on a change in pull request #7325: Fix result-level cache for queries URL: https://github.com/apache/incubator-druid/pull/7325#discussion_r276423783 ## File path: server/src/main/java/org/apache/druid/client/CachingClusteredClient.java ## @@ -385,6 +385,7

[GitHub] [incubator-druid] jon-wei opened a new pull request #7500: Update kafka version in tutorials

2019-04-17 Thread GitBox
jon-wei opened a new pull request #7500: Update kafka version in tutorials URL: https://github.com/apache/incubator-druid/pull/7500 PR #6496 updated Druid to use Kafka 2.1.0, this PR updates the Kafka tutorial to reference the same Kafka version.

[GitHub] [incubator-druid] samarthjain commented on issue #7088: Improve parallelism of zookeeper based segment change processing

2019-04-17 Thread GitBox
samarthjain commented on issue #7088: Improve parallelism of zookeeper based segment change processing URL: https://github.com/apache/incubator-druid/pull/7088#issuecomment-484285332 @leventov - sorry about missing your review comments. I have updated the config descriptions along with

[GitHub] [incubator-druid] jihoonson commented on issue #7501: Compact doesn't go more far than P1M back in history?

2019-04-17 Thread GitBox
jihoonson commented on issue #7501: Compact doesn't go more far than P1M back in history? URL: https://github.com/apache/incubator-druid/issues/7501#issuecomment-484310408 That sounds strange. Does the coordinator submits compaction tasks for the same interval over again?

[GitHub] [incubator-druid] vogievetsky commented on issue #7474: Can Druid use existed datasource and segments

2019-04-17 Thread GitBox
vogievetsky commented on issue #7474: Can Druid use existed datasource and segments URL: https://github.com/apache/incubator-druid/issues/7474#issuecomment-484366568 For the most part yes. Going up one version (say from 0.12 to 0.13) is guaranteed to be safe always. As it happens it

[GitHub] [incubator-druid] vogievetsky commented on issue #7498: 0.14 incubating New router unified-console UI shows 0 historical nodes when a cluster has been installed and historicals has no data ye

2019-04-17 Thread GitBox
vogievetsky commented on issue #7498: 0.14 incubating New router unified-console UI shows 0 historical nodes when a cluster has been installed and historicals has no data yet URL: https://github.com/apache/incubator-druid/issues/7498#issuecomment-484364395 Will be adding a temporary

[GitHub] [incubator-druid] dene14 opened a new issue #7501: Compact doesn't go more far than P1M back in history?

2019-04-17 Thread GitBox
dene14 opened a new issue #7501: Compact doesn't go more far than P1M back in history? URL: https://github.com/apache/incubator-druid/issues/7501 ### Affected Version 0.14 release I've recently updated Druid from 0.12 to 0.14 and configured compaction for my kafka-ingested

[GitHub] [incubator-druid] xqwbx163 opened a new issue #7503: compact error

2019-04-17 Thread GitBox
xqwbx163 opened a new issue #7503: compact error URL: https://github.com/apache/incubator-druid/issues/7503 bin/post-index-task --file /home/hdfs/charles/compact.json { "type": "compact", "dataSource": "101_order_history_info", "interval":

[GitHub] [incubator-druid] jihoonson merged pull request #7492: Batch hadoop ingestion job doesn't work correctly with custom segments table

2019-04-17 Thread GitBox
jihoonson merged pull request #7492: Batch hadoop ingestion job doesn't work correctly with custom segments table URL: https://github.com/apache/incubator-druid/pull/7492 This is an automated message from the Apache Git

[GitHub] [incubator-druid] pdeva commented on issue #7471: errors in coordinator web console in 0.14

2019-04-17 Thread GitBox
pdeva commented on issue #7471: errors in coordinator web console in 0.14 URL: https://github.com/apache/incubator-druid/issues/7471#issuecomment-484365263 not sure. i saw them this time so i reported them... 路‍♂️ This is

[GitHub] [incubator-druid] vogievetsky opened a new issue #7502: [Proposal] Data loader GUI

2019-04-17 Thread GitBox
vogievetsky opened a new issue #7502: [Proposal] Data loader GUI URL: https://github.com/apache/incubator-druid/issues/7502 ### Motivation Druid’s ingestion system is very versatile however currently the [ingestion specs]() in Druid are complicated and require a meticulous

[GitHub] [incubator-druid] es1220 opened a new pull request #7504: Fix aggregatorFactory meta merge exception

2019-04-17 Thread GitBox
es1220 opened a new pull request #7504: Fix aggregatorFactory meta merge exception URL: https://github.com/apache/incubator-druid/pull/7504 Fix HllSketch Metadata merge Exception A `segmentMetadata` query with` merge = true` raises an exception because it does not implement the

[GitHub] [incubator-druid] vogievetsky commented on issue #7471: errors in coordinator web console in 0.14

2019-04-17 Thread GitBox
vogievetsky commented on issue #7471: errors in coordinator web console in 0.14 URL: https://github.com/apache/incubator-druid/issues/7471#issuecomment-484364869 The coordinator console had some JS errors for a while? Is this a regression in 0.14?

[incubator-druid] branch master updated: Pass in segmentTable correctly (#7492)

2019-04-17 Thread jihoonson
This is an automated email from the ASF dual-hosted git repository. jihoonson pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git The following commit(s) were added to refs/heads/master by this push: new 9732e04 Pass in segmentTable

[GitHub] [incubator-druid] vogievetsky commented on issue #7498: 0.14 incubating New router unified-console UI shows 0 historical nodes when a cluster has been installed and historicals has no data ye

2019-04-17 Thread GitBox
vogievetsky commented on issue #7498: 0.14 incubating New router unified-console UI shows 0 historical nodes when a cluster has been installed and historicals has no data yet URL: https://github.com/apache/incubator-druid/issues/7498#issuecomment-484365670 @jihoonson I noticed you added

[GitHub] [incubator-druid] ans76 opened a new issue #7497: Use dsql query caught exception after HadoopIndexTask finished

2019-04-17 Thread GitBox
ans76 opened a new issue #7497: Use dsql query caught exception after HadoopIndexTask finished URL: https://github.com/apache/incubator-druid/issues/7497 ### Affected Version druid-0.13.0-incubating ### Description When HadoopIndexTask ingestion completely, query via

[GitHub] [incubator-druid] clintropolis opened a new pull request #7496: refactor druid-bloom-filter aggregators

2019-04-17 Thread GitBox
clintropolis opened a new pull request #7496: refactor druid-bloom-filter aggregators URL: https://github.com/apache/incubator-druid/pull/7496 This PR refactors the `druid-bloom-filter` extension aggregators to strictly use `ByteBuffer` representation of `BloomKFilter` and buffer based

[GitHub] [incubator-druid] adocortes opened a new issue #7498: 0.14 incubating New router unified-console UI shows 0 historical nodes when a cluster has been installed and historicals has no data yet

2019-04-17 Thread GitBox
adocortes opened a new issue #7498: 0.14 incubating New router unified-console UI shows 0 historical nodes when a cluster has been installed and historicals has no data yet URL: https://github.com/apache/incubator-druid/issues/7498 0.14 incubating New router unified-console UI shows 0

[incubator-druid] branch master updated: Move dev-related files and instructions to dev/ directory; add committer's instructions (#7279)

2019-04-17 Thread leventov
This is an automated email from the ASF dual-hosted git repository. leventov pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git The following commit(s) were added to refs/heads/master by this push: new 9d38527 Move dev-related files and

[GitHub] [incubator-druid] leventov merged pull request #7279: Move dev-related files and instructions to dev/ directory; add committer's instructions

2019-04-17 Thread GitBox
leventov merged pull request #7279: Move dev-related files and instructions to dev/ directory; add committer's instructions URL: https://github.com/apache/incubator-druid/pull/7279 This is an automated message from the

[GitHub] [incubator-druid] mprior10 commented on issue #6759: Unknown provider[mysql] of Key[type=org.apache.druid.metadata.MetadataStorageProvider,

2019-04-17 Thread GitBox
mprior10 commented on issue #6759: Unknown provider[mysql] of Key[type=org.apache.druid.metadata.MetadataStorageProvider, URL: https://github.com/apache/incubator-druid/issues/6759#issuecomment-484071307 Hi Egor, I didn’t get back to this, after I got the error. Thanks

[GitHub] [incubator-druid] leventov commented on issue #7206: Add the pull-request template

2019-04-17 Thread GitBox
leventov commented on issue #7206: Add the pull-request template URL: https://github.com/apache/incubator-druid/pull/7206#issuecomment-484119691 @jon-wei @gianm @clintropolis @jihoonson I've updated the PR template. Regarding the concurrency checklist, I've created a two-level system

[GitHub] [incubator-druid] leventov opened a new pull request #7499: Introduce Non-TeamCity Warning inspection severity in IntelliJ's profile

2019-04-17 Thread GitBox
leventov opened a new pull request #7499: Introduce Non-TeamCity Warning inspection severity in IntelliJ's profile URL: https://github.com/apache/incubator-druid/pull/7499 In the IDE interface, "Non-TeamCity Warning" looks exactly like an ordinary warning, but TeamCity should be unaware

[GitHub] [incubator-druid] leventov commented on a change in pull request #7477: Java 9 compatible specialized class compilation

2019-04-17 Thread GitBox
leventov commented on a change in pull request #7477: Java 9 compatible specialized class compilation URL: https://github.com/apache/incubator-druid/pull/7477#discussion_r276320618 ## File path: core/src/main/java/org/apache/druid/java/util/common/Unsafe.java ## @@ -0,0

[GitHub] [incubator-druid] leventov commented on a change in pull request #7477: Java 9 compatible specialized class compilation

2019-04-17 Thread GitBox
leventov commented on a change in pull request #7477: Java 9 compatible specialized class compilation URL: https://github.com/apache/incubator-druid/pull/7477#discussion_r276321173 ## File path: core/src/main/java/org/apache/druid/java/util/common/Unsafe.java ## @@ -0,0

[GitHub] [incubator-druid] gianm commented on issue #7496: refactor druid-bloom-filter aggregators

2019-04-17 Thread GitBox
gianm commented on issue #7496: refactor druid-bloom-filter aggregators URL: https://github.com/apache/incubator-druid/pull/7496#issuecomment-484159320 Going to tag this as 'bug' too since it does fix a bug - right now the type mismatch between what `deserialize` generates and `combine`

[GitHub] [incubator-druid] 87139511 commented on issue #3851: Druid ingestion ends with SUCCESS status but exception is thrown at the end

2019-04-17 Thread GitBox
87139511 commented on issue #3851: Druid ingestion ends with SUCCESS status but exception is thrown at the end URL: https://github.com/apache/incubator-druid/issues/3851#issuecomment-484160091 I have same problem .how to solve it?

[GitHub] [incubator-druid] 87139511 commented on issue #3851: Druid ingestion ends with SUCCESS status but exception is thrown at the end

2019-04-17 Thread GitBox
87139511 commented on issue #3851: Druid ingestion ends with SUCCESS status but exception is thrown at the end URL: https://github.com/apache/incubator-druid/issues/3851#issuecomment-484160470 my druid.version is 0.12.3

[GitHub] [incubator-druid] leventov commented on a change in pull request #7088: Improve parallelism of zookeeper based segment change processing

2019-04-17 Thread GitBox
leventov commented on a change in pull request #7088: Improve parallelism of zookeeper based segment change processing URL: https://github.com/apache/incubator-druid/pull/7088#discussion_r276322549 ## File path: docs/content/configuration/index.md ## @@ -1255,7 +1255,8 @@

[GitHub] [incubator-druid] leventov commented on a change in pull request #7088: Improve parallelism of zookeeper based segment change processing

2019-04-17 Thread GitBox
leventov commented on a change in pull request #7088: Improve parallelism of zookeeper based segment change processing URL: https://github.com/apache/incubator-druid/pull/7088#discussion_r276324565 ## File path:

[GitHub] [incubator-druid] leventov commented on a change in pull request #7088: Improve parallelism of zookeeper based segment change processing

2019-04-17 Thread GitBox
leventov commented on a change in pull request #7088: Improve parallelism of zookeeper based segment change processing URL: https://github.com/apache/incubator-druid/pull/7088#discussion_r276323483 ## File path: docs/content/configuration/index.md ## @@ -1255,7 +1255,8 @@

[GitHub] [incubator-druid] leventov commented on a change in pull request #7088: Improve parallelism of zookeeper based segment change processing

2019-04-17 Thread GitBox
leventov commented on a change in pull request #7088: Improve parallelism of zookeeper based segment change processing URL: https://github.com/apache/incubator-druid/pull/7088#discussion_r276322339 ## File path:

[GitHub] [incubator-druid] leventov commented on a change in pull request #7088: Improve parallelism of zookeeper based segment change processing

2019-04-17 Thread GitBox
leventov commented on a change in pull request #7088: Improve parallelism of zookeeper based segment change processing URL: https://github.com/apache/incubator-druid/pull/7088#discussion_r276327188 ## File path:

[GitHub] [incubator-druid] leventov commented on a change in pull request #7088: Improve parallelism of zookeeper based segment change processing

2019-04-17 Thread GitBox
leventov commented on a change in pull request #7088: Improve parallelism of zookeeper based segment change processing URL: https://github.com/apache/incubator-druid/pull/7088#discussion_r276325595 ## File path:

[incubator-druid] branch master updated: Java 9 compatible cleaner operations (#7487)

2019-04-17 Thread gian
This is an automated email from the ASF dual-hosted git repository. gian pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git The following commit(s) were added to refs/heads/master by this push: new 4322ce3 Java 9 compatible cleaner

[GitHub] [incubator-druid] gianm merged pull request #7487: Java 9 compatible cleaner operations

2019-04-17 Thread GitBox
gianm merged pull request #7487: Java 9 compatible cleaner operations URL: https://github.com/apache/incubator-druid/pull/7487 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [incubator-druid] xvrl commented on a change in pull request #7477: Java 9 compatible specialized class compilation

2019-04-17 Thread GitBox
xvrl commented on a change in pull request #7477: Java 9 compatible specialized class compilation URL: https://github.com/apache/incubator-druid/pull/7477#discussion_r276338346 ## File path: core/src/main/java/org/apache/druid/java/util/common/Unsafe.java ## @@ -0,0 +1,75

[GitHub] [incubator-druid] xvrl commented on a change in pull request #7477: Java 9 compatible specialized class compilation

2019-04-17 Thread GitBox
xvrl commented on a change in pull request #7477: Java 9 compatible specialized class compilation URL: https://github.com/apache/incubator-druid/pull/7477#discussion_r276339192 ## File path:

[GitHub] [incubator-druid] xvrl commented on a change in pull request #7477: Java 9 compatible specialized class compilation

2019-04-17 Thread GitBox
xvrl commented on a change in pull request #7477: Java 9 compatible specialized class compilation URL: https://github.com/apache/incubator-druid/pull/7477#discussion_r276339661 ## File path:

[GitHub] [incubator-druid] xvrl commented on a change in pull request #7477: Java 9 compatible specialized class compilation

2019-04-17 Thread GitBox
xvrl commented on a change in pull request #7477: Java 9 compatible specialized class compilation URL: https://github.com/apache/incubator-druid/pull/7477#discussion_r276338770 ## File path:

[GitHub] [incubator-druid] jihoonson commented on issue #7331: TDigest backed sketch aggregators

2019-04-17 Thread GitBox
jihoonson commented on issue #7331: TDigest backed sketch aggregators URL: https://github.com/apache/incubator-druid/pull/7331#issuecomment-484177850 @samarthjain ah sorry. I forgot about this PR. Will take a look soon. This