[incubator-tvm] branch master updated (902e21b -> 31c2f97)

2020-02-11 Thread lmzheng
This is an automated email from the ASF dual-hosted git repository. lmzheng pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git. from 902e21b [TFLite] Using real image for QNN testing. (#4816) add 31c2f97 [RUNTIME] Fix memory leakage of

[GitHub] [incubator-tvm] merrymercy merged pull request #4856: [RUNTIME] Fix memory leakage of TVMByteArray

2020-02-11 Thread GitBox
merrymercy merged pull request #4856: [RUNTIME] Fix memory leakage of TVMByteArray URL: https://github.com/apache/incubator-tvm/pull/4856 This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [incubator-tvm] mbarrett97 commented on a change in pull request #4771: [Relay] Added Merge Composite pass

2020-02-11 Thread GitBox
mbarrett97 commented on a change in pull request #4771: [Relay] Added Merge Composite pass URL: https://github.com/apache/incubator-tvm/pull/4771#discussion_r377545174 ## File path: tests/python/relay/test_pass_merge_composite.py ## @@ -0,0 +1,158 @@ +# Licensed to the Apa

[GitHub] [incubator-tvm] mbarrett97 opened a new pull request #4864: [Relay] Ignore Primitive functions in Visitors

2020-02-11 Thread GitBox
mbarrett97 opened a new pull request #4864: [Relay] Ignore Primitive functions in Visitors URL: https://github.com/apache/incubator-tvm/pull/4864 Primitive functions are not to be modified by passes and as such should be ignored. This commit makes Visitor patterns ignore Primitive function

[GitHub] [incubator-tvm] masahi commented on issue #4497: [Relay] Add a PyTorch to Relay Parser

2020-02-11 Thread GitBox
masahi commented on issue #4497: [Relay] Add a PyTorch to Relay Parser URL: https://github.com/apache/incubator-tvm/pull/4497#issuecomment-584690004 the mobilenet issue is a new one since torch update? This is an automated mes

[GitHub] [incubator-tvm] masahi edited a comment on issue #4497: [Relay] Add a PyTorch to Relay Parser

2020-02-11 Thread GitBox
masahi edited a comment on issue #4497: [Relay] Add a PyTorch to Relay Parser URL: https://github.com/apache/incubator-tvm/pull/4497#issuecomment-584690004 the mobilenet issue is a new one since torch update? `CUDA_ERROR_INVALID_PTX` seems a codegen issue (too many threads per block, too m

[GitHub] [incubator-tvm] masahi edited a comment on issue #4497: [Relay] Add a PyTorch to Relay Parser

2020-02-11 Thread GitBox
masahi edited a comment on issue #4497: [Relay] Add a PyTorch to Relay Parser URL: https://github.com/apache/incubator-tvm/pull/4497#issuecomment-584690004 the mobilenet issue is a new one since torch update? `CUDA_ERROR_INVALID_PTX` seems a codegen issue (too many threads/shared mem per b

[GitHub] [incubator-tvm] yongfeng-nv commented on issue #4651: Tensor Expression Debug Display (TEDD)

2020-02-11 Thread GitBox
yongfeng-nv commented on issue #4651: Tensor Expression Debug Display (TEDD) URL: https://github.com/apache/incubator-tvm/pull/4651#issuecomment-584702130 The PR is clear from building/testing failures, after qualifying with @Hzfengsy's help on tutorial. I am attaching the three static i

[GitHub] [incubator-tvm] tqchen merged pull request #4859: [LLVM] Explicit llvm::StringRef to std::string conversion

2020-02-11 Thread GitBox
tqchen merged pull request #4859: [LLVM] Explicit llvm::StringRef to std::string conversion URL: https://github.com/apache/incubator-tvm/pull/4859 This is an automated message from the Apache Git Service. To respond to the m

[incubator-tvm] branch master updated (31c2f97 -> 91d2f5a)

2020-02-11 Thread tqchen
This is an automated email from the ASF dual-hosted git repository. tqchen pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git. from 31c2f97 [RUNTIME] Fix memory leakage of TVMByteArray (#4856) add 91d2f5a [LLVM] Explicit llvm::StringRe

[GitHub] [incubator-tvm] tqchen edited a comment on issue #4863: vta+nvdla integration

2020-02-11 Thread GitBox
tqchen edited a comment on issue #4863: vta+nvdla integration URL: https://github.com/apache/incubator-tvm/pull/4863#issuecomment-584732108 Thanks for the contribution, please create an RFC to describe what are you proposing, features and implementation plans. I also noticed that there is a

[GitHub] [incubator-tvm] tqchen commented on issue #4863: vta+nvdla integration

2020-02-11 Thread GitBox
tqchen commented on issue #4863: vta+nvdla integration URL: https://github.com/apache/incubator-tvm/pull/4863#issuecomment-584732108 Thanks for the contribution, please create an RFC to describe what are you proposing, features and implementation plans. I also noticed that there is a refer

[GitHub] [incubator-tvm] tqchen commented on issue #4858: Error in Build NNPACK @mbp

2020-02-11 Thread GitBox
tqchen commented on issue #4858: Error in Build NNPACK @mbp URL: https://github.com/apache/incubator-tvm/issues/4858#issuecomment-584732891 Please open a new trouble shooting thread on https://discuss.tvm.ai/ note that NNPack is completely optional, and you do not have to build with NNPack

[GitHub] [incubator-tvm] tqchen edited a comment on issue #4864: [Relay] Ignore Primitive functions in Visitors

2020-02-11 Thread GitBox
tqchen edited a comment on issue #4864: [Relay] Ignore Primitive functions in Visitors URL: https://github.com/apache/incubator-tvm/pull/4864#issuecomment-584733547 I feel that this is a change that should be bought to a sub-class of a visitor, instead of the visitor itself. Given that it

[GitHub] [incubator-tvm] tqchen commented on issue #4864: [Relay] Ignore Primitive functions in Visitors

2020-02-11 Thread GitBox
tqchen commented on issue #4864: [Relay] Ignore Primitive functions in Visitors URL: https://github.com/apache/incubator-tvm/pull/4864#issuecomment-584733547 I feel this is a change that should be bought to a sub-class of a visitor, instead of the visitor itself. Given that it is quite spec

[GitHub] [incubator-tvm] tqchen merged pull request #4861: [TVM] const auto p -> const auto& p

2020-02-11 Thread GitBox
tqchen merged pull request #4861: [TVM] const auto p -> const auto& p URL: https://github.com/apache/incubator-tvm/pull/4861 This is an automated message from the Apache Git Service. To respond to the message, please log on t

[GitHub] [incubator-tvm] tqchen commented on issue #4861: [TVM] const auto p -> const auto& p

2020-02-11 Thread GitBox
tqchen commented on issue #4861: [TVM] const auto p -> const auto& p URL: https://github.com/apache/incubator-tvm/pull/4861#issuecomment-584734150 Thanks @hlu1 ! This is an automated message from the Apache Git Service. To res

[incubator-tvm] branch master updated (91d2f5a -> c42bb6c)

2020-02-11 Thread tqchen
This is an automated email from the ASF dual-hosted git repository. tqchen pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git. from 91d2f5a [LLVM] Explicit llvm::StringRef to std::string conversion (#4859) add c42bb6c [TVM] const auto

[GitHub] [incubator-tvm] tqchen commented on issue #4628: [Object] Add String container

2020-02-11 Thread GitBox
tqchen commented on issue #4628: [Object] Add String container URL: https://github.com/apache/incubator-tvm/pull/4628#issuecomment-584734563 @wweic please update as per comments :) This is an automated message from the Apache

[GitHub] [incubator-tvm] tqchen edited a comment on issue #4628: [Object] Add String container

2020-02-11 Thread GitBox
tqchen edited a comment on issue #4628: [Object] Add String container URL: https://github.com/apache/incubator-tvm/pull/4628#issuecomment-584734563 @wweic please update per comments :) This is an automated message from the Apa

[GitHub] [incubator-tvm] tqchen closed issue #4858: Error in Build NNPACK @mbp

2020-02-11 Thread GitBox
tqchen closed issue #4858: Error in Build NNPACK @mbp URL: https://github.com/apache/incubator-tvm/issues/4858 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [incubator-tvm] mbarrett97 commented on issue #4864: [Relay] Ignore Primitive functions in Visitors

2020-02-11 Thread GitBox
mbarrett97 commented on issue #4864: [Relay] Ignore Primitive functions in Visitors URL: https://github.com/apache/incubator-tvm/pull/4864#issuecomment-584737964 I agree it's not ideal to modify the behaviour of the Visitors directly. However, if I sub-class to produce a 'PrimitiveSkipping

[GitHub] [incubator-tvm] mbarrett97 commented on issue #4864: [Relay] Ignore Primitive functions in Visitors

2020-02-11 Thread GitBox
mbarrett97 commented on issue #4864: [Relay] Ignore Primitive functions in Visitors URL: https://github.com/apache/incubator-tvm/pull/4864#issuecomment-584738329 @comaniac @zhiics Can you review please? I'm wondering whether I've interpreted the intended behaviour of primitive functions co

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #4855: [Refactor] move vm.py under runtime and adt to runtime.container.py

2020-02-11 Thread GitBox
tqchen commented on a change in pull request #4855: [Refactor] move vm.py under runtime and adt to runtime.container.py URL: https://github.com/apache/incubator-tvm/pull/4855#discussion_r377780629 ## File path: python/tvm/runtime/vm.py ## @@ -0,0 +1,357 @@ +# License .to t

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #4855: [Refactor] move vm.py under runtime and adt to runtime.container.py

2020-02-11 Thread GitBox
tqchen commented on a change in pull request #4855: [Refactor] move vm.py under runtime and adt to runtime.container.py URL: https://github.com/apache/incubator-tvm/pull/4855#discussion_r377780840 ## File path: python/tvm/runtime/vm.py ## @@ -0,0 +1,357 @@ +# License .to t

[GitHub] [incubator-tvm] tqchen commented on issue #4864: [Relay] Ignore Primitive functions in Visitors

2020-02-11 Thread GitBox
tqchen commented on issue #4864: [Relay] Ignore Primitive functions in Visitors URL: https://github.com/apache/incubator-tvm/pull/4864#issuecomment-584751569 A potentially better approach here would be to lift the primitive functions into the module-level, so that the function pass can safe

[GitHub] [incubator-tvm] tqchen commented on issue #4864: [Relay] Ignore Primitive functions in Visitors

2020-02-11 Thread GitBox
tqchen commented on issue #4864: [Relay] Ignore Primitive functions in Visitors URL: https://github.com/apache/incubator-tvm/pull/4864#issuecomment-584753379 It would also be great to understand how things would break the primitive function(e.g. was that due to inlining), and whether liftin

[GitHub] [incubator-tvm] tqchen edited a comment on issue #4864: [Relay] Ignore Primitive functions in Visitors

2020-02-11 Thread GitBox
tqchen edited a comment on issue #4864: [Relay] Ignore Primitive functions in Visitors URL: https://github.com/apache/incubator-tvm/pull/4864#issuecomment-584753379 It would also be great to understand how things would break in the case of external functions(e.g. was that due to inlining),

[GitHub] [incubator-tvm] alexgl-github commented on issue #4790: Fast exponent

2020-02-11 Thread GitBox
alexgl-github commented on issue #4790: Fast exponent URL: https://github.com/apache/incubator-tvm/pull/4790#issuecomment-584757028 @masahi @anijain2305 @FrozenGene Would you mind reviewing again? This is an automated message

[GitHub] [incubator-tvm] mbarrett97 commented on issue #4864: [Relay] Ignore Primitive functions in Visitors

2020-02-11 Thread GitBox
mbarrett97 commented on issue #4864: [Relay] Ignore Primitive functions in Visitors URL: https://github.com/apache/incubator-tvm/pull/4864#issuecomment-584758674 An example to illustrate why this breaks is that we have external codegens that want to act directly on the relay 'qnn dialect'.

[GitHub] [incubator-tvm] comaniac commented on issue #4864: [Relay] Ignore Primitive functions in Visitors

2020-02-11 Thread GitBox
comaniac commented on issue #4864: [Relay] Ignore Primitive functions in Visitors URL: https://github.com/apache/incubator-tvm/pull/4864#issuecomment-584759811 Specifically for removing all functions from main, would this help? https://github.com/apache/incubator-tvm/pull/4847 This PR s

[GitHub] [incubator-tvm] masahi commented on issue #4838: [Frontend, ONNX] Add Resize op converter

2020-02-11 Thread GitBox
masahi commented on issue #4838: [Frontend, ONNX] Add Resize op converter URL: https://github.com/apache/incubator-tvm/pull/4838#issuecomment-584765362 Can somebody merge this? @tqchen @icemelon9 @yzhliu This is an automated

[GitHub] [incubator-tvm] icemelon9 merged pull request #4838: [Frontend, ONNX] Add Resize op converter

2020-02-11 Thread GitBox
icemelon9 merged pull request #4838: [Frontend, ONNX] Add Resize op converter URL: https://github.com/apache/incubator-tvm/pull/4838 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-tvm] icemelon9 commented on issue #4838: [Frontend, ONNX] Add Resize op converter

2020-02-11 Thread GitBox
icemelon9 commented on issue #4838: [Frontend, ONNX] Add Resize op converter URL: https://github.com/apache/incubator-tvm/pull/4838#issuecomment-584767853 Thanks @masahi @jwfromm This is an automated message from the Apache G

[incubator-tvm] branch master updated (c42bb6c -> 4fce513)

2020-02-11 Thread haichen
This is an automated email from the ASF dual-hosted git repository. haichen pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git. from c42bb6c [TVM] const auto p -> const auto &p (#4861) add 4fce513 add resize op converter (#4838) No ne

[GitHub] [incubator-tvm] zhiics commented on issue #4864: [Relay] Ignore Primitive functions in Visitors

2020-02-11 Thread GitBox
zhiics commented on issue #4864: [Relay] Ignore Primitive functions in Visitors URL: https://github.com/apache/incubator-tvm/pull/4864#issuecomment-584769286 I think there are at least two solutions to prevent Relay passes from touching the external functions: - S0: lifting the external

[GitHub] [incubator-tvm] zhiics edited a comment on issue #4864: [Relay] Ignore Primitive functions in Visitors

2020-02-11 Thread GitBox
zhiics edited a comment on issue #4864: [Relay] Ignore Primitive functions in Visitors URL: https://github.com/apache/incubator-tvm/pull/4864#issuecomment-584769286 I think there are at least two solutions to prevent Relay passes from touching the external functions: - S0: lifting the e

[GitHub] [incubator-tvm] tqchen commented on issue #4862: [REFACTOR][PY] establish tvm.ir, migrate base, expr, type, adt

2020-02-11 Thread GitBox
tqchen commented on issue #4862: [REFACTOR][PY] establish tvm.ir, migrate base, expr, type, adt URL: https://github.com/apache/incubator-tvm/pull/4862#issuecomment-584776027 cc @zhiics @wweic @yzhliu @icemelon9 @jroesch @MarisaKirisame @ZihengJiang

[GitHub] [incubator-tvm] zhiics commented on a change in pull request #4862: [REFACTOR][PY] establish tvm.ir, migrate base, expr, type, adt

2020-02-11 Thread GitBox
zhiics commented on a change in pull request #4862: [REFACTOR][PY] establish tvm.ir, migrate base, expr, type, adt URL: https://github.com/apache/incubator-tvm/pull/4862#discussion_r377813960 ## File path: python/tvm/ir/base.py ## @@ -0,0 +1,86 @@ +# Licensed to the Apache

[GitHub] [incubator-tvm] zhiics commented on a change in pull request #4862: [REFACTOR][PY] establish tvm.ir, migrate base, expr, type, adt

2020-02-11 Thread GitBox
zhiics commented on a change in pull request #4862: [REFACTOR][PY] establish tvm.ir, migrate base, expr, type, adt URL: https://github.com/apache/incubator-tvm/pull/4862#discussion_r377817042 ## File path: python/tvm/ir/type.py ## @@ -0,0 +1,205 @@ +# Licensed to the Apach

[GitHub] [incubator-tvm] zhiics commented on a change in pull request #4862: [REFACTOR][PY] establish tvm.ir, migrate base, expr, type, adt

2020-02-11 Thread GitBox
zhiics commented on a change in pull request #4862: [REFACTOR][PY] establish tvm.ir, migrate base, expr, type, adt URL: https://github.com/apache/incubator-tvm/pull/4862#discussion_r377813574 ## File path: python/tvm/ir/base.py ## @@ -0,0 +1,86 @@ +# Licensed to the Apache

[GitHub] [incubator-tvm] zhiics commented on a change in pull request #4862: [REFACTOR][PY] establish tvm.ir, migrate base, expr, type, adt

2020-02-11 Thread GitBox
zhiics commented on a change in pull request #4862: [REFACTOR][PY] establish tvm.ir, migrate base, expr, type, adt URL: https://github.com/apache/incubator-tvm/pull/4862#discussion_r377810691 ## File path: python/tvm/ir/adt.py ## @@ -0,0 +1,88 @@ +# Licensed to the Apache

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #4862: [REFACTOR][PY] establish tvm.ir, migrate base, expr, type, adt

2020-02-11 Thread GitBox
tqchen commented on a change in pull request #4862: [REFACTOR][PY] establish tvm.ir, migrate base, expr, type, adt URL: https://github.com/apache/incubator-tvm/pull/4862#discussion_r377831779 ## File path: python/tvm/ir/base.py ## @@ -0,0 +1,86 @@ +# Licensed to the Apache

[GitHub] [incubator-tvm] zhiics commented on a change in pull request #4862: [REFACTOR][PY] establish tvm.ir, migrate base, expr, type, adt, transform

2020-02-11 Thread GitBox
zhiics commented on a change in pull request #4862: [REFACTOR][PY] establish tvm.ir, migrate base, expr, type, adt, transform URL: https://github.com/apache/incubator-tvm/pull/4862#discussion_r377835396 ## File path: python/tvm/ir/base.py ## @@ -0,0 +1,86 @@ +# Licensed to

[GitHub] [incubator-tvm] jwfromm commented on a change in pull request #4771: [Relay] Added Merge Composite pass

2020-02-11 Thread GitBox
jwfromm commented on a change in pull request #4771: [Relay] Added Merge Composite pass URL: https://github.com/apache/incubator-tvm/pull/4771#discussion_r377835990 ## File path: tests/python/relay/test_pass_merge_composite.py ## @@ -0,0 +1,158 @@ +# Licensed to the Apache

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #4862: [REFACTOR][PY] establish tvm.ir, migrate base, expr, type, adt, transform

2020-02-11 Thread GitBox
tqchen commented on a change in pull request #4862: [REFACTOR][PY] establish tvm.ir, migrate base, expr, type, adt, transform URL: https://github.com/apache/incubator-tvm/pull/4862#discussion_r377837198 ## File path: python/tvm/ir/base.py ## @@ -0,0 +1,86 @@ +# Licensed to

[GitHub] [incubator-tvm] yzhliu commented on issue #3670: [RFC] AlterOpLayout Pass Refactoring

2020-02-11 Thread GitBox
yzhliu commented on issue #3670: [RFC] AlterOpLayout Pass Refactoring URL: https://github.com/apache/incubator-tvm/issues/3670#issuecomment-584813744 @tqchen I have limited progress at this moment. might be able to revisit in a month or so. -

[GitHub] [incubator-tvm] tqchen merged pull request #4855: [Refactor] move vm.py under runtime and adt to runtime.container.py

2020-02-11 Thread GitBox
tqchen merged pull request #4855: [Refactor] move vm.py under runtime and adt to runtime.container.py URL: https://github.com/apache/incubator-tvm/pull/4855 This is an automated message from the Apache Git Service. To respon

[GitHub] [incubator-tvm] tqchen commented on issue #4864: [Relay] Ignore Primitive functions in Visitors

2020-02-11 Thread GitBox
tqchen commented on issue #4864: [Relay] Ignore Primitive functions in Visitors URL: https://github.com/apache/incubator-tvm/pull/4864#issuecomment-584825131 I think S0 is a better approach here This is an automated message fr

[GitHub] [incubator-tvm] tqchen commented on issue #4855: [Refactor] move vm.py under runtime and adt to runtime.container.py

2020-02-11 Thread GitBox
tqchen commented on issue #4855: [Refactor] move vm.py under runtime and adt to runtime.container.py URL: https://github.com/apache/incubator-tvm/pull/4855#issuecomment-584825270 Thanks @zhiics ! This is an automated message

[incubator-tvm] branch master updated (4fce513 -> 502cf26)

2020-02-11 Thread tqchen
This is an automated email from the ASF dual-hosted git repository. tqchen pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git. from 4fce513 add resize op converter (#4838) add 502cf26 [Refactor] move vm.py under runtime and adt to run

[GitHub] [incubator-tvm] tqchen commented on issue #3670: [RFC] AlterOpLayout Pass Refactoring

2020-02-11 Thread GitBox
tqchen commented on issue #3670: [RFC] AlterOpLayout Pass Refactoring URL: https://github.com/apache/incubator-tvm/issues/3670#issuecomment-584825626 no problem, just to check to see if the issue can be closed This is an autom

[GitHub] [incubator-tvm] hlu1 opened a new pull request #4865: [Topi] Missing header

2020-02-11 Thread GitBox
hlu1 opened a new pull request #4865: [Topi] Missing header URL: https://github.com/apache/incubator-tvm/pull/4865 Fix compilation error with clang: ``` tvm/tvm/topi/include/topi/x86/default.h:58:14: error: no type named 'AutoInlineInjective' in namespace 'tvm::te' tvm::te::Aut

[GitHub] [incubator-tvm] zhiics closed issue #4854: [REFACTOR] Move python vm runtime into runtime/vm.py

2020-02-11 Thread GitBox
zhiics closed issue #4854: [REFACTOR] Move python vm runtime into runtime/vm.py URL: https://github.com/apache/incubator-tvm/issues/4854 This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [incubator-tvm] tqchen commented on issue #4862: [REFACTOR][PY][API-CHANGE] establish tvm.ir, migrate corresponding relay files

2020-02-11 Thread GitBox
tqchen commented on issue #4862: [REFACTOR][PY][API-CHANGE] establish tvm.ir, migrate corresponding relay files URL: https://github.com/apache/incubator-tvm/pull/4862#issuecomment-584832133 Updated the PR and comment, @zhiics please help to take another look ---

[GitHub] [incubator-tvm] tqchen commented on issue #4690: WIP: Flake8: Add undefined names test

2020-02-11 Thread GitBox
tqchen commented on issue #4690: WIP: Flake8: Add undefined names test URL: https://github.com/apache/incubator-tvm/pull/4690#issuecomment-584835748 close for now per the reasons stated above This is an automated message from

[GitHub] [incubator-tvm] tqchen closed pull request #4690: WIP: Flake8: Add undefined names test

2020-02-11 Thread GitBox
tqchen closed pull request #4690: WIP: Flake8: Add undefined names test URL: https://github.com/apache/incubator-tvm/pull/4690 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-tvm] alexwong commented on issue #4497: [Relay] Add a PyTorch to Relay Parser

2020-02-11 Thread GitBox
alexwong commented on issue #4497: [Relay] Add a PyTorch to Relay Parser URL: https://github.com/apache/incubator-tvm/pull/4497#issuecomment-584855049 > the mobilenet issue is a new one since torch update? `CUDA_ERROR_INVALID_PTX` seems a codegen issue (too many threads/shared mem per bloc

[GitHub] [incubator-tvm] kparzysz-quic commented on a change in pull request #4859: [LLVM] Explicit llvm::StringRef to std::string conversion

2020-02-11 Thread GitBox
kparzysz-quic commented on a change in pull request #4859: [LLVM] Explicit llvm::StringRef to std::string conversion URL: https://github.com/apache/incubator-tvm/pull/4859#discussion_r377915813 ## File path: src/target/llvm/codegen_llvm.cc ## @@ -88,7 +88,7 @@ void CodeGen

[GitHub] [incubator-tvm] alexgl-github opened a new pull request #4866: Optimize x86 conv3d_ndhwc using data packing approach.

2020-02-11 Thread GitBox
alexgl-github opened a new pull request #4866: Optimize x86 conv3d_ndhwc using data packing approach. URL: https://github.com/apache/incubator-tvm/pull/4866 Add tuneable conv3d_ndhwc schedule Thanks for contributing to TVM! Please refer to guideline https://docs.tvm.ai/contribute

[GitHub] [incubator-tvm] alexgl-github commented on issue #4866: Optimize x86 conv3d_ndhwc using data packing approach.

2020-02-11 Thread GitBox
alexgl-github commented on issue #4866: Optimize x86 conv3d_ndhwc using data packing approach. URL: https://github.com/apache/incubator-tvm/pull/4866#issuecomment-584868090 @anijain2305 Please take a look This is an automate

[GitHub] [incubator-tvm] tqchen merged pull request #4750: Fix onnx import bugs

2020-02-11 Thread GitBox
tqchen merged pull request #4750: Fix onnx import bugs URL: https://github.com/apache/incubator-tvm/pull/4750 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[incubator-tvm] branch master updated (502cf26 -> 54349ec)

2020-02-11 Thread tqchen
This is an automated email from the ASF dual-hosted git repository. tqchen pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git. from 502cf26 [Refactor] move vm.py under runtime and adt to runtime.container.py (#4855) add 54349ec Fix on

[GitHub] [incubator-tvm] tqchen commented on issue #4750: Fix onnx import bugs

2020-02-11 Thread GitBox
tqchen commented on issue #4750: Fix onnx import bugs URL: https://github.com/apache/incubator-tvm/pull/4750#issuecomment-584868960 Merge it for now to avoid staleness, and given that the code is properly reviewed. @kice @jwfromm would be great to add a followup PR to cover the case --

[GitHub] [incubator-tvm] kumasento commented on a change in pull request #4847: Use dummy func when no lowered_funcs exists in Relay mod

2020-02-11 Thread GitBox
kumasento commented on a change in pull request #4847: Use dummy func when no lowered_funcs exists in Relay mod URL: https://github.com/apache/incubator-tvm/pull/4847#discussion_r377919071 ## File path: src/relay/backend/build_module.cc ## @@ -438,13 +442,19 @@ class Relay

[GitHub] [incubator-tvm] kumasento commented on issue #4847: Use dummy func when no lowered_funcs exists in Relay mod

2020-02-11 Thread GitBox
kumasento commented on issue #4847: Use dummy func when no lowered_funcs exists in Relay mod URL: https://github.com/apache/incubator-tvm/pull/4847#issuecomment-584869309 Thank you guys for all your kind reviews! @mbarrett97 @FrozenGene @tqchen @zhiics I've updated this PR to fulfi

[GitHub] [incubator-tvm] kumasento commented on a change in pull request #4847: Use dummy func when no lowered_funcs exists in Relay mod

2020-02-11 Thread GitBox
kumasento commented on a change in pull request #4847: Use dummy func when no lowered_funcs exists in Relay mod URL: https://github.com/apache/incubator-tvm/pull/4847#discussion_r377919235 ## File path: src/relay/backend/build_module.cc ## @@ -438,13 +442,19 @@ class Relay

[GitHub] [incubator-tvm] kumasento commented on issue #4748: [RELAY] Support RelayBuild with Only Constants

2020-02-11 Thread GitBox
kumasento commented on issue #4748: [RELAY] Support RelayBuild with Only Constants URL: https://github.com/apache/incubator-tvm/issues/4748#issuecomment-584871414 Thank you @zhiics @FrozenGene @tqchen I've changed the current implementation to use `CSourceModule`. It does not cost much and

[GitHub] [incubator-tvm] zhiics commented on a change in pull request #4847: Use dummy func when no lowered_funcs exists in Relay mod

2020-02-11 Thread GitBox
zhiics commented on a change in pull request #4847: Use dummy func when no lowered_funcs exists in Relay mod URL: https://github.com/apache/incubator-tvm/pull/4847#discussion_r377923131 ## File path: src/relay/backend/build_module.cc ## @@ -438,13 +439,14 @@ class RelayBui

[GitHub] [incubator-tvm] zhiics commented on a change in pull request #4847: Use dummy func when no lowered_funcs exists in Relay mod

2020-02-11 Thread GitBox
zhiics commented on a change in pull request #4847: Use dummy func when no lowered_funcs exists in Relay mod URL: https://github.com/apache/incubator-tvm/pull/4847#discussion_r377921458 ## File path: src/relay/backend/build_module.cc ## @@ -28,15 +28,20 @@ #include #inc

[GitHub] [incubator-tvm] zhiics commented on a change in pull request #4847: Use dummy func when no lowered_funcs exists in Relay mod

2020-02-11 Thread GitBox
zhiics commented on a change in pull request #4847: Use dummy func when no lowered_funcs exists in Relay mod URL: https://github.com/apache/incubator-tvm/pull/4847#discussion_r377926067 ## File path: src/relay/backend/build_module.cc ## @@ -438,13 +439,14 @@ class RelayBui

[GitHub] [incubator-tvm] zhiics commented on a change in pull request #4847: Use dummy func when no lowered_funcs exists in Relay mod

2020-02-11 Thread GitBox
zhiics commented on a change in pull request #4847: Use dummy func when no lowered_funcs exists in Relay mod URL: https://github.com/apache/incubator-tvm/pull/4847#discussion_r377926439 ## File path: src/relay/backend/build_module.cc ## @@ -438,13 +439,14 @@ class RelayBui

[GitHub] [incubator-tvm] hlu1 commented on a change in pull request #4859: [LLVM] Explicit llvm::StringRef to std::string conversion

2020-02-11 Thread GitBox
hlu1 commented on a change in pull request #4859: [LLVM] Explicit llvm::StringRef to std::string conversion URL: https://github.com/apache/incubator-tvm/pull/4859#discussion_r377926869 ## File path: src/target/llvm/codegen_llvm.cc ## @@ -88,7 +88,7 @@ void CodeGenLLVM::Ini

[GitHub] [incubator-tvm] kumasento commented on a change in pull request #4847: Use dummy func when no lowered_funcs exists in Relay mod

2020-02-11 Thread GitBox
kumasento commented on a change in pull request #4847: Use dummy func when no lowered_funcs exists in Relay mod URL: https://github.com/apache/incubator-tvm/pull/4847#discussion_r377927901 ## File path: src/relay/backend/build_module.cc ## @@ -438,13 +439,14 @@ class Relay

[GitHub] [incubator-tvm] mbarrett97 commented on issue #4864: [Relay] Ignore Primitive functions in Visitors

2020-02-11 Thread GitBox
mbarrett97 commented on issue #4864: [Relay] Ignore Primitive functions in Visitors URL: https://github.com/apache/incubator-tvm/pull/4864#issuecomment-584880777 I'll investigate the global function approach in the context of the graph runtime which is what I'm using at the moment. In thin

[GitHub] [incubator-tvm] masahi commented on issue #4864: [Relay] Ignore Primitive functions in Visitors

2020-02-11 Thread GitBox
masahi commented on issue #4864: [Relay] Ignore Primitive functions in Visitors URL: https://github.com/apache/incubator-tvm/pull/4864#issuecomment-584883789 Primitive functions are also created during the op fusion pass. https://github.com/apache/incubator-tvm/blob/e4d817d4c63b1f9881e5085e

[GitHub] [incubator-tvm] mbarrett97 commented on issue #4864: [Relay] Ignore Primitive functions in Visitors

2020-02-11 Thread GitBox
mbarrett97 commented on issue #4864: [Relay] Ignore Primitive functions in Visitors URL: https://github.com/apache/incubator-tvm/pull/4864#issuecomment-584886942 It would prevent the contents of the fused functions from being further modified (except by passes which specifically exempt the

[GitHub] [incubator-tvm] zhiics commented on issue #4864: [Relay] Ignore Primitive functions in Visitors

2020-02-11 Thread GitBox
zhiics commented on issue #4864: [Relay] Ignore Primitive functions in Visitors URL: https://github.com/apache/incubator-tvm/pull/4864#issuecomment-58480 hmm, it should be okay for the primitive functions created in fusion as we actually annotate external functions with `kCompiler` and

[GitHub] [incubator-tvm] alexwong edited a comment on issue #4497: [Relay] Add a PyTorch to Relay Parser

2020-02-11 Thread GitBox
alexwong edited a comment on issue #4497: [Relay] Add a PyTorch to Relay Parser URL: https://github.com/apache/incubator-tvm/pull/4497#issuecomment-584855049 > the mobilenet issue is a new one since torch update? `CUDA_ERROR_INVALID_PTX` seems a codegen issue (too many threads/shared mem pe

[GitHub] [incubator-tvm] masahi commented on issue #4864: [Relay] Ignore Primitive functions in Visitors

2020-02-11 Thread GitBox
masahi commented on issue #4864: [Relay] Ignore Primitive functions in Visitors URL: https://github.com/apache/incubator-tvm/pull/4864#issuecomment-584891015 I don't know what exactly "Primitive" function is supposed mean either, but functions created during op fusion and partitioning have

[GitHub] [incubator-tvm] tqchen merged pull request #4865: [Topi] Missing header

2020-02-11 Thread GitBox
tqchen merged pull request #4865: [Topi] Missing header URL: https://github.com/apache/incubator-tvm/pull/4865 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[incubator-tvm] branch master updated (54349ec -> 15df204)

2020-02-11 Thread tqchen
This is an automated email from the ASF dual-hosted git repository. tqchen pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git. from 54349ec Fix onnx import bugs (#4750) add 15df204 [Topi] Missing header (#4865) No new revisions were a

[GitHub] [incubator-tvm] tqchen commented on issue #4864: [Relay] Ignore Primitive functions in Visitors

2020-02-11 Thread GitBox
tqchen commented on issue #4864: [Relay] Ignore Primitive functions in Visitors URL: https://github.com/apache/incubator-tvm/pull/4864#issuecomment-584897668 Given the current discussion, I still think it is better to close this PR for now and take the lift to global approach. While

[GitHub] [incubator-tvm] tqchen edited a comment on issue #4864: [Relay] Ignore Primitive functions in Visitors

2020-02-11 Thread GitBox
tqchen edited a comment on issue #4864: [Relay] Ignore Primitive functions in Visitors URL: https://github.com/apache/incubator-tvm/pull/4864#issuecomment-584897668 Given the current discussion, I still think it is better to close this PR for now and take the lift to global approach.

[GitHub] [incubator-tvm] tqchen edited a comment on issue #4864: [Relay] Ignore Primitive functions in Visitors

2020-02-11 Thread GitBox
tqchen edited a comment on issue #4864: [Relay] Ignore Primitive functions in Visitors URL: https://github.com/apache/incubator-tvm/pull/4864#issuecomment-584897668 Given the current discussion, I still think it is better to close this PR for now and take the lift to global approach(sorry

[GitHub] [incubator-tvm] wpan11nv opened a new pull request #4867: [TOPI][CUDA] Enable vectorization on fp16 type

2020-02-11 Thread GitBox
wpan11nv opened a new pull request #4867: [TOPI][CUDA] Enable vectorization on fp16 type URL: https://github.com/apache/incubator-tvm/pull/4867 - This allows to better utilize the memory bandwidth - Note that not all cases are vectorized for fp16 datatype. For instance, when the

[GitHub] [incubator-tvm] anijain2305 commented on a change in pull request #4790: Fast exponent

2020-02-11 Thread GitBox
anijain2305 commented on a change in pull request #4790: Fast exponent URL: https://github.com/apache/incubator-tvm/pull/4790#discussion_r377957864 ## File path: topi/include/topi/elemwise.h ## @@ -360,5 +360,85 @@ inline Tensor full_like(const Tensor& x, }, name, tag);

[GitHub] [incubator-tvm] anijain2305 commented on a change in pull request #4790: Fast exponent

2020-02-11 Thread GitBox
anijain2305 commented on a change in pull request #4790: Fast exponent URL: https://github.com/apache/incubator-tvm/pull/4790#discussion_r377958380 ## File path: topi/include/topi/elemwise.h ## @@ -360,5 +360,85 @@ inline Tensor full_like(const Tensor& x, }, name, tag);

[GitHub] [incubator-tvm] anijain2305 commented on a change in pull request #4790: Fast exponent

2020-02-11 Thread GitBox
anijain2305 commented on a change in pull request #4790: Fast exponent URL: https://github.com/apache/incubator-tvm/pull/4790#discussion_r377959246 ## File path: topi/include/topi/elemwise.h ## @@ -360,5 +360,85 @@ inline Tensor full_like(const Tensor& x, }, name, tag);

[GitHub] [incubator-tvm] zhiics opened a new pull request #4868: [doc][VM] Update the vm doc

2020-02-11 Thread GitBox
zhiics opened a new pull request #4868: [doc][VM] Update the vm doc URL: https://github.com/apache/incubator-tvm/pull/4868 https://discuss.tvm.ai/t/relay-vm-from-c/5623 The VM doc is stale, this PR updates it. @icemelon9 we need a followup to update the dynamic shape handling s

[GitHub] [incubator-tvm] zhiics commented on issue #4790: Fast exponent

2020-02-11 Thread GitBox
zhiics commented on issue #4790: Fast exponent URL: https://github.com/apache/incubator-tvm/pull/4790#issuecomment-584925474 I have some silly questions: when should we switch to the fast_exp since it is in topi? Do we expect users to select it? Does this mean that this op is only availabl

[GitHub] [incubator-tvm] tqchen commented on issue #4862: [REFACTOR][PY][API-CHANGE] establish tvm.ir, migrate corresponding relay files

2020-02-11 Thread GitBox
tqchen commented on issue #4862: [REFACTOR][PY][API-CHANGE] establish tvm.ir, migrate corresponding relay files URL: https://github.com/apache/incubator-tvm/pull/4862#issuecomment-584946965 The Base class has been moved to tvm.ir.RelayExpr to reflect the changes in the C++ side, so now Exp

[GitHub] [incubator-tvm] tqchen edited a comment on issue #4862: [REFACTOR][PY][API-CHANGE] establish tvm.ir, migrate corresponding relay files

2020-02-11 Thread GitBox
tqchen edited a comment on issue #4862: [REFACTOR][PY][API-CHANGE] establish tvm.ir, migrate corresponding relay files URL: https://github.com/apache/incubator-tvm/pull/4862#issuecomment-584946965 @MarisaKirisame The Base class has been moved to tvm.ir.RelayExpr to reflect the changes in t

[GitHub] [incubator-tvm] alexgl-github commented on issue #4790: Fast exponent

2020-02-11 Thread GitBox
alexgl-github commented on issue #4790: Fast exponent URL: https://github.com/apache/incubator-tvm/pull/4790#issuecomment-584949689 > I have some silly questions: when should we switch to the fast_exp since it is in topi? Do we expect users to select it? Does this mean that this op is only

[GitHub] [incubator-tvm] tqchen commented on issue #4867: [TOPI][CUDA] Enable vectorization on fp16 type

2020-02-11 Thread GitBox
tqchen commented on issue #4867: [TOPI][CUDA] Enable vectorization on fp16 type URL: https://github.com/apache/incubator-tvm/pull/4867#issuecomment-584951383 Please request reviews from reviewers This is an automated message f

[GitHub] [incubator-tvm] masahi commented on issue #4497: [Relay] Add a PyTorch to Relay Parser

2020-02-11 Thread GitBox
masahi commented on issue #4497: [Relay] Add a PyTorch to Relay Parser URL: https://github.com/apache/incubator-tvm/pull/4497#issuecomment-584981315 hmm it's weird. After I reboot my machine, alexnet and vgg test both passed on cuda. Do you have accuracy issues with alexnet and vgg locally?

[GitHub] [incubator-tvm] masahi commented on issue #4497: [Relay] Add a PyTorch to Relay Parser

2020-02-11 Thread GitBox
masahi commented on issue #4497: [Relay] Add a PyTorch to Relay Parser URL: https://github.com/apache/incubator-tvm/pull/4497#issuecomment-584985662 @alexwong I have another finding. I get `CUDA_ERROR_INVALID_PTX` even with my `torchscript-to-tvm` repo if I use the latest TVM. Previously I

[GitHub] [incubator-tvm] masahi edited a comment on issue #4497: [Relay] Add a PyTorch to Relay Parser

2020-02-11 Thread GitBox
masahi edited a comment on issue #4497: [Relay] Add a PyTorch to Relay Parser URL: https://github.com/apache/incubator-tvm/pull/4497#issuecomment-584985662 @alexwong I have another finding. I get `CUDA_ERROR_INVALID_PTX` even with my `torchscript-to-tvm` repo if I use the latest TVM. Previo

[GitHub] [incubator-tvm] masahi commented on issue #4497: [Relay] Add a PyTorch to Relay Parser

2020-02-11 Thread GitBox
masahi commented on issue #4497: [Relay] Add a PyTorch to Relay Parser URL: https://github.com/apache/incubator-tvm/pull/4497#issuecomment-584991294 @alexwong Reverting the commit https://github.com/apache/incubator-tvm/pull/4787 fixed the mobilenet issue for me.

[GitHub] [incubator-tvm] masahi commented on a change in pull request #4497: [Relay] Add a PyTorch to Relay Parser

2020-02-11 Thread GitBox
masahi commented on a change in pull request #4497: [Relay] Add a PyTorch to Relay Parser URL: https://github.com/apache/incubator-tvm/pull/4497#discussion_r378019344 ## File path: tests/python/frontend/pytorch/test_forward.py ## @@ -0,0 +1,766 @@ +# Licensed to the Apache

  1   2   >