hadoop-yetus commented on PR #4650:
URL: https://github.com/apache/hadoop/pull/4650#issuecomment-1202031062
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
slfan1989 commented on code in PR #4656:
URL: https://github.com/apache/hadoop/pull/4656#discussion_r935124487
##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/test/java/org/apache/hadoop/yarn/server/federation/utils/FederationPoliciesTestUtil.java:
ashutoshcipher commented on code in PR #4658:
URL: https://github.com/apache/hadoop/pull/4658#discussion_r935105525
##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/client/RMProxy.java:
##
@@ -98,8 +98,7 @@ protected static T
ashutoshcipher commented on code in PR #4658:
URL: https://github.com/apache/hadoop/pull/4658#discussion_r935105330
##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/client/RMProxy.java:
##
@@ -303,4 +302,17 @@ protected static
hadoop-yetus commented on PR #4656:
URL: https://github.com/apache/hadoop/pull/4656#issuecomment-1201973872
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
hadoop-yetus commented on PR #4664:
URL: https://github.com/apache/hadoop/pull/4664#issuecomment-1201971791
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
ZanderXu commented on PR #4670:
URL: https://github.com/apache/hadoop/pull/4670#issuecomment-1201946584
> We need to pay attention to checkstyle, and then see if the junit test
problem is related to this change. Thank you.
@slfan1989 Copy, sir, I will fix them later.
--
This is an
ZanderXu commented on PR #4661:
URL: https://github.com/apache/hadoop/pull/4661#issuecomment-1201945547
@ayushtkn Thank you very much for helping me review it.
Yes, you are right, we should return an empty value for this case. How about
change it same with `getDiskBalancerStatus`,
ZanderXu commented on code in PR #4662:
URL: https://github.com/apache/hadoop/pull/4662#discussion_r935053891
##
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RBFConfigKeys.java:
##
@@ -96,6 +96,10 @@ public class
hadoop-yetus commented on PR #4594:
URL: https://github.com/apache/hadoop/pull/4594#issuecomment-1201929844
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
goiri commented on code in PR #4662:
URL: https://github.com/apache/hadoop/pull/4662#discussion_r935044257
##
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RBFConfigKeys.java:
##
@@ -96,6 +96,10 @@ public class RBFConfigKeys
goiri commented on code in PR #4663:
URL: https://github.com/apache/hadoop/pull/4663#discussion_r935043281
##
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterRpcClient.java:
##
@@ -483,10 +483,11 @@ public Object
goiri commented on code in PR #4656:
URL: https://github.com/apache/hadoop/pull/4656#discussion_r935042136
##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/test/java/org/apache/hadoop/yarn/server/federation/utils/FederationPoliciesTestUtil.java:
hadoop-yetus commented on PR #4662:
URL: https://github.com/apache/hadoop/pull/4662#issuecomment-1201918556
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
slfan1989 commented on code in PR #4650:
URL: https://github.com/apache/hadoop/pull/4650#discussion_r935028494
##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/amrmproxy/AMRMProxyService.java:
[
https://issues.apache.org/jira/browse/HADOOP-15984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17573978#comment-17573978
]
Viraj Jasani edited comment on HADOOP-15984 at 8/2/22 12:52 AM:
Tried
[
https://issues.apache.org/jira/browse/HADOOP-15984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17573978#comment-17573978
]
Viraj Jasani commented on HADOOP-15984:
---
Tried digging bit more last week but this effort is not
slfan1989 commented on PR #4670:
URL: https://github.com/apache/hadoop/pull/4670#issuecomment-1201880094
@ZanderXu We need to pay attention to checkstyle, and then see if the junit
test problem is related to this change. Thank you.
--
This is an automated message from the Apache Git
virajjasani opened a new pull request, #4671:
URL: https://github.com/apache/hadoop/pull/4671
### Description of PR
- MiniDFSCluster should report cause of exception in assertion error
- Improve message of ExitException to include cause
--
This is an automated message from the
slfan1989 commented on PR #4667:
URL: https://github.com/apache/hadoop/pull/4667#issuecomment-1201877435
@ZanderXu
> I think we need it. Because after removing it, the IDEA warns _Unchecked
cast:`org.apache.hadoop.hdfs.server.namenode.FSEditLogOp` to T._
Thanks for the
slfan1989 commented on code in PR #4656:
URL: https://github.com/apache/hadoop/pull/4656#discussion_r935005118
##
slfan1989 commented on code in PR #4656:
URL: https://github.com/apache/hadoop/pull/4656#discussion_r935003118
##
slfan1989 commented on code in PR #4656:
URL: https://github.com/apache/hadoop/pull/4656#discussion_r935001976
##
hadoop-yetus commented on PR #4670:
URL: https://github.com/apache/hadoop/pull/4670#issuecomment-1201845862
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
[
https://issues.apache.org/jira/browse/HADOOP-18358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17573966#comment-17573966
]
fanshilun commented on HADOOP-18358:
[~ayushtkn] Thank you very much for your help reviewing the
[
https://issues.apache.org/jira/browse/HADOOP-18358?focusedWorklogId=797061=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-797061
]
ASF GitHub Bot logged work on HADOOP-18358:
---
Author: ASF GitHub Bot
slfan1989 commented on PR #4619:
URL: https://github.com/apache/hadoop/pull/4619#issuecomment-1201844924
@ayushtkn Thank you very much for your help reviewing the code!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
ZanderXu closed pull request #4596: HDFS-16670. Improve Code With Lambda in
EditLogTailer class
URL: https://github.com/apache/hadoop/pull/4596
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
ZanderXu commented on PR #4596:
URL: https://github.com/apache/hadoop/pull/4596#issuecomment-1201842552
Thanks @slfan1989 for you review and nice suggestion. I will close this PR
and accomplish it in HDFS-16695.
--
This is an automated message from the Apache Git Service.
To respond to
ZanderXu commented on PR #4630:
URL: https://github.com/apache/hadoop/pull/4630#issuecomment-1201841527
@goiri Sir, can you help me review this patch? Thanks
Add detailed scop information to the log will help us to locate the root
cause of this log easily.
--
This is an automated
slfan1989 commented on PR #4594:
URL: https://github.com/apache/hadoop/pull/4594#issuecomment-1201840963
> There are a few unused imports.
Thanks for the reminder, I will remove this part.
--
This is an automated message from the Apache Git Service.
To respond to the message,
ZanderXu commented on PR #4660:
URL: https://github.com/apache/hadoop/pull/4660#issuecomment-1201838947
@goiri Sir, can you help me review this patch? Thanks
In our prod environment, we encountered the RBF NameNodeHeartbeatServices
thread being blocked for a long time because one of the
ZanderXu commented on PR #4662:
URL: https://github.com/apache/hadoop/pull/4662#issuecomment-1201834463
@goiri @slfan1989 Sir, please help me review this patch, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
ZanderXu commented on PR #4667:
URL: https://github.com/apache/hadoop/pull/4667#issuecomment-1201831182
Thanks @slfan1989 for your review.
> Can the unchecked flag be removed?
I think we need it. Because after removing it, the IDEA warns _Unchecked
ZanderXu commented on PR #4668:
URL: https://github.com/apache/hadoop/pull/4668#issuecomment-1201827298
Thanks @goiri @slfan1989 for your review.
- First, I will remove some code that has nothing to do with lambdas
- Second, I will split this PR at the subPackage Level, such as:
goiri commented on code in PR #4658:
URL: https://github.com/apache/hadoop/pull/4658#discussion_r934980277
##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/client/RMProxy.java:
##
@@ -98,8 +98,7 @@ protected static T
goiri commented on code in PR #4658:
URL: https://github.com/apache/hadoop/pull/4658#discussion_r934980055
##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/client/RMProxy.java:
##
@@ -303,4 +302,17 @@ protected static RetryPolicy
hadoop-yetus commented on PR #4667:
URL: https://github.com/apache/hadoop/pull/4667#issuecomment-1201772807
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
hadoop-yetus commented on PR #4666:
URL: https://github.com/apache/hadoop/pull/4666#issuecomment-1201732038
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
goiri commented on code in PR #4650:
URL: https://github.com/apache/hadoop/pull/4650#discussion_r934925055
##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/amrmproxy/AMRMProxyService.java:
slfan1989 commented on PR #4668:
URL: https://github.com/apache/hadoop/pull/4668#issuecomment-1201714219
> > Personally, I think this optimization should still be valuable, I hope
that the submitted pr is not at the class level, at least at the moudle level.
>
> I wouldn't go for one
hadoop-yetus commented on PR #4668:
URL: https://github.com/apache/hadoop/pull/4668#issuecomment-1201705853
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
goiri commented on PR #4594:
URL: https://github.com/apache/hadoop/pull/4594#issuecomment-1201704434
There are a few unused imports.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
hadoop-yetus commented on PR #4659:
URL: https://github.com/apache/hadoop/pull/4659#issuecomment-1201703911
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
goiri commented on code in PR #4656:
URL: https://github.com/apache/hadoop/pull/4656#discussion_r934901461
##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/test/java/org/apache/hadoop/yarn/server/federation/policies/BaseFederationPoliciesTest.java:
[
https://issues.apache.org/jira/browse/HADOOP-18368?focusedWorklogId=797027=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-797027
]
ASF GitHub Bot logged work on HADOOP-18368:
---
Author: ASF GitHub Bot
[
https://issues.apache.org/jira/browse/HADOOP-18368?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mukund Thakur resolved HADOOP-18368.
Assignee: Ahmar Suhail
Resolution: Fixed
> ITestCustomSigner fails when access
mukund-thakur commented on PR #4634:
URL: https://github.com/apache/hadoop/pull/4634#issuecomment-1201701909
pushed to branch-3.3 as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
goiri commented on PR #4668:
URL: https://github.com/apache/hadoop/pull/4668#issuecomment-1201689352
> Personally, I think this optimization should still be valuable, I hope
that the submitted pr is not at the class level, at least at the moudle level.
I wouldn't go for one per class
[
https://issues.apache.org/jira/browse/HADOOP-18368?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mukund Thakur updated HADOOP-18368:
---
Fix Version/s: 3.3.9
> ITestCustomSigner fails when access point name has '-'
>
[
https://issues.apache.org/jira/browse/HADOOP-18368?focusedWorklogId=797023=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-797023
]
ASF GitHub Bot logged work on HADOOP-18368:
---
Author: ASF GitHub Bot
[
https://issues.apache.org/jira/browse/HADOOP-18358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ayush Saxena resolved HADOOP-18358.
---
Fix Version/s: 3.4.0
Hadoop Flags: Reviewed
Resolution: Fixed
> Update
[
https://issues.apache.org/jira/browse/HADOOP-18358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17573914#comment-17573914
]
Ayush Saxena commented on HADOOP-18358:
---
Committed to trunk.
Thanx [~slfan1989] for the
mukund-thakur merged PR #4634:
URL: https://github.com/apache/hadoop/pull/4634
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/HADOOP-18358?focusedWorklogId=797022=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-797022
]
ASF GitHub Bot logged work on HADOOP-18358:
---
Author: ASF GitHub Bot
ayushtkn merged PR #4619:
URL: https://github.com/apache/hadoop/pull/4619
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
slfan1989 commented on PR #4668:
URL: https://github.com/apache/hadoop/pull/4668#issuecomment-1201661795
> This is a massive PR. I'm not sure if it is worth though. I would prefer
to scope it too.
Personally, I think this optimization should still be valuable, I hope that
the
slfan1989 commented on PR #4667:
URL: https://github.com/apache/hadoop/pull/4667#issuecomment-1201654095
Can the unchecked flag be removed?
```
@SuppressWarnings("unchecked")
public T get(FSEditLogOpCodes opCode) {
return useCache ? (T)CACHE.get().get(opCode) :
slfan1989 commented on PR #4668:
URL: https://github.com/apache/hadoop/pull/4668#issuecomment-1201649379
Personally, I think this optimization should still be valuable, but I hope
not to submit pr for one class and one class.
--
This is an automated message from the Apache Git Service.
[
https://issues.apache.org/jira/browse/HADOOP-18358?focusedWorklogId=797015=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-797015
]
ASF GitHub Bot logged work on HADOOP-18358:
---
Author: ASF GitHub Bot
slfan1989 commented on PR #4619:
URL: https://github.com/apache/hadoop/pull/4619#issuecomment-1201646809
@ayushtkn Can you help merge this pr into the trunk branch? Thank you very
much!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
slfan1989 commented on PR #4656:
URL: https://github.com/apache/hadoop/pull/4656#issuecomment-1201642818
@goiri Please help to review the code again, thank you very much!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
slfan1989 commented on PR #4670:
URL: https://github.com/apache/hadoop/pull/4670#issuecomment-1201641023
LGTM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
slfan1989 commented on code in PR #4664:
URL: https://github.com/apache/hadoop/pull/4664#discussion_r934859521
##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/test/java/org/apache/hadoop/yarn/server/router/webapp/TestRouterWebServices.java:
slfan1989 commented on PR #4650:
URL: https://github.com/apache/hadoop/pull/4650#issuecomment-1201635741
@goiri Please help to review the code again, thank you very much!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
slfan1989 commented on PR #4657:
URL: https://github.com/apache/hadoop/pull/4657#issuecomment-1201630427
@goiri Please help to review the code again, thank you very much!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
[
https://issues.apache.org/jira/browse/HADOOP-17649?focusedWorklogId=796992=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-796992
]
ASF GitHub Bot logged work on HADOOP-17649:
---
Author: ASF GitHub Bot
ashutoshcipher commented on PR #4539:
URL: https://github.com/apache/hadoop/pull/4539#issuecomment-1201585096
@steveloughran - Can you please help with review on for this PR? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
ashutoshcipher commented on PR #4658:
URL: https://github.com/apache/hadoop/pull/4658#issuecomment-1201582890
@goiri - Can you please help with review? I am have addressed you comments
in mu last commit. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to
goiri commented on code in PR #4314:
URL: https://github.com/apache/hadoop/pull/4314#discussion_r934775212
##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy/src/main/java/org/apache/hadoop/yarn/server/webproxy/AppReportFetcher.java:
##
@@ -27,81
goiri commented on code in PR #4664:
URL: https://github.com/apache/hadoop/pull/4664#discussion_r934774351
##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/test/java/org/apache/hadoop/yarn/server/router/webapp/TestRouterWebServices.java:
##
@@
goiri commented on PR #4668:
URL: https://github.com/apache/hadoop/pull/4668#issuecomment-1201520370
This is a massive PR.
I'm not sure if it is worth though.
I would prefer to scope it too.
--
This is an automated message from the Apache Git Service.
To respond to the message,
goiri commented on code in PR #4668:
URL: https://github.com/apache/hadoop/pull/4668#discussion_r934771841
##
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/EncryptionZoneManager.java:
##
@@ -636,10 +636,7 @@ private boolean
goiri commented on code in PR #4665:
URL: https://github.com/apache/hadoop/pull/4665#discussion_r934770189
##
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterRpcClient.java:
##
@@ -1580,7 +1580,7 @@ private void
goiri commented on code in PR #4670:
URL: https://github.com/apache/hadoop/pull/4670#discussion_r934768914
##
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/CheckpointFaultInjector.java:
##
@@ -36,9 +36,9 @@ public static void
[
https://issues.apache.org/jira/browse/HADOOP-18340?focusedWorklogId=796966=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-796966
]
ASF GitHub Bot logged work on HADOOP-18340:
---
Author: ASF GitHub Bot
huaxiangsun commented on PR #4608:
URL: https://github.com/apache/hadoop/pull/4608#issuecomment-1201491627
Thanks for info for ITtest for s3a. I did run IT for s3a before submitting
the patch, but did not try to run in IDE yet. Let me try.
--
This is an automated message from the Apache
[
https://issues.apache.org/jira/browse/HADOOP-18339?focusedWorklogId=796965=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-796965
]
ASF GitHub Bot logged work on HADOOP-18339:
---
Author: ASF GitHub Bot
hadoop-yetus commented on PR #4669:
URL: https://github.com/apache/hadoop/pull/4669#issuecomment-1201491003
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
[
https://issues.apache.org/jira/browse/HADOOP-18364?focusedWorklogId=796963=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-796963
]
ASF GitHub Bot logged work on HADOOP-18364:
---
Author: ASF GitHub Bot
xkrogen commented on code in PR #4624:
URL: https://github.com/apache/hadoop/pull/4624#discussion_r934744686
##
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataNodeMetrics.java:
##
@@ -591,14 +592,24 @@ public Boolean get() {
}
ZanderXu opened a new pull request, #4670:
URL: https://github.com/apache/hadoop/pull/4670
### Description of PR
When I read some class about HDFS NameNode, I found there are many redundant
throw exception in org.apahce.hadoop.hdfs.server.namenode package, such as:
```
public
[
https://issues.apache.org/jira/browse/HADOOP-12020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17573825#comment-17573825
]
Monthon Klongklaew commented on HADOOP-12020:
-
oh, I've just noticed the issue with log at
[
https://issues.apache.org/jira/browse/HADOOP-12020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17573824#comment-17573824
]
Monthon Klongklaew commented on HADOOP-12020:
-
I have added new tests for byte/heap buffer
[
https://issues.apache.org/jira/browse/HADOOP-18339?focusedWorklogId=796936=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-796936
]
ASF GitHub Bot logged work on HADOOP-18339:
---
Author: ASF GitHub Bot
[
https://issues.apache.org/jira/browse/HADOOP-18339?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated HADOOP-18339:
Labels: pull-request-available (was: )
> S3A storage class option only picked up when
monthonk opened a new pull request, #4669:
URL: https://github.com/apache/hadoop/pull/4669
### Description of PR
HADOOP-18339. S3A storage class option only picked up when buffering writes
to disk.
The problem is that there are two `createPutObjectRequest` classes, one for
9uapaw commented on code in PR #4655:
URL: https://github.com/apache/hadoop/pull/4655#discussion_r934582154
##
ZanderXu opened a new pull request, #4668:
URL: https://github.com/apache/hadoop/pull/4668
### Description of PR
Improve Code with Lambda in org.apahce.hadoop.hdfs.server.namenode package.
For example:
Current logic:
```
public ListenableFuture getJournaledEdits(
hadoop-yetus commented on PR #4655:
URL: https://github.com/apache/hadoop/pull/4655#issuecomment-1201288593
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
[
https://issues.apache.org/jira/browse/HADOOP-18368?focusedWorklogId=796906=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-796906
]
ASF GitHub Bot logged work on HADOOP-18368:
---
Author: ASF GitHub Bot
ahmarsuhail commented on PR #4634:
URL: https://github.com/apache/hadoop/pull/4634#issuecomment-1201262628
@mukund-thakur small PR which fixes an issue with ITestCustomSigner, could
you take a look please?
--
This is an automated message from the Apache Git Service.
To respond to the
hadoop-yetus commented on PR #4664:
URL: https://github.com/apache/hadoop/pull/4664#issuecomment-1201261799
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
[
https://issues.apache.org/jira/browse/HADOOP-18368?focusedWorklogId=796902=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-796902
]
ASF GitHub Bot logged work on HADOOP-18368:
---
Author: ASF GitHub Bot
9uapaw commented on code in PR #4655:
URL: https://github.com/apache/hadoop/pull/4655#discussion_r934578071
##
hadoop-yetus commented on PR #4634:
URL: https://github.com/apache/hadoop/pull/4634#issuecomment-1201259497
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
[
https://issues.apache.org/jira/browse/HADOOP-18383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Sewell updated HADOOP-18383:
--
Description:
Compressors and Decompressions with a @DoNotPool annotation are not closed when
[
https://issues.apache.org/jira/browse/HADOOP-18383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Sewell updated HADOOP-18383:
--
Description:
Compressors and Decompressions with a @DoNotPool annotation are not closed when
hadoop-yetus commented on PR #4665:
URL: https://github.com/apache/hadoop/pull/4665#issuecomment-1201232800
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: |
[
https://issues.apache.org/jira/browse/HADOOP-18362?focusedWorklogId=796880=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-796880
]
ASF GitHub Bot logged work on HADOOP-18362:
---
Author: ASF GitHub Bot
1 - 100 of 121 matches
Mail list logo
