[
https://issues.apache.org/jira/browse/HADOOP-18207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1771#comment-1771
]
ASF GitHub Bot commented on HADOOP-18207:
-
hadoop-yetus commented on PR #5717:
hadoop-yetus commented on PR #5717:
URL: https://github.com/apache/hadoop/pull/5717#issuecomment-1641452395
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexe
YuanbenWang commented on PR #5849:
URL: https://github.com/apache/hadoop/pull/5849#issuecomment-1641306654
@jojochuang @slfan1989 @ayushtkn Thank you for your review~!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
slfan1989 commented on PR #5846:
URL: https://github.com/apache/hadoop/pull/5846#issuecomment-1641268449
@haiyang1987 Thanks for your contribution! @ayushtkn @goiri @tomscut Thanks
for the review!
--
This is an automated message from the Apache Git Service.
To respond to the message, plea
slfan1989 merged PR #5846:
URL: https://github.com/apache/hadoop/pull/5846
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@had
slfan1989 commented on PR #5849:
URL: https://github.com/apache/hadoop/pull/5849#issuecomment-1641267247
@YuanbenWang Thanks for your contribution! @ayushtkn @jojochuang Thanks for
helping review!
--
This is an automated message from the Apache Git Service.
To respond to the message, ple
slfan1989 merged PR #5849:
URL: https://github.com/apache/hadoop/pull/5849
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@had
hadoop-yetus commented on PR #2821:
URL: https://github.com/apache/hadoop/pull/2821#issuecomment-1640951200
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexe
hadoop-yetus commented on PR #5810:
URL: https://github.com/apache/hadoop/pull/5810#issuecomment-1640797603
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reex
hadoop-yetus commented on PR #5841:
URL: https://github.com/apache/hadoop/pull/5841#issuecomment-1640752706
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reex
hadoop-yetus commented on PR #5637:
URL: https://github.com/apache/hadoop/pull/5637#issuecomment-1640746032
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexe
[
https://issues.apache.org/jira/browse/HADOOP-18706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17744294#comment-17744294
]
Chris Bevard commented on HADOOP-18706:
---
[~ste...@apache.org]
> Improve S3ABloc
[
https://issues.apache.org/jira/browse/HADOOP-18807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17744293#comment-17744293
]
ASF GitHub Bot commented on HADOOP-18807:
-
steveloughran commented on code in P
steveloughran commented on code in PR #5847:
URL: https://github.com/apache/hadoop/pull/5847#discussion_r1267028844
##
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/fs/viewfs/TestViewFileSystemClose.java:
##
@@ -17,26 +17,26 @@
*/
package org.apache.hadoop.f
hadoop-yetus commented on PR #5854:
URL: https://github.com/apache/hadoop/pull/5854#issuecomment-1640555209
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reex
[
https://issues.apache.org/jira/browse/HADOOP-18807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17744291#comment-17744291
]
ASF GitHub Bot commented on HADOOP-18807:
-
steveloughran commented on code in P
steveloughran commented on code in PR #5847:
URL: https://github.com/apache/hadoop/pull/5847#discussion_r1267026982
##
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/fs/viewfs/TestViewFileSystemClose.java:
##
@@ -0,0 +1,64 @@
+/**
+ * Licensed to the Apache Soft
[
https://issues.apache.org/jira/browse/HADOOP-18807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17744290#comment-17744290
]
ASF GitHub Bot commented on HADOOP-18807:
-
steveloughran commented on code in P
steveloughran commented on code in PR #5847:
URL: https://github.com/apache/hadoop/pull/5847#discussion_r1267026055
##
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFileSystem.java:
##
@@ -1926,12 +1926,41 @@ enum RenameStrategy {
SAME_FI
[
https://issues.apache.org/jira/browse/HADOOP-18805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17744283#comment-17744283
]
ASF GitHub Bot commented on HADOOP-18805:
-
virajjasani commented on PR #5851:
U
virajjasani commented on PR #5851:
URL: https://github.com/apache/hadoop/pull/5851#issuecomment-1640511615
> this jira would cover the original large file test, as it has similar
issues
you mean `ITestS3APrefetchingInputStream` correct? let me try including that
as well.
--
This i
[
https://issues.apache.org/jira/browse/HADOOP-18804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ConfX updated HADOOP-18804:
---
Attachment: reproduce.sh
> Out of Memory when mistakenly set io.file.buffer.size to a large number
> --
slfan1989 commented on code in PR #5841:
URL: https://github.com/apache/hadoop/pull/5841#discussion_r1266945158
##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/amrmproxy/TestFederationIntercepto
slfan1989 commented on code in PR #5841:
URL: https://github.com/apache/hadoop/pull/5841#discussion_r1266944879
##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/amrmproxy/AMRMProxyApplicationCont
[
https://issues.apache.org/jira/browse/HADOOP-12677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17744264#comment-17744264
]
Xiang Li commented on HADOOP-12677:
---
We exposed this problem when trying to read Spar
brumi1024 commented on code in PR #5784:
URL: https://github.com/apache/hadoop/pull/5784#discussion_r1266613396
##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmapp/RMAppImpl.java:
brumi1024 commented on code in PR #5784:
URL: https://github.com/apache/hadoop/pull/5784#discussion_r1266829431
##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmapp/RMAppImpl.java:
brumi1024 commented on code in PR #5784:
URL: https://github.com/apache/hadoop/pull/5784#discussion_r1266889475
##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmapp/RMAppRunningOnNodeEv
ferdelyi commented on code in PR #5784:
URL: https://github.com/apache/hadoop/pull/5784#discussion_r1266883249
##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmapp/RMAppRunningOnNodeEve
hadoop-yetus commented on PR #5841:
URL: https://github.com/apache/hadoop/pull/5841#issuecomment-1640362747
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reex
hadoop-yetus commented on PR #5784:
URL: https://github.com/apache/hadoop/pull/5784#issuecomment-1640352968
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reex
brumi1024 commented on code in PR #5784:
URL: https://github.com/apache/hadoop/pull/5784#discussion_r1266850170
##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmapp/RMAppRunningOnNodeEv
brumi1024 commented on code in PR #5784:
URL: https://github.com/apache/hadoop/pull/5784#discussion_r1266829431
##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmapp/RMAppImpl.java:
[
https://issues.apache.org/jira/browse/HADOOP-18808?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Steve Loughran resolved HADOOP-18808.
-
Fix Version/s: 3.3.9
Resolution: Fixed
> LogExactlyOnce to add a debug() method
[
https://issues.apache.org/jira/browse/HADOOP-18808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17744222#comment-17744222
]
ASF GitHub Bot commented on HADOOP-18808:
-
steveloughran merged PR #5850:
URL:
steveloughran merged PR #5850:
URL: https://github.com/apache/hadoop/pull/5850
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...
[
https://issues.apache.org/jira/browse/HADOOP-18809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Steve Loughran updated HADOOP-18809:
Component/s: fs/s3
> s3a prefetch read/write file operations should guard channel close
>
[
https://issues.apache.org/jira/browse/HADOOP-18809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Steve Loughran updated HADOOP-18809:
Affects Version/s: 3.3.9
> s3a prefetch read/write file operations should guard channel c
[
https://issues.apache.org/jira/browse/HADOOP-18809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Steve Loughran resolved HADOOP-18809.
-
Fix Version/s: 3.3.9
Resolution: Fixed
> s3a prefetch read/write file operations
[
https://issues.apache.org/jira/browse/HADOOP-18809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17744220#comment-17744220
]
ASF GitHub Bot commented on HADOOP-18809:
-
steveloughran merged PR #5853:
URL:
steveloughran merged PR #5853:
URL: https://github.com/apache/hadoop/pull/5853
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...
[
https://issues.apache.org/jira/browse/HADOOP-18487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17744219#comment-17744219
]
ASF GitHub Bot commented on HADOOP-18487:
-
steveloughran commented on PR #4996:
steveloughran commented on PR #4996:
URL: https://github.com/apache/hadoop/pull/4996#issuecomment-1640209168
rbf compile failure is very much related
```
rbf: [ERROR] COMPILATION ERROR :
[INFO] -
[ERROR]
/home/jenkins/j
[
https://issues.apache.org/jira/browse/HADOOP-18487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17744217#comment-17744217
]
ASF GitHub Bot commented on HADOOP-18487:
-
steveloughran commented on PR #4996:
steveloughran commented on PR #4996:
URL: https://github.com/apache/hadoop/pull/4996#issuecomment-1640205050
Failures are all in TestMRJobsWithProfiler, covered exactly in
MAPREDUCE-7436 and therefore unrelated.
This PR is ready to merge
--
This is an automated message from the Apa
[
https://issues.apache.org/jira/browse/HADOOP-18807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17744212#comment-17744212
]
ASF GitHub Bot commented on HADOOP-18807:
-
Hexiaoqiao commented on code in PR #
Hexiaoqiao commented on code in PR #5847:
URL: https://github.com/apache/hadoop/pull/5847#discussion_r1266746765
##
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFileSystem.java:
##
@@ -1926,12 +1926,41 @@ enum RenameStrategy {
SAME_FILES
Hexiaoqiao commented on code in PR #5854:
URL: https://github.com/apache/hadoop/pull/5854#discussion_r1266726577
##
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestLeaseRecoveryStriped.java:
##
@@ -17,6 +17,10 @@
*/
package org.apache.hadoop.hdfs;
+
ferdelyi commented on code in PR #5784:
URL: https://github.com/apache/hadoop/pull/5784#discussion_r1266723998
##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmapp/RMAppRunningOnNodeEve
[
https://issues.apache.org/jira/browse/HADOOP-18772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17744198#comment-17744198
]
Steve Loughran commented on HADOOP-18772:
-
go for it' i'd just missed the origi
[
https://issues.apache.org/jira/browse/HADOOP-18291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17744197#comment-17744197
]
Steve Loughran commented on HADOOP-18291:
-
bq. multiple addendum-addendum commi
[
https://issues.apache.org/jira/browse/HADOOP-18805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17744196#comment-17744196
]
ASF GitHub Bot commented on HADOOP-18805:
-
steveloughran commented on code in P
steveloughran commented on code in PR #5851:
URL: https://github.com/apache/hadoop/pull/5851#discussion_r1266680532
##
hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/ITestS3APrefetchingLruEviction.java:
##
@@ -78,39 +77,44 @@ public ITestS3APrefetchingLruEviction
hadoop-yetus commented on PR #5846:
URL: https://github.com/apache/hadoop/pull/5846#issuecomment-1640053229
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reex
fanluoo commented on PR #5591:
URL: https://github.com/apache/hadoop/pull/5591#issuecomment-1640019438
@ayushtkn could you help to review this pr ? is there anything else that i
can improve
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
brumi1024 commented on code in PR #5784:
URL: https://github.com/apache/hadoop/pull/5784#discussion_r1266612668
##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmapp/RMAppRunningOnNodeEv
[
https://issues.apache.org/jira/browse/HADOOP-18807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17744168#comment-17744168
]
ASF GitHub Bot commented on HADOOP-18807:
-
hadoop-yetus commented on PR #5847:
hadoop-yetus commented on PR #5847:
URL: https://github.com/apache/hadoop/pull/5847#issuecomment-1639994871
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexe
ferdelyi commented on PR #5784:
URL: https://github.com/apache/hadoop/pull/5784#issuecomment-1639994837
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
[
https://issues.apache.org/jira/browse/HADOOP-18757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17744164#comment-17744164
]
ASF GitHub Bot commented on HADOOP-18757:
-
modithah commented on code in PR #57
modithah commented on code in PR #5706:
URL: https://github.com/apache/hadoop/pull/5706#discussion_r1266594931
##
hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/commit/staging/integration/ITestStagingCommitProtocolFailure.java:
##
@@ -32,8 +32,7 @@
import org.ap
K0K0V0K commented on code in PR #5784:
URL: https://github.com/apache/hadoop/pull/5784#discussion_r1266592765
##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmapp/RMAppImpl.java:
##
zhangshuyan0 opened a new pull request, #5854:
URL: https://github.com/apache/hadoop/pull/5854
### Description of PR
When a block recovery occurs, `RecoveryTaskStriped` in datanode expects
`rBlock.getLocations()` and `rBlock. getBlockIndices()` to be in one-to-one
correspondence. However
ferdelyi commented on code in PR #5784:
URL: https://github.com/apache/hadoop/pull/5784#discussion_r1266568192
##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmapp/RMAppImpl.java:
#
haiyang1987 commented on PR #5846:
URL: https://github.com/apache/hadoop/pull/5846#issuecomment-1639885700
Update PR, add -dumpState.
@slfan1989 @goiri @ayushtkn sir please help me review this pr again when
you have free time. Thanks a lot!!!
--
This is an automated message from
[
https://issues.apache.org/jira/browse/HADOOP-18757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17744139#comment-17744139
]
ASF GitHub Bot commented on HADOOP-18757:
-
hadoop-yetus commented on PR #5706:
hadoop-yetus commented on PR #5706:
URL: https://github.com/apache/hadoop/pull/5706#issuecomment-1639878208
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reex
haiyang1987 commented on PR #5846:
URL: https://github.com/apache/hadoop/pull/5846#issuecomment-1639852392
> dfsrouteradmin missed `-dumpState` as well, we should add that as well
https://github.com/apache/hadoop/blob/trunk/hadoop-hdfs-project/hadoop-hdfs-rbf/src/test/java/org/apache/hadoop/
haiyang1987 commented on PR #5845:
URL: https://github.com/apache/hadoop/pull/5845#issuecomment-1639833566
> can we add a test as well, may be like one in:
[HDFS-14795](https://issues.apache.org/jira/browse/HDFS-14795)
yes. thanks sir help me review, i will add test ut later.
--
Th
slfan1989 commented on code in PR #5810:
URL: https://github.com/apache/hadoop/pull/5810#discussion_r1266392811
##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-globalpolicygenerator/src/main/java/org/apache/hadoop/yarn/server/globalpolicygenerator/GPGPolicyFacad
[
https://issues.apache.org/jira/browse/HADOOP-18291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17744079#comment-17744079
]
Quan Li commented on HADOOP-18291:
--
They were test related only, same exeception as yo
slfan1989 commented on code in PR #5810:
URL: https://github.com/apache/hadoop/pull/5810#discussion_r1266333007
##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml:
##
@@ -5426,4 +5426,36 @@
100ms
+
+
+ The interval at
72 matches
Mail list logo