[GitHub] [hadoop] hadoop-yetus commented on pull request #5062: [Testing] Jenkins for Hadoop on Windows

2023-01-07 Thread GitBox
hadoop-yetus commented on PR #5062: URL: https://github.com/apache/hadoop/pull/5062#issuecomment-1374427969 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] hadoop-yetus commented on pull request #5282: HDFS-16876: Changes cleanup of shared RouterStateIdContext to be driven by namenodeResolver data.

2023-01-07 Thread GitBox
hadoop-yetus commented on PR #5282: URL: https://github.com/apache/hadoop/pull/5282#issuecomment-1374427144 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[GitHub] [hadoop] hadoop-yetus commented on pull request #5062: [Testing] Jenkins for Hadoop on Windows

2023-01-07 Thread GitBox
hadoop-yetus commented on PR #5062: URL: https://github.com/apache/hadoop/pull/5062#issuecomment-1374416752 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at console in case of problems.

[GitHub] [hadoop] slfan1989 opened a new pull request, #5284: YARN-11218. [Federation] Add getActivities, getBulkActivities REST APIs for Router.

2023-01-07 Thread GitBox
slfan1989 opened a new pull request, #5284: URL: https://github.com/apache/hadoop/pull/5284 JIRA: YARN-11218. [Federation] Add getActivities, getBulkActivities REST APIs for Router. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [hadoop] hadoop-yetus commented on pull request #5062: [Testing] Jenkins for Hadoop on Windows

2023-01-06 Thread GitBox
hadoop-yetus commented on PR #5062: URL: https://github.com/apache/hadoop/pull/5062#issuecomment-1374409423 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at console in case of problems.

[GitHub] [hadoop] brahmareddybattula commented on pull request #5229: HADOOP-18578. Bump netty to the latest 4.1.86

2023-01-06 Thread GitBox
brahmareddybattula commented on PR #5229: URL: https://github.com/apache/hadoop/pull/5229#issuecomment-1374396629 @donghyun-kim-1 thanks for reporting. Any chance ran tests locally and seen any failures after this change..? -- This is an automated message from the Apache Git Service. To r

[GitHub] [hadoop] hadoop-yetus commented on pull request #5282: HDFS-16876: Changes cleanup of shared RouterStateIdContext to be driven by namenodeResolver data.

2023-01-06 Thread GitBox
hadoop-yetus commented on PR #5282: URL: https://github.com/apache/hadoop/pull/5282#issuecomment-1374389996 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] hadoop-yetus commented on pull request #5242: YARN-6412 aux-services classpath not documented

2023-01-06 Thread GitBox
hadoop-yetus commented on PR #5242: URL: https://github.com/apache/hadoop/pull/5242#issuecomment-1374388947 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] neshkeev commented on pull request #5267: Fix "the the" and friends typos

2023-01-06 Thread GitBox
neshkeev commented on PR #5267: URL: https://github.com/apache/hadoop/pull/5267#issuecomment-1374381874 Could this PR be merged, please? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [hadoop] haiyang1987 opened a new pull request, #5283: HDFS-16885. Fix TestHdfsConfigFields#testCompareConfigurationClassAgainstXml failed

2023-01-06 Thread GitBox
haiyang1987 opened a new pull request, #5283: URL: https://github.com/apache/hadoop/pull/5283 ### Description of PR [HDFS-16885](https://issues.apache.org/jira/browse/HDFS-16885) A new parameter "dfs.namenode.access-control-enforcer-reporting-threshold-ms" was introduced in [HDFS-

[GitHub] [hadoop] haiyang1987 commented on pull request #5280: HDFS-16884. Fix TestFsDatasetImpl#testConcurrentWriteAndDeleteBlock failed

2023-01-06 Thread GitBox
haiyang1987 commented on PR #5280: URL: https://github.com/apache/hadoop/pull/5280#issuecomment-1374375708 Hi @ZanderXu @tomscut @tasanuma please help me review this pr when you are available, Thanks. -- This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [hadoop] haiyang1987 commented on pull request #5280: HDFS-16884. Fix TestFsDatasetImpl#testConcurrentWriteAndDeleteBlock failed

2023-01-06 Thread GitBox
haiyang1987 commented on PR #5280: URL: https://github.com/apache/hadoop/pull/5280#issuecomment-1374375533 The failed unit test seems unrelated to the change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [hadoop] hadoop-yetus commented on pull request #5282: HDFS-16876: Changes cleanup of shared RouterStateIdContext to be driven by namenodeResolver data.

2023-01-06 Thread GitBox
hadoop-yetus commented on PR #5282: URL: https://github.com/apache/hadoop/pull/5282#issuecomment-1374364662 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[GitHub] [hadoop] dongjoon-hyun commented on pull request #5281: HADOOP-18590. Publish SBOM artifacts

2023-01-06 Thread GitBox
dongjoon-hyun commented on PR #5281: URL: https://github.com/apache/hadoop/pull/5281#issuecomment-1374361679 Thank you, @sunchao ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[GitHub] [hadoop] simbadzina opened a new pull request, #5282: HDFS-16876: Changes cleanup of shared RouterStateIdContext to be driven by namenodeResolver data.

2023-01-06 Thread GitBox
simbadzina opened a new pull request, #5282: URL: https://github.com/apache/hadoop/pull/5282 HDFS-16876: Changes cleanup of shared RouterStateIdContext to be driven by namenodeResolver data. ### Description of PR Changes cleanup of shared RouterStateIdContext to be driven b

[GitHub] [hadoop] omalley merged pull request #5257: HDFS-16877: Enables state context for namenode in TestObserverWithRouter

2023-01-06 Thread GitBox
omalley merged PR #5257: URL: https://github.com/apache/hadoop/pull/5257 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoo

[GitHub] [hadoop] cnauroth commented on pull request #5270: HADOOP-18587: upgrade to jettison 1.5.3 due to cve

2023-01-06 Thread GitBox
cnauroth commented on PR #5270: URL: https://github.com/apache/hadoop/pull/5270#issuecomment-1374267322 I have committed this to trunk and branch-3.3, after resolving a minor merge conflict in LICENSE-binary. @pjfanning , thank you for the contribution. @ayushtkn , thank you for advi

[GitHub] [hadoop] dongjoon-hyun commented on pull request #5281: HADOOP-18590. Publish SBOM artifacts

2023-01-06 Thread GitBox
dongjoon-hyun commented on PR #5281: URL: https://github.com/apache/hadoop/pull/5281#issuecomment-1374263495 Thank you, @cnauroth ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[GitHub] [hadoop] cnauroth merged pull request #5270: HADOOP-18587: upgrade to jettison 1.5.3 due to cve

2023-01-06 Thread GitBox
cnauroth merged PR #5270: URL: https://github.com/apache/hadoop/pull/5270 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hado

[GitHub] [hadoop] hadoop-yetus commented on pull request #5248: HADOOP-18581 : Handle Server KDC re-login when Server and Client run …

2023-01-06 Thread GitBox
hadoop-yetus commented on PR #5248: URL: https://github.com/apache/hadoop/pull/5248#issuecomment-1374252688 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] dongjoon-hyun commented on pull request #5281: HADOOP-18590. Publish SBOM artifacts

2023-01-06 Thread GitBox
dongjoon-hyun commented on PR #5281: URL: https://github.com/apache/hadoop/pull/5281#issuecomment-1374107916 cc @steveloughran , @sunchao , @snmvaughan -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [hadoop] dongjoon-hyun opened a new pull request, #5281: HADOOP-18590. Publish SBOM artifacts

2023-01-06 Thread GitBox
dongjoon-hyun opened a new pull request, #5281: URL: https://github.com/apache/hadoop/pull/5281 ### Description of PR ### How was this patch tested? ### For code changes: - [ ] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'H

[GitHub] [hadoop] hadoop-yetus commented on pull request #5272: YARN-11217. [Federation] Add dumpSchedulerLogs REST APIs for Router.

2023-01-06 Thread GitBox
hadoop-yetus commented on PR #5272: URL: https://github.com/apache/hadoop/pull/5272#issuecomment-1373879656 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[GitHub] [hadoop] hadoop-yetus commented on pull request #5280: HDFS-16884. Fix TestFsDatasetImpl#testConcurrentWriteAndDeleteBlock failed

2023-01-06 Thread GitBox
hadoop-yetus commented on PR #5280: URL: https://github.com/apache/hadoop/pull/5280#issuecomment-1373875710 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] simbadzina commented on pull request #5257: HDFS-16877: Enables state context for namenode in TestObserverWithRouter

2023-01-06 Thread GitBox
simbadzina commented on PR #5257: URL: https://github.com/apache/hadoop/pull/5257#issuecomment-1373860804 @tomscut @goiri could either of you please merge this pull request for me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [hadoop] szilard-nemeth commented on pull request #5113: YARN-6971 Clean up different ways to create resources

2023-01-06 Thread GitBox
szilard-nemeth commented on PR #5113: URL: https://github.com/apache/hadoop/pull/5113#issuecomment-1373819355 Hi @riyakhdl , Can you please check the checkstyle and unit test failures? -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [hadoop] brumi1024 commented on a diff in pull request #5278: YARN-11408. Add a check of autoQueueCreation is disabled for emitDefaultUserLimitFactor method

2023-01-06 Thread GitBox
brumi1024 commented on code in PR #5278: URL: https://github.com/apache/hadoop/pull/5278#discussion_r1063534266 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/converter/F

[GitHub] [hadoop] slfan1989 commented on a diff in pull request #5272: YARN-11217. [Federation] Add dumpSchedulerLogs REST APIs for Router.

2023-01-06 Thread GitBox
slfan1989 commented on code in PR #5272: URL: https://github.com/apache/hadoop/pull/5272#discussion_r1063514791 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/test/java/org/apache/hadoop/yarn/server/router/webapp/TestableFederationInterceptorREST.jav

[GitHub] [hadoop] hadoop-yetus commented on pull request #5279: Feature/yarn 11391

2023-01-06 Thread GitBox
hadoop-yetus commented on PR #5279: URL: https://github.com/apache/hadoop/pull/5279#issuecomment-1373465600 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] hadoop-yetus commented on pull request #4435: YARN-11178. Avoid CPU busy idling and resource wasting in DelegationTokenRenewerPoolTracker thread

2023-01-06 Thread GitBox
hadoop-yetus commented on PR #4435: URL: https://github.com/apache/hadoop/pull/4435#issuecomment-1373425771 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] pranavsaxena-microsoft commented on a diff in pull request #5273: HADOOP-17377: Add retry for HTTP 429 and HTTP 410

2023-01-06 Thread GitBox
pranavsaxena-microsoft commented on code in PR #5273: URL: https://github.com/apache/hadoop/pull/5273#discussion_r1063226881 ## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/ExponentialRetryPolicy.java: ## @@ -128,6 +138,8 @@ public boolean shoul

[GitHub] [hadoop] skysiders closed pull request #4629: YARN-11231 modify destinationTmp permission from 755 to 777

2023-01-05 Thread GitBox
skysiders closed pull request #4629: YARN-11231 modify destinationTmp permission from 755 to 777 URL: https://github.com/apache/hadoop/pull/4629 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [hadoop] haiyang1987 opened a new pull request, #5280: HDFS-16884. Fix TestFsDatasetImpl#testConcurrentWriteAndDeleteBlock failed

2023-01-05 Thread GitBox
haiyang1987 opened a new pull request, #5280: URL: https://github.com/apache/hadoop/pull/5280 ### Description of PR [HDFS-16884](https://issues.apache.org/jira/browse/HDFS-16884) Since the default is async delete replica on the datanode, the replica may not be deleted during the ex

[GitHub] [hadoop] lnbest0707 opened a new pull request, #5279: Feature/yarn 11391

2023-01-05 Thread GitBox
lnbest0707 opened a new pull request, #5279: URL: https://github.com/apache/hadoop/pull/5279 ### Description of PR The patch reuses the resolver introduced from the HDFS side and apply similar logic to YARN RM service addresses resolving. To utilize the YARN DNS support and

[GitHub] [hadoop] lnbest0707 closed pull request #5277: Yarn 11391

2023-01-05 Thread GitBox
lnbest0707 closed pull request #5277: Yarn 11391 URL: https://github.com/apache/hadoop/pull/5277 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-

[GitHub] [hadoop] hadoop-yetus commented on pull request #5276: HDFS-16882. RBF: Add cache hit rate metric in MountTableResolver#getDestinationForPath

2023-01-05 Thread GitBox
hadoop-yetus commented on PR #5276: URL: https://github.com/apache/hadoop/pull/5276#issuecomment-1373127369 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] hfutatzhanghb commented on a diff in pull request #5276: HDFS-16882. RBF: Add cache hit rate metric in MountTableResolver#getDestinationForPath

2023-01-05 Thread GitBox
hfutatzhanghb commented on code in PR #5276: URL: https://github.com/apache/hadoop/pull/5276#discussion_r1063032727 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/resolver/MountTableResolver.java: ## @@ -97,6 +99,8 @@ private fin

[GitHub] [hadoop] tomscut commented on a diff in pull request #5276: HDFS-16882. RBF: Add cache hit rate metric in MountTableResolver#getDestinationForPath

2023-01-05 Thread GitBox
tomscut commented on code in PR #5276: URL: https://github.com/apache/hadoop/pull/5276#discussion_r1063045690 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/resolver/MountTableResolver.java: ## @@ -97,6 +99,8 @@ private final Tre

[GitHub] [hadoop] hfutatzhanghb commented on a diff in pull request #5276: HDFS-16882. RBF: Add cache hit rate metric in MountTableResolver#getDestinationForPath

2023-01-05 Thread GitBox
hfutatzhanghb commented on code in PR #5276: URL: https://github.com/apache/hadoop/pull/5276#discussion_r1063032727 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/resolver/MountTableResolver.java: ## @@ -97,6 +99,8 @@ private fin

[GitHub] [hadoop] hfutatzhanghb commented on a diff in pull request #5276: HDFS-16882. RBF: Add cache hit rate metric in MountTableResolver#getDestinationForPath

2023-01-05 Thread GitBox
hfutatzhanghb commented on code in PR #5276: URL: https://github.com/apache/hadoop/pull/5276#discussion_r1063032820 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/resolver/MountTableResolver.java: ## @@ -97,6 +99,8 @@ private fin

[GitHub] [hadoop] tomscut commented on a diff in pull request #5276: HDFS-16882. RBF: Add cache hit rate metric in MountTableResolver#getDestinationForPath

2023-01-05 Thread GitBox
tomscut commented on code in PR #5276: URL: https://github.com/apache/hadoop/pull/5276#discussion_r1063016376 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/resolver/MountTableResolver.java: ## @@ -97,6 +99,8 @@ private final Tre

[GitHub] [hadoop] tomscut commented on a diff in pull request #5276: HDFS-16882. RBF: Add cache hit rate metric in MountTableResolver#getDestinationForPath

2023-01-05 Thread GitBox
tomscut commented on code in PR #5276: URL: https://github.com/apache/hadoop/pull/5276#discussion_r1063015972 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/resolver/MountTableResolver.java: ## @@ -97,6 +99,8 @@ private final Tre

[GitHub] [hadoop] hadoop-yetus commented on pull request #5257: HDFS-16877: Enables state context for namenode in TestObserverWithRouter

2023-01-05 Thread GitBox
hadoop-yetus commented on PR #5257: URL: https://github.com/apache/hadoop/pull/5257#issuecomment-1372927532 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[GitHub] [hadoop] pjfanning commented on pull request #5270: HADOOP-18587: upgrade to jettison 1.5.3 due to cve

2023-01-05 Thread GitBox
pjfanning commented on PR #5270: URL: https://github.com/apache/hadoop/pull/5270#issuecomment-1372888613 The mapreduce test failure is tracked as MAPREDUCE-7203 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [hadoop] pjfanning commented on a diff in pull request #5272: YARN-11217. [Federation] Add dumpSchedulerLogs REST APIs for Router.

2023-01-05 Thread GitBox
pjfanning commented on code in PR #5272: URL: https://github.com/apache/hadoop/pull/5272#discussion_r1062947833 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/test/java/org/apache/hadoop/yarn/server/router/webapp/TestableFederationInterceptorREST.jav

[GitHub] [hadoop] ayushtkn commented on a diff in pull request #5200: HDFS-16865. RBF: The source path is always / after RBF proxied the complete, addBlock and getAdditionalDatanode RPC.

2023-01-05 Thread GitBox
ayushtkn commented on code in PR #5200: URL: https://github.com/apache/hadoop/pull/5200#discussion_r1062932845 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterClientProtocol.java: ## @@ -465,6 +465,26 @@ public void setO

[GitHub] [hadoop] hadoop-yetus commented on pull request #5277: Yarn 11391

2023-01-05 Thread GitBox
hadoop-yetus commented on PR #5277: URL: https://github.com/apache/hadoop/pull/5277#issuecomment-1372809577 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] hadoop-yetus commented on pull request #5278: YARN-11408. Add a check of autoQueueCreation is disabled for emitDefaultUserLimitFactor method

2023-01-05 Thread GitBox
hadoop-yetus commented on PR #5278: URL: https://github.com/apache/hadoop/pull/5278#issuecomment-1372803205 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] ayushtkn commented on pull request #5270: HADOOP-18587: upgrade to jettison 1.5.3 due to cve

2023-01-05 Thread GitBox
ayushtkn commented on PR #5270: URL: https://github.com/apache/hadoop/pull/5270#issuecomment-1372754748 The HDFS one shouldn't be related. It is being chased at [HDFS-16853](https://issues.apache.org/jira/browse/HDFS-16853) -- This is an automated message from the Apache Git Service. To r

[GitHub] [hadoop] pjfanning commented on pull request #5270: HADOOP-18587: upgrade to jettison 1.5.3 due to cve

2023-01-05 Thread GitBox
pjfanning commented on PR #5270: URL: https://github.com/apache/hadoop/pull/5270#issuecomment-1372610396 @cnauroth there are still 2 test failures and they seem genuine (not intermittent failures). I might need someone with more HDFS debugging experience than me to look into this one

[GitHub] [hadoop] hadoop-yetus commented on pull request #5229: HADOOP-18578. Bump netty to the latest 4.1.86

2023-01-05 Thread GitBox
hadoop-yetus commented on PR #5229: URL: https://github.com/apache/hadoop/pull/5229#issuecomment-1372585032 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] susheel-gupta opened a new pull request, #5278: YARN-11408. Add a check of autoQueueCreation is disabled for emitDefaultUserLimitFactor method

2023-01-05 Thread GitBox
susheel-gupta opened a new pull request, #5278: URL: https://github.com/apache/hadoop/pull/5278 Change-Id: If1e36c5969d270c1b81a4bbd2e883fa819c81f20 ### Description of PR ### How was this patch tested? ### For code changes: - [ ] Does the title or t

[GitHub] [hadoop] lnbest0707 opened a new pull request, #5277: Yarn 11391

2023-01-05 Thread GitBox
lnbest0707 opened a new pull request, #5277: URL: https://github.com/apache/hadoop/pull/5277 ### Description of PR The patch reuses the resolver introduced from the HDFS side and apply similar logic to YARN RM service addresses resolving. To utilize the YARN DNS support and

[GitHub] [hadoop] lnbest0707 closed pull request #5254: Yarn-11391 Add yarn RM DNS support

2023-01-05 Thread GitBox
lnbest0707 closed pull request #5254: Yarn-11391 Add yarn RM DNS support URL: https://github.com/apache/hadoop/pull/5254 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[GitHub] [hadoop] slfan1989 commented on pull request #5272: YARN-11217. [Federation] Add dumpSchedulerLogs REST APIs for Router.

2023-01-05 Thread GitBox
slfan1989 commented on PR #5272: URL: https://github.com/apache/hadoop/pull/5272#issuecomment-1372423600 @goiri Can you help review this pr? Thank you very much! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [hadoop] hadoop-yetus commented on pull request #5276: HDFS-16882. RBF: Add cache hit rate metric in MountTableResolver#getDestinationForPath

2023-01-05 Thread GitBox
hadoop-yetus commented on PR #5276: URL: https://github.com/apache/hadoop/pull/5276#issuecomment-1372330879 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] hadoop-yetus commented on pull request #5270: HADOOP-18587: upgrade to jettison 1.5.3 due to cve

2023-01-05 Thread GitBox
hadoop-yetus commented on PR #5270: URL: https://github.com/apache/hadoop/pull/5270#issuecomment-1372298509 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] hadoop-yetus commented on pull request #5200: HDFS-16865. RBF: The source path is always / after RBF proxied the complete, addBlock and getAdditionalDatanode RPC.

2023-01-05 Thread GitBox
hadoop-yetus commented on PR #5200: URL: https://github.com/apache/hadoop/pull/5200#issuecomment-1372247333 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] hadoop-yetus commented on pull request #4499: HADOOP-18320. Fixes typos in Delegation Tokens documentation.

2023-01-05 Thread GitBox
hadoop-yetus commented on PR #4499: URL: https://github.com/apache/hadoop/pull/4499#issuecomment-1372200195 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[GitHub] [hadoop] hfutatzhanghb commented on pull request #5276: HDFS-16882. RBF: Add cache hit rate metric in MountTableResolver#getDestinationForPath

2023-01-05 Thread GitBox
hfutatzhanghb commented on PR #5276: URL: https://github.com/apache/hadoop/pull/5276#issuecomment-1372165277 Hi, @goiri @ayushtkn @ZanderXu . could you please help me review the code? thanks a lot. -- This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [hadoop] hfutatzhanghb opened a new pull request, #5276: HDFS-16882. RBF: Add cache hit rate metric in MountTableResolver#getDestinationForPath

2023-01-05 Thread GitBox
hfutatzhanghb opened a new pull request, #5276: URL: https://github.com/apache/hadoop/pull/5276 Currently, the default value of "dfs.federation.router.mount-table.cache.enable" is true and the default value of "dfs.federation.router.mount-table.max-cache-size" is 1. But there is

[GitHub] [hadoop] hfutatzhanghb closed pull request #5275: HDFS-16882. RBF: Add cache hit rate metric in MountTableResolver#getDestinationForPath

2023-01-05 Thread GitBox
hfutatzhanghb closed pull request #5275: HDFS-16882. RBF: Add cache hit rate metric in MountTableResolver#getDestinationForPath URL: https://github.com/apache/hadoop/pull/5275 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [hadoop] hadoop-yetus commented on pull request #5275: HDFS-16882. RBF: Add cache hit rate metric in MountTableResolver#getDestinationForPath

2023-01-05 Thread GitBox
hadoop-yetus commented on PR #5275: URL: https://github.com/apache/hadoop/pull/5275#issuecomment-1372116817 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] ahmarsuhail commented on pull request #4499: HADOOP-18320. Fixes typos in Delegation Tokens documentation.

2023-01-05 Thread GitBox
ahmarsuhail commented on PR #4499: URL: https://github.com/apache/hadoop/pull/4499#issuecomment-1372112947 thanks for taking a look @mukund-thakur, have made the suggested changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [hadoop] ahmarsuhail commented on a diff in pull request #4499: HADOOP-18320. Fixes typos in Delegation Tokens documentation.

2023-01-05 Thread GitBox
ahmarsuhail commented on code in PR #4499: URL: https://github.com/apache/hadoop/pull/4499#discussion_r1062386144 ## hadoop-tools/hadoop-aws/src/site/markdown/tools/hadoop-aws/delegation_tokens.md: ## @@ -353,10 +352,10 @@ it is authenticated with; the role token binding will f

[GitHub] [hadoop] hadoop-yetus commented on pull request #4435: YARN-11178. Avoid CPU busy idling and resource wasting in DelegationTokenRenewerPoolTracker thread

2023-01-05 Thread GitBox
hadoop-yetus commented on PR #4435: URL: https://github.com/apache/hadoop/pull/4435#issuecomment-1372103081 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] hadoop-yetus commented on pull request #5275: HDFS-16882. RBF: Add cache hit rate metric in MountTableResolver#getDestinationForPath

2023-01-05 Thread GitBox
hadoop-yetus commented on PR #5275: URL: https://github.com/apache/hadoop/pull/5275#issuecomment-1372081196 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] hadoop-yetus commented on pull request #5272: YARN-11217. [Federation] Add dumpSchedulerLogs REST APIs for Router.

2023-01-05 Thread GitBox
hadoop-yetus commented on PR #5272: URL: https://github.com/apache/hadoop/pull/5272#issuecomment-1372052632 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[GitHub] [hadoop] hadoop-yetus commented on pull request #5273: HADOOP-17377: Add retry for HTTP 429 and HTTP 410

2023-01-05 Thread GitBox
hadoop-yetus commented on PR #5273: URL: https://github.com/apache/hadoop/pull/5273#issuecomment-1372011908 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] hfutatzhanghb commented on pull request #5275: HDFS-16882. RBF: Add cache hit rate metric in MountTableResolver#getDestinationForPath

2023-01-05 Thread GitBox
hfutatzhanghb commented on PR #5275: URL: https://github.com/apache/hadoop/pull/5275#issuecomment-1371920367 Hi, @goiri @ayushtkn . could you please help me review the code? thanks a lot. -- This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [hadoop] hadoop-yetus commented on pull request #3440: HADOOP-17912. ABFS: Support for Encryption Context

2023-01-05 Thread GitBox
hadoop-yetus commented on PR #3440: URL: https://github.com/apache/hadoop/pull/3440#issuecomment-1371914872 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] hfutatzhanghb opened a new pull request, #5275: HDFS-16882. RBF: Add cache hit rate metric in MountTableResolver#getDestinationForPath

2023-01-05 Thread GitBox
hfutatzhanghb opened a new pull request, #5275: URL: https://github.com/apache/hadoop/pull/5275 Currently, the default value of "dfs.federation.router.mount-table.cache.enable" is true and the default value of "dfs.federation.router.mount-table.max-cache-size" is 1. But there is

[GitHub] [hadoop] hadoop-yetus commented on pull request #5217: YARN-11320. [Federation] Add getSchedulerInfo REST APIs for Router.

2023-01-04 Thread GitBox
hadoop-yetus commented on PR #5217: URL: https://github.com/apache/hadoop/pull/5217#issuecomment-1371884437 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] hadoop-yetus commented on pull request #5273: HADOOP-17377: Add retry for HTTP 429 and HTTP 410

2023-01-04 Thread GitBox
hadoop-yetus commented on PR #5273: URL: https://github.com/apache/hadoop/pull/5273#issuecomment-1371873722 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] hadoop-yetus commented on pull request #5273: HADOOP-17377: Add retry for HTTP 429 and HTTP 410

2023-01-04 Thread GitBox
hadoop-yetus commented on PR #5273: URL: https://github.com/apache/hadoop/pull/5273#issuecomment-1371868477 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[GitHub] [hadoop] LennonChin commented on a diff in pull request #4435: YARN-11178. Avoid CPU busy idling and resource wasting in DelegationTokenRenewerPoolTracker thread

2023-01-04 Thread GitBox
LennonChin commented on code in PR #4435: URL: https://github.com/apache/hadoop/pull/4435#discussion_r1062171496 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/security/DelegationTokenR

[GitHub] [hadoop] LennonChin commented on pull request #4435: YARN-11178. Avoid CPU busy idling and resource wasting in DelegationTokenRenewerPoolTracker thread

2023-01-04 Thread GitBox
LennonChin commented on PR #4435: URL: https://github.com/apache/hadoop/pull/4435#issuecomment-1371858309 I have made two commits to perform your suggestions, @slfan1989 please cc -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [hadoop] ZanderXu commented on pull request #5147: HDFS-16848. RBF: Improve StateStoreZooKeeperImpl performance

2023-01-04 Thread GitBox
ZanderXu commented on PR #5147: URL: https://github.com/apache/hadoop/pull/5147#issuecomment-1371846633 @howzi It seems the failed UT `hadoop.hdfs.server.federation.router.TestRouterRPCMultipleDestinationMountTableResolver` is not caused by this PR, but can you fix it in a new PR? -- Thi

[GitHub] [hadoop] ZanderXu commented on a diff in pull request #5147: HDFS-16848. RBF: Improve StateStoreZooKeeperImpl performance

2023-01-04 Thread GitBox
ZanderXu commented on code in PR #5147: URL: https://github.com/apache/hadoop/pull/5147#discussion_r1062141662 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/store/driver/impl/StateStoreZooKeeperImpl.java: ## @@ -109,8 +138,16 @@ pu

[GitHub] [hadoop] pranavsaxena-microsoft commented on a diff in pull request #3440: HADOOP-17912. ABFS: Support for Encryption Context

2023-01-04 Thread GitBox
pranavsaxena-microsoft commented on code in PR #3440: URL: https://github.com/apache/hadoop/pull/3440#discussion_r1062150210 ## hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/extensions/MockEncryptionContextProvider.java: ## @@ -0,0 +1,93 @@ +/** + * Licen

[GitHub] [hadoop] pranavsaxena-microsoft commented on a diff in pull request #3440: HADOOP-17912. ABFS: Support for Encryption Context

2023-01-04 Thread GitBox
pranavsaxena-microsoft commented on code in PR #3440: URL: https://github.com/apache/hadoop/pull/3440#discussion_r1062149965 ## hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/TestTracingContext.java: ## @@ -26,6 +26,7 @@ import org.apache.hadoop.conf.Co

[GitHub] [hadoop] pranavsaxena-microsoft commented on a diff in pull request #3440: HADOOP-17912. ABFS: Support for Encryption Context

2023-01-04 Thread GitBox
pranavsaxena-microsoft commented on code in PR #3440: URL: https://github.com/apache/hadoop/pull/3440#discussion_r1062149184 ## hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAzureBlobFileSystemCreate.java: ## @@ -25,6 +25,7 @@ import java.util.EnumS

[GitHub] [hadoop] pranavsaxena-microsoft commented on a diff in pull request #3440: HADOOP-17912. ABFS: Support for Encryption Context

2023-01-04 Thread GitBox
pranavsaxena-microsoft commented on code in PR #3440: URL: https://github.com/apache/hadoop/pull/3440#discussion_r1062148768 ## hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAbfsCustomEncryption.java: ## @@ -0,0 +1,330 @@ +/** + * Licensed to the Apa

[GitHub] [hadoop] pranavsaxena-microsoft commented on a diff in pull request #3440: HADOOP-17912. ABFS: Support for Encryption Context

2023-01-04 Thread GitBox
pranavsaxena-microsoft commented on code in PR #3440: URL: https://github.com/apache/hadoop/pull/3440#discussion_r1062148536 ## hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAbfsCustomEncryption.java: ## @@ -0,0 +1,330 @@ +/** + * Licensed to the Apa

[GitHub] [hadoop] pranavsaxena-microsoft commented on a diff in pull request #3440: HADOOP-17912. ABFS: Support for Encryption Context

2023-01-04 Thread GitBox
pranavsaxena-microsoft commented on code in PR #3440: URL: https://github.com/apache/hadoop/pull/3440#discussion_r1062148391 ## hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAbfsCustomEncryption.java: ## @@ -0,0 +1,330 @@ +/** + * Licensed to the Apa

[GitHub] [hadoop] pranavsaxena-microsoft commented on a diff in pull request #3440: HADOOP-17912. ABFS: Support for Encryption Context

2023-01-04 Thread GitBox
pranavsaxena-microsoft commented on code in PR #3440: URL: https://github.com/apache/hadoop/pull/3440#discussion_r1062148055 ## hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAbfsCustomEncryption.java: ## @@ -0,0 +1,330 @@ +/** + * Licensed to the Apa

[GitHub] [hadoop] pranavsaxena-microsoft commented on a diff in pull request #3440: HADOOP-17912. ABFS: Support for Encryption Context

2023-01-04 Thread GitBox
pranavsaxena-microsoft commented on code in PR #3440: URL: https://github.com/apache/hadoop/pull/3440#discussion_r1062148055 ## hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAbfsCustomEncryption.java: ## @@ -0,0 +1,330 @@ +/** + * Licensed to the Apa

[GitHub] [hadoop] pranavsaxena-microsoft commented on a diff in pull request #3440: HADOOP-17912. ABFS: Support for Encryption Context

2023-01-04 Thread GitBox
pranavsaxena-microsoft commented on code in PR #3440: URL: https://github.com/apache/hadoop/pull/3440#discussion_r1062147088 ## hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAbfsCustomEncryption.java: ## @@ -0,0 +1,330 @@ +/** + * Licensed to the Apa

[GitHub] [hadoop] pranavsaxena-microsoft commented on a diff in pull request #3440: HADOOP-17912. ABFS: Support for Encryption Context

2023-01-04 Thread GitBox
pranavsaxena-microsoft commented on code in PR #3440: URL: https://github.com/apache/hadoop/pull/3440#discussion_r1062146937 ## hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAbfsCustomEncryption.java: ## @@ -0,0 +1,330 @@ +/** + * Licensed to the Apa

[GitHub] [hadoop] pranavsaxena-microsoft commented on a diff in pull request #3440: HADOOP-17912. ABFS: Support for Encryption Context

2023-01-04 Thread GitBox
pranavsaxena-microsoft commented on code in PR #3440: URL: https://github.com/apache/hadoop/pull/3440#discussion_r1062146779 ## hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAbfsCustomEncryption.java: ## @@ -0,0 +1,330 @@ +/** + * Licensed to the Apa

[GitHub] [hadoop] pranavsaxena-microsoft commented on a diff in pull request #3440: HADOOP-17912. ABFS: Support for Encryption Context

2023-01-04 Thread GitBox
pranavsaxena-microsoft commented on code in PR #3440: URL: https://github.com/apache/hadoop/pull/3440#discussion_r1062146571 ## hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAbfsCustomEncryption.java: ## @@ -0,0 +1,330 @@ +/** + * Licensed to the Apa

[GitHub] [hadoop] pranavsaxena-microsoft commented on a diff in pull request #3440: HADOOP-17912. ABFS: Support for Encryption Context

2023-01-04 Thread GitBox
pranavsaxena-microsoft commented on code in PR #3440: URL: https://github.com/apache/hadoop/pull/3440#discussion_r1062146112 ## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/utils/EncryptionType.java: ## @@ -0,0 +1,28 @@ +/** + * Licensed to the Apache So

[GitHub] [hadoop] pranavsaxena-microsoft commented on a diff in pull request #3440: HADOOP-17912. ABFS: Support for Encryption Context

2023-01-04 Thread GitBox
pranavsaxena-microsoft commented on code in PR #3440: URL: https://github.com/apache/hadoop/pull/3440#discussion_r1062145845 ## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsOutputStream.java: ## @@ -494,17 +499,26 @@ public synchronized void

[GitHub] [hadoop] pranavsaxena-microsoft commented on a diff in pull request #3440: HADOOP-17912. ABFS: Support for Encryption Context

2023-01-04 Thread GitBox
pranavsaxena-microsoft commented on code in PR #3440: URL: https://github.com/apache/hadoop/pull/3440#discussion_r1062145205 ## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsInputStream.java: ## @@ -695,8 +701,17 @@ public boolean seekToNewSo

[GitHub] [hadoop] pranavsaxena-microsoft commented on a diff in pull request #3440: HADOOP-17912. ABFS: Support for Encryption Context

2023-01-04 Thread GitBox
pranavsaxena-microsoft commented on code in PR #3440: URL: https://github.com/apache/hadoop/pull/3440#discussion_r1062144844 ## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsInputStream.java: ## @@ -25,6 +25,7 @@ import java.util.UUID; im

[GitHub] [hadoop] mukund-thakur commented on a diff in pull request #4499: HADOOP-18320. Fixes typos in Delegation Tokens documentation.

2023-01-04 Thread GitBox
mukund-thakur commented on code in PR #4499: URL: https://github.com/apache/hadoop/pull/4499#discussion_r1062124836 ## hadoop-tools/hadoop-aws/src/site/markdown/tools/hadoop-aws/delegation_tokens.md: ## @@ -108,7 +108,7 @@ password-protected data opaque to clients; they contain

[GitHub] [hadoop] pranavsaxena-microsoft commented on a diff in pull request #3440: HADOOP-17912. ABFS: Support for Encryption Context

2023-01-04 Thread GitBox
pranavsaxena-microsoft commented on code in PR #3440: URL: https://github.com/apache/hadoop/pull/3440#discussion_r1062143955 ## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsClient.java: ## @@ -346,24 +398,29 @@ public AbfsRestOperation delet

[GitHub] [hadoop] pranavsaxena-microsoft commented on a diff in pull request #3440: HADOOP-17912. ABFS: Support for Encryption Context

2023-01-04 Thread GitBox
pranavsaxena-microsoft commented on code in PR #3440: URL: https://github.com/apache/hadoop/pull/3440#discussion_r1062143598 ## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsClient.java: ## @@ -228,16 +231,65 @@ List createDefaultHeaders() {

[GitHub] [hadoop] pranavsaxena-microsoft commented on a diff in pull request #3440: HADOOP-17912. ABFS: Support for Encryption Context

2023-01-04 Thread GitBox
pranavsaxena-microsoft commented on code in PR #3440: URL: https://github.com/apache/hadoop/pull/3440#discussion_r1062142574 ## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsClient.java: ## @@ -228,16 +231,65 @@ List createDefaultHeaders() {

[GitHub] [hadoop] pranavsaxena-microsoft commented on a diff in pull request #3440: HADOOP-17912. ABFS: Support for Encryption Context

2023-01-04 Thread GitBox
pranavsaxena-microsoft commented on code in PR #3440: URL: https://github.com/apache/hadoop/pull/3440#discussion_r1062141142 ## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsClient.java: ## @@ -160,42 +168,30 @@ private AbfsClient(final URL b

<    1   2   3   4   5   6   7   8   9   10   >