[
https://issues.apache.org/jira/browse/HADOOP-13866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16207884#comment-16207884
]
Haibo Chen commented on HADOOP-13866:
-
To summarize the current status, the netty-all version has
[
https://issues.apache.org/jira/browse/HADOOP-13866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16177945#comment-16177945
]
Hadoop QA commented on HADOOP-13866:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-13866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16177943#comment-16177943
]
stack commented on HADOOP-13866:
This issue is no longer relevant. HBase shades its netty dependency.
[
https://issues.apache.org/jira/browse/HADOOP-13866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16020335#comment-16020335
]
Andrew Wang commented on HADOOP-13866:
--
Can we try excluding Hadoop's netty dep in HBase? The point
[
https://issues.apache.org/jira/browse/HADOOP-13866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16012773#comment-16012773
]
Ted Yu commented on HADOOP-13866:
-
The shading discussion thread mentioned above hasn't led to a JIRA
[
https://issues.apache.org/jira/browse/HADOOP-13866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16012763#comment-16012763
]
Hadoop QA commented on HADOOP-13866:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-13866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16012689#comment-16012689
]
Robert Kanter commented on HADOOP-13866:
Any updates on this?
> Upgrade netty-all to
[
https://issues.apache.org/jira/browse/HADOOP-13866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15977185#comment-15977185
]
Junping Du commented on HADOOP-13866:
-
Just a quick thoughts: another alternative way is to declare
[
https://issues.apache.org/jira/browse/HADOOP-13866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15975258#comment-15975258
]
Haibo Chen commented on HADOOP-13866:
-
Thanks for the pointer [~tedyu]
> Upgrade netty-all to
[
https://issues.apache.org/jira/browse/HADOOP-13866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15973537#comment-15973537
]
Ted Yu commented on HADOOP-13866:
-
See this thread:
[
https://issues.apache.org/jira/browse/HADOOP-13866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15971427#comment-15971427
]
Haibo Chen commented on HADOOP-13866:
-
Reading through the discussion above, the decision is to go
[
https://issues.apache.org/jira/browse/HADOOP-13866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15898406#comment-15898406
]
Andrew Wang commented on HADOOP-13866:
--
Thanks Ted, please let us know how the HBase testing goes.
[
https://issues.apache.org/jira/browse/HADOOP-13866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15898379#comment-15898379
]
Junping Du commented on HADOOP-13866:
-
bq. And since the upgrading does not acquire any source
[
https://issues.apache.org/jira/browse/HADOOP-13866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15898377#comment-15898377
]
Ted Yu commented on HADOOP-13866:
-
I suggest keeping this JIRA open for a while until the following has
[
https://issues.apache.org/jira/browse/HADOOP-13866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15898370#comment-15898370
]
Andrew Wang commented on HADOOP-13866:
--
Thanks to Akira and Jason for helping with the review, I've
[
https://issues.apache.org/jira/browse/HADOOP-13866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15895340#comment-15895340
]
Andrew Wang commented on HADOOP-13866:
--
I've posted a pretty straightforward patch to HDFS-11498,
[
https://issues.apache.org/jira/browse/HADOOP-13866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15894901#comment-15894901
]
Andrew Wang commented on HADOOP-13866:
--
Re: shading, I should have spelled this out, but my
[
https://issues.apache.org/jira/browse/HADOOP-13866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15894862#comment-15894862
]
Sangjin Lee commented on HADOOP-13866:
--
Sounds like the 4.1 bump happened within 2.8, in which case
[
https://issues.apache.org/jira/browse/HADOOP-13866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15894790#comment-15894790
]
Andrew Wang commented on HADOOP-13866:
--
Thanks for the analysis Jason, I basically agree. I've been
[
https://issues.apache.org/jira/browse/HADOOP-13866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15894685#comment-15894685
]
Jason Lowe commented on HADOOP-13866:
-
We've never released a non-alpha version of Hadoop that
[
https://issues.apache.org/jira/browse/HADOOP-13866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15889238#comment-15889238
]
Duo Zhang commented on HADOOP-13866:
Have we published a 2.x hadoop final releases with
[
https://issues.apache.org/jira/browse/HADOOP-13866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15889164#comment-15889164
]
Andrew Wang commented on HADOOP-13866:
--
Sorry, I'm still -1 based on my above reasons, which I
[
https://issues.apache.org/jira/browse/HADOOP-13866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15888361#comment-15888361
]
Junping Du commented on HADOOP-13866:
-
I don't see any solid reason for veto here:
1. the library
[
https://issues.apache.org/jira/browse/HADOOP-13866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15887115#comment-15887115
]
Andrew Wang commented on HADOOP-13866:
--
We don't need to debate whether this is source
[
https://issues.apache.org/jira/browse/HADOOP-13866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15887061#comment-15887061
]
Junping Du commented on HADOOP-13866:
-
bq. As we discussed earlier, this is an incompatible change.
[
https://issues.apache.org/jira/browse/HADOOP-13866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15886997#comment-15886997
]
Andrew Wang commented on HADOOP-13866:
--
As we discussed earlier, this is an incompatible change.
[
https://issues.apache.org/jira/browse/HADOOP-13866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15886982#comment-15886982
]
Junping Du commented on HADOOP-13866:
-
Thanks [~yuzhih...@gmail.com] for doing more investigations.
[
https://issues.apache.org/jira/browse/HADOOP-13866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15886035#comment-15886035
]
Ted Yu commented on HADOOP-13866:
-
Not sure how long we can get consensus w.r.t. pulling in this change
[
https://issues.apache.org/jira/browse/HADOOP-13866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15883581#comment-15883581
]
Junping Du commented on HADOOP-13866:
-
Just give a heads up that YARN-6143 already get fixed so no
[
https://issues.apache.org/jira/browse/HADOOP-13866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15864588#comment-15864588
]
Andrew Wang commented on HADOOP-13866:
--
I want the shading done because from past experience, the
[
https://issues.apache.org/jira/browse/HADOOP-13866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15863817#comment-15863817
]
Ted Yu commented on HADOOP-13866:
-
[~xiaochen] [~andrew.wang] [~djp]:
Can this be resolved this week ?
[
https://issues.apache.org/jira/browse/HADOOP-13866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15862452#comment-15862452
]
Ted Yu commented on HADOOP-13866:
-
Test failure in TestParameterParser is reproducible.
[
https://issues.apache.org/jira/browse/HADOOP-13866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15862375#comment-15862375
]
Hadoop QA commented on HADOOP-13866:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-13866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15862337#comment-15862337
]
Ted Yu commented on HADOOP-13866:
-
bq. make HBase 2.0 to work with Hadoop 2.8.0
That would be nice.
>
[
https://issues.apache.org/jira/browse/HADOOP-13866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15862300#comment-15862300
]
Junping Du commented on HADOOP-13866:
-
Hi folks, sorry for coming late. HADOOP-14043 sounds like a
[
https://issues.apache.org/jira/browse/HADOOP-13866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15859123#comment-15859123
]
stack commented on HADOOP-13866:
+1 for master branch then (after update to latest 4.1.x). We'll need to
[
https://issues.apache.org/jira/browse/HADOOP-13866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15856975#comment-15856975
]
Andrew Wang commented on HADOOP-13866:
--
Hi all,
To clarify, I'm fine bumping netty in trunk
[
https://issues.apache.org/jira/browse/HADOOP-13866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15856940#comment-15856940
]
stack commented on HADOOP-13866:
Latest netty release on 4.1 is 4.1.8, not 4.1.1. Might want to go to
[
https://issues.apache.org/jira/browse/HADOOP-13866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15856876#comment-15856876
]
Xiao Chen commented on HADOOP-13866:
Hi [~tedyu],
I can commit this to trunk today, since didn't see
[
https://issues.apache.org/jira/browse/HADOOP-13866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15856858#comment-15856858
]
Ted Yu commented on HADOOP-13866:
-
[~andrew.wang] [~xiaochen]:
Is there anything I need to do to move
[
https://issues.apache.org/jira/browse/HADOOP-13866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15851988#comment-15851988
]
Andrew Wang commented on HADOOP-13866:
--
Hi Stack,
I'm okay with any branch-2 backport as long as
[
https://issues.apache.org/jira/browse/HADOOP-13866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15851878#comment-15851878
]
stack commented on HADOOP-13866:
I tried the patch here against the hadoop 2.7 branch and it fixed my
[
https://issues.apache.org/jira/browse/HADOOP-13866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15850837#comment-15850837
]
Xiao Chen commented on HADOOP-13866:
Thanks Ted, removed 2.9 and linked to HADOOP-14043.
I think
[
https://issues.apache.org/jira/browse/HADOOP-13866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15850826#comment-15850826
]
Ted Yu commented on HADOOP-13866:
-
2.9 can temporarily be dropped.
If HADOOP-14043 gets into 2.9, we can
[
https://issues.apache.org/jira/browse/HADOOP-13866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15850812#comment-15850812
]
Xiao Chen commented on HADOOP-13866:
So should we remove 2.9.0 from target versions? Thanks.
>
[
https://issues.apache.org/jira/browse/HADOOP-13866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15850808#comment-15850808
]
Ted Yu commented on HADOOP-13866:
-
That's true - if downstream project(s) uses netty API available in
[
https://issues.apache.org/jira/browse/HADOOP-13866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15850715#comment-15850715
]
Xiao Chen commented on HADOOP-13866:
bq. There is no code change needed for the upgrade.
Understand
[
https://issues.apache.org/jira/browse/HADOOP-13866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15850706#comment-15850706
]
Ted Yu commented on HADOOP-13866:
-
There is no code change needed for the upgrade.
> Upgrade netty-all
[
https://issues.apache.org/jira/browse/HADOOP-13866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15850693#comment-15850693
]
Xiao Chen commented on HADOOP-13866:
Thanks [~tedyu] for the continued work and testing here.
[
https://issues.apache.org/jira/browse/HADOOP-13866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15850432#comment-15850432
]
Ted Yu commented on HADOOP-13866:
-
By swapping in netty-all-4.1.1.Final.jar to hadoop directories where
[
https://issues.apache.org/jira/browse/HADOOP-13866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15843394#comment-15843394
]
Xiao Chen commented on HADOOP-13866:
Ah, I overlooked the fact that the precommit here has already
[
https://issues.apache.org/jira/browse/HADOOP-13866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15843377#comment-15843377
]
Ted Yu commented on HADOOP-13866:
-
The patch attached to HDFS-11214 carry JIRA number of this JIRA.
[
https://issues.apache.org/jira/browse/HADOOP-13866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15843337#comment-15843337
]
Xiao Chen commented on HADOOP-13866:
Thanks [~tedyu] for the work.
Could you kick off the HDFS
[
https://issues.apache.org/jira/browse/HADOOP-13866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15843299#comment-15843299
]
Ted Yu commented on HADOOP-13866:
-
Is there anything I need to do ?
> Upgrade netty-all to 4.1.1.Final
[
https://issues.apache.org/jira/browse/HADOOP-13866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15840860#comment-15840860
]
Xiaoyu Yao commented on HADOOP-13866:
-
The fix for TestAclsEndToEnd is tracked by HADOOP-14029.
>
[
https://issues.apache.org/jira/browse/HADOOP-13866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15840819#comment-15840819
]
Ted Yu commented on HADOOP-13866:
-
Ran the failed tests with patch v7 locally.
Two passed.
[
https://issues.apache.org/jira/browse/HADOOP-13866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15840806#comment-15840806
]
Hadoop QA commented on HADOOP-13866:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-13866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15840573#comment-15840573
]
Xiao Chen commented on HADOOP-13866:
Thank you, [~tedyu].
FYI - HDFS-8377 has been reverted from
[
https://issues.apache.org/jira/browse/HADOOP-13866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15838914#comment-15838914
]
Ted Yu commented on HADOOP-13866:
-
There has not been discussion in hbase community on the exact release
[
https://issues.apache.org/jira/browse/HADOOP-13866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15838909#comment-15838909
]
Xiao Chen commented on HADOOP-13866:
Thanks, so this jira is also targeting to 2.x? Could you update
[
https://issues.apache.org/jira/browse/HADOOP-13866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15838897#comment-15838897
]
Ted Yu commented on HADOOP-13866:
-
Reverting from branch-2 would make it close to trunk.
Since this
[
https://issues.apache.org/jira/browse/HADOOP-13866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15838879#comment-15838879
]
Xiao Chen commented on HADOOP-13866:
Thanks all for the comment.
So to summarize: let's revert
[
https://issues.apache.org/jira/browse/HADOOP-13866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15838875#comment-15838875
]
Duo Zhang commented on HADOOP-13866:
+1 on reverting.
> Upgrade netty-all to 4.1.1.Final
>
[
https://issues.apache.org/jira/browse/HADOOP-13866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15838866#comment-15838866
]
Junping Du commented on HADOOP-13866:
-
It is too late for 2.8.0 which is in RC stage and get frozen
[
https://issues.apache.org/jira/browse/HADOOP-13866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15838827#comment-15838827
]
Ted Yu commented on HADOOP-13866:
-
[~Apache9]:
See the above discussion.
Your opinion is appreciated.
[
https://issues.apache.org/jira/browse/HADOOP-13866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15838810#comment-15838810
]
Ted Yu commented on HADOOP-13866:
-
2.8.0 hasn't been released yet.
For 3.0, [~andrew.wang]: do you
[
https://issues.apache.org/jira/browse/HADOOP-13866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15838809#comment-15838809
]
Andrew Wang commented on HADOOP-13866:
--
bq. It looks like it's already rolled out to 2.8.0 and
[
https://issues.apache.org/jira/browse/HADOOP-13866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15838786#comment-15838786
]
Haibo Chen commented on HADOOP-13866:
-
See [~xiaochen]'s comment above.
> Upgrade netty-all to
[
https://issues.apache.org/jira/browse/HADOOP-13866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15838777#comment-15838777
]
Ted Yu commented on HADOOP-13866:
-
Where is the discussion about reverting HDFS-8377 ?
I looked at the
[
https://issues.apache.org/jira/browse/HADOOP-13866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15838772#comment-15838772
]
Haibo Chen commented on HADOOP-13866:
-
bq. If I can construct Http2ConnectionHandler using above
[
https://issues.apache.org/jira/browse/HADOOP-13866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15838686#comment-15838686
]
Ted Yu commented on HADOOP-13866:
-
I ran TestPipelinesFailover and TestNameNodeMetadataConsistency with
[
https://issues.apache.org/jira/browse/HADOOP-13866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15838663#comment-15838663
]
Ted Yu commented on HADOOP-13866:
-
In netty's Http2FrameCodec ctor :
{code}
[
https://issues.apache.org/jira/browse/HADOOP-13866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15771316#comment-15771316
]
Hadoop QA commented on HADOOP-13866:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-13866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15770705#comment-15770705
]
Ted Yu commented on HADOOP-13866:
-
testDataNodeXFrameOptionsEnabled was introduced by :
HDFS-10579.
[
https://issues.apache.org/jira/browse/HADOOP-13866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15751894#comment-15751894
]
Haibo Chen commented on HADOOP-13866:
-
You can call this inside DtpHttp2FrameListener constructor,
[
https://issues.apache.org/jira/browse/HADOOP-13866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15751677#comment-15751677
]
Ted Yu commented on HADOOP-13866:
-
Thanks for the hint, Haibo.
This is not public:
{code}
protected
[
https://issues.apache.org/jira/browse/HADOOP-13866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15749879#comment-15749879
]
Haibo Chen commented on HADOOP-13866:
-
I suspect it is this code in DtpHttp2FrameListener
[
https://issues.apache.org/jira/browse/HADOOP-13866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15749720#comment-15749720
]
Ted Yu commented on HADOOP-13866:
-
This is what DtpHttp2FrameListener writes:
{code}
[
https://issues.apache.org/jira/browse/HADOOP-13866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15749702#comment-15749702
]
Haibo Chen commented on HADOOP-13866:
-
[~ted_yu] Thanks for the patch! The test failure might have
[
https://issues.apache.org/jira/browse/HADOOP-13866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15738647#comment-15738647
]
Ted Yu commented on HADOOP-13866:
-
Additional log shows x-frame option enabled:
{code}
2016-12-10
[
https://issues.apache.org/jira/browse/HADOOP-13866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15738624#comment-15738624
]
Ted Yu commented on HADOOP-13866:
-
After getting over the above error,
[
https://issues.apache.org/jira/browse/HADOOP-13866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15738581#comment-15738581
]
Ted Yu commented on HADOOP-13866:
-
Getting a strange error locally:
{code}
Tests run: 1, Failures: 0,
[
https://issues.apache.org/jira/browse/HADOOP-13866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15729337#comment-15729337
]
Hadoop QA commented on HADOOP-13866:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-13866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15727627#comment-15727627
]
Ted Yu commented on HADOOP-13866:
-
Looks like TestDatanodeHttpXFrame#testDataNodeXFrameOptionsEnabled
[
https://issues.apache.org/jira/browse/HADOOP-13866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15727602#comment-15727602
]
Duo Zhang commented on HADOOP-13866:
I think you can just remove TestDtpHttp2. The http2 DTP related
[
https://issues.apache.org/jira/browse/HADOOP-13866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15727252#comment-15727252
]
Hadoop QA commented on HADOOP-13866:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-13866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15726765#comment-15726765
]
Ted Yu commented on HADOOP-13866:
-
HADOOP-13866.v3.patch fixes compilation.
TestDtpHttp2 doesn't pass
[
https://issues.apache.org/jira/browse/HADOOP-13866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15726161#comment-15726161
]
Ted Yu commented on HADOOP-13866:
-
[~Apache9]
Can you take a look at the compilation error above (since
[
https://issues.apache.org/jira/browse/HADOOP-13866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15726101#comment-15726101
]
Ted Yu commented on HADOOP-13866:
-
This JIRA was opened as suggested by Haibo.
Andrew was watching
[
https://issues.apache.org/jira/browse/HADOOP-13866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15726092#comment-15726092
]
Steve Loughran commented on HADOOP-13866:
-
fine, re-open this one and clsoe that as a duplicate.
[
https://issues.apache.org/jira/browse/HADOOP-13866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15726017#comment-15726017
]
Ted Yu commented on HADOOP-13866:
-
There was no discussion on HADOOP-12854
It only had 4 watchers while
[
https://issues.apache.org/jira/browse/HADOOP-13866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15725176#comment-15725176
]
Steve Loughran commented on HADOOP-13866:
-
the patches should go in to an associated HDFS- JIRA,
[
https://issues.apache.org/jira/browse/HADOOP-13866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15723683#comment-15723683
]
Ted Yu commented on HADOOP-13866:
-
Haibo:
If you have bandwidth, feel free to attach patch(es).
I may
[
https://issues.apache.org/jira/browse/HADOOP-13866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15723508#comment-15723508
]
Hadoop QA commented on HADOOP-13866:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-13866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15723411#comment-15723411
]
Haibo Chen commented on HADOOP-13866:
-
My quick check shows that upgrading to 4.1.1.Final breaks
[
https://issues.apache.org/jira/browse/HADOOP-13866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15723337#comment-15723337
]
Ted Yu commented on HADOOP-13866:
-
If I name the patch HDFS-13866.v1.patch, would QA report back test
[
https://issues.apache.org/jira/browse/HADOOP-13866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15723330#comment-15723330
]
Steve Loughran commented on HADOOP-13866:
-
really we should kick off the build and test for all
[
https://issues.apache.org/jira/browse/HADOOP-13866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15723327#comment-15723327
]
Ted Yu commented on HADOOP-13866:
-
netty-all is used by :
[
https://issues.apache.org/jira/browse/HADOOP-13866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15723315#comment-15723315
]
Andrew Wang commented on HADOOP-13866:
--
It seems like precommit also didn't run any unit tests. We
[
https://issues.apache.org/jira/browse/HADOOP-13866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15723310#comment-15723310
]
Andrew Wang commented on HADOOP-13866:
--
Is this an incompatible change?
> Upgrade netty-all to
1 - 100 of 101 matches
Mail list logo
