[GitHub] [hadoop] hadoop-yetus commented on issue #1431: HDDS-1569 Support creating multiple pipelines with same datanode

2019-09-26 Thread GitBox
hadoop-yetus commented on issue #1431: HDDS-1569 Support creating multiple pipelines with same datanode URL: https://github.com/apache/hadoop/pull/1431#issuecomment-535403493 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hadoop] vivekratnavel commented on issue #1528: HDDS-2181. Ozone Manager should send correct ACL type in ACL requests…

2019-09-26 Thread GitBox
vivekratnavel commented on issue #1528: HDDS-2181. Ozone Manager should send correct ACL type in ACL requests… URL: https://github.com/apache/hadoop/pull/1528#issuecomment-535358050 @xiaoyuyao @anuengineer Please review This

[GitHub] [hadoop] vivekratnavel opened a new pull request #1528: HDDS-2181. Ozone Manager should send correct ACL type in ACL requests…

2019-09-26 Thread GitBox
vivekratnavel opened a new pull request #1528: HDDS-2181. Ozone Manager should send correct ACL type in ACL requests… URL: https://github.com/apache/hadoop/pull/1528 … to Authorizer Currently, Ozone manager sends "WRITE" as ACLType for key create, key delete and bucket create

[GitHub] [hadoop] vivekratnavel commented on issue #1528: HDDS-2181. Ozone Manager should send correct ACL type in ACL requests…

2019-09-26 Thread GitBox
vivekratnavel commented on issue #1528: HDDS-2181. Ozone Manager should send correct ACL type in ACL requests… URL: https://github.com/apache/hadoop/pull/1528#issuecomment-535357989 /label ozone This is an automated message

[GitHub] [hadoop] hadoop-yetus commented on issue #1528: HDDS-2181. Ozone Manager should send correct ACL type in ACL requests…

2019-09-26 Thread GitBox
hadoop-yetus commented on issue #1528: HDDS-2181. Ozone Manager should send correct ACL type in ACL requests… URL: https://github.com/apache/hadoop/pull/1528#issuecomment-535370213 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[jira] [Commented] (HADOOP-16606) checksum link from hadoop web site is broken.

2019-09-26 Thread Rohith Sharma K S (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16938411#comment-16938411 ] Rohith Sharma K S commented on HADOOP-16606: I am wondering why do we need to move sha512

[GitHub] [hadoop] elek commented on issue #1529: HDDS-2182. Fix checkstyle violations introduced by HDDS-1738

2019-09-26 Thread GitBox
elek commented on issue #1529: HDDS-2182. Fix checkstyle violations introduced by HDDS-1738 URL: https://github.com/apache/hadoop/pull/1529#issuecomment-535395150 /retest This is an automated message from the Apache Git

[GitHub] [hadoop] hadoop-yetus commented on issue #1529: HDDS-2182. Fix checkstyle violations introduced by HDDS-1738

2019-09-26 Thread GitBox
hadoop-yetus commented on issue #1529: HDDS-2182. Fix checkstyle violations introduced by HDDS-1738 URL: https://github.com/apache/hadoop/pull/1529#issuecomment-535374603 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hadoop] aasha opened a new pull request #1530: HDFS-14869 Copy renamed files which are not excluded anymore by filter

2019-09-26 Thread GitBox
aasha opened a new pull request #1530: HDFS-14869 Copy renamed files which are not excluded anymore by filter URL: https://github.com/apache/hadoop/pull/1530 ## NOTICE Please create an issue in ASF JIRA before opening a pull request, and you need to set the title of the pull

[jira] [Commented] (HADOOP-16558) [COMMON+HDFS] use protobuf-maven-plugin to generate protobuf classes

2019-09-26 Thread Junping Du (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16938318#comment-16938318 ] Junping Du commented on HADOOP-16558: - bq. I think this should go into all active branches? Agree.

[jira] [Commented] (HADOOP-15616) Incorporate Tencent Cloud COS File System Implementation

2019-09-26 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-15616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16938329#comment-16938329 ] Hadoop QA commented on HADOOP-15616: | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote ||

[GitHub] [hadoop] elek closed pull request #1529: HDDS-2182. Fix checkstyle violations introduced by HDDS-1738

2019-09-26 Thread GitBox
elek closed pull request #1529: HDDS-2182. Fix checkstyle violations introduced by HDDS-1738 URL: https://github.com/apache/hadoop/pull/1529 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [hadoop] elek commented on a change in pull request #1501: HDDS-2067. Create generic service facade with tracing/metrics/logging support

2019-09-26 Thread GitBox
elek commented on a change in pull request #1501: HDDS-2067. Create generic service facade with tracing/metrics/logging support URL: https://github.com/apache/hadoop/pull/1501#discussion_r328546227 ## File path:

[GitHub] [hadoop] vivekratnavel opened a new pull request #1529: HDDS-2182. Fix checkstyle violations introduced by HDDS-1738

2019-09-26 Thread GitBox
vivekratnavel opened a new pull request #1529: HDDS-2182. Fix checkstyle violations introduced by HDDS-1738 URL: https://github.com/apache/hadoop/pull/1529 This is an automated message from the Apache Git Service. To

[GitHub] [hadoop] vivekratnavel commented on issue #1529: HDDS-2182. Fix checkstyle violations introduced by HDDS-1738

2019-09-26 Thread GitBox
vivekratnavel commented on issue #1529: HDDS-2182. Fix checkstyle violations introduced by HDDS-1738 URL: https://github.com/apache/hadoop/pull/1529#issuecomment-535362376 @elek @adoroszlai Please review This is an automated

[GitHub] [hadoop] vivekratnavel commented on issue #1529: HDDS-2182. Fix checkstyle violations introduced by HDDS-1738

2019-09-26 Thread GitBox
vivekratnavel commented on issue #1529: HDDS-2182. Fix checkstyle violations introduced by HDDS-1738 URL: https://github.com/apache/hadoop/pull/1529#issuecomment-535362292 /label ozone This is an automated message from the

[GitHub] [hadoop] Apache9 closed pull request #1512: HADOOP-16598. Backport "HADOOP-16558 [COMMON+HDFS] use protobuf-maven…

2019-09-26 Thread GitBox
Apache9 closed pull request #1512: HADOOP-16598. Backport "HADOOP-16558 [COMMON+HDFS] use protobuf-maven… URL: https://github.com/apache/hadoop/pull/1512 This is an automated message from the Apache Git Service. To respond

[jira] [Commented] (HADOOP-16503) [JDK11] TestLeafQueue tests are failing due to WrongTypeOfReturnValue

2019-09-26 Thread Kinga Marton (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16938345#comment-16938345 ] Kinga Marton commented on HADOOP-16503: --- The test failure is unrelated. This test failure is

[GitHub] [hadoop] timmylicheng commented on issue #1431: HDDS-1569 Support creating multiple pipelines with same datanode

2019-09-26 Thread GitBox
timmylicheng commented on issue #1431: HDDS-1569 Support creating multiple pipelines with same datanode URL: https://github.com/apache/hadoop/pull/1431#issuecomment-535406569 /retest This is an automated message from the

[jira] [Commented] (HADOOP-16503) [JDK11] TestLeafQueue tests are failing due to WrongTypeOfReturnValue

2019-09-26 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16938430#comment-16938430 ] Hadoop QA commented on HADOOP-16503: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Updated] (HADOOP-16503) [JDK11] TestLeafQueue tests are failing due to WrongTypeOfReturnValue

2019-09-26 Thread Kinga Marton (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16503?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kinga Marton updated HADOOP-16503: -- Attachment: HADOOP-16503.003.patch > [JDK11] TestLeafQueue tests are failing due to

[GitHub] [hadoop] elek commented on issue #1513: HDDS-2149. Replace FindBugs with SpotBugs

2019-09-26 Thread GitBox
elek commented on issue #1513: HDDS-2149. Replace FindBugs with SpotBugs URL: https://github.com/apache/hadoop/pull/1513#issuecomment-535540747 /retest This is an automated message from the Apache Git Service. To respond to

[GitHub] [hadoop] hadoop-yetus commented on issue #1514: HDDS-2072. Make StorageContainerLocationProtocolService message based

2019-09-26 Thread GitBox
hadoop-yetus commented on issue #1514: HDDS-2072. Make StorageContainerLocationProtocolService message based URL: https://github.com/apache/hadoop/pull/1514#issuecomment-535574078 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hadoop] anuengineer merged pull request #1526: HDDS-2180. Add Object ID and update ID on VolumeList Object.

2019-09-26 Thread GitBox
anuengineer merged pull request #1526: HDDS-2180. Add Object ID and update ID on VolumeList Object. URL: https://github.com/apache/hadoop/pull/1526 This is an automated message from the Apache Git Service. To respond to the

[jira] [Commented] (HADOOP-15685) Build fails (hadoop pipes) on newer Linux envs (like Fedora 28)

2019-09-26 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-15685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16938798#comment-16938798 ] Hadoop QA commented on HADOOP-15685: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[GitHub] [hadoop] adoroszlai commented on a change in pull request #1513: HDDS-2149. Replace FindBugs with SpotBugs

2019-09-26 Thread GitBox
adoroszlai commented on a change in pull request #1513: HDDS-2149. Replace FindBugs with SpotBugs URL: https://github.com/apache/hadoop/pull/1513#discussion_r328660397 ## File path: hadoop-ozone/dev-support/checks/findbugs.sh ## @@ -16,16 +16,22 @@ DIR="$( cd "$( dirname

[GitHub] [hadoop] bharatviswa504 commented on issue #1511: HDDS-2162. Make Kerberos related configuration support HA style config.

2019-09-26 Thread GitBox
bharatviswa504 commented on issue #1511: HDDS-2162. Make Kerberos related configuration support HA style config. URL: https://github.com/apache/hadoop/pull/1511#issuecomment-53194 /retest This is an automated message

[GitHub] [hadoop] hadoop-yetus commented on issue #1521: HDDS-2073. Make SCMSecurityProtocol message based

2019-09-26 Thread GitBox
hadoop-yetus commented on issue #1521: HDDS-2073. Make SCMSecurityProtocol message based URL: https://github.com/apache/hadoop/pull/1521#issuecomment-535574747 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[jira] [Commented] (HADOOP-15685) Build fails (hadoop pipes) on newer Linux envs (like Fedora 28)

2019-09-26 Thread Ayush Saxena (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-15685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16938794#comment-16938794 ] Ayush Saxena commented on HADOOP-15685: --- IIRC [~bibinchundatt] got a solution for us couple of

[GitHub] [hadoop] hadoop-yetus commented on issue #1533: HDDS-2185. createmrenv failure not reflected in acceptance test result

2019-09-26 Thread GitBox
hadoop-yetus commented on issue #1533: HDDS-2185. createmrenv failure not reflected in acceptance test result URL: https://github.com/apache/hadoop/pull/1533#issuecomment-535549355 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hadoop] vivekratnavel commented on issue #1528: HDDS-2181. Ozone Manager should send correct ACL type in ACL requests…

2019-09-26 Thread GitBox
vivekratnavel commented on issue #1528: HDDS-2181. Ozone Manager should send correct ACL type in ACL requests… URL: https://github.com/apache/hadoop/pull/1528#issuecomment-535552218 /retest This is an automated message from

[GitHub] [hadoop] anuengineer commented on a change in pull request #1504: HDDS-2068. Make StorageContainerDatanodeProtocolService message based

2019-09-26 Thread GitBox
anuengineer commented on a change in pull request #1504: HDDS-2068. Make StorageContainerDatanodeProtocolService message based URL: https://github.com/apache/hadoop/pull/1504#discussion_r328404623 ## File path:

[GitHub] [hadoop] hadoop-yetus commented on issue #1531: HADOOP-16579 - Upgrade to Apache Curator 4.2.0 excluding ZK

2019-09-26 Thread GitBox
hadoop-yetus commented on issue #1531: HADOOP-16579 - Upgrade to Apache Curator 4.2.0 excluding ZK URL: https://github.com/apache/hadoop/pull/1531#issuecomment-535539541 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hadoop] hadoop-yetus commented on issue #1532: HDDS-2183. Container and pipline subcommands of scmcli should be grouped.

2019-09-26 Thread GitBox
hadoop-yetus commented on issue #1532: HDDS-2183. Container and pipline subcommands of scmcli should be grouped. URL: https://github.com/apache/hadoop/pull/1532#issuecomment-535547992 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hadoop] adoroszlai commented on issue #1533: HDDS-2185. createmrenv failure not reflected in acceptance test result

2019-09-26 Thread GitBox
adoroszlai commented on issue #1533: HDDS-2185. createmrenv failure not reflected in acceptance test result URL: https://github.com/apache/hadoop/pull/1533#issuecomment-535531451 /label ozone This is an automated message

[GitHub] [hadoop] adoroszlai opened a new pull request #1533: HDDS-2185. createmrenv failure not reflected in acceptance test result

2019-09-26 Thread GitBox
adoroszlai opened a new pull request #1533: HDDS-2185. createmrenv failure not reflected in acceptance test result URL: https://github.com/apache/hadoop/pull/1533 ## What changes were proposed in this pull request? Avoid purging results dir when `testlib.sh` is `source`d.

[GitHub] [hadoop] hadoop-yetus commented on issue #1431: HDDS-1569 Support creating multiple pipelines with same datanode

2019-09-26 Thread GitBox
hadoop-yetus commented on issue #1431: HDDS-1569 Support creating multiple pipelines with same datanode URL: https://github.com/apache/hadoop/pull/1431#issuecomment-535547508 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hadoop] hadoop-yetus commented on issue #1532: HDDS-2183. Container and pipline subcommands of scmcli should be grouped.

2019-09-26 Thread GitBox
hadoop-yetus commented on issue #1532: HDDS-2183. Container and pipline subcommands of scmcli should be grouped. URL: https://github.com/apache/hadoop/pull/1532#issuecomment-535576563 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hadoop] elek commented on a change in pull request #1513: HDDS-2149. Replace FindBugs with SpotBugs

2019-09-26 Thread GitBox
elek commented on a change in pull request #1513: HDDS-2149. Replace FindBugs with SpotBugs URL: https://github.com/apache/hadoop/pull/1513#discussion_r328659287 ## File path: hadoop-ozone/dev-support/checks/findbugs.sh ## @@ -16,16 +16,22 @@ DIR="$( cd "$( dirname

[jira] [Commented] (HADOOP-16520) race condition in DDB table init and waiting threads

2019-09-26 Thread Gabor Bota (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16938690#comment-16938690 ] Gabor Bota commented on HADOOP-16520: - I'll try to solve this the other way: add the version marker

[GitHub] [hadoop] hadoop-yetus commented on issue #1504: HDDS-2068. Make StorageContainerDatanodeProtocolService message based

2019-09-26 Thread GitBox
hadoop-yetus commented on issue #1504: HDDS-2068. Make StorageContainerDatanodeProtocolService message based URL: https://github.com/apache/hadoop/pull/1504#issuecomment-535575211 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hadoop] hadoop-yetus commented on issue #1530: HDFS-14869 Copy renamed files which are not excluded anymore by filter

2019-09-26 Thread GitBox
hadoop-yetus commented on issue #1530: HDFS-14869 Copy renamed files which are not excluded anymore by filter URL: https://github.com/apache/hadoop/pull/1530#issuecomment-535466321 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hadoop] ayushtkn commented on issue #1527: HADOOP-16610. Upgrade to yetus 0.11.0 and use emoji vote on github pre…

2019-09-26 Thread GitBox
ayushtkn commented on issue #1527: HADOOP-16610. Upgrade to yetus 0.11.0 and use emoji vote on github pre… URL: https://github.com/apache/hadoop/pull/1527#issuecomment-535476829 IMO That +1 -1 are more descriptive and looks better as compared to this Hearts

[GitHub] [hadoop] ayushtkn commented on issue #1527: HADOOP-16610. Upgrade to yetus 0.11.0 and use emoji vote on github pre…

2019-09-26 Thread GitBox
ayushtkn commented on issue #1527: HADOOP-16610. Upgrade to yetus 0.11.0 and use emoji vote on github pre… URL: https://github.com/apache/hadoop/pull/1527#issuecomment-535476839 IMO That +1 -1 are more descriptive and looks better as compared to this Hearts

[jira] [Commented] (HADOOP-16600) StagingTestBase uses methods not available in Mockito 1.8.5 in branch-3.1

2019-09-26 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16938606#comment-16938606 ] Duo Zhang commented on HADOOP-16600: Tried to reset to this commit commit

[GitHub] [hadoop] cxorm opened a new pull request #1532: HDDS-2183. Container and pipline subcommands of scmcli should be grouped.

2019-09-26 Thread GitBox
cxorm opened a new pull request #1532: HDDS-2183. Container and pipline subcommands of scmcli should be grouped. URL: https://github.com/apache/hadoop/pull/1532 ## NOTICE Please create an issue in ASF JIRA before opening a pull request, and you need to set the title of the pull

[GitHub] [hadoop] lokeshj1703 commented on issue #1431: HDDS-1569 Support creating multiple pipelines with same datanode

2019-09-26 Thread GitBox
lokeshj1703 commented on issue #1431: HDDS-1569 Support creating multiple pipelines with same datanode URL: https://github.com/apache/hadoop/pull/1431#issuecomment-535459860 /retest This is an automated message from the

[GitHub] [hadoop] hadoop-yetus removed a comment on issue #1442: HADOOP-16570. S3A committers encounter scale issues

2019-09-26 Thread GitBox
hadoop-yetus removed a comment on issue #1442: HADOOP-16570. S3A committers encounter scale issues URL: https://github.com/apache/hadoop/pull/1442#issuecomment-534683787 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hadoop] nkalmar opened a new pull request #1531: HADOOP-16579 - Upgrade to Apache Curator 4.2.0 excluding ZK

2019-09-26 Thread GitBox
nkalmar opened a new pull request #1531: HADOOP-16579 - Upgrade to Apache Curator 4.2.0 excluding ZK URL: https://github.com/apache/hadoop/pull/1531 This is an automated message from the Apache Git Service. To respond

[jira] [Commented] (HADOOP-16503) [JDK11] TestLeafQueue tests are failing due to WrongTypeOfReturnValue

2019-09-26 Thread Kinga Marton (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16938485#comment-16938485 ] Kinga Marton commented on HADOOP-16503: --- The failed unit test seems a flaky one and I am pretty

[jira] [Commented] (HADOOP-15691) Add PathCapabilities to FS and FC to complement StreamCapabilities

2019-09-26 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-15691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16938507#comment-16938507 ] Steve Loughran commented on HADOOP-15691: - Apart from its breadth, I'd like to backport this to

[GitHub] [hadoop] steveloughran commented on issue #1523: HADOOP-16611. Make test4tests vote for -0 instead of -1

2019-09-26 Thread GitBox
steveloughran commented on issue #1523: HADOOP-16611. Make test4tests vote for -0 instead of -1 URL: https://github.com/apache/hadoop/pull/1523#issuecomment-535461886 I actually quite like the -1, as it says "you need a good explanation". If people are submitting patches without

[jira] [Commented] (HADOOP-16600) StagingTestBase uses methods not available in Mockito 1.8.5 in branch-3.1

2019-09-26 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16938511#comment-16938511 ] Steve Loughran commented on HADOOP-16600: - I'm confused. When did this breakage happen? I'd

[jira] [Commented] (HADOOP-16598) Backport "HADOOP-16558 [COMMON+HDFS] use protobuf-maven-plugin to generate protobuf classes" to all active branches

2019-09-26 Thread Junping Du (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16938522#comment-16938522 ] Junping Du commented on HADOOP-16598: - The patch LGTM. +1. Will commit it shortly if no other

[jira] [Commented] (HADOOP-16598) Backport "HADOOP-16558 [COMMON+HDFS] use protobuf-maven-plugin to generate protobuf classes" to all active branches

2019-09-26 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16938534#comment-16938534 ] Duo Zhang commented on HADOOP-16598: Will also upload patches for other active branches here, but

[jira] [Resolved] (HADOOP-16611) Make test4tests vote for -0 instead of -1

2019-09-26 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HADOOP-16611. Resolution: Not A Problem > Make test4tests vote for -0 instead of -1 >

[GitHub] [hadoop] Apache9 commented on issue #1527: HADOOP-16610. Upgrade to yetus 0.11.0 and use emoji vote on github pre…

2019-09-26 Thread GitBox
Apache9 commented on issue #1527: HADOOP-16610. Upgrade to yetus 0.11.0 and use emoji vote on github pre… URL: https://github.com/apache/hadoop/pull/1527#issuecomment-535479017 But it is really hard to find out the -1 as there is no color? For the pre commit on jira, we have different

[GitHub] [hadoop] steveloughran commented on a change in pull request #1442: HADOOP-16570. S3A committers encounter scale issues

2019-09-26 Thread GitBox
steveloughran commented on a change in pull request #1442: HADOOP-16570. S3A committers encounter scale issues URL: https://github.com/apache/hadoop/pull/1442#discussion_r328619684 ## File path:

[jira] [Updated] (HADOOP-16579) Upgrade to Apache Curator 4.2.0 in Hadoop

2019-09-26 Thread Jira
[ https://issues.apache.org/jira/browse/HADOOP-16579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Norbert Kalmár updated HADOOP-16579: Status: Patch Available (was: In Progress) > Upgrade to Apache Curator 4.2.0 in Hadoop

[jira] [Work started] (HADOOP-16579) Upgrade to Apache Curator 4.2.0 in Hadoop

2019-09-26 Thread Jira
[ https://issues.apache.org/jira/browse/HADOOP-16579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HADOOP-16579 started by Norbert Kalmár. --- > Upgrade to Apache Curator 4.2.0 in Hadoop >

[GitHub] [hadoop] timmylicheng commented on issue #1431: HDDS-1569 Support creating multiple pipelines with same datanode

2019-09-26 Thread GitBox
timmylicheng commented on issue #1431: HDDS-1569 Support creating multiple pipelines with same datanode URL: https://github.com/apache/hadoop/pull/1431#issuecomment-535527900 Many integration tests using MiniOzoneCluster seem to have memory issues, which could be related to the change of

[GitHub] [hadoop] Apache9 closed pull request #1523: HADOOP-16611. Make test4tests vote for -0 instead of -1

2019-09-26 Thread GitBox
Apache9 closed pull request #1523: HADOOP-16611. Make test4tests vote for -0 instead of -1 URL: https://github.com/apache/hadoop/pull/1523 This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Commented] (HADOOP-16600) StagingTestBase uses methods not available in Mockito 1.8.5 in branch-3.1

2019-09-26 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16938551#comment-16938551 ] Duo Zhang commented on HADOOP-16600: [~ste...@apache.org] The code is introduced by HADOOP-13786.

[jira] [Commented] (HADOOP-16600) StagingTestBase uses methods not available in Mockito 1.8.5 in branch-3.1

2019-09-26 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16938615#comment-16938615 ] Duo Zhang commented on HADOOP-16600: And another thing is that in HADOOP-14918, we introduced a

[GitHub] [hadoop] Apache9 commented on issue #1527: HADOOP-16610. Upgrade to yetus 0.11.0 and use emoji vote on github pre…

2019-09-26 Thread GitBox
Apache9 commented on issue #1527: HADOOP-16610. Upgrade to yetus 0.11.0 and use emoji vote on github pre… URL: https://github.com/apache/hadoop/pull/1527#issuecomment-535505595 https://github.com/apache/yetus/pull/73 This is

[GitHub] [hadoop] adoroszlai commented on issue #1525: HDDS-2179. ConfigFileGenerator fails with Java 10 or newer

2019-09-26 Thread GitBox
adoroszlai commented on issue #1525: HDDS-2179. ConfigFileGenerator fails with Java 10 or newer URL: https://github.com/apache/hadoop/pull/1525#issuecomment-535454934 /retest This is an automated message from the Apache Git

[GitHub] [hadoop] Apache9 commented on issue #1523: HADOOP-16611. Make test4tests vote for -0 instead of -1

2019-09-26 Thread GitBox
Apache9 commented on issue #1523: HADOOP-16611. Make test4tests vote for -0 instead of -1 URL: https://github.com/apache/hadoop/pull/1523#issuecomment-535474210 OK, htat's fine, will keep it as is. Mind taking a look at HADOOP-16610, i.e. #1527? Thanks.

[GitHub] [hadoop] steveloughran commented on issue #1527: HADOOP-16610. Upgrade to yetus 0.11.0 and use emoji vote on github pre…

2019-09-26 Thread GitBox
steveloughran commented on issue #1527: HADOOP-16610. Upgrade to yetus 0.11.0 and use emoji vote on github pre… URL: https://github.com/apache/hadoop/pull/1527#issuecomment-535484273 could we do emoji and text? no app should use nothing but red and green to distinguish state as

[GitHub] [hadoop] Apache9 commented on issue #1527: HADOOP-16610. Upgrade to yetus 0.11.0 and use emoji vote on github pre…

2019-09-26 Thread GitBox
Apache9 commented on issue #1527: HADOOP-16610. Upgrade to yetus 0.11.0 and use emoji vote on github pre… URL: https://github.com/apache/hadoop/pull/1527#issuecomment-535492302 It has different shapes, this is the broken heart  . Of course it is not very clear for color blindness,

[GitHub] [hadoop] steveloughran commented on issue #1527: HADOOP-16610. Upgrade to yetus 0.11.0 and use emoji vote on github pre…

2019-09-26 Thread GitBox
steveloughran commented on issue #1527: HADOOP-16610. Upgrade to yetus 0.11.0 and use emoji vote on github pre… URL: https://github.com/apache/hadoop/pull/1527#issuecomment-535510770 ok, go for it as is and then we can go with the later changes +1

[jira] [Commented] (HADOOP-16600) StagingTestBase uses methods not available in Mockito 1.8.5 in branch-3.1

2019-09-26 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16938839#comment-16938839 ] Steve Loughran commented on HADOOP-16600: - -I just did a check out and build of branch-3.1 and

[GitHub] [hadoop] vivekratnavel commented on a change in pull request #1528: HDDS-2181. Ozone Manager should send correct ACL type in ACL requests…

2019-09-26 Thread GitBox
vivekratnavel commented on a change in pull request #1528: HDDS-2181. Ozone Manager should send correct ACL type in ACL requests… URL: https://github.com/apache/hadoop/pull/1528#discussion_r328797836 ## File path:

[GitHub] [hadoop] xiaoyuyao commented on a change in pull request #1528: HDDS-2181. Ozone Manager should send correct ACL type in ACL requests…

2019-09-26 Thread GitBox
xiaoyuyao commented on a change in pull request #1528: HDDS-2181. Ozone Manager should send correct ACL type in ACL requests… URL: https://github.com/apache/hadoop/pull/1528#discussion_r328755891 ## File path:

[GitHub] [hadoop] ashvina commented on a change in pull request #1478: HDFS-14856 Fetch file ACLs while mounting external store

2019-09-26 Thread GitBox
ashvina commented on a change in pull request #1478: HDFS-14856 Fetch file ACLs while mounting external store URL: https://github.com/apache/hadoop/pull/1478#discussion_r328767391 ## File path:

[GitHub] [hadoop] vivekratnavel commented on a change in pull request #1528: HDDS-2181. Ozone Manager should send correct ACL type in ACL requests…

2019-09-26 Thread GitBox
vivekratnavel commented on a change in pull request #1528: HDDS-2181. Ozone Manager should send correct ACL type in ACL requests… URL: https://github.com/apache/hadoop/pull/1528#discussion_r328781094 ## File path:

[jira] [Assigned] (HADOOP-16489) S3Guard operations log has tombstone/PUT swapped

2019-09-26 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran reassigned HADOOP-16489: --- Assignee: Steve Loughran > S3Guard operations log has tombstone/PUT swapped >

[GitHub] [hadoop] steveloughran commented on issue #1442: HADOOP-16570. S3A committers encounter scale issues

2019-09-26 Thread GitBox
steveloughran commented on issue #1442: HADOOP-16570. S3A committers encounter scale issues URL: https://github.com/apache/hadoop/pull/1442#issuecomment-535658748 latest test run -s3 ireland. There's a new unit test which with the current values takes 1 min; plan to cut the numbers back,

[GitHub] [hadoop] anuengineer edited a comment on issue #1526: HDDS-2180. Add Object ID and update ID on VolumeList Object.

2019-09-26 Thread GitBox
anuengineer edited a comment on issue #1526: HDDS-2180. Add Object ID and update ID on VolumeList Object. URL: https://github.com/apache/hadoop/pull/1526#issuecomment-535675877 > Was this committed without a pre-commit run from Anzix? Looks like it was not run. I did look at the

[GitHub] [hadoop] anuengineer commented on issue #1526: HDDS-2180. Add Object ID and update ID on VolumeList Object.

2019-09-26 Thread GitBox
anuengineer commented on issue #1526: HDDS-2180. Add Object ID and update ID on VolumeList Object. URL: https://github.com/apache/hadoop/pull/1526#issuecomment-535675877 > Was this committed without a pre-commit run from Anzix? Looks like it was not run. I did look at the yetus

[GitHub] [hadoop] xiaoyuyao commented on a change in pull request #1528: HDDS-2181. Ozone Manager should send correct ACL type in ACL requests…

2019-09-26 Thread GitBox
xiaoyuyao commented on a change in pull request #1528: HDDS-2181. Ozone Manager should send correct ACL type in ACL requests… URL: https://github.com/apache/hadoop/pull/1528#discussion_r328740746 ## File path:

[jira] [Assigned] (HADOOP-15672) add s3guard CLI command to generate session keys for an assumed role

2019-09-26 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-15672?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran reassigned HADOOP-15672: --- Assignee: Steve Loughran > add s3guard CLI command to generate session keys for

[jira] [Resolved] (HADOOP-16489) S3Guard operations log has tombstone/PUT swapped

2019-09-26 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran resolved HADOOP-16489. - Fix Version/s: 3.3.0 Resolution: Duplicate fixed this in HADOOP-16430 >

[GitHub] [hadoop] hadoop-yetus commented on issue #1442: HADOOP-16570. S3A committers encounter scale issues

2019-09-26 Thread GitBox
hadoop-yetus commented on issue #1442: HADOOP-16570. S3A committers encounter scale issues URL: https://github.com/apache/hadoop/pull/1442#issuecomment-535653705 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hadoop] arp7 commented on issue #1511: HDDS-2162. Make Kerberos related configuration support HA style config.

2019-09-26 Thread GitBox
arp7 commented on issue #1511: HDDS-2162. Make Kerberos related configuration support HA style config. URL: https://github.com/apache/hadoop/pull/1511#issuecomment-535626926 /retest This is an automated message from the

[GitHub] [hadoop] hadoop-yetus commented on issue #1497: HDDS-2001. Update Ratis version to 0.4.0.

2019-09-26 Thread GitBox
hadoop-yetus commented on issue #1497: HDDS-2001. Update Ratis version to 0.4.0. URL: https://github.com/apache/hadoop/pull/1497#issuecomment-535646732 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #1528: HDDS-2181. Ozone Manager should send correct ACL type in ACL requests…

2019-09-26 Thread GitBox
bharatviswa504 commented on a change in pull request #1528: HDDS-2181. Ozone Manager should send correct ACL type in ACL requests… URL: https://github.com/apache/hadoop/pull/1528#discussion_r328782110 ## File path:

[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #1528: HDDS-2181. Ozone Manager should send correct ACL type in ACL requests…

2019-09-26 Thread GitBox
bharatviswa504 commented on a change in pull request #1528: HDDS-2181. Ozone Manager should send correct ACL type in ACL requests… URL: https://github.com/apache/hadoop/pull/1528#discussion_r328781990 ## File path:

[jira] [Resolved] (HADOOP-15672) add s3guard CLI command to generate session keys for an assumed role

2019-09-26 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-15672?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran resolved HADOOP-15672. - Fix Version/s: 3.3.0 Resolution: Duplicate > add s3guard CLI command to

[GitHub] [hadoop] hadoop-yetus commented on issue #1519: HDDS-2174. Delete GDPR Encryption Key from metadata when a Key is deleted

2019-09-26 Thread GitBox
hadoop-yetus commented on issue #1519: HDDS-2174. Delete GDPR Encryption Key from metadata when a Key is deleted URL: https://github.com/apache/hadoop/pull/1519#issuecomment-535671164 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hadoop] xiaoyuyao commented on a change in pull request #1528: HDDS-2181. Ozone Manager should send correct ACL type in ACL requests…

2019-09-26 Thread GitBox
xiaoyuyao commented on a change in pull request #1528: HDDS-2181. Ozone Manager should send correct ACL type in ACL requests… URL: https://github.com/apache/hadoop/pull/1528#discussion_r328754590 ## File path:

[GitHub] [hadoop] xiaoyuyao commented on a change in pull request #1528: HDDS-2181. Ozone Manager should send correct ACL type in ACL requests…

2019-09-26 Thread GitBox
xiaoyuyao commented on a change in pull request #1528: HDDS-2181. Ozone Manager should send correct ACL type in ACL requests… URL: https://github.com/apache/hadoop/pull/1528#discussion_r328756703 ## File path:

[GitHub] [hadoop] xiaoyuyao commented on a change in pull request #1505: HDDS-2166. Some RPC metrics are missing from SCM prometheus endpoint

2019-09-26 Thread GitBox
xiaoyuyao commented on a change in pull request #1505: HDDS-2166. Some RPC metrics are missing from SCM prometheus endpoint URL: https://github.com/apache/hadoop/pull/1505#discussion_r328759936 ## File path:

[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #1528: HDDS-2181. Ozone Manager should send correct ACL type in ACL requests…

2019-09-26 Thread GitBox
bharatviswa504 commented on a change in pull request #1528: HDDS-2181. Ozone Manager should send correct ACL type in ACL requests… URL: https://github.com/apache/hadoop/pull/1528#discussion_r328781404 ## File path:

[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #1528: HDDS-2181. Ozone Manager should send correct ACL type in ACL requests…

2019-09-26 Thread GitBox
bharatviswa504 commented on a change in pull request #1528: HDDS-2181. Ozone Manager should send correct ACL type in ACL requests… URL: https://github.com/apache/hadoop/pull/1528#discussion_r328781534 ## File path:

[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #1528: HDDS-2181. Ozone Manager should send correct ACL type in ACL requests…

2019-09-26 Thread GitBox
bharatviswa504 commented on a change in pull request #1528: HDDS-2181. Ozone Manager should send correct ACL type in ACL requests… URL: https://github.com/apache/hadoop/pull/1528#discussion_r328781534 ## File path:

[GitHub] [hadoop] vivekratnavel commented on a change in pull request #1528: HDDS-2181. Ozone Manager should send correct ACL type in ACL requests…

2019-09-26 Thread GitBox
vivekratnavel commented on a change in pull request #1528: HDDS-2181. Ozone Manager should send correct ACL type in ACL requests… URL: https://github.com/apache/hadoop/pull/1528#discussion_r328781882 ## File path:

[GitHub] [hadoop] arp7 commented on issue #1526: HDDS-2180. Add Object ID and update ID on VolumeList Object.

2019-09-26 Thread GitBox
arp7 commented on issue #1526: HDDS-2180. Add Object ID and update ID on VolumeList Object. URL: https://github.com/apache/hadoop/pull/1526#issuecomment-535617334 Was this committed without a pre-commit run from Anzix? This

[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #1528: HDDS-2181. Ozone Manager should send correct ACL type in ACL requests…

2019-09-26 Thread GitBox
bharatviswa504 commented on a change in pull request #1528: HDDS-2181. Ozone Manager should send correct ACL type in ACL requests… URL: https://github.com/apache/hadoop/pull/1528#discussion_r328782828 ## File path:

[jira] [Commented] (HADOOP-15672) add s3guard CLI command to generate session keys for an assumed role

2019-09-26 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-15672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16938905#comment-16938905 ] Steve Loughran commented on HADOOP-15672: - I don't think we need this any more. I have

[jira] [Commented] (HADOOP-16520) race condition in DDB table init and waiting threads

2019-09-26 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-16520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16938914#comment-16938914 ] Steve Loughran commented on HADOOP-16520: - see also HADOOP-16349 > race condition in DDB table

  1   2   >