Re: [12] RFR JDK-8211266: [TESTBUG] jdk/nio/zipfs/ZipFSTester.java failed intermittently in ZipFSTester.checkRead()

2018-11-21 Thread Lance Andersen
nt(8192)] >> >> ZipFSTester::checkRead need to take this into account. >> >> Thanks, >> Amy >> >> > <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>

Re: RFR (JDK 12/java.xml) 8210722: JAXP Tests: CatalogSupport2 and CatalogSupport3 generate incorrect messages upon failure

2018-11-19 Thread Lance Andersen
https://bugs.openjdk.java.net/browse/JDK-8210720 > > Thanks, > Joe > <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.c

Re: RFR: XXXS: JDK-8213913: Redundant HTML in java.se/module-info.java

2018-11-14 Thread Lance Andersen
oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>

Re: RFR: XXS: JDK-8213910: Invalid HTML in java.net.http.HttpClient

2018-11-14 Thread Lance Andersen
r > > > JBS: https://bugs.openjdk.java.net/browse/JDK-8213910 > > -- Jon > <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <ht

Re: RFR 8212876: ftp: links for character-sets require a login password

2018-11-05 Thread Lance Andersen
sign/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>

Re: RFR 8212872: Broken link to http://www.w3.org/XML/xml-names-19990114-errata

2018-11-05 Thread Lance Andersen
/oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>

Re: [12] RFR: 8213330: Fix legal headers in i18n tests

2018-11-03 Thread Lance Andersen
mail-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>

Re: 8213321: Fix legal headers in test/jaxp

2018-11-02 Thread Lance Andersen
+1 -- Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com Sent from my iPhone > On Nov 2, 2018, at 3:13 PM, Joe Wang wrote: > > Hi, > > Please review:

Re: [12] RFR: 8213046: Define Japanese new Era character

2018-11-01 Thread Lance Andersen
ship it :-) > On Nov 1, 2018, at 4:51 PM, Naoto Sato wrote: > > Indeed. Added the period. > > http://cr.openjdk.java.net/~naoto/8213046/webrev.02/ > > Naoto > > On 11/1/18 1:03 PM, Lance Andersen wrote: >> Looks better. Unless it is my eyes, the period see

Re: [12] RFR: 8213046: Define Japanese new Era character

2018-11-01 Thread Lance Andersen
gt; Naoto > > On 11/1/18 11:31 AM, Naoto Sato wrote: >> Hi Lance, >> On 11/1/18 11:26 AM, Lance Andersen wrote: >>> Hi Naoto >>> >>> + * The code point, U+32FF, is reserved by the Unicode Consortium >>> + * to represent the Japanese square characte

Re: [12] RFR: 8213046: Define Japanese new Era character

2018-11-01 Thread Lance Andersen
acle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>

Re: RFR(JDK12/java.xml) 8212871: Broken links give 401-Unauthorized

2018-11-01 Thread Lance Andersen
emporary URL > Fixed now in the webrev: > webrev: http://cr.openjdk.java.net/~joehw/jdk12/8212871/webrev/ > <http://cr.openjdk.java.net/~joehw/jdk12/8212871/webrev/> > > Thanks, > Joe > > On 10/31/18, 5:14 PM, Lance Andersen wrote: >> >> BTW >> >&g

Re: RFR(JDK12/java.xml) 8212871: Broken links give 401-Unauthorized

2018-10-31 Thread Lance Andersen
the Document Object Model (DOM) Level 3 XPath Specification. */ > On Oct 31, 2018, at 8:09 PM, Lance Andersen wrote: > > Hi Joe, > > I see the update as > > https://www.w3.org/TR/DOM-Level-3-XPath/ > and > > https://www.w3.org/TR/2004/NOTE-DOM-Level-3-XPat

Re: RFR(JDK12/java.xml) 8212871: Broken links give 401-Unauthorized

2018-10-31 Thread Lance Andersen
openjdk.java.net/~joehw/jdk12/8212871/webrev/ > > Thanks, > Joe > <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/

Re: RFR(JDK 12/java.xml) 8212866: Broken link to schematron.com

2018-10-26 Thread Lance Andersen
coming an ISO standard. > + * Schematron is href="http://standards.iso.org/ittf/PubliclyAvailableStandards/index.html;>an > ISO standard. > * > * > * > > > Thanks, > Joe > > > <http://oracle.com/us/design/oracle-email-sig-198324.gif> <h

Re: RFR 8212129: Remove finalize methods from java.util.zip.ZipFIle/Inflator/Deflator

2018-10-25 Thread Lance Andersen
> On Oct 25, 2018, at 9:32 AM, Alan Bateman wrote: > > > > On 24/10/2018 18:19, Lance Andersen wrote: >> Hi all, >> >> This change removes the finalize methods from >> java.util.zip.ZipFIle/Inflator/Deflator. These methods were deprecat

Re: Review Request JDK-8212948: Remove unused jdk.internal.misc.VMNotification interface

2018-10-24 Thread Lance Andersen
e the same if we are just releasing > -// suspended threads. > -void newAllocState(int oldState, int newState, > - boolean threadsSuspended); > -} > <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324

Re: JDK 12 RFR of JDK-8212880: Cannot access ftp: site for fdlibm.tar

2018-10-24 Thread Lance Andersen
Thanks, > > -Joe > <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance An

RFR 8212129: Remove finalize methods from java.util.zip.ZipFIle/Inflator/Deflator

2018-10-24 Thread Lance Andersen
/oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>

Re: RFR[S]: JDK-8211876,,Broken links in java.base files (ClassLoader.html#name)

2018-10-22 Thread Lance Andersen
of the method represented by this stack frame. * * @return the binary > name of the declaring class of the method | > > ​ <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/or

Re: [PATCH] Fix typo in javadoc for java.lang.ref.Cleaner

2018-10-18 Thread Lance Andersen
Andrew, I can sponsor your change > On Oct 17, 2018, at 5:18 PM, Lance Andersen wrote: > > +1 >> On Oct 17, 2018, at 4:50 PM, Andrew Luo > <mailto:andrewluotechnolog...@outlook.com>> wrote: >> >> Done as well, thanks for spotting that also. >> >

Re: [PATCH] Fix typo in javadoc for java.lang.ref.Cleaner

2018-10-17 Thread Lance Andersen
te final State state; > + *private final Cleaner.Cleanable cleanable; > * > *public CleaningExample() { > *this.state = new State(...); > > Thanks, > > -Andrew > > From: Lance Andersen <mailto:lance.ander...@oracle.com>> &g

Re: [PATCH] Fix typo in javadoc for java.lang.ref.Cleaner

2018-10-17 Thread Lance Andersen
-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.203

Re: RFR 8211922: Remove test/jdk/javax/naming/module/RunBasic.java from the ProblemList

2018-10-11 Thread Lance Andersen
e-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>

RFR 8212045: Add back tests removed from HashesTest.java and AddExportsTest.java

2018-10-11 Thread Lance Andersen
ports", "java.compiler/javax.tools.internal=m2", "--upgrade-module-path", UPGRADE_MODS_DIRS.toString(), "--module-path", MODS_DIR.toString(), "-m", mid) ljanders-mac:open ljanders$ The mach 5 jdk tier1, tier2, and tier3 tests ran without error Best Lance <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>

Re: RFR: JDK-8211952: Broken links in java.time API

2018-10-09 Thread Lance Andersen
com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>

Re: RFR JDK-8211880,Broken links in java.util.jar

2018-10-09 Thread Lance Andersen
; Sherman <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principa

Re: RFR [12] 8211863: Problem list test/jdk/javax/naming/module/RunBasic.java

2018-10-08 Thread Lance Andersen
//oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>

RFR: 8211765 - JarFile constructor throws undocumented exception

2018-10-06 Thread Lance Andersen
oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>

Re: RFR JDK-8211728,JarFile::versionedStream() does not filter META-INF resources in versioned stream

2018-10-05 Thread Lance Andersen
<http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Tec

Re: RFR JDK-8211385: (zipfs) ZipDirectoryStream yields a stream of absolute paths when directory is relative

2018-10-02 Thread Lance Andersen
gt; > > Thanks, > Sherman <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324

Re: RFR (XS) 8200381 : Typos in javadoc - missing verb "be" and alike

2018-10-01 Thread Lance Andersen
s/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>

Re: RFR 8211295: DriverManager.getConnection fails when called from com.sun.rowset.JdbcRowSetImpl

2018-10-01 Thread Lance Andersen
> On Oct 1, 2018, at 1:09 PM, Mandy Chung wrote: > > > > On 9/29/18 1:59 PM, Lance Andersen wrote: >> Attached is the webrev for the JDBC RowSet/DriverManager issue, >> https://bugs.openjdk.java.net/browse/JDK-8211295 >> <https://bugs.openjdk.java.net/b

Re: How can I solve Modularity related issue ?

2018-10-01 Thread Lance Andersen
oes look like related to the de-privileging of java.sql.rowset >> module. JDBC rowset implementation just happened to work in the past >> as it was defined to the bootstrap class loader. >> I have created JBS issue for this: >>https://bugs.openjdk.java.net/browse/J

RFR 8211295: DriverManager.getConnection fails when called from com.sun.rowset.JdbcRowSetImpl

2018-09-29 Thread Lance Andersen
.java.net/~lancea/8211295/webrev.00/> Best Lance <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-1983

Re: RFR: JDK-8211121: Remove sun.reflect.ReflectionFactory::newInstanceForSerialization

2018-09-26 Thread Lance Andersen
tNoData} method on * a Serializable class. * The first argument of {@link MethodHandle#invoke} is the serializable — Local build went fine. Mach5 is running again for an additional sanity check Best Lance > > Otherwise looks fine. > > Mandy > > On 9/25/18 4:10 PM, Lance Ande

RFR: JDK-8211121: Remove sun.reflect.ReflectionFactory::newInstanceForSerialization

2018-09-25 Thread Lance Andersen
<http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>

Re: RFR(JDK12/JAXP/java.xml) 8210874: Test for JDK-8209615

2018-09-18 Thread Lance Andersen
ig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>

Re: Review Request JDK-8210721: Replace legacy serial exception field with Throwable::cause

2018-09-13 Thread Lance Andersen
evs/8210721/webrev.00/ > > Mandy > [1] > http://mail.openjdk.java.net/pipermail/core-libs-dev/2018-August/054878.html <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/

Re: RFR(JDK12/JAXP/java.xml) 8207760: SAXException: Invalid UTF-16 surrogate detected: d83c ?

2018-09-12 Thread Lance Andersen
lt;http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>

Re: RFR(JDK12/JAXP/java.xml) 8209873: Typo in javax.xml.validation.Validator.validate​ documentation

2018-08-23 Thread Lance Andersen
ion > > > JBS: https://bugs.openjdk.java.net/browse/JDK-8209873 > > Thanks, > Joe > <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif

Re: RFR(JDK12/JAXP/java.xml) 8209615: ParseError in XMLEventReader on a valid input

2018-08-21 Thread Lance Andersen
email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.4

Re: JDK 12 RFR of 8176425: Add radix indication in NumberFormatException message for Integer.decode

2018-08-15 Thread Lance Andersen
Looks good Joe On Aug 14, 2018, at 11:20 PM, joe darcy wrote: > http://cr.openjdk.java.net/~darcy/8176425.0/ Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com

Re: JDK 12 RFR of 5075463 : (enum) Serialized Form javadoc for java.lang.Enum is misleading

2018-08-15 Thread Lance Andersen
Hi Joe, Added myself as a reviewer to the CSR and the change looks fine On Aug 14, 2018, at 11:59 PM, joe darcy wrote: > https://bugs.openjdk.java.net/browse/JDK-8209524 Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Dr

Re: RFR (XXS) 8201394: Update java.se module summary to reflect removal of java.se.ee module

2018-08-07 Thread Lance Andersen
Thanks, > iris <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Pri

Re: JDK 12 RFR of JDK-8209024: Use SuppressWarnings on serialVersionUID fields in interfaces

2018-08-06 Thread Lance Andersen
; > /** indicate compatibility with JDK 1.1.x version of class. */ > +@SuppressWarnings("serial") // serialVersionUID in an interface is > ineffectual > static final long serialVersionUID = 3632638527362204081L; > > /** > --- old/src/java.rmi/share/classes/java/rmi/server/ServerRef.java 2018-08-06 > 12:04:54.494000999 -0700 > +++ new/src/java.rmi/share/classes/java/rmi/server/ServerRef.java 2018-08-06 > 12:04:54.338000999 -0700 > @@ -39,6 +39,7 @@ > public interface ServerRef extends RemoteRef { > > /** indicate compatibility with JDK 1.1.x version of class. */ > +@SuppressWarnings("serial") // serialVersionUID in an interface is > ineffectual > static final long serialVersionUID = -4557750989390278438L; > > /** > > > <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>

Re: JDK 12 RFR of JDK-8208782: Remove extra type in throws clause of SerialClob.writeObject

2018-08-03 Thread Lance Andersen
/oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>

Re: [12] RFR 8208363: test/jdk/java/lang/Package/PackageFromManifest.java missing module dependencies declaration

2018-07-27 Thread Lance Andersen
acle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>

Re: RFR: 8208157: requires.VMProps throws NPE for missing properties in "release" file

2018-07-24 Thread Lance Andersen
ementorProperty.replace("\"", ""); > } catch (IOException e) { > e.printStackTrace(); > } > > > Thank you. > > Shura <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracl

Re: JDK 12 RFR of JDK-8208060: Additional corrections of serial-related declarations

2018-07-20 Thread Lance Andersen
teObject method doesn't throw ClassNotFoundException. > > Thanks, <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/des

Re: JDK 12 RFR of JDK-8207751: Remove misleading serialVersionUID from JulienFields.Field

2018-07-17 Thread Lance Andersen
Hi Joe > On Jul 17, 2018, at 7:32 PM, Joseph D. Darcy wrote: > > Hi Lance, > > On 7/17/2018 4:25 PM, Lance Andersen wrote: >> Hi Joe, >> >> +1 >> >> I assume we do not need to add a specific test for this clean-up? > > I put a &qu

Re: JDK 12 RFR of JDK-8207751: Remove misleading serialVersionUID from JulienFields.Field

2018-07-17 Thread Lance Andersen
TemporalUnit baseUnit; > private final transient TemporalUnit rangeUnit; > <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracl

Re: 8207393: ServiceLoader class description improvements

2018-07-17 Thread Lance Andersen
used to locate and instantiate providers of > the > * service by means of the {@link #iterator() iterator} method. {@code > ServiceLoader} > <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://o

Re: RFR 8205610: [TESTLIB] Improve listing of open file descriptors

2018-07-17 Thread Lance Andersen
mail-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>

Re: RFR 8189717: Too much documentation of ProcessBuilder.start copied to ProcessBuilder.startPipeline

2018-07-13 Thread Lance Andersen
Hi Roger, +1 Have a great weekend! Best Lance > On Jul 13, 2018, at 4:38 PM, Roger Riggs wrote: > > Hi Lance, > > Updated in place with your suggestion. > http://cr.openjdk.java.net/~rriggs/webrev-process-8189717/ > > Thanks, Roger > > On 7/13/2018 4:31 P

Re: RFR 8189717: Too much documentation of ProcessBuilder.start copied to ProcessBuilder.startPipeline

2018-07-13 Thread Lance Andersen
to the above > Roger > > > On 7/13/2018 3:26 PM, Lance Andersen wrote: >> Hi Roger, >> >> I am struggling with the wording at: >> >> ——— >> * Subsequent modifications to any of process builders in the {@code builders} >> 1198 * argu

Re: RFR 8189717: Too much documentation of ProcessBuilder.start copied to ProcessBuilder.startPipeline

2018-07-13 Thread Lance Andersen
oger > <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member

Re: RFR(JDK12/JAXP/java.xml) 8194680: StartElement#getAttributes and getNamespaces refer to incorrect package

2018-07-11 Thread Lance Andersen
;> -- Jon <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>

Re: RFR: 8206495 [testbug] Redundant System.setProperty(null) tests

2018-07-06 Thread Lance Andersen
cle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff |

Re: RFR(JDK12/JAXP/java.xml) 8206164: forgot to "throw" TransformerConfigurationException

2018-07-05 Thread Lance Andersen
t;http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>

Re: RFR(JDK12/JAXP/java.xml) 8204329: Java API doc for XMLStreamReader.next() needs to be clarified for the exception thrown when hasNext() method returns false

2018-07-02 Thread Lance Andersen
ttp://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>

Re: RFR(JDK12/JAXP/java.xml) 8190835: Subtraction with two javax.xml.datatype.Duration gives incorrect result

2018-06-28 Thread Lance Andersen
ks, > Joe <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principa

Re: RFR(JDK11/NIO) 8205058 throw CharacterCodingException --> Re: RFR (JDK11/NIO) 8201276: (fs) Add methods to Files for reading/writing a string from/to a file

2018-06-26 Thread Lance Andersen
ate tests to check for UnmappedCharacterException and >> MalformedInputException look good. > > Thanks, > Joe > >> >> -Alan <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://o

Re: RFR(xs): JDK-8201610: fix broken link in UnicastRemoteObject

2018-06-25 Thread Lance Andersen
ass loader of the remote object's class. <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>

Re: JDK 11 RFR of JDK-8205003: Replace selected link tags with linkplain in java.lang.Class

2018-06-13 Thread Lance Andersen
+1 -- Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com Sent from my iPhone > On Jun 13, 2018, at 8:51 PM, joe darcy wrote: > > Hello, > > Please review the sm

Re: RFR: 8201608 fix broken links in javax/sql/rowset/package.html and javax/sql/rowset/spi/package.html

2018-06-06 Thread Lance Andersen
en forgot it would be stripped by the mail server so I attached it to the bug per Paul’s suggestion. > The changes are fine by me. Thank you Best Lance > > Roger > > > On 6/6/18 10:56 AM, Lance Andersen wrote: >> Hi Roger >>> On Jun 5, 2018, at 5:54 PM, Ro

Re: RFR: 8201608 fix broken links in javax/sql/rowset/package.html and javax/sql/rowset/spi/package.html

2018-06-06 Thread Lance Andersen
le you are there, how about converting to {@code...} etc. I do plan to do this, but thought I would keep things minimal for this updateand do that in a follow-on due to the renaming so it is easier to follow in the webrev. Best Lance > > Thanks, Roger > > > On 6/4/18

Re: RFR JDK-8066709 Make some JDK system properties read only

2018-06-04 Thread Lance Andersen
6/4/2018 12:09 PM, Lance Andersen wrote: >> Hi Roger, >> >> Overall, it looks very good. >> >> A couple of quick thoughts, nothing that needs any action unless you feel >> the desire :-) >> >> Line 671 in System.java, it mentions ‘standard’ sy

Re: RFR: 8201608 fix broken links in javax/sql/rowset/package.html and javax/sql/rowset/spi/package.html

2018-06-04 Thread Lance Andersen
> On Jun 4, 2018, at 2:51 PM, Paul Sandoz wrote: > > > >> On Jun 4, 2018, at 4:22 AM, Lance Andersen wrote: >> >> Hi, >> >> Bug 8201608 highlights a few broken links in javax/sql/rowset/package.html >> and javax/sql/rowset/spi/package.htm

Re: RFR JDK-8066709 Make some JDK system properties read only

2018-06-04 Thread Lance Andersen
http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical St

RFR: 8201608 fix broken links in javax/sql/rowset/package.html and javax/sql/rowset/spi/package.html

2018-06-04 Thread Lance Andersen
mail-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 0

Re: RFR(s): 8204243: remove Thread.destroy() and Thread.stop(Throwable)

2018-06-01 Thread Lance Andersen
Deprecator <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal M

Re: RFR: JDK-8190417 java.util.regex.Matcher method doc points to incorrect links

2018-05-31 Thread Lance Andersen
ebrev.01/ > <http://cr.openjdk.java.net/~mvala/jdk/jdk/JDK-8190417/webrev.01/> > > > On 05/31/2018 12:45 PM, Lance Andersen wrote: >> Hi Michal, >> Any additional changes we can use this bug. >> If you have made additional changes, please point me to your latest

Re: RFR: JDK-8190417 java.util.regex.Matcher method doc points to incorrect links

2018-05-31 Thread Lance Andersen
ind} methods. >> should be >> + * {@link #find() find} methods. >> Of course now I can't find those rules! The javadoc guide [1] doesn't seem >> to include or refer to a tag reference! >> Cheers, >> David >> [1] https://docs.oracle.com/javase/10/javadoc/t

Re: RFR: JDK-8190417 java.util.regex.Matcher method doc points to incorrect links

2018-05-30 Thread Lance Andersen
r at index i. * * @return A char from the specified index */ - > On May 30, 2018, at 11:10 AM, Michal Vala wrote: > > Hi Lance, > > thanks, I'd appreciate that > > On 05/30/2018 04:32 PM, Lance Andersen wrote: >> I can spo

Re: RFR: JDK-8190417 java.util.regex.Matcher method doc points to incorrect links

2018-05-30 Thread Lance Andersen
7/webrev.00/ > > Thanks! > > -- > Michal Vala > OpenJDK QE > Red Hat Czech <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http

Re: RFR: 8193154: methods in java.time's TCKZoneRules OpenJDK test miss @Test annotation

2018-05-27 Thread Lance Andersen
> having the annotation at the method level affects correct processing of > TCKZoneRules and inclusion of test methods into master test list where this > test has been ported to. So, I am assuming this would still help. But for > that, I agree with you that this may not be needed. > &

Re: RFR: 8193154: methods in java.time's TCKZoneRules OpenJDK test miss @Test annotation

2018-05-26 Thread Lance Andersen
e.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>

Re: RFR JDK-8200172,String.split non-positive term incorrect use

2018-05-22 Thread Lance Andersen
lt;http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>

Re: RFR (S): 8203500: Fix broken links to Specification in "specs" directory

2018-05-21 Thread Lance Andersen
esign/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>

Re: RFR (JDK11/JAXP/java.xml) 8198548: Initialization race in com.sun.org.apache.xerces.internal.impl.xpath.regex.Token.getRange() on Token.categories

2018-05-18 Thread Lance Andersen
mail-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Orac

Re: RFR(JDK11/JAXP/java.xml) 8202426: NPE thrown by Transformer when XMLStreamReader reports no xml attribute type

2018-05-15 Thread Lance Andersen
-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle J

Re: RFR (JDK11/java.xml) 8201138: Defect in XMLEventReader.getElementText() may cause data to be skipped, duplicated or otherwise result in a ClassCastException

2018-05-03 Thread Lance Andersen
<http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>

Re: 8202507: Remove IO and NIO AtomicAppend tests from problem list

2018-05-01 Thread Lance Andersen
7158947 > solaris-all Solaris 11 <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-

Re: [11] RFR (XS): 8202484: Unused field in TimeZone

2018-05-01 Thread Lance Andersen
e-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>

Re: 8202062: Put FileChannel and FileOutpuStream variants of AtomicAppend on problem list

2018-04-24 Thread Lance Andersen
7158947 > solaris-all Solaris 11 > java/nio/file/WatchService/LotsOfCancels.java 8188039 > solaris-all Solaris 11 > <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>

Re: [jdk8u-dev] RFR: 8196491: Newlines in JAXB string values of SOAP-requests are escaped to ""

2018-04-20 Thread Lance Andersen
n/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>

Re: RFR 8201348, ProblemList update for bugid associated with SSLSocketParametersTest.sh

2018-04-10 Thread Lance Andersen
l-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>

Re: RFR 8200706: Better cleanup for open/test/jdk/java/lang/ProcessBuilder/DestroyTest.java

2018-04-06 Thread Lance Andersen
198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>

Re: RFR 8197595: Serialization javadoc should link to security best practices

2018-03-28 Thread Lance Andersen
; > > Thanks for the reviews, Roger > > On 3/23/2018 12:57 PM, Lance Andersen wrote: >> Looks good to me also Roger with Sean’s suggestions :-) >> >>> On Mar 23, 2018, at 10:12 AM, Roger Riggs <roger.ri...@oracle.com >>> <mailto:roger.

Re: RFR 8197595: Serialization javadoc should link to security best practices

2018-03-23 Thread Lance Andersen
us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>

Re: RFR (JDK11/doc-only) 8199176: Accessibility issues in java.base docs

2018-03-21 Thread Lance Andersen
> Thanks, > Joe > <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>

Re: RFR (JDK11/java.xml) 8199792: Wrong license header in XMLLimitAnalyzer.java

2018-03-20 Thread Lance Andersen
gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engi

Re: RFR 8198889 Clarify the throwing of exceptions from ConstantBootstraps.invoke

2018-03-13 Thread Lance Andersen
e invocation > */ > public static Object invoke(MethodHandles.Lookup lookup, String name, > Class type, > <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle

Re: [11] RFR: 8198989: Provide more diagnostic IAE messages

2018-03-12 Thread Lance Andersen
8324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>

Re: RFR 8199420 Update javadoc tags in java.lang.System and related

2018-03-09 Thread Lance Andersen
c/index.html > > Thanks, Roger > <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance A

Re: RFR 8199258: BigInteger.bitLength() should explicitly specify behavior when the value is zero

2018-03-07 Thread Lance Andersen
bit <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of T

Re: RFR: 8197538 Remove mention of hotjava paths in MimeTable.java

2018-03-05 Thread Lance Andersen
; } > > Thanks, Roger > > <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig

Re: RFR 8198931: remove java.xml.bind module dependency for com/sun/jndi tests

2018-03-04 Thread Lance Andersen
+1 -- Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com Sent from my iPhone > On Mar 4, 2018, at 8:26 PM, Chris Yin <xu.y@oracle.com> wrote: > > Please review th

Re: RFR JDK-8197533 move javax.transaction.xa into its own module

2018-03-01 Thread Lance Andersen
cea/8197533/webrev.03/> Best Lance > On Mar 1, 2018, at 12:37 PM, Paul Sandoz <paul.san...@oracle.com> wrote: > > +1 > >> On Mar 1, 2018, at 8:59 AM, Lance Andersen <lance.ander...@oracle.com >> <mailto:lance.ander...@oracle.com>> wrote: >>> &

<    5   6   7   8   9   10   11   12   13   14   >