RE: [11u] RFR: 7146776: deadlock between URLStreamHandler.getHostAddress and file.Handler.openconnection

Hi, Thanks for downporting this, looks good. Best regards, Goetz. From: Doerr, Martin Sent: Tuesday, January 19, 2021 6:44 PM To: core-libs-dev ; jdk-updates-...@openjdk.java.net Cc: Lindenmaier, Goetz ; Langer, Christoph Subject: [11u] RFR: 7146776: deadlock between

RE: [11u] RFR: 8241770 Module xxxAnnotation() methods throw NCDFE if module-info.class found as resource in unnamed module

-updates-...@openjdk.java.net Cc: Langer, Christoph ; Lindenmaier, Goetz Subject: [11u] RFR: 8241770 Module xxxAnnotation() methods throw NCDFE if module-info.class found as resource in unnamed module Hi, JDK-8248901 is backported to 11.0.11-oracle. I'd like to backport it for parity. Change

RE: [11u] RFR: 8235351: Lookup::unreflect should bind with the original caller independent of Method's accessible flag

; Lindenmaier, Goetz Subject: [11u] RFR: 8235351: Lookup::unreflect should bind with the original caller independent of Method's accessible flag Hi, JDK-8235351 is backported to 11.0.11-oracle. I'd like to backport it for parity. Change doesn't apply cleanly, because https://bugs.openjdk.java.net/browse

RE: Explicitly constructed NPE is showing (wrong) message

Hi, Thanks for reporting this issue. You analyzed it well, and the simple repro case was also helpful. I filed https://bugs.openjdk.java.net/browse/JDK-8248476 and will send RFR for this in a minute. It's probably best to continue discussion there. Best regards, Goetz. > -Original

Re: Explicitly constructed NPE is showing (wrong) message

The message from this sender included one or more files which could not be scanned for virus detection; do not open these files unless you are certain of the sender's intent. -- Hi, I‘ll have a look on Monday. Thanks for

RE: RFR (L, final): 8218626: Add detailed message to NullPointerException describing what is null.

nal Message- > From: mark.reinh...@oracle.com > Sent: Donnerstag, 3. Oktober 2019 00:41 > To: Lindenmaier, Goetz > Cc: hotspot-runtime-...@openjdk.java.net; core-libs-dev@openjdk.java.net > Subject: Re: RFR (L, final): 8218626: Add detailed message to > NullPointerException de

RE: RFR (L, final): 8218626: Add detailed message to NullPointerException describing what is null.

Hi Mark, thanks for looking at my change! Can I add you as reviewer? This webrev incorporates your patch as well as two fixes of issues that sneaked in implementing some recent reviews: bytecodeUtils.cpp:449 1 --> 1ULL bytecodeUtils.cpp:460 move assertion to where len is known.

RE: RFR (L, final): 8218626: Add detailed message to NullPointerException describing what is null.

Thanks, Ralf! Best regards, Goetz. > -Original Message- > From: Schmelter, Ralf > Sent: Dienstag, 1. Oktober 2019 10:11 > To: Lindenmaier, Goetz ; Hotspot dev runtime > ; Java Core Libs d...@openjdk.java.net> > Subject: RE: RFR (L, final): 8218626:

RE: RFR (L, final): 8218626: Add detailed message to NullPointerException describing what is null.

Hi Ralf, > The test should not omit these two bytecodes because the current > implementation is the same. This can change and it is not much additional code > to add the two cases. I implemented test cases for the missing invokes:

RE: JEP proposed to target JDK 14: 358: Helpful NullPointerExceptions

Hi Jon, Good catch, I fixed it. Thanks! Goetz. > -Original Message- > From: hotspot-runtime-dev boun...@openjdk.java.net> On Behalf Of Jonathan Gibbons > Sent: Thursday, September 26, 2019 12:41 AM > To: hotspot-runtime-...@openjdk.java.net runtime d...@openjdk.java.net>; OpenJDK

RE: RFR (L, final): 8218626: Add detailed message to NullPointerException describing what is null.

Thanks! Best regards, Goetz > -Original Message- > From: Roger Riggs > Sent: Dienstag, 24. September 2019 15:54 > To: Lindenmaier, Goetz ; Hotspot dev runtime > ; Java Core Libs d...@openjdk.java.net> > Subject: Re: RFR (L, final): 8218626:

RE: RFR (L, final): 8218626: Add detailed message to NullPointerException describing what is null.

; From: Roger Riggs > Sent: Montag, 23. September 2019 17:30 > To: Lindenmaier, Goetz ; Hotspot dev runtime > ; Java Core Libs d...@openjdk.java.net> > Subject: Re: RFR (L, final): 8218626: Add detailed message to > NullPointerException describing what is null. > > Hi Goe

RE: RFR (L, final): 8218626: Add detailed message to NullPointerException describing what is null.

Hi Remi, thanks for the heads up, I incorporated it in the main webrev: http://cr.openjdk.java.net/~goetz/wr19/8218628-exMsg-NPE/19/ Best regards, Goetz. > -Original Message- > From: fo...@univ-mlv.fr > Sent: Montag, 23. September 2019 18:02 > To: Lindenmaier, Goetz &

RE: RFR (L, final): 8218626: Add detailed message to NullPointerException describing what is null.

' after that any more. See the example in the test. Best regards, Goetz. > -Original Message- > From: fo...@univ-mlv.fr > Sent: Freitag, 20. September 2019 00:01 > To: Lindenmaier, Goetz > Cc: hotspot-runtime-dev ; core-libs- > dev > Subject: Re: RFR (L, final):

RE: RFR (L, final): 8218626: Add detailed message to NullPointerException describing what is null.

Hi Ralf, thanks for looking at this code and this thorough review! New webrevs: http://cr.openjdk.java.net/~goetz/wr19/8218628-exMsg-NPE/18/ http://cr.openjdk.java.net/~goetz/wr19/8218628-exMsg-NPE/18-incremental/ Find my comments inline: > In javaClasses.cpp: > > > #define

RE: RFR (L, final): 8218626: Add detailed message to NullPointerException describing what is null.

-dev" , > "core-libs-dev" > > Envoyé: Mardi 17 Septembre 2019 16:18:03 > > Objet: RE: RFR (L, final): 8218626: Add detailed message to > NullPointerException describing what is null. > > > @core-libs experts, I would appreciate comments on the changes > > to

RE: RFR (L, final): 8218626: Add detailed message to NullPointerException describing what is null.

@core-libs experts, I would appreciate comments on the changes to NullPointerException.java, especially wrt. the Javadoc comment. The change there is S. Best regards, Goetz. > -Original Message- > From: Lindenmaier, Goetz > Sent: Dienstag, 10. September 2019 11:48 > To:

RE: RFR (L, final): 8218626: Add detailed message to NullPointerException describing what is null.

/ http://cr.openjdk.java.net/~goetz/wr19/8218628-exMsg-NPE/17/ Best regards, Goetz. > -Original Message- > From: Thomas Stüfe > Sent: Dienstag, 17. September 2019 09:06 > To: Lindenmaier, Goetz > Cc: Hotspot dev runtime ; Java Core > Libs > Subject: Re: RFR (L,

RE: RFR (L, final): 8218626: Add detailed message to NullPointerException describing what is null.

Hi, the subject should mention 8218628. (Not 8218626). Sorry for this! Best regards, Goetz. From: Lindenmaier, Goetz Sent: Dienstag, 10. September 2019 11:48 To: 'Hotspot dev runtime' ; Java Core Libs Subject: RFR (L, final): 8218626: Add detailed message to NullPointerException describing

RFR (L, final): 8218626: Add detailed message to NullPointerException describing what is null.

Hi, this is the implementation of JEP 358: Helpful NullPointerExceptions. The JEP is in status "Candidate". Coleen (many, many thanks!) ran it through the Oracle-internal processes. Now I please need final reviews for this change so that I can propose it to target jdk 14. JEP:

RE: RFR(T): 8227252: [aix] Disable jdk/java/lang/reflect/exeCallerAccessTest

Hi Thomas, looks good. We did similar to other tests using the primordial thread before. Best regards, Goetz. > -Original Message- > From: core-libs-dev On Behalf Of > Thomas Stüfe > Sent: Donnerstag, 4. Juli 2019 11:14 > To: Java Core Libs ; ppc-aix-port-dev

RE: 8223869: Problem list java/awt/FontMetrics/MaxAdvanceIsMax.java on more platforms

Hi Alan, thanks for looking at this. > If the issue on these platforms is different JDK-8221305 then best to > create a new issue and use that to exclude the test (you can't used > JDK-8223869 as that is the issue you are using to add to the exclude > list). Ah, no I think it's the same issue.

8223869: Problem list java/awt/FontMetrics/MaxAdvanceIsMax.java on more platforms

Hi, I would like to problem list this test on ppc and s390. We see it failing, and it seems to be a Problem not related to the VM, see also the description in JDK-8221305 java/awt/FontMetrics/MaxAdvanceIsMax.java fails on MacOS + Solaris

RE: RFR(L): 8218628: Add detailed message to NullPointerException describing what is null.

Hi, here a webrev which uses 'cannot'. Nothing else changed. http://cr.openjdk.java.net/~goetz/wr19/8218628-exMsg-NPE/10-cannot/ Best regards, Goetz. > -Original Message- > From: Lindenmaier, Goetz > Sent: Donnerstag, 9. Mai 2019 08:55 > To: coleen.phillim...@oracle.co

RE: RFR(L): 8218628: Add detailed message to NullPointerException describing what is null.

Hi, > Cannot is apparently preferable in English. OK, changed. Best regards, Goetz. > -Original Message- > From: coleen.phillim...@oracle.com > Sent: Mittwoch, 8. Mai 2019 17:32 > To: Lindenmaier, Goetz ; Schmelter, Ralf > ; Java Core Libs ; > hotspot-runtime

RE: RFR(L): 8218628: Add detailed message to NullPointerException describing what is null.

Best regards, Goetz. > -Original Message- > From: Schmelter, Ralf > Sent: Dienstag, 7. Mai 2019 14:35 > To: Lindenmaier, Goetz ; Java Core Libs libs-...@openjdk.java.net>; hotspot-runtime-...@openjdk.java.net; Coleen > Phillimore (coleen.phillim...@oracle.com) > Sub

RE: RFR(L): 8218628: Add detailed message to NullPointerException describing what is null.

your help! Best regards, Goetz. > -Original Message----- > From: Lindenmaier, Goetz > Sent: Freitag, 12. April 2019 12:33 > To: Mandy Chung ; Roger Riggs > > Cc: Java Core Libs ; hotspot-runtime- > d...@openjdk.java.net > Subject: RE: RFR(L): 8218628: Add detaile

RFR: 8220715 JEP Draft: Add detailed message to NullPointerException describing what is null

lso feel free to fix the administrative information in the > Jira issue if it is wrong. > > And, naturally, you're welcome to discuss the topic! > > Best regards, > Goetz. > > > -Original Message- > > From: mark.reinh...@oracle.com > > Sent:

RE: RFR(L): 8218628: Add detailed message to NullPointerException describing what is null.

-Original Message- > From: Lindenmaier, Goetz > Sent: Donnerstag, 14. März 2019 21:56 > To: 'Mandy Chung' ; 'Roger Riggs' > > Cc: 'Java Core Libs' ; 'hotspot-runtime- > d...@openjdk.java.net' > Subject: RE: RFR(L): 8218628: Add detailed message to NullPointerException

RE: RFR(L): 8218628: Add detailed message to NullPointerException describing what is null.

not concerned about that. I'm currently looking at how to identify hidden frames... Best regards, Goetz. > -Original Message- > From: Maurizio Cimadamore > Sent: Freitag, 15. März 2019 12:33 > To: Lindenmaier, Goetz ; Mandy Chung > ; Roger Riggs > Cc: Java Core Libs

RE: RFR(L): 8218628: Add detailed message to NullPointerException describing what is null.

Hi Peter, > -Original Message- > From: Peter Levart > Sent: Freitag, 29. März 2019 16:44 > To: Lindenmaier, Goetz ; 'Mandy Chung' > > Cc: core-libs-dev@openjdk.java.net; maurizio.cimadam...@oracle.com; > hotspot-runtime-...@openjdk.java.net > Subject: Re: RFR(L

RE: RFR(L): 8218628: Add detailed message to NullPointerException describing what is null.

Hi Mandy, I could access the JBS now, so part 2 of my reply. Yesterday, I added tables to the JEP describing what is printed for which bytecode. If this is too verbose for the JEP, it might be nice in the bug implementing it. > > This is a design decision not to make the printout too complex.

RE: RFR(L): 8218628: Add detailed message to NullPointerException describing what is null.

Hi Mandy, The JBS is offline, so I'll just reply on this item for now: > > > Since the JEP quotes that NullPointerExceptions are thrown frequently > > > and swallowed, it would help if you can generate some numbers. > > > This JEP will help the discussion on the proposed feature and design and

RE: RFR(L): 8218628: Add detailed message to NullPointerException describing what is null.

Hi Mandy, >and also the cases when it requires to look at its caller > frame. > > Never. Only the method that was executed when the exception is > thrown is needed. I only mention the backtrace because it happens to > store the top method and the corresponding

RE: RFR(L): 8218628: Add detailed message to NullPointerException describing what is null.

Hi Mandy, thanks for reading the JEP and giving detailed feedback! > In the "Basic algorithm to compute the message" section: > > "This dataflow analysis walks the bytecodes forward simulating the execution > stack." > > Please elaborate it. Given a stack trace, it starts with the most

RE: RFR(S): 8172695: (scanner) java/util/Scanner/ScanTest.java fails

Hi, if it is only about parsing floats, why not use NumberFormat.getInstance().parse(value)? I did 8205108: [testbug] Fix pattern matching in jstatd tests. http://hg.openjdk.java.net/jdk-updates/jdk11u/rev/1637a4e50fc9?revcount=80 some while ago, because we had wrong float parsing on mac in our

RE: RFR(L): 8218628: Add detailed message to NullPointerException describing what is null.

status 'submitted'? Best regards, Goetz > > Mandy > > On 3/15/19 3:55 AM, Lindenmaier, Goetz wrote: > > Hi everybody, Mark, > > > > I followed your advice and created a JEP: > > https://bugs.openjdk.java.net/browse/JDK-8220715 > > > > Please poi

RE: RFR(L): 8218628: Add detailed message to NullPointerException describing what is null.

t; > bucket (and most users, really), this level of detail will simply be > > unacceptable (since now they have to understand the JVMS to parse the > > message :-)). > > > > I suggest we separate the use cases, at least for the purpose of the > > design discussion. > > >

RE: RFR(L): 8218628: Add detailed message to NullPointerException describing what is null.

? And why would information you don't need be unacceptable? You can just ignore it ... Best regards, Goetz. > I suggest we separate the use cases, at least for the purpose of the > design discussion. > > Maurizio > > On 15/03/2019 13:11, Lindenmaier, Goetz wrote: > > Hi Maurizio, &

RE: RFR(L): 8218628: Add detailed message to NullPointerException describing what is null.

. Good that you point this out, I'll add it to the JEP. Best regards, Goetz ... Sorry, I missed the "reply all" on my first reply. > -Original Message- > From: Maurizio Cimadamore > Sent: Freitag, 15. März 2019 12:33 > To: Lindenmaier, Goetz ; Mandy Chung >

RE: RFR(L): 8218628: Add detailed message to NullPointerException describing what is null.

, you're welcome to discuss the topic! Best regards, Goetz. > -Original Message- > From: mark.reinh...@oracle.com > Sent: Donnerstag, 14. März 2019 22:38 > To: maurizio.cimadam...@oracle.com; Lindenmaier, Goetz > > Cc: mandy.ch...@oracle.com; roger.ri...@oracle.c

RE: RFR(L): 8218628: Add detailed message to NullPointerException describing what is null.

Hi Maurizio, > > I second what Mandy says. > > First let me start by saying that this enhancement will be a great > addition to our platform; back in the days when I was teaching some Java > classes at the university, I was very aware of how hard it is to > diagnose a NPE for someone novel to

RE: RFR(L): 8218628: Add detailed message to NullPointerException describing what is null.

Hi Coleen, thanks for looking at my change.. > For the record, I think the C++ implementation is more straightforward > than trying to use the Stackwalker and ASM because there's other code > just like it right here. You have all the information you need directly > in the Throwable.backtrace

RE: RFR(L): 8218628: Add detailed message to NullPointerException describing what is null.

Hi, > Roger, Coleen, Maurizio and I talked about this proposed feature. > We all think that improving NPE message is a useful enhancement for > the platform and helps developers to tell what causes NPE. Thanks for this positive feedback :)! > This is not a small enhancement. Diving into a

RE: RFR(L): 8218628: Add detailed message to NullPointerException describing what is null.

include these your remarks: http://cr.openjdk.java.net/~goetz/wr19/8218628-exMsg-NPE/03-PeterLevart/ (updated in-place). Nevertheless, I think I will follow Roger's demand to not modify the defaultMessage field. Best regards, Goetz. > > > Regards, Peter > > On 2/14/19 5:35 P

RE: RFR(L): 8218628: Add detailed message to NullPointerException describing what is null.

Hi Andrew, > Ok. However, if you have the appropriate method bytecodes and the BCI at > which the exception occurred then I'm not sure why you would need ASM. I implemented it in C++ at first. I was asked to investigate an implementation in Java by the reviewers. Thanks! Goetz > Also, it

RE: RFR(L): 8218628: Add detailed message to NullPointerException describing what is null.

look some more into the reconstituter code... Thanks, Goetz. > -Original Message- > From: Andrew Dinn > Sent: Mittwoch, 20. Februar 2019 18:29 > To: Lindenmaier, Goetz > Cc: core-libs-dev ; hotspot-runtime- > d...@openjdk.java.net > Subject: Re: RFR(L): 8218628:

RE: RFR(L): 8218628: Add detailed message to NullPointerException describing what is null.

Hi Remi, > yes, it's a feature of ASM, offer the right abstraction to do bytecode > generation/transformation i.e. a stream of opcodes that are more abstract > than the real bytecode, so there is no way to get a direct access to the > bytecode at a specific BCI. For the generation of the NPE

RE: RFR(L): 8218628: Add detailed message to NullPointerException describing what is null.

advice? Best regards, Goetz. > -Original Message- > From: Peter Levart > Sent: Freitag, 15. Februar 2019 18:38 > To: Lindenmaier, Goetz ; Roger Riggs > ; Java Core Libs > Cc: hotspot-runtime-...@openjdk.java.net > Subject: Re: RFR(L): 8218628:

RE: RFR(L): 8218628: Add detailed message to NullPointerException describing what is null.

m static field AltFocusIssueTest.frame" and I figured it's the fact we run headless that makes the test fail without even looking at the code. Best regards, Goetz From: Roger Riggs Sent: Dienstag, 12. Februar 2019 17:03 To: Lindenmaier, Goetz ; Java Core Libs Cc: hotspot-runtime-...@o

RE: RFR(L): 8218628: Add detailed message to NullPointerException describing what is null.

__ > Von: core-libs-dev im Auftrag > von Roger Riggs > Gesendet: Dienstag, Februar 12, 2019 8:07 PM > An: Lindenmaier, Goetz; Java Core Libs > Cc: hotspot-runtime-...@openjdk.java.net > Betreff: Re: RFR(L): 8218628: Add detailed message to NullPointerException > describing what i

RE: RFR(L): 8218628: Add detailed message to NullPointerException describing what is null.

Hi Mandy, Thanks for supporting my intend of adding the message as such! I'll start implementing this in Java and come back with a webrev in a while. In parallel, I would like to continue discussing the other topics, e.g., the wording of the message. I will probably come up with a separate

RE: RFR(L): 8218628: Add detailed message to NullPointerException describing what is null.

avaClasses.cpp. Best regards, Goetz. > -Original Message- > From: Daniel Fuchs > Sent: Dienstag, 12. Februar 2019 14:55 > To: Lindenmaier, Goetz ; Roger Riggs > ; Java Core Libs > Cc: hotspot-runtime-...@openjdk.java.net > Subject: Re: RFR(L): 8218628: Add detailed me

RE: RFR(L): 8218628: Add detailed message to NullPointerException describing what is null.

Hi Roger, thanks for looking at my change! > A few higher level issues should be considered, though the details of > the webrev captured my immediate attention. > > Is this the right feature Yes!! > and is this the right level of implementation (C++/native)? See below. > From a security

RE: RFR(L): 8218628: Add detailed message to NullPointerException describing what is null.

019 13:31 > To: Lindenmaier, Goetz ; hotspot-runtime- > d...@openjdk.java.net; Java Core Libs > Subject: Re: RFR(L): 8218628: Add detailed message to NullPointerException > describing what is null. > > Hi Goetz, > > Just one follow up for now: > > > * Add pa

RE: RFR(L): 8218628: Add detailed message to NullPointerException describing what is null.

_SetDefaultMessage, to set a field in the Java object? Why isn't that > done in Java? Obviously, the problem is that the field is private. As Christoph points out, there are several ways to implement this. Please give advice: * reflection * shared secret * Add package visible "void set

RE: RFR(L): 8218628: Add detailed message to NullPointerException describing what is null.

ly, the problem is that the field is private. I see various ways to implement this. Please give advice: * reflection * shared secret * Add package visible "void setMessage (String msg)" to throwable. Best regards, Goetz. > > Best regards > Christoph > > > > -

RFR(L): 8218628: Add detailed message to NullPointerException describing what is null.

Hi, since Java 5, our internal VM reports verbose null pointer exception messages. I would like to contribute this feature to OpenJDK. With this change, messages as "java.lang.NullPointerException: while trying to load from a null int array loaded from local variable 'ia1'" are printed. For

RE: [RFR]: Per thread IO statistics in JFR

/rev/a181612f0715?revcount=40 Best regards, Goetz. > -Original Message- > From: Alan Bateman > Sent: Freitag, 1. Februar 2019 12:37 > To: Lindenmaier, Goetz > Cc: hotspot-jfr-...@openjdk.java.net; Java Core Libs d...@openjdk.java.net>; Hotspot dev runtime d..

RE: [RFR]: Per thread IO statistics in JFR

Hi, > These features are orthogonal. Please read Gunter's answer about the > difference in his previous mail > (https://mail.openjdk.java.net/pipermail/core-libs-dev/2019- > January/058030.html) > repeated here for your convenience: > > "The existing events are triggered only if the time the IO

RE: JDK-8217880 AIX build issue about JDK-8214533

Pushed. Best regards, Goetz > -Original Message- > From: Ichiroh Takiguchi > Sent: Dienstag, 29. Januar 2019 11:30 > To: Lindenmaier, Goetz > Cc: build-dev ; ppc-aix-port-dev d...@openjdk.java.net>; core-libs-dev@openjdk.java.net; Baesken, Matthias > > Subj

RE: JDK-8217880 AIX build issue about JDK-8214533

Hi, this looks good, the build works with this patch. Do you need a sponsor? Best regards, Goetz. > -Original Message- > From: Ichiroh Takiguchi > Sent: Dienstag, 29. Januar 2019 02:21 > To: Lindenmaier, Goetz > Cc: build-dev ; ppc-aix-port-dev d...@openjdk.java.net&

RE: RFR [11u backport]: 8034802: (zipfs) newFileSystem throws UOE when the zip file is located in a custom file system

Hi Chris, this is fine, too. Best regards, Goetz. > -Original Message- > From: Langer, Christoph > Sent: Montag, 28. Januar 2019 23:28 > To: Lindenmaier, Goetz > Cc: core-libs-dev@openjdk.java.net > Subject: RE: RFR [11u backport]: 8034802: (zipfs) newFileSystem

RE: RFR [11u backport]: 8034802: (zipfs) newFileSystem throws UOE when the zip file is located in a custom file system

change he should be able to cope with that. Thus, looks good! Best regards, Götz > -Original Message- > From: Langer, Christoph > Sent: Friday, January 25, 2019 11:40 AM > To: Lindenmaier, Goetz ; core-libs- > d...@openjdk.java.net > Subject: RE: RFR [11u backport

RE: RFR: 8214533 IBM-29626C is required for AIX default charset

Hi Ichiroh, just open a bug, like "Fix aix build after 8214533" and post a RFR for it. I assume the fix is quite trivial so we can review it quick. Best regards, Goetz. > -Original Message- > From: ppc-aix-port-dev On > Behalf Of Ichiroh Takiguchi > Sent: Montag, 28. Januar 2019

RE: RFR [11u backport]: 8034802: (zipfs) newFileSystem throws UOE when the zip file is located in a custom file system

Hi Christoph, This is a big change, and it seems a lot more changed than resolving Hunks. Some hunks are missing altogether. For example, http://hg.openjdk.java.net/jdk/jdk/rev/ba51515b64e5, ZipFileSystem 2341 2.341-IndexNode inode = new IndexNode(cen, nlen, pos); 2.342+

RE: JDK-8214063: OpenJDK will not build on AIX while using the xlc 13.1 compiler

Hi Steve, feel free to request the downport of this change. For this, you must first check whether the change applies cleanly: cd jdk/jdk; hg export -r 7384e00d5860 > 8215962.changeset (you find the hash in the JBS) cd jdk11u; hg import 8215962.changeset If so, you flag the bug in JBS as

RE: RFR(XS): 8217438: Adapt tools//launcher/Test7029048.java for AIX

Hi Arno, thanks for looking at the change! Best regards, Goetz. > -Original Message- > From: Zeller, Arno > Sent: Dienstag, 22. Januar 2019 14:48 > To: Lindenmaier, Goetz > Cc: core-libs-dev@openjdk.java.net > Subject: RE: RFR(XS): 8217438: Adapt tools//launche

RE: RFR(XS): 8217438: Adapt tools//launcher/Test7029048.java for AIX

Hi Christoph, thanks for your review. I'll update AIX to Aix before pushing. Best regards, Goetz. > -Original Message- > From: Langer, Christoph > Sent: Montag, 21. Januar 2019 11:43 > To: Lindenmaier, Goetz > Cc: core-libs-dev@openjdk.java.net > Subject: RE: RFR(X

RFR(XS): 8217438: Adapt tools//launcher/Test7029048.java for AIX

Hi, please review the following small test fix: http://cr.openjdk.java.net/~goetz/wr19/8217438-aix_launcherTest/01/ The Aix launcher always sets the path to the jdk libraries because Aix does not support $ORIGIN to find libjvm.so. So some of the test cases here fail. Skip them. Best regards,

RE: RFR(S): 8217044: [aix] Launcher still adds old path to jli library to LIBPATH

ds old path to jli > library to > LIBPATH > > Hi Goetz, > > Looks fine. > > Removing unnecessary special case code is great! > > Thanks, Roger > > > On 01/15/2019 07:49 AM, Lindenmaier, Goetz wrote: > > Hi, > > > > > > > > As AIX does

RFR(S): 8217044: [aix] Launcher still adds old path to jli library to LIBPATH

Hi, As AIX does not know $ORIGIN the path to libjli must be in LIBPATH. libjli though has been moved from lib/jli/ to lib/. The path to lib/ is added to LIBPATH anyways, so we can remove the special case for AIX. Please review this small cleanup.

RE: [12] JDK-8211841 [testbug] sun/nio/cs/OLD/TestIBMDB.java does not compile (aix)

Hi, Our nightly tests with the updated patch are green, too, So I pushed it to 12: http://hg.openjdk.java.net/jdk/jdk12/rev/6b37a7ba9b66 Best regards, Goetz. > -Original Message- > From: core-libs-dev On Behalf > Of Lindenmaier, Goetz > Sent: Thursday, January 10, 2

RE: [12] JDK-8211841 [testbug] sun/nio/cs/OLD/TestIBMDB.java does not compile (aix)

Hi, The change looks good for me, too. I ran the original change through our nightly testing, it's all green. I could sponsor this as well ... Best regards, Goetz. > -Original Message- > From: core-libs-dev On Behalf > Of Ichiroh Takiguchi > Sent: Thursday, January 10, 2019 1:06

RE: JDK-8211844 [aix] ProcessBuilder: Piping between created processes does not work.

Hi Steve, I will push it once Roger gives his ok. Best regards, Goetz. > -Original Message- > From: Steve Groeger > Sent: Montag, 10. Dezember 2018 14:42 > To: Lindenmaier, Goetz > Cc: core-libs-dev@openjdk.java.net; Roger Riggs > Subject: RE: JDK-8211844 [a

RE: JDK-8211844 [aix] ProcessBuilder: Piping between created processes does not work.

Hi, I ran the fix through our tests. There are no new regressions, and the addressed test works. So reviewed from my side. I increased the bug to P3 so we can push it to jdk12 in case we miss Thursday. Best regards, Goetz. > -Original Message- > From: core-libs-dev On Behalf Of

RE: JDK-8211844 [aix] ProcessBuilder: Piping between created processes does not work.

Hi, To me, the change looks good, too. I just wondered whether solaris needs to be fixed, too. But I don’t see the test failing on solaris. The bug needs to be removed from the ProblemList in the change, though. See also

RE: 8207404: MulticastSocket tests failing on Aix

the VM should work on the default system configuration? Or do you think that this should be fixed in the default system configuration? Best regards, Goetz. > -Original Message- > From: Steve Groeger > Sent: Freitag, 30. November 2018 12:20 > To: Lindenmaier, Goetz > C

RE: Proposal: Add support for Process Groups to the JDK

Hi Roger, > I'd be interested in hearing more about the use cases. Well, as Thomas already stated, we use this in our test framework and in an application server environment. Our test scheduler runs tests of various VMs (we test OpenJDK builds, SapMachine builds and SAP JVM builds for Java 5-12

RE: RFR: 8211752: JNU_ThrowIOExceptionWithLastErrorAndPath - enhance some IOExceptions with path causing the issue

well. > > If needed, we might use something similar to JDK-8207768 where a > category has been added for enhanced exception messages to the > java.security file . > > Best regards, Matthias > > From: Baesken, Matthias > Sent: Dienstag, 9. Oktober 2018

RE: JEP JDK-8208089: Implement C++14 Language Features

ag, 4. Oktober 2018 23:01 > To: Lindenmaier, Goetz > Cc: hotspot-dev developers ; build-dev > ; core-libs-dev@openjdk.java.net > Subject: Re: JEP JDK-8208089: Implement C++14 Language Features > > > On Oct 4, 2018, at 2:59 AM, Lindenmaier, Goetz > wrote: > > > > Hi, > &

RE: JEP JDK-8208089: Implement C++14 Language Features

Hi, I appreciate this is handled in a JEP and well communicated! XLc, the compiler we use for AIX, might be a bottleneck here. But we currently have no compiler-constraints by products on our aix port of jdk12 (for jdk11 we must stay with the current compiler xlc 12 which does not support

RE: RFR: 8210416: [linux] Poor StrictMath performance due to non-optimized compilation

Hi, We are only talking about reducing O3 to O2 for the compilation step of fdlibm, right? As I know, this is being replaced by Java coding, anyways. Therefore I don't have a strong opinion for any of the choices. Best regards, Goetz. > -Original Message- > From: core-libs-dev On

RE: [OpenJDK 2D-Dev] RFR JDK-8209786: gcc 7.3 compiler errors on zLinux

Yes, that's fine. I can sponsor it tomorrow. I'm not in the office today. Best regards, Goetz. > -Original Message- > From: Andrew Leonard > Sent: Donnerstag, 6. September 2018 12:29 > To: Magnus Ihse Bursie ; Lindenmaier, Goetz > > Cc: 2d-dev <2d-...@ope

RE: RFR JDK-8209786: gcc 7.3 compiler errors on zLinux

Hi Leonard, Whom should I add as reviewers? (Besides me :)) Best regards, Goetz. > -Original Message- > From: Andrew Leonard > Sent: Donnerstag, 30. August 2018 17:02 > To: Lindenmaier, Goetz > Cc: Brian Burkhalter ; build-dev (build- > d...@openjdk.java.net

RE: RFR JDK-8209786: gcc 7.3 compiler errors on zLinux

Hi Leonard, the change looks good to me. I'll test it tonight, to make sure it runs with our compilers. Did you run it through jdk-submit? If you supply a patch with all the changeset information (like from hg export) that jchecks fine, I'll sponsor this for you. Best regards, Goetz. >

RE: RFR [11] 8207846: Generalize the jdk.net.includeInExceptions security property

Hi, I scanned all the changes we did to exception messages in our internal VM, see below. We print paths and sockets in a row of places, but also other information. It's wide spread, while most is in java.base. We plan to contribute these messages in the near future. Thus it'll be useful if

RE: RFR : 8207395: jar has issues with UNC-path arguments for the jar -C parameter [windows]

Looks good. Best regards, Goetz. > -Original Message- > From: Baesken, Matthias > Sent: Donnerstag, 19. Juli 2018 11:15 > To: core-libs-dev@openjdk.java.net; xueming.s...@oracle.com > Cc: Lindenmaier, Goetz > Subject: Re: RFR : 8207395: jar has issues with

RE: RE : RFR(S): 8207766: [testbug] Adapt tests for Aix.

Hi Matthias, thanks for lookin at this! Best regards, Goetz. > -Original Message- > From: Baesken, Matthias > Sent: Freitag, 20. Juli 2018 09:03 > To: core-libs-dev@openjdk.java.net > Cc: Lindenmaier, Goetz > Subject: RE : RFR(S): 8207766: [testbug] Adapt tests f

RE: RFR(S): 8207766: [testbug] Adapt tests for Aix.

uot; --> " Best regards, Goetz. > -Original Message- > From: Langer, Christoph > Sent: Donnerstag, 19. Juli 2018 09:00 > To: Lindenmaier, Goetz ; core-libs- > d...@openjdk.java.net > Subject: RE: RFR(S): 8207766: [testbug] Adapt tests for Aix. > > Hi Goetz, > &

RE: RFR : 8207395: jar has issues with UNC-path arguments for the jar -C parameter [windows]

Hi Matthias, thanks for doing this fix. I think this can be noted down a bit better, avoiding duplicating the loop. Also, please remove the redundant dir.replace(File.separatorChar, '/'). dir = dir.replace(File.separatorChar, '/'); +String unc

RFR(S): 8207766: [testbug] Adapt tests for Aix.

Hi, I would like to fix these tests to run on aix: http://cr.openjdk.java.net/~goetz/wr18/8207766-aixTestFixes/01/ MulticastSocket tests Opened bug and asked IBM to fix. Put on ProblemList. See https://bugs.openjdk.java.net/browse/JDK-8207404 EvalArraysAsList.sh Quotes need to be escaped

RE: RFR(S): 8207233: Minor improvements of jdk C-coding

_mult.c: 84, 89 >    Since the assignment is done in both branches of the if, it could be > moved up. > > Regards, Roger > > > On 7/13/2018 6:54 AM, Lindenmaier, Goetz wrote: > > Hi, > > > > I ran coverity on the jdk11 jdk sources and want to propose

RFR(S): 8207233: Minor improvements of jdk C-coding

Hi, I ran coverity on the jdk11 jdk sources and want to propose the following fixes. I scanned the linux x86_64 build. Some issues are similar to previous parfait fixes (check for NULL). I also identified some issues I consider real problems. If you think some are tooo conservative, I'm happy

RE: RFR(M): 8203826: Chain class initialization exceptions into later NoClassDefFoundErrors

Hi, Volker, thanks for improving on my original change and implementing David's and Karen's proposals. David, I think the change addresses a row of your concerns. > proposal - it just moves the "field" from the Java side to the VM side. No, the space overhead in case of successful

RE: [RFR] 8204539: improve error messages in matchJavaTZ [windows]

Hi Matthias, thanks for adding this information, looks good! Best regards, Goety. > -Original Message- > From: Baesken, Matthias > Sent: Freitag, 8. Juni 2018 08:51 > To: Langer, Christoph ; core-libs- > d...@openjdk.java.net; 'sean.cof...@oracle.com' > > C

RE: RFR(M): 8202745: Remove hyphens from "out-of-bounds".

Hi David, Thanks for looking at this. > The grammar can be a bit subtle here. IIUC we would say: > "Index %d out of bounds for length %d" > but if we turn it around we'd say: > "out-of-bounds index %d for length %d" Yes, this is the assumption of my edits. > src/hotspot/cpu/ppc/ppc.ad > I'd

RFR(M): 8202745: Remove hyphens from "out-of-bounds".

Hi, as a follow up to "8201593: Print array length in ArrayIndexOutOfBoundsException." I promised to check all occurances of out-of-bounds. This change fixes them wherever the term is not used as an adjective: http://cr.openjdk.java.net/~goetz/wr18/8202745-out-of-bounds/01/ Please review. Best

RE: RFR(M): 8201593: Print array length in ArrayIndexOutOfBoundsException.

quot;arraycopy:" prefix always included > the ":". Added. Best regards, Goetz. > > Thanks, Roger > > > On 4/24/18 12:25 PM, Lindenmaier, Goetz wrote: > > Hi Simon, > > > > Because as stated here, > > http://mail.openjdk.java.net/pipermai

RE: RFR(M): 8201593: Print array length in ArrayIndexOutOfBoundsException.

lto:si...@cjnash.com] > Sent: Dienstag, 24. April 2018 18:17 > To: Lindenmaier, Goetz <goetz.lindenma...@sap.com> > Cc: David Holmes <david.hol...@oracle.com>; hotspot-runtime- > d...@openjdk.java.net; hotspot-compiler-...@openjdk.java.net; aarch64- > port-.

  1   2   >