Hello,
Responding to David's comment and some comments from Alan off-list, here
is a variant which doesn't use suppressed exceptions in initCause, but
still passes along some information:
http://cr.openjdk.java.net/~darcy/8012044.4
Patch to Throwable:
--- a/src/share/classes/java/lang/T
Alan,
Thanks for your comments.
I did the changes in code.
Please, read my answers below.
Here is fixed version:
http://cr.openjdk.java.net/~uta/openjdk-webrevs/JDK-8012453/webrev.02/
Regards,
-uta
On 24.04.2013 18:23, Alan Bateman wrote:
On 24/04/2013 13:58, Alexey Utkin wrote:
I changed
On 25/04/2013 08:16, Joe Darcy wrote:
Hello,
Responding to David's comment and some comments from Alan off-list,
here is a variant which doesn't use suppressed exceptions in
initCause, but still passes along some information:
http://cr.openjdk.java.net/~darcy/8012044.4
This looks reason
Hi Mandy,
Here's another update that changes the sub-key back to
WeakReference based:
http://dl.dropboxusercontent.com/u/101777488/jdk8-tl/proxy-wc/webrev.05/index.html
On 04/25/2013 03:38 AM, Mandy Chung wrote:
I like this one too. The mapping is straight forward and clean that
avoids the
Looks good. I still think last sentence of the Throwable.addSuppressed
javadocs side steps the counter arguments.
Thanks for working on this,
Jason
> Date: Thu, 25 Apr 2013 00:16:05 -0700
> From: joe.da...@oracle.com
> To: david.hol...@oracle.com; alan.
Changeset: 4da1d43f5843
Author:darcy
Date: 2013-04-25 09:37 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4da1d43f5843
8012044: Give more information about self-suppression from
Throwable.addSuppressed
Reviewed-by: alanb, dholmes
! src/share/classes/java/lang/Throwable.jav
Hello,
Please review changes which essentially contains asm5_future in asm's
mainline
repository, I have tested this patch with Nashorn (so has Sundar), as
well as Lambda's
usage.
Fixes that I know of:
1. supports v52.0 class files and JSR 308/Type Annotations changes
Thanks to Remi
2. elimi
On 04/24/2013 06:54 AM, Alan Bateman wrote:
> On 24/04/2013 00:09, Henry Jen wrote:
>> Hi,
>>
>> Please review static Stream factory methods and methods for Arrays.
>> Webrev is at
>>
>> http://cr.openjdk.java.net/~henryjen/tl/8012650-8011918.0
>>
>> Stream methods are covered in a test suite which
On 25/04/2013 19:14, Henry Jen wrote:
:
Both fixed, new webrev is at
http://cr.openjdk.java.net/~henryjen/tl/8012650-8011918.1
Cheers,
Henry
Thanks, I didn't mean you have to have to generate a new webrev for such
minor matters. Anyway, I don't see any other issues and looks fine to me.
-Al
Changeset: ca0957f0d408
Author:emc
Date: 2013-04-25 14:23 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ca0957f0d408
8012937: Correct errors in javadoc comments.
Summary: Correct some errors in the javadoc comments for parameter reflection.
Reviewed-by: darcy
! src/share/cl
Hello all;
Here's the promised results of the survey. With 10 responses 7 favoured the
"before @param" option and 3 favoured the "@after throws" option. Here are the
survey text comments, "-", with my notes, "--", following each.
- "@apiNote should be removed, anything it has to say should be i
Changeset: 5871d7b1673c
Author:coffeys
Date: 2013-04-25 21:12 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5871d7b1673c
8000529: Regression: SimpleDateFormat incorrectly parses dates formatted with Z
and z pattern letters
Reviewed-by: okutsu
! src/share/classes/java/text/
Here is the webrev:
http://cr.openjdk.java.net/~ksrini/8013225/webrev.0/
Thanks
Kumar
Hello,
Please review changes which essentially contains asm5_future in asm's
mainline
repository, I have tested this patch with Nashorn (so has Sundar), as
well as Lambda's
usage.
Fixes that I know of:
1.
Hi,
Please review two default methods add to CharSequence returns IntStream
of char value or code point value.
http://cr.openjdk.java.net/~henryjen/tl/8012665.0/webrev/
The synchronization test is relieved so lambda and other synthetic
method is not tested. If synchronization is needed for those
http://cr.openjdk.java.net/~lancea/8010416/webrev.03/ addresses the typos that
were pointed out and also fixes a couple javadoc warnings
Best,
Lance
On Apr 22, 2013, at 11:17 AM, Lance Andersen - Oracle wrote:
>
> On Apr 22, 2013, at 9:13 AM, Alan Bateman wrote:
>
>> On 21/04/2013 12:45, Lanc
Henry,
I believe the coding standards require curly braces for any if-statement
and for-loop.
Also the return statements exceed the 80 character limit. It would be nice
to have them formatted across several lines like the following because it's
difficult to read going straight across:
return Str
On 04/25/2013 01:57 PM, Paul Benedict wrote:
> Henry,
>
> I believe the coding standards require curly braces for any if-statement
> and for-loop.
>
> Also the return statements exceed the 80 character limit. It would be nice
> to have them formatted across several lines like the following becaus
Hi Peter,
This looks great. I have imported your patch with slight modification
in WeakCache:
http://cr.openjdk.java.net/~mchung/jdk8/webrevs/7123493/webrev.01/
I believe WeakCache.get(K, P) should throw NPE if key is null and I
fixed that. I changed refQueue to be of type ReferenceQueue
The restyling changes obfustucated things a bit but I didn't see anything of
concern in casual review.
I had hoped to see the updated SmallSet that didn't try to implement Iterator
directly.
Looks OK. The testing, which you have done, is the important qualifier for this
change.
Mike
On Apr 2
I think core library code should write the slightly lower-level code for
performance
+int cp = Character.codePointAt(CharSequence.this, cur);
+cur += Character.charCount(cp);
int length = length();
if (cur == length) throw NSEE;
char c1 = charAt(cur++), c2;
if (!is
Hello,
We are at long last soon to commence our long overdue effort to integrate this
important submission.
To this end I have a couple of questions and a comment below.
Thanks,
Brian
On Mar 10, 2013, at 1:39 PM, Tim Buktu wrote:
> I have updated the patch. It now contains Alan Eliasen's fas
On 4/25/2013 3:53 PM, Mike Duigou wrote:
The restyling changes obfustucated things a bit but I didn't see anything of
concern in casual review.
I had hoped to see the updated SmallSet that didn't try to implement Iterator
directly.
Remi, Paul and Brian discussed that and struck a deal, maybe
Changeset: b600d637ef77
Author:wetmore
Date: 2013-04-25 17:10 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b600d637ef77
8012530: test/sun/security/provider/SecureRandom/StrongSeedReader.java failing
Reviewed-by: wetmore
Contributed-by: alan.bate...@oracle.com
! test/sun/se
Changeset: 4b0038f66d66
Author:jjg
Date: 2013-04-25 17:45 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/4b0038f66d66
8013256: javac test failing after Lambda changes to java.util.List
Reviewed-by: mduigou
! test/tools/javac/api/TestJavacTaskScanner.java
Changeset: a8da4e516bc3
Author:akhil
Date: 2013-04-23 11:54 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a8da4e516bc3
8005051: optimized defaults for Iterator.forEachRemaining
Reviewed-by: alanb, mduigou, psandoz, ulfzibis
Contributed-by: Akhil Arora
! src/share/classes/j
On 4/18/2013 7:44 PM, David Holmes wrote:
On 19/04/2013 8:32 AM, huizhe wang wrote:
On 4/18/2013 2:13 AM, Alan Bateman wrote:
On 18/04/2013 07:28, huizhe wang wrote:
System.getProperties [1] returns all of the "current" system
properties. Is there a way to get a list of the system reserved
p
Hi Mandy,
Just a note on null keys (1st level)...
On 04/25/2013 11:53 PM, Mandy Chung wrote:
Hi Peter,
This looks great. I have imported your patch with slight modification
in WeakCache:
http://cr.openjdk.java.net/~mchung/jdk8/webrevs/7123493/webrev.01/
I believe WeakCache.get(K, P) should
On 4/25/2013 11:53 PM, Peter Levart wrote:
I believe WeakCache.get(K, P) should throw NPE if key is null and I
fixed that.
Oops... typo sorry for the confusion.- I meant WeakCache.containsKey(V
value) should throw NPE if value is null.
Mandy
28 matches
Mail list logo
