On Wed, 2 Dec 2020 14:51:23 GMT, Julia Boes wrote:
> Now that the changes for record serialization are integrated into the Java
> Object Serialization Specification, this change updates the serialization
> javadocs in ObjectInputStream, ObjectOutputStream, Serializable and
> java.lang.Record.
> Update Class::isRecord to only return true for classes that are final.
>
> The removal of non-specified JVM checks on classes with a Record Attribute
> (see JDK-8255342), has resulted in more types of loadable classes that may
> contain a Record Attribute. Since these checks are not performed
On Tue, 1 Dec 2020 19:34:11 GMT, Chris Hegarty wrote:
> Update Class::isRecord to only return true for classes that are final.
>
> The removal of non-specified JVM checks on classes with a Record Attribute
> (see JDK-8255342), has resulted in more types of loadable classes that may
> contain a
On Thu, 26 Nov 2020 19:24:16 GMT, Jorn Vernee wrote:
> This upstreams the patch from:
> https://github.com/openjdk/panama-foreign/pull/396
>
> There were only some minor merge conflicts due to imports and some tests
> being replaced by java/foreign/TestNulls. All tests still pass, no other
>
On Fri, 27 Nov 2020 16:57:54 GMT, Jan Lahoda wrote:
> This pull request replaces https://github.com/openjdk/jdk/pull/1227.
>
> From the original PR:
>
>> Please review the code for the second iteration of sealed classes. In this
>> iteration we are:
>>
>> * Enhancing narrowing reference c
> A lot (but not all) of the data in make/data is tied to a specific module.
> For instance, the publicsuffixlist is used by java.base, and fontconfig by
> java.desktop. (A few directories, like mainmanifest, is *actually* used by
> make for the whole build.)
>
> These data files should move t
On Mon, 7 Dec 2020 14:20:07 GMT, Magnus Ihse Bursie wrote:
>> @erikj79 Good point, that makes much more sense.
>
> I'm not sure about the formal process for suggesting changes to a delivered
> JEP, but this is the text I suggest should replace the current definition of
> the new scheme:
>
>
On Fri, 4 Dec 2020 15:17:06 GMT, Magnus Ihse Bursie wrote:
>> Regarding the chosen layout. Did you consider following the existing pattern
>> of src//{share,}/data?
>
> @erikj79 Good point, that makes much more sense.
I'm not sure about the formal process for suggesting changes to a delivered
On Sat, 5 Dec 2020 01:46:31 GMT, Dan Smith wrote:
> Integration of [JEP 390](https://bugs.openjdk.java.net/browse/JDK-8249100).
>
> Development has been broken into 5 tasks, each with its own JBS issue:
> - Deprecate wrapper class constructors for removal (rriggs)
> - Revise "value-based class"
On Sun, 6 Dec 2020 17:29:27 GMT, Ivan Šipka wrote:
>> Refactor `test/jdk/java/lang/Thread/UncaughtExceptions.sh` as java test.
>
> Ivan Šipka has updated the pull request incrementally with one additional
> commit since the last revision:
>
> 8166026: Refactor java/lang shell tests to java
t
On Sat, 5 Dec 2020 01:46:31 GMT, Dan Smith wrote:
> Integration of [JEP 390](https://bugs.openjdk.java.net/browse/JDK-8249100).
>
> Development has been broken into 5 tasks, each with its own JBS issue:
> - Deprecate wrapper class constructors for removal (rriggs)
> - Revise "value-based class"
On Sat, 5 Dec 2020 02:37:55 GMT, Stuart Marks wrote:
>> Is there a reason the code would not naturally work when either min or
>> preferred is zero?
>> Why are their preconditions? What do they allow?
>> These methods are used in enough places that a slip in any of the clients
>> would be trou
On Sat, 5 Dec 2020 03:17:56 GMT, Mikael Vidstedt wrote:
>> Start of JDK 17 updates.
>
> Marked as reviewed by mikael (Reviewer).
The langtools changes look fine to me. There were additions/changes to jcod
files under `test/hotspot/jtreg/runtime/sealedClasses/` made under JDK-8246778,
so these
On Mon, 16 Nov 2020 13:30:06 GMT, Vicente Romero wrote:
> Please review the code for the second iteration of sealed classes. In this
> iteration we are:
>
> - Enhancing narrowing reference conversion to allow for stricter checking of
> cast conversions with respect to sealed type hierarchies
>
On Mon, 7 Dec 2020 15:50:55 GMT, Harold Seigel wrote:
>> Integration of [JEP 390](https://bugs.openjdk.java.net/browse/JDK-8249100).
>>
>> Development has been broken into 5 tasks, each with its own JBS issue:
>> - Deprecate wrapper class constructors for removal (rriggs)
>> - Revise "value-base
Safe URI encode logic adopted from UnixUriUtils.
-
Commit messages:
- 8242258: (jrtfs) Path::toUri throws AssertionError for malformed input
Changes: https://git.openjdk.java.net/jdk/pull/1669/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=1669&range=00
Issue: https:
On Sat, 5 Dec 2020 05:33:25 GMT, Alexander Matveev wrote:
> Fixed by using correct localized resources.
Marked as reviewed by asemenyuk (Committer).
-
PR: https://git.openjdk.java.net/jdk/pull/1638
On Thu, 26 Nov 2020 18:29:42 GMT, Maurizio Cimadamore
wrote:
> There is a subtle bug in the heap segment factories: the byte size is
> computed using an int multiplication instead of a long multiplication.
> Because of that, it is possible to observe overflow when creating segments
> out of a
On Sat, 5 Dec 2020 12:02:26 GMT, Marius Volkhart
wrote:
>> The default implementation of javax.xml.stream.XMLEventReader produced a
>> StartDocument event that always indicated that the "standalone" attribute
>> was set.
>>
>> The root cause of this was that the
>> com.sun.xml.internal.strea
On Fri, 4 Dec 2020 00:32:26 GMT, Joe Wang wrote:
>> Marius Volkhart has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains three commits:
>>
>> - Adjust test so it works with jtreg
>> - Fix: javax.xml.stream.XMLEventReader produces inc
This simple patch updates the jaavdoc in the module-info file of
jdk.incubator.foreign to reflect the fact that support of foreign function
calls has been added.
-
Commit messages:
- Fix module-info javadoc
Changes: https://git.openjdk.java.net/jdk/pull/1671/files
Webrev: https:/
This change applies a stricter semantic distinction of 'type' versus 'class and
interface'. This is based on the JLS changes described in the "Consistent Class
and Interface Terminology" document:
https://download.java.net/java/early_access/jdk16/docs/specs/class-terminology-jls.html.
The follo
This has been implemented for cgroups v1 with
[JDK-8250984](https://bugs.openjdk.java.net/browse/JDK-8250984) but was lacking
some tooling support for cgroups v2. With podman 2.2.0 release this could now
be implemented (and tested). The idea is the same as for the cgroups v1 fix. If
we've got n
On Sun, 6 Dec 2020 00:00:24 GMT, Michael Edgar
wrote:
>> Allow `XMLStreamException` to be thrown to the application when a filtered
>> `XMLStreamReader` encounters an `XMLStreamException` advancing the wrapped
>> `XMLStreamReader`.
>>
>> Note, this PR includes a method signature change (const
On Sat, 5 Dec 2020 05:33:25 GMT, Alexander Matveev wrote:
> Fixed by using correct localized resources.
This pull request has now been integrated.
Changeset: a265c201
Author:Alexander Matveev
URL: https://git.openjdk.java.net/jdk/commit/a265c201
Stats: 2 lines in 2 files changed:
On Wed, 18 Nov 2020 07:18:16 GMT, Joe Wang wrote:
>> Michael Edgar has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains two commits:
>>
>> - Update test for jtreg
>> - 8255918: Throw XMLStreamExceptions from XMLStreamFilterImpl const
On Mon, 7 Dec 2020 17:31:34 GMT, Julia Boes wrote:
> This change applies a stricter semantic distinction of 'type' versus 'class
> and interface'. This is based on the JLS changes described in the "Consistent
> Class and Interface Terminology" document:
> https://download.java.net/java/early_a
On Sat, 5 Dec 2020 01:46:31 GMT, Dan Smith wrote:
> Integration of [JEP 390](https://bugs.openjdk.java.net/browse/JDK-8249100).
>
> Development has been broken into 5 tasks, each with its own JBS issue:
> - Deprecate wrapper class constructors for removal (rriggs)
> - Revise "value-based class"
> Please review this fix for the intermittently-failing
> java/lang/ClassLoader/nativeLibrary/NativeLibraryTest.java.
>
> The change replaces System.gc()+sleep() with the more robust gcAwait()
> mechanic used elsewhere in the test base, [as pointed out by
> Martin](https://bugs.openjdk.java.net
On Mon, 7 Dec 2020 14:27:45 GMT, Magnus Ihse Bursie wrote:
>> A lot (but not all) of the data in make/data is tied to a specific module.
>> For instance, the publicsuffixlist is used by java.base, and fontconfig by
>> java.desktop. (A few directories, like mainmanifest, is *actually* used by
>
> Start of JDK 17 updates.
Joe Darcy has updated the pull request with a new target base due to a merge or
a rebase. The incremental webrev excludes the unrelated changes brought in by
the merge/rebase. The pull request contains eight additional commits since the
last revision:
- Merge branch
On Mon, 7 Dec 2020 16:10:42 GMT, Jan Lahoda wrote:
>
>
> The langtools changes look fine to me. There were additions/changes to jcod
> files under `test/hotspot/jtreg/runtime/sealedClasses/` made under
> JDK-8246778, so these may need an update. Sorry about that.
After a merge, the tests in
Please review this fix for JDK-8256867. This change no longer throws a
ClassFormatError exception when loading a class whose PermittedSubclasses
attribute is empty (contains no classes). Instead, the class is treated as a
sealed class which cannot be extended nor implemented. This new behavio
On Mon, 7 Dec 2020 17:38:40 GMT, Maurizio Cimadamore
wrote:
> This simple patch updates the jaavdoc in the module-info file of
> jdk.incubator.foreign to reflect the fact that support of foreign function
> calls has been added.
Marked as reviewed by jvernee (Committer).
-
PR: ht
On Mon, 7 Dec 2020 19:30:28 GMT, Brent Christian wrote:
>> Please review this fix for the intermittently-failing
>> java/lang/ClassLoader/nativeLibrary/NativeLibraryTest.java.
>>
>> The change replaces System.gc()+sleep() with the more robust gcAwait()
>> mechanic used elsewhere in the test ba
On Mon, 7 Dec 2020 16:35:52 GMT, Athijegannathan Sundararajan
wrote:
> Safe URI encode logic adopted from UnixUriUtils.
test/jdk/jdk/internal/jrtfs/Test8242258.java line 40:
> 38: import static org.testng.Assert.assertEquals;
> 39:
> 40: public class Test8242258 {
I think it would be better
> Refactor `test/jdk/java/lang/Thread/UncaughtExceptions.sh` as java test.
Ivan Šipka has updated the pull request incrementally with two additional
commits since the last revision:
- 8166026: Refactor java/lang shell tests to java
- 8166026: Refactor java/lang shell tests to java
---
On Mon, 7 Dec 2020 15:46:11 GMT, Roger Riggs wrote:
>> Ivan Šipka has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8166026: Refactor java/lang shell tests to java
>
> test/jdk/java/lang/Thread/UncaughtExceptionsTest.java line 68:
>
>> 66
On Mon, 7 Dec 2020 19:38:41 GMT, Joe Darcy wrote:
>> Start of JDK 17 updates.
>
> Joe Darcy has updated the pull request with a new target base due to a merge
> or a rebase. The incremental webrev excludes the unrelated changes brought in
> by the merge/rebase. The pull request contains eight a
On Mon, 7 Dec 2020 19:38:41 GMT, Joe Darcy wrote:
>> Start of JDK 17 updates.
>
> Joe Darcy has updated the pull request with a new target base due to a merge
> or a rebase. The incremental webrev excludes the unrelated changes brought in
> by the merge/rebase. The pull request contains eight a
On Mon, 7 Dec 2020 19:38:41 GMT, Joe Darcy wrote:
>> Start of JDK 17 updates.
>
> Joe Darcy has updated the pull request with a new target base due to a merge
> or a rebase. The incremental webrev excludes the unrelated changes brought in
> by the merge/rebase. The pull request contains eight a
6882207: Convert javap to use diamond operator internally
-
Commit messages:
- 6882207: Convert javap to use diamond operator internally
Changes: https://git.openjdk.java.net/jdk/pull/1677/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=1677&range=00
Issue: https://bu
increase retries and timeout increasing in runMsiexecWithRetries
-
Commit messages:
- JDK-8257539: tools/jpackage/windows/WinL10nTest.java unpack.bat failed with
Exit code: 1618
Changes: https://git.openjdk.java.net/jdk/pull/1676/files
Webrev: https://webrevs.openjdk.java.net/?rep
On Mon, 7 Dec 2020 19:30:28 GMT, Brent Christian wrote:
>> Please review this fix for the intermittently-failing
>> java/lang/ClassLoader/nativeLibrary/NativeLibraryTest.java.
>>
>> The change replaces System.gc()+sleep() with the more robust gcAwait()
>> mechanic used elsewhere in the test ba
On Mon, 7 Dec 2020 20:08:59 GMT, Jonathan Gibbons wrote:
>> Joe Darcy has updated the pull request with a new target base due to a merge
>> or a rebase. The incremental webrev excludes the unrelated changes brought
>> in by the merge/rebase. The pull request contains eight additional commits
>
On Mon, 7 Dec 2020 19:51:38 GMT, Harold Seigel wrote:
> Please review this fix for JDK-8256867. This change no longer throws a
> ClassFormatError exception when loading a class whose PermittedSubclasses
> attribute is empty (contains no classes). Instead, the class is treated as a
> sealed c
On Mon, 7 Dec 2020 19:51:38 GMT, Harold Seigel wrote:
> Please review this fix for JDK-8256867. This change no longer throws a
> ClassFormatError exception when loading a class whose PermittedSubclasses
> attribute is empty (contains no classes). Instead, the class is treated as a
> sealed c
On Mon, 7 Dec 2020 21:18:45 GMT, Joe Darcy wrote:
>> Please review this fix for JDK-8256867. This change no longer throws a
>> ClassFormatError exception when loading a class whose PermittedSubclasses
>> attribute is empty (contains no classes). Instead, the class is treated as
>> a sealed c
On Mon, 7 Dec 2020 21:30:18 GMT, Lois Foltan wrote:
>> Please review this fix for JDK-8256867. This change no longer throws a
>> ClassFormatError exception when loading a class whose PermittedSubclasses
>> attribute is empty (contains no classes). Instead, the class is treated as
>> a sealed
On Mon, 7 Dec 2020 20:20:58 GMT, Jesper Wilhelmsson
wrote:
>> Joe Darcy has updated the pull request with a new target base due to a merge
>> or a rebase. The incremental webrev excludes the unrelated changes brought
>> in by the merge/rebase. The pull request contains eight additional commits
On Mon, 7 Dec 2020 20:38:31 GMT, Naoto Sato wrote:
>> Brent Christian has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains three additional
>> commit
On Mon, 7 Dec 2020 20:39:34 GMT, Naoto Sato wrote:
>> Brent Christian has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains three additional
>> commit
> Please review this fix for the intermittently-failing
> java/lang/ClassLoader/nativeLibrary/NativeLibraryTest.java.
>
> The change replaces System.gc()+sleep() with the more robust gcAwait()
> mechanic used elsewhere in the test base, [as pointed out by
> Martin](https://bugs.openjdk.java.net
On Mon, 7 Dec 2020 19:51:38 GMT, Harold Seigel wrote:
> Please review this fix for JDK-8256867. This change no longer throws a
> ClassFormatError exception when loading a class whose PermittedSubclasses
> attribute is empty (contains no classes). Instead, the class is treated as a
> sealed c
On Mon, 7 Dec 2020 23:52:29 GMT, Brent Christian wrote:
>> Please review this fix for the intermittently-failing
>> java/lang/ClassLoader/nativeLibrary/NativeLibraryTest.java.
>>
>> The change replaces System.gc()+sleep() with the more robust gcAwait()
>> mechanic used elsewhere in the test ba
On Mon, 7 Dec 2020 23:52:29 GMT, Brent Christian wrote:
>> Please review this fix for the intermittently-failing
>> java/lang/ClassLoader/nativeLibrary/NativeLibraryTest.java.
>>
>> The change replaces System.gc()+sleep() with the more robust gcAwait()
>> mechanic used elsewhere in the test ba
On Mon, 7 Dec 2020 19:51:38 GMT, Harold Seigel wrote:
> Please review this fix for JDK-8256867. This change no longer throws a
> ClassFormatError exception when loading a class whose PermittedSubclasses
> attribute is empty (contains no classes). Instead, the class is treated as a
> sealed c
On Mon, 7 Dec 2020 21:29:23 GMT, Lois Foltan wrote:
>> Please review this fix for JDK-8256867. This change no longer throws a
>> ClassFormatError exception when loading a class whose PermittedSubclasses
>> attribute is empty (contains no classes). Instead, the class is treated as
>> a sealed
On Mon, 7 Dec 2020 16:05:11 GMT, Roger Riggs wrote:
>> The origin of this code is in collections like ArrayList that have an
>> existing array (hence oldLength >= 0) and that need it to grow (hence
>> minGrowth > 0). Those were the prevailing assumptions in the code from which
>> this was deri
`Reference::isEnqueued` method was never implemented as it was initially
specified since 1.2. The specification says that it tests if this reference
object has been enqueued, but the long-standing behavior is to test if this
reference object is in its associated queue, only reflecting the state
On Mon, 7 Dec 2020 19:31:59 GMT, Jonathan Gibbons wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Move to share/data, and move jdwp.spec to java.se
>
> I have reviewed all lines in the patch file with or near
> Safe URI encode logic adopted from UnixUriUtils.
Athijegannathan Sundararajan has updated the pull request incrementally with
one additional commit since the last revision:
renamed the test as per review comment.
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/1669/fi
On Mon, 7 Dec 2020 19:59:40 GMT, Alan Bateman wrote:
>> Athijegannathan Sundararajan has updated the pull request incrementally with
>> one additional commit since the last revision:
>>
>> renamed the test as per review comment.
>
> test/jdk/jdk/internal/jrtfs/Test8242258.java line 40:
>
>>
On Mon, 7 Dec 2020 20:29:56 GMT, Andy Herrick wrote:
> increase retries and timeout increasing in runMsiexecWithRetries
Looks like test failed due to:
[Fatal Error] b.wxl:3:1: XML document structures must start and end within the
same entity.
So, I am not sure how increased repeat will help. Do
On Fri, 4 Dec 2020 22:13:21 GMT, Roger Riggs wrote:
>> src/java.base/share/classes/java/util/HexFormat.java line 936:
>>
>>> 934: * if any of the characters is not a hexadecimal character
>>> 935: */
>>> 936: public int fromHexDigits(CharSequence string) {
>>
>> I recommend t
> Start of JDK 17 updates.
Joe Darcy has updated the pull request with a new target base due to a merge or
a rebase. The incremental webrev excludes the unrelated changes brought in by
the merge/rebase. The pull request contains ten additional commits since the
last revision:
- Merge branch '
Hi Johannes,
I've filed this bug report for you:
https://bugs.openjdk.java.net/browse/JDK-8257874
Thanks,
David
On 8/12/2020 11:20 am, Johannes Kuhn wrote:
Let's start with the reproducer:
public class NestmateBug {
private static int field = 0;
public static void main
Thanks David. I was about to create one.
This is indeed a gap in injecting this trampoline class for supporting
@CallerSensitive methods. The InjectedInvoker ensures that the
InjectedInvoker class has the same class loader as the lookup class.
W.r.t. your patch, it seems okay but I have to
On Tue, 8 Dec 2020 02:36:01 GMT, Mandy Chung wrote:
> `Reference::isEnqueued` method was never implemented as it was initially
> specified since 1.2. The specification says that it tests if this reference
> object has been enqueued, but the long-standing behavior is to test if this
> reference
8234131: Miscellaneous changes imported from jsr166 CVS 2020-12
-
Commit messages:
- JDK-8234131
Changes: https://git.openjdk.java.net/jdk/pull/1647/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=1647&range=00
Issue: https://bugs.openjdk.java.net/browse/JDK-8234131
On Tue, 8 Dec 2020 05:01:08 GMT, Kim Barrett wrote:
>> `Reference::isEnqueued` method was never implemented as it was initially
>> specified since 1.2. The specification says that it tests if this reference
>> object has been enqueued, but the long-standing behavior is to test if this
>> refer
8246677: LinkedTransferQueue and SynchronousQueue synchronization updates
-
Commit messages:
- JDK-8246677
Changes: https://git.openjdk.java.net/jdk/pull/1645/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=1645&range=00
Issue: https://bugs.openjdk.java.net/browse/JDK
8246585: ForkJoin updates
-
Commit messages:
- JDK-8246585
Changes: https://git.openjdk.java.net/jdk/pull/1646/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=1646&range=00
Issue: https://bugs.openjdk.java.net/browse/JDK-8246585
Stats: 3114 lines in 6 files changed:
8254350: CompletableFuture.get may swallow InterruptedException
-
Commit messages:
- JDK-8254350
Changes: https://git.openjdk.java.net/jdk/pull/1651/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=1651&range=00
Issue: https://bugs.openjdk.java.net/browse/JDK-8254350
Let's start with the reproducer:
public class NestmateBug {
private static int field = 0;
public static void main(String[] args) throws Throwable {
Lookup l = MethodHandles.lookup();
Field f = NestmateBug.class.getDeclaredField("field");
Met
> Hi, Please review
> Windows mapping for file into memory could not happen to reserved memory.
> In mapping CDS archive we first reserve enough memory then before mapping,
> release them. For cds archive and using class space, need split the whole
> space into two, that is, release the whole
> 8246677: LinkedTransferQueue and SynchronousQueue synchronization updates
Martin Buchholz has refreshed the contents of this pull request, and previous
commits have been removed. The incremental views will show differences compared
to the previous content of the PR. The pull request contains o
> 8246585: ForkJoin updates
Martin Buchholz has refreshed the contents of this pull request, and previous
commits have been removed. The incremental views will show differences compared
to the previous content of the PR. The pull request contains one new commit
since the last revision:
JDK-8
> 8234131: Miscellaneous changes imported from jsr166 CVS 2020-12
Martin Buchholz has refreshed the contents of this pull request, and previous
commits have been removed. The incremental views will show differences compared
to the previous content of the PR. The pull request contains one new com
OK, thanks, good information. Clearly support for named groups is the most important
thing missing from MatchResult.
s'marks
On 12/4/20 11:43 PM, Cay Horstmann wrote:
Hi Stuart,
1: If there is no match at all, then results yields the empty stream. I don't think
anything else is required.
2
> This rewrites the doc of ArraysSupport.newLength, adds detail to the
> exception message, and adds a test. In addition to some renaming and a bit of
> refactoring of the actual code, I also made two changes of substance to the
> code:
>
> 1. I fixed a problem with overflow checking. In the or
> Start of JDK 17 updates.
Joe Darcy has updated the pull request with a new target base due to a merge or
a rebase. The incremental webrev excludes the unrelated changes brought in by
the merge/rebase. The pull request contains 10 additional commits since the
last revision:
- Merge branch 'm
> 8254350: CompletableFuture.get may swallow InterruptedException
Martin Buchholz has refreshed the contents of this pull request, and previous
commits have been removed. The incremental views will show differences compared
to the previous content of the PR. The pull request contains one new com
On Mon, 7 Dec 2020 21:14:55 GMT, Joe Darcy wrote:
>> test/jdk/java/lang/module/ClassFileVersionsTest.java line 107:
>>
>>> 105: { 61, 0, Set.of(STATIC, TRANSITIVE) },
>>> 106:
>>> 107: { 62, 0, Set.of()}, // JDK 18
>>
>> This seems un
On Tue, 8 Dec 2020 03:00:34 GMT, Athijegannathan Sundararajan
wrote:
>> Safe URI encode logic adopted from UnixUriUtils.
>
> Athijegannathan Sundararajan has updated the pull request incrementally with
> one additional commit since the last revision:
>
> renamed the test as per review commen
On Tue, 8 Dec 2020 02:55:43 GMT, Athijegannathan Sundararajan
wrote:
>> test/jdk/jdk/internal/jrtfs/Test8242258.java line 60:
>>
>>> 58: { "xyz ", "jrt:/xyz%20" },
>>> 59: { "xy z", "jrt:/xy%20z" },
>>> 60: };
>>
>> One other thing we test here is a malformed es
On Tue, 8 Dec 2020 06:30:28 GMT, Martin Buchholz wrote:
>> 8254350: CompletableFuture.get may swallow InterruptedException
>
> Martin Buchholz has refreshed the contents of this pull request, and previous
> commits have been removed. The incremental views will show differences
> compared to the
87 matches
Mail list logo