RE: 8201226 missing JNIEXPORT / JNICALL at some places in function declarations/implementations - was : RE: missing JNIEXPORT / JNICALL at some places in function declarations/implementations

Hi Phil/Alexey, thanks for adding the other lists . > Is this the current version of the change : > http://cr.openjdk.java.net/~mbaesken/webrevs/8201226.2/ ? Yes. Best regards, Matthias > -Original Message- > From: Alexey Ivanov [mailto:alexey.iva...@oracle.com] > Sent:

Re: RFR: 8201274: Launch Single-File Source-Code Programs

On 4/13/18 4:15 AM, Jonathan Gibbons wrote: Please review an initial implementation for the feature described in JEP 330: Launch Single-File Source-Code Programs. The work is described in the JEP and CSR, and falls into various parts:  * The part to handle the new command-line options is in

Re: RFR: 8184692: add Pattern.asMatchPredicate

Thanks Vivek, Looks good to me. On 4/12/18 9:25 PM, Vivek Theeyarath wrote: Hi Roger, Please find the updated webrev http://cr.openjdk.java.net/~vtheeyarath/8184692/webrev.04/ . I fixed the indentation with my earlier fix

RE: RFR: 8184692: add Pattern.asMatchPredicate

Hi Roger,    Please find the updated webrev http://cr.openjdk.java.net/~vtheeyarath/8184692/webrev.04/ . I fixed the indentation with my earlier fix (asPredicate) too. Hope that is fine.   Regards Vivek From: Roger Riggs Sent: Thursday, April 12, 2018 7:43 PM To: Vivek

Re: RFR of JDK-8078221, TEST_BUG: java/rmi/Naming/DefaultRegistryPort.java fails intermittently

Hi Roger, Thank you for reviewing, will push the code after improve the exception message. -Hamlin On 13/04/2018 3:41 AM, Roger Riggs wrote: Hi Hamlin, Looks ok. Please improve the exception message at line 76: to make it clear that the retries were exhausted and not some other cause

[11] RFR: 8201507: Generate alias entries in j.t.f.ZoneName from tzdb at build time

Hi, Please review the fix to the subject issue. While fixing 8189784 [1], I noticed that not only CLDR zones but also tzdb link entries are also hard coded. So I further modified j.t.f.ZoneName to generate tzdb entries at the build time. The issue:

Re: 8201226 missing JNIEXPORT / JNICALL at some places in function declarations/implementations - was : RE: missing JNIEXPORT / JNICALL at some places in function declarations/implementations

On 12/04/2018 21:42, Phil Race wrote: How can JNIEXPORT be different between 32 bit & 64 bit ? I'm sure you saw compilation errors but I don't get why it failed for 32 only. JNICALL (_stdcall) may be unnecessary on 64 bit Windows but that doesn't explain why the 32 bit compiler would

Re: RFR: 8201274: Launch Single-File Source-Code Programs

Looks great - some initial comments (I can't really comment on the launcher changes): * This logic is efficient: int magic = (in.read() << 8) + in.read(); boolean shebang = magic == (('#' << 8) + '!'); but convoluted to read; perhaps could be improved slightly by making '#' << 8) + '!' a

Re: 8201226 missing JNIEXPORT / JNICALL at some places in function declarations/implementations - was : RE: missing JNIEXPORT / JNICALL at some places in function declarations/implementations

How can JNIEXPORT be different between 32 bit & 64 bit ? I'm sure you saw compilation errors but I don't get why it failed for 32 only. JNICALL (_stdcall) may be unnecessary on 64 bit Windows but that doesn't explain why the 32 bit compiler would complain about inconsistent application of

Re: RFR: 8201274: Launch Single-File Source-Code Programs

On 2018-04-12 22:15, Jonathan Gibbons wrote: Please review an initial implementation for the feature described in JEP 330: Launch Single-File Source-Code Programs. The work is described in the JEP and CSR, and falls into various parts:  * The part to handle the new command-line options is in

RFR: 8201274: Launch Single-File Source-Code Programs

Please review an initial implementation for the feature described in JEP 330: Launch Single-File Source-Code Programs. The work is described in the JEP and CSR, and falls into various parts: * The part to handle the new command-line options is in the native Java launcher code. * The part

Re: RFR of JDK-8078221, TEST_BUG: java/rmi/Naming/DefaultRegistryPort.java fails intermittently

Hi Hamlin, Looks ok. Please improve the exception message at line 76: to make it clear that the retries were exhausted and not some other cause or exception. Thanks, Roger On 4/11/2018 10:47 PM, Hamlin Li wrote: would you please review the following patch? bug:

Re: RFR: JDK-8201443: NoSuchMethodException JarFile.open when jar file is used in classpath

+1 /Claes On 2018-04-12 21:25, Roger Riggs wrote: Looks good,  Thanks Sherman On 4/12/2018 2:43 PM, Xueming Shen wrote: Hi, Please help review the change for JDK-8201443 issue: https://bugs.openjdk.java.net/browse/JDK-8201443 webrev: http://cr.openjdk.java.net/~sherman/8201443/webrev (1)

Re: RFR: JDK-8201443: NoSuchMethodException JarFile.open when jar file is used in classpath

Looks good,  Thanks Sherman On 4/12/2018 2:43 PM, Xueming Shen wrote: Hi, Please help review the change for JDK-8201443 issue: https://bugs.openjdk.java.net/browse/JDK-8201443 webrev: http://cr.openjdk.java.net/~sherman/8201443/webrev (1) To use

RFR: JDK-8201443: NoSuchMethodException JarFile.open when jar file is used in classpath

Hi, Please help review the change for JDK-8201443 issue: https://bugs.openjdk.java.net/browse/JDK-8201443 webrev: http://cr.openjdk.java.net/~sherman/8201443/webrev (1) To use SharedSecret/JavaLangAccess/Class.getDeclaredPublicMethods to avoid NoSuchMethodExcetpion throwing. (2) Given

Re: 8194734 : Handle to jimage file inherited into child processes (win)

I'm still puzzled by the Unix change. I completely agree with Martin about CLOSEXEC but there is something fishy here that we need to get a handle on. When we fork then we close >= 3 in the child so there shouldn't be any magic with fd 3. The current code closes >= 4. FD 3 is a special one

Re: RFR [10] 8194554: filterArguments runs multiple filters in the wrong order

On 04/12/2018 08:23 PM, joe darcy wrote: > I've manually created a CSR for this issue and linked it in to the backport; > HTH, Thank you Joe! -Aleksey

Re: RFR [10] 8194554: filterArguments runs multiple filters in the wrong order

I've manually created a CSR for this issue and linked it in to the backport; HTH, -Joe On 4/12/2018 11:15 AM, joe darcy wrote: On 4/12/2018 11:11 AM, Aleksey Shipilev wrote: On 04/12/2018 07:43 PM, Paul Sandoz wrote: Sorry to be the bearer of more bureaucratic news i just found out we

Re: 8194734 : Handle to jimage file inherited into child processes (win)

Please get Windows change applied. I'm mostly interested in this part, because bug is currently hidden on Unix. I'm still puzzled by the Unix change. I completely agree with Martin about CLOSEXEC but there is something fishy here that we need to get a handle on. When we fork then we close >=

Re: Missing many locales support on AIX platform

Please review this patch for this issue. I have added IBM-943C as well to standard charset along with IBM-943. # HG changeset patch # User bhamaram # Date 1523510846 -19800 # Thu Apr 12 10:57:26 2018 +0530 # Node ID a76dd37b1c6b47e7ac99f279c4ba76832dd9736f # Parent

Re: 8194734 : Handle to jimage file inherited into child processes (win)

On 12/04/2018 18:38, Alexander Miloslavskiy wrote: I still need someone to get this patch applied. Please? At this moment, it seems that patch is validated: > Martin Buchholz > But regardless of that, we should try to set the CLOEXEC bit on all > our file descriptor > Alan Bateman > The

Re: RFR [10] 8194554: filterArguments runs multiple filters in the wrong order

On 4/12/2018 11:11 AM, Aleksey Shipilev wrote: On 04/12/2018 07:43 PM, Paul Sandoz wrote: Sorry to be the bearer of more bureaucratic news i just found out we require a CSR for 10 as well… which means you need to explicitly create a back port issue for 10 and hook the CSR for 10 to that

Re: RFR [10] 8194554: filterArguments runs multiple filters in the wrong order

On 04/12/2018 07:43 PM, Paul Sandoz wrote: > Sorry to be the bearer of more bureaucratic news i just found out we require > a CSR for 10 as > well… which means you need to explicitly create a back port issue for 10 and > hook the CSR for 10 > to that (there may be some small consolation that the

Re: RFR [10] 8194554: filterArguments runs multiple filters in the wrong order

Hi Aleksey, Sorry to be the bearer of more bureaucratic news i just found out we require a CSR for 10 as well… which means you need to explicitly create a back port issue for 10 and hook the CSR for 10 to that (there may be some small consolation that the CSR for 11 can be mostly copied

Re: 8194734 : Handle to jimage file inherited into child processes (win)

I still need someone to get this patch applied. Please? At this moment, it seems that patch is validated: > Martin Buchholz > But regardless of that, we should try to set the CLOEXEC bit on all > our file descriptor > Alan Bateman > The update to osSupport_Windows.cpp looks okay.

Re: RFR [10] 8194554: filterArguments runs multiple filters in the wrong order

Thanks Mandy! I added the comments to the JBS issue, hoping that would be enough to get the backport moving. -Aleksey On 04/12/2018 12:24 PM, mandy chung wrote: > I was on vacation last week.  Paul - thanks for submitting CSR for > JDK-8194554 for the resulting > behavioral change. > > This

Re: 8201226 missing JNIEXPORT / JNICALL at some places in function declarations/implementations - was : RE: missing JNIEXPORT / JNICALL at some places in function declarations/implementations

> On Apr 12, 2018, at 11:54 21AM, Iris Clark wrote: > > Hi. > > I believe that the internal page Christian references is for the test system. > > If you want to know whether the push arrived in the repository, you could > subscribe to

Re: RFR: 8184692: add Pattern.asMatchPredicate

Ok, thanks. When the CSR is approved please directly send me an exported changeset and i will push for you. Paul. > On Apr 12, 2018, at 5:49 AM, Vivek Theeyarath > wrote: > > Hi, > I have updated the doc as per the suggestion. Have finalized the csr >

RE: 8201226 missing JNIEXPORT / JNICALL at some places in function declarations/implementations - was : RE: missing JNIEXPORT / JNICALL at some places in function declarations/implementations

Hi. I believe that the internal page Christian references is for the test system. If you want to know whether the push arrived in the repository, you could subscribe to jdk-submit-chan...@openjdk.java.net. The archive of recent push notifications is public:

Re: RFR: 8184692: add Pattern.asMatchPredicate

Hi Vivek, ok, Generally, I like to see an updated webrev so that an old non-final webrev isn't left around to be a source of questions. Its easy enough to create a simple script to create the webrev and copy it to cr.openjdk... Continued javadoc @xxx lines should be indented to improve

Re: 8201226 missing JNIEXPORT / JNICALL at some places in function declarations/implementations - was : RE: missing JNIEXPORT / JNICALL at some places in function declarations/implementations

> On Apr 12, 2018, at 9:07 48AM, Baesken, Matthias > wrote: > >> Your submit job ran without failures, we were doing maintenance on the jdk- >> submit repo yesterday and had turned off notifications. Sorry for the >> inconvenience. > > Hi Christian , Thanks for the

RE: 8201226 missing JNIEXPORT / JNICALL at some places in function declarations/implementations - was : RE: missing JNIEXPORT / JNICALL at some places in function declarations/implementations

> Your submit job ran without failures, we were doing maintenance on the jdk- > submit repo yesterday and had turned off notifications. Sorry for the > inconvenience. Hi Christian , Thanks for the information about the submit job success. Is there a way to check (e.g. webpage) that a submit

RE: RFR: 8184692: add Pattern.asMatchPredicate

Hi, I have updated the doc as per the suggestion. Have finalized the csr too. Regards Vivek -Original Message- From: Paul Sandoz Sent: Thursday, April 12, 2018 12:40 AM To: Vivek Theeyarath Cc: Roger Riggs ; Core-Libs-Dev

Re: 8201226 missing JNIEXPORT / JNICALL at some places in function declarations/implementations - was : RE: missing JNIEXPORT / JNICALL at some places in function declarations/implementations

Hi Matthias, On 12/04/2018 11:12, Alexey Ivanov wrote: Hi Matthias, On 12/04/2018 08:49, Baesken, Matthias wrote: Hi,  could  someone please  sponsor  the change  now ? According to OpenJDK Census page [1], you have committer rights to JDK project. And  could someone please check  what

RE: 8201226 missing JNIEXPORT / JNICALL at some places in function declarations/implementations - was : RE: missing JNIEXPORT / JNICALL at some places in function declarations/implementations

Hi Alan , this is the up to date webrev . However we want to add Alexey Ivanov as additional author . > > As I read it, this changes the calling convention of these functions on > 32-bit Windows but it will have no impact on 64-bit Windows (as > __stdcall is ignored) or other platforms,

Re: 8201226 missing JNIEXPORT / JNICALL at some places in function declarations/implementations - was : RE: missing JNIEXPORT / JNICALL at some places in function declarations/implementations

Adding core-libs-dev as this is change code in libjava, libzip, libjimage, ... Can you confirm that this is the up to date webrev:    http://cr.openjdk.java.net/~mbaesken/webrevs/8201226.2/ As I read it, this changes the calling convention of these functions on 32-bit Windows but it will have

Re: RFR [10] 8194554: filterArguments runs multiple filters in the wrong order

I was on vacation last week.  Paul - thanks for submitting CSR for JDK-8194554 for the resulting behavioral change. This backport looks good to me. Thanks Mandy On 4/5/18 11:33 PM, Aleksey Shipilev wrote: Hi, Please review this jdk10 backport. Original JDK 11 bug:

Re: Missing many locales support on AIX platform

Patch I attached to previous mail is not seen. So, pasting patch here. Hope, it is fine. # HG changeset patch # User bhamaram # Date 1523510846 -19800 # Node ID 6134bbe986f8cc42b055081f2c48e91039a8 # Parent 0c3e252cea44f06aef570ef464950ab97c669970 java.lang.IllegalArgumentException from

Re: RFR: 8198793:Add launcher support for preview features

On 4/12/18 4:43 AM, Kumar Srinivasan wrote: Hello, Could I get a review to update the launcher help message. https://bugs.openjdk.java.net/browse/JDK-8198793 diff --git a/src/java.base/share/classes/sun/launcher/resources/launcher.properties

Missing many locales support on AIX platform

Hi, On AIX platforms, Java is not starting on many locales. Java initialization fails with java.lang.IllegalArgumentException bash-4.4$ LANG=Ja_JP java -version Error occurred during initialization of VM java.lang.IllegalArgumentException: Null charset name at

Re: Clean-room implementation of Double::toString(double) and Float::toString(float)

Hi, my code is now ready to be uploaded to the OpenJDK reps. Currently it resides on GitHub and is under the "GPLv2 + Classpath Exception" license, with myself as the copyright holder. I asked Oracle about how the copyright notice should be adapted to meet the OCA requirements but, as of