,
if there is interest ( could not really find one that tests execution of a
simple jar-file with jexec).
Best regards, Matthias
From: Baesken, Matthias
Sent: Donnerstag, 23. Februar 2017 07:39
To: 'core-libs-dev@openjdk.java.net' <core-libs-dev@openjdk.java.net>
Cc: Langer, Christoph <christoph.lan..
error
with the fix :
jdk/lib/jexec/java_test/hellojar/helloworld.jar
Hello world from a jar file
And btw I really wonder - is jexec still needed in future jdk's like jdk10 ?
Seems it is not used much .
Best regards, Matthias
From: Baesken, Matthias
Sent: Mittwoch, 22. Februar 2017 18
n [mailto:erik.joels...@oracle.com]
Sent: Donnerstag, 9. Februar 2017 13:42
To: Baesken, Matthias <matthias.baes...@sap.com>; build-...@openjdk.java.net
Cc: Langer, Christoph <christoph.lan...@sap.com>
Subject: Re: jdk10 : simplify jexec build settings
Hello,
On 2017-02-09 12:
of jexec.c for macosx one day
again).
Comments / suggestions ?
Best regards, Matthias
From: Baesken, Matthias
Sent: Donnerstag, 9. Februar 2017 14:10
To: 'Erik Joelsson' <erik.joels...@oracle.com>; build-...@openjdk.java.net;
'core-libs-dev@openjdk.java.net' <core-libs-dev@openjdk.jav
with the change 8156478: 3 Buffer overrun defect groups in
jexec.c )
Executing a helloworld.jar with jexec leads to
"invalid file (bad magic number): Exec format error" .
Should I open another bug for this ?
Best regards, Matthias
From: Baesken, Matthias
Sent: F
s a separate issue and not really build related.
/Erik
On 2017-02-14 17:27, Baesken, Matthias wrote:
Hello, here is the webrev :
http://cr.openjdk.java.net/~mbaesken/webrevs/8174242/<http://cr.openjdk.java.net/%7Embaesken/webrevs/8174242/>
bug :
https://bugs.openjdk.java.net/browse/JDK-81
bruar 2017 09:49
To: Baesken, Matthias <matthias.baes...@sap.com>; build-...@openjdk.java.net;
core-libs-dev@openjdk.java.net
Cc: Langer, Christoph <christoph.lan...@sap.com>
Subject: Re: jdk10 : simplify jexec build settings
Since the file has never been built, I would say remove
eller, Arno <arno.zel...@sap.com>; Baesken, Matthias
> <matthias.baes...@sap.com>; core-libs-dev@openjdk.java.net
> Subject: RE: rmid on Unix fails with Exception - maybe aftermath of JDK-
> 8173607 ??
>
> The colleagues tell me that it was about two weeks ago. But
Ping ...
Can I get a review please for the change ?
Thanks, Matthias
From: Baesken, Matthias
Sent: Donnerstag, 23. Februar 2017 12:28
To: 'core-libs-dev@openjdk.java.net' <core-libs-dev@openjdk.java.net>
Cc: Langer, Christoph <christoph.lan...@sap.com>; Erik Joelsson
(erik.joels..
change ?
Regards, Matthias
From: Thomas Stüfe [mailto:thomas.stu...@gmail.com]
Sent: Mittwoch, 1. März 2017 12:47
To: Baesken, Matthias <matthias.baes...@sap.com>
Cc: core-libs-dev@openjdk.java.net; Simonis, Volker <volker.simo...@sap.com>
Subject: Re: RFR [XS] : 8175000 : jexec fail
h, 1. März 2017 23:22
To: Thomas Stüfe <thomas.stu...@gmail.com>
Cc: Baesken, Matthias <matthias.baes...@sap.com>; Michel Trudeau
<michel.trud...@oracle.com>; core-libs-dev@openjdk.java.net; Simonis, Volker
<volker.simo...@sap.com>
Subject: Re: RFR [XS] : 8175000 : jexec fai
: Dienstag, 18. Juli 2017 15:43
To: Volker Simonis <volker.simo...@gmail.com>
Cc: hotspot-dev Source Developers <hotspot-...@openjdk.java.net>; core-libs-dev
<core-libs-dev@openjdk.java.net>; Baesken, Matthias <matthias.baes...@sap.com>
Subject: Re: JEP [DRAFT]: Container a
Hello all ,
could you please review the following small change.
Some java/awt and javax/swing tests miss the headful jtreg keyword
The change JDK-8129822 ( https://bugs.openjdk.java.net/browse/JDK-8129822 )
introduced a jtreg keyword to mark tests as requiring a "headful" (as opposed
to
Hello all, could I have a review for this small change ?
Thanks, Matthias
From: Langer, Christoph
Sent: Freitag, 30. Juni 2017 23:50
To: Baesken, Matthias <matthias.baes...@sap.com>; awt-...@openjdk.java.net
Cc: core-libs-dev@openjdk.java.net; joe.da...@oracle.com
Subject: RE: RFR: 8
Hello, could you please review this small change :
http://cr.openjdk.java.net/~mbaesken/webrevs/8180413/
it fixes a number of places in jdk.jdwp.agent where in case of an error it
is attempted to write to NULL .
Bug : JDK-8180413 : avoid accessing NULL in jdk.jdwp.agent
Sure, I forward it to serviceability-dev .
-Original Message-
From: Alan Bateman [mailto:alan.bate...@oracle.com]
Sent: Dienstag, 16. Mai 2017 11:51
To: Baesken, Matthias <matthias.baes...@sap.com>; core-libs-dev@openjdk.java.net
Cc: Simonis, Volker <volker.simo...@sap.com>
Great, thanks !
-Original Message-
From: Langer, Christoph
Sent: Donnerstag, 18. Mai 2017 15:27
To: Baesken, Matthias <matthias.baes...@sap.com>
Cc: Simonis, Volker <volker.simo...@sap.com>; Dmitry Samersoff
<dmitry.samers...@oracle.com>; core-libs-dev@openjdk.java.ne
Please review this small test change .
It adds a number of platforms to the existing test jdk10 jtreg test
java/nio/ByteOrder/NativeOrder.java .
Especially the porting platforms ppc64/ppc64le/s390x are added .
Webrev :
http://cr.openjdk.java.net/~mbaesken/webrevs/8181145/
bug :
...@oracle.com]
Sent: Freitag, 19. Mai 2017 02:18
To: Baesken, Matthias <matthias.baes...@sap.com>; Alan Bateman
<alan.bate...@oracle.com>; core-libs-dev@openjdk.java.net;
serviceability-...@openjdk.java.net
Cc: Simonis, Volker <volker.simo...@sap.com>
Subject: Re: [XS] JDK-8180413
I wonder why the display names for timezone MET changed ( I observed this on
Linux and Solaris) when I compare
jdk8 to jdk9 .
The test is very small, it just outputs for Locale.GERMAN the display name.
With jdk8 we get a translated german timezone name, but not with jdk9 (this is
a bit
>> Hi Matthias,
>>
>> I have closed your bug JDK-8188901 in favor of the bug that Sherman had
>> opened before: https://bugs.openjdk.java.net/browse/JDK-8188869.
>>
>> Please post a webrev for the change as suggested by Claes.
>
>Sounds good to me.
>
>In addition to being a cleanup, the
Hello,
When iterating on the zip entries (and printing the time stamps) of an old
sqljdbc.jarthe exception
"java.time.DateTimeException: Invalid value for SecondOfMinute (valid values 0
- 59): 60"
occured (issue has been seen on Windows).
Looks like the dosToJavaTime function in
f) + 80),
> ? (int)(((dtime >> 21) & 0x0f) - 1),
> ? (int)((dtime >> 16) & 0x1f),
> ? (int)((dtime >> 11) & 0x1f),
> ????? (int)((dtime >> 5) & 0x3f),
> ??
> Hi,
>
> please review this bug fix to ensure we don't reject jar
> and zip files due to entries having malformed timestamps.
>
> Webrev: http://cr.openjdk.java.net/~redestad/8188869/jdk.00/
> Bug: https://bugs.openjdk.java.net/browse/JDK-8188869
>
> I opted to only fall back to the
Hello , Mark reported this issue on AIX with OpenJDK8 :
>
>I'm getting an unsatisfied link error when using logstash on AIX but I suspect
>the issue is with AIX or the JRE, the exception is:
>
> java.lang.UnsatisfiedLinkError:
> sun.management.OperatingSystemImpl.getProcessCpuLoad()D
>
.1 ).
Best regards, Matthias
> -Original Message-
> From: Thomas Stüfe [mailto:thomas.stu...@gmail.com]
> Sent: Freitag, 27. April 2018 10:04
> To: Langer, Christoph <christoph.lan...@sap.com>
> Cc: Volker Simonis <volker.simo...@gmail.com>; Baesken, Matth
Hi Christoph can I add you as second reviewer (other reviewer was Erik
Joelsson) can push the change ?
Best regards, Matthias
From: Langer, Christoph
Sent: Donnerstag, 26. April 2018 16:38
To: Baesken, Matthias <matthias.baes...@sap.com>; 'build-...@openjdk.java.net'
Hi, could you please review this small change that improves the error
messages in matchJavaTZ .
A reason of the failure is added to the message , and also the offset where
the error happened .
Bug :
https://bugs.openjdk.java.net/browse/JDK-8204539
Webrev :
: Langer, Christoph
Sent: Donnerstag, 7. Juni 2018 13:52
To: Baesken, Matthias ; core-libs-dev@openjdk.java.net
Cc: Lindenmaier, Goetz
Subject: RE: [RFR] 8204539: improve error messages in matchJavaTZ [windows]
Hi Matthias,
in line 527, where the actual output is done, I think you would need to replace
age-
> From: Lindenmaier, Goetz
> Sent: Freitag, 8. Juni 2018 09:34
> To: Baesken, Matthias ; Langer, Christoph
> ; core-libs-dev@openjdk.java.net;
> 'sean.cof...@oracle.com'
> Subject: RE: [RFR] 8204539: improve error messages in matchJavaTZ
> [windows]
>
> Hi Ma
internal build/tests .
Best regards, Matthias
From: Langer, Christoph
Sent: Donnerstag, 7. Juni 2018 13:52
To: Baesken, Matthias ; core-libs-dev@openjdk.java.net
Cc: Lindenmaier, Goetz
Subject: RE: [RFR] 8204539: improve error messages in matchJavaTZ [windows]
Hi Matthias,
in line 527, where
> From: Langer, Christoph
> Sent: Freitag, 1. Juni 2018 10:57
> To: Ichiroh Takiguchi
> Cc: Baesken, Matthias ; 'build-
> d...@openjdk.java.net' ; ppc-aix-port-
> d...@openjdk.java.net; core-libs-dev@openjdk.java.net; Lindenmaier,
> Goetz
> Subject: RE: RFR : 8202322: AIX: s
Hello, please review this small change that improve exception messages during
manifest parsing of jar archives .
Thanks, Matthias
Bug :
https://bugs.openjdk.java.net/browse/JDK-8205525
Webrev :
http://cr.openjdk.java.net/~mbaesken/webrevs/8205525/
ds, Matthias
> -Original Message-
> From: Alan Bateman [mailto:alan.bate...@oracle.com]
> Sent: Montag, 25. Juni 2018 16:17
> To: Baesken, Matthias ; core-libs-
> d...@openjdk.java.net
> Subject: Re: [RFR] 8205525 : Improve exception messages during manifest
> parsing of jar
viewer however).
Best regards, Matthias
> -Original Message-
> From: Lindenmaier, Goetz
> Sent: Mittwoch, 10. Januar 2018 09:23
> To: core-libs-dev@openjdk.java.net
> Cc: Baesken, Matthias <matthias.baes...@sap.com>
> Subject: RFR(S): 8194869: [TESTBUG][aix, s39
as.stu...@gmail.com]
> Sent: Mittwoch, 20. Juni 2018 14:17
> To: Baesken, Matthias
> Cc: core-libs-dev@openjdk.java.net
> Subject: Re: RFR [XS] : 8205416 : windows: fix checking of CloseHandle return
> code in Java_java_io_FileCleanable_cleanupClose0
>
> Good catch.
>
> Could
jstimesArray) {
510 DIR* dir;
511 struct dirent* ptr;
Not sure if this is really an issue in "real life"
Best regards, Matthias
From: Brian Burkhalter
Sent: Donnerstag, 2. August 2018 16:59
To: Baesken, Matthias
Cc: core-libs-dev@openjdk.java.net; Langer, Christoph
18 14:54
> To: Alan Bateman ; Baesken, Matthias
>
> Cc: core-libs-dev@openjdk.java.net; Lindenmaier, Goetz
>
> Subject: Re: [RFR] 8205525 : Improve exception messages during manifest
> parsing of jar archives
>
>
> > On 19 Jul 2018, at 11:46, Alan Bateman
> wrote:
Hi Brian , I'll build it on AIX + in case it builds fine put it into our
test patch queue .
Best regards , Matthias
>
> --
>
> Message: 1
> Date: Tue, 31 Jul 2018 11:47:57 -0700
> From: Brian Burkhalter
> To: "B.
.01/raw_files/new/src/java.base/unix/native/libjava/ProcessHandleImpl_unix.c
Best regards, Matthias
From: Brian Burkhalter
Sent: Mittwoch, 1. August 2018 16:53
To: Baesken, Matthias
Cc: Langer, Christoph
Subject: Re: [12] (AIX) 8207744: Clean up inconsistent use of opendir/closedir
versus
Sure I'll look into it !
Best regards, Matthias
> -Original Message-
> From: Alan Bateman
> Sent: Mittwoch, 8. August 2018 20:30
> To: Baesken, Matthias ; Chris Hegarty
>
> Cc: core-libs-dev@openjdk.java.net; Lindenmaier, Goetz
> ; Langer, Christoph
> ; OpenJD
regards , Matthias
From: Brian Burkhalter
Sent: Samstag, 4. August 2018 00:08
To: Baesken, Matthias
Cc: core-libs-dev@openjdk.java.net; Langer, Christoph
; Simonis, Volker ;
Lindenmaier, Goetz
Subject: Re: [12] (AIX) 8207744: Clean up inconsistent use of opendir/closedir
versus opendir64
Ping , any reviews / comments ?
Thanks , Matthias
> -Original Message-
> From: Baesken, Matthias
> Sent: Dienstag, 31. Juli 2018 12:28
> To: 'Chris Hegarty' ; Alan Bateman
>
> Cc: core-libs-dev@openjdk.java.net; Lindenmaier, Goetz
> ; Langer, Christoph
&
I
would prefer this .
Best regards, Matthias
> -Original Message-
> From: Sean Mullan
> Sent: Freitag, 10. August 2018 17:39
> To: Baesken, Matthias ; Chris Hegarty
> ; Alan Bateman
> Cc: core-libs-dev@openjdk.java.net; security Dev OpenJDK d...@openjdk.java.net>
)
- read now from the InputStream and check for error conditions *before*
setting jarFilenamein the Manifest constructor
Best regards , Matthias
> -Original Message-
> From: Sean Mullan
> Sent: Freitag, 10. August 2018 17:39
> To: Baesken, Matthias ; Chris Hega
Message-
> From: Alan Bateman
> Sent: Montag, 27. August 2018 15:52
> To: Baesken, Matthias ; Sean Mullan
> ; Chris Hegarty
> Cc: core-libs-dev@openjdk.java.net; security Dev OpenJDK d...@openjdk.java.net>
> Subject: Re: [RFR] 8205525 : Improve exception messages during mani
018 17:35
> To: Baesken, Matthias
> Cc: Alan Bateman ; Sean Mullan
> ; Chris Hegarty ;
> security-...@openjdk.java.net; core-libs-dev@openjdk.java.net
> Subject: Re: [RFR] 8205525 : Improve exception messages during manifest
> parsing of jar archives
>
>
>
>
Looks good to me ( however I am not a Reviewer).
Best regards, Matthias
> -Original Message-
> From: core-libs-dev
> mailto:core-libs-dev-boun...@openjdk.java.net>>
> On Behalf
> Of Lindenmaier, Goetz
> Sent: Mittwoch, 18. Juli 2018 09:28
> To:
Thanks !
Sherman - are you fine with the latest version , if so I would push it .
Best regards, Matthias
> -Original Message-
> From: Lindenmaier, Goetz
> Sent: Freitag, 20. Juli 2018 09:38
> To: Baesken, Matthias ; core-libs-
> d...@openjdk.java.net; xueming.s...@oracl
Hi Chris, thanks for starting the new RFR for to generalization of the
`includeInExceptions` security property:
Best regards, Matthias
> -Original Message-
> From: Chris Hegarty [mailto:chris.hega...@oracle.com]
> Sent: Freitag, 20. Juli 2018 13:41
> To: Alan Batem
ability-
> d...@openjdk.java.net ; core-libs-
> dev
> Cc: Baesken, Matthias ; Schmidt, Lutz
>
> Subject: RFR: 8206456 - [TESTBUG] docker jtreg tests fail on systems without
> cpuset.effective_cpus / cpuset.effective_mem
>
> Please review this fix which eliminates some docker/cgroup t
Sent: Mittwoch, 18. Juli 2018 15:05
> To: Baesken, Matthias
> Cc: Lindenmaier, Goetz ; core-libs-
> d...@openjdk.java.net
> Subject: Re: RFR : 8207395: jar has issues with UNC-path arguments for the
> jar -C parameter [windows]
>
> That gives a different result.
>
ke to
enhance , so this has to be checked first .
Best regards, Matthias
> -Original Message-
> From: Alan Bateman [mailto:alan.bate...@oracle.com]
> Sent: Dienstag, 17. Juli 2018 13:39
> To: Baesken, Matthias ; core-libs-
> d...@openjdk.java.net
> Subject: Re: [RFR] 8205525
t;> }
> >> -
> >> pathsMap.get(version).add(dir.replace(File.separatorChar, '/'));
> >> + // Restore the second leading '/' needed for
> >> the Windows UNC path.
> >> +dir = unc + dir
: Mittwoch, 18. Juli 2018 19:44
> To: Baesken, Matthias ; core-libs-
> d...@openjdk.java.net; Lindenmaier, Goetz
> Subject: Re: [RFR] 8205525 : Improve exception messages during manifest
> parsing of jar archives
>
> On 18/07/2018 09:21, Baesken, Matthias wrote:
> > Hi Alan, I
ed
socket exceptions ) .
The line number is always printed .
Best regards, Matthias
> -Original Message-
> From: Baesken, Matthias
> Sent: Dienstag, 10. Juli 2018 11:53
> To: 'Alan Bateman' ; core-libs-
> d...@openjdk.java.net; 'jai.forums2...@gmail.com'
>
> Cc: Li
Please review this small fix for allowing windows UNC paths in the jar -C
parameter.
Currently passing a UNC path to a directory with -Cfails :
c:\testdir>c:\tools\jdk10\bin\jar.exe test.jar -C \\MYMACHINE\subdir README.txt
Illegal option: s
Try `jar --help' for more information.
egards, Matthias
> -Original Message-
> From: Lindenmaier, Goetz
> Sent: Mittwoch, 18. Juli 2018 11:32
> To: Baesken, Matthias ; core-libs-
> d...@openjdk.java.net
> Subject: RE: RFR : 8207395: jar has issues with UNC-path arguments for the
> jar -C parameter [windows]
Hi Max, thanks for adding yourself as a reviewer.
I set the CSR ( https://bugs.openjdk.java.net/browse/JDK-8207768 ) to
proposed.
Best regards, Matthias
>
> Message: 2
> Date: Tue, 4 Sep 2018 21:31:58 +0800
> From: Weijun Wang
> To: "Baesken, Matthi
n() {
214 return "manifest of " + file.getName() + ":" + lineNumber;
215 }
Best regards, Matthias
> -Original Message-
> From: Wang Weijun
> Sent: Samstag, 8. September 2018 17:43
> To: Sean Mullan
> Cc: Baesken, Matthias
ph
> Sent: Montag, 10. September 2018 10:04
> To: Baesken, Matthias ; Wang Weijun
> ; Sean Mullan
> Cc: security-...@openjdk.java.net; core-libs-dev@openjdk.java.net
> Subject: RE: [RFR] 8205525 : Improve exception messages during manifest
> parsing of jar archives
&g
ction and just return "filename" as
is.)
After the changes I wonder - should the jarPath category be renamed to
jarFile (or something else) ?
Best regards, Matthias
> -Original Message-
> From: Langer, Christoph
> Sent: Montag, 10. September 2018 10:04
> To: Baes
egards, Matthias
> -Original Message-
> From: Weijun Wang
> Sent: Freitag, 31. August 2018 04:32
> To: Baesken, Matthias
> Cc: Alan Bateman ; Sean Mullan
> ; Chris Hegarty ;
> security-...@openjdk.java.net; core-libs-dev@openjdk.java.net
> Subject: Re: [RFR] 8
; -Original Message-
> From: Weijun Wang
> Sent: Montag, 3. September 2018 17:14
> To: Baesken, Matthias
> Cc: Alan Bateman ; Sean Mullan
> ; Chris Hegarty ;
> security-...@openjdk.java.net; core-libs-dev@openjdk.java.net
> Subject: Re: [RFR] 8205525 : Improve exceptio
Hello, please check the new webrev :
http://cr.openjdk.java.net/~mbaesken/webrevs/8205525.10/
I kept the jarPath category name .
Best regards, Matthias
> -Original Message-
> From: Langer, Christoph
> Sent: Montag, 10. September 2018 21:30
> To: Weijun Wang ; Baesk
> I don't have a strong opinion on making Manifest.jarFilename final
Hi, just making it final leads to compile errors anyway.
Best regards, Matthias
> -Original Message-
> From: Weijun Wang
> Sent: Dienstag, 11. September 2018 13:04
> To: Baesken, Matthias
> Cc:
8 09:36
> To: Baesken, Matthias ; core-libs-
> d...@openjdk.java.net
> Cc: Lindenmaier, Goetz
> Subject: Re: [RFR] 8205525 : Improve exception messages during manifest
> parsing of jar archives
>
> On 06/07/2018 13:44, Baesken, Matthias wrote:
> > Hi Alan ,so it loo
018 16:52
> To: Baesken, Matthias ; core-libs-
> d...@openjdk.java.net
> Cc: Lindenmaier, Goetz
> Subject: Re: [RFR] 8205525 : Improve exception messages during manifest
> parsing of jar archives
>
> On 25/06/2018 15:29, Baesken, Matthias wrote:
> > Hi, do you consider
other platforms (fixes the
mismatches) .
Best regards, Matthias
> -Original Message-
> From: Alan Bateman [mailto:alan.bate...@oracle.com]
> Sent: Donnerstag, 12. April 2018 12:54
> To: Baesken, Matthias <matthias.baes...@sap.com>; Magnus Ihse Bursie
> <mag
a submit job has "arrived" and
is queued for build/test ?
Would have been helpful in this situation .
Best regards, Matthias
> -Original Message-
> From: Christian Tornqvist [mailto:christian.tornqv...@oracle.com]
> Sent: Donnerstag, 12. April 2018 14:58
> To: B
ent: Donnerstag, 12. April 2018 23:53
> To: Phil Race <philip.r...@oracle.com>; Baesken, Matthias
> <matthias.baes...@sap.com>; Alan Bateman <alan.bate...@oracle.com>;
> Magnus Ihse Bursie <magnus.ihse.bur...@oracle.com>
> Cc: build-...@openjdk.java.net; core-li
Hello , could you please review this small adjustment to the symbol
visibility compilation settings on AIX ?
Currently we use XLC 12.1 to compile JDK on AIX .
However XLC 12.1 does not support the "-qvisibility=hidden" setting
currently set on AIX.
It was introduced with XLC 13.1 .
ant to remove the flags .
( waiting for the feedback of Bhaktavatsal Reddy , in case he prefers it I
remove them for all xlC versions including 13.1 )
Best regards, Matthias
From: Langer, Christoph
Sent: Donnerstag, 26. April 2018 16:38
To: Baesken, Matthias <matthias.baes...@
t;
completely for xlc (and not only for xlc12.1) ?
(we currently compile only with XLC 12.1 , there might be more issues
with 13.1 )
Best regards, Matthias
> -Original Message-
> From: Bhaktavatsal R Maram [mailto:bhama...@in.ibm.com]
> Sent: Donnerstag, 26. April 2
Please review this small fix for a return code handling of windows function
CloseHandle .
MSDN documents CloseHandle here :
https://msdn.microsoft.com/de-de/library/windows/desktop/ms724211(v=vs.85).aspx
Return value
If the function succeeds, the return value is nonzero.
If the
n .
Best regards, Matthias
> -Original Message-
> From: Baesken, Matthias
> Sent: Dienstag, 2. Oktober 2018 17:03
> To: Bob Vandette
> Cc: hotspot-...@openjdk.java.net; core-libs-dev@openjdk.java.net;
> Moldenhauer, Niclas
> Subject: RE: RFR : 8211106: [windows] Update OS detection
I got the info that the GA of Windows Server 2019 has build number 17763
.
Should I update the webrev to check this build number (would mean we do not
detect the preview as Windows Server 2019) , or keep it the way it is ?
Current webrev :
for the list of build numbers )
Thanks, Matthias
> -Original Message-
> From: Baesken, Matthias
> Sent: Freitag, 12. Oktober 2018 08:57
> To: 'Bob Vandette'
> Cc: 'hotspot-...@openjdk.java.net' ;
> 'core-libs-dev@openjdk.java.net' ;
> Langer, Christoph
> Su
ore backporting it to jdk11u .
Best regards, Matthias
> -Original Message-
> From: Alan Bateman
> Sent: Samstag, 20. Oktober 2018 10:06
> To: Baesken, Matthias
> Cc: hotspot-dev Source Developers ; core-
> libs-...@openjdk.java.net; Moldenhauer, Niclas
>
>
Exceptions=hostInfo,jar,ioExceptionsWithPath
Thanks, Matthias
From: Baesken, Matthias
Sent: Dienstag, 9. Oktober 2018 14:12
To: security-...@openjdk.java.net; core-libs-dev@openjdk.java.net
Cc: Alan Bateman (alan.bate...@oracle.com)
Subject: FW: RFR: 8211752: JNU_ThrowIOExceptionWithLastErrorAndPath
ards ,
Matthias
From: Alan Bateman
Sent: Freitag, 12. Oktober 2018 11:18
To: Baesken, Matthias ;
security-...@openjdk.java.net; core-libs-dev@openjdk.java.net
Subject: Re: RFR: 8211752: JNU_ThrowIOExceptionWithLastErrorAndPath - enhance
some IOExceptions with path causing the issue
Hi Volker, looks good (not a Reviewer however) !
Maybe you should also adjust the Copyright year info in the files you touched .
Best regards, Matthias
-Original Message-
Hi,
can I please have a review for the following tiny change which fixes
the license header on a few
s/8211106.2/
Best regards, Matthias
From: Bob Vandette
Sent: Donnerstag, 18. Oktober 2018 16:36
To: Baesken, Matthias
Cc: hotspot-...@openjdk.java.net; core-libs-dev@openjdk.java.net; Langer,
Christoph
Subject: Re: RFR : 8211106: [windows] Update OS detection code to recognize
Windows
the other places too ).
Thanks, Matthias
> -Original Message-
> From: Sean Mullan
> Sent: Freitag, 12. Oktober 2018 17:19
> To: Langer, Christoph ; Baesken, Matthias
> ; Alan Bateman ;
> security-...@openjdk.java.net; core-libs-dev@openjdk.java.net
> Subject: Re: RFR
2019, ... "
Alan / Bob - can I you as reviewers ?
Best regards , Matthias
> -Original Message-
> From: Alan Bateman
> Sent: Samstag, 20. Oktober 2018 10:06
> To: Baesken, Matthias
> Cc: hotspot-dev Source Developers ; core-
> libs-...@openjdk.java.net; Moldenhauer,
Thanks for the reviews !
> -Original Message-
> From: Alan Bateman
> Sent: Donnerstag, 15. November 2018 11:08
> To: Baesken, Matthias ; Langer, Christoph
>
> Subject: Re: FW: RFR : 8211106: [windows] Update OS detection code to
> recognize Windows Server 2019
>
messages to the
java.security file .
Best regards, Matthias
From: Baesken, Matthias
Sent: Dienstag, 9. Oktober 2018 13:40
To: core-libs-dev@openjdk.java.net
Cc: Langer, Christoph ; Lindenmaier, Goetz
Subject: RFR: 8211752: JNU_ThrowIOExceptionWithLastErrorAndPath - enhance some
IOExceptions
Hello, please review the following change .
It enhances a number of JNU_ThrowIOExceptionWithLastError calls with path and
current working directory information.
For this, a new function JNU_ThrowIOExceptionWithLastErrorAndPath is added.
bug and webrev :
Hello, please review change 8211106 .
It updates the Windows OS detection code to recognize Windows Server 2019 .
For this we have to look at the build number (dwBuildNumber of
OSVERSIONINFOEX),
https://docs.microsoft.com/en-us/windows/desktop/api/Winnt/ns-winnt-_osversioninfoexa
build number 17677 ( Windows Server 2019
preview , seems older than what you are seeing)
and 17723 .
Best regards, Matthias
> -Original Message-
> From: Bob Vandette
> Sent: Dienstag, 2. Oktober 2018 16:09
> To: Baesken, Matthias
> Cc: hotspot-...@openjdk.java.n
k like? Is it "/tmp/x.jar:100"?
>
Yes it look like this :
line too long (/testdata/jars/file_with_long_line_1.jar:2)
Best regards, Matthias
> -Original Message-
> From: Weijun Wang
> Sent: Mittwoch, 29. August 2018 16:27
> To: Baesken, Matthias
> Cc: Alan Batem
String run() {
return file.getAbsolutePath() + "!META-INF/MANIFEST.MF line:"
+ lineNumber;
}
.
Best regards, Matthias
> -Original Message-
> From: Weijun Wang
> Sent: Donnerstag, 30. August 2018 16:04
> To: Baesken, Matthias
st regards, Matthias
> -Original Message-
> From: Weijun Wang
> Sent: Freitag, 31. August 2018 15:53
> To: Baesken, Matthias
> Cc: Alan Bateman ; Sean Mullan
> ; Chris Hegarty ;
> security-...@openjdk.java.net; core-libs-dev@openjdk.java.net
> Subject: Re: [RFR]
Hello, could you please review this small change (windows only) ?
Currently, the function "getJavaIDFromLangID"(located in windows
java_props_md.c)
only does proper deallocations after a successful call to the function
SetupI18nProps. See
if (SetupI18nProps(MAKELCID(langID,
Hi, thanks for your comments, I posted a second webrev :
http://cr.openjdk.java.net/~mbaesken/webrevs/8211149.1/webrev/
Best regards, Matthias
> -Original Message-
> From: naoto.s...@oracle.com
> Sent: Mittwoch, 26. September 2018 18:49
> To: Baesken, Matthias ; co
> -Original Message-
> From: Alan Bateman
> Sent: Mittwoch, 16. Januar 2019 10:37
> To: Baesken, Matthias ; core-libs-
> d...@openjdk.java.net
> Subject: Re: RFR : 8217093: Support extended-length paths in
> parse_manifest.c on windows
>
> On 16/01/2019 09:07, Baes
Mittwoch, 16. Januar 2019 16:43
> To: Baesken, Matthias ; core-libs-
> d...@openjdk.java.net
> Subject: Re: RFR : 8217093: Support extended-length paths in
> parse_manifest.c on windows
>
> On 16/01/2019 14:43, Baesken, Matthias wrote:
> > Hi Alan , do you
Hello, please review this small adjustment to parse_manifest.c .
It adds support for extended - length paths (on Window) .
(see
https://docs.microsoft.com/en-us/windows/desktop/fileio/naming-a-file#maximum-path-length-limitation
For extended length paths )
Additionally , some small
man
> Sent: Mittwoch, 16. Januar 2019 09:51
> To: Baesken, Matthias ; core-libs-
> d...@openjdk.java.net
> Subject: Re: RFR : 8217093: Support extended-length paths in
> parse_manifest.c on windows
>
> On 16/01/2019 08:42, Baesken, Matthias wrote:
> > Hello, please
gt; -Original Message-----
> From: Sean Mullan
> Sent: Donnerstag, 8. November 2018 20:36
> To: Baesken, Matthias ; Langer, Christoph
> ; Alan Bateman ;
> security-...@openjdk.java.net; core-libs-dev@openjdk.java.net
> Subject: Re: RFR: 8211752: JNU_ThrowIOExceptionWithLastErr
1 - 100 of 179 matches
Mail list logo
