Hi,
As discussed in the
https://mail.openjdk.java.net/pipermail/core-libs-dev/2021-July/079621.html
thread, this is the revised patch to address the use of '.' and '..' within Zip
FS
Zip FS needs to use "." and ".." as links to the current and parent directories
and cannot reliably support
On Thu, 22 Jul 2021 01:46:09 GMT, Ian Graves wrote:
>> 8199594: Add doc describing how (?x) ignores spaces in character classes
>
> Ian Graves has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Rewording repetitive phrase
Marked as reviewed
On Fri, 23 Jul 2021 15:23:07 GMT, Jaikiran Pai wrote:
> Thank you for the review Alan.
>
> @LanceAndersen, I've run the tier1 tests locally with the latest PR and they
> have passed without any regressions. Given that we changed the implementation
> to wrap ByteArrayOutputStream instead of
On Wed, 21 Jul 2021 21:25:18 GMT, Ian Graves wrote:
>> 8199594: Add doc describing how (?x) ignores spaces in character classes
>
> Ian Graves has updated the pull request incrementally with one additional
> commit since the last revision:
>
> delete errant line
On Mon, 5 Jul 2021 07:42:26 GMT, Jaikiran Pai wrote:
>> Can I please get a review for this proposed fix for the issue reported in
>> https://bugs.openjdk.java.net/browse/JDK-8190753?
>>
>> The commit here checks for the size of the zip entry before trying to create
>> a
st run going and will finish my review later today or tomorrow
Best
Lance
-Jaikiran
[cid:E1C4E2F0-ECD0-4C9D-ADB4-B16CA7BCB7FC@home]
Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@orac
On Fri, 2 Jul 2021 16:58:18 GMT, Brian Burkhalter wrote:
>> Modify the specification of
>> `java.io.ByteArrayInputStream#read(byte[],int,int)` to indicate that `-1` is
>> returned instead of `0` when the stream is at its end and the third
>> parameter, `len`, is zero.
>
> Brian Burkhalter has
On Jul 2, 2021, at 12:13 PM, Lance Andersen
mailto:lance.ander...@oracle.com>> wrote:
On Jul 2, 2021, at 8:08 AM, Jaikiran Pai
mailto:jai.forums2...@gmail.com>> wrote:
Hello Lance,
On 02/07/21 4:42 pm, Lance Andersen wrote:
Hi Jaikiran,
Consider:
On Jul 2, 2021, at 8:08 AM, Jaikiran Pai
mailto:jai.forums2...@gmail.com>> wrote:
Hello Lance,
On 02/07/21 4:42 pm, Lance Andersen wrote:
Hi Jaikiran,
Consider:
try (var os = Files.newOutputStream(ZIPFILE);
ZipOutputStream zos = new ZipOutputStr
On Fri, 2 Jul 2021 11:06:40 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this proposed fix for
>> https://bugs.openjdk.java.net/browse/JDK-8251329?
>>
>> As noted in that issue, if a zip filesystem created on top of a jar
>> containing a "./" entry is "walked" using the
On Wed, 30 Jun 2021 15:45:25 GMT, Weijun Wang wrote:
>> Add a cache to record which sources have called `System::setSecurityManager`
>> and only print out warning lines once for each.
>
> Weijun Wang has updated the pull request incrementally with one additional
> commit since the last
Hi Jaikiran
On Jun 30, 2021, at 12:15 PM, Jaikiran Pai
mailto:jai.forums2...@gmail.com>> wrote:
Hello Lance,
On 29/06/21 11:31 pm, Lance Andersen wrote:
I ran your current test 150 times and the max runtime was 25 seconds, most
cases were in the 18-20 second range on our slower test
On Mon, 28 Jun 2021 09:13:31 GMT, Jaikiran Pai wrote:
>> Can I please get a review for this proposed fix for the issue reported in
>> https://bugs.openjdk.java.net/browse/JDK-8190753?
>>
>> The commit here checks for the size of the zip entry before trying to create
>> a
53
Stats: 139 lines in 2 files changed: 138 ins; 0 del; 1 mod
Patch: https://git.openjdk.java.net/jdk/pull/4607.diff
Fetch: git fetch https://git.openjdk.java.net/jdk pull/4607/head:pull/4607
PR: https://git.openjdk.java.net/jdk/pull/4607
[cid:E1C4E2F0-ECD0-4C9D-ADB4-B16CA7BCB7FC@home]
Lance
On Mon, 28 Jun 2021 20:33:29 GMT, Naoto Sato wrote:
>> Please review this small doc change to the system property. Accompanying CSR
>> has also been created.
>
> Naoto Sato has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Missed one.
On Mon, 28 Jun 2021 18:37:34 GMT, Naoto Sato wrote:
>> Please review this small doc change to the system property. Accompanying CSR
>> has also been created.
>
> Naoto Sato has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Refined wording.
On Mon, 28 Jun 2021 18:03:56 GMT, Weijun Wang wrote:
> More refactoring to limit the scope of `@SuppressWarnings` annotations.
>
> Sometimes I introduce new methods. Please feel free to suggest method names
> you like to use.
>
> Note: this is copied from
On Mon, 28 Jun 2021 16:57:15 GMT, Naoto Sato wrote:
> Please review this small doc change to the system property. Accompanying CSR
> has also been created.
Looks good Naoto
-
Marked as reviewed by lancea (Reviewer).
PR: https://git.openjdk.java.net/jdk17/pull/163
On Fri, 25 Jun 2021 23:40:27 GMT, Weijun Wang wrote:
>> More refactoring to limit the scope of `@SuppressWarnings` annotations.
>>
>> Sometimes I introduce new methods. Please feel free to suggest method names
>> you like to use.
>
> Weijun Wang has updated the pull request incrementally with
On Fri, 25 Jun 2021 20:04:37 GMT, Weijun Wang wrote:
> More refactoring to limit the scope of `@SuppressWarnings` annotations.
>
> Sometimes I introduce new methods. Please feel free to suggest method names
> you like to use.
Changes look good Max
-
Marked as reviewed by lancea
On Thu, 24 Jun 2021 20:36:29 GMT, Joe Wang wrote:
> Fix a regression caused by the previous BCEL update. The issue was fixed in
> the current BCEL repo with a reversal of the previous code, adding back
> "gos.close();". Note however, doing so will result in a warning: [try]
> explicit call to
On Thu, 24 Jun 2021 18:43:00 GMT, Brian Burkhalter wrote:
>> Augment the specification of
>> `java.io.File.createTempFile(String,String,File)` to clarify its behavior
>> with respect to the `File` parameter `directory`.
>
> Brian Burkhalter has refreshed the contents of this pull request, and
On Thu, 24 Jun 2021 12:01:04 GMT, Patrick Concannon
wrote:
>> Hi,
>>
>> Could someone please review the second half of my update for the `java.time`
>> package to make use of switch expressions?
>>
>> This PR was split into two parts due to the large number of files affected.
>>
>> Kind
On Wed, 23 Jun 2021 23:02:01 GMT, Brian Burkhalter wrote:
>> Augment the specification of
>> `java.io.File.createTempFile(String,String,File)` to clarify its behavior
>> with respect to the `File` parameter `directory`.
>
> Brian Burkhalter has updated the pull request incrementally with one
On Wed, 23 Jun 2021 07:34:06 GMT, Masanori Yano wrote:
>> Hi all,
>>
>> Could you please review the 8268457 bug fixes?
>>
>> The problem is that ToHTMLStream applies processing for non-surrogate pairs
>> to the surrogate pair.
>> This fix changes the processing for non-surrogate pairs to the
On Tue, 22 Jun 2021 17:50:05 GMT, Patrick Concannon
wrote:
>> Hi,
>>
>> Could someone please review the second half of my update for the `java.time`
>> package to make use of switch expressions?
>>
>> This PR was split into two parts due to the large number of files affected.
>>
>> Kind
On Mon, 21 Jun 2021 18:22:26 GMT, Naoto Sato wrote:
> Please review this doc clarification fix to `toDaysPart()` method. CSR will
> also be filed accordingly.
Marked as reviewed by lancea (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/4542
On Mon, 24 May 2021 11:18:57 GMT, Mitsuru Kariya
wrote:
>> Fix `SerialBlob.setBytes(long pos, byte[] bytes, int offset, int length)` in
>> the following cases:
>>
>> 1. `pos - 1 + bytes.length - offset > this.length() && pos - 1 + length <=
>> this.length()`
>>The original implementation
On Thu, 17 Jun 2021 22:03:46 GMT, Joe Wang wrote:
>> The issue was that the attribute was processed before the variable was set
>> (e.g. m_preserveSpaces.push). Reversing the order fixed it.
>
> Joe Wang has updated the pull request incrementally with one additional
> commit since the last
On Wed, 9 Jun 2021 15:41:59 GMT, Patrick Concannon
wrote:
> Hi,
>
> Could someone please review my code for updating the code in the `java.time`
> packages to make use of the switch expressions?
>
> Kind regards,
> Patrick
Updates look good Patrick
-
Marked as reviewed by
On Wed, 9 Jun 2021 10:25:35 GMT, Patrick Concannon
wrote:
>> Hi,
>>
>> Could someone please review my code for updating the code in the `java.lang`
>> packages to make use of the switch expressions?
>>
>> Kind regards,
>> Patrick
>
> Patrick Concannon has updated the pull request
On Tue, 8 Jun 2021 18:32:36 GMT, Jorn Vernee wrote:
>> This patch adds a `--validate` option to the jar tool which can be used to
>> validate a jar file that might be malformed. For instance, if a jar is a
>> multi-release jar, it is malformed if different versions expose different
>> APIs.
On Wed, 2 Jun 2021 16:13:48 GMT, Jonathan Gibbons wrote:
> Please review the change to update to using jtreg 6.
>
> The primary change is to the jib-profiles.js file, which specifies the
> version of jtreg to use, for those systems that rely on this file. In
> addition, the `requiredVersion`
On Sat, 29 May 2021 00:12:09 GMT, Joe Wang wrote:
> Makes a correction to XPathEvaluationResult.XPathResultType.NODESET mapping.
> Clarifies the supported types for the evaluateExpression methods.
>
> Other changes were javadoc tag usages, e.g. s/the code tag/{@code
Marked as reviewed by
On Mon, 31 May 2021 15:02:57 GMT, Weijun Wang wrote:
>> Please review this implementation of [JEP
>> 411](https://openjdk.java.net/jeps/411).
>>
>> The code change is divided into 3 commits. Please review them one by one.
>>
>> 1.
>>
On Thu, 27 May 2021 15:33:36 GMT, Patrick Concannon
wrote:
>> Hi,
>>
>> Could someone please review my code for updating the code in the `java.io`,
>> `java.math`, and `java.text` packages to make use of the switch expressions?
>>
>> Kind regards,
>> Patrick
>
> Patrick Concannon has updated
On Mon, 24 May 2021 06:23:59 GMT, Joe Wang wrote:
>> Update module summary, add a few existing properties and features into the
>> tables.
>
> Joe Wang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Consolidated impl specific properties;
On Mon, 17 May 2021 14:39:05 GMT, Mitsuru Kariya
wrote:
>> Fix `SerialBlob.setBytes(long pos, byte[] bytes, int offset, int length)` in
>> the following cases:
>>
>> 1. `pos - 1 + bytes.length - offset > this.length() && pos - 1 + length <=
>> this.length()`
>>The original implementation
On Mon, 17 May 2021 14:39:05 GMT, Mitsuru Kariya
wrote:
>> Fix `SerialBlob.setBytes(long pos, byte[] bytes, int offset, int length)` in
>> the following cases:
>>
>> 1. `pos - 1 + bytes.length - offset > this.length() && pos - 1 + length <=
>> this.length()`
>>The original implementation
On Tue, 18 May 2021 10:37:21 GMT, Patrick Concannon
wrote:
> Hi,
>
> Could someone please review my code for updating the code in the `java.util`
> package to make use of the `instanceof` pattern variable?
>
> Kind regards,
> Patrick
Changes look good.
-
Marked as reviewed by
On Fri, 14 May 2021 17:44:20 GMT, Lance Andersen wrote:
> Please review this fix for a typo in the copyright header in HashTest which
> the jdk-tier1 does not catch
>
> Best
> Lance
This pull request has now been integrated.
Changeset: 5eda812f
Author: Lance Andersen
UR
Please review this fix for a typo in the copyright header in HashTest which the
jdk-tier1 does not catch
Best
Lance
-
Commit messages:
- Typo in copyright header for HashesTest
Changes: https://git.openjdk.java.net/jdk/pull/4034/files
Webrev:
On Thu, 13 May 2021 10:49:21 GMT, Lance Andersen wrote:
> HI all,
>
> Please review the fix to HashesTest.java to support running on TestNG 7.4.
>
> The fix adds a no-arg constructor which TestNG requires.
>
> The change allows the test to run with the
> HI all,
>
> Please review the fix to HashesTest.java to support running on TestNG 7.4.
>
> The fix adds a no-arg constructor which TestNG requires.
>
> The change allows the test to run with the current jtreg as well as the
> upcoming jtreg
>
>
> Best
&g
On Fri, 14 May 2021 08:02:29 GMT, Alan Bateman wrote:
>> Lance Andersen has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Adjust imports and spacing
>
> test/jdk/tools/jmod/hashes/Hashe
> HI all,
>
> Please review the fix to HashesTest.java to support running on TestNG 7.4.
>
> The fix adds a no-arg constructor which TestNG requires.
>
> The change allows the test to run with the current jtreg as well as the
> upcoming jtreg
>
>
> Best
&g
On Thu, 13 May 2021 18:53:25 GMT, Mandy Chung wrote:
>> Lance Andersen has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Update copyright typo
>
> test/jdk/tools/jmod/hashes/HashesTest.java line
On Thu, 13 May 2021 18:26:52 GMT, Lance Andersen wrote:
>> HI all,
>>
>> Please review the fix to HashesTest.java to support running on TestNG 7.4.
>>
>> The fix adds a no-arg constructor which TestNG requires.
>>
>> The change allows the
> HI all,
>
> Please review the fix to HashesTest.java to support running on TestNG 7.4.
>
> The fix adds a no-arg constructor which TestNG requires.
>
> The change allows the test to run with the current jtreg as well as the
> upcoming jtreg
>
>
> Best
&g
On Thu, 13 May 2021 10:49:21 GMT, Lance Andersen wrote:
> HI all,
>
> Please review the fix to HashesTest.java to support running on TestNG 7.4.
>
> The fix adds a no-arg constructor which TestNG requires.
>
> The change allows the test to run with the
> HI all,
>
> Please review the fix to HashesTest.java to support running on TestNG 7.4.
>
> The fix adds a no-arg constructor which TestNG requires.
>
> The change allows the test to run with the current jtreg as well as the
> upcoming jtreg
>
>
> Best
&g
On Thu, 13 May 2021 11:24:34 GMT, Chris Hegarty wrote:
> The non-static state in this test class is initialized for each of the static
> testXXX scenarios. An alternative could be to move said state (four fields)
> into a static inner class, and have each of the testXXX scenarios create an
>
On Thu, 13 May 2021 11:11:23 GMT, Alan Bateman wrote:
>> HI all,
>>
>> Please review the fix to HashesTest.java to support running on TestNG 7.4.
>>
>> The fix adds a no-arg constructor which TestNG requires.
>>
>> The change allows the test to run with the current jtreg as well as the
>>
HI all,
Please review the fix to HashesTest.java to support running on TestNG 7.4.
The fix adds a no-arg constructor which TestNG requires.
The change allows the test to run with the current jtreg as well as the
upcoming jtreg
Best
Lance
-
Commit messages:
- Remove
/bugs.openjdk.java.net/browse/JDK-8153490
Stats: 179 lines in 4 files changed: 122 ins; 17 del; 40 mod
Patch: https://git.openjdk.java.net/jdk/pull/4001.diff
Fetch: git fetch https://git.openjdk.java.net/jdk pull/4001/head:pull/4001
PR: https://git.openjdk.java.net/jdk/pull/4001
[cid:E1C4E2F0
On Wed, 12 May 2021 19:13:43 GMT, Joe Wang wrote:
>> Update module summary, add a few existing properties and features into the
>> tables.
>
> Joe Wang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Thanks Roger. Changed to fully
On Wed, 12 May 2021 00:42:57 GMT, Joe Wang wrote:
>> Update module summary, add a few existing properties and features into the
>> tables.
>
> Joe Wang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Add legacy property names table
Looks
ps://bugs.openjdk.java.net/browse/JDK-4991036
Please let me know if there is a better place to do so.
Thanks
[cid:E1C4E2F0-ECD0-4C9D-ADB4-B16CA7BCB7FC@home]
Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
On Tue, 11 May 2021 16:32:25 GMT, Joe Wang wrote:
>> Update BCEL to the latest version (6.5.0). The majority of the changes were
>> code refactoring (name format changes).
>>
>> XML tests passed on both Linux and Windows.
>
> Joe Wang has updated the pull request incrementally with one
On Fri, 7 May 2021 03:10:32 GMT, Jason Zaugg wrote:
>> If the given Path represents a file, use the overload of read defined
>> in FileChannel that accepts an explicit position and avoid serializing
>> reads.
>>
>> Note: The underlying NIO implementation is not required to implement
>>
On Fri, 7 May 2021 03:10:32 GMT, Jason Zaugg wrote:
>> If the given Path represents a file, use the overload of read defined
>> in FileChannel that accepts an explicit position and avoid serializing
>> reads.
>>
>> Note: The underlying NIO implementation is not required to implement
>>
On Thu, 6 May 2021 00:17:40 GMT, Joe Wang wrote:
> Update BCEL to the latest version (6.5.0). The majority of the changes were
> code refactoring (name format changes).
>
> XML tests passed on both Linux and Windows.
Marked as reviewed by lancea (Reviewer).
-
PR:
On Thu, 6 May 2021 16:57:12 GMT, Daniel Fuchs wrote:
>> Hi, please find here a trivial test change that adds some diagnostic (time
>> stamps) to the LoggerFinder/modules subprocess test logs.
>
> Daniel Fuchs has updated the pull request incrementally with one additional
> commit since the
On Tue, 4 May 2021 20:45:43 GMT, Lance Andersen wrote:
> Hi all,
>
> This fix addresses a change in TestNG behavior for the Before/AfterGroups
> annotations that was introduced via
> https://github.com/cbeust/testng/pull/2167. The tests have been verified
> against
On Wed, 5 May 2021 19:10:21 GMT, Lance Andersen wrote:
> Hi all,
>
> Please review this patch which updates
> test/jdk/java/lang/ProcessHandle/PermissionTest.java &
> test/jdk/java/sql/testng/util/TestPolicy.java to include :
>
> `new PropertyPermission("
Hi all,
Please review this patch which updates
test/jdk/java/lang/ProcessHandle/PermissionTest.java &
test/jdk/java/sql/testng/util/TestPolicy.java to include :
`new PropertyPermission("testng.memory.friendly", "read");
`
Which will be needed by TestNG 7.4
Best,
Lance
-
On Tue, 4 May 2021 14:10:52 GMT, Alan Bateman wrote:
>> Jason Zaugg has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Use pattern matching instanceof
>
> src/jdk.zipfs/share/classes/jdk/nio/zipfs/ZipFileSystem.java line 2223:
>
>> 2221:
On Tue, 4 May 2021 22:44:18 GMT, Brian Burkhalter wrote:
>> That's IntelliJ magic. I can update if you prefer and can let IntelliJ
>> optimize all of the imports
>
> Ah. I was just thinking of consistency with other tests. Up to you.
I think your milage will vary depending on the author and
On Tue, 4 May 2021 22:36:29 GMT, Brian Burkhalter wrote:
>> Hi all,
>>
>> This fix addresses a change in TestNG behavior for the Before/AfterGroups
>> annotations that was introduced via
>> https://github.com/cbeust/testng/pull/2167. The tests have been verified
>> against the latest
Hi all,
This fix addresses a change in TestNG behavior for the Before/AfterGroups
annotations that was introduced via
https://github.com/cbeust/testng/pull/2167. The tests have been verified
against the latest TestNG release and continue to run with the current TestNG
release used by
dk/pull/3072
[cid:E1C4E2F0-ECD0-4C9D-ADB4-B16CA7BCB7FC@home]
Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com<mailto:lance.ander...@oracle.com>
On Mon, 26 Apr 2021 02:36:54 GMT, Hamlin Li wrote:
>> code like below will create Deflater before null check, although it's not a
>> real mem leak, but it's better to do null check before new Deflater.
>>
>> try {
>> DeflaterOutputStream dos = new
On Fri, 23 Apr 2021 00:41:17 GMT, Joe Wang wrote:
> Update module summary, add a few existing properties and features into the
> tables.
Good morning Joe,
The changes look good based on the discussions we have had about the change and
the property documentation is more convenient to find
On Fri, 23 Apr 2021 15:38:53 GMT, Patrick Concannon
wrote:
>> Hi,
>>
>> Could someone please review the second half of my update for the `java.time`
>> package to make use of the `instanceof` pattern variable?
>>
>> This PR was split into two parts due to the large number of files affected.
On Fri, 23 Apr 2021 10:44:30 GMT, Patrick Concannon
wrote:
> Hi,
>
> Could someone please review the second half of my update for the `java.time`
> package to make use of the `instanceof` pattern variable?
>
> This PR was split into two parts due to the large number of files affected.
>
>
On Tue, 13 Apr 2021 18:01:49 GMT, Lance Andersen wrote:
> Hi all,
>
> Please review the following patch which adds additional permissions needed
> for when JTREG upgrades to a newer version of TestNG.
>
> Best,
> Lance
This pull request has now been integrated.
Chang
On Wed, 14 Apr 2021 14:03:01 GMT, Michael McMahon wrote:
> Hi,
>
> Could I get the following trivial doc changes reviewed please, caused by:
>
> - broken tags in MethodHandles referring to package.html instead of
> package-summary.html
>
> - references to a package level #unixdomain anchor
> Hi all,
>
> Please review the following patch which adds additional permissions needed
> for when JTREG upgrades to a newer version of TestNG.
>
> Best,
> Lance
Lance Andersen has updated the pull request incrementally with one additional
commit since the last
On Apr 14, 2021, at 2:13 AM, Alan Bateman
mailto:al...@openjdk.java.net>> wrote:
On Tue, 13 Apr 2021 18:56:22 GMT, Lance Andersen
mailto:lan...@openjdk.org>> wrote:
Hi all,
Please review the following patch which adds additional permissions needed for
when JTREG upgrade
> Hi all,
>
> Please review the following patch which adds additional permissions needed
> for when JTREG upgrades to a newer version of TestNG.
>
> Best,
> Lance
Lance Andersen has updated the pull request incrementally with one additional
commit since the last revisi
Hi all,
Please review the following patch which adds additional permissions needed for
when JTREG upgrades to a newer version of TestNG.
Best,
Lance
-
Commit messages:
- TestNG updates
Changes: https://git.openjdk.java.net/jdk/pull/3471/files
Webrev:
Adding additional support for these fields is fine, we just need to agree on
the API changes to move forward prior to updating the PR
Thanks!
Lin
-
PR: https://git.openjdk.java.net/jdk/pull/3072
[cid:E1C4E2F0-ECD0-4C9D-ADB4-B16CA7BCB7FC@home]
Lance Andersen| Principal Member of Technical
l
>>> require an update to the CSR.
>>>
>>>
>>>
>>> Thanks!
>>>
>>> BRs,
>>> Lin
>>>
>>> —
>>> You are receiving this because you commented.
>>> Reply to this email directly, view it
On Mon, 29 Mar 2021 14:04:10 GMT, Jaikiran Pai wrote:
>> Can I please get a review for this patch which proposes to implement the
>> enhancement request noted in
>> https://bugs.openjdk.java.net/browse/JDK-8173970?
>>
>> The commit in this PR introduces the `-o` and `--output-dir` option to
On Mon, 29 Mar 2021 14:04:10 GMT, Jaikiran Pai wrote:
>> Can I please get a review for this patch which proposes to implement the
>> enhancement request noted in
>> https://bugs.openjdk.java.net/browse/JDK-8173970?
>>
>> The commit in this PR introduces the `-o` and `--output-dir` option to
ulietti wrote:
As far as I can tell, scientific computation will make use of binary
floating point numbers for a long time. Decimal floating point numbers
are still limited to biz and fin applications.
[cid:E1C4E2F0-ECD0-4C9D-ADB4-B16CA7BCB7FC@home]
Lance Andersen| Principal Member of Technical
asses to provide a
better API.
I am not sure how much if at all these extra header fields are used. Certainly
if the API now sets them, we should probably provide a way to access them as
well.
-
PR: https://git.openjdk.java.net/jdk/pull/3072
[cid:E1C4E2F0-ECD0-4C9D-ADB4-B16CA7BCB7
t;d1/f2.txt" and other files,
then the above command extracts only "f1.txt" and "d1/f2.txt" into the
/tmp/foo/bar/ directory.
-Jaikiran
On 14/03/21 6:21 pm, Alan Bateman wrote:
On 12/03/2021 12:18, Lance Andersen wrote:
:
I don’t have a strong preference but lean slight
the todo list for next week.
Best
Lance
-
PR: https://git.openjdk.java.net/jdk/pull/2752
[cid:E1C4E2F0-ECD0-4C9D-ADB4-B16CA7BCB7FC@home]
Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lan
On Tue, 16 Feb 2021 13:48:20 GMT, Simon Legner
wrote:
> 8264031: Fix typo in ZipFileSystem.deleteFile ZipException
Marked as reviewed by lancea (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/2588
On Wed, 24 Mar 2021 09:56:16 GMT, Patrick Concannon
wrote:
> Hi,
>
> Could someone please review my code for updating the code in the `java.time`
> package to make use of the `instanceof` pattern variable?
>
> Kind regards,
> Patrick
Changes look good Patrick.
-
Marked as
irectly, view it on
GitHub<https://github.com/openjdk/jdk/pull/3072#issuecomment-805549600>, or
unsubscribe<https://github.com/notifications/unsubscribe-auth/ABQPFO5R4INTAUFZ3QS6WL3TFGDXHANCNFSM4ZMLU6SA>.
***@***.***
Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
***@***.**@***.***>
-
PR: https://git.openjdk.java.net/jdk/pull/3072
On Tue, 23 Mar 2021 21:41:32 GMT, Alex Blewitt
wrote:
> 8264091: Use the blessed modifier order in java.logging
Marked as reviewed by lancea (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/3163
On Fri, 19 Mar 2021 08:19:58 GMT, Lin Zang wrote:
>> 4890732: GZIPOutputStream doesn't support, in fact thwarts, use of optional
>> GZIP fields
>
> Lin Zang has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - update copyright
> - reuse
On Fri, 19 Mar 2021 15:27:00 GMT, Alex Blewitt
wrote:
> Fixes for the `java.sql`, `java.sql.rowset` and `java.transaction.xa`
> packages.
>
> @cl4es would you mind creating a subtask of JDK-8263854 so I can update the
> PR title?
Marked as reviewed by lancea (Reviewer).
-
PR:
et/jdk pull/3072/head:pull/3072
PR: https://git.openjdk.java.net/jdk/pull/3072
[cid:E1C4E2F0-ECD0-4C9D-ADB4-B16CA7BCB7FC@home]
Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@orac
On Tue, 16 Mar 2021 21:36:40 GMT, Joe Wang wrote:
>> Consolidate and move javadoc for the lookup mechanism to the module summary.
>
> Joe Wang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Fix typos: s/XMLEventFactory/XMLInputFactory
>
On Tue, 16 Mar 2021 00:52:24 GMT, Joe Wang wrote:
> Consolidate and move javadoc for the lookup mechanism to the module summary.
Marked as reviewed by lancea (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/3020
On Mar 12, 2021, at 6:32 AM, Alan Bateman
mailto:alan.bate...@oracle.com>> wrote:
On 11/03/2021 15:25, Lance Andersen wrote:
The only reason I included it is for completeness with tar which the jar
options were originally derived from.
I think it would be surprising to have two GNU
On Mar 11, 2021, at 9:29 AM, Alan Bateman
mailto:alan.bate...@oracle.com>> wrote:
On 04/03/2021 12:01, Lance Andersen wrote:
Hi Jaikiran
From https://docs.oracle.com/en/java/javase/15/docs/specs/man/jar.html
The jar man page includes the following :
The syntax for the jar c
301 - 400 of 1866 matches
Mail list logo
