the generated proxy class includes an
>> instance method named "foo" and no static method is generated in the
>> proxy class.
>>
>> Mandy
>>
>> On 10/2/17 11:44 AM, Eric McCorkle wrote:
>>> Hello everyone,
>>>
>>> A colleague
Hello everyone,
A colleague of mine discovered what seems to be a bug in
java.lang.reflect.Proxy#newProxyInstance. I'd like to confirm that this
is indeed incorrect behavior before I go and fix it.
Consider the following two interfaces:
interface I1 {
static I1 foo() {
return null;
}
}
Are there any more comments on this patch? This is an 8u40 issue, so it
needs to be committed soon.
Thanks,
Eric
On 11/05/14 16:57, Eric McCorkle wrote:
A word on the tests: I don't think there's a stable way to check the
types on getParameterizedType() and getAnnotatedType(). So I checked
this is a fine fix
for both 8u and 9.
cheers
/Joel
On 31 okt 2014, at 17:15, Eric McCorkle eric.mccor...@oracle.com wrote:
Hello,
Please review this patch which fixes issues that arise with
getGenericParameterTypes() and getAnnotatedParameterTypes() when there
are generic signatures
.
If you flesh out the test and remove the caching I think this is a fine fix
for both 8u and 9.
cheers
/Joel
On 31 okt 2014, at 17:15, Eric McCorkle eric.mccor...@oracle.com wrote:
Hello,
Please review this patch which fixes issues that arise with
getGenericParameterTypes
top-level
files; however, you can still look at the individual files just fine.
On 11/02/14 23:50, David Holmes wrote:
Hi Erik,
webrevs still broken for some reason.
On 1/11/2014 12:01 AM, Eric McCorkle wrote:
I went through and added comments in the binary data indicating where
This issue is an 8u40 issue, so it needs to be reviewed ASAP in order to
backport it in time.
On 10/31/14 12:15, Eric McCorkle wrote:
Hello,
Please review this patch which fixes issues that arise with
getGenericParameterTypes() and getAnnotatedParameterTypes() when there
are generic
an unsigned/signed byte
conversion problem), then modify the data by hand. The intent is to
replace this with a better method at some point.
On 10/30/14 21:59, David Holmes wrote:
Hi Erik,
On 31/10/2014 9:41 AM, Eric McCorkle wrote:
Hello,
Please review this patch which adds tests to the JDK
Hello,
Please review this patch which fixes issues that arise with
getGenericParameterTypes() and getAnnotatedParameterTypes() when there
are generic signatures and synthetic parameters.
Please note that a complete fix is not possible for all cases. See
discussion on
Hello,
Please review this patch which adds tests to the JDK test suite for two
reflection bugs that require hotspot changes (JDK-8058322 and JDK-8058313)
The webrev is here:
http://cr.openjdk.java.net/~emc/8062556/
I am currently seeing build failures on solaris, coming from within the
JDK repo:
/opt/jprt/products/P1/SS12u1/SS12u1/prod/bin/cc -DTRACING
-DMACRO_MEMSYS_OPS -DBREAKPTS -D_BIG_ENDIAN= -DSOLARIS
-DARCH='sparcv9' -Dsparcv9 -DNDEBUG -DTRIMMED
-DRELEASE='1.9.0-internal'
in the attach framework
On 05/09/14 14:08, Eric McCorkle wrote:
I am currently seeing build failures on solaris, coming from within the
JDK repo:
/opt/jprt/products/P1/SS12u1/SS12u1/prod/bin/cc -DTRACING
-DMACRO_MEMSYS_OPS -DBREAKPTS -D_BIG_ENDIAN= -DSOLARIS
-DARCH='sparcv9' -Dsparcv9 -DNDEBUG
blocking this week hotspot snapshot:
http://prt-web.us.oracle.com//archive/2014/05/2014-05-09-174238.amurillo.jdk9-hs-2014-05-09-jdk9-dev-control/logs/solaris_sparcv9_5.10-fastdebug.log.FAILED.log
please fix ASAP
Thanks
Alejandro
On 5/9/2014 12:16 PM, Eric McCorkle wrote:
Bug created: https
, 2014, Oracle and/or its affiliates. All rights
reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
On 05/09/14 15:01, Eric McCorkle wrote:
The problem is a stray '' as the first two characters in the file.
I have posted a patch that removes it to serviceability-dev
Pushed. You may now resume normal integration activities.
On 05/09/14 15:12, Staffan Larsen wrote:
Looks good.
Many apologies.
/Staffan
On 9 maj 2014, at 21:08, Eric McCorkle eric.mccor...@oracle.com wrote:
The following patch will fix it:
diff -r 7426549b1e3b
src/solaris
I've been doing some upgrades on servers I run at home recently. One of
the upgrades I'd planned was to increase the key size of my internal CA
key and SSL keys to 8192 bits as a future-proofing measure (I use SSL
with client certificates for all service-to-service communication).
What I found
Changeset: f684c9773858
Author:vlivanov
Date: 2014-01-31 21:07 +0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f684c9773858
8033278: Missed access checks for Lookup.unreflect* after 8032585
Reviewed-by: jrose, twisti
! src/share/classes/sun/invoke/util/VerifyAccess.java
!
Changeset: 11b83c913cca
Author:attila
Date: 2014-01-30 20:14 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/11b83c913cca
8032681: Issues with Nashorn
Reviewed-by: ahgross, jlaskey, sundar
+ src/jdk/internal/dynalink/linker/GuardedTypeConversion.java
!
Changeset: 56d05f260123
Author:vlivanov
Date: 2014-01-28 13:46 +0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/56d05f260123
8032585: JSR292: IllegalAccessError when attempting to invoke protected method
from different package
Reviewed-by: twisti, jrose
!
Changeset: 9e91793fd516
Author:vlivanov
Date: 2014-01-15 20:48 +0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9e91793fd516
8031502: JSR292: IncompatibleClassChangeError in LambdaForm for
CharSequence.toString() method handle type converter
Reviewed-by: sundar, lagergren,
Changeset: 24eaf41a3974
Author:emc
Date: 2013-11-14 12:32 -0500
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/24eaf41a3974
8028282: Remove @ignore from test langtools/test/tools/javac/T7042623.java
Summary: Remove @ignore from test
Reviewed-by: jjg
!
Hello,
Please review this trivial fix that adds @since documentation tags to
changes added in support of parameter reflection.
Webrev here:
http://cr.openjdk.java.net/~emc/8028021/
Thanks,
Eric
Changeset: ea91826bc2e9
Author:emc
Date: 2013-11-13 15:48 -0500
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ea91826bc2e9
8026884: test for fix of JDK-8021398 does not have @bug tag
8028021: @since 1.8 missing for certain methods in java.lang.reflect.Method in
generated api
Changeset: 4788eb38cac5
Author:emc
Date: 2013-11-11 09:47 -0500
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/4788eb38cac5
8027439: Compile-time error in the case of ((Integer[] Serializable)new
Integer[1]).getClass()
8027253: javac illegally accepts array as bound
Changeset: d2fa3f7e964e
Author:emc
Date: 2013-10-23 23:20 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/d2fa3f7e964e
8006732: support correct bytecode storage of type annotations in multicatch
Summary: Fix issue with annotations being added before attribution, which
Changeset: 119747cd9f25
Author:emc
Date: 2013-10-24 01:27 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/119747cd9f25
8023682: Incorrect attributes emitted for anonymous class declaration
Summary: Cause javac to emit type annotations on new instruction as well as
Changeset: 23b124cbf242
Author:drchase
Date: 2013-10-22 12:57 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/23b124cbf242
8026818: Defmeth failures with -mode invoke
Summary: Added test for IllegalAccessException - IllegalAccessError path to
check if root cause was
Changeset: 0a6730b5e192
Author:drchase
Date: 2013-10-16 17:55 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0a6730b5e192
8022718: Runtime accessibility checking: protected class, if extended, should
be accessible from another package
Summary: Modify accessibility check; it
Changeset: 7f6481e5fe3a
Author:emc
Date: 2013-10-16 16:33 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/7f6481e5fe3a
8026286: Improper locking of annotation queues causes assertion failures.
8026063: Calls to annotate.flush() cause incorrect type annotations to be
Changeset: 6dcf94e32a3a
Author:emc
Date: 2013-10-10 13:55 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/6dcf94e32a3a
8019461: Clean up javac diagnostics
7196553: Review error messages for repeating annotations
Summary: Changes to the diagnostic messages to improve
Hello,
Please review this simple patch that adds javadoc comments to
MalformedParametersException to quiet doclint warnings.
Note this patch involves no code changes.
The bug report is here:
https://bugs.openjdk.java.net/browse/JDK-8026011
The webrev is here:
Changeset: 4abfcbac1cb6
Author:emc
Date: 2013-10-10 18:56 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4abfcbac1cb6
8026011: java.lang.reflect.MalformedParametersException introduces doclint
warnings
Summary: Add javadoc comments to members of MalformedParametersException
Changeset: b1b4a6dcc282
Author:emc
Date: 2013-10-10 20:12 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/b1b4a6dcc282
8008762: Type annotation on inner class in anonymous class show up as regular
type annotations
8015257: type annotation with TYPE_USE and FIELD
I've updated the test, switched to an in-memory class loader, and added
a test case. Please review.
On 10/01/13 16:27, Eric McCorkle wrote:
On 10/01/13 02:41, Joe Darcy wrote:
(Suggested changes have been applied)
I think the test is acceptable as-is, but an RFE could be filed for some
, Eric McCorkle wrote:
I've updated the test, switched to an in-memory class loader, and added
a test case. Please review.
On 10/01/13 16:27, Eric McCorkle wrote:
On 10/01/13 02:41, Joe Darcy wrote:
(Suggested changes have been applied)
I think the test is acceptable as-is, but an RFE could
I forgot to hg add the test. I've addressed your and others' comments,
and refreshed the webrev. Please review.
On 10/01/13 04:06, Joel Borggren-Franck wrote:
Hi Eric,
Thanks for fixing this.
On 2013-10-01, Eric McCorkle wrote:
Hello, please review this simple patch which fixes
Thanks all, committing after successful tests.
On 10/01/13 14:33, Joe Darcy wrote:
Looks fine; cheers,
-Joe
On 10/1/2013 11:18 AM, Eric McCorkle wrote:
I forgot to hg add the test. I've addressed your and others' comments,
and refreshed the webrev. Please review.
On 10/01/13 04:06
yet: I've filed an RFE for a framework for generating bad class
files.
Webrev has been updated, please review:
http://cr.openjdk.java.net/~emc/8020981/
Cheers,
-Joe
On 9/24/2013 12:15 PM, Eric McCorkle wrote:
Webrev updated to address these issues.
On 09/24/13 07:51, Joel Borggren-Franck
(AnnotatedElement)decl);
284 }
Paul.
On Oct 1, 2013, at 8:18 PM, Eric McCorkle eric.mccor...@oracle.com wrote:
I forgot to hg add the test. I've addressed your and others' comments,
and refreshed the webrev. Please
Changeset: 1ed675532589
Author:vlivanov
Date: 2013-09-18 20:12 +0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1ed675532589
8024616: JSR292: lazily initialize core NamedFunctions used for bootstrapping
Reviewed-by: jrose
!
Changeset: bf1118ab775b
Author:emc
Date: 2013-10-01 17:35 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bf1118ab775b
8021398: j.l.r.Parameter.getAnnotatedType().getType() for not annotated use of
type returns null
Summary: Fixed issue with type annotation reflection
Changeset: de1c5dbe6c28
Author:emc
Date: 2013-10-01 17:41 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/de1c5dbe6c28
8021339: Compile-time error during casting array to intersection
Summary: Add ability to have arrays in intersection types.
Reviewed-by: jjg, vromero
Changeset: 5a7bd9825c01
Author:vlivanov
Date: 2013-09-23 19:51 +0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5a7bd9825c01
8001107: @Stable annotation for constant folding of lazily evaluated variables
Reviewed-by: twisti, kvn, rbackman
Contributed-by:
Changeset: 84161510f257
Author:emc
Date: 2013-09-28 13:46 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/84161510f257
8025413: NPE in Type.java due to recent change
Summary: isCompound throws a NPE for noType and other types. Made it return a
reasonable result
The enhanced metadata spec says nothing at all about an IAE. That is an
implementation detail, possibly subject to change at any point, and it
*should* not be leaked.
On 09/24/13 17:28, Paul Benedict wrote:
Eric,
Should MalformedParametersException save IAE as the root cause? Or is that
an
Updated webrev here:
http://cr.openjdk.java.net/~emc/8020981/
Are there any more comments, or is this good to go?
On 09/19/13 18:15, Eric McCorkle wrote:
The webrev has been updated with Joe's comments addressed.
On 09/19/13 00:11, David Holmes wrote:
On 19/09/2013 9:59 AM, Eric McCorkle
verifying function that throws IAE if given a bad index.
On 2013-09-19, Eric McCorkle wrote:
The webrev has been updated with Joe's comments addressed.
On 09/19/13 00:11, David Holmes wrote:
On 19/09/2013 9:59 AM, Eric McCorkle wrote:
This still needs to be reviewed.
You seem to have ignored Joe's
Changeset: 09301757bb32
Author:emc
Date: 2013-09-23 15:37 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/09301757bb32
6499673: Assertion check for TypeVariable.getUpperBound() fails.
Summary: Fix TypeVariable.getUpperBound to return results as specified
Reviewed-by:
The webrev has been updated with Joe's comments addressed.
On 09/19/13 00:11, David Holmes wrote:
On 19/09/2013 9:59 AM, Eric McCorkle wrote:
This still needs to be reviewed.
You seem to have ignored Joe's comments regarding the change to Modifier
being incorrect.
David
On 09/16/13 14
This still needs to be reviewed.
On 09/16/13 14:50, Eric McCorkle wrote:
I pulled the class files into byte array constants, as a temporary
measure until a viable method for testing bad class files is developed.
The webrev has been refreshed. The class files will be taken out before
I push
:
To avoid storing binaries in Hg, you could try something like:
* uuencode / ascii armor the class file
* convert to byte array in the test
* load classes from byte array
-Joe
On 09/13/2013 11:54 AM, Eric McCorkle wrote:
I did it by hand with emacs.
I would really rather tackle
A new webrev is posted (and crucible updated), which actually validates
parameter names correctly. Apologies for the last one.
On 09/12/13 16:02, Eric McCorkle wrote:
Hello,
Please review this patch, which implements correct behavior for the
Parameter Reflection API in the case of malformed
.
cheers
/Joel
On Sep 13, 2013, at 3:40 PM, Eric McCorkle eric.mccor...@oracle.com wrote:
A new webrev is posted (and crucible updated), which actually validates
parameter names correctly. Apologies for the last one.
On 09/12/13 16:02, Eric McCorkle wrote:
Hello,
Please review this patch
, 2013, at 4:49 PM, Eric McCorkle eric.mccor...@oracle.com wrote:
There is no simple means of generating bad class files for testing.
This is a huge deficiency in our testing abilities.
If these class files shouldn't go in, then I'm left with no choice but
to check in no test for this patch
inside a custom
ClassLoader...
To hacky? Dependent on future changes of javac? At least the bad name
patching could be performed trivially and reliably, I think: search and
replace with same-length string.
Regards, Peter
On 09/13/2013 07:35 PM, Eric McCorkle wrote:
Ugh. Byte arrays
On 09/13/13 09:53, Paul Benedict wrote:
MalformedParametersException should receive a @since tag.
Additionally, the javadoc doesn't describe what it means for a parameter to
be malformed. The answer doesn't need to be exhaustive, but I think some
examples would help developers if they catch
Changeset: 5d2d484a1216
Author:emc
Date: 2013-09-12 14:52 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/5d2d484a1216
8013846: javac fails to reject semantically equivalent generic method
declarations
Summary: Cause javac to consider intersection types with the same
Hello,
Please review this patch, which implements correct behavior for the
Parameter Reflection API in the case of malformed class files.
The bug report is here:
https://bugs.openjdk.java.net/browse/JDK-8020981
The webrev is here:
http://cr.openjdk.java.net/~emc/8020981/
This review is also on
Changeset: 65c218b25b61
Author:emc
Date: 2013-09-11 08:30 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/65c218b25b61
8024510: lib/combo/tools/javac/combo/TemplateTest.java fails
Summary: Edit regex in Template to allow MAJOR. pattern.
Reviewed-by: briangoetz
!
Changeset: c3ef78cd9081
Author:emc
Date: 2013-09-11 09:24 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c3ef78cd9081
6962494: Update documentation on Executable.getParameterAnnotations()
Summary: Update javadoc comments on getParameterAnnotations to correctly
describe its
A new webrev has been posted, with some improvements to the comment.
On 09/09/13 17:41, Eric McCorkle wrote:
Hello,
Please review this patch which updates the javadoc comments for
java.lang.reflect.Executable.getParameterAnnotations(). The patch
corrects the javadocs to describe the actual
Changeset: 67c5110c60fe
Author:emc
Date: 2013-09-09 17:11 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/67c5110c60fe
8015322: Javac template test framework
Summary: Putback of the javac template test framework from the Lambda repository
Reviewed-by: jjg
Changeset: f4efd6ef6e80
Author:emc
Date: 2013-09-09 16:26 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/f4efd6ef6e80
8022322: Reject default and static methods in annotation
Summary: Causes javac to reject static and default method declarations inside
an annotation
Hello,
Please review this patch which updates the javadoc comments for
java.lang.reflect.Executable.getParameterAnnotations(). The patch
corrects the javadocs to describe the actual behavior of this method.
It also refers users to the new java.lang.reflect.Parameter API.
See comments on the bug
Changeset: 1ab22e60a738
Author:emc
Date: 2013-08-22 12:47 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/1ab22e60a738
8020745: Suspicious MethodParameters attribute generated for local classes
capturing local variables
Summary: Corrected an error in a previous patch
Changeset: 2068190f8ac2
Author:emc
Date: 2013-08-21 20:23 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/2068190f8ac2
7118412: Shadowing of type-variables vs. member types
4987840: What is the scope of an annotation?
Summary: Fixed issue with shadowing of type names.
Changeset: eebb29618f50
Author:emc
Date: 2013-08-21 20:41 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/eebb29618f50
8023520: Add missing test for JDK-7118412
Summary: The test for JDK-7118412 was dropped from the changeset in a merging
accident.
Reviewed-by: jjg
+
Changeset: 558fe98d1ac0
Author:emc
Date: 2013-07-23 20:42 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/558fe98d1ac0
8016880: 42 tests in annot102* fail with compile-time errors.
Summary: Fixes error in type equality when bounds of type variables have
annotations.
Changeset: a8f51c3341a5
Author:emc
Date: 2013-07-03 19:47 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a8f51c3341a5
8016285: Add java.lang.reflect.Parameter.isNamePresent()
Summary: Add isNamePresent method to parameter reflection library, which
indicates whether or real
Pinging this one again...
On 06/24/13 15:20, Eric McCorkle wrote:
Pinging this RFR. It still needs a capital R reviewer.
http://cr.openjdk.java.net/~emc/8016285/
On 06/21/13 19:21, Eric McCorkle wrote:
On 06/21/13 16:15, Aleksey Shipilev wrote:
On 06/21/2013 11:57 PM, Eric McCorkle wrote
Changeset: 6101e52ce9e3
Author:emc
Date: 2013-06-28 06:54 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/6101e52ce9e3
8016760: Failure of regression test langtools/tools/javac/T6725036.java
Summary: Marking the failing test @ignore; the proposed change for 8015666
Accidentally dropped core-libs-dev from the reply.
On 06/27/13 13:31, Eric McCorkle wrote:
I could easily replace the patch I have now with one that just marks the
test @ignore and commit it. Do we want to go ahead and approve that?
On 06/27/13 13:12, Jonathan Gibbons wrote:
Yes, I think
/2013 10:31 AM, Eric McCorkle wrote:
I could easily replace the patch I have now with one that just marks the
test @ignore and commit it. Do we want to go ahead and approve that?
On 06/27/13 13:12, Jonathan Gibbons wrote:
Yes, I think that this is the correct approach.
-- Jon
On 06/27/2013 09
Changeset: 5c548a8542b8
Author:emc
Date: 2013-06-27 17:45 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/5c548a8542b8
8013357: javac accepts erroneous binary comparison operations
Summary: javac does not report type errors on illegal Object == primitive
comparisons
use 8016760 to add the test to the ProblemList.txt. It can
then be removed along with the other changes for 8015666.
-Chris.
-Sherman
On 06/25/2013 12:27 PM, Eric McCorkle wrote:
Does the fix for 8015666 stop the error from happening? If so, then
I'll withdraw this RFR.
On 06/25/13 13
Can I get a capital-R review on this so I can put it through?
On 06/24/13 17:28, Aleksey Shipilev wrote:
Forgot to reply: I'm ok with webrev.01.
-Aleksey
(rural r reviewer)
On 06/24/2013 11:20 PM, Eric McCorkle wrote:
Pinging this RFR. It still needs a capital R reviewer.
http
Changeset: c674b396827c
Author:emc
Date: 2013-06-27 00:37 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/c674b396827c
8014230: Compilation incorrectly succeeds with inner class constructor with 254
parameters
Summary: The compiler does not account fr extra parameters
Hello,
Please review this simple patch which updates regression test
langtools/tools/javac/T6725036.java to offset the time returned by
JavaFileObject.getLastModified() with the local time to UTC delta.
Please note that this patch is intended to address the test failures,
and that I will be
entry, if
presents.
The API doc will be updated accordingly as well to explicitly explain
the source of the
date/time and the its timezone sensitive conversion.
-Sherman
On 06/25/2013 07:03 AM, Eric McCorkle wrote:
Hello,
Please review this simple patch which updates regression test
, if there is no objection.
-Sherman
On 06/25/2013 12:27 PM, Eric McCorkle wrote:
Does the fix for 8015666 stop the error from happening? If so, then
I'll withdraw this RFR.
On 06/25/13 13:50, Xueming Shen wrote:
This is fine to be a workaround for the test case for now. It probably
will need
Changeset: bf020de5a6db
Author:emc
Date: 2013-06-24 22:03 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/bf020de5a6db
8012722: Single comma in array initializer should parse
Summary: Annotations of the form @Foo({,}) should parse
Reviewed-by: jjg
!
Hello, please review this patch which adds isNamePresent to the
java.lang.reflect.Parameter API.
The webrev is here:
http://cr.openjdk.java.net/~emc/8016285/
The change request is here:
http://bugs.sun.com/view_bug.do?bug_id=8016285
The updated spec is here:
On 06/21/13 16:15, Aleksey Shipilev wrote:
On 06/21/2013 11:57 PM, Eric McCorkle wrote:
The webrev is here:
http://cr.openjdk.java.net/~emc/8016285/
Looks generally good (but not a Reviewer).
A few questions though:
a) Are we em-bracing the brace-less control flow blocks?
Fixed
Changeset: 8717586f7b05
Author:emc
Date: 2013-06-06 08:48 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/8717586f7b05
8015701: MethodParameters are not filled in for synthetic captured local
variables
Summary: Synthetic parameters for captured local variables in an
Hello,
Please review this simple patch that removes setProtectionDomain0 from
java.lang.Class. This is part of a two-stage process to remove the
function from the JVM as well.
This method is not used, and has not been used in some time (at least
before 1.5)
The webrev is here:
Changeset: 37aa82c52317
Author:emc
Date: 2013-06-06 09:51 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/37aa82c52317
8016019: Remove setProtectionDomain0 and JVM_SetProtectionDomain in JDK
Summary: setProtectionDomain0 and JVM_SetProtectionDomain are unused since at
least
Thanks, Alan.
On 06/06/13 09:22, Alan Bateman wrote:
On 06/06/2013 14:07, Eric McCorkle wrote:
Hello,
Please review this simple patch that removes setProtectionDomain0 from
java.lang.Class. This is part of a two-stage process to remove the
function from the JVM as well.
This method
Changeset: 3d4d7ed93731
Author:emc
Date: 2013-06-03 10:44 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3d4d7ed93731
8014834: shell tests don't begin with #!/bin/sh
Summary: Some shell tests don't begin with the command interpreter line
Reviewed-by: alanb, ksrini
!
Thanks all, putting the changes in.
On 06/03/13 06:07, Alan Bateman wrote:
On 01/06/2013 13:32, Eric McCorkle wrote:
Thanks, Kumar. Do I have a second?
For the jdk repository then only one reviewer is required although in
specialized or complicated areas then having a reviewer that knows
Thanks, Kumar. Do I have a second?
Note: JPRT has been unreliable lately, so it may be a while before I can
put this in.
On 05/30/13 17:45, Kumar Srinivasan wrote:
Hi Erik,
This looks good, historically the #!shell was inserted after the
CopyRight,
because it was thought that the
Hello,
Please review this simple patch which fixes an issue with several of the
shell script tests, namely that they do not start with #!/bin/sh
The webrev is here:
http://cr.openjdk.java.net/~emc/8014834/
The bug is here:
http://bugs.sun.com/view_bug.do?bug_id=8014834
Thanks,
Eric
Changeset: ca0957f0d408
Author:emc
Date: 2013-04-25 14:23 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ca0957f0d408
8012937: Correct errors in javadoc comments.
Summary: Correct some errors in the javadoc comments for parameter reflection.
Reviewed-by: darcy
!
Any further comments, or is this one good to go?
On 04/23/13 19:54, Joseph Darcy wrote:
Acknowledged; thanks for checking,
-Joe
On 4/23/2013 7:46 AM, Eric McCorkle wrote:
I believe so. Alex Buckley recommended the exact wording.
On 04/22/13 22:09, Joseph Darcy wrote:
Hello,
240
explicitly nor implicitly declared?
I still think the follow comment is better deleted given the source that
follows it:
157 // If a parameter has no name, return argX, where x is the
158 // index.
159 //
-Joe
On 4/22/2013 11:46 AM, Eric McCorkle wrote:
I
Hello,
Please review this simple change, which corrects some errors in the
javadoc comments for method parameter reflection.
Note that this changeset does not include any code changes.
The webrev is here:
http://cr.openjdk.java.net/~emc/8012937/webrev.00/
Also, if you have any additional
I have posted a newer version with some more edits. Please review and
suggest any further changes.
http://cr.openjdk.java.net/~emc/8012937/webrev.01/
On 04/22/13 12:10, Eric McCorkle wrote:
Hello,
Please review this simple change, which corrects some errors in the
javadoc comments
Any other comments on this one, or is it good to go?
On 02/15/13 16:48, Joe Darcy wrote:
Hi Eric,
I'll approve this change as-is, but I'd prefer if the test were written
in the style of using annotations to record the expected value.
Cheers,
-Joe
On 2/15/2013 12:23 PM, Eric McCorkle
Clarification here: the issue's title is a bit more narrow than the
scope of the fix. It addresses some javadoc comments and handling of
nameless parameters as well.
On 02/05/13 14:58, Eric McCorkle wrote:
Hello, please review this patch, which implements some spec changes for
parameter
Thanks for the reviews everybody!
On 02/04/13 14:02, Joe Wang wrote:
Hi Eric,
The change is fine. Thanks for taking on fixing this!
Joe
On 2/1/2013 3:19 PM, Eric McCorkle wrote:
Thanks. Do I have a second?
On 02/01/13 12:04, Lance Andersen - Oracle wrote:
Its OK.
Not sure I would
Hello,
Please review this trivial patch which removes uses of _ as an
identifier in the jaxp API.
The webrev is here:
http://cr.openjdk.java.net/~emc/8007389/
The bug should be here, but does not seem to be showing up yet:
http://bugs.sun.com/view_bug.do?bug_id=8007389
1 - 100 of 130 matches
Mail list logo
