On Mon, 18 Oct 2021 20:49:07 GMT, Naoto Sato wrote:
> Removing a problem-listed test case, which has little value in itself.
> Confirmed it did succeed on all platforms before the removal.
Marked as reviewed by whuang (Author).
-
PR: https://git.openjdk.java.net/jdk/pull/5996
On Fri, 15 Oct 2021 09:30:18 GMT, Mitsuru Kariya wrote:
>> Fix `SerialBlob.setBytes(long pos, byte[] bytes, int offset, int length)` in
>> the following cases:
>>
>> 1. `pos - 1 + bytes.length - offset > this.length() && pos - 1 + length <=
>> this.length()`
>>The original implementation
On Tue, 19 Oct 2021 04:08:12 GMT, Wu Yan wrote:
>> Hi,
>> Please help me review the change to enhance getting time zone ID from
>> /etc/localtime on linux.
>>
>> We use `realpath` instead of `readlink` to obtain the link name of
>> /etc/localtime, because `readlink` can only read the value
On Fri, 15 Oct 2021 17:09:46 GMT, Daniel Fuchs wrote:
>> Aleksei Efimov has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Add @since tags to new API classes
>> - Add checks and test for empty stream resolver results
>
>
On Tue, 14 Sep 2021 08:52:37 GMT, Julia Boes wrote:
> This change implements a simple web server that can be run on the
> command-line with `java -m jdk.httpserver`.
>
> This is facilitated by adding an entry point for the `jdk.httpserver` module,
> an implementation class whose main method
Hello Claes,
On 19/10/21 7:07 pm, Claes Redestad wrote:
On 2021-10-19 14:31, Jaikiran Pai wrote:
The other option I experimented with was to make
ModuleDescriptor#hashCode() generate the same hashcode across
multiple JVM runs. Although I do have a "working" version of that
change, I decided
On Mon, 18 Oct 2021 13:44:56 GMT, Jaikiran Pai wrote:
> Can I please get a review for this change which addresses
> https://bugs.openjdk.java.net/browse/JDK-8269336?
>
> As noted in that issue, this change will now propagate any exception that
> occurred during parsing and creation of the
The `GlobalFilterTest` has to 2 `@test` tags. One of them has failed with a
timeout as noted in https://bugs.openjdk.java.net/browse/JDK-8268595. The
timeout seems to have happened even after the tests had already completed
successfully. Like I note in the JBS comments of that issue, I suspect
On Sun, 17 Oct 2021 21:39:06 GMT, Mark Sheppard wrote:
> I think that a hostname is constant while a host is up, but it can be
> changed, and when changed a host restart is required. I don't think it is
> quite as dynamic as has been suggested, but I open to correction.
It is possible to
On 19/10/2021 13:31, Jaikiran Pai wrote:
This relates to the intermittent failures in
tools/jlink/JLinkReproducibleTest.java test case which has been
ProblemListed for a while now. The root cause is
https://bugs.openjdk.java.net/browse/JDK-8275509. I couldn't find any
specific mailing lists
On 2021-10-19 14:31, Jaikiran Pai wrote:
The other option I experimented with was to make
ModuleDescriptor#hashCode() generate the same hashcode across multiple
JVM runs. Although I do have a "working" version of that change, I
decided not to spend too much time on it because the
Hello Alan,
On 19/10/21 6:59 pm, Alan Bateman wrote:
On 19/10/2021 13:31, Jaikiran Pai wrote:
This relates to the intermittent failures in
tools/jlink/JLinkReproducibleTest.java test case which has been
ProblemListed for a while now. The root cause is
As a follow up of JEP 411, we will soon disallow security manager by default.
jtreg 6.1 does not set its own security manager if JDK version is >= 18.
-
Commit messages:
- 8275512: Upgrade required version of jtreg to 6.1
Changes: https://git.openjdk.java.net/jdk/pull/6012/files
On Tue, 19 Oct 2021 13:51:45 GMT, Weijun Wang wrote:
> As a follow up of JEP 411, we will soon disallow security manager by default.
> jtreg 6.1 does not set its own security manager if JDK version is >= 18.
This pull request has now been integrated.
Changeset: c24fb852
Author:Weijun Wang
On Fri, 15 Oct 2021 19:31:24 GMT, Vamsi Parasa wrote:
>> src/hotspot/share/opto/mulnode.cpp line 468:
>>
>>> 466: }
>>> 467:
>>> 468:
>>> //=
>>
>> MulHiLNode::Value() and UMulHiLNode::Value() seem to be identical.
On Tue, 19 Oct 2021 18:57:59 GMT, Sandhya Viswanathan
wrote:
>> It's actually redundant because the class is final. Better to drop final
>> from all declarations, at the risk of creating a larger diff.
>
> Got it. I am ok with leaving things as is if it makes it easier.
For now to reduce
On Tue, 19 Oct 2021 17:24:17 GMT, Weijun Wang wrote:
>> As a follow up of JEP 411, we will soon disallow security manager by
>> default. jtreg 6.1 does not set its own security manager if JDK version is
>> >= 18.
>
> Weijun Wang has updated the pull request incrementally with one additional
>
On Tue, 19 Oct 2021 19:51:54 GMT, Paul Sandoz wrote:
>> src/jdk.incubator.vector/share/classes/jdk/incubator/vector/ByteVector.java
>> line 603:
>>
>>> 601: if (opKind(op, VO_SPECIAL)) {
>>> 602: if (op == ZOMO) {
>>> 603: return blend(broadcast(-1),
On Tue, 19 Oct 2021 17:24:17 GMT, Weijun Wang wrote:
>> As a follow up of JEP 411, we will soon disallow security manager by
>> default. jtreg 6.1 does not set its own security manager if JDK version is
>> >= 18.
>
> Weijun Wang has updated the pull request incrementally with one additional
>
On Tue, 19 Oct 2021 17:24:17 GMT, Weijun Wang wrote:
>> As a follow up of JEP 411, we will soon disallow security manager by
>> default. jtreg 6.1 does not set its own security manager if JDK version is
>> >= 18.
>
> Weijun Wang has updated the pull request incrementally with one additional
>
This relates to the intermittent failures in
tools/jlink/JLinkReproducibleTest.java test case which has been
ProblemListed for a while now. The root cause is
https://bugs.openjdk.java.net/browse/JDK-8275509. I couldn't find any
specific mailing lists for jlink tool and I remember seeing
> This change implements a new service provider interface for host name and
> address resolution, so that java.net.InetAddress API can make use of
> resolvers other than the platform's built-in resolver.
>
> The following API classes are added to `java.net.spi` package to facilitate
> this:
>
On Fri, 15 Oct 2021 14:25:02 GMT, Daniel Fuchs wrote:
>> Aleksei Efimov has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Add @since tags to new API classes
>> - Add checks and test for empty stream resolver results
>
>
On Fri, 15 Oct 2021 17:19:26 GMT, Daniel Fuchs wrote:
>> Aleksei Efimov has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Add @since tags to new API classes
>> - Add checks and test for empty stream resolver results
>
>
On Mon, 18 Oct 2021 22:56:37 GMT, Sandhya Viswanathan
wrote:
>> Paul Sandoz has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains seven commits:
>>
>> - Merge branch 'master' into JDK-8271515-vector-api
>> - Apply patch from
On Tue, 19 Oct 2021 18:54:01 GMT, Paul Sandoz wrote:
>> src/hotspot/share/utilities/globalDefinitions_vecApi.hpp line 29:
>>
>>> 27: // the intent of this file to provide a header that can be included in
>>> .s files.
>>> 28:
>>> 29: #ifndef SHARE_VM_UTILITIES_GLOBALDEFINITIONS_VECAPI_HPP
>>
> Optimize the new Math.unsignedMultiplyHigh using the x86 mul instruction.
> This change show 1.87X improvement on a micro benchmark.
Vamsi Parasa has updated the pull request incrementally with one additional
commit since the last revision:
refactoring to remove code duplication by using a
On Wed, 13 Oct 2021 18:55:10 GMT, Vamsi Parasa wrote:
> Optimize the new Math.unsignedMultiplyHigh using the x86 mul instruction.
> This change show 1.87X improvement on a micro benchmark.
This pull request has been closed without being integrated.
-
PR:
On Fri, 15 Oct 2021 21:04:12 GMT, Vamsi Parasa wrote:
> > > How you verified correctness of results? I suggest to extend
> > > `test/jdk//java/lang/Math/MultiplicationTests.java` test to cover
> > > unsigned method.
> >
> >
> > Tests for unsignedMultiplyHigh were already added in
> >
> Can I please get a review for this change which addresses
> https://bugs.openjdk.java.net/browse/JDK-8269336?
>
> As noted in that issue, this change will now propagate any exception that
> occurred during parsing and creation of the filter configured through the
> `jdk.serialFilter` system
On Tue, 19 Oct 2021 13:48:33 GMT, Roger Riggs wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Roger's review suggestion - rethrow the RuntimeException instead of
>> wrapping in ExceptionInInitializerError
>
>
On Tue, 19 Oct 2021 17:24:17 GMT, Weijun Wang wrote:
>> As a follow up of JEP 411, we will soon disallow security manager by
>> default. jtreg 6.1 does not set its own security manager if JDK version is
>> >= 18.
>
> Weijun Wang has updated the pull request incrementally with one additional
>
On 19/10/2021 14:49, Jaikiran Pai wrote:
Ah! So this exact same investigation had already happened a few weeks
back then. I haven't subscribed to that list, so missed it. I see in
one of those messages this part:
"Off hand I can't think of any issues with the ModuleDescriptor
hashCode. It
On Tue, 19 Oct 2021 13:51:45 GMT, Weijun Wang wrote:
> As a follow up of JEP 411, we will soon disallow security manager by default.
> jtreg 6.1 does not set its own security manager if JDK version is >= 18.
LGTM
-
Marked as reviewed by ihse (Reviewer).
PR:
On Tue, 19 Oct 2021 13:51:45 GMT, Weijun Wang wrote:
> As a follow up of JEP 411, we will soon disallow security manager by default.
> jtreg 6.1 does not set its own security manager if JDK version is >= 18.
LGTM
-
Marked as reviewed by iignatyev (Reviewer).
PR:
On Mon, 18 Oct 2021 20:49:07 GMT, Naoto Sato wrote:
> Removing a problem-listed test case, which has little value in itself.
> Confirmed it did succeed on all platforms before the removal.
This pull request has now been integrated.
Changeset: 8a3e0a1f
Author:Naoto Sato
URL:
> As a follow up of JEP 411, we will soon disallow security manager by default.
> jtreg 6.1 does not set its own security manager if JDK version is >= 18.
Weijun Wang has updated the pull request incrementally with one additional
commit since the last revision:
upgrade the version in GHA
Please review this small fix for JDK-8272614 to remove the unused indexInCP
argument to linkCallSite() and linkDynamicConstant(). The fix was tested with
Mach5 tiers 1-2 on Linux, Mac OS, and Windows, and Mach5 tiers 3-6 on Linux x64.
Thanks, Harold
-
Commit messages:
- 8272614:
On Tue, 19 Oct 2021 13:28:26 GMT, Aleksei Efimov wrote:
>> This change implements a new service provider interface for host name and
>> address resolution, so that java.net.InetAddress API can make use of
>> resolvers other than the platform's built-in resolver.
>>
>> The following API
> This PR improves the performance of vector operations that accept masks on
> architectures that support masking in hardware, specifically Intel AVX512 and
> ARM SVE.
>
> On architectures that do not support masking in hardware the same technique
> as before is applied to most operations,
On Tue, 19 Oct 2021 17:12:16 GMT, Harold Seigel wrote:
> Please review this small fix for JDK-8272614 to remove the unused indexInCP
> argument to linkCallSite() and linkDynamicConstant(). The fix was tested
> with Mach5 tiers 1-2 on Linux, Mac OS, and Windows, and Mach5 tiers 3-6 on
> Linux
On Wed, 20 Oct 2021 00:22:30 GMT, Paul Sandoz wrote:
>> This PR improves the performance of vector operations that accept masks on
>> architectures that support masking in hardware, specifically Intel AVX512
>> and ARM SVE.
>>
>> On architectures that do not support masking in hardware the
> This PR improves the performance of vector operations that accept masks on
> architectures that support masking in hardware, specifically Intel AVX512 and
> ARM SVE.
>
> On architectures that do not support masking in hardware the same technique
> as before is applied to most operations,
On Tue, 19 Oct 2021 22:37:10 GMT, Paul Sandoz wrote:
>> This PR improves the performance of vector operations that accept masks on
>> architectures that support masking in hardware, specifically Intel AVX512
>> and ARM SVE.
>>
>> On architectures that do not support masking in hardware the
On Tue, 19 Oct 2021 21:14:08 GMT, Sandhya Viswanathan
wrote:
>> Paul Sandoz has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains seven commits:
>>
>> - Merge branch 'master' into JDK-8271515-vector-api
>> - Apply patch from
On Sat, 16 Oct 2021 00:56:14 GMT, Paul Sandoz wrote:
>> This PR improves the performance of vector operations that accept masks on
>> architectures that support masking in hardware, specifically Intel AVX512
>> and ARM SVE.
>>
>> On architectures that do not support masking in hardware the
On Tue, 19 Oct 2021 22:34:13 GMT, Paul Sandoz wrote:
>> src/jdk.incubator.vector/share/classes/jdk/incubator/vector/VectorMask.java
>> line 574:
>>
>>> 572: * @throws ClassCastException if the species is wrong
>>> 573: */
>>> 574: abstract VectorMask check(Class>
>>> maskClass,
On Tue, 19 Oct 2021 06:32:57 GMT, Mitsuru Kariya wrote:
> The pre-submit test seems to have failed because the compiler was not found
> in some environments.
> Should I take any action?
> Or should I issue the /integrate pull request command?
You should be OK. Just as an extra sanity check, I
48 matches
Mail list logo
