RFR(S): 8062543: Replace uses of MethodHandleImpl.castReference with Class.cast

: * jtreg (java.lang.invoke, java.util.stream) * JPRT (hotspot and jdk_lang test sets) * UTE (vm.quick-pcl.testlist, vm.defmeth.testlist) Thanks, Michael -- <http://www.oracle.com/> Dr. Michael Haupt | Principal Member of Technical Staff Phone: +49 331 200 7277 | Fax: +49 331 200 7561

Re: RFR(S): 8062543: Replace uses of MethodHandleImpl.castReference with Class.cast

Hi Paul, Vladimir, thanks - I'll be back with perf numbers ASAP. Best, Michael > Am 15.07.2015 um 12:51 schrieb Paul Sandoz : > > > On Jul 15, 2015, at 10:23 AM, Michael Haupt wrote: > >> Dear all, >> >> please review and sponsor this change. >&g

Re: RFR(S): 8062543: Replace uses of MethodHandleImpl.castReference with Class.cast

13:58 schrieb Michael Haupt : > > Hi Paul, Vladimir, > > thanks - I'll be back with perf numbers ASAP. > > Best, > > Michael > >> Am 15.07.2015 um 12:51 schrieb Paul Sandoz : >> >> >> On Jul 15, 2015, at 10:23 AM, Michael Haupt wrote

Re: [9] RFR: 8060717: [TESTBUG] Improve test coverage of MethodHandles.explicitCastArguments()

fov/8060717/webrev.00/ note that mine is a lower-case review and does not count, but: thumbs up. The level of detail at which the API is tested improves significantly with these changes. Best, Michael -- <http://www.oracle.com/> Dr. Michael Haupt | Principal Member of Technical Staff Ph

Re: [9] RFR: 8133543: [TESTBUG] java/lang/invoke/LFCaching/LFSingleThreadCachingTest.java should be modified

http://cr.openjdk.java.net/~kshefov/8133543/webrev.00/ > > -Konstantin -- <http://www.oracle.com/> Dr. Michael Haupt | Principal Member of Technical Staff Phone: +49 331 200 7277 | Fax: +49 331 200 7561 Oracle Java Platform Group | LangTools Team | Nashorn Oracle Deutschland B.V

RFR(S): 8136931: more fine-grained condition checking for BMH species creation

addressed. Thanks, Michael -- <http://www.oracle.com/> Dr. Michael Haupt | Principal Member of Technical Staff Phone: +49 331 200 7277 | Fax: +49 331 200 7561 Oracle Java Platform Group | LangTools Team | Nashorn Oracle Deutschland B.V. & Co. KG, Schiffbauergasse 14 | 14467 Potsda

Re: RFR(S): 8136931: more fine-grained condition checking for BMH species creation

Thank you; I will add this comment before pushing. Best, Michael -- <http://www.oracle.com/> Dr. Michael Haupt | Principal Member of Technical Staff Phone: +49 331 200 7277 | Fax: +49 331 200 7561 Oracle Java Platform Group | LangTools Team | Nashorn Oracle Deutschland B.V. & Co. KG, S

Re: RFR: JDK-8136893: Improve early java.lang.invoke infrastructure initialization

re first > `@run' Yes. The test is also marked as ignored until another issue is fixed, so that can be ignored. Other than the above remark/suggestion, this looks fine. I'll defer to an upper-case Reviewer, though. Best, Michael -- <http://www.oracle.com/> Dr. Michael

Re: RFR: JDK-8136893: Improve early java.lang.invoke infrastructure initialization

oint, and wasn't happy with my original proposal either. > Perhaps a note in the javadoc that this is the preferred method for internal > use would be sufficient? We can't make a reference from public method to the > package-private one in javadoc though. That's a good

RFR(XS): 8136967: revert all changes applied to obtain information about 8131129

detailed error logging for 8131129. These are no longer needed. Thanks, Michael -- <http://www.oracle.com/> Dr. Michael Haupt | Principal Member of Technical Staff Phone: +49 331 200 7277 | Fax: +49 331 200 7561 Oracle Java Platform Group | LangTools Team | Nashorn Oracle Deutschland B.V. &a

RFR(S): 8131129: Attempt to define a duplicate BMH$Species class

dHandle$Species_IL7" at sun.misc.Unsafe.defineClass(Native Method) at java.lang.invoke.BoundMethodHandle$Factory.generateConcreteBMHClass(BoundMethodHandle.java:715) at java.lang.invoke.BoundMethodHandle$SpeciesData.get(BoundMethodHandle.java:401) - -- <http://www.oracle.com/> Dr. Mic

Re: RFR(S): 8131129: Attempt to define a duplicate BMH$Species class

; LFMultiThreadCachingTest.lambda$doTest$0(LFMultiThreadCachingTest.java:80) >> at LFMultiThreadCachingTest$$Lambda$5/21979926.run(Unknown Source) >> at java.lang.Thread.run(Thread.java:745) >> STATUS:Failed.STATUS:Failed.STATUS:Failed.`main' threw exception: >

RFR(XS): 8139863: [TESTBUG] Need to port tests for JDK-8134903 to 8u-dev

belongs to. The backport was approved; see http://mail.openjdk.java.net/pipermail/jdk8u-dev/2015-September/004185.html. Thanks, Michael -- <http://www.oracle.com/> Dr. Michael Haupt | Principal Member of Technical Staff Phone: +49 331 200 7277 | Fax: +49 331 200 7561 Oracle Java Platform

Re: RFR(S): 8131129: Attempt to define a duplicate BMH$Species class

s that it is mostly a test problem, but java.lang.invoke >> framework should clearly communicate the reason why it fails. Since the >> test is aware about code cache overflow problems, it looks preferable to >> go with (1) or (3) for now. VM should throw VirtualMachineError on >> repeated attemp

[8u-dev] RFR(XS): 8139863: [TESTBUG] Need to port tests for JDK-8134903 to 8u-dev

(reposted with corrected subject line) > Am 29.10.2015 um 11:58 schrieb Michael Haupt : > > Dear all, > > cross-posted to jdk8u-dev and core-libs-dev. > > Please review this change. > Issue: https://bugs.openjdk.java.net/browse/JDK-8139863 > Webrev: http://cr.openj

[8u-dev] Request for review and approval: 8139863: [TESTBUG] Need to port tests for JDK-8134903 to 8u-dev

(Apologies for multiple posts with wrong subject lines.) > Dear all, > > cross-posted to jdk8u-dev and core-libs-dev. > > Please review this change. > Issue: https://bugs.openjdk.java.net/browse/JDK-8139863 > > Webrev: http://cr.openjdk.java.ne

Re: [8u-dev] Request for review and approval: 8139863: [TESTBUG] Need to port tests for JDK-8134903 to 8u-dev

All, the code in question has been reviewed already: http://mail.openjdk.java.net/pipermail/core-libs-dev/2015-February/031871.html Best, Michael > Am 02.11.2015 um 09:12 schrieb Michael Haupt : > > (Apologies for multiple posts with wrong subject lines.) > >> Dear all, &

Re: [8u-dev] Request for review and approval: 8139863: [TESTBUG] Need to port tests for JDK-8134903 to 8u-dev

Hi Rob, my bad. Thanks a lot! Michael > Am 04.11.2015 um 16:09 schrieb Rob McKenna : > > Sorry for the delay Michael, I had understood the subject to mean you were > waiting on another explicit review. > > Approved. > > -Rob > > On 04/11/15 08:3

Re: RFR(S): 8131129: Attempt to define a duplicate BMH$Species class

te that patched source now contains the same >> number of lines as original. How does the jigsaw HelloWorld score now? >> >> Regards, Peter > > Thanks, this looks really good to me. I verified that #classes are the same > and it even looks like footprint improves ever s

Re: RFR (S): 8141536, 8141539: Minor java.lang.invoke improvements

Bug: https://bugs.openjdk.java.net/browse/JDK-8141539 > > /Claes -- <http://www.oracle.com/> Dr. Michael Haupt | Principal Member of Technical Staff Phone: +49 331 200 7277 | Fax: +49 331 200 7561 Oracle Java Platform Group | LangTools Team | Nashorn Oracle Deutschland B.V. &

Re: RFR(S): 8131129: Attempt to define a duplicate BMH$Species class

gt; On 11/05/2015 02:16 PM, Michael Haupt wrote: >> Hi Claes, Peter, Vladimir, all, >> >> I really support Peter's latest proposal: it reduces the amounts of code, >> synchronisation, and complication, and actually addresses the problem at >> hand too. What

Re: RFR(S): 8131129: Attempt to define a duplicate BMH$Species class

not be static final when >>>> it is initialized out of . Just static. It was just static >>>> before when it was initialized in and could be static final. We >>>> can make it @Stable at least. >>>> >>> Not sure it is on hot path, but I&#x

RFR(L): 8139885: implement JEP 274: enhanced method handles

Dear all, please review this change. RFE: https://bugs.openjdk.java.net/browse/JDK-8139885 Corresponding JEP: https://bugs.openjdk.java.net/browse/JDK-8130227 Webrev: http://cr.openjdk.java.net/~mhaupt/8139885/webrev.00/ Thanks, Michael -- <http://www.oracle.com/> Dr. Michael

Re: RFR(L): 8139885: implement JEP 274: enhanced method handles

mbinators in InvokerBytecodeGenerator to compile them in more > efficient bytecode shapes. If yes, please, file corresponding RFEs. Absolutely; this is on my to-do list anyway. https://bugs.openjdk.java.net/browse/JDK-8143211 Best, Michael -- <http://www.oracle.com/> Dr. Michael Haupt | Prin

Re: RFR(L): 8139885: implement JEP 274: enhanced method handles

esult type = loop variable type, rather than result type = loop variable). > I guess in the future there may be ample opporunity to specialize the generic > “loop” mechanism with LambdaForms? Yep: https://bugs.openjdk.java.net/browse/JDK-8143211 Best, Michael -- <http://www.oracle

RFR(S): 8143798: jck failures: api/java_lang/invoke/MethodHandle/index_MethodsTests[asSpreaderWMTE]: java.lang.VerifyError: Bad type on operand stack

Dear all, please review this change. Bug: https://bugs.openjdk.java.net/browse/JDK-8143798 Webrev: http://cr.openjdk.java.net/~mhaupt/8143798/webrev.00/ The issue is an array iteration boundary bug in the JEP 274 implementation. Thanks, Michael -- <http://www.oracle.com/> Dr. Michael

Re: RFR(S): 8131129: Attempt to define a duplicate BMH$Species class

Hello, FYI, I've requested backport approval for this fix to 8u. http://mail.openjdk.java.net/pipermail/jdk8u-dev/2015-November/004540.html Best, Michael > Am 09.11.2015 um 16:28 schrieb Michael Haupt : > > ... thanks a lot, Peter and Vladimir! > > Best, > > Mich

Re: RFR: 8143131: Remove unused code from java.lang.invoke

://bugs.openjdk.java.net/browse/JDK-8143131 > Webrev: http://cr.openjdk.java.net/~redestad/8143131/webrev.01/ > > /Claes -- <http://www.oracle.com/> Dr. Michael Haupt | Principal Member of Technical Staff Phone: +49 331 200 7277 | Fax: +49 331 200 7561 Oracle Java Platform

RFR(XS): 8076596: BytecodeDescriptor.parseMethod doesn't work during bootstrapping

bug. It is not reproducible in current 9-dev and jake builds. Thanks, Michael -- <http://www.oracle.com/> Dr. Michael Haupt | Principal Member of Technical Staff Phone: +49 331 200 7277 | Fax: +49 331 200 7561 Oracle Java Platform Group | LangTools Team | Nashorn Oracle Deutschland B.V

RFR(S): 8143343: add JEP 274 Javadoc tests to JavaDocExamplesTest

-- <http://www.oracle.com/> Dr. Michael Haupt | Principal Member of Technical Staff Phone: +49 331 200 7277 | Fax: +49 331 200 7561 Oracle Java Platform Group | LangTools Team | Nashorn Oracle Deutschland B.V. & Co. KG, Schiffbauergasse 14 | 14467 Potsdam, Germany <http://www.oracle.c

RFR(XS): 8072844: Use more efficient LambdaForm type representation

Dear all, please review this change. RFE: https://bugs.openjdk.java.net/browse/JDK-8072844 Webrev: http://cr.openjdk.java.net/~mhaupt/8072844/webrev.00 Thanks, Michael -- <http://www.oracle.com/> Dr. Michael Haupt | Principal Member of Technical Staff Phone: +49 331 200 7277 | Fax: +

Re: RFR(XS): 8072844: Use more efficient LambdaForm type representation

uires further analysis: it is used in LF bytecode generation and DMH creation only. I'll keep it out of this change but bear it in mind. Thanks, Michael > Am 03.12.2015 um 11:05 schrieb Michael Haupt : > > Dear all, > > please review this change. > RFE: https://bugs.openjdk

Re: RFR(XS): 8072844: Use more efficient LambdaForm type representation

InterpreterEntryPoint(Type > rType, Type[] pTypes) { A MethodType is an apt abstraction for what is needed here; I don't think breaking it up into its components would help much. Thanks, Michael -- <http://www.oracle.com/> Dr. Michael Haupt | Principal Member of Technical Staf

Re: RFR(S): 8144723: MethodHandleImpl.initStatics is no longer needed

unctions that can be made lazily initialized, which > defers 6 classes from loading eagerly in startup tests that use lambdas > explicitly. > > Thanks! > > /Claes -- <http://www.oracle.com/> Dr. Michael Haupt | Principal Member of Technical Staff Phone: +49 331 200

RFR(XS): 8081512: Remove sun.invoke.anon classes, or move / co-locate them with tests

gt; Dr. Michael Haupt | Principal Member of Technical Staff Phone: +49 331 200 7277 | Fax: +49 331 200 7561 Oracle Java Platform Group | LangTools Team | Nashorn Oracle Deutschland B.V. & Co. KG, Schiffbauergasse 14 | 14467 Potsdam, Germany <http://www.oracle.com/commitment> Oracle

Re: RFR(XS): 8081512: Remove sun.invoke.anon classes, or move / co-locate them with tests

(... please ignore the "and sponsor" part ...) > Am 08.12.2015 um 10:37 schrieb Michael Haupt : > > Dear all, > > please review and sponsor this change. > RFE: https://bugs.openjdk.java.net/browse/JDK-8081512 > Webrev: http://cr.openjdk.java.net/~mhaupt/808

RFR(S): 8146786: [TESTBUG] straighten out testability for several issues

-- <http://www.oracle.com/> Dr. Michael Haupt | Principal Member of Technical Staff Phone: +49 331 200 7277 | Fax: +49 331 200 7561 Oracle Java Platform Group | LangTools Team | Nashorn Oracle Deutschland B.V. & Co. KG, Schiffbauergasse 14 | 14467 Potsdam, Germany <http://www.oracle.c

RFR(S): 8147078: MethodHandles.catchException does not enforce Throwable subtype

. The change adds the corresponding check, and a test. Thanks, Michael -- <http://www.oracle.com/> Dr. Michael Haupt | Principal Member of Technical Staff Phone: +49 331 200 7277 | Fax: +49 331 200 7561 Oracle Java Platform Group | LangTools Team | Nashorn Oracle Deutschland B.V. &a

Re: API review of VarHandles

sking the Unsafe users of the > world to switch to dynamic VarHandle is like asking C programmers to > rewrite their code in perl 6 ... for performance! It's the same > "srsly?" feeling one gets reading """We can currently use RPerl to > speed up low-magic

Re: RFR 8138578:MethodHandles.Lookup.findSpecial() Javadoc fails to consider static methods

;> >> Please review the updated patch- >> >> http://cr.openjdk.java.net/~srastogi/8138578/webrev.01/ >> >> I verified Lookup.unreflectSpecial() also throws >> java.lang.IllegalAccessException so updated the JavaDoc. >> >> Thanks, >> Shilpi --

Re: RFR 8138884:MethodHandles.Lookup.findVirtual() Javadoc fails to consider private interface methods

dk.java.net/~srastogi/8138884/webrev.01/ >> <http://cr.openjdk.java.net/~srastogi/8138884/webrev.01/> >> > > Just add a “,” after the new statement > > .. {@code static}, > > No need for another review. > > >> Same is not applicable for "Lookup.unref

Re: RFR: 8071368 Use more concrete types for NamedFunction constants in the code

Object) in the MH >>>> runtime is an artifact of bootstrapping difficulties, early in the >>>> project. I hope it is not necessary any more." >>>> >>>> Best regards, >>>> Vladimir Ivanov >>>> > -- <http://www.or

Re: RFR 8144931: Assert class signatures are correct and refer to valid classes

~srastogi/8144931/webrev.03/ >> > > +1 > > Paul. -- <http://www.oracle.com/> Dr. Michael Haupt | Principal Member of Technical Staff Phone: +49 331 200 7277 | Fax: +49 331 200 7561 Oracle Java Platform Group | LangTools Team | Nashorn Oracle Deutschland B.V. & Co. KG |

RFR(S): 8150360: augment/correct MethodHandle API documentation

() * MethodHandles.collectArguments(), .dropArguments(), .filterArguments(), .filterReturnValue(), .foldArguments(), .permuteArguments() Thanks, Michael -- <http://www.oracle.com/> Dr. Michael Haupt | Principal Member of Technical Staff Phone: +49 331 200 7277 | Fax: +49 331 200 7561 Oracle Java Pl

RFR(S): 8143410: augment pseudo-code descriptions in MethodHandles API

: catchException(), collectArguments(), filterArguments(), filterReturnValue(), foldArguments(), and guardWithTest(). Thanks, Michael -- <http://www.oracle.com/> Dr. Michael Haupt | Principal Member of Technical Staff Phone: +49 331 200 7277 | Fax: +49 331 200 7561 Oracle Java Platform

Re: RFR(S): 8150360: augment/correct MethodHandle API documentation

d and pushed. Best, Michael -- <http://www.oracle.com/> Dr. Michael Haupt | Principal Member of Technical Staff Phone: +49 331 200 7277 | Fax: +49 331 200 7561 Oracle Java Platform Group | LangTools Team | Nashorn Oracle Deutschland B.V. & Co. KG | Schiffbauergasse 14 | 1446

Re: RFR(S): 8143410: augment pseudo-code descriptions in MethodHandles API

seudocode examples? That might be more changes than you wanna apply in this > case :-) You're right, the naming should be consistent. I've applied this throughout. Best, Michael -- <http://www.oracle.com/> Dr. Michael Haupt | Principal Member of Technical Staff Phone: +49

Re: RFR(S): 8143410: augment pseudo-code descriptions in MethodHandles API

Hi Paul, thanks - all right; I'll consider using "and" rather than "/" and push the result. Best, Michael > Am 23.02.2016 um 09:13 schrieb Paul Sandoz : > >> >> On 23 Feb 2016, at 07:39, Michael Haupt wrote: >> >> Hi Paul, >>

RFR(M): 8150635: j.l.i.MethodHandles.loop(...) throws IndexOutOfBoundsException

details and examples. Thanks, Michael -- <http://www.oracle.com/> Dr. Michael Haupt | Principal Member of Technical Staff Phone: +49 331 200 7277 | Fax: +49 331 200 7561 Oracle Java Platform Group | LangTools Team | Nashorn Oracle Deutschland B.V. & Co. KG | Schiffbauergasse 14 | 144

RFR(S): 8150825: MethodHandles.tryFinally throws IndexOutOfBoundsException for non-conforming parameter lists

-- <http://www.oracle.com/> Dr. Michael Haupt | Principal Member of Technical Staff Phone: +49 331 200 7277 | Fax: +49 331 200 7561 Oracle Java Platform Group | LangTools Team | Nashorn Oracle Deutschland B.V. & Co. KG | Schiffbauergasse 14 | 14467 Potsdam, Germany ORACLE Deutschland B.V

Re: RFR(S): 8150825: MethodHandles.tryFinally throws IndexOutOfBoundsException for non-conforming parameter lists

ng nagged me for a while, I'll do it at some point in the near future (probably by piggybacking the renaming onto something else). :-) Best, Michael -- <http://www.oracle.com/> Dr. Michael Haupt | Principal Member of Technical Staff Phone: +49 331 200 7277 | Fax: +49 331 200 75

Re: RFR(M): 8150635: j.l.i.MethodHandles.loop(...) throws IndexOutOfBoundsException

E here: https://bugs.openjdk.java.net/browse/JDK-8150832 A new webrev with the above changes (save the renaming) is at http://cr.openjdk.java.net/~mhaupt/8150635/webrev.01 Best, Michael -- <http://www.oracle.com/> Dr. Michael Haupt | Principal Member of Technical Staff Phone: +49 331 200 72

Re: RFR(M): 8150635: j.l.i.MethodHandles.loop(...) throws IndexOutOfBoundsException

Hi Paul, > Am 29.02.2016 um 14:46 schrieb Paul Sandoz : >> A new webrev with the above changes (save the renaming) is at >> http://cr.openjdk.java.net/~mhaupt/8150635/webrev.01 >> > > +1 thank you. I'll push once CCC approves. Best, Michael -- <http:/

RFR(XS): 8150953: j.l.i.MethodHandles: example section in whileLoop(...) provides example for doWhileLoop

(). Thanks, Michael -- <http://www.oracle.com/> Dr. Michael Haupt | Principal Member of Technical Staff Phone: +49 331 200 7277 | Fax: +49 331 200 7561 Oracle Java Platform Group | LangTools Team | Nashorn Oracle Deutschland B.V. & Co. KG | Schiffbauergasse 14 | 14467 Potsdam, Germa

RFR(M): 8150832: split T8139885 into several tests by functionality

declarative annotations were introduced where it made sense. Thanks, Michael -- <http://www.oracle.com/> Dr. Michael Haupt | Principal Member of Technical Staff Phone: +49 331 200 7277 | Fax: +49 331 200 7561 Oracle Java Platform Group | LangTools Team | Nashorn Oracle Deutschland B.V

Re: RFR(M): 8150832: split T8139885 into several tests by functionality

Hi Claes, thanks a lot, and I agree with the renaming. Best, Michael > Am 02.03.2016 um 13:59 schrieb Claes Redestad : > > Hi, > > this looks good to me. > > Maybe rename LoopTest to LoopCombinatorTest to add a bit of specificity? > > /Claes > > On 2016

RFR(S): 8150957: j.l.i.MethodHandles.whileLoop(...) fails with IOOBE in the case 'init' is null, 'step' and 'pred' have parameters

ttp://www.oracle.com/> Dr. Michael Haupt | Principal Member of Technical Staff Phone: +49 331 200 7277 | Fax: +49 331 200 7561 Oracle Java Platform Group | LangTools Team | Nashorn Oracle Deutschland B.V. & Co. KG | Schiffbauergasse 14 | 14467 Potsdam, Germany ORACLE Deutschland B.V. & Co. KG | H

Re: RFR(S): 8150957: j.l.i.MethodHandles.whileLoop(...) fails with IOOBE in the case 'init' is null, 'step' and 'pred' have parameters

w.oracle.com/> Dr. Michael Haupt | Principal Member of Technical Staff Phone: +49 331 200 7277 | Fax: +49 331 200 7561 Oracle Java Platform Group | LangTools Team | Nashorn Oracle Deutschland B.V. & Co. KG | Schiffbauergasse 14 | 14467 Potsdam, Germany ORACLE Deutschland B.V. & Co. KG | Haupt

RFR(S): 8150782: findClass / accessClass throw unexpected exceptions

change contains some tests that illustrate these cases. CCC approval is pending. Thanks, Michael -- <http://www.oracle.com/> Dr. Michael Haupt | Principal Member of Technical Staff Phone: +49 331 200 7277 | Fax: +49 331 200 7561 Oracle Java Platform Group | LangTools Team | Nashorn

Re: RFR(S): 8150782: findClass / accessClass throw unexpected exceptions

> determined if the loaded class is accessible to this lookup object" > or something like that. > accessClass() probably doesn't need to mention a class loader at all, to > avoid confusion. > > BTW, I've noticed one more thing: > > @throws Clas

RFR(XS): 8151778: TestLookup.java fails after push of JDK-8150782

Dear all, please review this one-line fix. Bug: https://bugs.openjdk.java.net/browse/JDK-8151778 Webrev: http://cr.openjdk.java.net/~mhaupt/8151778/webrev.00/ TestLookup is lacking a @compile directive. Thanks, Michael -- <http://www.oracle.com/> Dr. Michael Haupt | Principal Mem

RFR (XS): 8033465: JSR292: InvokerBytecodeGenerator: convert a check for REF_invokeVirtual on an interface into an assert

Dear all, please review and sponsor this change. Bug: https://bugs.openjdk.java.net/browse/JDK-8033465 Change: http://cr.openjdk.java.net/~mhaupt/8033465/webrev.00/ Thanks, Michael -- <http://www.oracle.com/> Dr. Michael Haupt | Principal Member of Technical Staff Phone: +49 331 20

Re: RFR (XS): 8033465: JSR292: InvokerBytecodeGenerator: convert a check for REF_invokeVirtual on an interface into an assert

... thank you very much, Vladimir! Best, Michael > Am 07.04.2015 um 14:17 schrieb Vladimir Ivanov : > > Looks good. > > I'll push it for you. > > Best regards, > Vladimir Ivanov > > On 4/7/15 1:23 PM, Michael Haupt wrote: >> Dear all, >> >&

RFR (S): 8076461: JSR292: remove unused native and constants

class. RFE: https://bugs.openjdk.java.net/browse/JDK-8076461 Changes: http://cr.openjdk.java.net/~mhaupt/8076461/webrev.00/ Tested with JPRT, HotSpot testset. Thanks, Michael -- <http://www.oracle.com/> Dr. Michael Haupt | Principal Member of Technical Staff Phone: +49 331 200 7277 | Fa

Re: RFR (S): 8076461: JSR292: remove unused native and constants

Hello, in case anyone was wondering about the empty changeset in the webrev: that's fixed now. Thanks to Vladimir I. for pointing out the glitch in my webrev creation approach. :-) Best, Michael > Am 07.04.2015 um 21:11 schrieb Michael Haupt : > > Dear all, > > pleas

Re: RFR (S): 8076461: JSR292: remove unused native and constants

tants class to clarify its role a bit. Local tests and JPRT are still happy with this. Updated webrev: http://cr.openjdk.java.net/~mhaupt/8076461/webrev.01/ Best, Michael > Am 07.04.2015 um 23:49 schrieb John Rose : > > On Apr 7, 2015, at 12:11 PM, Michael Haupt wrote: >> >&g

Re: RFR (S): 8076461: JSR292: remove unused native and constants

you can. We > probably stopped using any of those when we started using ASM. > > Thanks! > > — John > > On Apr 13, 2015, at 4:40 AM, Michael Haupt wrote: >> >> Hi John, >> >> thank you very much for your review; keeping the Constants class around for >

Re: RFR (S): 8076461: JSR292: remove unused native and constants

... thank you, Vladimir! Best, Michael > Am 14.04.2015 um 13:47 schrieb Vladimir Ivanov : > > Looks good. > > I'll push it for you. > > Best regards, > Vladimir Ivanov -- <http://www.oracle.com/> Dr. Michael Haupt | Principal Member of Technical Staff

RFR (XS): 8030680: 292 cleanup from default method code assessment

hotspot test set. Thanks, Michael -- <http://www.oracle.com/> Dr. Michael Haupt | Principal Member of Technical Staff Phone: +49 331 200 7277 | Fax: +49 331 200 7561 Oracle Java Platform Group | HotSpot Compiler Team Oracle Deutschland B.V. & Co. KG, Schiffbauergasse 14 | 14467 Potsda

Re: RFR (XS): 8030680: 292 cleanup from default method code assessment

Hello again, forgive me; this is the wrong list. Best, Michael > Am 23.04.2015 um 21:08 schrieb Michael Haupt : > > Hello, > > please review and sponsor this change. > RFE: https://bugs.openjdk.java.net/browse/JDK-8030680 > Webrev: http://cr.openjdk.java.net/~mha

Re: RFR 8150829: Enhanced drop-args, identity and default constant, varargs adjustment

ava.net/browse/JDK-8150829 > http://cr.openjdk.java.net/~srastogi/8150829/webrev.04 > > > Thanks, > Shilpi -- <http://www.oracle.com/> Dr. Michael Haupt | Principal Member of Technical Staff Phone: +49 331 200 7277 | Fax: +49 331 200 7561 Oracle Java Platform Group |

Re: RFR 8152645 VarHandle lookup access control tests

t; <http://cr.openjdk.java.net/~psandoz/jdk9/JDK-8152645-VH-access-control/webrev/> > > For completeness i also added tests for MH as i could not find any such > existing tests. > > > Further follow on work might be to test lookup to fields across module > boundarie

Re: RFR 8151706: Update VarHandle implementation to use @Stable arrays

VarHandle implementation. It should also be > possible to lazily create MemberName instances as required, rather than > aggressively doing so, which may further reduce initialization costs and > memory usage in common cases. > > Paul. -- <http://www.oracle.com/> Dr. Mi

Re: RFR 8151705 VarHandle.AccessMode enum names should conform to code style

8 public static AccessMode valueFromMethodName(String methodName) { > 1199 AccessMode am = methodNameToAccessMode.get(methodName); > 1200 if (am != null) return am; > 1201 throw new IllegalArgumentException("No AccessMode value for > method n

RFR(S): 8153637: MethodHandles.countedLoop/3 initialises loop counter to 1 instead of 0

counter increment to the end of the loop (requires argument permutation). Thanks, Michael -- <http://www.oracle.com/> Dr. Michael Haupt | Principal Member of Technical Staff Phone: +49 331 200 7277 | Fax: +49 331 200 7561 Oracle Java Platform Group | LangTools Team | Nashorn Oracle Deutschla

RFR(S): 8150824: Exceptions when omitting trailing arguments in cleanup

ttp://www.oracle.com/> Dr. Michael Haupt | Principal Member of Technical Staff Phone: +49 331 200 7277 | Fax: +49 331 200 7561 Oracle Java Platform Group | LangTools Team | Nashorn Oracle Deutschland B.V. & Co. KG | Schiffbauergasse 14 | 14467 Potsdam, Germany ORACLE Deutschland B.V

RFR(S): 8150956: j.l.i.MethodHandles.whileLoop(...) and .iteratedLoop(...) throw unexpected exceptions in the case of 'init' return type is void

Dear all, please review this change. Bug: https://bugs.openjdk.java.net/browse/JDK-8150956 Webrev: http://cr.openjdk.java.net/~mhaupt/8150956/webrev.00/ Thanks, Michael -- <http://www.oracle.com/> Dr. Michael Haupt | Principal Member of Technical Staff Phone: +49 331 200 7277 | Fax: +

RFR(S): 8152667: MHs.iteratedLoop(...) throws unexpected WMTE, disallows Iterator subclasses, generates inconsistent loop result type

Dear all, please review this change. Bug: https://bugs.openjdk.java.net/browse/JDK-8152667 Webrev: http://cr.openjdk.java.net/~mhaupt/8152667/webrev.00/ Thanks, Michael -- <http://www.oracle.com/> Dr. Michael Haupt | Principal Member of Technical Staff Phone: +49 331 200 7277 | Fax: +

RFR(S): 8154751: MethodHandles.countedLoop does not accept empty bodies

Dear all, please review this change. Bug: https://bugs.openjdk.java.net/browse/JDK-8154751 Webrev: http://cr.openjdk.java.net/~mhaupt/8154751/webrev.00/ Thanks, Michael -- <http://www.oracle.com/> Dr. Michael Haupt | Principal Member of Technical Staff Phone: +49 331 200 7277 | Fax: +

RFR(S): 8154754: MethodHandles.countedLoop errors in deriving loop arguments, result type, and local state

/040386.html -- <http://www.oracle.com/> Dr. Michael Haupt | Principal Member of Technical Staff Phone: +49 331 200 7277 | Fax: +49 331 200 7561 Oracle Java Platform Group | LangTools Team | Nashorn Oracle Deutschland B.V. & Co. KG | Schiffbauergasse 14 | 14467 Potsdam, Germa

Re: RFR(S): 8152667: MHs.iteratedLoop(...) throws unexpected WMTE, disallows Iterator subclasses, generates inconsistent loop result type

nly used if iterator == null, thus could be refactored > into an if (iterator == null) ... else construct > > Thanks! > > /Claes > > On 2016-04-20 11:25, Michael Haupt wrote: >> Dear all, >> >> please review this change. >> Bug: https://bugs.op

Re: RFR(S): 8154751: MethodHandles.countedLoop does not accept empty bodies

eturnType()) is used > twice, breaking it out to variable would improve readability, possibly > performance. Same goes for the subexpression init.type().returnType() which > is used three times currently. > > Otherwise it looks fine to me. > > Thanks! > > /Claes > >

Re: RFR(S): 8154754: MethodHandles.countedLoop errors in deriving loop arguments, result type, and local state

e == void.class ? zero(void.class) : > identity(resultType) appears twice and unconditionally used at least once, > thus could be profitably extracted to a variable for readability/imaginary > performance gain. Thanks! /Claes > > On 2016-04-20 15:46, Michael Haupt wrote: >>

RFR(XS): 8155214: java/lang/invoke/PermuteArgsTest.java fails due to exhausted code cache

-- <http://www.oracle.com/> Dr. Michael Haupt | Principal Member of Technical Staff Phone: +49 331 200 7277 | Fax: +49 331 200 7561 Oracle Java Platform Group | LangTools Team | Nashorn Oracle Deutschland B.V. & Co. KG | Schiffbauergasse 14 | 14467 Potsdam, Germany ORACLE Deutschland

RFR(S): 8155106: MHs.Lookup.findConstructor returns handles for array classes

Dear all, please review this change. Bug: https://bugs.openjdk.java.net/browse/JDK-8155106 Webrev: http://cr.openjdk.java.net/~mhaupt/8155106/webrev.00/ Thanks, Michael -- <http://www.oracle.com/> Dr. Michael Haupt | Principal Member of Technical Staff Phone: +49 331 200 7277 | Fax: +

Re: RFR[9]:java/lang/invoke/VarargsArrayTest.java miss othervm for main/bootclasspath mode

t; > Please review one small fix for > > https://bugs.openjdk.java.net/browse/JDK-8155791 > http://cr.openjdk.java.net/~srastogi/8155791/webrev.00/ > > Thanks, > Shilpi -- <http://www.oracle.com/> Dr. Michael Haupt | Principal Member of Technical Staff Phone: +49 331

Re: RFR[9]:Fix java/lang/invoke/MethodHandleImpl's use of Unsafe.defineAnonymousClass()

s name index form constant pool and patch it > with new name > http://cr.openjdk.java.net/~srastogi/8149574/webrev.05/ > > 2. Create class with new name (With ASM) > http://cr.openjdk.java.net/~srastogi/8149574/webrev.06/ > > Which approach is better? > > Thanks, > Shi

Re: RFR[9]:java/lang/invoke/VarargsArrayTest.java miss othervm for main/bootclasspath mode

rmTest.java" StatusError Parse > Exception: [-esa]: vm option(s) found, need to specify /othervm > > Thanks, > Shilpi > > On 5/11/2016 6:47 PM, Michael Haupt wrote: >> Hi Shilpi, >> >> not a review - the bug mentions that this issue is fixed in Jake a

Re: RFR[9]:Fix java/lang/invoke/MethodHandleImpl's use of Unsafe.defineAnonymousClass()

class package name with the package name >>>> of its host class. >>>> >>>> Two approaches to solve this- >>>> 1. Parse .class and get the class name index form constant pool and >>>> patch it with new name >>>> http://cr.ope

Re: MethodHandle for array length

assertEquals(Iterate.MT_sum, loop.type()); assertEquals(21, loop.invoke(new Integer[]{1, 2, 3, 4, 5, 6})); } ... where MH_sumIterator is a handle to this method: static Iterator sumIterator(Integer[] a) { return Arrays.asList(a).iterator(); } Best, Michael -- <http://www.oracle.com/> Dr.

RFR(M): 8156915: introduce MethodHandle factory for array length

Dear all, please review this change. RFE: https://bugs.openjdk.java.net/browse/JDK-8156915 Webrev: http://cr.openjdk.java.net/~mhaupt/8156915/webrev.00/ Thanks, Michael -- <http://www.oracle.com/> Dr. Michael Haupt | Principal Member of Technical Staff Phone: +49 331 200 7277 | Fax: +

Re: MethodHandle for array length

> - > Uwe Schindler > uschind...@apache.org > ASF Member, Apache Lucene PMC / Committer > Bremen, Germany > http://lucene.apache.org/ > >> -Original Message- >> From: Remi Forax [mailto:fo...@univ-mlv.fr] >> Sent: Friday, May 13, 2016 10:37 AM >>

Re: MethodHandle for array length

ommitter > Bremen, Germany > http://lucene.apache.org/ > >> -Original Message- >> From: Uwe Schindler [mailto:uschind...@apache.org] >> Sent: Friday, May 13, 2016 11:55 AM >> To: 'Remi Forax' >> Cc: 'Michael Haupt' ; 'Core-Libs-Dev

Re: RFR(M): 8156915: introduce MethodHandle factory for array length

gt; Otherwise, looks good! > > Best regards, > Vladimir Ivanov > > On 5/18/16 10:52 AM, Michael Haupt wrote: >> Dear all, >> >> please review this change. >> RFE: https://bugs.openjdk.java.net/browse/JDK-8156915 >> Webrev: http://cr.openjdk.java.net/~mh

Re: RFR(M): 8156915: introduce MethodHandle factory for array length

oc. > Probably no need to go deep in details on how, for example, > arrayElementGetter(T) maps on 8 Taload instructions, > but just give a basic notion of that. > > WDYT? Should I file a separate RFE for that? (for arrayElementGetter/Setter? > for all three?) > > Thanks,

RFR(XS): 8157590: MethodHandles.arrayLength() lacks @since tag, implementation throws wrong exception

Dear all, please review this fix. Bug: https://bugs.openjdk.java.net/browse/JDK-8157590 Webrev: http://cr.openjdk.java.net/~mhaupt/8157590/webrev.00/ Thanks, Michael -- <http://www.oracle.com/> Dr. Michael Haupt | Principal Member of Technical Staff Phone: +49 331 200 7277 | Fax: +

Re: RFR(M): 8156915: introduce MethodHandle factory for array length

structor has @since 9, but arrayLength() not. > > Uwe -- <http://www.oracle.com/> Dr. Michael Haupt | Principal Member of Technical Staff Phone: +49 331 200 7277 | Fax: +49 331 200 7561 Oracle Java Platform Group | LangTools Team | Nashorn Oracle Deutschland B.V. & Co. KG | Sc

Re: RFR[9]: 8156868 MethodHandles.zero(Class) doc issues

cr.openjdk.java.net/~srastogi/8156868/webrev.02/ >> > > +1 > > Paul. -- <http://www.oracle.com/> Dr. Michael Haupt | Principal Member of Technical Staff Phone: +49 331 200 7277 | Fax: +49 331 200 7561 Oracle Java Platform Group | LangTools Team | Nashorn Oracle Deut

Re: RFR[9]:MethodHandles.dropArgumentsToMatch(...) non-documented IAE

net/~srastogi/8158171/webrev.00/ > > > Thanks, > Shilpi -- <http://www.oracle.com/> Dr. Michael Haupt | Principal Member of Technical Staff Phone: +49 331 200 7277 | Fax: +49 331 200 7561 Oracle Java Platform Group | LangTools Team | Nashorn Oracle Deutschland B.V. & Co. KG | S

Re: RFR[9]:MethodHandles.dropArgumentsToMatch(...) non-documented IAE

Hi Shilpi, CCC approval is in. My review is lower-case, so another one is needed ere I can sponsor the push. Best, Michael > Am 02.06.2016 um 14:53 schrieb Michael Haupt : > > Hi Shilpi, > > lower-case thumbs up. Please obtain CCC approval for this change. > > Best,

  1   2   >