Re: [darktable-dev] Possible alternative to Markesteijn x-trans demosaic?

2016-03-21 Thread johannes hanika
hi ingo, very interesting. do you know why the shadow tone of the font on the toothpaste looks so different? looks like you're losing some contrast as compared to markesteijn? or is m. oversharpening? sad to see how the thin branches in the trees have these colourful fringes. i guess that would g

Re: [darktable-dev] Possible alternative to Markesteijn x-trans demosaic?

2016-03-30 Thread johannes hanika
he Liebhardt >> algorithm would be similarly improved. >> >> Ingo: Have you read the ChromaSoft blog entries on X-Trans demosaicing? >> (Starting at >> http://chromasoft.blogspot.com/2012/05/demosaicing-fuji-x-pro1-and-its-x-trans.html >> and ongoing.) I found them e

Re: [darktable-dev] Some Questions on monochrome

2016-04-09 Thread johannes hanika
heya, On Sat, Apr 9, 2016 at 9:53 AM, Helena Henkel wrote: > Thank you for the quick response. > > > Am 08.04.2016 um 23:38 schrieb Roman Lebedev: >> On Sat, Apr 9, 2016 at 12:23 AM, Helena Henkel >> wrote: >>> Hallo, >> Hi. >> >>> thank you for your good work on darktable. >>> >>> I have two q

Re: [darktable-dev] Some Questions on monochrome

2016-04-09 Thread johannes hanika
see d6a0066bfd22e621eab4f82ec0958d3a930ff052 -j. On Sat, Apr 9, 2016 at 11:43 PM, johannes hanika wrote: > heya, > > On Sat, Apr 9, 2016 at 9:53 AM, Helena Henkel > wrote: >> Thank you for the quick response. >> >> >> Am 08.04.2016 um 23:38 schrieb Roman Le

Re: [darktable-dev] Darktable plug-in in GIMP - Darktable for Windows?

2016-04-20 Thread johannes hanika
hi all, let me try to answer some details from the dt side: On Wed, Apr 20, 2016 at 6:46 AM, Sven Claussner wrote: > Hi, > > sorry if I'm asking the wrong question but I feel I have to. > Since 18.04.2016 there is a raw importer plug-in in GIMP master > that calls darktable to do its job. With t

Re: [darktable-dev] cannot build current git

2016-04-24 Thread johannes hanika
i really think this compiler warning is stupid. leads to all sorts of idiotic non-error handling code around fscanf and the likes. can you try current master again? j. On Sun, Apr 24, 2016 at 7:18 AM, Christian Tellefsen wrote: > On 23. april 2016 19:23, Alexander Rabtchevich wrote: >> >> Hello

Re: [darktable-dev] cannot build current git

2016-04-24 Thread johannes hanika
t; ^ > /home/sasha/Install/darktable/src/lut/pfm.c:41:9: error: ignoring return > value of ‘fscanf’, declared with attribute warn_unused_result > [-Werror=unused-result] >fscanf(f, " %63s ", scale_factor_string); > ^ > cc1: all warnings being

Re: [darktable-dev] X-Trans torture tests

2016-04-26 Thread johannes hanika
heya, On Wed, Apr 27, 2016 at 6:04 AM, J. Liles wrote: > Group, > > I've recently acquired a camera with an X-Trans sensor, and have had little > trouble generating images that contain areas prone to demosaicing artifacts. hehe, i know what you mean. > Is anyone interested in these? If so, is t

Re: [darktable-dev] sRGB internal color profile

2016-04-27 Thread johannes hanika
heya, i can't reproduce. is there anything else? can you share an .xmp sidecar file so we can precisely reproduce your steps? and just to double check: you are talking export, not display, right? so it can't be a display profile issue. are you using any particular icc profile as input colour space

Re: [darktable-dev] Re: X-Trans torture tests

2016-04-27 Thread johannes hanika
my 2min-version of the 2nd image: https://jo.dreggn.org/neon.jpg the neon lights are indeed something that doesn't seem to be covered well at all by the reference it8 chart. we probably need to somehow extend the darktable-lut module to read not only well defined colour patches but also random im

Re: [darktable-dev] Re: X-Trans torture tests

2016-04-27 Thread johannes hanika
it if > wanted. > > I’m working on the performance now. > > Cheers, > Ingo > > > > Am 27.04.2016 um 18:16 schrieb J. Liles : > > > > On Wed, Apr 27, 2016 at 6:56 AM, johannes hanika wrote: >> >> my 2min-version of the 2nd image: >> >

Re: [darktable-dev] Re: X-Trans torture tests

2016-04-27 Thread johannes hanika
I’m working on the performance now. > > Cheers, > Ingo > > > > Am 27.04.2016 um 18:16 schrieb J. Liles : > > > > On Wed, Apr 27, 2016 at 6:56 AM, johannes hanika wrote: >> >> my 2min-version of the 2nd image: >> >> https://jo.dreggn.org/neon.j

Re: [darktable-dev] Green Artifacts in Denoise

2016-04-27 Thread johannes hanika
heya, usually that means that the profiling underestimates the actual amount of noise in your shot. is the camera old or was it warm? does it improve if you manually select a higher iso from the combobox dropdown? -jo On Thu, Apr 28, 2016 at 6:22 AM, Maximilian Trescher wrote: > Hi there, > > W

Re: [darktable-dev] Re: X-Trans torture tests

2016-04-27 Thread johannes hanika
[..] > You've lost the color of the sunset on the lettering on the clock face > though. oh, i bet that's the classic chrome film style. i just applied one from the list to get a fuji-like tonecurve, since those affect saturation of colours as well as the contrast a lot. > This is not the best te

Re: [darktable-dev] More on the topic of X-Trans II demosaicing

2016-05-04 Thread johannes hanika
hi, i would agree that this looks like a bug in the markesteijn algorithm. another thing to try is probably the green equilibration thing that some bayer sensors suffered from. that there was some spill from blue -> one green and red-> the other green (same line of the sensor, maybe during readout

Re: [darktable-dev] Contribution

2016-05-07 Thread johannes hanika
ooh, nice! papers to implement :) one that's been on my list for quite a while but i never got around to do it is this: http://people.csail.mit.edu/sparis/#cacm15 http://people.csail.mit.edu/sparis/publi/2015/cacm/Paris_15_Local_Laplacian_Filters.pdf which can separate coarse/fine detail without

Re: [darktable-dev] sRGB internal color profile

2016-05-07 Thread johannes hanika
e minimal options that create the problem in blue shades. > The arw file is there : https://1fichier.com/?8khnco34cy > > darktable version 2.1.0+1080~gfedb40 > > Jean-marc > > > > > Le 27/04/2016 à 15:06, johannes hanika a écrit : >> >> heya, >> >&

Re: [darktable-dev] Contribution

2016-05-08 Thread johannes hanika
hi wolfgang, great to hear you're interested in this! On Mon, May 9, 2016 at 2:11 AM, Tobias Ellinghaus wrote: > Am Sonntag, 8. Mai 2016, 15:07:49 schrieb Wolfgang Mader: > > [...] > >> Licence of the Matlab implementation of the Local Laplacian Filters >> "Start quote" >> Copyright (c) 2011 Sam

[darktable-dev] Re: Local Laplacian Filter

2016-05-12 Thread johannes hanika
heya, sorry for the delay, i had half of this mail sitting in my drafts folder for quite some time now. On Tue, May 10, 2016 at 12:54 AM, Wolfgang Mader wrote: > Hi Johannes, > > I write this mail personally to you since I am not sure if my excerpt of the > paper is too detailed for the list. As

Re: [darktable-dev] Darktable will not start

2016-05-13 Thread johannes hanika
hi, On Fri, May 13, 2016 at 1:34 PM, Blickwinkel wrote: > Help! Darktable will not start > > I don't now what happened. I haven't change anything > > This is the message at the terminal > > franjo@franjo-desktop ~ $ darktable > [Thread debugging using libthread_db enabled] > Using host libthread_

Re: [darktable-dev] Darktable will not start

2016-05-13 Thread johannes hanika
weird, looks like it's trying to access a translated string that's not there. do you have custom icc profiles in ~/.config/darktable/color/in or [..]/out ? j. On Fri, May 13, 2016 at 1:51 PM, franjo wrote: > attache the file > > > > Am 13.05.2016 um 13:46 schrieb johann

Re: [darktable-dev] Fujifilm X100 blackpoint issue

2016-05-15 Thread johannes hanika
hey, i believe our black point is correct (see screenshot below [0]). it's just a bit much to ask to push a 3200 ISO image by 3 stops and get useful colour rendition out of the box. the rawtherapee shot looks like a different whitebalance/colour profile/curve has been applied? anyways, you're al

Re: [darktable-dev] Fujifilm X100 blackpoint issue

2016-05-15 Thread johannes hanika
on for that. I'll report back. Hopefully it's indeed consistent across > images, although I could not find the correct blackpoint in the gui of > RawTherapee before they patched DCRaw. > > Regards, > > Martijn > > Op zo 15 mei 2016 om 14:51 schreef johannes hanika :

Re: [darktable-dev] Fujifilm X100 blackpoint issue

2016-05-15 Thread johannes hanika
nel order is R-G1-G2-B) .." >> >> So the blackpoint varies with ISO and maybe some other variables and >> should be read out for each image independently. >> >> Regards, >> >> Martijn >> >> Op zo 15 mei 2016 om 16:43 schreef johannes han

Re: [darktable-dev] Fujifilm X100 blackpoint issue

2016-05-15 Thread johannes hanika
see https://github.com/darktable-org/darktable/pull/1202 j. On Mon, May 16, 2016 at 5:02 AM, Martijn Kruiten wrote: > Yes, I thought it was amazing too. Thanks for looking into it! > > Op zo 15 mei 2016 om 17:40 schreef johannes hanika : >> >> oh, right. thanks for point

Re: [darktable-dev] compilation error

2016-05-15 Thread johannes hanika
can you kids stop :) ? i don't have gcc6, but am happy to push a couple of white spaces to make silly compilers happy.. fwiw i think -Werror is a good idea in general (i think we take it out for release tarballs, if not we should probably). -jo On Mon, May 16, 2016 at 4:29 AM, Pedro Côrte-Real

Re: [darktable-dev] weird colours when using several color modules

2016-05-15 Thread johannes hanika
hi, On Mon, May 16, 2016 at 4:19 AM, Marc Cousin wrote: > Hi, > > > I have something wrong in latests git versions: colours are completely > wrong as soon as I touch anything in several modules. The most obvious > one is color zones: touch anything and the color is completely wrong > (everything

Re: [darktable-dev] compilation error

2016-05-15 Thread johannes hanika
https://github.com/darktable-org/darktable/commit/5eeddc9f2415e31475e8d6b89630fcde7e7a34f7 On Mon, May 16, 2016 at 5:34 AM, johannes hanika wrote: > can you kids stop :) ? > > i don't have gcc6, but am happy to push a couple of white spaces to > make silly compilers happy..

Re: [darktable-dev] weird colours when using several color modules

2016-05-16 Thread johannes hanika
creenshot, I only did a minor change in the > color zones module. > > Regards > > On 15/05/2016 21:45, johannes hanika wrote: >> hi, >> >> On Mon, May 16, 2016 at 4:19 AM, Marc Cousin wrote: >>> Hi, >>> >>> >>> I have something wron

Re: [darktable-dev] compile error

2016-05-16 Thread johannes hanika
yeah, just noticed that too. should be fixed now. -jo On Tue, May 17, 2016 at 7:13 AM, Ulrich Pegelow wrote: > Hi, > > current master does not compile here (gcc (SUSE Linux) 4.8.3 20140627 > [gcc-4_8-branch revision 212064]): > > imageio_dng.h:212:20: note: expected ‘const uint8_t (*)[6]’ but ar

Re: [darktable-dev] Fujifilm X100 blackpoint issue

2016-05-24 Thread johannes hanika
1026 > 1026 1026 1026 1026 1026 1026 1026 1026 1026 1026 1026 1026 1026 1026 1026 > 1026 1026 1026 1026 1026 1026 1026 1026 1026 1026 1026 1026 1026 > > > On Sun, May 15, 2016 at 10:27 AM, johannes hanika wrote: >> >> see >> >> https://github.com/darktable-org

Re: [darktable-dev] Fujifilm X100 blackpoint issue

2016-05-24 Thread johannes hanika
On Wed, May 25, 2016 at 4:23 AM, J. Liles wrote: > > > On Tue, May 24, 2016 at 9:18 AM, Roman Lebedev wrote: >> >> On Tue, May 24, 2016 at 6:44 PM, J. Liles wrote: >> > >> > >> > On Tue, May 24, 2016 at 5:40 AM, johannes hanika >> >

Re: [darktable-dev] Export To Web Gallery

2016-06-08 Thread johannes hanika
heya this web export is indeed a bit rusty and could be modernised, maybe even to scale to different screen sizes? i'd be interested in seeing your ideas about it, integrating into a c exporter should be easy. maybe it's also possible to do it as an optional lua script. but yeah, if you find som

Re: [darktable-dev] Re: Export To Web Gallery

2016-06-13 Thread johannes hanika
hi! looks nice! i like how it scales to fit the window. a few thoughts: - not sure we can get away completely without thumbnail support from our side, i'd hate to leave the rescaling to the browser after downloading 12MB of jpg.. - along the same lines, will there be an overview somewhere? like

Re: [darktable-dev] Re: Export To Web Gallery

2016-06-14 Thread johannes hanika
hi, On Tue, Jun 14, 2016 at 9:30 AM, Set Hallström wrote: > On 2016-06-13 16:55, Christian Mandel wrote: >> Am 13.06.2016 um 15:42 schrieb johannes hanika: >>> - not sure we can get away completely without thumbnail support from >>> our side, i'd hate to leave th

Re: [darktable-dev] [PATCH] Fix for SIGSEGV when using darktable-chart with charts with lots of color patches

2016-07-11 Thread johannes hanika
do you have any interesting results to share of what you were trying to achieve with this? did it work out well? cheers, jo On Fri, Jul 8, 2016 at 4:30 PM, Erwin Burema wrote: > On 8 July 2016 at 11:21, Tobias Ellinghaus wrote: >> >> On Donnerstag, 7. Juli 2016 19:43:04 CEST Erwin Burema wrote

Re: [darktable-dev] [PATCH] Fix for SIGSEGV when using darktable-chart with charts with lots of color patches

2016-07-11 Thread johannes hanika
cool, looking forward to reading your writeup then :) -jo On Mon, Jul 11, 2016 at 11:03 PM, Erwin Burema wrote: > > On 11 July 2016 at 11:44, johannes hanika wrote: >> >> do you have any interesting results to share of what you were trying >> to achieve with th

Re: [darktable-dev] Issue with dng files

2016-08-07 Thread johannes hanika
heya, sure we're interested. if you could upload a sample somewhere (dropbox or similar?) that would would be helpful. cheers, jo On Sun, Aug 7, 2016 at 6:34 PM, Peter Harde wrote: > Hi, > > I have some dng images, created by a scanner for diapositives. I tried to > open such dng files in dark

Re: [darktable-dev] Grayscale

2016-08-11 Thread johannes hanika
heya, if you have any show-off result images, i'd be interested.. also, if you need laplacian pyramid code, i think i have a working implementation of a local laplacian now (it's monochrome though). cheers, jo On Wed, Aug 10, 2016 at 10:50 PM, Wolfgang Mader wrote: > I finally have something

Re: [darktable-dev] Grayscale

2016-08-11 Thread johannes hanika
and I would try to > incorporate it in the new monochrome module. > > Cheers > Maximilian > > > Am 11.08.2016 um 15:53 schrieb johannes hanika: >> >> heya, >> >> if you have any show-off result images, i'd be interested.. >> >> also, if you ne

Re: [darktable-dev] basecurve/fusion: Update of lighttable and filmstrip images mostly not executed

2016-08-29 Thread johannes hanika
hm. i guess that was me breaking it in two places here :| i think for now you should enable the option `never use embedded thumb but half size raw' or similar in the preferences to work around it. the basic issue is that dt does a terrible job at determining for which images the embedded thumbnai

Re: [darktable-dev] Details on pictures for benchmark of new created noise profiles

2016-09-27 Thread johannes hanika
heya, any images will do for the test. preferably the ones you're actually interested in denoising (so natural images more than out of focus ones, most likely). cheers, jo On Wed, Sep 28, 2016 at 5:31 AM, Sascha Oleszczuk wrote: > Hi, > > before running the benchmark of the new created noise p

Re: [darktable-dev] Attention developers! PSA: CI

2016-10-01 Thread johannes hanika
heya, i can see your subscription request in the logs, but nothing about another confirmation mail. where did you send it exactly? i can of course insert you manually.. but i'd like to know why this doesn't work so i won't have to subscribe everybody by hand :) cheers, jo On Sun, Oct 2, 2016 at

Re: [darktable-dev] Attention developers! PSA: CI

2016-10-02 Thread johannes hanika
hi all, i'm sorry but i'm a terrible mailing list admin :) if you want to subscribe to the list, please let me know, i'll subscribe you manually. it indeed seems the deny all but travis rule also drops the subscription confirmation mails. cheers, jo On Sun, Oct 2, 2016 at 5:29 AM, Roman Lebed

[darktable-dev] feature freeze for 2.2

2016-10-04 Thread johannes hanika
hi all, in an effort to get a feature release out before end of the year this time around, i'd like to announce the feature freeze for 2.2 on the master branch. this should give us devs some time to make the features we have more stable, and everybody else a chance to find bugs. note that we're

Re: [darktable-dev] feature freeze for 2.2

2016-10-04 Thread johannes hanika
let's wait for another couple of days for this then? and soft-freeze the other features ;) ? cheers, jo On Tue, Oct 4, 2016 at 11:34 PM, Tobias Ellinghaus wrote: > Am Dienstag, 4. Oktober 2016, 13:01:43 CEST schrieb Roman Lebedev: > > [...] > >> I'm not sure about merging it *right now*, IIRC T

Re: [darktable-dev] feature request: new iop: apply 3D LUT from file

2016-10-13 Thread johannes hanika
fwiw people have already found ways to ingest 3d luts into our colour look up table module: https://www.youtube.com/watch?v=m_cLCL5PJk4 -jo On Fri, Oct 14, 2016 at 3:03 AM, Tobias Ellinghaus wrote: > Am Donnerstag, 13. Oktober 2016, 12:53:12 CEST schrieb Seweryn Niemiec: >> Hi >> >> Colour tran

Re: [darktable-dev] Does darktable properly handle shadows in Canon RAW files?

2016-10-23 Thread johannes hanika
i wrote some code in a branch once that would move our denoising before black point subtraction (or at least the clamping to 0). the differences to the old code path in terms of result images were disappointing at best. first, the black point thing would only result in very academic differences, on

Re: [darktable-dev] Re: Another real-life example

2016-10-25 Thread johannes hanika
hi, On Mon, Oct 24, 2016 at 9:46 PM, Alex wrote: > He complains about magenta shadows. [..] > The issue is obvious in these images: > http://i.imgur.com/0sixStb.jpg > http://i.imgur.com/12eQb4y.jpg yes, those images do show the mean shift when clamping to 0 before denoising. if you have a raw li

Re: [darktable-dev] feature freeze for 2.2

2016-10-26 Thread johannes hanika
hi all, after having merged a few pull requests, we announce 0K feature freeze on master. we'll stay here for a bit and then also freeze the ui strings before we proceed to release candidates. cheers, jo On Wed, Oct 5, 2016 at 3:23 PM, Pascal Obry wrote: > > Hello Tobias, > >> So by all mea

Re: [darktable-dev] Color Lookup Table Question

2016-11-13 Thread johannes hanika
heya, yes, this order of modules is intentional. changing exposure changes the starting point of the colour transform.. those luts have been created from well-exposed it8 charts, so heavily under- or overexposed areas will not have any valid data points. also the colour transform is non-linear and

Re: [darktable-dev] Export from Lua

2016-11-14 Thread johannes hanika
On Mon, Nov 14, 2016 at 2:58 PM, Roman Lebedev wrote: > On Mon, Nov 14, 2016 at 4:53 PM, Pascal Obry wrote: >> Hello Lua experts! >> >> I want to create a Lib (a bit like the Enfuse one in the lua-script >> repo) but I need to first export the RAW file as say TIF. Is there a >> way to export a se

Re: [darktable-dev] Thumbnails in exported photos?

2016-11-28 Thread johannes hanika
On Mon, Nov 28, 2016 at 11:01 PM, KOVÁCS István wrote: > You can copy exif from original raw to jpeg using exiv2. Since your > jpeg will probably have been correctly rotated by the orientation > module, you'll need to clear the 'rotation needed' flag using jhead > -norot; you can then regenerate t

Re: [darktable-dev] Defringe broken in 2.2.0 rc1?

2016-11-30 Thread johannes hanika
heya, sorry we'd need more info to help you. did you strip the exif/xmp from these jpg? could you provide raw+xmp? i can't tell whether your history stack is indeed the same or what settings you used. fwiw i can remove the fringes from your jpg by using the defringe module.. cheers, jo On Wed,

Re: [darktable-dev] Defringe broken in 2.2.0 rc1?

2016-11-30 Thread johannes hanika
om/open > ?id=0Bxs_utDd2nQgTS16bG94OXJjRlU > > On Thu, 2016-12-01 at 02:32 +1300, johannes hanika wrote: >> heya, >> >> sorry we'd need more info to help you. did you strip the exif/xmp >> from >> these jpg? could you provide raw+xmp? i can't tell whether your

Re: [darktable-dev] Auto-crop to create Star Trails Vortex

2016-12-12 Thread johannes hanika
On Mon, Dec 12, 2016 at 11:29 AM, Tobias Ellinghaus wrote: > Am Sonntag, 11. Dezember 2016, 23:50:35 CET schrieb Martí Amengual Torrens: >> Hi, >> >> First of all, I want to introduce myself. I'm Martí Amengual from >> Mallorca and I use Darktable to edit my photos. I am a project manager >> in th

Re: [darktable-dev] darktable-chart 2.2 rc2 not running

2016-12-17 Thread johannes hanika
On Sun, Dec 18, 2016 at 12:09 AM, Tobias Ellinghaus wrote: > Am Samstag, 17. Dezember 2016, 04:17:57 CET schrieb Aurélien PIERRE: >> Yes I did as said in the post on DT's blog. >> >> Tobias, I'm on laptop with Intel® Core™ i7-2670QM CPU @ 2.20GHz × 8 and >> Intel Sandybridge + Nvidia Geforce GT 6

Re: [darktable-dev] Warning: git master now uses rawspeed as submodule !

2017-01-03 Thread johannes hanika
yeah that is annoying. is it a good idea to add that file to .gitignore? or is this indeed the mechanism to update the submodule? -jo On Wed, Jan 4, 2017 at 7:57 AM, Ulrich Pegelow wrote: > Am 03.01.2017 um 17:29 schrieb Roman Lebedev: >> >> On Tue, Jan 3, 2017 at 7:22 PM, Ulrich Pegelow >>> >>>

Re: [darktable-dev] Sampling with LUT

2017-01-04 Thread johannes hanika
hi, yeah not sure the ui is perfect yet.. maybe you're running into the issue that you can't create patches, but only delete or update? also, sometimes the colour picker will give you a patch with unexpected colour because it matches colour + brightness (and in fact usually after reconsidering i f

Re: [darktable-dev] local contrast with Laplace filter

2017-01-16 Thread johannes hanika
yeah sorry.. will fix it once i get my life back end of this week :) -jo On Mon, Jan 16, 2017 at 8:09 AM, Christian Kanzian wrote: > Hi, > > Looks like this issue: https://redmine.darktable.org/issues/11434 > >> darktable 2.3.0+git247.4b67f41-1.1 ... openSUSE 42.2 (Recently >> installed OpenCL)

Re: [darktable-dev] local contrast with Laplace filter

2017-01-16 Thread johannes hanika
if i manage to fix this boundary handling thing.. opencl should be a lot faster especially on this local laplacing. maybe there's something odd with the setup. -jo On Tue, Jan 17, 2017 at 5:12 AM, David Vincent-Jones wrote: > Yes, definitely related to OpenCL! > > Frankly, on my system OpenCL 'f

Re: [darktable-dev] local contrast with Laplace filter

2017-01-19 Thread johannes hanika
heya, if any one of you uses git master.. could you tell me if the current version resolves your opencl boundary handling issues? it seems to be fixed for me now. cheers, jo On Mon, Jan 16, 2017 at 6:48 PM, johannes hanika wrote: > if i manage to fix this boundary handling thing.. ope

Re: [darktable-dev] local contrast with Laplace filter

2017-01-19 Thread johannes hanika
me. I'm getting a black bar on the right. Only >> happens using laplacian filter. Tried four images. Happens for every one. >> Fresh git pulled 5 minutes ago. >> >> Regards >> >> Dave Jones >> >> >> On Thu, 19 Jan 2017, 14:50 johannes hani

Re: [darktable-dev] local contrast with Laplace filter

2017-01-19 Thread johannes hanika
i'm not sure i understand this.. but could you try again now please? -jo On Thu, Jan 19, 2017 at 2:11 PM, johannes hanika wrote: > those pyramids are terrible. and the boundary conditions are the > worst. they are different if the image dimension is a multiple of 2 > (that'

Re: [darktable-dev] Re: Unusual stability problem

2017-01-30 Thread johannes hanika
thanks for providing the fix! seems correct to me, since the loop is y <= max and y+1 is accessed inside. i pushed this PR to master. let's see if it fixes it for everyone. cheers, jo On Mon, Jan 30, 2017 at 5:38 PM, Dan Torop wrote: > I should also mention that the Bayer downscale code for th

Re: [darktable-dev] kernel performance: 3.16 vs. 4.9

2017-02-05 Thread johannes hanika
hi, how much do you trust your numbers? they look very weird to me. such a speedup sounds more like one is running single threaded :) did you run it a couple of times one after the other? to rule out disk prefetching etc? using the minimum time of three consecutive runs may be a good indication.

Re: [darktable-dev] automatic haze/dust removal

2017-02-12 Thread johannes hanika
hi, as of dev documentation: there's our irc channel which you may find most useful.. and src/iop/useless.c https://github.com/darktable-org/darktable/blob/master/src/iop/useless.c which implements all required callbacks and comes with a couple of code comments that should get you started. cheers

Re: [darktable-dev] determining global image features in the pixelpipe

2017-02-17 Thread johannes hanika
hi, a few modules have similar requirements. you can have a look for instance in the ashift.c module, where it says: // only for preview pipe: collect input buffer data and do some other evaluations if(self->dev->gui_attached && g && piece->pipe->type == DT_DEV_PIXELPIPE_PREVIEW) { there is

Re: Re: [darktable-dev] Darktable on Beignet

2017-02-22 Thread johannes hanika
hi, thanks for looking into this! /0 is not nice in any case.. but i doubt your fix is the best we can do. num should be incremented whenever a value is smaller than or equal to a threshold, which is chosen based on the min and max of these very values. the case num==0 should really never happen

Re: Re: [darktable-dev] Darktable on Beignet

2017-02-22 Thread johannes hanika
f my patch is OK, could you please merge it and remove beignet from > black list? > Thanks. > > Yan Wang > > > yan.wang > > > From: johannes hanika > Date: 2017-02-22 17:11 > To: yan.wang > CC: darktable-dev > Subject: Re

Re: Re: [darktable-dev] Darktable on Beignet

2017-02-24 Thread johannes hanika
there a official benchmark for these darktable OCL kernels for > evaluation? > Thanks. > > > > yan.wang > > > From: johannes hanika > Date: 2017-02-22 19:00 > To: yan.wang > CC: darktable-dev > Subject: Re: Re: [darktable-dev] Darktable on

Re: [darktable-dev] guided filter for parametric and drawn masks

2017-03-23 Thread johannes hanika
wow, this looks interesting and useful! cheers, jo On Wed, Mar 22, 2017 at 11:55 PM, Heiko Bauke wrote: > Hi, > > in Darktable masks can be blurred by a Gaussian filter. I have implemented > an experimental feature to modify parametric and drawn masks by another kind > of filter called guided

[darktable-dev] Fwd: mailing list admin things

2017-03-30 Thread johannes hanika
hi all, especially hi to all yahoo users here. i think all of you noticed the bounce messages we sometimes get from this list. it's not all that often but kind of annoying. turns out it's some anti-spam mechanism enforced by yahoo that goes berserk (see for instance this email thread for the mail

[darktable-dev] color lut module updates

2017-04-26 Thread johannes hanika
hi all, i added a few minor updates to the color checker lut module and related workflow: 1) the tonecurve has a new mode: adjust color automatic in RGB. this pretty much turns the tone curve into a prophoto-rgb cure 2) darktable-chart uses this mode in a tonecurve when fitting luts to pairs of

Re: [darktable-dev] Adaptative deconvolution

2017-04-27 Thread johannes hanika
great, we've got a flamewar! let me join the fun: i'm very much unconvinced by their examples re: lens blur or generic sharpening. it has the typical fourier artifacts (even though the ringing seems surprisingly well balanced in their examples. but i can still see it). i think our current local co

Re: [darktable-dev] Adaptative deconvolution

2017-04-27 Thread johannes hanika
17 at 2:54 PM, johannes hanika wrote: > great, we've got a flamewar! let me join the fun: > > i'm very much unconvinced by their examples re: lens blur or generic > sharpening. it has the typical fourier artifacts (even though the > ringing seems surprisingly well balance

Re: [darktable-dev] Redmine bug #10333 and X-Trans demosaicking re-visited

2017-05-07 Thread johannes hanika
heya, nice results! especially the high iso one shows quite a bit more pleasant noise behaviour in the gray center patch. how bad is the performance? do you think it could be improved? does it use SIMD/openmp yet and how promising would an opencl code path be? cheers, jo On Mon, May 8, 2017 at

Re: [darktable-dev] Redmine bug #10333 and X-Trans demosaicking re-visited

2017-05-07 Thread johannes hanika
t; works quite well in OpenCL. so there may be hope :) cheers, jo > > Cheers, > Ingo > > >> Am 07.05.2017 um 20:03 schrieb johannes hanika : >> >> heya, >> >> nice results! especially the high iso one shows quite a bit more >> pleasant noise behav

Re: [darktable-dev] Redmine bug #10333 and X-Trans demosaicking re-visited

2017-05-08 Thread johannes hanika
's hope... actually, up to now I was really focusing on > the algorithm itself and on demosaicking quality. Code is still dirty and I > think there's potential. > I'd use FFT for convolutions. As said, some more info to come tomorrow. > Cheers, > Ingo > > > Am 07.0

Re: [darktable-dev] Redmine bug #10333 and X-Trans demosaicking re-visited

2017-05-14 Thread johannes hanika
ers, > Ingo > > > > Am 08.05.2017 um 22:58 schrieb johannes hanika : > > heya, > > doesn't sound too bad for something that hasn't been optimised at all > yet. did you describe what you do on a high level somewhere on your > blog? or is the best docume

Re: [darktable-dev] Planning of the upcoming 2.4.0 release

2017-06-21 Thread johannes hanika
heya, On Thu, Jun 22, 2017 at 4:35 AM, Moritz Mœller (The Ritz) wrote: > On June 20, 2017 18:34:27 Roman Lebedev wrote: >> >> On Tue, Jun 20, 2017 at 5:55 PM, Moritz Moeller >> wrote: >>> >>> On 20.6.17 11:43 , Tobias Ellinghaus wrote: >>> I'm using a local build with [...] Wolfgang Mader's >>>

Re: [darktable-dev] possible bug in color look up table module

2017-07-12 Thread johannes hanika
heya, sounds weird, will try to reproduce. the fitting of this function is using a spline, which may be prone to ringing, in between the colours you fixed. it has a linear part that fixes this issue for purely b/w, but may lead to issues for b/w + single colour. cheers, -jo On Tue, Jul 11, 2017

Re: [darktable-dev] possible bug in color look up table module

2017-07-30 Thread johannes hanika
pull it in as a dependency. cheers, jo On Fri, Jul 28, 2017 at 9:24 PM, Heiko Bauke wrote: > Dear Johannes, > > Am 12.07.2017 um 10:06 schrieb johannes hanika: >> >> sounds weird, will try to reproduce. the fitting of this function is >> using a spline, which ma

Re: [darktable-dev] Redmine bug #10333 and X-Trans demosaicking re-visited

2017-07-31 Thread johannes hanika
ght be > possible to include it in the upcoming 2.4.0 release... > > Cheers, > Ingo > > > Am 14.05.2017 um 21:06 schrieb johannes hanika : > > nice thanks! will give it a read! > > -jo > > On Mon, May 15, 2017 at 6:55 AM, Ingo Liebhardt > wrote:

Re: [darktable-dev] film emulation

2017-09-02 Thread johannes hanika
wow, supercool, thanks for this effort! what exactly was the tweak you needed to do for darktable-chart? -jo On Sat, Sep 2, 2017 at 11:13 PM, Heiko Bauke wrote: > Hi, > > the G'MIC film emulation tool (see http://gmic.eu/film_emulation/index.shtml > ) is very nice for emulating the look of old a

Re: [darktable-dev] film emulation

2017-09-02 Thread johannes hanika
hi, that means you are dropping the tonecurve information? or is that baked into the clut, too? cheers, jo On Sun, Sep 3, 2017 at 6:38 AM, Heiko Bauke wrote: > Hi, > > Am Samstag 2. September 2017 schrieb johannes hanika: >> wow, supercool, thanks for this effort! what exactl

Re: [darktable-dev] film emulation

2017-09-08 Thread johannes hanika
heya, On Thu, Sep 7, 2017 at 12:57 PM, Heiko Bauke wrote: > Hi, > > Am 03.09.2017 um 13:46 schrieb Heiko Bauke: >> >> yes I just dropped the tonecurve information because this gave me the >> best results in some test cases. Investigating the source code of >> darktable-chart I realized that drop

Re: [darktable-dev] compiler warnings regarding variable length arrays

2017-09-24 Thread johannes hanika
hi, i disagree. i really like variable length arrays. and std::vectors dynamically allocate memory on the heap, with standard implementations locking a global mutex on the way, causing slowdown for multithreaded cases. just incrementing the stack pointer is a simple thing, it's thread local and li

Re: [darktable-dev] Library size, just for conversation

2017-09-25 Thread johannes hanika
.. and that is images, not bytes in the db, right? most impressive :) any particular operations that show significant slowdown due to this? or does it just work? cheers, jo On Tue, Sep 26, 2017 at 4:45 AM, Patrick Shanahan wrote: > this morning my library contained >88.5k > > > -- > (paka)Patr

Re: [darktable-dev] Deconvolution and Python framework

2017-10-12 Thread johannes hanika
hi, 1) 16s in single-thread python sounds like it would be possible to do < 100ms in a programming language. 4) that depends on the order of modules. if you want to do it in the current sharpen module as an option, it'll come pretty much last. if you do it early, dt will transparently cache the o

Re: [darktable-dev] Deconvolution and Python framework

2017-10-16 Thread johannes hanika
On Mon, Oct 16, 2017 at 11:21 PM, Tobias Ellinghaus wrote: > Am Sonntag, 15. Oktober 2017, 14:51:47 CEST schrieb Aurélien PIERRE: >> Hi, >> >> this technic aims at solving all kinds of blurs (static and motion >> blurs). The most challenging configuration is when the blur is not >> uniform along t

Re: [darktable-dev] Tamron 10-24mm F/3.5-4.5 Di II VC HLD with Canon EOS 80D

2017-11-05 Thread johannes hanika
.. also the screenshot shows the output of `exiftool' not `exiv2' so it's not clear whether libexiv2 would report the correct id to dt to pass it on to lensfun.. -jo On Mon, Nov 6, 2017 at 1:37 AM, Patrick Shanahan wrote: > * Holger Klemm [11-05-17 04:29]: >> Yesterday I tested the Tamron 10-24

Re: [darktable-dev] Module ordering and icons

2017-12-02 Thread johannes hanika
heya, On Sun, Dec 3, 2017 at 1:12 AM, Dominik Markiewicz wrote: > Hi, > Small tip from my side. It's not perfect (yet! :) but it speedup my > processing a bit. > > I've split my workflow for a few steps. For each step I've select a few > modules I'm using 99% of the time. Then I've selected them

Re: [darktable-dev] Local contrast with laplacian filter washes highlights tones

2017-12-03 Thread johannes hanika
hi, yes i think that request makes sense. cheers, jo On Fri, Dec 1, 2017 at 11:37 AM, Aurélien PIERRE wrote: > Hi, > > I have been using the local contrast module with the laplacian filter on the > git/master version for a few months now, and I noticed that it's impossible > to push highlights

Re: [darktable-dev] darktable 2.4.0rc0 released

2017-12-04 Thread johannes hanika
hi, On Mon, Dec 4, 2017 at 3:39 PM, Terry Duell wrote: > On Mon, 04 Dec 2017 03:10:51 +1100, Tobias Ellinghaus wrote: > >> we're proud to announce the first release candidate for the upcoming 2.4 >> series of darktable, 2.4.0rc0! >> >> the github release is here: https://github.com/darktable-org

Re: [darktable-dev] Darktable 2.4.0 Crashing with "double free or corruption"

2018-01-07 Thread johannes hanika
hi, thanks for the report. some questions: does that only happen on this specific image? did darktable write a stack trace to /tmp/darktable-bt-* ? if so, could you poste this file? how much ram does your machine have? cheers, jo On Mon, Jan 8, 2018 at 9:23 AM, ben rudgers wrote: > Behaviors:

Re: [darktable-dev] Darktable 2.4.0 Crashing with "double free or corruption"

2018-01-07 Thread johannes hanika
ill also correlate to the edited file. > > + Discarding the history stack seems to allow the file to receive a few > edits before crashing. > > Thanks, > > Ben > > > > On 01/07/2018 02:40 PM, johannes hanika wrote: >> >> hi, >> >> thanks for

Re: [darktable-dev] Darktable 2.4.0 Crashing with "double free or corruption"

2018-01-08 Thread johannes hanika
heya, please keep replies on the list in case anyone else is interested or i get lost or similar :) -jo On Mon, Jan 8, 2018 at 4:56 PM, ben rudgers wrote: > Just a clarification on my last email. > > 0. I was able to apply 20 or so operations without a crash before I applied > the frame. > > 1.

Re: [darktable-dev] denoise profile non local means: neighborhood parameter

2018-01-26 Thread johannes hanika
hi, if you want, absolutely do play around with K. in my tests it did not lead to any better denoising. to my surprise a larger K often led to worse results (for some reason often the relevance of discovered patches decreases with distance from the current point). that's why K is not exposed in th

Re: [darktable-dev] denoise profile non local means: neighborhood parameter

2018-01-27 Thread johannes hanika
far as I understand, it gives a way to choose an adaptated window size > for each pixel, but I don't see in the code anything related to that > > Maybe is this paper related to the TODOs in the code ? > > Was it planned to implement such a variable window approach ? > > O

  1   2   >