Re: DateTime::Event::Easter - Beta 2

2003-03-25 Thread Eugene van der Pijll
Rick Measham schreef: > Can't use a block eval for 'use X'. All 'use X' commands are parsed before > anything else, so it will always try to use X, even if we don't go there. Yes, of course, stupid me. > 'require X' happens at run-time so doesn't need to be eval-ed. Except if you want to catch t

Re: DateTime::Event::Easter - Beta 2

2003-03-25 Thread Rick Measham
On 26/3/03 9:44 am, Eugene van der Pijll at [EMAIL PROTECTED] spake thus: > Rick Measham schreef: >>> Best solution would perhaps to convert to Julian at the start of those >>> methods, and to convert them back to Gregorian at the end. >>> (DateTime::Calendar::Julian could be useful here ;-) >> >

Re: DateTime::Event::Easter - Beta 2

2003-03-25 Thread Dave Rolsky
On Tue, 25 Mar 2003, Eugene van der Pijll wrote: > > other than: > > eval("use DateTime::Set"); > > croak("Couldn't load DateTime::Set:".$@) if $@; > > Block-eval is better than string-eval. Also I think 'require' is used > more often than 'use' in these kind of constructs, but I don't think > t

Re: DateTime::Event::Easter - Beta 2

2003-03-25 Thread Eugene van der Pijll
Rick Measham schreef: > > Best solution would perhaps to convert to Julian at the start of those > > methods, and to convert them back to Gregorian at the end. > > (DateTime::Calendar::Julian could be useful here ;-) > > Yeah, I figured I might have to do that, although then rather than finding >

Re: DateTime::Event::Easter - Beta 2

2003-03-25 Thread Rick Measham
On 26/3/03 9:09 am, Dave Rolsky at [EMAIL PROTECTED] spake thus: > I'm going to pick nits, because I'm anal. Picking nits is good, but I swear I showered and combed my hair this morning! > - It'd be good to name the variables that are constants either in all caps > or in StudlyCaps Will do > -

Re: DateTime::Event::Easter - Beta 2

2003-03-25 Thread Rick Measham
Thanks Eugene! This is excellent! On 26/3/03 8:42 am, Eugene van der Pijll at [EMAIL PROTECTED] spake thus: > Rick Measham schreef: >> Beta 2 includes support for Orthodox Easter, however I doubt it >> handles it the best way possible. Please take a look and offer >> suggestions (its the last sub

Re: DateTime::Event::Easter - Beta 2

2003-03-25 Thread Dave Rolsky
I'm going to pick nits, because I'm anal. - It'd be good to name the variables that are constants either in all caps or in StudlyCaps - You don't need to load Data::Dumper - Your editor produces satanic tabbing indentation! What are you using? When I load the code in emacs or vi it scrolls off

Re: DateTime::Event::Easter - Beta 2

2003-03-25 Thread Eugene van der Pijll
Rick Measham schreef: > Beta 2 includes support for Orthodox Easter, however I doubt it > handles it the best way possible. Please take a look and offer > suggestions (its the last sub before the POD). It should also be > noted that both Easters should return Gregorian Dates as they do now. The

RE: DateTime::Event::Easter - Beta 2

2003-03-25 Thread Hill, Ronald
Hi Rick, > > Attached is Beta 2. I think I've incorporated all suggestions. If > I've missed anything, let me know. > [snipped] > > The ->set method is now ->as_list and I've added ->as_set which > returns a DateTime::Set object (although this isn't tested at ALL! > CPAN wouldn't give me Da

Re: DateTime::Event::Easter - Beta 2

2003-03-25 Thread Flavio S. Glock
Hill, Ronald wrote: > Does anyone know where I can get the DateTime::Set module? Here: http://www.ipct.pucrs.br/flavio/perl/DateTime-Set-0.00_18.tar.gz You will also need this: http://www.ipct.pucrs.br/flavio/perl/Set-Infinite-0.45.tar.gz - Flavio S. Glock

Re: DateTime::Event::Easter - Beta 2

2003-03-25 Thread Flavio S. Glock
Hill, Ronald wrote: > Does anyone know where I can get the DateTime::Set module? It is in the cvs (http://sourceforge.net --> project "perl-date-time"). I'll update CPAN now. - Flavio S. Glock

RE: DateTime::Event::Easter - Beta 2

2003-03-25 Thread Hill, Ronald
Hi Rick, [snipped] > > The ->set method is now ->as_list and I've added ->as_set which > returns a DateTime::Set object (although this isn't tested at ALL! > CPAN wouldn't give me DateTime::Set :)) I guess I jumped the gun a bit, I will follow suit and make the changes to the Sunrise module.