Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2058
this is the reason why SessionCloseTest.testCanNotUseXAWithClosedSession is
failing.
---
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2058
Can we instead revert 10849eb?
---
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2058
I would make a reference with the commit as well.
---
GitHub user clebertsuconic opened a pull request:
https://github.com/apache/activemq-artemis/pull/2059
Topology updates and other test fixes.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/clebertsuconic/activemq-artemis
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2056
@mtaylor the previous build actually failed.. testsuite failures will
break TravisCI builds .
but this one seems good now.. merging it shortly.
---
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2057
I don't mind much about the checkstyle broken here as I could fix with an
intermediate checkout...
But this test is always failing for me. Isn't this suppos
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2056
@mtaylor this is breaking compatibility. an export / import test..
exporting on older version importing on newer version is broken.. this is a
no-go change! Can you fix it
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2056#discussion_r185285955
--- Diff:
artemis-cli/src/main/resources/org/apache/activemq/artemis/cli/commands/etc/broker.xml
---
@@ -20,7 +20,6 @@ under the License
GitHub user clebertsuconic opened a pull request:
https://github.com/apache/activemq-artemis/pull/2054
ARTEMIS-1839 NettyConnector was ignoring sniHost
This is fixing
org.apache.activemq.artemis.tests.integration.ssl.CoreClientOverOneWaySSLKerb5Test
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2053
@tabish121 fixed again..
---
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2053
Sh...t :)
---
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2053
@tabish121 thanks.. fixed it
---
GitHub user clebertsuconic opened a pull request:
https://github.com/apache/activemq-artemis/pull/2053
ARTEMIS-1838 Fixing AMQP->Core Race on durable property
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/clebertsuco
GitHub user clebertsuconic opened a pull request:
https://github.com/apache/activemq-artemis/pull/2052
ARTEMIS-1837 Replication Initial catchup deadlocks if clients disconnect
This is fixing existing tests, so no more tests are needed.
You can merge this pull request into a Git
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2010#discussion_r184701274
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java
---
@@ -2712,6 +2713,11 @@ private
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2049#discussion_r184699818
--- Diff:
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/amqp/JMSDurableConsumerTest.java
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2049#discussion_r184698179
--- Diff:
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/amqp/JMSDurableConsumerTest.java
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2010
there's an open statement with a question I asked you.. and can you fix
this easy to fix conflict?
---
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2010#discussion_r184572931
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java
---
@@ -2712,6 +2714,11 @@ private
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2038
Is this compatible with previous usages? what happens if I don't specify
the rounting type?
---
GitHub user clebertsuconic opened a pull request:
https://github.com/apache/activemq-artemis/pull/2047
NO-JIRA Recompiling libnative using an older Linux
this will increase the chances of the library being loaded on older Linux
You can merge this pull request into a Git repository
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2041#discussion_r184398314
--- Diff:
artemis-hawtio/artemis-plugin/src/main/webapp/plugin/js/brokerDiagram.js ---
@@ -461,10 +463,20 @@ var ARTEMIS = (function
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2044
this may be fixing a test actually
---
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2039#discussion_r184178629
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ActiveMQServerImpl.java
---
@@ -2323,6 +2324,16
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2040#discussion_r184177998
--- Diff:
artemis-core-client/src/main/java/org/apache/activemq/artemis/utils/XMLUtil.java
---
@@ -323,7 +323,7 @@ public static double
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2045
It's gone then.. I'm sending a commit, with a close to this PR
---
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2041#discussion_r184175230
--- Diff:
artemis-hawtio/artemis-plugin/src/main/webapp/plugin/js/brokerDiagram.js ---
@@ -455,16 +457,27 @@ var ARTEMIS = (function
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2041#discussion_r184175183
--- Diff:
artemis-hawtio/artemis-plugin/src/main/webapp/plugin/js/brokerDiagram.js ---
@@ -455,16 +457,27 @@ var ARTEMIS = (function
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2044
I see...
Can I ask you a favor... if a test for your change doesn't make sense, can
you explicitly add a comment to your commit message saying "a test is n
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2045
@jbertram @franz1981 I vote to remove this test.. FailoverTest is already
testing for Shared storage conditions.. I think this is a dead test.
---
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2045
This test was ignored for a while until it was re-enabled at
https://github.com/apache/activemq-artemis/commit/aa730fdaa72b0530a7e5d901c5bf7016b67a35e7
---
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2046
non related failure.. but can you git commit --amend; git push origin -f
just to force another build please?
---
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2044#discussion_r184067483
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/plugin/ActiveMQServerPlugin.java
---
@@ -566,7 +566,7
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2044
you would need a major release to remove these.
---
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2039#discussion_r183472200
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ActiveMQServerImpl.java
---
@@ -2323,6 +2324,16
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2040#discussion_r183471882
--- Diff:
artemis-core-client/src/main/java/org/apache/activemq/artemis/utils/XMLUtil.java
---
@@ -323,7 +323,7 @@ public static double
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2010#discussion_r183418125
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java
---
@@ -2712,6 +2714,11 @@ private
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2031
@tabish121 no regressions on the testsuites.. I will let you decide about
merging this or not.
---
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2031
@tabish121 @franz1981 fair enough.. lets run the whole testsuite then..
then we can merge this.
---
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2031
@franz1981 sorry.. but I -1 on this.. you ok with closing this?
---
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2031
for optimizing OpenWire.. I would prefer implementing OpenWireMessage
properly. There's a PR open for that already.
---
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/1793
@michaelandrepearce There is another testsuite just for openwire.
somethings that we inherited from activemq5.. it's under
./tests/activemq5-unit-tests
that on
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/1793
this is a nice start.. but it will require some work... a lot of tests are
broken... the converters need to be updated... (especially on the openwire
testsuite).
---
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2020
I sent a commit to close this PR. definitely a won't fix.
---
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2020
this is a won't fix.. close it please!
---
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2020#discussion_r182439370
--- Diff:
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/failover/FailoverTest.java
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2020#discussion_r182438794
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/protocol/core/ServerSessionPacketHandler.java
---
@@ -658,6
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2028
merged.. close it
---
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2029
merged.. close it
---
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2027
These 3 Pull Requests are all about JDBC... it would be a lot easier if you
posted a single Pull Request with JDBC Changes with 3 commits on it. A lot
easier to manage
---
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2025
I amended your commits before merging...
examples are now checked for checkstyle also now :)
---
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2025
this would also fail checkstyle
---
GitHub user clebertsuconic reopened a pull request:
https://github.com/apache/activemq-artemis/pull/2024
ARTEMIS-1814 Try original connection when every other node failed
@michaelandrepearce @mtaylor this one will interest you I think
You can merge this pull request into a Git
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2025
@pgfox please rebase, also add the new example under run-examples under
artemis-distribution/src/test/script
---
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2025
@pgfox please, update run-examples.sh under
artemis-distribution/src/tests/script
---
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2025
please, wait #2026 to be merged...
@pgfox I will need you to rebase once I merge #2026... I will let you know.
---
GitHub user clebertsuconic opened a pull request:
https://github.com/apache/activemq-artemis/pull/2026
NO-JIRA Adding examples verification into travis
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/clebertsuconic/activemq
Github user clebertsuconic commented on the pull request:
https://github.com/apache/activemq-artemis/commit/2f0149c7598ed8c3adc2c0e5b0315fa07756dd4b#commitcomment-28619396
this commit broke the tests.. checkstyle
---
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/1987
the only reason I splitted into two commits is because it would be simpler
to verify the fix.
Again.. thanks a lot for this.
---
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/1987
@TomasHofman Kudos.. really nice...
i have done some tweaking though.. I'm removing TransportConstantsV2 and
adding those properties directly on the Utility.
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2020#discussion_r182086148
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/postoffice/impl/PostOfficeImpl.java
---
@@ -829,7 +829,13
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2022
@franz1981 to reopen this PR successfully on github.
Reopen it with the same git you have now... then push -f...
If you reopen it with a different git-ID it will
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2024
There are test failures.. I will fix them and reopen this.
---
Github user clebertsuconic closed the pull request at:
https://github.com/apache/activemq-artemis/pull/2024
---
GitHub user clebertsuconic opened a pull request:
https://github.com/apache/activemq-artemis/pull/2024
ARTEMIS-1814 Try original connection when every other node failed
@michaelandrepearce @mtaylor this one will interest you I think
You can merge this pull request into a Git
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2015
@franz1981 I think so too.. but I would do it in the context of a
refactoring in AMQP also. we need to properly implement large messages in AMQP.
---
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2010#discussion_r181386656
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java
---
@@ -2712,6 +2713,11 @@ private
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2011
done
---
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2011
@LionelCons I can.. if this is ready to be merged.
---
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2010#discussion_r180859972
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java
---
@@ -2727,7 +2731,7 @@ private
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2010#discussion_r180859106
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/impl/PageSubscriptionImpl.java
---
@@ -205,7 +205,7
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2010#discussion_r180859389
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java
---
@@ -2712,6 +2712,10 @@ private
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2010#discussion_r180858486
--- Diff:
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/ChannelImpl.java
---
@@ -511,22 +511,24
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2010#discussion_r180858361
--- Diff:
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/ChannelImpl.java
---
@@ -380,7 +380,7
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2011
@jbertram can you look into this one? you have more miles on security than
I do. :)
---
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2009#discussion_r180777030
--- Diff:
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/management/QueueControlTest.java
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2009#discussion_r180773234
--- Diff:
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/management/QueueControlTest.java
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2005
I will merge it .. but I will rename the commit message.
---
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/1999
only issue I see is.. if this is broken.. then
Topology::getMember(TransportConfiguration) is probably broken as well? That's
used on freezeConnections and ScaleDownHa
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1999#discussion_r180507233
--- Diff:
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/remoting/impl/netty/NettyConnection.java
---
@@ -511,6
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2005
@gaohoward by block did you mean avoid? When you say block I was expecting
a client blocking or not completing.
---
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2006
nice one.. thanks.. will wait the check and merge it
---
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2007
@cshannon I see. .thanks for the clarification. merging it.
---
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2006#discussion_r180460101
--- Diff:
artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2007#discussion_r180458900
--- Diff:
artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/CoreNotificationType.java
---
@@ -39,7 +39,15
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2007#discussion_r180457921
--- Diff:
artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/CoreNotificationType.java
---
@@ -39,7 +39,15
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2007#discussion_r180448672
--- Diff:
artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/CoreNotificationType.java
---
@@ -39,7 +39,15
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1999#discussion_r180281260
--- Diff:
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/TopologyMemberImpl.java
---
@@ -105,12 +105,16
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1999#discussion_r180162324
--- Diff:
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/TopologyMemberImpl.java
---
@@ -105,12 +105,16
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1999#discussion_r180134239
--- Diff:
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/TopologyMemberImpl.java
---
@@ -105,12 +105,16
GitHub user clebertsuconic opened a pull request:
https://github.com/apache/activemq-artemis/pull/2002
ARTEMIS-1796 AMQP flush during handshake can break SASL
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/clebertsuconic
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1975#discussion_r179841255
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/cluster/impl/BridgeImpl.java
---
@@ -930,9 +930,7
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/1994
same thing I asked on the JIRA. Why it shouldn't? why only on noLocal?
trying to get some context on the why it should not be included...
it would be ni
GitHub user clebertsuconic opened a pull request:
https://github.com/apache/activemq-artemis/pull/1996
ARTEMIS-1776 Blocked Bridge is not resuming after reconnect
This is still part of ARTEMIS-1776 fix, which still part of the same
release as we are on now.
Hence I'
GitHub user clebertsuconic opened a pull request:
https://github.com/apache/activemq-artemis/pull/1993
ARTEMIS-618 Using proper block size on Native One Mega Buffer
This buffer is used on fill
You can merge this pull request into a Git repository by running:
$ git pull https
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1990#discussion_r179284287
--- Diff:
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/ClientSessionImpl.java
---
@@ -1539,6 +1540,8
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1990#discussion_r179284174
--- Diff:
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/ClientSessionImpl.java
---
@@ -1539,6 +1540,8
GitHub user clebertsuconic opened a pull request:
https://github.com/apache/activemq-artemis/pull/1992
ARTEMIS-1785 Fixing --message-size on ./artemis producer
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/clebertsuconic
Github user clebertsuconic closed the pull request at:
https://github.com/apache/activemq-artemis/pull/1991
---
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/1990
@rstancel looking :#1991
---
501 - 600 of 2940 matches
Mail list logo
