[GitHub] activemq-artemis pull request #2269: ARTEMIS-1938 Update Qpid JMS along with...

2018-08-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2269 ---

[GitHub] activemq-artemis pull request #2258: ARTEMIS-2044 Add onSendError, onMessage...

2018-08-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2258 ---

[GitHub] activemq-artemis pull request #2269: ARTEMIS-1938 Update Qpid JMS along with...

2018-08-24 Thread tabish121
GitHub user tabish121 opened a pull request: https://github.com/apache/activemq-artemis/pull/2269 ARTEMIS-1938 Update Qpid JMS along with Proton and Netty Update the Qpid JMS and Proton dependencies to lastest and sync Netty with the 4.1.28.Final version used by Qpid JMS to

[GitHub] activemq-artemis pull request #2268: DONT MERGE - JUST TESTING BUILD FOR PR ...

2018-08-24 Thread michaelandrepearce
Github user michaelandrepearce closed the pull request at: https://github.com/apache/activemq-artemis/pull/2268 ---

[GitHub] activemq-artemis pull request #2268: DONT MERGE - JUST TESTING BUILD FOR PR ...

2018-08-24 Thread michaelandrepearce
GitHub user michaelandrepearce opened a pull request: https://github.com/apache/activemq-artemis/pull/2268 DONT MERGE - JUST TESTING BUILD FOR PR 2258 https://github.com/apache/activemq-artemis/pull/2258 You can merge this pull request into a Git repository by running: $ git

[GitHub] activemq-artemis pull request #2267: ARTEMIS-2052 - QueueQuery should use ad...

2018-08-24 Thread cshannon
GitHub user cshannon opened a pull request: https://github.com/apache/activemq-artemis/pull/2267 ARTEMIS-2052 - QueueQuery should use address name for address settings The name used for looking up address settings for a queue now uses the address name if there is a local queue

[GitHub] activemq-artemis pull request #2266: [ARTEMIS-2050] It is possible to get AM...

2018-08-24 Thread JiriOndrusek
GitHub user JiriOndrusek opened a pull request: https://github.com/apache/activemq-artemis/pull/2266 [ARTEMIS-2050] It is possible to get AMQ224000: Failure in initialisa… …tion: java.lang.NullPointerException during shutdown of backup server with shared store Issue:

[GitHub] activemq-artemis pull request #2265: [ARTEMIS-2050] It is possible to get AM...

2018-08-24 Thread JiriOndrusek
GitHub user JiriOndrusek opened a pull request: https://github.com/apache/activemq-artemis/pull/2265 [ARTEMIS-2050] It is possible to get AMQ224000: Failure in initialisa… …tion: java.lang.NullPointerException during shutdown of backup server with shared store

[GitHub] activemq-artemis pull request #2264: [ARTEMIS-2050] It is possible to get AM...

2018-08-24 Thread JiriOndrusek
GitHub user JiriOndrusek opened a pull request: https://github.com/apache/activemq-artemis/pull/2264 [ARTEMIS-2050] It is possible to get AMQ224000: Failure in initialisa… …tion: java.lang.NullPointerException during shutdown of backup server with shared store Issue:

[GitHub] activemq-artemis pull request #2263: ARTEMIS-2051 add trace logging for JDBC

2018-08-23 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2263#discussion_r212477311 --- Diff: artemis-jdbc-store/src/main/java/org/apache/activemq/artemis/jdbc/store/drivers/AbstractJDBCDriver.java --- @@ -132,6

[GitHub] activemq-artemis pull request #2263: ARTEMIS-2051 add trace logging for JDBC

2018-08-23 Thread jbertram
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/2263 ARTEMIS-2051 add trace logging for JDBC Activate by enabling TRACE logging for: org.apache.activemq.artemis.jdbc.store.drivers.AbstractJDBCDriver This doesn't log *all* JDBC

[GitHub] activemq-artemis pull request #2260: Added several tests in artemis-cli//Mes...

2018-08-23 Thread clebertsuconic
Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2260#discussion_r212289383 --- Diff: artemis-cli/src/test/java/org/apache/activemq/cli/test/MessageSerializerTest.java --- @@ -321,6 +329,161 @@ public void

[GitHub] activemq-artemis pull request #2260: Added several tests in artemis-cli//Mes...

2018-08-23 Thread clebertsuconic
Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2260#discussion_r212289978 --- Diff: artemis-cli/src/test/java/org/apache/activemq/cli/test/MessageSerializerTest.java --- @@ -321,6 +329,161 @@ public void

[GitHub] activemq-artemis pull request #2260: Added several tests in artemis-cli//Mes...

2018-08-23 Thread clebertsuconic
Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2260#discussion_r212289285 --- Diff: artemis-cli/src/test/java/org/apache/activemq/cli/test/MessageSerializerTest.java --- @@ -321,6 +329,161 @@ public void

[GitHub] activemq-artemis pull request #2262: ARTEMIS-1663 fix disparity on messageco...

2018-08-23 Thread michaelandrepearce
Github user michaelandrepearce closed the pull request at: https://github.com/apache/activemq-artemis/pull/2262 ---

[GitHub] activemq-artemis pull request #2262: ARTEMIS-1663 fix disparity on messageco...

2018-08-23 Thread michaelandrepearce
GitHub user michaelandrepearce opened a pull request: https://github.com/apache/activemq-artemis/pull/2262 ARTEMIS-1663 fix disparity on messagecount Reverting a change done in 1663. It seems the new messagecount != the original messageReferences.size all the time, it is

[GitHub] activemq-artemis pull request #2261: ARTEMIS-2023 Fix cast on ActiveMQActiva...

2018-08-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2261 ---

[GitHub] activemq-artemis pull request #2261: ARTEMIS-2023 Fix cast on ActiveMQActiva...

2018-08-22 Thread mtaylor
GitHub user mtaylor opened a pull request: https://github.com/apache/activemq-artemis/pull/2261 ARTEMIS-2023 Fix cast on ActiveMQActivation You can merge this pull request into a Git repository by running: $ git pull https://github.com/mtaylor/activemq-artemis

[GitHub] activemq-artemis pull request #2260: Added several tests in artemis-cli//Mes...

2018-08-22 Thread feuillemorte
GitHub user feuillemorte opened a pull request: https://github.com/apache/activemq-artemis/pull/2260 Added several tests in artemis-cli//MessageSerializerTest Hello! I wrote some tests in MessageSerializerTest file, please review it. Please, advice me how to fix

[GitHub] activemq-artemis pull request #2259: Documentation: Add steps for Artemis as...

2018-08-22 Thread BiNZGi
GitHub user BiNZGi opened a pull request: https://github.com/apache/activemq-artemis/pull/2259 Documentation: Add steps for Artemis as a service on windows You can merge this pull request into a Git repository by running: $ git pull https://github.com/BiNZGi/activemq-artemis

[GitHub] activemq-artemis pull request #2258: ARTEMIS-2044 Add onSendError, onMessage...

2018-08-22 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2258#discussion_r211868062 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/plugin/ActiveMQServerMessagePlugin.java --- @@ -128,6

[GitHub] activemq-artemis pull request #2258: ARTEMIS-2044 Add onSendError, onMessage...

2018-08-22 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2258#discussion_r211867898 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/plugin/ActiveMQServerMessagePlugin.java --- @@ -65,6

[GitHub] activemq-artemis pull request #2258: ARTEMIS-2044 Add onSendError, onMessage...

2018-08-22 Thread calohmn
GitHub user calohmn opened a pull request: https://github.com/apache/activemq-artemis/pull/2258 ARTEMIS-2044 Add onSendError, onMessageRouteError to broker plugin This fixes [ARTEMIS-2044](https://issues.apache.org/jira/browse/ARTEMIS-2044). You can merge this pull request into a

[GitHub] activemq-artemis pull request #2257: ARTEMIS-2047 Compatible option for Acti...

2018-08-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2257 ---

[GitHub] activemq-artemis pull request #2254: compatibility fixes only

2018-08-21 Thread clebertsuconic
Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2254#discussion_r211692631 --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/ClientSessionImpl.java --- @@ -241,6 +243,16 @@

[GitHub] activemq-artemis pull request #2257: ARTEMIS-2047 Compatible option for Acti...

2018-08-21 Thread clebertsuconic
GitHub user clebertsuconic opened a pull request: https://github.com/apache/activemq-artemis/pull/2257 ARTEMIS-2047 Compatible option for ActiveMQJMSClient You can merge this pull request into a Git repository by running: $ git pull

[GitHub] activemq-artemis pull request #2254: compatibility fixes only

2018-08-21 Thread clebertsuconic
Github user clebertsuconic closed the pull request at: https://github.com/apache/activemq-artemis/pull/2254 ---

[GitHub] activemq-artemis pull request #2254: compatibility fixes only

2018-08-21 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2254#discussion_r211618431 --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/ClientSessionImpl.java --- @@ -241,6 +243,16

[GitHub] activemq-artemis pull request #2254: compatibility fixes only

2018-08-21 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2254#discussion_r211617012 --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/ClientSessionImpl.java --- @@ -241,6 +243,16

[GitHub] activemq-artemis pull request #2255: replication fixes

2018-08-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2255 ---

[GitHub] activemq-artemis pull request #2256: ARTEMIS-2045 Add support for setting de...

2018-08-21 Thread calohmn
Github user calohmn commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2256#discussion_r211574987 --- Diff: artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPMessage.java --- @@ -733,6

[GitHub] activemq-artemis pull request #2254: compatibility fixes only

2018-08-21 Thread clebertsuconic
Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2254#discussion_r211573418 --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/ClientSessionImpl.java --- @@ -241,6 +243,16 @@

[GitHub] activemq-artemis pull request #2256: ARTEMIS-2045 Add support for setting de...

2018-08-21 Thread calohmn
GitHub user calohmn opened a pull request: https://github.com/apache/activemq-artemis/pull/2256 ARTEMIS-2045 Add support for setting delivery annotations on AMQPMessage This fixes ARTEMIS-2045. It enables outgoing AMQP interceptors to set delivery annotations for the outgoing

[GitHub] activemq-artemis pull request #2254: compatibility fixes only

2018-08-21 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2254#discussion_r211494915 --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/ClientSessionImpl.java --- @@ -241,6 +243,16

[GitHub] activemq-artemis pull request #2254: compatibility fixes and replication fix...

2018-08-20 Thread clebertsuconic
Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2254#discussion_r211435170 --- Diff: artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQMessage.java --- @@ -423,7 +421,7 @@ public

[GitHub] activemq-artemis pull request #2254: compatibility fixes and replication fix...

2018-08-20 Thread clebertsuconic
Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2254#discussion_r211427175 --- Diff: artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQMessage.java --- @@ -423,7 +421,7 @@ public

[GitHub] activemq-artemis pull request #2254: compatibility fixes and replication fix...

2018-08-20 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2254#discussion_r211422507 --- Diff: artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQMessage.java --- @@ -423,7 +421,7 @@ public

[GitHub] activemq-artemis pull request #2254: compatibility fixes and replication fix...

2018-08-20 Thread clebertsuconic
Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2254#discussion_r211426369 --- Diff: artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQMessage.java --- @@ -371,7 +369,7 @@ public

[GitHub] activemq-artemis pull request #2254: compatibility fixes and replication fix...

2018-08-20 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2254#discussion_r211423843 --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/ClientSessionImpl.java --- @@ -241,6 +243,16

[GitHub] activemq-artemis pull request #2254: compatibility fixes and replication fix...

2018-08-20 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2254#discussion_r211422975 --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/ClientSessionImpl.java --- @@ -241,6 +243,16

[GitHub] activemq-artemis pull request #2254: compatibility fixes and replication fix...

2018-08-20 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2254#discussion_r211423306 --- Diff: artemis-commons/src/main/java/org/apache/activemq/artemis/utils/ArtemisSystemProperties.java --- @@ -0,0 +1,76 @@ +/*

[GitHub] activemq-artemis pull request #2254: compatibility fixes and replication fix...

2018-08-20 Thread clebertsuconic
Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2254#discussion_r211423204 --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/ClientSessionImpl.java --- @@ -241,6 +243,16 @@

[GitHub] activemq-artemis pull request #2254: compatibility fixes and replication fix...

2018-08-20 Thread clebertsuconic
Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2254#discussion_r211421516 --- Diff: artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQMessage.java --- @@ -423,7 +421,7 @@ public

[GitHub] activemq-artemis pull request #2254: compatibility fixes and replication fix...

2018-08-20 Thread clebertsuconic
Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2254#discussion_r211421243 --- Diff: artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQMessage.java --- @@ -423,7 +421,7 @@ public

[GitHub] activemq-artemis pull request #2254: compatibility fixes and replication fix...

2018-08-20 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2254#discussion_r211420562 --- Diff: artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQMessage.java --- @@ -371,7 +369,7 @@ public

[GitHub] activemq-artemis pull request #2255: Fix on replication and storage

2018-08-20 Thread clebertsuconic
GitHub user clebertsuconic opened a pull request: https://github.com/apache/activemq-artemis/pull/2255 Fix on replication and storage You can merge this pull request into a Git repository by running: $ git pull https://github.com/clebertsuconic/activemq-artemis

[GitHub] activemq-artemis pull request #2254: compatibility fixes and replication fix...

2018-08-20 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2254#discussion_r211419727 --- Diff: artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQMessage.java --- @@ -423,7 +421,7 @@ public

[GitHub] activemq-artemis pull request #2254: compatibility fixes and replication fix...

2018-08-20 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2254#discussion_r211419508 --- Diff: artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQMessage.java --- @@ -423,7 +421,7 @@ public

[GitHub] activemq-artemis pull request #2254: compatibility fixes and replication fix...

2018-08-20 Thread clebertsuconic
Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2254#discussion_r211419574 --- Diff: artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQMessage.java --- @@ -371,7 +369,7 @@ public

[GitHub] activemq-artemis pull request #2254: compatibility fixes and replication fix...

2018-08-20 Thread clebertsuconic
Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2254#discussion_r211419155 --- Diff: artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQDestination.java --- @@ -219,7 +221,12 @@

[GitHub] activemq-artemis pull request #2254: compatibility fixes and replication fix...

2018-08-20 Thread clebertsuconic
Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2254#discussion_r211418620 --- Diff: artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQDestination.java --- @@ -219,7 +221,12 @@

[GitHub] activemq-artemis pull request #2254: compatibility fixes and replication fix...

2018-08-20 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2254#discussion_r211418658 --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/ClientSessionImpl.java --- @@ -241,6 +243,16

[GitHub] activemq-artemis pull request #2254: compatibility fixes and replication fix...

2018-08-20 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2254#discussion_r211418260 --- Diff: artemis-commons/src/main/java/org/apache/activemq/artemis/utils/ArtemisSystemProperties.java --- @@ -0,0 +1,76 @@ +/*

[GitHub] activemq-artemis pull request #2254: compatibility fixes and replication fix...

2018-08-20 Thread clebertsuconic
Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2254#discussion_r211418220 --- Diff: artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQMessage.java --- @@ -423,7 +421,7 @@ public

[GitHub] activemq-artemis pull request #2254: compatibility fixes and replication fix...

2018-08-20 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2254#discussion_r211417924 --- Diff: artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQMessage.java --- @@ -423,7 +421,7 @@ public

[GitHub] activemq-artemis pull request #2254: compatibility fixes and replication fix...

2018-08-20 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2254#discussion_r211418039 --- Diff: artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQDestination.java --- @@ -219,7 +221,12 @@

[GitHub] activemq-artemis pull request #2254: compatibility fixes and replication fix...

2018-08-20 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2254#discussion_r211417758 --- Diff: artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQMessage.java --- @@ -371,7 +369,7 @@ public

[GitHub] activemq-artemis pull request #2254: compatibility fixes and replication fix...

2018-08-20 Thread clebertsuconic
Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2254#discussion_r211416478 --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/ClientSessionImpl.java --- @@ -241,6 +243,16 @@

[GitHub] activemq-artemis pull request #2254: compatibility fixes and replication fix...

2018-08-20 Thread clebertsuconic
Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2254#discussion_r211416106 --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/ClientSessionImpl.java --- @@ -241,6 +243,16 @@

[GitHub] activemq-artemis pull request #2254: compatibility fixes and replication fix...

2018-08-20 Thread clebertsuconic
Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2254#discussion_r211415938 --- Diff: artemis-commons/src/main/java/org/apache/activemq/artemis/utils/ArtemisSystemProperties.java --- @@ -0,0 +1,76 @@ +/* +

[GitHub] activemq-artemis pull request #2254: compatibility fixes and replication fix...

2018-08-20 Thread clebertsuconic
Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2254#discussion_r211415997 --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/ClientSessionImpl.java --- @@ -241,6 +243,16 @@

[GitHub] activemq-artemis pull request #2254: compatibility fixes and replication fix...

2018-08-20 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2254#discussion_r211415627 --- Diff: artemis-commons/src/main/java/org/apache/activemq/artemis/utils/ArtemisSystemProperties.java --- @@ -0,0 +1,76 @@ +/*

[GitHub] activemq-artemis pull request #2254: compatibility fixes and replication fix...

2018-08-20 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2254#discussion_r211415126 --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/ClientSessionImpl.java --- @@ -241,6 +243,16

[GitHub] activemq-artemis pull request #2254: compatibility fixes and replication fix...

2018-08-20 Thread clebertsuconic
Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2254#discussion_r211413708 --- Diff: artemis-commons/src/main/java/org/apache/activemq/artemis/utils/ArtemisSystemProperties.java --- @@ -0,0 +1,76 @@ +/* +

[GitHub] activemq-artemis pull request #2254: compatibility fixes and replication fix...

2018-08-20 Thread clebertsuconic
Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2254#discussion_r211413409 --- Diff: artemis-commons/src/main/java/org/apache/activemq/artemis/utils/ArtemisSystemProperties.java --- @@ -0,0 +1,76 @@ +/* +

[GitHub] activemq-artemis pull request #2254: compatibility fixes and replication fix...

2018-08-20 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2254#discussion_r211413331 --- Diff: artemis-commons/src/main/java/org/apache/activemq/artemis/utils/ArtemisSystemProperties.java --- @@ -0,0 +1,76 @@ +/*

[GitHub] activemq-artemis pull request #2254: compatibility fixes and replication fix...

2018-08-20 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2254#discussion_r211412518 --- Diff: artemis-commons/src/main/java/org/apache/activemq/artemis/utils/ArtemisSystemProperties.java --- @@ -0,0 +1,76 @@ +/*

[GitHub] activemq-artemis pull request #2254: compatibility fixes and replication fix...

2018-08-20 Thread clebertsuconic
Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2254#discussion_r211411859 --- Diff: artemis-commons/src/main/java/org/apache/activemq/artemis/utils/ArtemisSystemProperties.java --- @@ -0,0 +1,76 @@ +/* +

[GitHub] activemq-artemis pull request #2254: compatibility fixes and replication fix...

2018-08-20 Thread clebertsuconic
Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2254#discussion_r211410036 --- Diff: artemis-commons/src/main/java/org/apache/activemq/artemis/utils/ArtemisSystemProperties.java --- @@ -0,0 +1,76 @@ +/* +

[GitHub] activemq-artemis pull request #2254: compatibility fixes and replication fix...

2018-08-20 Thread clebertsuconic
Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2254#discussion_r211409599 --- Diff: artemis-commons/src/main/java/org/apache/activemq/artemis/utils/ArtemisSystemProperties.java --- @@ -0,0 +1,76 @@ +/* +

[GitHub] activemq-artemis pull request #2254: compatibility fixes and replication fix...

2018-08-20 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2254#discussion_r211409233 --- Diff: artemis-commons/src/main/java/org/apache/activemq/artemis/utils/ArtemisSystemProperties.java --- @@ -0,0 +1,76 @@ +/*

[GitHub] activemq-artemis pull request #2254: compatibility fixes and replication fix...

2018-08-20 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2254#discussion_r211409036 --- Diff: artemis-commons/src/main/java/org/apache/activemq/artemis/utils/ArtemisSystemProperties.java --- @@ -0,0 +1,76 @@ +/*

[GitHub] activemq-artemis pull request #2254: compatibility fixes and replication fix...

2018-08-20 Thread clebertsuconic
GitHub user clebertsuconic opened a pull request: https://github.com/apache/activemq-artemis/pull/2254 compatibility fixes and replication fixes You can merge this pull request into a Git repository by running: $ git pull https://github.com/clebertsuconic/activemq-artemis

[GitHub] activemq-artemis pull request #:

2018-08-19 Thread clebertsuconic
Github user clebertsuconic commented on the pull request: https://github.com/apache/activemq-artemis/commit/97bfaabdaa23672e15c154b838a4e9ea2aa4df17#commitcomment-30185652 not very orthodox.. but I removed the commit with a push -f (I don't this very often) ---

[GitHub] activemq-artemis pull request #:

2018-08-19 Thread clebertsuconic
Github user clebertsuconic commented on the pull request: https://github.com/apache/activemq-artemis/commit/97bfaabdaa23672e15c154b838a4e9ea2aa4df17#commitcomment-30185630 hmmm... you meant 2.6.x... I will revert the commit in there. ---

[GitHub] activemq-artemis pull request #:

2018-08-19 Thread clebertsuconic
Github user clebertsuconic commented on the pull request: https://github.com/apache/activemq-artemis/commit/97bfaabdaa23672e15c154b838a4e9ea2aa4df17#commitcomment-30181128 @michalxo try building from the root project.. mvn clean; mvn install from the root. All my CIs

[GitHub] activemq-artemis pull request #:

2018-08-19 Thread michalxo
Github user michalxo commented on the pull request: https://github.com/apache/activemq-artemis/commit/97bfaabdaa23672e15c154b838a4e9ea2aa4df17#commitcomment-30179541 Seems like due to this commit, artemis can't be built (due to Integration tests failing). ``` [INFO]

[GitHub] activemq-artemis pull request #2253: NO-JIRA Tweak RedeployTest

2018-08-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2253 ---

[GitHub] activemq-artemis pull request #2253: NO-JIRA Tweak RedeployTest

2018-08-17 Thread jbertram
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/2253 NO-JIRA Tweak RedeployTest 1) Remove use of deprecated EmbeddedJMS. 2) Change test config to use static clustering as discovery may not work in some CI environments. You can

[GitHub] activemq-artemis pull request #2252: ARTEMIS-2023 Fix missing setEnable1x me...

2018-08-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2252 ---

[GitHub] activemq-artemis pull request #2252: ARTEMIS-2023 Fix missing setEnable1x me...

2018-08-17 Thread mtaylor
GitHub user mtaylor opened a pull request: https://github.com/apache/activemq-artemis/pull/2252 ARTEMIS-2023 Fix missing setEnable1x methods You can merge this pull request into a Git repository by running: $ git pull https://github.com/mtaylor/activemq-artemis

[GitHub] activemq-artemis pull request #2251: ARTEMIS-2023 extend 1x naming to other ...

2018-08-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2251 ---

[GitHub] activemq-artemis pull request #2251: ARTEMIS-2023 extend 1x naming to other ...

2018-08-16 Thread jbertram
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/2251 ARTEMIS-2023 extend 1x naming to other ops You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-2023

[GitHub] activemq-artemis pull request #2250: ARTEMIS-1996 MappedSequentialFileFactor...

2018-08-15 Thread franz1981
GitHub user franz1981 opened a pull request: https://github.com/apache/activemq-artemis/pull/2250 ARTEMIS-1996 MappedSequentialFileFactory may cause DirectByteBuffer off-heap memory leaks Compaction is now reusing direct ByteBuffers on both reading and writing with explicit and

[GitHub] activemq-artemis pull request #2249: ARTEMIS-2023 Fix NPE

2018-08-15 Thread jdanekrh
Github user jdanekrh commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2249#discussion_r210198098 --- Diff: artemis-jms-server/src/main/java/org/apache/activemq/artemis/jms/server/config/impl/ConnectionFactoryConfigurationImpl.java --- @@

[GitHub] activemq-artemis pull request #2241: Added a Spring Boot Sample integration

2018-08-14 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2241 ---

[GitHub] activemq-artemis pull request #2249: ARTEMIS-2023 Fix NPE

2018-08-14 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2249#discussion_r210023905 --- Diff: tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/jms/client/StoreConfigTest.java --- @@

[GitHub] activemq-artemis pull request #2249: ARTEMIS-2023 Fix NPE

2018-08-14 Thread clebertsuconic
Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2249#discussion_r210022817 --- Diff: tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/jms/client/StoreConfigTest.java --- @@

[GitHub] activemq-artemis pull request #2249: ARTEMIS-2023 Fix NPE

2018-08-14 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2249 ---

[GitHub] activemq-artemis pull request #2249: ARTEMIS-2023 Fix NPE

2018-08-14 Thread clebertsuconic
Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2249#discussion_r210016740 --- Diff: tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/jms/client/StoreConfigTest.java --- @@

[GitHub] activemq-artemis pull request #2249: ARTEMIS-2023 Fix NPE

2018-08-14 Thread clebertsuconic
Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2249#discussion_r210016477 --- Diff: tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/jms/client/StoreConfigTest.java --- @@

[GitHub] activemq-artemis pull request #2249: ARTEMIS-2023 Fix NPE

2018-08-14 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2249#discussion_r210014188 --- Diff: tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/jms/client/StoreConfigTest.java --- @@

[GitHub] activemq-artemis pull request #2249: ARTEMIS-2023 Fix NPE

2018-08-14 Thread clebertsuconic
Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2249#discussion_r210009695 --- Diff: tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/jms/client/StoreConfigTest.java --- @@

[GitHub] activemq-artemis pull request #2249: ARTEMIS-2023 Fix NPE

2018-08-14 Thread michaelandrepearce
GitHub user michaelandrepearce opened a pull request: https://github.com/apache/activemq-artemis/pull/2249 ARTEMIS-2023 Fix NPE Add test to prove NPE and compatibility with 2.6.0 Fix decoding logic to avoid NPE You can merge this pull request into a Git repository by running:

[GitHub] activemq-artemis pull request #2248: ARTEMIS-2030 only use interrupt during ...

2018-08-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2248 ---

[GitHub] activemq-artemis pull request #2238: ARTEMIS-2023 Support 1x prefixes for JM...

2018-08-13 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2238#discussion_r209819327 --- Diff: artemis-jms-server/src/main/java/org/apache/activemq/artemis/jms/server/config/impl/ConnectionFactoryConfigurationImpl.java ---

[GitHub] activemq-artemis pull request #2248: ARTEMIS-2030 only use interrupt during ...

2018-08-13 Thread clebertsuconic
GitHub user clebertsuconic opened a pull request: https://github.com/apache/activemq-artemis/pull/2248 ARTEMIS-2030 only use interrupt during shutdown on RA You can merge this pull request into a Git repository by running: $ git pull

[GitHub] activemq-artemis pull request #2247: ARTEMIS-2029 Fixing wire checks after r...

2018-08-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2247 ---

[GitHub] activemq-artemis pull request #2246: ARTEMIS-2024 Enable SharedClientID on C...

2018-08-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2246 ---

[GitHub] activemq-artemis pull request #2246: ARTEMIS-2024 Enable SharedClientID on C...

2018-08-13 Thread mtaylor
Github user mtaylor commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2246#discussion_r209671702 --- Diff: tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/jms/client/ConnectionTest.java --- @@ -131,6

<    5   6   7   8   9   10   11   12   13   14   >