[GitHub] michaelandrepearce commented on issue #2514: ARTEMIS-2236 Address Latency Impact caused by ARTEMIS-1451

2019-01-23 Thread GitBox
michaelandrepearce commented on issue #2514: ARTEMIS-2236 Address Latency Impact caused by ARTEMIS-1451 URL: https://github.com/apache/activemq-artemis/pull/2514#issuecomment-456724549 @franz1981 yup agree there are some improvements we could have done, but have left them out As right

[GitHub] michaelandrepearce edited a comment on issue #2514: ARTEMIS-2236 Address Latency Impact caused by ARTEMIS-1451

2019-01-23 Thread GitBox
michaelandrepearce edited a comment on issue #2514: ARTEMIS-2236 Address Latency Impact caused by ARTEMIS-1451 URL: https://github.com/apache/activemq-artemis/pull/2514#issuecomment-456724549 @franz1981 yup agree there are some improvements we could have done, but have left them out As

[GitHub] michaelandrepearce edited a comment on issue #2514: ARTEMIS-2236 Address Latency Impact caused by ARTEMIS-1451

2019-01-23 Thread GitBox
michaelandrepearce edited a comment on issue #2514: ARTEMIS-2236 Address Latency Impact caused by ARTEMIS-1451 URL: https://github.com/apache/activemq-artemis/pull/2514#issuecomment-456724549 @franz1981 yup agree there are some improvements we could have done, but have left them out.

[GitHub] franz1981 commented on a change in pull request #2514: ARTEMIS-2236 Address Latency Impact caused by ARTEMIS-1451

2019-01-23 Thread GitBox
franz1981 commented on a change in pull request #2514: ARTEMIS-2236 Address Latency Impact caused by ARTEMIS-1451 URL: https://github.com/apache/activemq-artemis/pull/2514#discussion_r250105709 ## File path:

[GitHub] franz1981 commented on issue #2514: ARTEMIS-2236 Address Latency Impact caused by ARTEMIS-1451

2019-01-23 Thread GitBox
franz1981 commented on issue #2514: ARTEMIS-2236 Address Latency Impact caused by ARTEMIS-1451 URL: https://github.com/apache/activemq-artemis/pull/2514#issuecomment-456725073 @michaelandrepearce Yep, but consider that providing a lock-free implementation *is* an improvement that need

[GitHub] michaelandrepearce edited a comment on issue #2514: ARTEMIS-2236 Address Latency Impact caused by ARTEMIS-1451

2019-01-23 Thread GitBox
michaelandrepearce edited a comment on issue #2514: ARTEMIS-2236 Address Latency Impact caused by ARTEMIS-1451 URL: https://github.com/apache/activemq-artemis/pull/2514#issuecomment-456725467 @franz1981 no indeed, and thats not what im doing. Im reverting but also removed the need

[GitHub] franz1981 commented on a change in pull request #2514: ARTEMIS-2236 Address Latency Impact caused by ARTEMIS-1451

2019-01-23 Thread GitBox
franz1981 commented on a change in pull request #2514: ARTEMIS-2236 Address Latency Impact caused by ARTEMIS-1451 URL: https://github.com/apache/activemq-artemis/pull/2514#discussion_r250105709 ## File path:

[GitHub] franz1981 commented on issue #2514: ARTEMIS-2236 Address Latency Impact caused by ARTEMIS-1451

2019-01-23 Thread GitBox
franz1981 commented on issue #2514: ARTEMIS-2236 Address Latency Impact caused by ARTEMIS-1451 URL: https://github.com/apache/activemq-artemis/pull/2514#issuecomment-456725789 > I'm reverting but also removed the need for the sync blocks, and using atomic updater to the threadTaskDelta

[GitHub] michaelandrepearce edited a comment on issue #2514: ARTEMIS-2236 Address Latency Impact caused by ARTEMIS-1451

2019-01-23 Thread GitBox
michaelandrepearce edited a comment on issue #2514: ARTEMIS-2236 Address Latency Impact caused by ARTEMIS-1451 URL: https://github.com/apache/activemq-artemis/pull/2514#issuecomment-456725467 @franz1981 no indeed, and thats not what im doing. Im reverting but also removed the need

[GitHub] michaelandrepearce commented on issue #2514: ARTEMIS-2236 Address Latency Impact caused by ARTEMIS-1451

2019-01-23 Thread GitBox
michaelandrepearce commented on issue #2514: ARTEMIS-2236 Address Latency Impact caused by ARTEMIS-1451 URL: https://github.com/apache/activemq-artemis/pull/2514#issuecomment-456725467 @franz1981 no indeed, and thats not what im doing. Im reverting but also removed the need for the

[GitHub] michaelandrepearce edited a comment on issue #2514: ARTEMIS-2236 Address Latency Impact caused by ARTEMIS-1451

2019-01-23 Thread GitBox
michaelandrepearce edited a comment on issue #2514: ARTEMIS-2236 Address Latency Impact caused by ARTEMIS-1451 URL: https://github.com/apache/activemq-artemis/pull/2514#issuecomment-456709895 To show this, using a broker with persistance disabled (to remove external disk perf factors)

[GitHub] michaelandrepearce edited a comment on issue #2514: ARTEMIS-2236 Address Latency Impact caused by ARTEMIS-1451

2019-01-23 Thread GitBox
michaelandrepearce edited a comment on issue #2514: ARTEMIS-2236 Address Latency Impact caused by ARTEMIS-1451 URL: https://github.com/apache/activemq-artemis/pull/2514#issuecomment-456708382 ARTEMIS-1451 removed synchronization in the class, by adding the overhead of creating a new

[GitHub] franz1981 commented on issue #2514: ARTEMIS-2236 Address Latency Impact caused by ARTEMIS-1451

2019-01-23 Thread GitBox
franz1981 commented on issue #2514: ARTEMIS-2236 Address Latency Impact caused by ARTEMIS-1451 URL: https://github.com/apache/activemq-artemis/pull/2514#issuecomment-456711246 Suggestion: i would use something more precise (with an higher spectrum of latencies) if possible to make things

[GitHub] michaelandrepearce edited a comment on issue #2514: ARTEMIS-2236 Address Latency Impact caused by ARTEMIS-1451

2019-01-23 Thread GitBox
michaelandrepearce edited a comment on issue #2514: ARTEMIS-2236 Address Latency Impact caused by ARTEMIS-1451 URL: https://github.com/apache/activemq-artemis/pull/2514#issuecomment-456709895 To show this, using a broker with persistance disabled (to remove external disk perf factors),

[GitHub] franz1981 edited a comment on issue #2514: ARTEMIS-2236 Address Latency Impact caused by ARTEMIS-1451

2019-01-23 Thread GitBox
franz1981 edited a comment on issue #2514: ARTEMIS-2236 Address Latency Impact caused by ARTEMIS-1451 URL: https://github.com/apache/activemq-artemis/pull/2514#issuecomment-456711246 Suggestion: i would use something more precise (with an higher spectrum of latencies) if possible to make

[GitHub] michaelandrepearce edited a comment on issue #2514: ARTEMIS-2236 Address Latency Impact caused by ARTEMIS-1451

2019-01-23 Thread GitBox
michaelandrepearce edited a comment on issue #2514: ARTEMIS-2236 Address Latency Impact caused by ARTEMIS-1451 URL: https://github.com/apache/activemq-artemis/pull/2514#issuecomment-456712653 @franz1981 we dont even need, that the % change is quite significant. Also note

[GitHub] michaelandrepearce commented on issue #2514: ARTEMIS-2236 Address Latency Impact caused by ARTEMIS-1451

2019-01-23 Thread GitBox
michaelandrepearce commented on issue #2514: ARTEMIS-2236 Address Latency Impact caused by ARTEMIS-1451 URL: https://github.com/apache/activemq-artemis/pull/2514#issuecomment-456713968 @franz1981 we have been running investigations in a REAL environment going back an forth between

[GitHub] michaelandrepearce commented on issue #2514: ARTEMIS-2236 Address Latency Impact caused by ARTEMIS-1451

2019-01-23 Thread GitBox
michaelandrepearce commented on issue #2514: ARTEMIS-2236 Address Latency Impact caused by ARTEMIS-1451 URL: https://github.com/apache/activemq-artemis/pull/2514#issuecomment-456716247 @franz1981 its not down to sizing the thread pool.

[GitHub] michaelandrepearce commented on issue #2514: ARTEMIS-2236 Address Latency Impact caused by ARTEMIS-1451

2019-01-23 Thread GitBox
michaelandrepearce commented on issue #2514: ARTEMIS-2236 Address Latency Impact caused by ARTEMIS-1451 URL: https://github.com/apache/activemq-artemis/pull/2514#issuecomment-456716626 @franz1981 This is what the old varient tried to avoid, was creating new threads...

[GitHub] michaelandrepearce edited a comment on issue #2514: ARTEMIS-2236 Address Latency Impact caused by ARTEMIS-1451

2019-01-23 Thread GitBox
michaelandrepearce edited a comment on issue #2514: ARTEMIS-2236 Address Latency Impact caused by ARTEMIS-1451 URL: https://github.com/apache/activemq-artemis/pull/2514#issuecomment-456716626 @franz1981 This is what the old varient tried to avoid, was creating new threads... The

[GitHub] michaelandrepearce edited a comment on issue #2514: ARTEMIS-2236 Address Latency Impact caused by ARTEMIS-1451

2019-01-23 Thread GitBox
michaelandrepearce edited a comment on issue #2514: ARTEMIS-2236 Address Latency Impact caused by ARTEMIS-1451 URL: https://github.com/apache/activemq-artemis/pull/2514#issuecomment-456718199 @franz1981 roughly correct The original one before 1451, tried to re-use an idle thread if

[GitHub] michaelandrepearce edited a comment on issue #2514: ARTEMIS-2236 Address Latency Impact caused by ARTEMIS-1451

2019-01-23 Thread GitBox
michaelandrepearce edited a comment on issue #2514: ARTEMIS-2236 Address Latency Impact caused by ARTEMIS-1451 URL: https://github.com/apache/activemq-artemis/pull/2514#issuecomment-456718199 @franz1981 roughly correct The original one before 1451, tried to re-use an idle thread if

[GitHub] michaelandrepearce commented on issue #2514: ARTEMIS-2236 Address Latency Impact caused by ARTEMIS-1451

2019-01-23 Thread GitBox
michaelandrepearce commented on issue #2514: ARTEMIS-2236 Address Latency Impact caused by ARTEMIS-1451 URL: https://github.com/apache/activemq-artemis/pull/2514#issuecomment-456719291 correct. This is an automated message

[GitHub] franz1981 edited a comment on issue #2514: ARTEMIS-2236 Address Latency Impact caused by ARTEMIS-1451

2019-01-23 Thread GitBox
franz1981 edited a comment on issue #2514: ARTEMIS-2236 Address Latency Impact caused by ARTEMIS-1451 URL: https://github.com/apache/activemq-artemis/pull/2514#issuecomment-456719095 @michaelandrepearce Ok and the old thread-pool, assuming max thread count already reached, was equally

[GitHub] franz1981 commented on issue #2514: ARTEMIS-2236 Address Latency Impact caused by ARTEMIS-1451

2019-01-23 Thread GitBox
franz1981 commented on issue #2514: ARTEMIS-2236 Address Latency Impact caused by ARTEMIS-1451 URL: https://github.com/apache/activemq-artemis/pull/2514#issuecomment-456719095 @michaelandrepearce Ok and the old thread-pool, assuming max thread count already reached, was equally

[GitHub] franz1981 edited a comment on issue #2514: ARTEMIS-2236 Address Latency Impact caused by ARTEMIS-1451

2019-01-23 Thread GitBox
franz1981 edited a comment on issue #2514: ARTEMIS-2236 Address Latency Impact caused by ARTEMIS-1451 URL: https://github.com/apache/activemq-artemis/pull/2514#issuecomment-456719988 Ok, if that's the problem I agree with you that need to be addressed: is not the behaviour of a

[GitHub] franz1981 commented on issue #2514: ARTEMIS-2236 Address Latency Impact caused by ARTEMIS-1451

2019-01-23 Thread GitBox
franz1981 commented on issue #2514: ARTEMIS-2236 Address Latency Impact caused by ARTEMIS-1451 URL: https://github.com/apache/activemq-artemis/pull/2514#issuecomment-456719988 Ok, if that's the problem I agree with you that need to be addressed: is not the behaviour of a thread-pool, that

[GitHub] franz1981 edited a comment on issue #2514: ARTEMIS-2236 Address Latency Impact caused by ARTEMIS-1451

2019-01-23 Thread GitBox
franz1981 edited a comment on issue #2514: ARTEMIS-2236 Address Latency Impact caused by ARTEMIS-1451 URL: https://github.com/apache/activemq-artemis/pull/2514#issuecomment-456721762 Now that you've helped me to understand the issue I believe that's correct: let me take a look to the PR

[GitHub] franz1981 commented on issue #2514: ARTEMIS-2236 Address Latency Impact caused by ARTEMIS-1451

2019-01-23 Thread GitBox
franz1981 commented on issue #2514: ARTEMIS-2236 Address Latency Impact caused by ARTEMIS-1451 URL: https://github.com/apache/activemq-artemis/pull/2514#issuecomment-456721762 Now that you've helped me to understand the issue I believe that's correct: let me take a look to the current

[GitHub] michaelandrepearce commented on issue #2514: ARTEMIS-2236 Address Latency Impact caused by ARTEMIS-1451

2019-01-23 Thread GitBox
michaelandrepearce commented on issue #2514: ARTEMIS-2236 Address Latency Impact caused by ARTEMIS-1451 URL: https://github.com/apache/activemq-artemis/pull/2514#issuecomment-456722769 So all ive done, is revert that change of 1451 to put back semantics. Streamlined the code a tad,

[GitHub] michaelandrepearce edited a comment on issue #2514: ARTEMIS-2236 Address Latency Impact caused by ARTEMIS-1451

2019-01-23 Thread GitBox
michaelandrepearce edited a comment on issue #2514: ARTEMIS-2236 Address Latency Impact caused by ARTEMIS-1451 URL: https://github.com/apache/activemq-artemis/pull/2514#issuecomment-456722769 So all ive done, is revert that change of 1451 to put back semantics. Streamlined the code

[GitHub] franz1981 commented on issue #2514: ARTEMIS-2236 Address Latency Impact caused by ARTEMIS-1451

2019-01-23 Thread GitBox
franz1981 commented on issue #2514: ARTEMIS-2236 Address Latency Impact caused by ARTEMIS-1451 URL: https://github.com/apache/activemq-artemis/pull/2514#issuecomment-456723336 Yep I see that there are a couple of things that could be addressed due to this + a possible improvement: I will

[GitHub] michaelandrepearce edited a comment on issue #2514: ARTEMIS-2236 Address Latency Impact caused by ARTEMIS-1451

2019-01-23 Thread GitBox
michaelandrepearce edited a comment on issue #2514: ARTEMIS-2236 Address Latency Impact caused by ARTEMIS-1451 URL: https://github.com/apache/activemq-artemis/pull/2514#issuecomment-456724549 @franz1981 yup agree there are some improvements we could have done, but have left them out As

[GitHub] michaelandrepearce edited a comment on issue #2514: ARTEMIS-2236 Address Latency Impact caused by ARTEMIS-1451

2019-01-23 Thread GitBox
michaelandrepearce edited a comment on issue #2514: ARTEMIS-2236 Address Latency Impact caused by ARTEMIS-1451 URL: https://github.com/apache/activemq-artemis/pull/2514#issuecomment-456725981 I can un-squash and make it a two stage commit if it helps? e.g. revert commit, then remove sync

[GitHub] michaelandrepearce commented on issue #2514: ARTEMIS-2236 Address Latency Impact caused by ARTEMIS-1451

2019-01-23 Thread GitBox
michaelandrepearce commented on issue #2514: ARTEMIS-2236 Address Latency Impact caused by ARTEMIS-1451 URL: https://github.com/apache/activemq-artemis/pull/2514#issuecomment-456725981 I can make it a two stage commit if it helps?

[GitHub] ldebello commented on issue #2510: [ARTEMIS-2156] Message Duplication when using exclusive divert and clustering

2019-01-23 Thread GitBox
ldebello commented on issue #2510: [ARTEMIS-2156] Message Duplication when using exclusive divert and clustering URL: https://github.com/apache/activemq-artemis/pull/2510#issuecomment-456842951 @clebertsuconic sorry just one question to understand the workflow is common to see the PR

[GitHub] michaelandrepearce commented on issue #2490: ARTEMIS-196 Implement Consumer Priority

2019-01-23 Thread GitBox
michaelandrepearce commented on issue #2490: ARTEMIS-196 Implement Consumer Priority URL: https://github.com/apache/activemq-artemis/pull/2490#issuecomment-456881694 @clebertsuconic some of those variables are used but accesed by atomic updaters. Have commented on your commit

[GitHub] asfgit merged pull request #2514: ARTEMIS-2236 Address Latency Impact caused by ARTEMIS-1451

2019-01-23 Thread GitBox
asfgit merged pull request #2514: ARTEMIS-2236 Address Latency Impact caused by ARTEMIS-1451 URL: https://github.com/apache/activemq-artemis/pull/2514 This is an automated message from the Apache Git Service. To respond to

[GitHub] asfgit closed pull request #2510: [ARTEMIS-2156] Message Duplication when using exclusive divert and clustering

2019-01-23 Thread GitBox
asfgit closed pull request #2510: [ARTEMIS-2156] Message Duplication when using exclusive divert and clustering URL: https://github.com/apache/activemq-artemis/pull/2510 This is an automated message from the Apache Git

[GitHub] clebertsuconic commented on issue #2490: ARTEMIS-196 Implement Consumer Priority

2019-01-23 Thread GitBox
clebertsuconic commented on issue #2490: ARTEMIS-196 Implement Consumer Priority URL: https://github.com/apache/activemq-artemis/pull/2490#issuecomment-456877360 I added one change on top of yours during merge... to remove unused variables.. merged! you are the man!

[GitHub] asfgit closed pull request #2451: ARTEMIS-2192 LegacyLDAPSecuritySettingPlugin uses hard-coded RDN types

2019-01-23 Thread GitBox
asfgit closed pull request #2451: ARTEMIS-2192 LegacyLDAPSecuritySettingPlugin uses hard-coded RDN types URL: https://github.com/apache/activemq-artemis/pull/2451 This is an automated message from the Apache Git Service. To

[GitHub] clebertsuconic commented on issue #2490: ARTEMIS-196 Implement Consumer Priority

2019-01-22 Thread GitBox
clebertsuconic commented on issue #2490: ARTEMIS-196 Implement Consumer Priority URL: https://github.com/apache/activemq-artemis/pull/2490#issuecomment-456656799 @michaelandrepearce I'm pretty sure I will be able to merge this tomorrow. Testsuite had some unrelated failures. I just want to

[GitHub] clebertsuconic commented on issue #2514: ARTEMIS-2236 Address Latency Impact caused by ARTEMIS-1451

2019-01-23 Thread GitBox
clebertsuconic commented on issue #2514: ARTEMIS-2236 Address Latency Impact caused by ARTEMIS-1451 URL: https://github.com/apache/activemq-artemis/pull/2514#issuecomment-456837511 Oh shoot.. I don't know how I missed this.. I'm the one who merged it.. I wouldn't have merged it if

[GitHub] asfgit closed pull request #2490: ARTEMIS-196 Implement Consumer Priority

2019-01-23 Thread GitBox
asfgit closed pull request #2490: ARTEMIS-196 Implement Consumer Priority URL: https://github.com/apache/activemq-artemis/pull/2490 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] michaelandrepearce commented on issue #2427: ARTEMIS-2170 Optimized CoreMessage's checkProperties and cleanupInternalProperties methods

2019-01-23 Thread GitBox
michaelandrepearce commented on issue #2427: ARTEMIS-2170 Optimized CoreMessage's checkProperties and cleanupInternalProperties methods URL: https://github.com/apache/activemq-artemis/pull/2427#issuecomment-456947342 I happy to merge this if you are ready. Have been waiting for your ci

[GitHub] michaelandrepearce edited a comment on issue #2427: ARTEMIS-2170 Optimized CoreMessage's checkProperties and cleanupInternalProperties methods

2019-01-23 Thread GitBox
michaelandrepearce edited a comment on issue #2427: ARTEMIS-2170 Optimized CoreMessage's checkProperties and cleanupInternalProperties methods URL: https://github.com/apache/activemq-artemis/pull/2427#issuecomment-456947342 @franz1981 I happy to merge this if you are ready. Have been

[GitHub] michaelandrepearce commented on issue #2199: ARTEMIS-1996 MappedSequentialFileFactory may cause DirectByteBuffer off-heap memory leaks

2019-01-23 Thread GitBox
michaelandrepearce commented on issue #2199: ARTEMIS-1996 MappedSequentialFileFactory may cause DirectByteBuffer off-heap memory leaks URL: https://github.com/apache/activemq-artemis/pull/2199#issuecomment-456949661 @morefuntang ping. I will close this in a couple days as no response for 3

[GitHub] michaelandrepearce edited a comment on issue #2427: ARTEMIS-2170 Optimized CoreMessage's checkProperties and cleanupInternalProperties methods

2019-01-23 Thread GitBox
michaelandrepearce edited a comment on issue #2427: ARTEMIS-2170 Optimized CoreMessage's checkProperties and cleanupInternalProperties methods URL: https://github.com/apache/activemq-artemis/pull/2427#issuecomment-456947342 @franz1981 I happy to merge this if you are ready. Have been

[GitHub] asfgit closed pull request #2515: ARTEMIS-1867 fix FQQNOpenWireTest

2019-01-23 Thread GitBox
asfgit closed pull request #2515: ARTEMIS-1867 fix FQQNOpenWireTest URL: https://github.com/apache/activemq-artemis/pull/2515 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] jbertram opened a new pull request #2515: ARTEMIS-1867 fix FQQNOpenWireTest

2019-01-23 Thread GitBox
jbertram opened a new pull request #2515: ARTEMIS-1867 fix FQQNOpenWireTest URL: https://github.com/apache/activemq-artemis/pull/2515 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] clebertsuconic commented on issue #2490: ARTEMIS-196 Implement Consumer Priority

2019-01-23 Thread GitBox
clebertsuconic commented on issue #2490: ARTEMIS-196 Implement Consumer Priority URL: https://github.com/apache/activemq-artemis/pull/2490#issuecomment-456913156 @michaelandrepearce duh.. thanks This is an automated message

[GitHub] michaelandrepearce commented on issue #1293: ARTEMIS-1194: SOCKS proxy support

2019-01-23 Thread GitBox
michaelandrepearce commented on issue #1293: ARTEMIS-1194: SOCKS proxy support URL: https://github.com/apache/activemq-artemis/pull/1293#issuecomment-456950321 @clebertsuconic whats occuring on this, we ok to merge? And simply mark feature beta until some decent tests?

[GitHub] tabish121 commented on issue #17: AMQCPP-643: Add an option to time out connection attempts when blocked in ensureConnectionInfoSent

2019-01-23 Thread GitBox
tabish121 commented on issue #17: AMQCPP-643: Add an option to time out connection attempts when blocked in ensureConnectionInfoSent URL: https://github.com/apache/activemq-cpp/pull/17#issuecomment-456951888 This is targeted at 3.9.x but would also need to go into master, can you target

[GitHub] michaelandrepearce commented on issue #1994: ARTEMIS-1787 Openwire message should not contain internal property

2019-01-23 Thread GitBox
michaelandrepearce commented on issue #1994: ARTEMIS-1787 Openwire message should not contain internal property URL: https://github.com/apache/activemq-artemis/pull/1994#issuecomment-456950879 As noted effort should go to native openwire message support #1793. Can we close this.

[GitHub] michaelandrepearce commented on issue #2274: ARTEMIS-2059 NettyWritable should use UTF-8 exact length to encode strings

2019-01-23 Thread GitBox
michaelandrepearce commented on issue #2274: ARTEMIS-2059 NettyWritable should use UTF-8 exact length to encode strings URL: https://github.com/apache/activemq-artemis/pull/2274#issuecomment-456951676 @franz1981 Can we close and reopen later once some more progress or discussion is done.

[GitHub] clebertsuconic commented on a change in pull request #2480: ARTEMIS-2212 Avoid using CLQ on ServerConsumerImpl

2019-01-17 Thread GitBox
clebertsuconic commented on a change in pull request #2480: ARTEMIS-2212 Avoid using CLQ on ServerConsumerImpl URL: https://github.com/apache/activemq-artemis/pull/2480#discussion_r248709539 ## File path:

[GitHub] clebertsuconic commented on a change in pull request #2480: ARTEMIS-2212 Avoid using CLQ on ServerConsumerImpl

2019-01-17 Thread GitBox
clebertsuconic commented on a change in pull request #2480: ARTEMIS-2212 Avoid using CLQ on ServerConsumerImpl URL: https://github.com/apache/activemq-artemis/pull/2480#discussion_r24870 ## File path:

[GitHub] asfgit closed pull request #2480: ARTEMIS-2212 Avoid using CLQ on ServerConsumerImpl

2019-01-17 Thread GitBox
asfgit closed pull request #2480: ARTEMIS-2212 Avoid using CLQ on ServerConsumerImpl URL: https://github.com/apache/activemq-artemis/pull/2480 This is an automated message from the Apache Git Service. To respond to the

[GitHub] franz1981 edited a comment on issue #2494: ARTEMIS-2224 Reduce contention on LivePageCacheImpl

2019-01-16 Thread GitBox
franz1981 edited a comment on issue #2494: ARTEMIS-2224 Reduce contention on LivePageCacheImpl URL: https://github.com/apache/activemq-artemis/pull/2494#issuecomment-454709952 @qihongxu What is worrying me is this > at most time it obtained a 3k~6k tps If the same test (same

[GitHub] michaelandrepearce commented on issue #2498: ARTEMIS-2228 Large Messages over Management

2019-01-15 Thread GitBox
michaelandrepearce commented on issue #2498: ARTEMIS-2228 Large Messages over Management URL: https://github.com/apache/activemq-artemis/pull/2498#issuecomment-454450983 Just fyi, Re your failed pr build since some recent merges to master ive been getting more intermittent build failures

[GitHub] franz1981 commented on issue #2250: ARTEMIS-1996 MappedSequentialFileFactory may cause DirectByteBuffer off-heap memory leaks

2019-01-14 Thread GitBox
franz1981 commented on issue #2250: ARTEMIS-1996 MappedSequentialFileFactory may cause DirectByteBuffer off-heap memory leaks URL: https://github.com/apache/activemq-artemis/pull/2250#issuecomment-454285382 @CNNJYB in this case it is wanted: compaction was leaking buffers big as as the

[GitHub] franz1981 edited a comment on issue #2250: ARTEMIS-1996 MappedSequentialFileFactory may cause DirectByteBuffer off-heap memory leaks

2019-01-14 Thread GitBox
franz1981 edited a comment on issue #2250: ARTEMIS-1996 MappedSequentialFileFactory may cause DirectByteBuffer off-heap memory leaks URL: https://github.com/apache/activemq-artemis/pull/2250#issuecomment-454285382 @CNNJYB in this case it is wanted: compaction was leaking buffers big as the

[GitHub] michaelandrepearce commented on a change in pull request #2498: ARTEMIS-2228 Large Messages over Management

2019-01-14 Thread GitBox
michaelandrepearce commented on a change in pull request #2498: ARTEMIS-2228 Large Messages over Management URL: https://github.com/apache/activemq-artemis/pull/2498#discussion_r247781204 ## File path:

[GitHub] franz1981 commented on a change in pull request #2494: ARTEMIS-2224 Reduce contention on LivePageCacheImpl

2019-01-17 Thread GitBox
franz1981 commented on a change in pull request #2494: ARTEMIS-2224 Reduce contention on LivePageCacheImpl URL: https://github.com/apache/activemq-artemis/pull/2494#discussion_r248691840 ## File path:

[GitHub] asfgit closed pull request #2500: NO-JIRA Adding test to verify Openwire consuming from FQQN

2019-01-17 Thread GitBox
asfgit closed pull request #2500: NO-JIRA Adding test to verify Openwire consuming from FQQN URL: https://github.com/apache/activemq-artemis/pull/2500 This is an automated message from the Apache Git Service. To respond to

[GitHub] qihongxu commented on issue #2494: ARTEMIS-2224 Reduce contention on LivePageCacheImpl

2019-01-16 Thread GitBox
qihongxu commented on issue #2494: ARTEMIS-2224 Reduce contention on LivePageCacheImpl URL: https://github.com/apache/activemq-artemis/pull/2494#issuecomment-454686710 > 900M of page size and very small messages are not such a common use case TBH Agreed. Use this case just to make

[GitHub] franz1981 commented on issue #2494: ARTEMIS-2224 Reduce contention on LivePageCacheImpl

2019-01-16 Thread GitBox
franz1981 commented on issue #2494: ARTEMIS-2224 Reduce contention on LivePageCacheImpl URL: https://github.com/apache/activemq-artemis/pull/2494#issuecomment-454709952 @qihongxu What is worrying me is this > at most time it obtained a 3k~6k tps If the same test (same

[GitHub] franz1981 edited a comment on issue #2494: ARTEMIS-2224 Reduce contention on LivePageCacheImpl

2019-01-16 Thread GitBox
franz1981 edited a comment on issue #2494: ARTEMIS-2224 Reduce contention on LivePageCacheImpl URL: https://github.com/apache/activemq-artemis/pull/2494#issuecomment-454709952 @qihongxu What is worrying me is this > at most time it obtained a 3k~6k tps If the same test (same

[GitHub] franz1981 commented on issue #2494: ARTEMIS-2224 Reduce contention on LivePageCacheImpl

2019-01-15 Thread GitBox
franz1981 commented on issue #2494: ARTEMIS-2224 Reduce contention on LivePageCacheImpl URL: https://github.com/apache/activemq-artemis/pull/2494#issuecomment-454338688 > @franz1981 thx for recommending this tool, much easier to use than jfr! I was sure you would have like it: is

[GitHub] clebertsuconic commented on a change in pull request #2479: ARTEMIS-2211 Avoid duplicate code for ByteBuffer pooling and alignment

2019-01-17 Thread GitBox
clebertsuconic commented on a change in pull request #2479: ARTEMIS-2211 Avoid duplicate code for ByteBuffer pooling and alignment URL: https://github.com/apache/activemq-artemis/pull/2479#discussion_r248716417 ## File path:

[GitHub] asfgit closed pull request #2478: ARTEMIS-2210 Fix PagingStore creation synchronization issue

2019-01-17 Thread GitBox
asfgit closed pull request #2478: ARTEMIS-2210 Fix PagingStore creation synchronization issue URL: https://github.com/apache/activemq-artemis/pull/2478 This is an automated message from the Apache Git Service. To respond

[GitHub] asfgit closed pull request #2474: [ARTEMIS-1536]: Incorrect Journal filesize calculation where specified size is lest that the block size when using AIO.

2019-01-17 Thread GitBox
asfgit closed pull request #2474: [ARTEMIS-1536]: Incorrect Journal filesize calculation where specified size is lest that the block size when using AIO. URL: https://github.com/apache/activemq-artemis/pull/2474 This is an

[GitHub] clebertsuconic commented on issue #2474: [ARTEMIS-1536]: Incorrect Journal filesize calculation where specified size is lest that the block size when using AIO.

2019-01-17 Thread GitBox
clebertsuconic commented on issue #2474: [ARTEMIS-1536]: Incorrect Journal filesize calculation where specified size is lest that the block size when using AIO. URL: https://github.com/apache/activemq-artemis/pull/2474#issuecomment-455216239 merged & cherry-picked into 2.6.x

[GitHub] clebertsuconic commented on a change in pull request #2473: ARTEMIS-1058 Jars in web tmp dir locked on Windows

2019-01-17 Thread GitBox
clebertsuconic commented on a change in pull request #2473: ARTEMIS-1058 Jars in web tmp dir locked on Windows URL: https://github.com/apache/activemq-artemis/pull/2473#discussion_r248722829 ## File path:

[GitHub] clebertsuconic commented on issue #2466: ARTEMIS-2206 The MQTT consumer reconnection caused the queue to not be cle…

2019-01-17 Thread GitBox
clebertsuconic commented on issue #2466: ARTEMIS-2206 The MQTT consumer reconnection caused the queue to not be cle… URL: https://github.com/apache/activemq-artemis/pull/2466#issuecomment-455219150 @jbertram / @onlyMIT what's the status here? I was looking on PRs to merge but this one

[GitHub] jbertram commented on issue #2466: ARTEMIS-2206 The MQTT consumer reconnection caused the queue to not be cle…

2019-01-17 Thread GitBox
jbertram commented on issue #2466: ARTEMIS-2206 The MQTT consumer reconnection caused the queue to not be cle… URL: https://github.com/apache/activemq-artemis/pull/2466#issuecomment-455219703 @clebertsuconic, this is still in progress. I haven't had any time to follow-up yet.

[GitHub] clebertsuconic commented on a change in pull request #2459: ARTEMIS-2200 NPE while dropping/failing large messages on paging

2019-01-17 Thread GitBox
clebertsuconic commented on a change in pull request #2459: ARTEMIS-2200 NPE while dropping/failing large messages on paging URL: https://github.com/apache/activemq-artemis/pull/2459#discussion_r248724979 ## File path:

[GitHub] franz1981 commented on a change in pull request #2459: ARTEMIS-2200 NPE while dropping/failing large messages on paging

2019-01-17 Thread GitBox
franz1981 commented on a change in pull request #2459: ARTEMIS-2200 NPE while dropping/failing large messages on paging URL: https://github.com/apache/activemq-artemis/pull/2459#discussion_r248726229 ## File path:

[GitHub] franz1981 commented on a change in pull request #2459: ARTEMIS-2200 NPE while dropping/failing large messages on paging

2019-01-17 Thread GitBox
franz1981 commented on a change in pull request #2459: ARTEMIS-2200 NPE while dropping/failing large messages on paging URL: https://github.com/apache/activemq-artemis/pull/2459#discussion_r248726803 ## File path:

[GitHub] clebertsuconic commented on a change in pull request #2459: ARTEMIS-2200 NPE while dropping/failing large messages on paging

2019-01-17 Thread GitBox
clebertsuconic commented on a change in pull request #2459: ARTEMIS-2200 NPE while dropping/failing large messages on paging URL: https://github.com/apache/activemq-artemis/pull/2459#discussion_r248726923 ## File path:

[GitHub] michaelandrepearce edited a comment on issue #2438: ARTEMIS-2178 routing-type config for core bridge

2019-01-17 Thread GitBox
michaelandrepearce edited a comment on issue #2438: ARTEMIS-2178 routing-type config for core bridge URL: https://github.com/apache/activemq-artemis/pull/2438#issuecomment-455354071 @jbertram thanks for this, like the feature!!, sorry been so long to merge it for you.

[GitHub] asfgit closed pull request #2438: ARTEMIS-2178 routing-type config for core bridge

2019-01-17 Thread GitBox
asfgit closed pull request #2438: ARTEMIS-2178 routing-type config for core bridge URL: https://github.com/apache/activemq-artemis/pull/2438 This is an automated message from the Apache Git Service. To respond to the

[GitHub] michaelandrepearce commented on issue #2438: ARTEMIS-2178 routing-type config for core bridge

2019-01-17 Thread GitBox
michaelandrepearce commented on issue #2438: ARTEMIS-2178 routing-type config for core bridge URL: https://github.com/apache/activemq-artemis/pull/2438#issuecomment-455354071 @jbertram thanks for this, sorry been so long to merge it for you.

[GitHub] asfgit closed pull request #2470: Fixes for alerts from lgtm.com

2019-01-17 Thread GitBox
asfgit closed pull request #2470: Fixes for alerts from lgtm.com URL: https://github.com/apache/activemq-artemis/pull/2470 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] clebertsuconic commented on a change in pull request #2451: ARTEMIS-2192 LegacyLDAPSecuritySettingPlugin uses hard-coded RDN types

2019-01-17 Thread GitBox
clebertsuconic commented on a change in pull request #2451: ARTEMIS-2192 LegacyLDAPSecuritySettingPlugin uses hard-coded RDN types URL: https://github.com/apache/activemq-artemis/pull/2451#discussion_r248871028 ## File path:

[GitHub] clebertsuconic commented on issue #2434: ARTEMIS-1867 FQQN for producers

2019-01-17 Thread GitBox
clebertsuconic commented on issue #2434: ARTEMIS-1867 FQQN for producers URL: https://github.com/apache/activemq-artemis/pull/2434#issuecomment-455363730 this is conflicting. it will conflict even worse after we merge Consumers priority. Can we work on this after Consumers

[GitHub] michaelandrepearce edited a comment on issue #2434: ARTEMIS-1867 FQQN for producers

2019-01-17 Thread GitBox
michaelandrepearce edited a comment on issue #2434: ARTEMIS-1867 FQQN for producers URL: https://github.com/apache/activemq-artemis/pull/2434#issuecomment-455366517 @clebertsuconic ill hold on merging this, and the work on this with @jbertram after

[GitHub] clebertsuconic commented on issue #2445: ARTEMIS-2187 remove page from softcache before consumedpage

2019-01-17 Thread GitBox
clebertsuconic commented on issue #2445: ARTEMIS-2187 remove page from softcache before consumedpage URL: https://github.com/apache/activemq-artemis/pull/2445#issuecomment-455366535 on this case I think it will be enough if the tests are passing.. will merge it.

[GitHub] michaelandrepearce commented on issue #2434: ARTEMIS-1867 FQQN for producers

2019-01-17 Thread GitBox
michaelandrepearce commented on issue #2434: ARTEMIS-1867 FQQN for producers URL: https://github.com/apache/activemq-artemis/pull/2434#issuecomment-455366517 @clebertsuconic ill hold. This is an automated message from the

[GitHub] michaelandrepearce commented on issue #2445: ARTEMIS-2187 remove page from softcache before consumedpage

2019-01-17 Thread GitBox
michaelandrepearce commented on issue #2445: ARTEMIS-2187 remove page from softcache before consumedpage URL: https://github.com/apache/activemq-artemis/pull/2445#issuecomment-455370802 @clebertsuconic no worries, this is your area of expertise so will leave for your better judgement. If

[GitHub] michaelandrepearce commented on issue #2444: ARTEMIS-2186 Large message incomplete when server is crashed

2019-01-17 Thread GitBox
michaelandrepearce commented on issue #2444: ARTEMIS-2186 Large message incomplete when server is crashed URL: https://github.com/apache/activemq-artemis/pull/2444#issuecomment-455373882 @clebertsuconic you happy with this one? I am.

[GitHub] asfgit merged pull request #2501: ARTEMIS-2221 Fix Merge

2019-01-17 Thread GitBox
asfgit merged pull request #2501: ARTEMIS-2221 Fix Merge URL: https://github.com/apache/activemq-artemis/pull/2501 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and

[GitHub] franz1981 commented on a change in pull request #2427: ARTEMIS-2170 Optimized CoreMessage's checkProperties and cleanupInternalProperties methods

2019-01-17 Thread GitBox
franz1981 commented on a change in pull request #2427: ARTEMIS-2170 Optimized CoreMessage's checkProperties and cleanupInternalProperties methods URL: https://github.com/apache/activemq-artemis/pull/2427#discussion_r248889763 ## File path:

[GitHub] gaohoward opened a new pull request #2506: ARTEMIS-2230 Exception closing advisory consumers when supportAdvisory=false

2019-01-17 Thread GitBox
gaohoward opened a new pull request #2506: ARTEMIS-2230 Exception closing advisory consumers when supportAdvisory=false URL: https://github.com/apache/activemq-artemis/pull/2506 When broker's advisory is disabled (supportAdvisory=false) any advisory consumer won't get created at

[GitHub] gaohoward commented on issue #2386: ARTEMIS-2135 Test multiple core consumers receiving amqp messages

2019-01-17 Thread GitBox
gaohoward commented on issue #2386: ARTEMIS-2135 Test multiple core consumers receiving amqp messages URL: https://github.com/apache/activemq-artemis/pull/2386#issuecomment-455419691 closing this as it already merged. This

[GitHub] gaohoward closed pull request #2386: ARTEMIS-2135 Test multiple core consumers receiving amqp messages

2019-01-17 Thread GitBox
gaohoward closed pull request #2386: ARTEMIS-2135 Test multiple core consumers receiving amqp messages URL: https://github.com/apache/activemq-artemis/pull/2386 This is an automated message from the Apache Git Service. To

[GitHub] michaelandrepearce opened a new pull request #2504: NO-JIRA Check data != null during encode

2019-01-17 Thread GitBox
michaelandrepearce opened a new pull request #2504: NO-JIRA Check data != null during encode URL: https://github.com/apache/activemq-artemis/pull/2504 Picked up by code analysis checks This is an automated message from the

[GitHub] clebertsuconic commented on issue #2490: ARTEMIS-196 Implement Consumer Priority

2019-01-17 Thread GitBox
clebertsuconic commented on issue #2490: ARTEMIS-196 Implement Consumer Priority URL: https://github.com/apache/activemq-artemis/pull/2490#issuecomment-455388517 Current list of failures: Test Name | Duration | Age -- | -- | --

[GitHub] michaelandrepearce commented on issue #2490: ARTEMIS-196 Implement Consumer Priority

2019-01-17 Thread GitBox
michaelandrepearce commented on issue #2490: ARTEMIS-196 Implement Consumer Priority URL: https://github.com/apache/activemq-artemis/pull/2490#issuecomment-455391365 @clebertsuconic can you recheck this against master, i know things like testDoubleDelete are failing currently on master

[GitHub] michaelandrepearce edited a comment on issue #2490: ARTEMIS-196 Implement Consumer Priority

2019-01-17 Thread GitBox
michaelandrepearce edited a comment on issue #2490: ARTEMIS-196 Implement Consumer Priority URL: https://github.com/apache/activemq-artemis/pull/2490#issuecomment-455394066 @clebertsuconic the message group test ones are are genuine, should be fixed up in last push. I dont believe

<    1   2   3   4   5   6   7   8   9   10   >