[GitHub] clebertsuconic opened a new pull request #2544: max-disk default change

clebertsuconic opened a new pull request #2544: max-disk default change URL: https://github.com/apache/activemq-artemis/pull/2544 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] jbertram commented on issue #2543: ARTEMIS-2081 listConfiguredQueues returns only queues created by config

jbertram commented on issue #2543: ARTEMIS-2081 listConfiguredQueues returns only queues created by config URL: https://github.com/apache/activemq-artemis/pull/2543#issuecomment-461582642 Even though it's adding data to the queue encoding I see this as bug fix for the feature added in

[GitHub] jbertram commented on issue #2541: ARTEMIS-2246 clarify docs for defaults; change max-disk-usage default

jbertram commented on issue #2541: ARTEMIS-2246 clarify docs for defaults; change max-disk-usage default URL: https://github.com/apache/activemq-artemis/pull/2541#issuecomment-461581392 This was replaced by #2544. This is an

[GitHub] asfgit merged pull request #2544: max-disk default change

asfgit merged pull request #2544: max-disk default change URL: https://github.com/apache/activemq-artemis/pull/2544 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub

[GitHub] jbertram closed pull request #2541: ARTEMIS-2246 clarify docs for defaults; change max-disk-usage default

jbertram closed pull request #2541: ARTEMIS-2246 clarify docs for defaults; change max-disk-usage default URL: https://github.com/apache/activemq-artemis/pull/2541 This is an automated message from the Apache Git Service.

[GitHub] asfgit closed pull request #2542: ARTEMIS-2081 listConfiguredQueues returns only queues created by config

asfgit closed pull request #2542: ARTEMIS-2081 listConfiguredQueues returns only queues created by config URL: https://github.com/apache/activemq-artemis/pull/2542 This is an automated message from the Apache Git Service.

[GitHub] jbertram closed pull request #2543: ARTEMIS-2081 listConfiguredQueues returns only queues created by config

jbertram closed pull request #2543: ARTEMIS-2081 listConfiguredQueues returns only queues created by config URL: https://github.com/apache/activemq-artemis/pull/2543 This is an automated message from the Apache Git Service.

[GitHub] michaelandrepearce commented on issue #2543: ARTEMIS-2081 listConfiguredQueues returns only queues created by config

michaelandrepearce commented on issue #2543: ARTEMIS-2081 listConfiguredQueues returns only queues created by config URL: https://github.com/apache/activemq-artemis/pull/2543#issuecomment-461591422 @jbertram @clebertsuconic agreed this is a bug fix, i meant to port this to 2.6.x back last

[GitHub] ehsavoie closed pull request #2517: [ARTEMIS-2171]: ThreadPoolExecutor leak under SM due to lack of privileged block.

ehsavoie closed pull request #2517: [ARTEMIS-2171]: ThreadPoolExecutor leak under SM due to lack of privileged block. URL: https://github.com/apache/activemq-artemis/pull/2517 This is an automated message from the Apache

[GitHub] michaelandrepearce commented on a change in pull request #2517: [ARTEMIS-2171]: ThreadPoolExecutor leak under SM due to lack of privileged block.

michaelandrepearce commented on a change in pull request #2517: [ARTEMIS-2171]: ThreadPoolExecutor leak under SM due to lack of privileged block. URL: https://github.com/apache/activemq-artemis/pull/2517#discussion_r254982298 ## File path:

[GitHub] andytaylor opened a new pull request #2546: ARTEMIS-2249 - update cpp example to use correct client libs

andytaylor opened a new pull request #2546: ARTEMIS-2249 - update cpp example to use correct client libs URL: https://github.com/apache/activemq-artemis/pull/2546 https://issues.apache.org/jira/browse/ARTEMIS-2249 This is an

[GitHub] emagiz opened a new pull request #2547: Patched with live lock evaluation

emagiz opened a new pull request #2547: Patched with live lock evaluation URL: https://github.com/apache/activemq-artemis/pull/2547 When using the shared store the live server can loose the lock on the journal but does not notice it. This can happen when a shared file system is being used

[GitHub] michaelandrepearce edited a comment on issue #2287: ARTEMIS-2069 Backup doesn't activate after shared store is reconnected

michaelandrepearce edited a comment on issue #2287: ARTEMIS-2069 Backup doesn't activate after shared store is reconnected URL: https://github.com/apache/activemq-artemis/pull/2287#issuecomment-461819799 @clebertsuconic whilst im happy and would have merged. As you have raised a comment

[GitHub] michaelandrepearce commented on issue #2287: ARTEMIS-2069 Backup doesn't activate after shared store is reconnected

michaelandrepearce commented on issue #2287: ARTEMIS-2069 Backup doesn't activate after shared store is reconnected URL: https://github.com/apache/activemq-artemis/pull/2287#issuecomment-461819799 @clebertsuconic whilst im happy and would have merged. As you have raised a comment before i

[GitHub] TomasHofman commented on issue #2287: ARTEMIS-2069 Backup doesn't activate after shared store is reconnected

TomasHofman commented on issue #2287: ARTEMIS-2069 Backup doesn't activate after shared store is reconnected URL: https://github.com/apache/activemq-artemis/pull/2287#issuecomment-461810090 @michaelandrepearce just checking out on this, are there any reservations on this? I'm not sure if

[GitHub] franz1981 opened a new pull request #2545: ARTEMIS-2245 Cleaning up Docker images preparation, run and docs

franz1981 opened a new pull request #2545: ARTEMIS-2245 Cleaning up Docker images preparation, run and docs URL: https://github.com/apache/activemq-artemis/pull/2545 I've included: - doc fixes on both the docker image preparation and guide - allowed users to run other artemis

[GitHub] jbertram opened a new pull request #2540: ARTEMIS-2247 remove quotes from etc dir for Win service

jbertram opened a new pull request #2540: ARTEMIS-2247 remove quotes from etc dir for Win service URL: https://github.com/apache/activemq-artemis/pull/2540 This is an automated message from the Apache Git Service. To

[GitHub] jbertram opened a new pull request #2541: ARTEMIS-2246 clarify max-disk-usage 'default'

jbertram opened a new pull request #2541: ARTEMIS-2246 clarify max-disk-usage 'default' URL: https://github.com/apache/activemq-artemis/pull/2541 This is an automated message from the Apache Git Service. To respond to the

[GitHub] jbertram opened a new pull request #2539: ARTEMIS-2248 don't create sslEngine w/sniHost in NettyConnector

jbertram opened a new pull request #2539: ARTEMIS-2248 don't create sslEngine w/sniHost in NettyConnector URL: https://github.com/apache/activemq-artemis/pull/2539 This is an automated message from the Apache Git Service.

[GitHub] jbertram commented on issue #2539: ARTEMIS-2248 don't create sslEngine w/sniHost in NettyConnector

jbertram commented on issue #2539: ARTEMIS-2248 don't create sslEngine w/sniHost in NettyConnector URL: https://github.com/apache/activemq-artemis/pull/2539#issuecomment-461109432 @roddiekieley please review This is an

[GitHub] michaelandrepearce edited a comment on issue #2547: Patched with live lock evaluation

michaelandrepearce edited a comment on issue #2547: Patched with live lock evaluation URL: https://github.com/apache/activemq-artemis/pull/2547#issuecomment-461884720 First of all thanks for looking to contribute. Left some comments around using the common executor pools and better

[GitHub] michaelandrepearce commented on issue #2547: Patched with live lock evaluation

michaelandrepearce commented on issue #2547: Patched with live lock evaluation URL: https://github.com/apache/activemq-artemis/pull/2547#issuecomment-461885590 Also could you look at: https://github.com/apache/activemq-artemis/pull/2287 Are these to solutions dealing with same

[GitHub] michaelandrepearce edited a comment on issue #2547: Patched with live lock evaluation

michaelandrepearce edited a comment on issue #2547: Patched with live lock evaluation URL: https://github.com/apache/activemq-artemis/pull/2547#issuecomment-461885590 Also could you look at: https://github.com/apache/activemq-artemis/pull/2287 Are these two solutions dealing

[GitHub] coheigea opened a new pull request #344: Disable directory listing for the webconsole

coheigea opened a new pull request #344: Disable directory listing for the webconsole URL: https://github.com/apache/activemq/pull/344 We should disable directory listing for the web console, as a good security practise.

[GitHub] michaelandrepearce commented on a change in pull request #2547: Patched with live lock evaluation

michaelandrepearce commented on a change in pull request #2547: Patched with live lock evaluation URL: https://github.com/apache/activemq-artemis/pull/2547#discussion_r255168020 ## File path:

[GitHub] michaelandrepearce commented on issue #2547: Patched with live lock evaluation

michaelandrepearce commented on issue #2547: Patched with live lock evaluation URL: https://github.com/apache/activemq-artemis/pull/2547#issuecomment-461884720 Left some comments around using the common executor pools and better thread use. As like anything test case as well please

[GitHub] michaelandrepearce commented on a change in pull request #2547: Patched with live lock evaluation

michaelandrepearce commented on a change in pull request #2547: Patched with live lock evaluation URL: https://github.com/apache/activemq-artemis/pull/2547#discussion_r255168820 ## File path:

[GitHub] clebertsuconic commented on a change in pull request #2545: ARTEMIS-2245 Cleaning up Docker images preparation, run and docs

clebertsuconic commented on a change in pull request #2545: ARTEMIS-2245 Cleaning up Docker images preparation, run and docs URL: https://github.com/apache/activemq-artemis/pull/2545#discussion_r255229585 ## File path: artemis-docker/prepare-docker.sh ## @@ -29,7 +29,7 @@

[GitHub] michaelandrepearce commented on issue #2548: ARTEMIS-2118 Enhanced Message Groups Support

michaelandrepearce commented on issue #2548: ARTEMIS-2118 Enhanced Message Groups Support URL: https://github.com/apache/activemq-artemis/pull/2548#issuecomment-463959867 @franz1981 done, now using a single array (thats lazy initiated)

[GitHub] michaelandrepearce commented on issue #2548: ARTEMIS-2118 Enhanced Message Groups Support

michaelandrepearce commented on issue #2548: ARTEMIS-2118 Enhanced Message Groups Support URL: https://github.com/apache/activemq-artemis/pull/2548#issuecomment-463949198 @franz1981 and now because of the refactor and simpler methods we need to support i think i can easily implement the

[GitHub] jdanekrh opened a new pull request #2552: NO-JIRA Fix a "Dereference null return value" Coverity Scan warning

jdanekrh opened a new pull request #2552: NO-JIRA Fix a "Dereference null return value" Coverity Scan warning URL: https://github.com/apache/activemq-artemis/pull/2552 The value checked for null was not the one that was subsequently used.

[GitHub] jdanekrh opened a new pull request #2553: NO-JIRA Fix a "Inefficient Map Iterator" SpotBugs warning

jdanekrh opened a new pull request #2553: NO-JIRA Fix a "Inefficient Map Iterator" SpotBugs warning URL: https://github.com/apache/activemq-artemis/pull/2553

[GitHub] onlyMIT commented on a change in pull request #2528: ARTEMIS-2226 last consumer connection should close the previous consu…

onlyMIT commented on a change in pull request #2528: ARTEMIS-2226 last consumer connection should close the previous consu… URL: https://github.com/apache/activemq-artemis/pull/2528#discussion_r255960926 ## File path:

[GitHub] onlyMIT commented on a change in pull request #2528: ARTEMIS-2226 last consumer connection should close the previous consu…

onlyMIT commented on a change in pull request #2528: ARTEMIS-2226 last consumer connection should close the previous consu… URL: https://github.com/apache/activemq-artemis/pull/2528#discussion_r255985412 ## File path:

[GitHub] onlyMIT commented on a change in pull request #2528: ARTEMIS-2226 last consumer connection should close the previous consu…

onlyMIT commented on a change in pull request #2528: ARTEMIS-2226 last consumer connection should close the previous consu… URL: https://github.com/apache/activemq-artemis/pull/2528#discussion_r255983228 ## File path:

[GitHub] franz1981 commented on issue #2522: ARTEMIS-2239 Zero-copy NIO/MAPPED TimedBuffer

franz1981 commented on issue #2522: ARTEMIS-2239 Zero-copy NIO/MAPPED TimedBuffer URL: https://github.com/apache/activemq-artemis/pull/2522#issuecomment-462741716 This one should be kinda independent from the rest so can be merged without worrying about any conflicts, thanks!!!

[GitHub] qihongxu opened a new pull request #2549: ARTEMIS-2251 Large messages might not be deleted when server crashed

qihongxu opened a new pull request #2549: ARTEMIS-2251 Large messages might not be deleted when server crashed URL: https://github.com/apache/activemq-artemis/pull/2549 When deleting large messages, artemis will use storePendingLargeMessage to insert a temporary record in journal for

[GitHub] michaelandrepearce commented on issue #2548: ARTEMIS-2118 Enhanced Message Groups Support

michaelandrepearce commented on issue #2548: ARTEMIS-2118 Enhanced Message Groups Support URL: https://github.com/apache/activemq-artemis/pull/2548#issuecomment-463091333 @billpoole-mi No there wont be any special message. The intent here is for apps where you want evenly load

[GitHub] michaelandrepearce edited a comment on issue #2548: ARTEMIS-2118 Enhanced Message Groups Support

michaelandrepearce edited a comment on issue #2548: ARTEMIS-2118 Enhanced Message Groups Support URL: https://github.com/apache/activemq-artemis/pull/2548#issuecomment-463091333 @billpoole-mi No there wont be any special message. The intent here is for apps where you want evenly

[GitHub] michaelandrepearce edited a comment on issue #2548: ARTEMIS-2118 Enhanced Message Groups Support

michaelandrepearce edited a comment on issue #2548: ARTEMIS-2118 Enhanced Message Groups Support URL: https://github.com/apache/activemq-artemis/pull/2548#issuecomment-463091333 @billpoole-mi No there wont be any special message. The intent here is for apps where you want evenly

[GitHub] michaelandrepearce edited a comment on issue #2548: ARTEMIS-2118 Enhanced Message Groups Support

michaelandrepearce edited a comment on issue #2548: ARTEMIS-2118 Enhanced Message Groups Support URL: https://github.com/apache/activemq-artemis/pull/2548#issuecomment-463091333 @billpoole-mi No there wont be any special message. The intent here is for apps where you want evenly

[GitHub] billpoole-mi commented on issue #2548: ARTEMIS-2118 Enhanced Message Groups Support

billpoole-mi commented on issue #2548: ARTEMIS-2118 Enhanced Message Groups Support URL: https://github.com/apache/activemq-artemis/pull/2548#issuecomment-463025385 I have a couple of questions regarding the "support rebalancing groups when a consumer is added" aspect of this change:

[GitHub] michaelandrepearce edited a comment on issue #2548: ARTEMIS-2118 Enhanced Message Groups Support

michaelandrepearce edited a comment on issue #2548: ARTEMIS-2118 Enhanced Message Groups Support URL: https://github.com/apache/activemq-artemis/pull/2548#issuecomment-463091333 @billpoole-mi No there wont be any special message. The intent here is for apps where you want evenly

[GitHub] michaelandrepearce edited a comment on issue #2548: ARTEMIS-2118 Enhanced Message Groups Support

michaelandrepearce edited a comment on issue #2548: ARTEMIS-2118 Enhanced Message Groups Support URL: https://github.com/apache/activemq-artemis/pull/2548#issuecomment-463091333 @billpoole-mi No there wont be any special message. The intent here is for apps where you want evenly

[GitHub] billpoole-mi commented on issue #2548: ARTEMIS-2118 Enhanced Message Groups Support

billpoole-mi commented on issue #2548: ARTEMIS-2118 Enhanced Message Groups Support URL: https://github.com/apache/activemq-artemis/pull/2548#issuecomment-463093142 There may be a workable workflow for transferring ownership of a message group, where that workflow is cooperation between

[GitHub] billpoole-mi edited a comment on issue #2548: ARTEMIS-2118 Enhanced Message Groups Support

billpoole-mi edited a comment on issue #2548: ARTEMIS-2118 Enhanced Message Groups Support URL: https://github.com/apache/activemq-artemis/pull/2548#issuecomment-463093142 There may be a workable workflow for transferring ownership of a message group, where that workflow is a cooperation

[GitHub] michaelandrepearce edited a comment on issue #2548: ARTEMIS-2118 Enhanced Message Groups Support

michaelandrepearce edited a comment on issue #2548: ARTEMIS-2118 Enhanced Message Groups Support URL: https://github.com/apache/activemq-artemis/pull/2548#issuecomment-463093738 @billpoole-mi as i said, if/when this merges, you're more than welcome to contribute further enhancements you

[GitHub] billpoole-mi commented on issue #2548: ARTEMIS-2118 Enhanced Message Groups Support

billpoole-mi commented on issue #2548: ARTEMIS-2118 Enhanced Message Groups Support URL: https://github.com/apache/activemq-artemis/pull/2548#issuecomment-463094268 @michaelandrepearce no worries. I really appreciate all the work you guys are doing and just wanted to check whether

[GitHub] michaelandrepearce commented on issue #2548: ARTEMIS-2118 Enhanced Message Groups Support

michaelandrepearce commented on issue #2548: ARTEMIS-2118 Enhanced Message Groups Support URL: https://github.com/apache/activemq-artemis/pull/2548#issuecomment-463093738 @billpoole-mi as i said, if/when this merges, you're more than welcome to contribute further enhancements you want.

[GitHub] PawelJ-PL commented on issue #2191: ARTEMIS-1987 - Add consumer window size to AddressSettings

PawelJ-PL commented on issue #2191: ARTEMIS-1987 - Add consumer window size to AddressSettings URL: https://github.com/apache/activemq-artemis/pull/2191#issuecomment-463120937 Hi, Do You know, when the feature will be included in the Artemis release? It's present on master, but is

[GitHub] michaelandrepearce commented on issue #2548: ARTEMIS-2118 Enhanced Message Groups Support

michaelandrepearce commented on issue #2548: ARTEMIS-2118 Enhanced Message Groups Support URL: https://github.com/apache/activemq-artemis/pull/2548#issuecomment-463095530 So yes i think if you find a way to elegantly achieve that without a performance impact i personally would be open to

[GitHub] billpoole-mi commented on issue #2548: ARTEMIS-2118 Enhanced Message Groups Support

billpoole-mi commented on issue #2548: ARTEMIS-2118 Enhanced Message Groups Support URL: https://github.com/apache/activemq-artemis/pull/2548#issuecomment-463096446 Okay great! You are correct regarding a header for when a group is assigned to a consumer. That's the

[GitHub] onlyMIT commented on issue #2528: ARTEMIS-2226 last consumer connection should close the previous consu…

onlyMIT commented on issue #2528: ARTEMIS-2226 last consumer connection should close the previous consu… URL: https://github.com/apache/activemq-artemis/pull/2528#issuecomment-463157879 Add java doc This is an automated

[GitHub] michaelandrepearce commented on a change in pull request #2528: ARTEMIS-2226 last consumer connection should close the previous consu…

michaelandrepearce commented on a change in pull request #2528: ARTEMIS-2226 last consumer connection should close the previous consu… URL: https://github.com/apache/activemq-artemis/pull/2528#discussion_r255916966 ## File path:

[GitHub] michaelandrepearce commented on a change in pull request #2528: ARTEMIS-2226 last consumer connection should close the previous consu…

michaelandrepearce commented on a change in pull request #2528: ARTEMIS-2226 last consumer connection should close the previous consu… URL: https://github.com/apache/activemq-artemis/pull/2528#discussion_r255918235 ## File path:

[GitHub] michaelandrepearce commented on issue #2528: ARTEMIS-2226 last consumer connection should close the previous consu…

michaelandrepearce commented on issue #2528: ARTEMIS-2226 last consumer connection should close the previous consu… URL: https://github.com/apache/activemq-artemis/pull/2528#issuecomment-462731246 @onlyMIT looking better, i have some questions, which im sure all makes sense if explained,

[GitHub] michaelandrepearce commented on a change in pull request #2528: ARTEMIS-2226 last consumer connection should close the previous consu…

michaelandrepearce commented on a change in pull request #2528: ARTEMIS-2226 last consumer connection should close the previous consu… URL: https://github.com/apache/activemq-artemis/pull/2528#discussion_r255920956 ## File path:

[GitHub] michaelandrepearce commented on issue #2522: ARTEMIS-2239 Zero-copy NIO/MAPPED TimedBuffer

michaelandrepearce commented on issue #2522: ARTEMIS-2239 Zero-copy NIO/MAPPED TimedBuffer URL: https://github.com/apache/activemq-artemis/pull/2522#issuecomment-462732912 Looking promising. @franz1981 with all the changes youve been working on for journals, im not sure what the merge

[GitHub] michaelandrepearce commented on a change in pull request #2548: ARTEMIS-2118 Enhanced Message Groups Support

michaelandrepearce commented on a change in pull request #2548: ARTEMIS-2118 Enhanced Message Groups Support URL: https://github.com/apache/activemq-artemis/pull/2548#discussion_r256617634 ## File path:

[GitHub] michaelandrepearce commented on a change in pull request #2548: ARTEMIS-2118 Enhanced Message Groups Support

michaelandrepearce commented on a change in pull request #2548: ARTEMIS-2118 Enhanced Message Groups Support URL: https://github.com/apache/activemq-artemis/pull/2548#discussion_r256706799 ## File path:

[GitHub] asfgit closed pull request #2522: ARTEMIS-2239 Zero-copy NIO/MAPPED TimedBuffer

asfgit closed pull request #2522: ARTEMIS-2239 Zero-copy NIO/MAPPED TimedBuffer URL: https://github.com/apache/activemq-artemis/pull/2522 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] franz1981 commented on a change in pull request #2548: ARTEMIS-2118 Enhanced Message Groups Support

franz1981 commented on a change in pull request #2548: ARTEMIS-2118 Enhanced Message Groups Support URL: https://github.com/apache/activemq-artemis/pull/2548#discussion_r256700662 ## File path:

[GitHub] michaelandrepearce commented on a change in pull request #2548: ARTEMIS-2118 Enhanced Message Groups Support

michaelandrepearce commented on a change in pull request #2548: ARTEMIS-2118 Enhanced Message Groups Support URL: https://github.com/apache/activemq-artemis/pull/2548#discussion_r256617634 ## File path:

[GitHub] michaelandrepearce commented on a change in pull request #2548: ARTEMIS-2118 Enhanced Message Groups Support

michaelandrepearce commented on a change in pull request #2548: ARTEMIS-2118 Enhanced Message Groups Support URL: https://github.com/apache/activemq-artemis/pull/2548#discussion_r256623980 ## File path:

[GitHub] michaelandrepearce commented on issue #2548: ARTEMIS-2118 Enhanced Message Groups Support

michaelandrepearce commented on issue #2548: ARTEMIS-2118 Enhanced Message Groups Support URL: https://github.com/apache/activemq-artemis/pull/2548#issuecomment-463423401 @franz1981 as noted i found Netty has an int primitive hashmap implementation using open addressing

[GitHub] michaelandrepearce edited a comment on issue #2548: ARTEMIS-2118 Enhanced Message Groups Support

michaelandrepearce edited a comment on issue #2548: ARTEMIS-2118 Enhanced Message Groups Support URL: https://github.com/apache/activemq-artemis/pull/2548#issuecomment-463423401 @franz1981 as noted i found Netty has an int primitive hashmap implementation using open addressing

[GitHub] franz1981 commented on a change in pull request #2548: ARTEMIS-2118 Enhanced Message Groups Support

franz1981 commented on a change in pull request #2548: ARTEMIS-2118 Enhanced Message Groups Support URL: https://github.com/apache/activemq-artemis/pull/2548#discussion_r256700265 ## File path:

[GitHub] michaelandrepearce commented on a change in pull request #2548: ARTEMIS-2118 Enhanced Message Groups Support

michaelandrepearce commented on a change in pull request #2548: ARTEMIS-2118 Enhanced Message Groups Support URL: https://github.com/apache/activemq-artemis/pull/2548#discussion_r256617515 ## File path:

[GitHub] michaelandrepearce commented on a change in pull request #2548: ARTEMIS-2118 Enhanced Message Groups Support

michaelandrepearce commented on a change in pull request #2548: ARTEMIS-2118 Enhanced Message Groups Support URL: https://github.com/apache/activemq-artemis/pull/2548#discussion_r256617634 ## File path:

[GitHub] coheigea opened a new pull request #345: Enable X-XSS-Protection + X-Content-Type-Options headers for the webc…

coheigea opened a new pull request #345: Enable X-XSS-Protection + X-Content-Type-Options headers for the webc… URL: https://github.com/apache/activemq/pull/345 …onsole. It's good security practice to set these two headers to make XSS attacks and content sniffing attacks harder.

[GitHub] clebertsuconic commented on issue #2191: ARTEMIS-1987 - Add consumer window size to AddressSettings

clebertsuconic commented on issue #2191: ARTEMIS-1987 - Add consumer window size to AddressSettings URL: https://github.com/apache/activemq-artemis/pull/2191#issuecomment-463391530 I’m planning a release soon. Perhaps you could try a snapshot.

[GitHub] franz1981 commented on a change in pull request #2548: ARTEMIS-2118 Enhanced Message Groups Support

franz1981 commented on a change in pull request #2548: ARTEMIS-2118 Enhanced Message Groups Support URL: https://github.com/apache/activemq-artemis/pull/2548#discussion_r256598278 ## File path:

[GitHub] franz1981 commented on a change in pull request #2548: ARTEMIS-2118 Enhanced Message Groups Support

franz1981 commented on a change in pull request #2548: ARTEMIS-2118 Enhanced Message Groups Support URL: https://github.com/apache/activemq-artemis/pull/2548#discussion_r256599873 ## File path:

[GitHub] franz1981 commented on a change in pull request #2548: ARTEMIS-2118 Enhanced Message Groups Support

franz1981 commented on a change in pull request #2548: ARTEMIS-2118 Enhanced Message Groups Support URL: https://github.com/apache/activemq-artemis/pull/2548#discussion_r256605066 ## File path:

[GitHub] PawelJ-PL commented on issue #2191: ARTEMIS-1987 - Add consumer window size to AddressSettings

PawelJ-PL commented on issue #2191: ARTEMIS-1987 - Add consumer window size to AddressSettings URL: https://github.com/apache/activemq-artemis/pull/2191#issuecomment-463385169 Thank You for clarification. I'm asking because we are going to try to replace ActiveMq with Artemis and

[GitHub] michaelandrepearce commented on a change in pull request #2548: ARTEMIS-2118 Enhanced Message Groups Support

michaelandrepearce commented on a change in pull request #2548: ARTEMIS-2118 Enhanced Message Groups Support URL: https://github.com/apache/activemq-artemis/pull/2548#discussion_r256706799 ## File path:

[GitHub] michaelandrepearce commented on a change in pull request #2548: ARTEMIS-2118 Enhanced Message Groups Support

michaelandrepearce commented on a change in pull request #2548: ARTEMIS-2118 Enhanced Message Groups Support URL: https://github.com/apache/activemq-artemis/pull/2548#discussion_r256706799 ## File path:

[GitHub] michaelandrepearce commented on a change in pull request #2548: ARTEMIS-2118 Enhanced Message Groups Support

michaelandrepearce commented on a change in pull request #2548: ARTEMIS-2118 Enhanced Message Groups Support URL: https://github.com/apache/activemq-artemis/pull/2548#discussion_r256738673 ## File path:

[GitHub] michaelandrepearce commented on a change in pull request #2548: ARTEMIS-2118 Enhanced Message Groups Support

michaelandrepearce commented on a change in pull request #2548: ARTEMIS-2118 Enhanced Message Groups Support URL: https://github.com/apache/activemq-artemis/pull/2548#discussion_r256706799 ## File path:

[GitHub] franz1981 commented on a change in pull request #2548: ARTEMIS-2118 Enhanced Message Groups Support

franz1981 commented on a change in pull request #2548: ARTEMIS-2118 Enhanced Message Groups Support URL: https://github.com/apache/activemq-artemis/pull/2548#discussion_r256728547 ## File path:

[GitHub] michaelandrepearce commented on a change in pull request #2548: ARTEMIS-2118 Enhanced Message Groups Support

michaelandrepearce commented on a change in pull request #2548: ARTEMIS-2118 Enhanced Message Groups Support URL: https://github.com/apache/activemq-artemis/pull/2548#discussion_r256739594 ## File path:

[GitHub] michaelandrepearce commented on a change in pull request #2548: ARTEMIS-2118 Enhanced Message Groups Support

michaelandrepearce commented on a change in pull request #2548: ARTEMIS-2118 Enhanced Message Groups Support URL: https://github.com/apache/activemq-artemis/pull/2548#discussion_r256739594 ## File path:

[GitHub] michaelandrepearce commented on a change in pull request #2548: ARTEMIS-2118 Enhanced Message Groups Support

michaelandrepearce commented on a change in pull request #2548: ARTEMIS-2118 Enhanced Message Groups Support URL: https://github.com/apache/activemq-artemis/pull/2548#discussion_r256739594 ## File path:

[GitHub] michaelandrepearce commented on a change in pull request #2548: ARTEMIS-2118 Enhanced Message Groups Support

michaelandrepearce commented on a change in pull request #2548: ARTEMIS-2118 Enhanced Message Groups Support URL: https://github.com/apache/activemq-artemis/pull/2548#discussion_r256706799 ## File path:

[GitHub] michaelandrepearce commented on a change in pull request #2548: ARTEMIS-2118 Enhanced Message Groups Support

michaelandrepearce commented on a change in pull request #2548: ARTEMIS-2118 Enhanced Message Groups Support URL: https://github.com/apache/activemq-artemis/pull/2548#discussion_r256706799 ## File path:

[GitHub] franz1981 commented on a change in pull request #2548: ARTEMIS-2118 Enhanced Message Groups Support

franz1981 commented on a change in pull request #2548: ARTEMIS-2118 Enhanced Message Groups Support URL: https://github.com/apache/activemq-artemis/pull/2548#discussion_r256741638 ## File path:

[GitHub] michaelandrepearce commented on a change in pull request #2548: ARTEMIS-2118 Enhanced Message Groups Support

michaelandrepearce commented on a change in pull request #2548: ARTEMIS-2118 Enhanced Message Groups Support URL: https://github.com/apache/activemq-artemis/pull/2548#discussion_r256745053 ## File path:

[GitHub] michaelandrepearce commented on a change in pull request #2548: ARTEMIS-2118 Enhanced Message Groups Support

michaelandrepearce commented on a change in pull request #2548: ARTEMIS-2118 Enhanced Message Groups Support URL: https://github.com/apache/activemq-artemis/pull/2548#discussion_r256745053 ## File path:

[GitHub] franz1981 commented on a change in pull request #2548: ARTEMIS-2118 Enhanced Message Groups Support

franz1981 commented on a change in pull request #2548: ARTEMIS-2118 Enhanced Message Groups Support URL: https://github.com/apache/activemq-artemis/pull/2548#discussion_r256741638 ## File path:

[GitHub] michaelandrepearce commented on a change in pull request #2548: ARTEMIS-2118 Enhanced Message Groups Support

michaelandrepearce commented on a change in pull request #2548: ARTEMIS-2118 Enhanced Message Groups Support URL: https://github.com/apache/activemq-artemis/pull/2548#discussion_r256745053 ## File path:

[GitHub] michaelandrepearce commented on a change in pull request #2548: ARTEMIS-2118 Enhanced Message Groups Support

michaelandrepearce commented on a change in pull request #2548: ARTEMIS-2118 Enhanced Message Groups Support URL: https://github.com/apache/activemq-artemis/pull/2548#discussion_r256745053 ## File path:

[GitHub] franz1981 commented on a change in pull request #2548: ARTEMIS-2118 Enhanced Message Groups Support

franz1981 commented on a change in pull request #2548: ARTEMIS-2118 Enhanced Message Groups Support URL: https://github.com/apache/activemq-artemis/pull/2548#discussion_r256728127 ## File path:

[GitHub] jdanekrh opened a new pull request #2550: NO-JIRA Fix a "Computation of average could overflow" SpotBugs warning

jdanekrh opened a new pull request #2550: NO-JIRA Fix a "Computation of average could overflow" SpotBugs warning URL: https://github.com/apache/activemq-artemis/pull/2550

[GitHub] michaelandrepearce commented on issue #2550: NO-JIRA Fix a "Computation of average could overflow" SpotBugs warning

michaelandrepearce commented on issue #2550: NO-JIRA Fix a "Computation of average could overflow" SpotBugs warning URL: https://github.com/apache/activemq-artemis/pull/2550#issuecomment-463616792 Great find. Thanks. Will merge

[GitHub] michaelandrepearce edited a comment on issue #2533: ARTEMIS-2244 checkDepage method placed outside CRITICAL_DELIVER avoid critical analyzer timeout

michaelandrepearce edited a comment on issue #2533: ARTEMIS-2244 checkDepage method placed outside CRITICAL_DELIVER avoid critical analyzer timeout URL: https://github.com/apache/activemq-artemis/pull/2533#issuecomment-463614378 To me it seems we shouldnt have change critical analyslzer at

[GitHub] michaelandrepearce commented on issue #2533: ARTEMIS-2244 checkDepage method placed outside CRITICAL_DELIVER avoid critical analyzer timeout

michaelandrepearce commented on issue #2533: ARTEMIS-2244 checkDepage method placed outside CRITICAL_DELIVER avoid critical analyzer timeout URL: https://github.com/apache/activemq-artemis/pull/2533#issuecomment-463614378 To me it seems we shouldnt have change critical analyslzer at all.

[GitHub] asfgit merged pull request #2550: NO-JIRA Fix a "Computation of average could overflow" SpotBugs warning

asfgit merged pull request #2550: NO-JIRA Fix a "Computation of average could overflow" SpotBugs warning URL: https://github.com/apache/activemq-artemis/pull/2550 This is an automated message from the Apache Git Service. To

[GitHub] clebertsuconic commented on issue #2533: ARTEMIS-2244 checkDepage method placed outside CRITICAL_DELIVER avoid critical analyzer timeout

clebertsuconic commented on issue #2533: ARTEMIS-2244 checkDepage method placed outside CRITICAL_DELIVER avoid critical analyzer timeout URL: https://github.com/apache/activemq-artemis/pull/2533#issuecomment-463621345 I have amended the change before merging (extra commit) Basically

[GitHub] michaelandrepearce commented on issue #2548: ARTEMIS-2118 Enhanced Message Groups Support

michaelandrepearce commented on issue #2548: ARTEMIS-2118 Enhanced Message Groups Support URL: https://github.com/apache/activemq-artemis/pull/2548#issuecomment-463640868 @franz1981 Hopefully fixed the checkstyle, netty used 4 space tabs we use 3, lol, i feel like an episode of

[GitHub] michaelandrepearce commented on a change in pull request #2467: ARTEMIS-2205 Performance improvements on AMQP and other parts

michaelandrepearce commented on a change in pull request #2467: ARTEMIS-2205 Performance improvements on AMQP and other parts URL: https://github.com/apache/activemq-artemis/pull/2467#discussion_r256896902 ## File path:

<    3   4   5   6   7   8   9   10   11   12   >