[GitHub] [incubator-annotator-website] dependabot[bot] opened a new pull request, #32: Bump luxon from 1.25.0 to 1.28.1

dependabot[bot] opened a new pull request, #32: URL: https://github.com/apache/incubator-annotator-website/pull/32 Bumps [luxon](https://github.com/moment/luxon) from 1.25.0 to 1.28.1. Changelog Sourced from https://github.com/moment/luxon/blob/master/CHANGELOG.md";>luxon's changel

[GitHub] [incubator-annotator] Treora commented on issue #131: Don’t find/highlight text inside elements (or other invalid parents for a ).

Treora commented on issue #131: URL: https://github.com/apache/incubator-annotator/issues/131#issuecomment-1367306132 Yet another issue in this theme: table layout can be messed up by the added `` elements. -- This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [incubator-annotator] Treora commented on issue #142: @apache-annotator/dom not updated on NPM

Treora commented on issue #142: URL: https://github.com/apache/incubator-annotator/issues/142#issuecomment-1367296047 Hi! The numbered versions on npm indeed lag far behind the main branch. As an incubating Apache project, each official release needs to be verified and upvoted by th

[GitHub] [incubator-annotator] pkspyder007 commented on issue #142: @apache-annotator/dom not updated on NPM

pkspyder007 commented on issue #142: URL: https://github.com/apache/incubator-annotator/issues/142#issuecomment-1354112845 I'll be happy to work on the project to fix stuff and learn more about it. -- This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [incubator-annotator] pkspyder007 opened a new issue, #142: @apache-annotator/dom not updated on NPM

pkspyder007 opened a new issue, #142: URL: https://github.com/apache/incubator-annotator/issues/142 The current version of @apache-annotator/dom v0.2.0 still uses optimal-select which was fixed in PR #117 Is this project still active or one using it should seek forking it or alternative

[GitHub] [incubator-annotator] dependabot[bot] opened a new pull request, #141: Bump express from 4.17.1 to 4.18.2

dependabot[bot] opened a new pull request, #141: URL: https://github.com/apache/incubator-annotator/pull/141 Bumps [express](https://github.com/expressjs/express) from 4.17.1 to 4.18.2. Release notes Sourced from https://github.com/expressjs/express/releases";>express's releases.

[GitHub] [incubator-annotator] dependabot[bot] opened a new pull request, #140: Bump qs from 6.5.2 to 6.5.3

dependabot[bot] opened a new pull request, #140: URL: https://github.com/apache/incubator-annotator/pull/140 Bumps [qs](https://github.com/ljharb/qs) from 6.5.2 to 6.5.3. Changelog Sourced from https://github.com/ljharb/qs/blob/main/CHANGELOG.md";>qs's changelog. 6.5.3

[GitHub] [incubator-annotator] dependabot[bot] opened a new pull request, #139: Bump decode-uri-component from 0.2.0 to 0.2.2

dependabot[bot] opened a new pull request, #139: URL: https://github.com/apache/incubator-annotator/pull/139 Bumps [decode-uri-component](https://github.com/SamVerschueren/decode-uri-component) from 0.2.0 to 0.2.2. Release notes Sourced from https://github.com/SamVerschueren/decod

[GitHub] [incubator-annotator] Treora commented on issue #133: Data Model validation as API

Treora commented on issue #133: URL: https://github.com/apache/incubator-annotator/issues/133#issuecomment-1325723751 Generally “since the code is already there” seems a weak argument to do more work on that code (if it is of little use, it might better be dropped altogether). In this case

[GitHub] [incubator-annotator] Treora opened a new pull request, #138: Add convenience matcher functions to dom package

Treora opened a new pull request, #138: URL: https://github.com/apache/incubator-annotator/pull/138 We have discussed similar APIs before, to make the common use cases easier. - `createAnySelectorMatcher` mimics the signature of existing matcher creators, but works on any selector typ

[GitHub] [incubator-annotator] Treora opened a new pull request, #137: Create new package @apache-annotator/annotation

Treora opened a new pull request, #137: URL: https://github.com/apache/incubator-annotator/pull/137 Types & utility functions for annotations as a whole. With code imported from . Unfortunately, I keep getting an error when r

[GitHub] [incubator-annotator] Treora opened a new pull request, #136: Tweak types

Treora opened a new pull request, #136: URL: https://github.com/apache/incubator-annotator/pull/136 Based on experience in Web Annotation Discovery webextension. See [here](https://code.treora.com/gerben/web-annotation-discovery-webextension/src/commit/52293bb25d72b1cd4c2ee18ae385acc7bd38f68

[GitHub] [incubator-annotator] Treora opened a new pull request, #135: Turn highlightText into a class TextHighlight

Treora opened a new pull request, #135: URL: https://github.com/apache/incubator-annotator/pull/135 Currently, `highlightText` returns a function that removes the highlight again. In some cases, one may want more possibilities, e.g. attaching a hover event listener to the highlight elements

[GitHub] [incubator-annotator] PermissionError opened a new pull request, #134: Update package.json

PermissionError opened a new pull request, #134: URL: https://github.com/apache/incubator-annotator/pull/134 As mentioned in #114 the Windows build failures can also be attributed to the babel-esm-register plugin. Upstream has accepted my fix, so this bumps Annotator's dependency version to

[GitHub] [incubator-annotator] PermissionError opened a new issue, #133: Data Model validation as API

PermissionError opened a new issue, #133: URL: https://github.com/apache/incubator-annotator/issues/133 Currently `yarn validate --url ` can be used to validate JSON documents against the Web Annotation Data Model schema. This is achieved through executing `test/data-model.test.ts`. I'm won

[GitHub] [incubator-annotator-website] PermissionError commented on pull request #31: Address Privacy issues

PermissionError commented on PR #31: URL: https://github.com/apache/incubator-annotator-website/pull/31#issuecomment-1316797623 Hi @Treora, thanks for the review. I have removed updates to `content/` so that you can build it separately. Apologies for the mess, I thought this would be a qui

[GitHub] [incubator-annotator] Treora commented on issue #70: Web Annotation Protocol Server

Treora commented on issue #70: URL: https://github.com/apache/incubator-annotator/issues/70#issuecomment-1316785124 I recently looked what’s around, and found this [simple-annotation-server](https://github.com/jankaszel/simple-annotation-server) look possibily useful for a start, by virtue

[GitHub] [incubator-annotator-website] Treora commented on pull request #31: Address Privacy issues

Treora commented on PR #31: URL: https://github.com/apache/incubator-annotator-website/pull/31#issuecomment-1316745969 Thank you! Indeed the loading of third-party resources should never have happened, I somehow thought that had already been fixed long ago. We could add a CSP in a `` tag t

[GitHub] [incubator-annotator] Treora commented on issue #114: Can't build on windows

Treora commented on issue #114: URL: https://github.com/apache/incubator-annotator/issues/114#issuecomment-1316711927 Thanks for investigating! Once (if) the remaining issue is fixed upstream be welcome to make a PR with the dependency upgrade. -- This is an automated message from the Ap

[GitHub] [incubator-annotator] Treora closed issue #114: Can't build on windows

Treora closed issue #114: Can't build on windows URL: https://github.com/apache/incubator-annotator/issues/114 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e

[GitHub] [incubator-annotator] Treora merged pull request #132: Fix omission of shx in build script

Treora merged PR #132: URL: https://github.com/apache/incubator-annotator/pull/132 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@annot

[GitHub] [incubator-annotator] Treora commented on pull request #132: Fix omission of shx in build script

Treora commented on PR #132: URL: https://github.com/apache/incubator-annotator/pull/132#issuecomment-1316708378 Looks good, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [incubator-annotator-website] PermissionError opened a new pull request, #31: Address Privacy issues

PermissionError opened a new pull request, #31: URL: https://github.com/apache/incubator-annotator-website/pull/31 Per https://whimsy.apache.org/pods/project/annotator and https://privacy.apache.org/faq/committers.html, the Privacy Policy link in the footer is broken and external CDN resour

[GitHub] [incubator-annotator] PermissionError commented on issue #114: Can't build on windows

PermissionError commented on issue #114: URL: https://github.com/apache/incubator-annotator/issues/114#issuecomment-1314651433 I've submitted a potential fix to the ESM loader at giltayar/babel-register-esm#3. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-annotator] PermissionError commented on issue #114: Can't build on windows

PermissionError commented on issue #114: URL: https://github.com/apache/incubator-annotator/issues/114#issuecomment-1314581741 Hi, I have submitted #132 to solve ` 'cp' is not recognized as an internal or external command,`. However, on my Windows system, I still get the following er

[GitHub] [incubator-annotator] PermissionError opened a new pull request, #132: Fix omission of shx in build script

PermissionError opened a new pull request, #132: URL: https://github.com/apache/incubator-annotator/pull/132 This simply adds `shx` before `cp` in the `build:misc` script so that the build failure for Windows is resolved. Fixes #114 -- This is an automated message from the Apache G

[GitHub] [incubator-annotator-website] dependabot[bot] opened a new pull request, #30: Bump minimatch from 3.0.4 to 3.1.2

dependabot[bot] opened a new pull request, #30: URL: https://github.com/apache/incubator-annotator-website/pull/30 Bumps [minimatch](https://github.com/isaacs/minimatch) from 3.0.4 to 3.1.2. Commits https://github.com/isaacs/minimatch/commit/699c459443a6bd98f5b28197978f76e7f7146

[GitHub] [incubator-annotator] Treora commented on pull request #130: Improve performance for large documents with many annotations

Treora commented on PR #130: URL: https://github.com/apache/incubator-annotator/pull/130#issuecomment-1248026159 Sorry for the silence, and thanks a lot for the contribution! Glad to hear this library is useful to you; we’d love to hear in what way it helps you, for what purpose, and how i

[GitHub] [incubator-annotator] raphael10-collab closed issue #128: I'm not getting the text position

raphael10-collab closed issue #128: I'm not getting the text position URL: https://github.com/apache/incubator-annotator/issues/128 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

[GitHub] [incubator-annotator] Treora commented on issue #128: I'm not getting the text position

Treora commented on issue #128: URL: https://github.com/apache/incubator-annotator/issues/128#issuecomment-1248013365 A quick response, as I (nor others, it seems) get around to look further at your issue. From your description it’s not clear to me what you mean. If you mean to create a Te

[GitHub] [incubator-annotator] reckart commented on issue #131: Don’t find/highlight text inside elements (or other invalid parents for a ).

reckart commented on issue #131: URL: https://github.com/apache/incubator-annotator/issues/131#issuecomment-1247988367 Another case could be mathml sections. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [incubator-annotator] Treora opened a new issue, #131: Don’t find/highlight text inside elements (or other invalid parents for a ).

Treora opened a new issue, #131: URL: https://github.com/apache/incubator-annotator/issues/131 Highlighting (using `` elements, as we do) text inside a `` will make that text disappear. The higlighter should either fail or modify the given range if parts of it are within a textarea.

[GitHub] [incubator-annotator] raphael10-collab commented on issue #129: For some webpages when highlighting a text, the text is splitted

raphael10-collab commented on issue #129: URL: https://github.com/apache/incubator-annotator/issues/129#issuecomment-1237855931 @Treora Interesting. Thank you very much -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [incubator-annotator] Treora commented on issue #129: For some webpages when highlighting a text, the text is splitted

Treora commented on issue #129: URL: https://github.com/apache/incubator-annotator/issues/129#issuecomment-1237844279 A quick look at that website ([link](https://intelligencequarterly.com/energy/crude-oil-inventories-week-ending-19-august-2022/)) reveals it has a css rule for `` element:

[GitHub] [incubator-annotator] vrish88 opened a new pull request, #130: Improve performance for large documents with many annotations

vrish88 opened a new pull request, #130: URL: https://github.com/apache/incubator-annotator/pull/130 Hello and thank you for this wonderful project. It's provided some excellent shoulders to stand on. ### Context I'm extracting footnotes embedded in markdown and converting them an

[GitHub] [incubator-annotator] reckart commented on issue #129: For some webpages when highlighting a text, the text is splitted

reckart commented on issue #129: URL: https://github.com/apache/incubator-annotator/issues/129#issuecomment-1229518195 Try looking at the HTML code of the page at that location after you have selected the word - what does it look like? Does it make sense? -- This is an automated message

[GitHub] [incubator-annotator] raphael10-collab opened a new issue, #129: For some webpages when highlighting a text, the text is splitted

raphael10-collab opened a new issue, #129: URL: https://github.com/apache/incubator-annotator/issues/129 For some webpages I'm getting this strange behavior :  fo

[GitHub] [incubator-annotator] raphael10-collab opened a new issue, #128: I'm not getting the text position

raphael10-collab opened a new issue, #128: URL: https://github.com/apache/incubator-annotator/issues/128 The text is highlighted but I do not get the text position, needed for further annotating ![image](https://user-images.githubusercontent.com/70313067/187079466-224a78d1-8b7c-4787-

[GitHub] [incubator-annotator] LibertyNLP commented on issue #125: Fragment selector for PDFs + PDF.js integration

LibertyNLP commented on issue #125: URL: https://github.com/apache/incubator-annotator/issues/125#issuecomment-1193104892 Hi , I wish my work can help you. I have figured out a solution of pdf.js annotation, use only pdf.js dist, and it is very easy to import into your project. De

[GitHub] [incubator-annotator] dependabot[bot] opened a new pull request, #127: Bump terser from 4.3.4 to 4.8.1

dependabot[bot] opened a new pull request, #127: URL: https://github.com/apache/incubator-annotator/pull/127 Bumps [terser](https://github.com/terser/terser) from 4.3.4 to 4.8.1. Changelog Sourced from https://github.com/terser/terser/blob/master/CHANGELOG.md";>terser's changelog.

[GitHub] [incubator-annotator] dependabot[bot] opened a new pull request, #126: Bump jsdom from 16.2.2 to 16.5.0

dependabot[bot] opened a new pull request, #126: URL: https://github.com/apache/incubator-annotator/pull/126 Bumps [jsdom](https://github.com/jsdom/jsdom) from 16.2.2 to 16.5.0. Release notes Sourced from https://github.com/jsdom/jsdom/releases";>jsdom's releases. Version 16.

[GitHub] [incubator-annotator] jaime-rivas opened a new issue, #125: Fragment selector for PDFs + PDF.js integration

jaime-rivas opened a new issue, #125: URL: https://github.com/apache/incubator-annotator/issues/125 Hi everyone, I recently found out that PDF.js is adding full annotation editing support to the library, which can be tracked here: [PDF.js editing](https://github.com/mozilla/pdf.js/pr

[GitHub] [incubator-annotator] dependabot[bot] opened a new pull request, #124: Bump eventsource from 1.0.7 to 1.1.1

dependabot[bot] opened a new pull request, #124: URL: https://github.com/apache/incubator-annotator/pull/124 Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.0.7 to 1.1.1. Changelog Sourced from https://github.com/EventSource/eventsource/blob/master/HISTORY.md

[GitHub] [incubator-annotator] tilgovi merged pull request #121: Bump node-fetch from 2.6.0 to 2.6.7

tilgovi merged PR #121: URL: https://github.com/apache/incubator-annotator/pull/121 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@anno

[GitHub] [incubator-annotator] tilgovi merged pull request #122: Bump trim-off-newlines from 1.0.1 to 1.0.3

tilgovi merged PR #122: URL: https://github.com/apache/incubator-annotator/pull/122 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@anno

[GitHub] [incubator-annotator] tilgovi merged pull request #123: Bump async from 2.6.3 to 2.6.4

tilgovi merged PR #123: URL: https://github.com/apache/incubator-annotator/pull/123 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@anno

[GitHub] [incubator-annotator] dependabot[bot] opened a new pull request, #123: Bump async from 2.6.3 to 2.6.4

dependabot[bot] opened a new pull request, #123: URL: https://github.com/apache/incubator-annotator/pull/123 Bumps [async](https://github.com/caolan/async) from 2.6.3 to 2.6.4. Changelog Sourced from https://github.com/caolan/async/blob/v2.6.4/CHANGELOG.md";>async's changelog.

[GitHub] [incubator-annotator] dependabot[bot] opened a new pull request, #122: Bump trim-off-newlines from 1.0.1 to 1.0.3

dependabot[bot] opened a new pull request, #122: URL: https://github.com/apache/incubator-annotator/pull/122 Bumps [trim-off-newlines](https://github.com/stevemao/trim-off-newlines) from 1.0.1 to 1.0.3. Commits https://github.com/stevemao/trim-off-newlines/commit/c3b28d395cf249

[GitHub] [incubator-annotator] dependabot[bot] opened a new pull request, #121: Bump node-fetch from 2.6.0 to 2.6.7

dependabot[bot] opened a new pull request, #121: URL: https://github.com/apache/incubator-annotator/pull/121 Bumps [node-fetch](https://github.com/node-fetch/node-fetch) from 2.6.0 to 2.6.7. Release notes Sourced from https://github.com/node-fetch/node-fetch/releases";>node-fetch's

[GitHub] [incubator-annotator] tilgovi commented on pull request #116: Add scripts to (semi)automate release steps

tilgovi commented on PR #116: URL: https://github.com/apache/incubator-annotator/pull/116#issuecomment-1103382982 As for the error, something must be wrong with the permissions on the git directory that gets created. I am thinking that initializing a git repository inside the archive

[GitHub] [incubator-annotator] tilgovi commented on pull request #116: Add scripts to (semi)automate release steps

tilgovi commented on PR #116: URL: https://github.com/apache/incubator-annotator/pull/116#issuecomment-1103381492 @Treora I would be fine to drop the RAT steps. It feels strange to download a jar and leave it on the machine. Unless we download it to the current directory. -- This is an

[GitHub] [incubator-annotator] jaime-rivas commented on issue #118: Monthly calls

jaime-rivas commented on issue #118: URL: https://github.com/apache/incubator-annotator/issues/118#issuecomment-1101919490 We would love to participate in a guest Q&A! Please let us know for the next call and @xavicn @F-Fontinha and I would be very happy to share our use cases and experien

[GitHub] [incubator-annotator-website] dependabot[bot] opened a new pull request, #29: Bump minimist from 1.2.5 to 1.2.6

dependabot[bot] opened a new pull request, #29: URL: https://github.com/apache/incubator-annotator-website/pull/29 Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6. Commits https://github.com/substack/minimist/commit/7efb22a518b53b06f5b02a1038a88bd6290c

[GitHub] [incubator-annotator] BigBlueHat commented on issue #118: Monthly calls

BigBlueHat commented on issue #118: URL: https://github.com/apache/incubator-annotator/issues/118#issuecomment-1093228436 > @BigBlueHat you mentioned that you "miss the "connection" with app builders". We've been using the annotatorjs library but would be very happy to integrate apache ann

[GitHub] [incubator-annotator] xavicn commented on issue #118: Monthly calls

xavicn commented on issue #118: URL: https://github.com/apache/incubator-annotator/issues/118#issuecomment-1092831505 Hello @Treora, nice to meet you! I'm Xavi from Synergy, I will also join the meeting along with my teammate @F-Fontinha. -- This is an automated message from the Apache G

[GitHub] [incubator-annotator] jaime-rivas commented on issue #118: Monthly calls

jaime-rivas commented on issue #118: URL: https://github.com/apache/incubator-annotator/issues/118#issuecomment-1092822136 Thank you @Treora! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [incubator-annotator] Treora commented on issue #118: Monthly calls

Treora commented on issue #118: URL: https://github.com/apache/incubator-annotator/issues/118#issuecomment-1091971113 Hi Jaime, sorry for the silence from our side. I hope I can answer on behalf of the other two too. :) As for calls, you may have just noticed it on the mailing list:

[GitHub] [incubator-annotator] Treora commented on pull request #116: Add scripts to (semi)automate release steps

Treora commented on pull request #116: URL: https://github.com/apache/incubator-annotator/pull/116#issuecomment-1083812835 I added a commit that downloads RAT, removes comments, removes the sleep pauses too. But I get an error when running this, which looks unrelated to the current change

[GitHub] [incubator-annotator] reckart commented on issue #120: Accumulation of mark elements because text nodes not cleaned up

reckart commented on issue #120: URL: https://github.com/apache/incubator-annotator/issues/120#issuecomment-1083618408 Also consider cases like `foobarblah` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [incubator-annotator] reckart commented on issue #120: Accumulation of mark elements because text nodes not cleaned up

reckart commented on issue #120: URL: https://github.com/apache/incubator-annotator/issues/120#issuecomment-1083617104 It seems to happen in particular with overlapping/nesting highlights like e.g. `foo bar` - the more overlap/nesting, the more it seems to happen. -- This is an automat

[GitHub] [incubator-annotator] Treora edited a comment on issue #120: Accumulation of mark elements because text nodes not cleaned up

Treora edited a comment on issue #120: URL: https://github.com/apache/incubator-annotator/issues/120#issuecomment-108361 In which situation are empty text nodes added? That sounds like a potential bug. Only the start and/or end node should be splitted, and only if it is partially sele

[GitHub] [incubator-annotator] Treora commented on issue #120: Accumulation of mark elements because text nodes not cleaned up

Treora commented on issue #120: URL: https://github.com/apache/incubator-annotator/issues/120#issuecomment-108361 In which situation are empty text nodes added? That sounds like a potential bug. Only the start and/or end node should be splitted, and only if it is partially selected by

[GitHub] [incubator-annotator] reckart opened a new issue #120: Accumulation of mark elements because text nodes not cleaned up

reckart opened a new issue #120: URL: https://github.com/apache/incubator-annotator/issues/120 It appears that when adding/removing a highlight, empty text nodes may be added to the DOM. This again may cause subsequent highlighting operations to add additional highlight elements around the

[GitHub] [incubator-annotator] jaime-rivas opened a new issue #118: Monthly calls

jaime-rivas opened a new issue #118: URL: https://github.com/apache/incubator-annotator/issues/118 Hi everyone, First of all, thanks for the effort and work to put together this project. We'd like to join the community and hopefully help to move this forward. @tilgovi I saw i

[GitHub] [incubator-annotator] tilgovi merged pull request #117: Run tests as ECMAScript modules

tilgovi merged pull request #117: URL: https://github.com/apache/incubator-annotator/pull/117 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-

[GitHub] [incubator-annotator] tilgovi closed issue #113: Can't use after installing via npm (without webpack or similar)

tilgovi closed issue #113: URL: https://github.com/apache/incubator-annotator/issues/113 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsub

[GitHub] [incubator-annotator] tilgovi commented on a change in pull request #116: Add scripts to (semi)automate release steps

tilgovi commented on a change in pull request #116: URL: https://github.com/apache/incubator-annotator/pull/116#discussion_r747279515 ## File path: scripts/verify-rc.sh ## @@ -0,0 +1,52 @@ +set -e + +#VERSION=0.2.0 Review comment: We can remove these comments. ###

[GitHub] [incubator-annotator] tilgovi commented on a change in pull request #117: Run tests as ECMAScript modules

tilgovi commented on a change in pull request #117: URL: https://github.com/apache/incubator-annotator/pull/117#discussion_r747278040 ## File path: babel.config.js ## @@ -53,8 +53,7 @@ module.exports = (api) => { ...(DEV || TEST ? { alias: { -

[GitHub] [incubator-annotator] tilgovi commented on a change in pull request #117: Run tests as ECMAScript modules

tilgovi commented on a change in pull request #117: URL: https://github.com/apache/incubator-annotator/pull/117#discussion_r747276780 ## File path: babel.config.js ## @@ -47,14 +50,25 @@ module.exports = (api) => { // Options for the module-resolver plugin. // Used for r

[GitHub] [incubator-annotator] Treora commented on a change in pull request #117: Run tests as ECMAScript modules

Treora commented on a change in pull request #117: URL: https://github.com/apache/incubator-annotator/pull/117#discussion_r744517548 ## File path: babel.config.js ## @@ -47,14 +50,25 @@ module.exports = (api) => { // Options for the module-resolver plugin. // Used for re

[GitHub] [incubator-annotator] Treora commented on a change in pull request #117: Run tests as ECMAScript modules

Treora commented on a change in pull request #117: URL: https://github.com/apache/incubator-annotator/pull/117#discussion_r744496151 ## File path: babel.config.js ## @@ -53,8 +53,7 @@ module.exports = (api) => { ...(DEV || TEST ? { alias: { -

[GitHub] [incubator-annotator] tilgovi commented on a change in pull request #117: Run tests as ECMAScript modules

tilgovi commented on a change in pull request #117: URL: https://github.com/apache/incubator-annotator/pull/117#discussion_r744392086 ## File path: packages/dom/src/css.ts ## @@ -20,10 +20,10 @@ * under the License. */ -import optimalSelect from 'optimal-select'; +import

[GitHub] [incubator-annotator] tilgovi commented on a change in pull request #117: Run tests as ECMAScript modules

tilgovi commented on a change in pull request #117: URL: https://github.com/apache/incubator-annotator/pull/117#discussion_r744361773 ## File path: packages/dom/src/css.ts ## @@ -20,10 +20,10 @@ * under the License. */ -import optimalSelect from 'optimal-select'; +import

[GitHub] [incubator-annotator] Treora commented on pull request #116: Add scripts to (semi)automate release steps

Treora commented on pull request #116: URL: https://github.com/apache/incubator-annotator/pull/116#issuecomment-962694567 > This is a great start! I'll check out the branch locally, see if there are any tweaks to make, and maybe try to push up changes to make the verify command interactiv

[GitHub] [incubator-annotator] Treora commented on a change in pull request #117: Run tests as ECMAScript modules

Treora commented on a change in pull request #117: URL: https://github.com/apache/incubator-annotator/pull/117#discussion_r744326905 ## File path: packages/dom/src/css.ts ## @@ -20,10 +20,10 @@ * under the License. */ -import optimalSelect from 'optimal-select'; +import

[GitHub] [incubator-annotator] tilgovi opened a new pull request #117: Run tests as ECMAScript modules

tilgovi opened a new pull request #117: URL: https://github.com/apache/incubator-annotator/pull/117 Upgrade Mocha to v9, replace chai with the built-in assert module, replace optimal-select with @medv/finder, replace nyc with c8, and configure the test suite to run without transforming mod

[GitHub] [incubator-annotator] tilgovi commented on pull request #116: Add scripts to (semi)automate release steps

tilgovi commented on pull request #116: URL: https://github.com/apache/incubator-annotator/pull/116#issuecomment-945211415 This is a great start! I'll check out the branch locally, see if there are any tweaks to make, and maybe try to push up changes to make the verify command interactive

[GitHub] [incubator-annotator] Treora opened a new pull request #116: Add scripts to (semi)automate release steps

Treora opened a new pull request #116: URL: https://github.com/apache/incubator-annotator/pull/116 These are roughly the commands from our [Creating a Release](https://github.com/apache/incubator-annotator/wiki/Creating-a-Release) and [Testing a Source Release](https://github.com/apache/i

[GitHub] [incubator-annotator] tilgovi commented on issue #113: Can't use after installing via npm (without webpack or similar)

tilgovi commented on issue #113: URL: https://github.com/apache/incubator-annotator/issues/113#issuecomment-913793451 Actually, even compiling the dependencies won't work, because `@mdev/finder` specifies `"type": "module"` in its `package.json`, which means Node will try to load it as ES

[GitHub] [incubator-annotator] tilgovi commented on issue #113: Can't use after installing via npm (without webpack or similar)

tilgovi commented on issue #113: URL: https://github.com/apache/incubator-annotator/issues/113#issuecomment-913791968 Ah, I see. It shouldn't be a problem that `@mdef/finder` is ESM-only, since we only support versions of Node that have stable ESM support. However, it looks like the lands

[GitHub] [incubator-annotator] Treora commented on issue #113: Can't use after installing via npm (without webpack or similar)

Treora commented on issue #113: URL: https://github.com/apache/incubator-annotator/issues/113#issuecomment-913777213 Regarding replacing the `optimal-select` dependency, I described my earlier research in commit message c8ef340e34b1: I tried a few css selector generators, listed

[GitHub] [incubator-annotator] tilgovi commented on issue #113: Can't use after installing via npm (without webpack or similar)

tilgovi commented on issue #113: URL: https://github.com/apache/incubator-annotator/issues/113#issuecomment-912790948 There's a project that compares some of these CSS selector generation libraries, and it seems to find this one favorable, too: https://github.com/fczbkk/css-selector-gener

[GitHub] [incubator-annotator] tilgovi commented on issue #113: Can't use after installing via npm (without webpack or similar)

tilgovi commented on issue #113: URL: https://github.com/apache/incubator-annotator/issues/113#issuecomment-912789963 I propose we switch to [@medv/finder](https://github.com/antonmedv/finder). It is actively maintained (for now), written in TypeScript, seems properly packaged, has no dep

[GitHub] [incubator-annotator] tilgovi commented on issue #115: Turn AsyncGenerators into Generators

tilgovi commented on issue #115: URL: https://github.com/apache/incubator-annotator/issues/115#issuecomment-901270903 I've been thinking more about this and I think we should try to tackle it for the next release. One option would be to just make sure that our API allows context to

[GitHub] [incubator-annotator] tilgovi commented on issue #115: Turn AsyncGenerators into Generators

tilgovi commented on issue #115: URL: https://github.com/apache/incubator-annotator/issues/115#issuecomment-883082208 > One can always make a sync function into async one, but not the other way around. Yes, that's the reason for making everything async now. If we compose higher lev

[GitHub] [incubator-annotator] tilgovi edited a comment on issue #115: Turn AsyncGenerators into Generators

tilgovi edited a comment on issue #115: URL: https://github.com/apache/incubator-annotator/issues/115#issuecomment-883082208 > One can always make a sync function into async one, but not the other way around. Yes, that's the reason for making everything async now. If we compose high

[GitHub] [incubator-annotator] DellCliff commented on issue #115: Turn AsyncGenerators into Generators

DellCliff commented on issue #115: URL: https://github.com/apache/incubator-annotator/issues/115#issuecomment-882816203 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [incubator-annotator] DellCliff edited a comment on issue #115: Turn AsyncGenerators into Generators

DellCliff edited a comment on issue #115: URL: https://github.com/apache/incubator-annotator/issues/115#issuecomment-882816203 This kinda smells like speculative generality. IMO I would make those matchers not adhere to some common interface and let them have their own signature. A user c

[GitHub] [incubator-annotator] tilgovi commented on issue #113: Can't use after installing via npm (without webpack or similar)

tilgovi commented on issue #113: URL: https://github.com/apache/incubator-annotator/issues/113#issuecomment-883091895 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[GitHub] [incubator-annotator] Treora commented on issue #115: Turn AsyncGenerators into Generators

Treora commented on issue #115: URL: https://github.com/apache/incubator-annotator/issues/115#issuecomment-882519923 You are completely correct that there is no need for the current functions to be async. The reason they are async is to make it easier to do async stuff in the future, with

[GitHub] [incubator-annotator] tilgovi commented on issue #115: Turn AsyncGenerators into Generators

tilgovi commented on issue #115: URL: https://github.com/apache/incubator-annotator/issues/115#issuecomment-883082208 > One can always make a sync function into async one, but not the other way around. Yes, that's the reason for making everything async now. If we compose higher lev

[GitHub] [incubator-annotator] tilgovi edited a comment on issue #115: Turn AsyncGenerators into Generators

tilgovi edited a comment on issue #115: URL: https://github.com/apache/incubator-annotator/issues/115#issuecomment-883082208 > One can always make a sync function into async one, but not the other way around. Yes, that's the reason for making everything async now. If we compose high

[GitHub] [incubator-annotator] DellCliff edited a comment on issue #115: Turn AsyncGenerators into Generators

DellCliff edited a comment on issue #115: URL: https://github.com/apache/incubator-annotator/issues/115#issuecomment-882816203 This kinda smells like speculative generality. IMO I would make those matchers not adhere to some common interface and let them have their own signature. A user c

[GitHub] [incubator-annotator] DellCliff commented on issue #115: Turn AsyncGenerators into Generators

DellCliff commented on issue #115: URL: https://github.com/apache/incubator-annotator/issues/115#issuecomment-882816203 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [incubator-annotator] tilgovi commented on issue #113: Can't use after installing via npm (without webpack or similar)

tilgovi commented on issue #113: URL: https://github.com/apache/incubator-annotator/issues/113#issuecomment-883091895 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[GitHub] [incubator-annotator] Treora commented on issue #115: Turn AsyncGenerators into Generators

Treora commented on issue #115: URL: https://github.com/apache/incubator-annotator/issues/115#issuecomment-882519923 You are completely correct that there is no need for the current functions to be async. The reason they are async is to make it easier to do async stuff in the future, with

[GitHub] [incubator-annotator] tilgovi commented on issue #113: Can't use after installing via npm (without webpack or similar)

tilgovi commented on issue #113: URL: https://github.com/apache/incubator-annotator/issues/113#issuecomment-883097394 Looks like that problem has been reported here: https://github.com/autarc/optimal-select/issues/70 We could drop the "describe" support for Element -> CSS selector c

[GitHub] [incubator-annotator] tilgovi commented on issue #113: Can't use after installing via npm (without webpack or similar)

tilgovi commented on issue #113: URL: https://github.com/apache/incubator-annotator/issues/113#issuecomment-883091895 We are generating ES6 imports/exports. We don't actually ship CommonJS at all right now. But npm package imports are not valid in the browser because the browser only allo

[GitHub] [incubator-annotator] tilgovi edited a comment on issue #115: Turn AsyncGenerators into Generators

tilgovi edited a comment on issue #115: URL: https://github.com/apache/incubator-annotator/issues/115#issuecomment-883082208 > One can always make a sync function into async one, but not the other way around. Yes, that's the reason for making everything async now. If we compose high

[GitHub] [incubator-annotator] tilgovi commented on issue #115: Turn AsyncGenerators into Generators

tilgovi commented on issue #115: URL: https://github.com/apache/incubator-annotator/issues/115#issuecomment-883082208 > One can always make a sync function into async one, but not the other way around. Yes, that's the reason for making everything async now. If we compose higher lev

  1   2   3   4   >