Re: Review Request 73654: ATLAS-4454 : Upgrade JanusGraph version to 0.6.0

2021-10-21 Thread Madhan Neethiraj
> On Oct. 19, 2021, 5:57 p.m., Madhan Neethiraj wrote: > > graphdb/janus-hbase2/src/main/java/org/janusgraph/diskstorage/hbase2/HBaseKeyColumnValueStore.java > > Lines 157 (patched) > > <https://reviews.apache.org/r/73654/diff/3/?file=22

Re: Review Request 73654: ATLAS-4454 : Upgrade JanusGraph version to 0.6.0

2021-10-20 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73654/#review223643 --- Ship it! Ship It! - Madhan Neethiraj On Oct. 20, 2021, 5:45

Re: Review Request 73654: ATLAS-4454 : Upgrade JanusGraph version to 0.6.0

2021-10-19 Thread Madhan Neethiraj
=> ex var10 => ex - Madhan Neethiraj On Oct. 19, 2021, 11:27 a.m., Pinal Shah wrote: > > --- > This is an automatically generated e-mail. To reply, visit:

Re: Reminder: To add contributor in Atlas.

2021-09-23 Thread Madhan Neethiraj
Shraddha, Thank you for your interest in contributing to Apache Atlas. You now have  contributor access in Apache Atlas. Welcome to Apache Atlas. Thanks, Madhan for the Apache Atlas PMC From: Shraddha Chauhan Date: Wednesday, September 22, 2021 at 10:23 PM To: Madhan Neethiraj Cc

Re: Review Request 73595: ATLAS-4428 : Enhance Atlas hook messages to capture hook version & message source

2021-09-22 Thread Madhan Neethiraj
d void setHookInfo(HookInfo hookInfo) { this.hookInfo = hookInfo; } - Madhan Neethiraj On Sept. 21, 2021, 10:23 a.m., chaitali wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http

Re: Reminder: To add contributor in Atlas.

2021-09-22 Thread Madhan Neethiraj
Shraddha, Thank you for your interest in contributing to Apache Atlas. Can you please create a JIRA account at https://issues.apache.org/jira/ and send your account id? Thanks, Madhan On 9/22/21, 8:29 AM, "Shraddha Chauhan" wrote: Hi, This is a gentle reminder to add me as a

[DRAFT] [REPORT] Apache Atlas - Sep-2021

2021-09-09 Thread Madhan Neethiraj
Atlas community, Please review the following draft report for this quarter. Thanks, Madhan ## Description: The mission of Apache Atlas is the creation and maintenance of software related to a scalable and extensible set of core foundational governance services - enabling enterprises to

[jira] [Resolved] (ATLAS-3665) Add 'queryText' attribute to the 'spark_process' type

2021-08-24 Thread Madhan Neethiraj (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3665?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Madhan Neethiraj resolved ATLAS-3665. - Fix Version/s: (was: 2.3.0) 2.2.0 Resolution: Fixed >

[jira] [Resolved] (ATLAS-3646) Create new 'spark_ml_model_dataset' and 'spark_ml_pipeline_dataset' relationship definitions

2021-08-24 Thread Madhan Neethiraj (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Madhan Neethiraj resolved ATLAS-3646. - Fix Version/s: (was: 2.3.0) 2.2.0 Resolution: Fixed

[jira] [Resolved] (ATLAS-4278) Deferred Actions : Deleting a tag after disassociating it from a table which propagated fails

2021-08-24 Thread Madhan Neethiraj (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-4278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Madhan Neethiraj resolved ATLAS-4278. - Fix Version/s: (was: 2.3.0) 2.2.0 Resolution: Fixed

[jira] [Updated] (ATLAS-3610) Enable logging to multiple targets (logdir, stdout)

2021-08-24 Thread Madhan Neethiraj (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3610?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Madhan Neethiraj updated ATLAS-3610: Fix Version/s: (was: 2.2.0) 2.3.0 > Enable logging to multi

[jira] [Updated] (ATLAS-3794) New UI: Advance search usablity improvment

2021-08-24 Thread Madhan Neethiraj (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Madhan Neethiraj updated ATLAS-3794: Fix Version/s: (was: 2.2.0) 2.3.0 > New UI: Advance search usabl

[jira] [Updated] (ATLAS-3498) Update basic-search to enable search using labels

2021-08-24 Thread Madhan Neethiraj (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3498?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Madhan Neethiraj updated ATLAS-3498: Fix Version/s: (was: 2.2.0) 2.3.0 > Update basic-search to ena

[jira] [Updated] (ATLAS-3837) execute import-hive.sh raise exception: Failed to load application properties

2021-08-24 Thread Madhan Neethiraj (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Madhan Neethiraj updated ATLAS-3837: Fix Version/s: (was: 2.2.0) 2.3.0 > execute import-hive.sh ra

[jira] [Updated] (ATLAS-3353) HMS Hook does not capture the deleted column with alter table replace columns command.

2021-08-24 Thread Madhan Neethiraj (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Madhan Neethiraj updated ATLAS-3353: Fix Version/s: (was: 2.2.0) 2.3.0 > HMS Hook does not capt

[jira] [Updated] (ATLAS-3407) Regression, Impala and Spark Hook : Rename table doesn't rename existing table , but creates new table with updated name.

2021-08-24 Thread Madhan Neethiraj (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Madhan Neethiraj updated ATLAS-3407: Fix Version/s: (was: 2.2.0) 2.3.0 > Regression, Impala and Sp

[jira] [Updated] (ATLAS-3890) Enhancement for all BulkAPIs.

2021-08-24 Thread Madhan Neethiraj (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Madhan Neethiraj updated ATLAS-3890: Fix Version/s: (was: 2.2.0) 2.3.0 > Enhancement for all BulkA

[jira] [Updated] (ATLAS-4278) Deferred Actions : Deleting a tag after disassociating it from a table which propagated fails

2021-08-24 Thread Madhan Neethiraj (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-4278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Madhan Neethiraj updated ATLAS-4278: Fix Version/s: (was: 2.2.0) 2.3.0 > Deferred Actions : Delet

[jira] [Updated] (ATLAS-3852) Entity Bulk Create with unique reference

2021-08-24 Thread Madhan Neethiraj (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3852?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Madhan Neethiraj updated ATLAS-3852: Fix Version/s: (was: 2.2.0) 2.3.0 > Entity Bulk Create with uni

[jira] [Updated] (ATLAS-3341) Atlas knox SSO doesnt work when using external load balancer for Atlas UI.

2021-08-24 Thread Madhan Neethiraj (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3341?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Madhan Neethiraj updated ATLAS-3341: Fix Version/s: (was: 2.2.0) 2.3.0 > Atlas knox SSO doesnt work w

[jira] [Updated] (ATLAS-3683) Entity details > Business Metadata, multi-valued attribute spacing issue

2021-08-24 Thread Madhan Neethiraj (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3683?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Madhan Neethiraj updated ATLAS-3683: Fix Version/s: (was: 2.2.0) 2.3.0 > Entity details > Bu

[jira] [Updated] (ATLAS-3501) Update guava version to 28.0-jre

2021-08-24 Thread Madhan Neethiraj (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Madhan Neethiraj updated ATLAS-3501: Fix Version/s: (was: 2.2.0) 2.3.0 > Update guava version to 2

[jira] [Updated] (ATLAS-3359) Relationships : Unique attribute in a relationship is not honored

2021-08-24 Thread Madhan Neethiraj (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Madhan Neethiraj updated ATLAS-3359: Fix Version/s: (was: 2.2.0) 2.3.0 > Relationships : Uni

[jira] [Updated] (ATLAS-3665) Add 'queryText' attribute to the 'spark_process' type

2021-08-24 Thread Madhan Neethiraj (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3665?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Madhan Neethiraj updated ATLAS-3665: Fix Version/s: (was: 2.2.0) 2.3.0 > Add 'queryText' attrib

[jira] [Updated] (ATLAS-2013) Audit - add non-hbase, persistent audit repository

2021-08-24 Thread Madhan Neethiraj (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-2013?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Madhan Neethiraj updated ATLAS-2013: Fix Version/s: (was: 2.2.0) 2.3.0 > Audit - add non-hb

[jira] [Updated] (ATLAS-3724) Qualified name pattern for Column cause ambiguity in Quickstart data.

2021-08-24 Thread Madhan Neethiraj (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Madhan Neethiraj updated ATLAS-3724: Fix Version/s: (was: 2.2.0) 2.3.0 > Qualified name patt

[jira] [Updated] (ATLAS-3839) import-hive.sh build target directory error

2021-08-24 Thread Madhan Neethiraj (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3839?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Madhan Neethiraj updated ATLAS-3839: Fix Version/s: (was: 2.2.0) 2.3.0 > import-hive.sh build tar

[jira] [Updated] (ATLAS-3468) Exclude JTS topology suite library from being packaged

2021-08-24 Thread Madhan Neethiraj (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Madhan Neethiraj updated ATLAS-3468: Fix Version/s: (was: 2.2.0) 2.3.0 > Exclude JTS topology su

[jira] [Updated] (ATLAS-3255) UI: IE 10 - Page Limit button gets displaced after clicking it.

2021-08-24 Thread Madhan Neethiraj (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Madhan Neethiraj updated ATLAS-3255: Fix Version/s: (was: 2.2.0) 2.3.0 > UI: IE 10 - Page Limit but

[jira] [Updated] (ATLAS-3646) Create new 'spark_ml_model_dataset' and 'spark_ml_pipeline_dataset' relationship definitions

2021-08-24 Thread Madhan Neethiraj (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Madhan Neethiraj updated ATLAS-3646: Fix Version/s: (was: 2.2.0) 2.3.0 > Create

[jira] [Updated] (ATLAS-4246) Make Kafka Interface aware of Kafka Schema Registry

2021-08-24 Thread Madhan Neethiraj (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-4246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Madhan Neethiraj updated ATLAS-4246: Fix Version/s: (was: 2.2.0) 2.3.0 > Make Kafka Interface aw

[jira] [Updated] (ATLAS-4330) Add Kafka topics lag information on metrics and log

2021-08-24 Thread Madhan Neethiraj (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-4330?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Madhan Neethiraj updated ATLAS-4330: Fix Version/s: (was: 2.2.0) 2.3.0 > Add Kafka topics

Re: [VOTE] Release Apache Atlas version 2.2.0 - rc1

2021-08-10 Thread Madhan Neethiraj
+1 for Apache Atlas 2.2.0 rc1 This release has an impressive list of features/enhancements/fixes. In addition to list in Sid's email below, UI updates like type-system browser, enum editor will make it a lot easier to work with Atlas type system. One Atlas to carry the weight of metadata and

Re: Review Request 73504: ATLAS-4390: Change the Atlas branch at dev-support/atlas-docker/.env

2021-08-05 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73504/#review223315 --- Ship it! Ship It! - Madhan Neethiraj On Aug. 5, 2021, 7:21

Re: [VOTE] Release Apache Atlas version 2.2.0 - rc0

2021-08-05 Thread Madhan Neethiraj
Sid, Validated following on Atlas 2.2.0-rc0 - looks good overall! Found couple of issues given below; please review. Thanks, Madhan 1. successfully built Atlas using docker, for profile external-hbase-solr (instructions in dev-support/atlas-docker/README.txt) 2. successfully brought up

Re: Request for Contributor Access

2021-07-29 Thread Madhan Neethiraj
Disha, Thank you for your interest in contributing to Apache Atlas. You now have contributor access in Apache Atlas. Welcome to Apache Atlas. Thanks, Madhan Apache Atlas PMC On 7/28/21, 2:16 PM, "disha talreja" wrote: AtlasDev, This is to follow up on my previous email. I

Re: Planning for Apache Atlas 2.2.0 release

2021-07-28 Thread Madhan Neethiraj
+1 for Apache Atlas 2.2.0 release. It has been a while now! Thanks Sid! Madhan From: Nikhil Bonte Reply-To: "u...@atlas.apache.org" Date: Tuesday, July 27, 2021 at 10:20 PM To: "u...@atlas.apache.org" Cc: "dev@atlas.apache.org" Subject: Re: Planning for Apache Atlas 2.2.0

Re: Review Request 73453: ATLAS-4353 - Atlas typedef name issue with name="name"

2021-07-15 Thread Madhan Neethiraj
> On July 15, 2021, 3:50 p.m., Madhan Neethiraj wrote: > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasGraphUtilsV2.java > > Line 118 (original), 119 (patched) > > <https://reviews.apache.org/r/73453/diff/2/?file=2251209#file2251209line1

Re: Review Request 73453: ATLAS-4353 - Atlas typedef name issue with name="name"

2021-07-15 Thread Madhan Neethiraj
public static String getTypeDefPropertyKey(String typeName) { return PROPERTY_PREFIX + typeName + ATTRIBUTE_PREFIX; } public static String getTypeDefPropertyKey(String typeName, String child) { return PROPERTY_PREFIX + typeName + ATTRIBUTE_PREFIX + "." + child

Re: Next release - 2.2 or 3.0?

2021-06-12 Thread Madhan Neethiraj
Adam, 2.2 release will be from branch-2.0. So, any fix/improvement targeted for 2.2 release must land in branch-2.0. That said, all commits generally land in master branch, and then they are cherry-picked into other relevant branches - like branch-2.0. If it is not a clean cherry-pick, then

Re: Review Request 73409: ATLAS-4330: Add Kafka topics lag information on metrics and log

2021-06-08 Thread Madhan Neethiraj
d only on demand. Rest of the chages look good! This will be a very useful addition. - Madhan Neethiraj On June 7, 2021, 11:12 p.m., Sarath Subramanian wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 73257: Add model types for Google cloud storage

2021-03-30 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73257/#review222743 --- Ship it! Ship It! - Madhan Neethiraj On March 31, 2021, 12

Re: Review Request 73257: Add model types for Google cloud storage

2021-03-30 Thread Madhan Neethiraj
p_typedefs.json Lines 137 (patched) <https://reviews.apache.org/r/73257/#comment311903> requesterPays - sounds like a boolean value. Please review and update the typeName if necessary. - Madhan Neethiraj On March 30, 2021, 10:28 p.m.,

Re: Review Request 73239: HiveHook: HiveServer2 Messages Improvement

2021-03-22 Thread Madhan Neethiraj
iews.apache.org/r/73239/#comment311893> if hive_process and hdfs_path entities are skipped here, then hive_process_execution should be skipped as well. Please review. - Madhan Neethiraj On March 22, 2021, 5:23 p.m., Ash

Review Request 73246: ATLAS-4218: Docker support to run Apache Hive and Apache HBase with Atlas hook

2021-03-20 Thread Madhan Neethiraj
Diff: https://reviews.apache.org/r/73246/diff/1/ Testing --- - verified that Atlas hook in HBase publishes metadata events to Atlas via Kafka notifications - verified that Atlas hook in Hive published metadata events to Atlas via Kafka notification Thanks, Madhan Neethiraj

[jira] [Created] (ATLAS-4218) Docker setup to run Hive and HBase with for Atlas hook

2021-03-20 Thread Madhan Neethiraj (Jira)
Madhan Neethiraj created ATLAS-4218: --- Summary: Docker setup to run Hive and HBase with for Atlas hook Key: ATLAS-4218 URL: https://issues.apache.org/jira/browse/ATLAS-4218 Project: Atlas

Re: Review Request 73239: HiveHook: HiveServer2 Messages Improvement

2021-03-19 Thread Madhan Neethiraj
to clean cache of deleted database. addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/DropTable.java Lines 71 (patched) <https://reviews.apache.org/r/73239/#comment311890> Please review if context.removeKnownTable(), #81, should be called for all tables, to clean cache

[jira] [Updated] (ATLAS-4215) HBase hook fails with ClassNotFoundException: org.apache.logging.log4j.LogManager

2021-03-19 Thread Madhan Neethiraj (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-4215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Madhan Neethiraj updated ATLAS-4215: Affects Version/s: (was: 2.2.0) 3.0.0 > HBase hook fa

Review Request 73244: ATLAS-4215: notification module updates to gracefully handle failure in finding org.apache.logging.log4j library

2021-03-18 Thread Madhan Neethiraj
--- - verified that Atlas HBase hook work with HBase 2.3.3 - pre-commit tests run: https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/460/ Thanks, Madhan Neethiraj

[jira] [Created] (ATLAS-4215) HBase hook fails with ClassNotFoundException: org.apache.logging.log4j.LogManager

2021-03-18 Thread Madhan Neethiraj (Jira)
Madhan Neethiraj created ATLAS-4215: --- Summary: HBase hook fails with ClassNotFoundException: org.apache.logging.log4j.LogManager Key: ATLAS-4215 URL: https://issues.apache.org/jira/browse/ATLAS-4215

Re: Review Request 73172: ATLAS-4124 Restrict user from deleting Business Metadata, if Business Metadata is already associated with an entity

2021-03-17 Thread Madhan Neethiraj
ess-metadata attribute is found - this will also be a better option to handle business-metadata having large number of attributes (consider few hundred attributes), by avoiding potential index-query limit at #449 below. - Madhan Neethiraj On March 2, 2021, 8:18 a.m., Mandar Am

Re: Review Request 73228: Fix the missing properties of Atlas Entity

2021-03-16 Thread Madhan Neethiraj
Verdan, Apache Atlas Python client 0.11 is now available at https://pypi.org/project/apache-atlas/. Thanks, Madhan On 3/15/21, 9:59 AM, "Verdan Mahmood" wrote: and a new release to PyPi too, please. 

Review Request 73230: ATLAS-4205: fixes in Python sample-app and Python client

2021-03-15 Thread Madhan Neethiraj
/r/73230/diff/1/ Testing --- - sample_client.py executes successfully Thanks, Madhan Neethiraj

[jira] [Created] (ATLAS-4205) Python sample-app failures

2021-03-15 Thread Madhan Neethiraj (Jira)
Madhan Neethiraj created ATLAS-4205: --- Summary: Python sample-app failures Key: ATLAS-4205 URL: https://issues.apache.org/jira/browse/ATLAS-4205 Project: Atlas Issue Type: Bug

Re: Review Request 73228: Fix the missing properties of Atlas Entity

2021-03-15 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73228/#review222685 --- Ship it! Ship It! - Madhan Neethiraj On March 15, 2021, 3

Re: can't build and run Apache Atlas pulled from official repository

2021-03-15 Thread Madhan Neethiraj
To: Madhan Neethiraj Subject: Re: can't build and run Apache Atlas pulled from official repository Sorry I forgot to mention that I have exported the required environment variables too (HBASE and SOLR), before running the atlas_start.py. On Monday, March 15, 2021, 12:16:45 PM GMT+3:30, Mostafa

Re: Review Request 73228: Fix the missing properties of Atlas Entity

2021-03-15 Thread Madhan Neethiraj
lasses consistent with Java equivalent. - Madhan Neethiraj On March 15, 2021, 10:39 a.m., Verdan Mahmood wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: can't build and run Apache Atlas pulled from official repository

2021-03-14 Thread Madhan Neethiraj
Mostafa, I followed the instructions in http://atlas.apache.org/#/BuildInstallation and http://atlas.apache.org/#/Installation: - Build Atlas with command: mvn clean -DskipTests package -Pdist,embedded-hbase-solr - Install and run with following commands: tar -xzvf

Re: Review Request 73224: Fixes the cyclic import issue for Python3.6

2021-03-13 Thread Madhan Neethiraj
Done! Apache Atlas Python client 0.0.5 is now available at https://pypi.org/project/apache-atlas. Madhan From: Verdan Mahmood Date: Friday, March 12, 2021 at 10:32 AM To: Madhan Neethiraj Cc: Pinal Shah , Sarath Subramanian , atlas Subject: Re: Review Request 73224: Fixes the cyclic

Re: Review Request 73224: Fixes the cyclic import issue for Python3.6

2021-03-12 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73224/#review222677 --- Ship it! Ship It! - Madhan Neethiraj On March 11, 2021, 4

Re: Review Request 73216: ATLAS-4188: Docker setup updated to run Atlas, HBase, Solr, Kafka, Zookeeper in seperate containers

2021-03-11 Thread Madhan Neethiraj
in a container - pre-commit tests run: https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/431 Thanks, Madhan Neethiraj

[DRAFT] Board report for Apache Atlas: March 2021

2021-03-09 Thread Madhan Neethiraj
Atlas team, Please review the draft board report below and send your feedback/comments. Thanks, Madhan ## Description: Apache Atlas is a scalable and extensible set of core foundational governance services that enables enterprises to effectively and efficiently meet their compliance

Re: Apache Atlas Commit Proposal

2021-03-09 Thread Madhan Neethiraj
Hi Marcel Jakob, Dennis Geisse, Aileen Toleikis, Thank you for reaching out on contributing to Apache Atlas. Here are the steps to contribute to Apache Atlas: 1. File a JIRA with details of the use case and issues faced (if relevant) at https://issues.apache.org/jira (project = ATLAS) 2.

Re: Review Request 73076: Deferred Actions Implementation

2021-03-08 Thread Madhan Neethiraj
ement.java Lines 161 (patched) <https://reviews.apache.org/r/73076/#comment311839> print() might be done only when tasks on submitted. Consider moving this call to where a task execution completes. - Madhan Neethiraj On March 8, 2021, 6:19 p.m., Ashutosh Mestry wrote: > >

Review Request 73216: Docker setup updated to run Atlas, HBase, Solr, Kafka, Zookeeper in seperate containers

2021-03-07 Thread Madhan Neethiraj
are built and run successfully - ran quick_start.py successfully on Atlas instance running in a container Thanks, Madhan Neethiraj

[jira] [Created] (ATLAS-4188) Docker setup to run Atlas and dependent services in separate containers

2021-03-07 Thread Madhan Neethiraj (Jira)
Madhan Neethiraj created ATLAS-4188: --- Summary: Docker setup to run Atlas and dependent services in separate containers Key: ATLAS-4188 URL: https://issues.apache.org/jira/browse/ATLAS-4188 Project

Re: Adding mandatory attribute to an existing entity type

2021-03-05 Thread Madhan Neethiraj
Sreeni, Jiaxin, Enhancements in ATLAS-4181 by Radhika addresses this requirement using type-def patch. More details in the JIRA. Hope this helps. Regards, Madhan From: Jiaxin Ye Reply-To: Date: Wednesday, January 20, 2021 at 5:13 PM To: "u...@atlas.apache.org" ,

Re: Review Request 73213: ATLAS-4183 Upgrade deployment descriptor for webapp project

2021-03-02 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73213/#review222648 --- Ship it! Ship It! - Madhan Neethiraj On March 2, 2021, 3:45

Re: Review Request 73211: ATLAS-4182 : Quick Search: Incorrect aggregation Metric when less than operator is selected to filter

2021-03-01 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73211/#review222647 --- Ship it! Ship It! - Madhan Neethiraj On March 2, 2021, 5:36

Re: Review Request 73172: ATLAS-4124 Restrict user from deleting Business Metadata, if Business Metadata is already associated with an entity

2021-03-01 Thread Madhan Neethiraj
/AtlasTypeDefGraphStore.java Lines 550 (patched) <https://reviews.apache.org/r/73172/#comment311809> Consider checking for references in preDelete*() methods in AtlasBusinessMetadataDefStoreV2, similar to AtlasEntityDef/AtlasClassificationDef/AtlasStructDef/AtlasRelationshipDef. -

Re: Review Request 73172: ATLAS-4124 Restrict user from deleting Business Metadata, if Business Metadata is already associated with an entity

2021-03-01 Thread Madhan Neethiraj
as it is a member of this class. repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStore.java Lines 92 (patched) <https://reviews.apache.org/r/73172/#comment311800> For clarity, consider moving #92 to #98, as applicableTypes is initializaed and used only

Re: Review Request 73197: ATLAS-4171 : Authorisation : Bulk entity DELETE API doesn't delete authorised entities

2021-02-23 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73197/#review222627 --- Ship it! Ship It! - Madhan Neethiraj On Feb. 23, 2021, 5:20

Re: Review Request 73197: ATLAS-4171 : Authorisation : Bulk entity DELETE API doesn't delete authorised entities

2021-02-23 Thread Madhan Neethiraj
/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java Lines 541 (patched) <https://reviews.apache.org/r/73197/#comment311785> vertex is not yet added to deletionCandidates; it is added only in #547 below. Hence #541 can be removed. Please review. - Madhan Neethiraj On Feb. 23, 2021

Re: Review Request 73197: ATLAS-4171 : Authorisation : Bulk entity DELETE API doesn't delete authorised entities

2021-02-22 Thread Madhan Neethiraj
add(vertex); repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java Lines 539 (patched) <https://reviews.apache.org/r/73197/#comment311782> createOrUpdate => deleteByIds - Madhan Neethiraj On Feb.

Re: Review Request 73076: Deferred Actions Implementation

2021-02-19 Thread Madhan Neethiraj
a Lines 755 (patched) <https://reviews.apache.org/r/73076/#comment311758> Consider supporting multiple guids for delete as well: @DELETE @Path("/tasks") @Produces(Servlets.JSON_MEDIA_TYPE) public List deleteTask(@QueryParam("guid")

Re: Review Request 73076: Deferred Actions Implementation

2021-02-17 Thread Madhan Neethiraj
lRepo.java Lines 26 (patched) <https://reviews.apache.org/r/73076/#comment311732> This implementation exists in webapp/src/main/java/org/apache/atlas/BeanUtil.java as well. Consider moving BeanUtil class to repository, to avoid

Re: Review Request 73185: NotificationHookConsumer: Large Compressed Message Processing Problem

2021-02-17 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73185/#review222605 --- Ship it! Ship It! - Madhan Neethiraj On Feb. 17, 2021, 7:12

Re: Review Request 73185: NotificationHookConsumer: Large Compressed Message Processing Problem

2021-02-17 Thread Madhan Neethiraj
hould be: return this.receive(); webapp/src/main/java/org/apache/atlas/notification/NotificationHookConsumer.java Lines 193 (patched) <https://reviews.apache.org/r/73185/#comment311712> Consider marking lastCommittedPartitionOffset as final. - Madhan Neethiraj On Feb. 17, 2021

Re: Review Request 73185: NotificationHookConsumer: Large Compressed Message Processing Problem

2021-02-16 Thread Madhan Neethiraj
/AtlasKafkaConsumer.java Lines 116 (patched) <https://reviews.apache.org/r/73185/#comment311709> records with offset less than the committed offset should be skipped right? This seems to skip records with offset higher than the committed offset. Please review and update. - Madhan Neethiraj On F

Re: Review Request 73185: NotificationHookConsumer: Large Compressed Message Processing Problem

2021-02-15 Thread Madhan Neethiraj
And send this to AtlasKafkaConsumer.receiveWithCheckedCommit() so that it can get topic/partition specifc offset and commit when appropriate. - Madhan Neethiraj On Feb. 15, 2021, 5:17 a.m., Ashutosh Mestry wrote: > > --- > This is an au

[jira] [Issue Comment Deleted] (ATLAS-3725) Are UI pages considering i18n internationalization support?

2021-02-08 Thread Madhan Neethiraj (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3725?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Madhan Neethiraj updated ATLAS-3725: Comment: was deleted (was: HI EE, Customer of ([https://csh.cloudera.com/ccs/index.html

Re: Review Request 73076: Deferred Actions Implementation

2021-02-05 Thread Madhan Neethiraj
l help to record guid of the deferred-action in the classification. It will help the user to know that the classification hasn't yet been propagated; and UI can render the status appropriately. class AtlasClassification { ... List pendingPropagations; } - Madh

Re: Review Request 73076: Deferred Actions Implementation

2021-02-04 Thread Madhan Neethiraj
AtlasConfiguration.TASKS_USE_ENABLED in Request context as RequestContext.skipPropagation. Remove data member skipPropagation, and have its callers directly check for AtlasConfiguration.TASKS_USE_ENABLED webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java Lines 16

Re: Review Request 73172: ATLAS-4124 Restrict user from deleting Business Metadata, if Business Metadata is already associated with an entity

2021-02-04 Thread Madhan Neethiraj
l-scan (watch for warning message in log). I suggest using index-query, with is-not-null condition - refer basic-search use of AtlasSolrQueryBuilder.withIsNotNull(). - Madhan Neethiraj On Feb. 4, 2021, 2:22 p.m., Mandar Ambawane

Re: Review Request 73170: ATLAS-4127 Reduce number of Hive table calls in Atlas Hook

2021-02-03 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73170/#review222554 --- Ship it! Ship It! - Madhan Neethiraj On Feb. 4, 2021, 2:10

[jira] [Resolved] (ATLAS-4108) Enable elasticsearch support in free text search processor

2021-01-23 Thread Madhan Neethiraj (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-4108?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Madhan Neethiraj resolved ATLAS-4108. - Fix Version/s: 2.2.0 3.0.0 Assignee: Jarosław Cellary

Re: Review Request 73155: ATLAS-4108 elasticsearch support in free text search processor

2021-01-23 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73155/#review222520 --- Ship it! Ship It! - Madhan Neethiraj On Jan. 21, 2021, 1:11

Re: Review Request 73157: ATLAS-4110 Inconsistency in the result of DSL query and basic query.

2021-01-23 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73157/#review222519 --- Ship it! Ship It! - Madhan Neethiraj On Jan. 21, 2021, 11

Re: Review Request 73012: ATLAS-4019 Audit improvement to store only delta

2021-01-21 Thread Madhan Neethiraj
> On Jan. 19, 2021, 8:18 p.m., Madhan Neethiraj wrote: > > repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListenerV2.java > > Lines 114 (patched) > > <https://reviews.apache.org/r/73012/diff/3/?file=2244479#file2244479line114> > > > &g

Re: Review Request 73012: ATLAS-4019 Audit improvement to store only delta

2021-01-21 Thread Madhan Neethiraj
/atlas/repository/store/graph/v2/AtlasEntityComparator.java Lines 93 (patched) <https://reviews.apache.org/r/73012/#comment311617> justCompare => findOnlyFirstDiff - Madhan Neethiraj On Jan. 20, 2021, 10:13 p.m., Deep Si

Review Request 73150: ATLAS-2932: improvements for easier readability

2021-01-20 Thread Madhan Neethiraj
://reviews.apache.org/r/73150/diff/1/ Testing --- - manually verified that 'mvn clean package' and 'mvn clean install' succeeded - pre-commit tests run: https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/345/ Thanks, Madhan Neethiraj

Re: Review Request 73128: DSL: Using AtlasTraversal Instead of Gremlin

2021-01-20 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73128/#review222501 --- Ship it! Ship It! - Madhan Neethiraj On Jan. 20, 2021, 6:49

Re: Review Request 73128: DSL: Using AtlasTraversal Instead of Gremlin

2021-01-19 Thread Madhan Neethiraj
zied at #280 with attributeType.getNormalizedValue(attrVal). Please review. - Madhan Neethiraj On Jan. 19, 2021, 4:52 a.m., Ashutosh Mestry wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Re: Review Request 73012: ATLAS-4019 Audit improvement to store only delta

2021-01-19 Thread Madhan Neethiraj
ore/graph/v2/AtlasEntityStoreV2.java Lines 1176 (patched) <https://reviews.apache.org/r/73012/#comment311598> Shouldn't hasUpdates be set to 'true' inside this if block, so that entity udpate might be skipped in #1178 below? - Madhan Neethiraj On Jan. 15, 2021, 5:34 a.m., Deep Singh

Re: Review Request 73119: ATLAS-4094 Sorting functionality on Atlas entity audit api

2021-01-19 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73119/#review222496 --- Ship it! Ship It! - Madhan Neethiraj On Jan. 19, 2021, 4:51

[jira] [Resolved] (ATLAS-4086) Fix Atlas Python Client Search and Bulk Get Entities

2021-01-18 Thread Madhan Neethiraj (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-4086?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Madhan Neethiraj resolved ATLAS-4086. - Fix Version/s: 2.2.0 3.0.0 Assignee: Verdan Mahmood

Re: Review Request 73139: ATLAS-4086: Fixes the search and other major issues in python client

2021-01-18 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73139/#review222490 --- Ship it! Ship It! - Madhan Neethiraj On Jan. 12, 2021, 9:54

Re: Review Request 73139: ATLAS-4086: Fixes the search and other major issues in python client

2021-01-18 Thread Madhan Neethiraj
> On Jan. 12, 2021, 11:38 p.m., Madhan Neethiraj wrote: > > intg/src/main/python/apache_atlas/model/glossary.py > > Line 19 (original), 19 (patched) > > <https://reviews.apache.org/r/73139/diff/2/?file=2244261#file2244261line19> > > > > C

Re: Review Request 73128: DSL: Using AtlasTraversal Instead of Gremlin

2021-01-15 Thread Madhan Neethiraj
' or ((owner = 'hive' and name = 'my_tbl) or (owner = 'sys' or createTime > "2021-01-01'T'00:00:00.000'Z'"))) - Madhan Neethiraj On Jan. 16, 2021, 7:06 a.m., Ashutosh Mestry wrote: > > --- > This is an automatically

Review Request 73146: ATLAS-4077: replaced print statements in Python files with call to print(), for Python3

2021-01-15 Thread Madhan Neethiraj
/Atlas/job/PreCommit-ATLAS-Build-Test/337/ Thanks, Madhan Neethiraj

<    1   2   3   4   5   6   7   8   9   10   >