[jira] [Updated] (ATLAS-1959) Enhance relationship attributes to support different cardinality mappings

2018-05-16 Thread Madhan Neethiraj (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Madhan Neethiraj updated ATLAS-1959: Fix Version/s: 1.0.0 > Enhance relationship attributes to support different cardinal

[jira] [Updated] (ATLAS-2372) Export-Import: Support for Relationship Attributes Missing

2018-05-16 Thread Madhan Neethiraj (JIRA)
for Relationship Attributes Missing > -- > > Key: ATLAS-2372 > URL: https://issues.apache.org/jira/browse/ATLAS-2372 > Project: Atlas > Issue Type: Bug > Components:

[jira] [Updated] (ATLAS-2420) Create indexes for relationship attributes

2018-05-16 Thread Madhan Neethiraj (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-2420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Madhan Neethiraj updated ATLAS-2420: Fix Version/s: 1.0.0 > Create indexes for relationship attribu

Re: Review Request 65329: [ATLAS-2420]: Create indexes for relationship attributes

2018-01-28 Thread Madhan Neethiraj
ystem attributes (guid) of relationship is not > indexed. This Jira enables adding indexing for relationship attributes. It > makes use of edge_index in solr. > > > Diffs > - > > common/src/main/java/org/apache/atlas/repository/Constants.java d63f361b > >

Re: Review Request 65329: [ATLAS-2420]: Create indexes for relationship attributes

2018-01-28 Thread Sarath Subramanian
tps://issues.apache.org/jira/browse/ATLAS-2420 > > > Repository: atlas > > > Description > --- > > Currently attributes and system attributes (guid) of relationship is not > indexed. This Jira enables adding indexing for relationship attributes. It > makes use

Re: Review Request 65329: [ATLAS-2420]: Create indexes for relationship attributes

2018-01-27 Thread Madhan Neethiraj
attributes and system attributes (guid) of relationship is not > indexed. This Jira enables adding indexing for relationship attributes. It > makes use of edge_index in solr. > > > Diffs > - > > common/src/main/java/org/apache/atlas/repository/Constants.java

Review Request 65329: [ATLAS-2420]: Create indexes for relationship attributes

2018-01-24 Thread Sarath Subramanian
://issues.apache.org/jira/browse/ATLAS-2420 Repository: atlas Description --- Currently attributes and system attributes (guid) of relationship is not indexed. This Jira enables adding indexing for relationship attributes. It makes use of edge_index in solr. Diffs - common/src/main

Re: Review Request 65220: Import: Support for Types with Relationship Attributes

2018-01-19 Thread Sarath Subramanian
> After introduction of _relationshipAttributes_ the import of types with > relationship attributes started failing. > > **Analysis** > Root cause: The _AtlasEntityGraphDiscoveryV1_ started using > _relationshipAttribute_ to discover entities. This caused more entities to be &

Re: Review Request 65220: Import: Support for Types with Relationship Attributes

2018-01-19 Thread Ashutosh Mestry
relationship attributes started failing. **Analysis** Root cause: The _AtlasEntityGraphDiscoveryV1_ started using _relationshipAttribute_ to discover entities. This caused more entities to be discovered than what was happening before. This caused the single stream entity not to lookup entities correctly

Re: Review Request 65220: Import: Support for Types with Relationship Attributes

2018-01-18 Thread Ashutosh Mestry
_relationshipAttributes_ the import of types with relationship attributes started failing. **Analysis** Root cause: The _AtlasEntityGraphDiscoveryV1_ started using _relationshipAttribute_ to discover entities. This caused more entities to be discovered than what was happening before. This caused the

Re: Review Request 65220: Import: Support for Types with Relationship Attributes

2018-01-18 Thread Ashutosh Mestry
_relationshipAttributes_ the import of types with relationship attributes started failing. **Analysis** Root cause: The _AtlasEntityGraphDiscoveryV1_ started using _relationshipAttribute_ to discover entities. This caused more entities to be discovered than what was happening before. This caused the

Review Request 65220: Import: Support for Types with Relationship Attributes

2018-01-18 Thread Ashutosh Mestry
-2372 https://issues.apache.org/jira/browse/ATLAS-2372 Repository: atlas Description --- **Background** After introduction of _relationshipAttributes_ the import of types with relationship attributes started failing. **Analysis** Root cause: The _AtlasEntityGraphDiscoveryV1_ started

Re: Review Request 61247: [ATLAS-1984]: Use AtlasRelatedObjectId to refer to relationship attributes during entity create/update

2017-08-24 Thread Sarath Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61247/ --- (Updated Aug. 24, 2017, 5:30 p.m.) Review request for atlas, David Radley and M

Re: Review Request 61247: [ATLAS-1984]: Use AtlasRelatedObjectId to refer to relationship attributes during entity create/update

2017-08-24 Thread Madhan Neethiraj
ype, > > entity.getRelationshipAttribute(attrName)); > > } else if (entity.hasAttribute(attrName)) { > > visitAttribute(attrType, entity.getAttribute(attrName)); > > } > > } > > Sarath Subramanian wrote: > entityType.getAllAttributes() d

Re: Review Request 61247: [ATLAS-1984]: Use AtlasRelatedObjectId to refer to relationship attributes during entity create/update

2017-08-24 Thread Sarath Subramanian
ype, > > entity.getRelationshipAttribute(attrName)); > > } else if (entity.hasAttribute(attrName)) { > > visitAttribute(attrType, entity.getAttribute(attrName)); > > } > > } entityType.getAllAttributes() doesn't include relationship attributes (al

Re: Review Request 61247: [ATLAS-1984]: Use AtlasRelatedObjectId to refer to relationship attributes during entity create/update

2017-08-24 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61247/#review183805 --- Fix it, then Ship it! Sarath - few minor improvements. Rest of

Re: Review Request 61247: [ATLAS-1984]: Use AtlasRelatedObjectId to refer to relationship attributes during entity create/update

2017-08-23 Thread Sarath Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61247/ --- (Updated Aug. 23, 2017, 10:27 a.m.) Review request for atlas, David Radley and

[jira] [Commented] (ATLAS-1959) Enhance relationship attributes to support different cardinality mappings

2017-08-22 Thread Sarath Subramanian (JIRA)
git1-us-west.apache.org/repos/asf?p=atlas.git;a=commit;h=02e4e86b5adeb52044ba09a978c8ccbb2200d67d > Enhance relationship attributes to support different cardinality mappings > - > >

[jira] [Commented] (ATLAS-1984) Use AtlasRelatedObjectId to refer to relationship attributes during entity create/update

2017-08-13 Thread ATLAS QA (JIRA)
/418//console This message is automatically generated. > Use AtlasRelatedObjectId to refer to relationship attributes during entity > create/update > > > Key: ATLAS-1984 >

Re: Review Request 61247: [ATLAS-1984]: Use AtlasRelatedObjectId to refer to relationship attributes during entity create/update

2017-08-08 Thread Sarath Subramanian
t; legacy relationships. this section adds relationshipattributes to legacy relationships (hive_table.columns) and its inverse edge (hive_column.table). If we restrict adding relationshipAttributes to legacy edges, how do we support systems with legacy models to use some of the relationship featu

Re: Review Request 61247: [ATLAS-1984]: Use AtlasRelatedObjectId to refer to relationship attributes during entity create/update

2017-08-08 Thread Sarath Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61247/ --- (Updated Aug. 8, 2017, 2:13 p.m.) Review request for atlas, David Radley and Ma

Re: Review Request 61247: [ATLAS-1984]: Use AtlasRelatedObjectId to refer to relationship attributes during entity create/update

2017-08-07 Thread David Radley
per.java Lines 1437 (patched) <https://reviews.apache.org/r/61247/#comment258175> I suggest this be static and junitted. This method seems to be removing entity attributes when there was a relationship attributes. This appears to be part of the legacy support; if so shouldn't we

[jira] [Updated] (ATLAS-1984) Use AtlasRelatedObjectId to refer to relationship attributes during entity create/update

2017-07-30 Thread Sarath Subramanian (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1984?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sarath Subramanian updated ATLAS-1984: -- Attachment: ATLAS-1984.1.patch > Use AtlasRelatedObjectId to refer to relations

Review Request 61247: [ATLAS-1984]: Use AtlasRelatedObjectId to refer to relationship attributes during entity create/update

2017-07-30 Thread Sarath Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61247/ --- Review request for atlas, David Radley and Madhan Neethiraj. Bugs: ATLAS-1984

[jira] [Updated] (ATLAS-1984) Use AtlasRelatedObjectId to refer to relationship attributes during entity create/update

2017-07-27 Thread Sarath Subramanian (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1984?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sarath Subramanian updated ATLAS-1984: -- Summary: Use AtlasRelatedObjectId to refer to relationship attributes during entity

Re: Relationship attributes

2017-07-25 Thread David Radley
Date: 24/07/2017 23:57 Subject: Re: Relationship attributes Sent by:Madhan Neethiraj David, I would suggest going with the following: class AtlasEntity { // ... Map attributes; // ... Map relationships; // Object type can be either AtlasRelatedObjectId or Collectio

Re: Relationship attributes

2017-07-24 Thread Madhan Neethiraj
: 24/07/2017 16:16 Subject: Re: Relationship attributes Sent by:Madhan Neethiraj As I said earlier, I prefer “relatedEntities” – as this name states that the values in this attributes are references to entities. I think “relationships” is good as we

Re: Relationship attributes

2017-07-24 Thread David Radley
24/07/2017 16:16 Subject: Re: Relationship attributes Sent by:Madhan Neethiraj As I said earlier, I prefer “relatedEntities” – as this name states that the values in this attributes are references to entities. I think “relationships” is good as well. However, I would pre

Re: Relationship attributes

2017-07-24 Thread Madhan Neethiraj
Cc: Madhan Neethiraj , Sarath Subramanian , Graham Wallis Subject: Re: Relationship attributes Hi all, I have just had a chat with Graham. we are thinking that we should go with relationships as the top level name. We also think we could helpfully add in the related entity in the new class

Re: Relationship attributes

2017-07-24 Thread David Radley
thiraj To: "dev@atlas.apache.org" , Sarath Subramanian Date: 24/07/2017 09:04 Subject: Re: Relationship attributes Sent by:Madhan Neethiraj Current name of ‘relationshipAttributes’ makes sense looking from an entity point-of-view – it distinguishes regular-att

Re: Relationship attributes

2017-07-24 Thread Nigel L Jones
Analytics CTO Office - jon...@uk.ibm.com From: Graham Wallis To: dev@atlas.apache.org Cc: Madhan Neethiraj , Sarath Subramanian Date: 24/07/2017 09:58 Subject: Re: Relationship attributes Personally I think 'relatedEntities' is clearer. Best regards, Graha

Re: Relationship attributes

2017-07-24 Thread Graham Wallis
thiraj To: "dev@atlas.apache.org" , Sarath Subramanian Date: 24/07/2017 09:04 Subject: Re: Relationship attributes Sent by:Madhan Neethiraj Current name of ‘relationshipAttributes’ makes sense looking from an entity point-of-view – it distinguishes regular-att

[jira] [Commented] (ATLAS-1984) Use AtlasRelatedObjectId to refer to relationship attributes during create/update/delete of entity

2017-07-24 Thread David Radley (JIRA)
lasRelatedObjectId to refer to relationship attributes during > create/update/delete of entity > -- > > Key: ATLAS-1984 > URL: https://issues.apache.org/ji

Re: Relationship attributes

2017-07-24 Thread Madhan Neethiraj
tionships as it is simpler - is there a reason you need attribute in the name? all the best, David. From: Sarath Subramanian To: dev@atlas.apache.org Cc: Madhan Neethiraj Date: 24/07/2017 07:09 Subject:Re: Relation

Re: Relationship attributes

2017-07-24 Thread David Radley
24/07/2017 07:09 Subject: Re: Relationship attributes Hi David, I agree with using the term 'relationship attributes' for attributes of relationship, I suggest we use "relatedAttributes" for relationship attributes of entity. Thanks, Sarath Subramanian On Sun, Jul 2

[jira] [Created] (ATLAS-1984) Use AtlasRelatedObjectId to refer to relationship attributes during create/update/delete of entity

2017-07-23 Thread Sarath Subramanian (JIRA)
Sarath Subramanian created ATLAS-1984: - Summary: Use AtlasRelatedObjectId to refer to relationship attributes during create/update/delete of entity Key: ATLAS-1984 URL: https://issues.apache.org/jira/browse

Re: Relationship attributes

2017-07-23 Thread Sarath Subramanian
Hi David, I agree with using the term 'relationship attributes' for attributes of relationship, I suggest we use "relatedAttributes" for relationship attributes of entity. Thanks, Sarath Subramanian On Sun, Jul 23, 2017 at 2:22 AM, David Radley wrote: > Hi Madhan,

Relationship attributes

2017-07-23 Thread David Radley
Hi Madhan, When I see the phrase 'relationship attributes', I am never quite sure whether we are referring to the attributes of an entity that relate to another entity or the attributes of the relationship instance itself. I think the phrase ' relationship attributes' more n

Re: Review Request 60938: [ATLAS-1959]: Enhance relationship attributes to support different cardinality mappings

2017-07-20 Thread Sarath Subramanian
> On July 19, 2017, 8:11 a.m., David Radley wrote: > > addons/models/0080-storm_model.json > > Line 150 (original), 150 (patched) > > > > > > shouldn't this be aggregation ? > > Sarath Subramanian wrote: > since

Re: Review Request 60938: [ATLAS-1959]: Enhance relationship attributes to support different cardinality mappings

2017-07-20 Thread David Radley
> On July 19, 2017, 3:11 p.m., David Radley wrote: > > addons/models/0080-storm_model.json > > Line 150 (original), 150 (patched) > > > > > > shouldn't this be aggregation ? > > Sarath Subramanian wrote: > since

Re: Review Request 60938: [ATLAS-1959]: Enhance relationship attributes to support different cardinality mappings

2017-07-19 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60938/#review181009 --- Ship it! Ship It! - Madhan Neethiraj On July 19, 2017, 7:27

Re: Review Request 60938: [ATLAS-1959]: Enhance relationship attributes to support different cardinality mappings

2017-07-19 Thread Sarath Subramanian
> On July 19, 2017, 8:11 a.m., David Radley wrote: > > addons/models/0010-base_model.json > > Line 105 (original), 105 (patched) > > > > > > I am not sunderstanding why some of these endpoints have the > > islegacya

Re: Review Request 60938: [ATLAS-1959]: Enhance relationship attributes to support different cardinality mappings

2017-07-19 Thread Sarath Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60938/ --- (Updated July 19, 2017, 12:27 p.m.) Review request for atlas and Madhan Neethir

Re: Review Request 60938: [ATLAS-1959]: Enhance relationship attributes to support different cardinality mappings

2017-07-19 Thread David Radley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60938/#review180926 --- addons/models/0010-base_model.json Line 105 (original), 105 (patc

Re: Review Request 60938: [ATLAS-1959]: Enhance relationship attributes to support different cardinality mappings

2017-07-18 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60938/#review180899 --- repository/src/main/java/org/apache/atlas/repository/store/graph/

[jira] [Updated] (ATLAS-1959) Enhance relationship attributes to support different cardinality mappings

2017-07-17 Thread Sarath Subramanian (JIRA)
operations and the following cardinalities (previously supported using inverseReference): * 1 to 1 * 1 to many * many to 1 * many to many Add unit tests for the above cases. > Enhance relationship attributes to support different cardinality mappi

[jira] [Updated] (ATLAS-1959) Enhance relationship attributes to support different cardinality mappings

2017-07-17 Thread Sarath Subramanian (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sarath Subramanian updated ATLAS-1959: -- Attachment: ATLAS-1959.1.patch > Enhance relationship attributes to support differ

Review Request 60938: [ATLAS-1959]: Enhance relationship attributes to support different cardinality mappings

2017-07-17 Thread Sarath Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60938/ --- Review request for atlas and Madhan Neethiraj. Bugs: ATLAS-1959 https://iss

[jira] [Created] (ATLAS-1959) Enhance relationship attributes to support different cardinality mappings

2017-07-17 Thread Sarath Subramanian (JIRA)
Sarath Subramanian created ATLAS-1959: - Summary: Enhance relationship attributes to support different cardinality mappings Key: ATLAS-1959 URL: https://issues.apache.org/jira/browse/ATLAS-1959

Re: Review Request 60285: [ATLAS-1892]: Implement logic to create relationship attributes in AtlasEntityType

2017-07-06 Thread David Radley
499350955631, "updateTime": 1499350955631, "version": 0, "classifications": [] } } I was expecting to see the relationship attributes with the attribute names with values of AtlasObjectIds and the relationship at

Re: Review Request 60285: [ATLAS-1892]: Implement logic to create relationship attributes in AtlasEntityType

2017-07-06 Thread David Radley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60285/#review179764 --- intg/src/main/java/org/apache/atlas/AtlasErrorCode.java Lines 96

Re: Review Request 60285: [ATLAS-1892]: Implement logic to create relationship attributes in AtlasEntityType

2017-06-22 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60285/#review178772 --- Ship it! Ship It! - Madhan Neethiraj On June 22, 2017, 9:51

Re: Review Request 60285: [ATLAS-1892]: Implement logic to create relationship attributes in AtlasEntityType

2017-06-22 Thread Sarath Subramanian
, Ashutosh Mestry, Madhan Neethiraj, Nixon Rodrigues, and Suma Shivaprasad. Changes --- addressed review comments. Moved logic to add relationship attributes to resolveReferencesPhase2() Bugs: ATLAS-1892 https://issues.apache.org/jira/browse/ATLAS-1892 Repository: atlas Description

Re: Review Request 60285: [ATLAS-1892]: Implement logic to create relationship attributes in AtlasEntityType

2017-06-22 Thread David Radley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60285/#review178673 --- distro/src/conf/policy-store.txt Line 9 (original), 9 (patched) <

Re: Review Request 60285: [ATLAS-1892]: Implement logic to create relationship attributes in AtlasEntityType

2017-06-22 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60285/#review178633 --- intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java Lin

<    1   2